[jira] [Commented] (HBASE-13437) ThriftServer leaks ZooKeeper connections
[ https://issues.apache.org/jira/browse/HBASE-13437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121659#comment-15121659 ] Khaled Hammouda commented on HBASE-13437: - For reference, this bug impacts the REST server as well, since it also uses the `ConnectionCache` class. > ThriftServer leaks ZooKeeper connections > > > Key: HBASE-13437 > URL: https://issues.apache.org/jira/browse/HBASE-13437 > Project: HBase > Issue Type: Bug > Components: Thrift >Affects Versions: 0.98.8 >Reporter: Winger Pun >Assignee: Albert Strasheim > Fix For: 2.0.0, 1.1.0, 0.98.13, 1.0.2 > > Attachments: HBASE-13437_1.patch, HBASE-13437_1.patch, > hbase-13437-fix.patch > > > HBase ThriftServer will cache Zookeeper connection in memory using > org.apache.hadoop.hbase.util.ConnectionCache. This class has a mechanism > called chore to clean up connections idle for too long(default is 10 min). > But method timedOut for testing whether idle exceed for maxIdleTime always > return false which leads to never release the Zookeeper connection. If we > send request to ThriftServer every maxIdleTime then ThriftServer will keep > thousands of Zookeeper Connection soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13437) ThriftServer leaks ZooKeeper connections
[
https://issues.apache.org/jira/browse/HBASE-13437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985473#comment-14985473
]
Pawel Kucharski commented on HBASE-13437:
-
workaround is to disable HTablePoll by
{code:xml}
hbase.thrift.htablepool.size.max
0
{code}
> ThriftServer leaks ZooKeeper connections
>
>
> Key: HBASE-13437
> URL: https://issues.apache.org/jira/browse/HBASE-13437
> Project: HBase
> Issue Type: Bug
> Components: Thrift
>Affects Versions: 0.98.8
>Reporter: Winger Pun
>Assignee: Albert Strasheim
> Fix For: 2.0.0, 1.1.0, 0.98.13, 1.0.2
>
> Attachments: HBASE-13437_1.patch, HBASE-13437_1.patch,
> hbase-13437-fix.patch
>
>
> HBase ThriftServer will cache Zookeeper connection in memory using
> org.apache.hadoop.hbase.util.ConnectionCache. This class has a mechanism
> called chore to clean up connections idle for too long(default is 10 min).
> But method timedOut for testing whether idle exceed for maxIdleTime always
> return false which leads to never release the Zookeeper connection. If we
> send request to ThriftServer every maxIdleTime then ThriftServer will keep
> thousands of Zookeeper Connection soon.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13437) ThriftServer leaks ZooKeeper connections
[
https://issues.apache.org/jira/browse/HBASE-13437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14606914#comment-14606914
]
Rocju commented on HBASE-13437:
---
after this bug fixed，find a new bug, thrift call will throws a exception：
org.apache.thrift.transport.TTransportException:
java.net.SocketTimeoutException: Read timed out
at
org.apache.thrift.transport.TIOStreamTransport.read(TIOStreamTransport.java:129)
at org.apache.thrift.transport.TTransport.readAll(TTransport.java:84)
at
org.apache.thrift.protocol.TBinaryProtocol.readAll(TBinaryProtocol.java:378)
at
org.apache.thrift.protocol.TBinaryProtocol.readI32(TBinaryProtocol.java:297)
at
org.apache.thrift.protocol.TBinaryProtocol.readMessageBegin(TBinaryProtocol.java:204)
at org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:69)
at
org.apache.hadoop.hbase.thrift2.generated.THBaseService$Client.recv_getScannerResults(THBaseService.java:703)
at
org.apache.hadoop.hbase.thrift2.generated.THBaseService$Client.getScannerResults(THBaseService.java:688)
at com.nl.test.ScanTask.run(ScanTask.java:47)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.net.SocketTimeoutException: Read timed out
at java.net.SocketInputStream.socketRead0(Native Method)
at java.net.SocketInputStream.read(SocketInputStream.java:152)
at java.net.SocketInputStream.read(SocketInputStream.java:122)
at java.io.BufferedInputStream.fill(BufferedInputStream.java:235)
at java.io.BufferedInputStream.read1(BufferedInputStream.java:275)
at java.io.BufferedInputStream.read(BufferedInputStream.java:334)
at
org.apache.thrift.transport.TIOStreamTransport.read(TIOStreamTransport.java:127)
... 9 more
=
I found org.apache.hadoop.hbase.util.ConnectionCache's InnerClass
connInfo.updateAccessTime() won't be called,
till maxIdleTime it close the connection,because of
org.apache.hadoop.hbase.client.HTablePool's method findOrCreateTable
will use its HTableInterface table = tables.get(tableName) and this won't renew
connection time.
so I modified org.apache.hadoop.hbase.client.HTablePool.java
private HTableInterface findOrCreateTable(String tableName) {
//HTableInterface table = tables.get(tableName);
//if (table == null) {
// table = createHTable(tableName);
//}
//return table;
return createHTable(tableName);
}
ThriftServer leaks ZooKeeper connections
Key: HBASE-13437
URL: https://issues.apache.org/jira/browse/HBASE-13437
Project: HBase
Issue Type: Bug
Components: Thrift
Affects Versions: 0.98.8
Reporter: Winger Pun
Assignee: Winger Pun
Fix For: 2.0.0, 1.1.0, 0.98.13, 1.0.2, 1.2.0
Attachments: HBASE-13437_1.patch, HBASE-13437_1.patch,
hbase-13437-fix.patch
HBase ThriftServer will cache Zookeeper connection in memory using
org.apache.hadoop.hbase.util.ConnectionCache. This class has a mechanism
called chore to clean up connections idle for too long(default is 10 min).
But method timedOut for testing whether idle exceed for maxIdleTime always
return false which leads to never release the Zookeeper connection. If we
send request to ThriftServer every maxIdleTime then ThriftServer will keep
thousands of Zookeeper Connection soon.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13437) ThriftServer leaks ZooKeeper connections
[ https://issues.apache.org/jira/browse/HBASE-13437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14507349#comment-14507349 ] Hudson commented on HBASE-13437: FAILURE: Integrated in HBase-1.2 #15 (See [https://builds.apache.org/job/HBase-1.2/15/]) HBASE-13437 ThriftServer leaks ZooKeeper connections (Winger Pun) (tedyu: rev 71b77555848445f0c6e8b26f4ea512302d41e469) * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestConnectionCache.java * hbase-server/src/main/java/org/apache/hadoop/hbase/util/ConnectionCache.java HBASE-13437 Addendum removes MiscTests (tedyu: rev 30880bca556542c1043fba5d81fc167cef2df270) * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestConnectionCache.java ThriftServer leaks ZooKeeper connections Key: HBASE-13437 URL: https://issues.apache.org/jira/browse/HBASE-13437 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.8 Reporter: Winger Pun Assignee: Winger Pun Fix For: 2.0.0, 1.1.0, 0.98.13, 1.0.2, 1.2.0 Attachments: HBASE-13437_1.patch, HBASE-13437_1.patch, hbase-13437-fix.patch HBase ThriftServer will cache Zookeeper connection in memory using org.apache.hadoop.hbase.util.ConnectionCache. This class has a mechanism called chore to clean up connections idle for too long(default is 10 min). But method timedOut for testing whether idle exceed for maxIdleTime always return false which leads to never release the Zookeeper connection. If we send request to ThriftServer every maxIdleTime then ThriftServer will keep thousands of Zookeeper Connection soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13437) ThriftServer leaks ZooKeeper connections
[ https://issues.apache.org/jira/browse/HBASE-13437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14507054#comment-14507054 ] Ted Yu commented on HBASE-13437: Lgtm ThriftServer leaks ZooKeeper connections Key: HBASE-13437 URL: https://issues.apache.org/jira/browse/HBASE-13437 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.8 Reporter: Winger Pun Attachments: HBASE-13437_1.patch, HBASE-13437_1.patch, hbase-13437-fix.patch HBase ThriftServer will cache Zookeeper connection in memory using org.apache.hadoop.hbase.util.ConnectionCache. This class has a mechanism called chore to clean up connections idle for too long(default is 10 min). But method timedOut for testing whether idle exceed for maxIdleTime always return false which leads to never release the Zookeeper connection. If we send request to ThriftServer every maxIdleTime then ThriftServer will keep thousands of Zookeeper Connection soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13437) ThriftServer leaks ZooKeeper connections
[ https://issues.apache.org/jira/browse/HBASE-13437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14507397#comment-14507397 ] Hudson commented on HBASE-13437: FAILURE: Integrated in HBase-1.0 #873 (See [https://builds.apache.org/job/HBase-1.0/873/]) HBASE-13437 ThriftServer leaks ZooKeeper connections (Winger Pun) (tedyu: rev f67b0beadd7b730d6265b13b7fe0462ece864fe8) * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestConnectionCache.java * hbase-server/src/main/java/org/apache/hadoop/hbase/util/ConnectionCache.java ThriftServer leaks ZooKeeper connections Key: HBASE-13437 URL: https://issues.apache.org/jira/browse/HBASE-13437 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.8 Reporter: Winger Pun Assignee: Winger Pun Fix For: 2.0.0, 1.1.0, 0.98.13, 1.0.2, 1.2.0 Attachments: HBASE-13437_1.patch, HBASE-13437_1.patch, hbase-13437-fix.patch HBase ThriftServer will cache Zookeeper connection in memory using org.apache.hadoop.hbase.util.ConnectionCache. This class has a mechanism called chore to clean up connections idle for too long(default is 10 min). But method timedOut for testing whether idle exceed for maxIdleTime always return false which leads to never release the Zookeeper connection. If we send request to ThriftServer every maxIdleTime then ThriftServer will keep thousands of Zookeeper Connection soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13437) ThriftServer leaks ZooKeeper connections
[ https://issues.apache.org/jira/browse/HBASE-13437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14506496#comment-14506496 ] Winger Pun commented on HBASE-13437: Done now. Just a simple test. Please suggest me if there are problems [~ndimiduk] [~tedyu] ThriftServer leaks ZooKeeper connections Key: HBASE-13437 URL: https://issues.apache.org/jira/browse/HBASE-13437 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.8 Reporter: Winger Pun Attachments: HBASE-13437_1.patch, hbase-13437-fix.patch HBase ThriftServer will cache Zookeeper connection in memory using org.apache.hadoop.hbase.util.ConnectionCache. This class has a mechanism called chore to clean up connections idle for too long(default is 10 min). But method timedOut for testing whether idle exceed for maxIdleTime always return false which leads to never release the Zookeeper connection. If we send request to ThriftServer every maxIdleTime then ThriftServer will keep thousands of Zookeeper Connection soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13437) ThriftServer leaks ZooKeeper connections
[
https://issues.apache.org/jira/browse/HBASE-13437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14506506#comment-14506506
]
Hadoop QA commented on HBASE-13437:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12727136/HBASE-13437_1.patch
against master branch at commit 23960207527b685609cd01259efbeb98f077b209.
ATTACHMENT ID: 12727136
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:red}-1 javac{color}. The patch appears to cause mvn compile goal to
fail with Hadoop version 2.4.1.
Compilation errors resume:
[ERROR] COMPILATION ERROR :
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestConnectionCache.java:[23,31]
cannot find symbol
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestConnectionCache.java:[28,11]
cannot find symbol
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.2:testCompile
(default-testCompile) on project hbase-server: Compilation failure: Compilation
failure:
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestConnectionCache.java:[23,31]
cannot find symbol
[ERROR] symbol: class MediumTests
[ERROR] location: package org.apache.hadoop.hbase
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestConnectionCache.java:[28,11]
cannot find symbol
[ERROR] symbol: class MediumTests
[ERROR] - [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn goals -rf :hbase-server
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13770//console
This message is automatically generated.
ThriftServer leaks ZooKeeper connections
Key: HBASE-13437
URL: https://issues.apache.org/jira/browse/HBASE-13437
Project: HBase
Issue Type: Bug
Components: Thrift
Affects Versions: 0.98.8
Reporter: Winger Pun
Attachments: HBASE-13437_1.patch, hbase-13437-fix.patch
HBase ThriftServer will cache Zookeeper connection in memory using
org.apache.hadoop.hbase.util.ConnectionCache. This class has a mechanism
called chore to clean up connections idle for too long(default is 10 min).
But method timedOut for testing whether idle exceed for maxIdleTime always
return false which leads to never release the Zookeeper connection. If we
send request to ThriftServer every maxIdleTime then ThriftServer will keep
thousands of Zookeeper Connection soon.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13437) ThriftServer leaks ZooKeeper connections
[ https://issues.apache.org/jira/browse/HBASE-13437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14507435#comment-14507435 ] Hudson commented on HBASE-13437: FAILURE: Integrated in HBase-TRUNK #6401 (See [https://builds.apache.org/job/HBase-TRUNK/6401/]) HBASE-13437 ThriftServer leaks ZooKeeper connections (Winger Pun) (tedyu: rev 2bf8cda4f68940909e9bcfdf8ae41cc751a49c7d) * hbase-server/src/main/java/org/apache/hadoop/hbase/util/ConnectionCache.java * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestConnectionCache.java ThriftServer leaks ZooKeeper connections Key: HBASE-13437 URL: https://issues.apache.org/jira/browse/HBASE-13437 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.8 Reporter: Winger Pun Assignee: Winger Pun Fix For: 2.0.0, 1.1.0, 0.98.13, 1.0.2, 1.2.0 Attachments: HBASE-13437_1.patch, HBASE-13437_1.patch, hbase-13437-fix.patch HBase ThriftServer will cache Zookeeper connection in memory using org.apache.hadoop.hbase.util.ConnectionCache. This class has a mechanism called chore to clean up connections idle for too long(default is 10 min). But method timedOut for testing whether idle exceed for maxIdleTime always return false which leads to never release the Zookeeper connection. If we send request to ThriftServer every maxIdleTime then ThriftServer will keep thousands of Zookeeper Connection soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13437) ThriftServer leaks ZooKeeper connections
[ https://issues.apache.org/jira/browse/HBASE-13437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14507485#comment-14507485 ] Hudson commented on HBASE-13437: SUCCESS: Integrated in HBase-1.1 #421 (See [https://builds.apache.org/job/HBase-1.1/421/]) HBASE-13437 ThriftServer leaks ZooKeeper connections (Winger Pun) (tedyu: rev 0f77121235f66cd9c1695086e566e2e66be7f6d5) * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestConnectionCache.java * hbase-server/src/main/java/org/apache/hadoop/hbase/util/ConnectionCache.java ThriftServer leaks ZooKeeper connections Key: HBASE-13437 URL: https://issues.apache.org/jira/browse/HBASE-13437 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.8 Reporter: Winger Pun Assignee: Winger Pun Fix For: 2.0.0, 1.1.0, 0.98.13, 1.0.2, 1.2.0 Attachments: HBASE-13437_1.patch, HBASE-13437_1.patch, hbase-13437-fix.patch HBase ThriftServer will cache Zookeeper connection in memory using org.apache.hadoop.hbase.util.ConnectionCache. This class has a mechanism called chore to clean up connections idle for too long(default is 10 min). But method timedOut for testing whether idle exceed for maxIdleTime always return false which leads to never release the Zookeeper connection. If we send request to ThriftServer every maxIdleTime then ThriftServer will keep thousands of Zookeeper Connection soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13437) ThriftServer leaks ZooKeeper connections
[ https://issues.apache.org/jira/browse/HBASE-13437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14507688#comment-14507688 ] Hudson commented on HBASE-13437: SUCCESS: Integrated in HBase-0.98 #958 (See [https://builds.apache.org/job/HBase-0.98/958/]) HBASE-13437 ThriftServer leaks ZooKeeper connections (Winger Pun) (tedyu: rev 5e38ffe6f43193e6cbb1211feff95c85d05d577c) * hbase-server/src/main/java/org/apache/hadoop/hbase/util/ConnectionCache.java * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestConnectionCache.java ThriftServer leaks ZooKeeper connections Key: HBASE-13437 URL: https://issues.apache.org/jira/browse/HBASE-13437 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.8 Reporter: Winger Pun Assignee: Winger Pun Fix For: 2.0.0, 1.1.0, 0.98.13, 1.0.2, 1.2.0 Attachments: HBASE-13437_1.patch, HBASE-13437_1.patch, hbase-13437-fix.patch HBase ThriftServer will cache Zookeeper connection in memory using org.apache.hadoop.hbase.util.ConnectionCache. This class has a mechanism called chore to clean up connections idle for too long(default is 10 min). But method timedOut for testing whether idle exceed for maxIdleTime always return false which leads to never release the Zookeeper connection. If we send request to ThriftServer every maxIdleTime then ThriftServer will keep thousands of Zookeeper Connection soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13437) ThriftServer leaks ZooKeeper connections
[ https://issues.apache.org/jira/browse/HBASE-13437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14507792#comment-14507792 ] Hudson commented on HBASE-13437: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #911 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/911/]) HBASE-13437 ThriftServer leaks ZooKeeper connections (Winger Pun) (tedyu: rev 5e38ffe6f43193e6cbb1211feff95c85d05d577c) * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestConnectionCache.java * hbase-server/src/main/java/org/apache/hadoop/hbase/util/ConnectionCache.java ThriftServer leaks ZooKeeper connections Key: HBASE-13437 URL: https://issues.apache.org/jira/browse/HBASE-13437 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.8 Reporter: Winger Pun Assignee: Winger Pun Fix For: 2.0.0, 1.1.0, 0.98.13, 1.0.2, 1.2.0 Attachments: HBASE-13437_1.patch, HBASE-13437_1.patch, hbase-13437-fix.patch HBase ThriftServer will cache Zookeeper connection in memory using org.apache.hadoop.hbase.util.ConnectionCache. This class has a mechanism called chore to clean up connections idle for too long(default is 10 min). But method timedOut for testing whether idle exceed for maxIdleTime always return false which leads to never release the Zookeeper connection. If we send request to ThriftServer every maxIdleTime then ThriftServer will keep thousands of Zookeeper Connection soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13437) ThriftServer leaks ZooKeeper connections
[
https://issues.apache.org/jira/browse/HBASE-13437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14506911#comment-14506911
]
Hadoop QA commented on HBASE-13437:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12727161/HBASE-13437_1.patch
against master branch at commit 23960207527b685609cd01259efbeb98f077b209.
ATTACHMENT ID: 12727161
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13772//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13772//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13772//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13772//console
This message is automatically generated.
ThriftServer leaks ZooKeeper connections
Key: HBASE-13437
URL: https://issues.apache.org/jira/browse/HBASE-13437
Project: HBase
Issue Type: Bug
Components: Thrift
Affects Versions: 0.98.8
Reporter: Winger Pun
Attachments: HBASE-13437_1.patch, HBASE-13437_1.patch,
hbase-13437-fix.patch
HBase ThriftServer will cache Zookeeper connection in memory using
org.apache.hadoop.hbase.util.ConnectionCache. This class has a mechanism
called chore to clean up connections idle for too long(default is 10 min).
But method timedOut for testing whether idle exceed for maxIdleTime always
return false which leads to never release the Zookeeper connection. If we
send request to ThriftServer every maxIdleTime then ThriftServer will keep
thousands of Zookeeper Connection soon.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13437) ThriftServer leaks ZooKeeper connections
[ https://issues.apache.org/jira/browse/HBASE-13437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14504584#comment-14504584 ] Winger Pun commented on HBASE-13437: Seems like no related test. I will have a try. ThriftServer leaks ZooKeeper connections Key: HBASE-13437 URL: https://issues.apache.org/jira/browse/HBASE-13437 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.8 Reporter: Winger Pun Attachments: hbase-13437-fix.patch HBase ThriftServer will cache Zookeeper connection in memory using org.apache.hadoop.hbase.util.ConnectionCache. This class has a mechanism called chore to clean up connections idle for too long(default is 10 min). But method timedOut for testing whether idle exceed for maxIdleTime always return false which leads to never release the Zookeeper connection. If we send request to ThriftServer every maxIdleTime then ThriftServer will keep thousands of Zookeeper Connection soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13437) ThriftServer leaks ZooKeeper connections
[ https://issues.apache.org/jira/browse/HBASE-13437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492742#comment-14492742 ] Nick Dimiduk commented on HBASE-13437: -- Okay, yes. Makes sense. +1. We have no test coverage for connection expiration? ThriftServer leaks ZooKeeper connections Key: HBASE-13437 URL: https://issues.apache.org/jira/browse/HBASE-13437 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.8 Reporter: Winger Pun Attachments: hbase-13437-fix.patch HBase ThriftServer will cache Zookeeper connection in memory using org.apache.hadoop.hbase.util.ConnectionCache. This class has a mechanism called chore to clean up connections idle for too long(default is 10 min). But method timedOut for testing whether idle exceed for maxIdleTime always return false which leads to never release the Zookeeper connection. If we send request to ThriftServer every maxIdleTime then ThriftServer will keep thousands of Zookeeper Connection soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13437) ThriftServer leaks ZooKeeper connections
[ https://issues.apache.org/jira/browse/HBASE-13437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487471#comment-14487471 ] Ted Yu commented on HBASE-13437: +1 ThriftServer leaks ZooKeeper connections Key: HBASE-13437 URL: https://issues.apache.org/jira/browse/HBASE-13437 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.8 Reporter: punwinger Attachments: hbase-13437-fix.patch HBase ThriftServer will cache Zookeeper connection in memory using org.apache.hadoop.hbase.util.ConnectionCache. This class has a mechanism called chore to clean up connections idle for too long(default is 10 min). But method timedOut for testing whether idle exceed for maxIdleTime always return false which leads to never release the Zookeeper connection. If we send request to ThriftServer every maxIdleTime then ThriftServer will keep thousands of Zookeeper Connection soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13437) ThriftServer leaks ZooKeeper connections
[ https://issues.apache.org/jira/browse/HBASE-13437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14488042#comment-14488042 ] Nick Dimiduk commented on HBASE-13437: -- I think this is no longer a problem in master and branch-1, as HTablePool has been replaced by the new Connection interface. However, it may still be there in branch-1.0. Mind having a look? ThriftServer leaks ZooKeeper connections Key: HBASE-13437 URL: https://issues.apache.org/jira/browse/HBASE-13437 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.8 Reporter: punwinger Attachments: hbase-13437-fix.patch HBase ThriftServer will cache Zookeeper connection in memory using org.apache.hadoop.hbase.util.ConnectionCache. This class has a mechanism called chore to clean up connections idle for too long(default is 10 min). But method timedOut for testing whether idle exceed for maxIdleTime always return false which leads to never release the Zookeeper connection. If we send request to ThriftServer every maxIdleTime then ThriftServer will keep thousands of Zookeeper Connection soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13437) ThriftServer leaks ZooKeeper connections
[
https://issues.apache.org/jira/browse/HBASE-13437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14486957#comment-14486957
]
Hadoop QA commented on HBASE-13437:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12724174/hbase-13437-fix.patch
against master branch at commit 80dbf06651e527ec0421ce51e4712ffb2f1d078b.
ATTACHMENT ID: 12724174
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13642//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13642//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13642//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13642//console
This message is automatically generated.
ThriftServer leaks ZooKeeper connections
Key: HBASE-13437
URL: https://issues.apache.org/jira/browse/HBASE-13437
Project: HBase
Issue Type: Bug
Components: Thrift
Affects Versions: 0.98.8
Reporter: punwinger
Attachments: hbase-13437-fix.patch
HBase ThriftServer will cache Zookeeper connection in memory using
org.apache.hadoop.hbase.util.ConnectionCache. This class has a mechanism
called chore to clean up connections idle for too long(default is 10 min).
But method timedOut for testing whether idle exceed for maxIdleTime always
return false which leads to never release the Zookeeper connection. If we
send request to ThriftServer every maxIdleTime then ThriftServer will keep
thousands of Zookeeper Connection soon.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
