[jira] [Commented] (HBASE-13738) Scan with RAW type for increment data insertions is displaying only latest two KV's

2015-07-18 Thread Lars Hofhansl (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-13738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632391#comment-14632391
 ] 

Lars Hofhansl commented on HBASE-13738:
---

Looks like we're fixing another problem now. The behavior described with 
VERSION=>1 is expected. If there's a problem and it keeps two version when it 
should only keep one, that's a different problem, and not a correctness issue.

Maybe the second issue is already fixed by HBASE-12931?

> Scan with RAW type for increment data insertions is displaying only latest 
> two KV's 
> 
>
> Key: HBASE-13738
> URL: https://issues.apache.org/jira/browse/HBASE-13738
> Project: HBase
>  Issue Type: Bug
>  Components: Scanners
> Environment: Suse 11 SP3
>Reporter: neha
>Assignee: Pankaj Kumar
>Priority: Minor
> Attachments: HBASE-13738.patch
>
>
> [Scenario for Reproducing ]:
> 1. Create an HBase table with single column family by keeping the versions=1 
> (DEFAULT)
> 2. Increment Insertion more than 2 times for the same row and for same 
> qualifier.
> 3. scan the table with raw= true and versions= 10  
> {code}
> scan 'tbl', {RAW => TRUE, VERSIONS => 10}
> {code}
> Expected Result:
> ===
> Raw scan should result in all the versions until the table flushed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-13738) Scan with RAW type for increment data insertions is displaying only latest two KV's

2015-07-14 Thread Pankaj Kumar (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-13738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14626801#comment-14626801
 ] 

Pankaj Kumar commented on HBASE-13738:
--

Sorry for late reply, I will provide another patch version soon addressing 
Anoop's feedback.

> Scan with RAW type for increment data insertions is displaying only latest 
> two KV's 
> 
>
> Key: HBASE-13738
> URL: https://issues.apache.org/jira/browse/HBASE-13738
> Project: HBase
>  Issue Type: Bug
>  Components: Scanners
> Environment: Suse 11 SP3
>Reporter: neha
>Assignee: Pankaj Kumar
>Priority: Minor
> Attachments: HBASE-13738.patch
>
>
> [Scenario for Reproducing ]:
> 1. Create an HBase table with single column family by keeping the versions=1 
> (DEFAULT)
> 2. Increment Insertion more than 2 times for the same row and for same 
> qualifier.
> 3. scan the table with raw= true and versions= 10  
> {code}
> scan 'tbl', {RAW => TRUE, VERSIONS => 10}
> {code}
> Expected Result:
> ===
> Raw scan should result in all the versions until the table flushed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-13738) Scan with RAW type for increment data insertions is displaying only latest two KV's

2015-07-13 Thread Andrew Purtell (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-13738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625140#comment-14625140
 ] 

Andrew Purtell commented on HBASE-13738:


Are you planning on putting up another version addressing Anoop's feedback 
[~pankaj_kumar]? 

> Scan with RAW type for increment data insertions is displaying only latest 
> two KV's 
> 
>
> Key: HBASE-13738
> URL: https://issues.apache.org/jira/browse/HBASE-13738
> Project: HBase
>  Issue Type: Bug
>  Components: Scanners
> Environment: Suse 11 SP3
>Reporter: neha
>Assignee: Pankaj Kumar
>Priority: Minor
> Attachments: HBASE-13738.patch
>
>
> [Scenario for Reproducing ]:
> 1. Create an HBase table with single column family by keeping the versions=1 
> (DEFAULT)
> 2. Increment Insertion more than 2 times for the same row and for same 
> qualifier.
> 3. scan the table with raw= true and versions= 10  
> {code}
> scan 'tbl', {RAW => TRUE, VERSIONS => 10}
> {code}
> Expected Result:
> ===
> Raw scan should result in all the versions until the table flushed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-13738) Scan with RAW type for increment data insertions is displaying only latest two KV's

2015-05-25 Thread Anoop Sam John (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-13738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14558126#comment-14558126
 ] 

Anoop Sam John commented on HBASE-13738:


Can not increment versionsVisible blindly.  Check whether this version is 
visible for the oldest scanner.  That is the readPoint passed. When cur cell 
seqId > smallestReadPoint, we can not increment the variable...
You can add a test with concurrent scan case also.  
Add increment
Open a scanner  but no next call
Add increment
Add increment
Add increment
Now next on scanner.
The later increments has to preserve the 1st cell for the old scanner.  
Close scanner
Now if u again add one more increment see how many cells.


> Scan with RAW type for increment data insertions is displaying only latest 
> two KV's 
> 
>
> Key: HBASE-13738
> URL: https://issues.apache.org/jira/browse/HBASE-13738
> Project: HBase
>  Issue Type: Bug
>  Components: Scanners
> Environment: Suse 11 SP3
>Reporter: neha
>Assignee: Pankaj Kumar
>Priority: Minor
> Attachments: HBASE-13738.patch
>
>
> [Scenario for Reproducing ]:
> 1. Create an HBase table with single column family by keeping the versions=1 
> (DEFAULT)
> 2. Increment Insertion more than 2 times for the same row and for same 
> qualifier.
> 3. scan the table with raw= true and versions= 10  
> {code}
> scan 'tbl', {RAW => TRUE, VERSIONS => 10}
> {code}
> Expected Result:
> ===
> Raw scan should result in all the versions until the table flushed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-13738) Scan with RAW type for increment data insertions is displaying only latest two KV's

2015-05-21 Thread Pankaj Kumar (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-13738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554190#comment-14554190
 ] 

Pankaj Kumar commented on HBASE-13738:
--

INCR old entries are getting removed from memstore when CF version is 1.

But cell upsert having some problem seems, it is retaining two entries always. 
Ideally it should be one.

{ code

  // versions visible to oldest scanner
int versionsVisible = 0;
while ( it.hasNext() ) {
  Cell cur = it.next();

  if (cell == cur) {
// ignore the one just put in
continue;
  }
  // check that this is the row and column we are interested in, otherwise 
bail
  if (CellUtil.matchingRow(cell, cur) && CellUtil.matchingQualifier(cell, 
cur)) {
// only remove Puts that concurrent scanners cannot possibly see
if (cur.getTypeByte() == KeyValue.Type.Put.getCode() &&
cur.getSequenceId() <= readpoint) {
  if (versionsVisible >= 1) {

 code }

> Scan with RAW type for increment data insertions is displaying only latest 
> two KV's 
> 
>
> Key: HBASE-13738
> URL: https://issues.apache.org/jira/browse/HBASE-13738
> Project: HBase
>  Issue Type: Bug
>  Components: Scanners
> Environment: Suse 11 SP3
>Reporter: neha
>Assignee: Pankaj Kumar
>Priority: Minor
>
> [Scenario for Reproducing ]:
> 1. Create an HBase table with single column family by keeping the versions=1 
> (DEFAULT)
> 2. Increment Insertion more than 2 times for the same row and for same 
> qualifier.
> 3. scan the table with raw= true and versions= 10  
> {code}
> scan 'tbl', {RAW => TRUE, VERSIONS => 10}
> {code}
> Expected Result:
> ===
> Raw scan should result in all the versions until the table flushed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-13738) Scan with RAW type for increment data insertions is displaying only latest two KV's

2015-05-21 Thread Anoop Sam John (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-13738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554141#comment-14554141
 ] 

Anoop Sam John commented on HBASE-13738:


bq. Create an HBase table with single column family by keeping the versions=1
If you would like to see old values (cells) by raw scan, then you have to keep 
the CF versions >1. If CF version is 1, we will upsert the new cell to memstore 
and so can remove old entries.  Pls test with >1 max_versions.

> Scan with RAW type for increment data insertions is displaying only latest 
> two KV's 
> 
>
> Key: HBASE-13738
> URL: https://issues.apache.org/jira/browse/HBASE-13738
> Project: HBase
>  Issue Type: Bug
>  Components: Scanners
> Environment: Suse 11 SP3
>Reporter: neha
>Assignee: Pankaj Kumar
>Priority: Minor
>
> [Scenario for Reproducing ]:
> 1. Create an HBase table with single column family by keeping the versions=1 
> (DEFAULT)
> 2. Increment Insertion more than 2 times for the same row and for same 
> qualifier.
> 3. scan the table with raw= true and versions= 10  
> {code}
> scan 'tbl', {RAW => TRUE, VERSIONS => 10}
> {code}
> Expected Result:
> ===
> Raw scan should result in all the versions until the table flushed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)