[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131136#comment-16131136 ] Hudson commented on HBASE-14135: FAILURE: Integrated in Jenkins build HBASE-14070.HLC #233 (See [https://builds.apache.org/job/HBASE-14070.HLC/233/]) HBASE-14135 Merge backup images (Vladimir Rodionov) (elserj: rev 05e6e5695089640006d06c2f74126b50a73363b7) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceRestoreJob.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManifest.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupSystemTable.java * (add) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/BackupMergeJob.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/util/BackupUtils.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/BackupRestoreFactory.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/HBackupFileSystem.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/BackupAdmin.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/BackupInfo.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestRepairAfterFailedDelete.java * (add) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceHFileSplitterJob.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupAdminImpl.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupCommands.java * (delete) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/HFileSplitterJob.java * (add) hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestIncrementalBackupMergeWithFailures.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/BackupDriver.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/impl/RestoreTablesClient.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java * (add) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceBackupMergeJob.java > HBase Backup/Restore Phase 3: Merge backup images > - > > Key: HBASE-14135 > URL: https://issues.apache.org/jira/browse/HBASE-14135 > Project: HBase > Issue Type: New Feature >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Critical > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-14135-v10.patch, HBASE-14135-v11.patch, > HBASE-14135-v3.patch, HBASE-14135-v5.patch, HBASE-14135-v6.patch, > HBASE-14135-v7.patch, HBASE-14135-v8.patch, HBASE-14135-v9.patch > > > User can merge incremental backup images into single incremental backup image. > # Merge supports only incremental images > # Merge supports only images for the same backup destinations > Command: > {code} > hbase backup merge image1,image2,..imageK > {code} > Example: > {code} > hbase backup merge backup_143126764557,backup_143126764456 > {code} > When operation is complete, only the most recent backup image will be kept > (in above example - backup_143126764557) as a merged backup image, all other > images will be deleted from both: file system and backup system tables, > corresponding backup manifest for the merged backup image will be updated to > remove dependencies from deleted images. Merged backup image will contains > all the data from original image and from deleted images. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125394#comment-16125394 ] Hudson commented on HBASE-14135: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3529 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3529/]) HBASE-14135 Merge backup images (Vladimir Rodionov) (elserj: rev 05e6e5695089640006d06c2f74126b50a73363b7) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupCommands.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/util/BackupUtils.java * (add) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceHFileSplitterJob.java * (add) hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestIncrementalBackupMergeWithFailures.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/BackupDriver.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/HBackupFileSystem.java * (add) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/BackupMergeJob.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/BackupInfo.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupSystemTable.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/BackupAdmin.java * (add) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceBackupMergeJob.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/impl/RestoreTablesClient.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/BackupRestoreFactory.java * (delete) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/HFileSplitterJob.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupAdminImpl.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestRepairAfterFailedDelete.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManifest.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceRestoreJob.java > HBase Backup/Restore Phase 3: Merge backup images > - > > Key: HBASE-14135 > URL: https://issues.apache.org/jira/browse/HBASE-14135 > Project: HBase > Issue Type: New Feature >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Critical > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-14135-v10.patch, HBASE-14135-v11.patch, > HBASE-14135-v3.patch, HBASE-14135-v5.patch, HBASE-14135-v6.patch, > HBASE-14135-v7.patch, HBASE-14135-v8.patch, HBASE-14135-v9.patch > > > User can merge incremental backup images into single incremental backup image. > # Merge supports only incremental images > # Merge supports only images for the same backup destinations > Command: > {code} > hbase backup merge image1,image2,..imageK > {code} > Example: > {code} > hbase backup merge backup_143126764557,backup_143126764456 > {code} > When operation is complete, only the most recent backup image will be kept > (in above example - backup_143126764557) as a merged backup image, all other > images will be deleted from both: file system and backup system tables, > corresponding backup manifest for the merged backup image will be updated to > remove dependencies from deleted images. Merged backup image will contains > all the data from original image and from deleted images. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125332#comment-16125332 ] Hudson commented on HBASE-14135: FAILURE: Integrated in Jenkins build HBase-2.0 #326 (See [https://builds.apache.org/job/HBase-2.0/326/]) HBASE-14135 Merge backup images (Vladimir Rodionov) (elserj: rev 35aa7aae3a0d269d809416f6ff24599517f5b44b) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/BackupRestoreFactory.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupCommands.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupAdminImpl.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/util/BackupUtils.java * (add) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceBackupMergeJob.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceRestoreJob.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/impl/RestoreTablesClient.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/HBackupFileSystem.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/BackupAdmin.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupSystemTable.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/BackupInfo.java * (add) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/BackupMergeJob.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManifest.java * (delete) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/HFileSplitterJob.java * (add) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceHFileSplitterJob.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestRepairAfterFailedDelete.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/BackupDriver.java * (add) hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestIncrementalBackupMergeWithFailures.java > HBase Backup/Restore Phase 3: Merge backup images > - > > Key: HBASE-14135 > URL: https://issues.apache.org/jira/browse/HBASE-14135 > Project: HBase > Issue Type: New Feature >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Critical > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-14135-v10.patch, HBASE-14135-v11.patch, > HBASE-14135-v3.patch, HBASE-14135-v5.patch, HBASE-14135-v6.patch, > HBASE-14135-v7.patch, HBASE-14135-v8.patch, HBASE-14135-v9.patch > > > User can merge incremental backup images into single incremental backup image. > # Merge supports only incremental images > # Merge supports only images for the same backup destinations > Command: > {code} > hbase backup merge image1,image2,..imageK > {code} > Example: > {code} > hbase backup merge backup_143126764557,backup_143126764456 > {code} > When operation is complete, only the most recent backup image will be kept > (in above example - backup_143126764557) as a merged backup image, all other > images will be deleted from both: file system and backup system tables, > corresponding backup manifest for the merged backup image will be updated to > remove dependencies from deleted images. Merged backup image will contains > all the data from original image and from deleted images. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124262#comment-16124262 ] Vladimir Rodionov commented on HBASE-14135: --- [~elserj], we had a clean QA run. > HBase Backup/Restore Phase 3: Merge backup images > - > > Key: HBASE-14135 > URL: https://issues.apache.org/jira/browse/HBASE-14135 > Project: HBase > Issue Type: New Feature >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Critical > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-14135-v10.patch, HBASE-14135-v11.patch, > HBASE-14135-v3.patch, HBASE-14135-v5.patch, HBASE-14135-v6.patch, > HBASE-14135-v7.patch, HBASE-14135-v8.patch, HBASE-14135-v9.patch > > > User can merge incremental backup images into single incremental backup image. > # Merge supports only incremental images > # Merge supports only images for the same backup destinations > Command: > {code} > hbase backup merge image1,image2,..imageK > {code} > Example: > {code} > hbase backup merge backup_143126764557,backup_143126764456 > {code} > When operation is complete, only the most recent backup image will be kept > (in above example - backup_143126764557) as a merged backup image, all other > images will be deleted from both: file system and backup system tables, > corresponding backup manifest for the merged backup image will be updated to > remove dependencies from deleted images. Merged backup image will contains > all the data from original image and from deleted images. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124250#comment-16124250 ] Hadoop QA commented on HBASE-14135: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 15s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 2 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 34s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 44s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 48s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 15s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 2s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 29s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 52s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 48s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 15s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 31m 51s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 4s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 28s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green}120m 55s{color} | {color:green} hbase-server in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 21s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}169m 55s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1 | | JIRA Issue | HBASE-14135 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12881536/HBASE-14135-v11.patch | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux e2ed64238b29 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 71a9a9a | | Default Java | 1.8.0_144 | | findbugs | v3.1.0-RC3 | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/8047/testReport/ | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/8047/console | | Powered by | Apache Yetus 0.4.0 http://yetus.apache.org | This message was automatically generated. > HBase Backup/Restore Phase 3: Merge backup images > - > > Key: HBASE-14135 > URL: https://issues.apache.org/jira/browse/HBASE-14135 > Project: HBase > Issue Type: New Feature >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Critical > Labels: backup > Fix For: 2.0.0 > > Atta
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16122921#comment-16122921 ] Hadoop QA commented on HBASE-14135: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 13m 7s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 2 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 54s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 40s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 48s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 15s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 59s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 30s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 48s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 32m 13s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 30s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red}108m 29s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 20s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}169m 59s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Timed out junit tests | org.apache.hadoop.hbase.master.procedure.TestDisableTableProcedure | | | org.apache.hadoop.hbase.master.procedure.TestModifyTableProcedure | | | org.apache.hadoop.hbase.master.procedure.TestCreateTableProcedure | | | org.apache.hadoop.hbase.master.procedure.TestEnableTableProcedure | | | org.apache.hadoop.hbase.master.procedure.TestDeleteTableProcedure | | | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId | | | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 | | | org.apache.hadoop.hbase.master.TestAssignmentManagerMetrics | | | org.apache.hadoop.hbase.master.TestMasterFailoverBalancerPersistence | | | org.apache.hadoop.hbase.master.cleaner.TestSnapshotFromMaster | | | org.apache.hadoop.hbase.master.TestTableStateManager | | | org.apache.hadoop.hbase.master.cleaner.TestReplicationZKNodeCleaner | | | org.apache.hadoop.hbase.master.assignment.TestAssignmentOnRSCrash | | | org.apache.hadoop.hbase.master.TestSplitLogManager | | | org.apache.hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS | | | org.apache.hadoop.hbase.master.balancer.TestFavoredNodeTableImport | | | org.apache.hadoop.hbase.master.TestRollingRestart | | | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer | | | org.apache.hadoop.hbase.master.TestDistributedLogSplitting | | | org.apache.hadoop.hbase.quotas.TestSpaceQuotas | | | org.apache.hadoop.hbase.master.TestMasterShutdown | | | or
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16122785#comment-16122785 ] Josh Elser commented on HBASE-14135: +1 once we get a proper QA back. bq. What is a blocker is moving backup out of hbase-server module, HBASE-17614 [~vrodionov], can you find the cycles to also take on this work in the near-term, please? > HBase Backup/Restore Phase 3: Merge backup images > - > > Key: HBASE-14135 > URL: https://issues.apache.org/jira/browse/HBASE-14135 > Project: HBase > Issue Type: New Feature >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Critical > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-14135-v10.patch, HBASE-14135-v3.patch, > HBASE-14135-v5.patch, HBASE-14135-v6.patch, HBASE-14135-v7.patch, > HBASE-14135-v8.patch, HBASE-14135-v9.patch > > > User can merge incremental backup images into single incremental backup image. > # Merge supports only incremental images > # Merge supports only images for the same backup destinations > Command: > {code} > hbase backup merge image1,image2,..imageK > {code} > Example: > {code} > hbase backup merge backup_143126764557,backup_143126764456 > {code} > When operation is complete, only the most recent backup image will be kept > (in above example - backup_143126764557) as a merged backup image, all other > images will be deleted from both: file system and backup system tables, > corresponding backup manifest for the merged backup image will be updated to > remove dependencies from deleted images. Merged backup image will contains > all the data from original image and from deleted images. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121939#comment-16121939 ] stack commented on HBASE-14135: --- This is not a blocker. What is a blocker is moving backup out of hbase-server module, HBASE-17614 > HBase Backup/Restore Phase 3: Merge backup images > - > > Key: HBASE-14135 > URL: https://issues.apache.org/jira/browse/HBASE-14135 > Project: HBase > Issue Type: New Feature >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Critical > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-14135-v10.patch, HBASE-14135-v3.patch, > HBASE-14135-v5.patch, HBASE-14135-v6.patch, HBASE-14135-v7.patch, > HBASE-14135-v8.patch, HBASE-14135-v9.patch > > > User can merge incremental backup images into single incremental backup image. > # Merge supports only incremental images > # Merge supports only images for the same backup destinations > Command: > {code} > hbase backup merge image1,image2,..imageK > {code} > Example: > {code} > hbase backup merge backup_143126764557,backup_143126764456 > {code} > When operation is complete, only the most recent backup image will be kept > (in above example - backup_143126764557) as a merged backup image, all other > images will be deleted from both: file system and backup system tables, > corresponding backup manifest for the merged backup image will be updated to > remove dependencies from deleted images. Merged backup image will contains > all the data from original image and from deleted images. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120817#comment-16120817 ] Hadoop QA commented on HBASE-14135: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 15s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 2 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 27s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 50s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 56s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 18s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 34s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 36s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 56s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 56s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 19s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 37m 42s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 46s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 36s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 76m 57s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 31s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}133m 56s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Timed out junit tests | org.apache.hadoop.hbase.regionserver.wal.TestSecureWALReplay | | | org.apache.hadoop.hbase.master.procedure.TestEnableTableProcedure | | | org.apache.hadoop.hbase.master.procedure.TestDeleteTableProcedure | | | org.apache.hadoop.hbase.master.procedure.TestModifyTableProcedure | | | org.apache.hadoop.hbase.regionserver.TestRowTooBig | | | org.apache.hadoop.hbase.regionserver.wal.TestAsyncWALReplay | | | org.apache.hadoop.hbase.regionserver.TestSplitLogWorker | | | org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy | | | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId | | | org.apache.hadoop.hbase.regionserver.wal.TestFSHLog | | | org.apache.hadoop.hbase.regionserver.TestCompaction | | | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 | | | org.apache.hadoop.hbase.regionserver.TestRemoveRegionMetrics | | | org.apache.hadoop.hbase.snapshot.TestSnapshotClientRetries | | | org.apache.hadoop.hbase.backup.TestRemoteBackup | | | org.apache.hadoop.hbase.master.TestAssignmentManagerMetrics | | | org.apache.hadoop.hbase.regionserver.TestTags | | | org.apache.hadoop.hbase.regionserver.TestTimestampFilterSeekHint | | | org.apache.hadoop.hbase.TestHBaseTestingUtility | | | org.apache.hadoop.hbase.TestFullLogReconstruction | | | org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint | | | org.apache.hadoop.hbase.wal.TestWALFilter
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120741#comment-16120741 ] Josh Elser commented on HBASE-14135: bq. We do have repair tool. It takes care of most failure scenarios (not all of them probably) and does housekeeping appropriately. Ah! I'm just showing some ignorance then. That sounds good to me. bq. v10. Some minor fixes based on a recent RB comments I will try to find some time to verify that, but I think this is essentially ready to go. > HBase Backup/Restore Phase 3: Merge backup images > - > > Key: HBASE-14135 > URL: https://issues.apache.org/jira/browse/HBASE-14135 > Project: HBase > Issue Type: New Feature >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-14135-v10.patch, HBASE-14135-v3.patch, > HBASE-14135-v5.patch, HBASE-14135-v6.patch, HBASE-14135-v7.patch, > HBASE-14135-v8.patch, HBASE-14135-v9.patch > > > User can merge incremental backup images into single incremental backup image. > # Merge supports only incremental images > # Merge supports only images for the same backup destinations > Command: > {code} > hbase backup merge image1,image2,..imageK > {code} > Example: > {code} > hbase backup merge backup_143126764557,backup_143126764456 > {code} > When operation is complete, only the most recent backup image will be kept > (in above example - backup_143126764557) as a merged backup image, all other > images will be deleted from both: file system and backup system tables, > corresponding backup manifest for the merged backup image will be updated to > remove dependencies from deleted images. Merged backup image will contains > all the data from original image and from deleted images. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120641#comment-16120641 ] Vladimir Rodionov commented on HBASE-14135: --- {quote} If it would be too difficult (which is what my gut-reaction was), a tool/utility to summarize these (expected) transient data (files in HDFS and hbase:backup records) would be really nice to have. If/when we would have to debug some kind of issue WRT backups or just HDFS use by hbase, such a tool could give us a definitive yes/no as to whether these transient files are to blame or not. {quote} We do have repair tool. It takes care of most failure scenarios (not all of them probably) and does housekeeping appropriately. > HBase Backup/Restore Phase 3: Merge backup images > - > > Key: HBASE-14135 > URL: https://issues.apache.org/jira/browse/HBASE-14135 > Project: HBase > Issue Type: New Feature >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-14135-v3.patch, HBASE-14135-v5.patch, > HBASE-14135-v6.patch, HBASE-14135-v7.patch, HBASE-14135-v8.patch, > HBASE-14135-v9.patch > > > User can merge incremental backup images into single incremental backup image. > # Merge supports only incremental images > # Merge supports only images for the same backup destinations > Command: > {code} > hbase backup merge image1,image2,..imageK > {code} > Example: > {code} > hbase backup merge backup_143126764557,backup_143126764456 > {code} > When operation is complete, only the most recent backup image will be kept > (in above example - backup_143126764557) as a merged backup image, all other > images will be deleted from both: file system and backup system tables, > corresponding backup manifest for the merged backup image will be updated to > remove dependencies from deleted images. Merged backup image will contains > all the data from original image and from deleted images. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113429#comment-16113429 ] Hadoop QA commented on HBASE-14135: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 19s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 2 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 48s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 58s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 4s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 24s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 35s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 43s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 6s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 52s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 52s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 58s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 43m 23s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 38s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 39s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red}151m 8s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 19s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}216m 45s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.master.TestMasterFailover | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1 | | JIRA Issue | HBASE-14135 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12880102/HBASE-14135-v9.patch | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 2ebc0117b574 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / fe890b7 | | Default Java | 1.8.0_131 | | findbugs | v3.1.0-RC3 | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/7912/artifact/patchprocess/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/7912/testReport/ | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/7912/console | | Powered by | Apache Yetus 0.4.0 http://yetus.apache.org | This message was automatically generated. > HBase Backup/Restore Phase 3: Merge backup images > - > > Key: HBASE-14135 > URL: https://issues.apache.org/jira/browse/HBASE-14135 > Project: HBase > Issue Type: N
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112993#comment-16112993 ] Josh Elser commented on HBASE-14135: bq. This is not only for backup, right, Josh Elser? Yeah, it definitely applies to all aspects of HBase. WALs is probably the most prevalent area I can think of. bq. Hard crash can happen during regular HBase operation, do we have any automation tools in Master to address potential issues? For WALs, I'm sure you're well aware of all of the CleanerChore logic we have surrounding WAL archival/removal that run in the Master. For these backup tools, it's a bit different since things are primarily being driven by the client instead of inside of HBase itself. I'm less asking the question "why wasn't server-side driven cleanup implemented" and more trying to ask the question "should we implement such cleanup?". I'd defer to you to say how easy such an automated (and safe) cleanup would be inside of the Master. If it would be too difficult (which is what my gut-reaction was), a tool/utility to summarize these (expected) transient data (files in HDFS and hbase:backup records) would be really nice to have. If/when we would have to debug some kind of issue WRT backups or just HDFS use by hbase, such a tool could give us a definitive yes/no as to whether these transient files are to blame or not. > HBase Backup/Restore Phase 3: Merge backup images > - > > Key: HBASE-14135 > URL: https://issues.apache.org/jira/browse/HBASE-14135 > Project: HBase > Issue Type: New Feature >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-14135-v3.patch, HBASE-14135-v5.patch, > HBASE-14135-v6.patch, HBASE-14135-v7.patch, HBASE-14135-v8.patch, > HBASE-14135-v9.patch > > > User can merge incremental backup images into single incremental backup image. > # Merge supports only incremental images > # Merge supports only images for the same backup destinations > Command: > {code} > hbase backup merge image1,image2,..imageK > {code} > Example: > {code} > hbase backup merge backup_143126764557,backup_143126764456 > {code} > When operation is complete, only the most recent backup image will be kept > (in above example - backup_143126764557) as a merged backup image, all other > images will be deleted from both: file system and backup system tables, > corresponding backup manifest for the merged backup image will be updated to > remove dependencies from deleted images. Merged backup image will contains > all the data from original image and from deleted images. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111735#comment-16111735 ] Vladimir Rodionov commented on HBASE-14135: --- {quote} It looks like there is the potential for files in HDFS to be orphaned (via a hard JVM crash where "deleteOnExit" wouldn't fire) and for entries in the hbase:backup table to be orphaned. The tooling to clean these up is great – should we have some automation inside of the Master to try to catch these scenarios and proactively clean it up for the user? {quote} This is not only for backup, right, [~elserj]? Hard crash can happen during regular HBase operation, do we have any automation tools in Master to address potential issues? > HBase Backup/Restore Phase 3: Merge backup images > - > > Key: HBASE-14135 > URL: https://issues.apache.org/jira/browse/HBASE-14135 > Project: HBase > Issue Type: New Feature >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-14135-v3.patch, HBASE-14135-v5.patch, > HBASE-14135-v6.patch, HBASE-14135-v7.patch, HBASE-14135-v8.patch, > HBASE-14135-v9.patch > > > User can merge incremental backup images into single incremental backup image. > # Merge supports only incremental images > # Merge supports only images for the same backup destinations > Command: > {code} > hbase backup merge image1,image2,..imageK > {code} > Example: > {code} > hbase backup merge backup_143126764557,backup_143126764456 > {code} > When operation is complete, only the most recent backup image will be kept > (in above example - backup_143126764557) as a merged backup image, all other > images will be deleted from both: file system and backup system tables, > corresponding backup manifest for the merged backup image will be updated to > remove dependencies from deleted images. Merged backup image will contains > all the data from original image and from deleted images. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096859#comment-16096859 ] Josh Elser commented on HBASE-14135: bq. We have repair tool, just in case if "client goes away" or some other disaster happens. This was one question I had on RB. Let me add to it since it was brought up here as well. It looks like there is the potential for files in HDFS to be orphaned (via a hard JVM crash where "deleteOnExit" wouldn't fire) and for entries in the hbase:backup table to be orphaned. The tooling to clean these up is great -- should we have some automation inside of the Master to try to catch these scenarios and proactively clean it up for the user? I am thinking about something very un-aggressive (e.g. cleaning up files in hdfs after many hours or days). WDYT? > HBase Backup/Restore Phase 3: Merge backup images > - > > Key: HBASE-14135 > URL: https://issues.apache.org/jira/browse/HBASE-14135 > Project: HBase > Issue Type: New Feature >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-14135-v3.patch, HBASE-14135-v5.patch, > HBASE-14135-v6.patch, HBASE-14135-v7.patch, HBASE-14135-v8.patch > > > User can merge incremental backup images into single incremental backup image. > # Merge supports only incremental images > # Merge supports only images for the same backup destinations > Command: > {code} > hbase backup merge image1,image2,..imageK > {code} > Example: > {code} > hbase backup merge backup_143126764557,backup_143126764456 > {code} > When operation is complete, only the most recent backup image will be kept > (in above example - backup_143126764557) as a merged backup image, all other > images will be deleted from both: file system and backup system tables, > corresponding backup manifest for the merged backup image will be updated to > remove dependencies from deleted images. Merged backup image will contains > all the data from original image and from deleted images. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16093981#comment-16093981 ] Vladimir Rodionov commented on HBASE-14135: --- Thanks, [~elserj] RB for your convenience: https://reviews.apache.org/r/60309/ > HBase Backup/Restore Phase 3: Merge backup images > - > > Key: HBASE-14135 > URL: https://issues.apache.org/jira/browse/HBASE-14135 > Project: HBase > Issue Type: New Feature >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-14135-v3.patch, HBASE-14135-v5.patch, > HBASE-14135-v6.patch, HBASE-14135-v7.patch, HBASE-14135-v8.patch > > > User can merge incremental backup images into single incremental backup image. > # Merge supports only incremental images > # Merge supports only images for the same backup destinations > Command: > {code} > hbase backup merge image1,image2,..imageK > {code} > Example: > {code} > hbase backup merge backup_143126764557,backup_143126764456 > {code} > When operation is complete, only the most recent backup image will be kept > (in above example - backup_143126764557) as a merged backup image, all other > images will be deleted from both: file system and backup system tables, > corresponding backup manifest for the merged backup image will be updated to > remove dependencies from deleted images. Merged backup image will contains > all the data from original image and from deleted images. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16093551#comment-16093551 ] Josh Elser commented on HBASE-14135: Unwinding my queue, [~vrodionov], but I'll try to get to this tmrw or Friday. > HBase Backup/Restore Phase 3: Merge backup images > - > > Key: HBASE-14135 > URL: https://issues.apache.org/jira/browse/HBASE-14135 > Project: HBase > Issue Type: New Feature >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-14135-v3.patch, HBASE-14135-v5.patch, > HBASE-14135-v6.patch, HBASE-14135-v7.patch, HBASE-14135-v8.patch > > > User can merge incremental backup images into single incremental backup image. > # Merge supports only incremental images > # Merge supports only images for the same backup destinations > Command: > {code} > hbase backup merge image1,image2,..imageK > {code} > Example: > {code} > hbase backup merge backup_143126764557,backup_143126764456 > {code} > When operation is complete, only the most recent backup image will be kept > (in above example - backup_143126764557) as a merged backup image, all other > images will be deleted from both: file system and backup system tables, > corresponding backup manifest for the merged backup image will be updated to > remove dependencies from deleted images. Merged backup image will contains > all the data from original image and from deleted images. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092480#comment-16092480 ] Hadoop QA commented on HBASE-14135: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 15s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 37s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 51s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 56s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 18s{color} | {color:green} master passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m 30s{color} | {color:red} hbase-server in master has 9 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 43s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 58s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 55s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 19s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 36m 52s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 52s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 35s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red}101m 38s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 27s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}158m 2s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.backup.TestIncrementalBackupMergeWithFailures | | Timed out junit tests | org.apache.hadoop.hbase.master.TestMasterMetricsWrapper | | | org.apache.hadoop.hbase.regionserver.wal.TestSecureWALReplay | | | org.apache.hadoop.hbase.master.procedure.TestDeleteTableProcedure | | | org.apache.hadoop.hbase.master.procedure.TestCreateTableProcedure | | | org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure | | | org.apache.hadoop.hbase.regionserver.TestRowTooBig | | | org.apache.hadoop.hbase.regionserver.TestSplitLogWorker | | | org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy | | | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId | | | org.apache.hadoop.hbase.regionserver.wal.TestFSHLog | | | org.apache.hadoop.hbase.regionserver.TestCompaction | | | org.apache.hadoop.hbase.trace.TestHTraceHooks | | | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 | | | org.apache.hadoop.hbase.regionserver.TestRegionServerMetrics | | | org.apache.hadoop.hbase.regionserver.TestRemoveRegionMetrics | | | org.apache.hadoop.hbase.master.assignment.TestAssignmentManager | | | org.apache.hadoop.hbase.master.TestAssignmentManagerMetrics | | | org.apache.hadoop.hbase.regionserver.TestTags | | | org.apache.hadoop.hbase.regionserver.TestTimestampFilterSeekHint | | | org.apache.hadoop.hbase.replication.regionserver.TestRegionRepl
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092191#comment-16092191 ] Hadoop QA commented on HBASE-14135: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 19s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 34s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 41s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 51s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 17s{color} | {color:green} master passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 45s{color} | {color:red} hbase-server in master has 9 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 28s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 47s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 40s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 40s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 50s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 15s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 30m 39s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 9s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 29s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 85m 40s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 31s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}132m 20s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Timed out junit tests | org.apache.hadoop.hbase.regionserver.wal.TestSecureWALReplay | | | org.apache.hadoop.hbase.master.procedure.TestDisableTableProcedure | | | org.apache.hadoop.hbase.coprocessor.TestRegionObserverInterface | | | org.apache.hadoop.hbase.regionserver.TestSplitLogWorker | | | org.apache.hadoop.hbase.regionserver.wal.TestAsyncWALReplay | | | org.apache.hadoop.hbase.regionserver.TestRowTooBig | | | org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure | | | org.apache.hadoop.hbase.master.procedure.TestEnableTableProcedure | | | org.apache.hadoop.hbase.master.procedure.TestCreateTableProcedure | | | org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy | | | org.apache.hadoop.hbase.mapreduce.TestTableInputFormat | | | org.apache.hadoop.hbase.mapreduce.TestHRegionPartitioner | | | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId | | | org.apache.hadoop.hbase.master.procedure.TestSafemodeBringsDownMaster | | | org.apache.hadoop.hbase.backup.TestRemoteBackup | | | org.apache.hadoop.hbase.snapshot.TestSnapshotClientRetries | | | org.apache.hadoop.hbase.regionserver.TestRemoveRegionMetrics | | | org.apache.hadoop.hbase.trace.TestHTraceHooks | | | org.apache.hadoop.hbase.TestHBaseTestingUtility | | | org.apache.hadoop.hbase.coprocessor.TestRegionObserverScannerOpenHook | | | org.apache.hadoop.hbase.regionserver.TestTags | | | org.apache.ha
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16081222#comment-16081222 ] Hadoop QA commented on HBASE-14135: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 14s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 36s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 44s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 53s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 15s{color} | {color:green} master passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m 6s{color} | {color:red} hbase-server in master has 10 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 29s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 46s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 38s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 38s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 47s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 15s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 28m 36s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha3. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 34s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 34s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green}116m 3s{color} | {color:green} hbase-server in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 16s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}161m 9s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:757bf37 | | JIRA Issue | HBASE-14135 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12876474/HBASE-14135-v6.patch | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux f01985501bd3 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 7d08c78 | | Default Java | 1.8.0_131 | | findbugs | v3.1.0-RC3 | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/7603/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/7603/testReport/ | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/7603/console | | Powered by | Apache Yetus 0.4.0 http://yetus.apache.org | This message was automatically generated. > HBase Backup/Restore Phase 3: Merge backup images > - > > Key: HBASE-14135 > URL: https://issues.apache.org/jira/browse/HBASE-14135 > Project: HBase > Issue Type: New Feature >Report
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080866#comment-16080866 ] Hadoop QA commented on HBASE-14135: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m 37s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:red}-1{color} | {color:red} @author {color} | {color:red} 0m 0s{color} | {color:red} The patch appears to contain 1 @author tags which the community has agreed to not allow in code contributions. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 25s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 51s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 59s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 21s{color} | {color:green} master passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m 30s{color} | {color:red} hbase-server in master has 10 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 33s{color} | {color:green} master passed {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 31s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 30s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 30s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 57s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 22s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m 34s{color} | {color:red} The patch causes 44 errors with Hadoop v2.6.1. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m 4s{color} | {color:red} The patch causes 44 errors with Hadoop v2.6.2. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m 31s{color} | {color:red} The patch causes 44 errors with Hadoop v2.6.3. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 5m 57s{color} | {color:red} The patch causes 44 errors with Hadoop v2.6.4. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 7m 23s{color} | {color:red} The patch causes 44 errors with Hadoop v2.6.5. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 8m 52s{color} | {color:red} The patch causes 44 errors with Hadoop v2.7.1. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 10m 22s{color} | {color:red} The patch causes 44 errors with Hadoop v2.7.2. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 11m 50s{color} | {color:red} The patch causes 44 errors with Hadoop v2.7.3. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 13m 13s{color} | {color:red} The patch causes 44 errors with Hadoop v3.0.0-alpha3. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 28s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 35s{color} | {color:red} hbase-server generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 28s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 8s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 30m 50s{color} | {color:black} {color} | \\ \\ ||
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079365#comment-16079365 ] Hadoop QA commented on HBASE-14135: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m 31s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 41s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 47s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 49s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 41s{color} | {color:green} master passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 7m 58s{color} | {color:red} hbase-server in master has 10 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 26s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 43s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 38s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 77m 18s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha3. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 8m 27s{color} | {color:red} hbase-server generated 3 new + 10 unchanged - 0 fixed = 13 total (was 10) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 23s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red}213m 38s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 23s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}332m 27s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:hbase-server | | | Nullcheck of conn at line 94 of value previously dereferenced in org.apache.hadoop.hbase.backup.mapreduce.MapReduceBackupMergeJob.run(String[]) At MapReduceBackupMergeJob.java:94 of value previously dereferenced in org.apache.hadoop.hbase.backup.mapreduce.MapReduceBackupMergeJob.run(String[]) At MapReduceBackupMergeJob.java:[line 94] | | | Exception is caught when Exception is not thrown in org.apache.hadoop.hbase.backup.mapreduce.MapReduceBackupMergeJob.run(String[]) At MapReduceBackupMergeJob.java:is not thrown in org.apache.hadoop.hbase.backup.mapreduce.MapReduceBackupMergeJob.run(String[]) At MapReduceBackupMergeJob.java:[line 161] | | | org.apache.hadoop.hbase.backup.util.BackupUtils.MILLISEC_IN_HOUR isn't final but should be At BackupUtils.java:be At BackupUtils.java:[line 73] | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:757bf37 | | JIRA Issue | HBASE-14135 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12874988/HBASE-14135-v3.patch | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 5db52a88b226 4.8.3-std-1 #1 SMP Fri Oct 21 11:15:43 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16077479#comment-16077479 ] Devaraj Das commented on HBASE-14135: - bq. Originally it was Service, then - Task, now is Job. What do you suggest, stack? How about _process_? Seems generic enough to capture MR Job among other possibilities.. Stack? > HBase Backup/Restore Phase 3: Merge backup images > - > > Key: HBASE-14135 > URL: https://issues.apache.org/jira/browse/HBASE-14135 > Project: HBase > Issue Type: New Feature >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: HBASE-7912 > > Attachments: HBASE-14135-v1.patch, HBASE-14135-v3.patch > > > User can merge incremental backup images into single incremental backup image. > # Merge supports only incremental images > # Merge supports only images for the same backup destinations > Command: > {code} > hbase backup merge image1,image2,..imageK > {code} > Example: > {code} > hbase backup merge backup_143126764557,backup_143126764456 > {code} > When operation is complete, only the most recent backup image will be kept > (in above example - backup_143126764557) as a merged backup image, all other > images will be deleted from both: file system and backup system tables, > corresponding backup manifest for the merged backup image will be updated to > remove dependencies from deleted images. Merged backup image will contains > all the data from original image and from deleted images. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16077412#comment-16077412 ] Vladimir Rodionov commented on HBASE-14135: --- {quote} And? What is the intent? To change them? Thanks. {quote} Yes. There is a JIRA HBASE-16458. {quote} You understand how someone might think 'MR' when they see 'Job'. Do you want to prevent any confusion? {quote} We have had already long discussion about this topic in the past. Should we start it again? Originally it was Service, then - Task, now is Job. What do you suggest, stack? {quote} And if the client goes away? They query to find running jobs? {quote} Job will fail, but next time (run), repair will be started automatically (mostly cleanup stuff). We have repair tool, just in case if "client goes away" or some other disaster happens. > HBase Backup/Restore Phase 3: Merge backup images > - > > Key: HBASE-14135 > URL: https://issues.apache.org/jira/browse/HBASE-14135 > Project: HBase > Issue Type: New Feature >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: HBASE-7912 > > Attachments: HBASE-14135-v1.patch, HBASE-14135-v3.patch > > > User can merge incremental backup images into single incremental backup image. > # Merge supports only incremental images > # Merge supports only images for the same backup destinations > Command: > {code} > hbase backup merge image1,image2,..imageK > {code} > Example: > {code} > hbase backup merge backup_143126764557,backup_143126764456 > {code} > When operation is complete, only the most recent backup image will be kept > (in above example - backup_143126764557) as a merged backup image, all other > images will be deleted from both: file system and backup system tables, > corresponding backup manifest for the merged backup image will be updated to > remove dependencies from deleted images. Merged backup image will contains > all the data from original image and from deleted images. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075853#comment-16075853 ] stack commented on HBASE-14135: --- bq. Long running tests are well-known issue for us. And? What is the intent? To change them? Thanks. bq. No it is just a generic Job which can be configured and executed You understand how someone might think 'MR' when they see 'Job'. Do you want to prevent any confusion? bq. Yes, it is synchronous. All operations are client-driven. And if the client goes away? They query to find running jobs? > HBase Backup/Restore Phase 3: Merge backup images > - > > Key: HBASE-14135 > URL: https://issues.apache.org/jira/browse/HBASE-14135 > Project: HBase > Issue Type: New Feature >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: HBASE-7912 > > Attachments: HBASE-14135-v1.patch, HBASE-14135-v3.patch > > > User can merge incremental backup images into single incremental backup image. > # Merge supports only incremental images > # Merge supports only images for the same backup destinations > Command: > {code} > hbase backup merge image1,image2,..imageK > {code} > Example: > {code} > hbase backup merge backup_143126764557,backup_143126764456 > {code} > When operation is complete, only the most recent backup image will be kept > (in above example - backup_143126764557) as a merged backup image, all other > images will be deleted from both: file system and backup system tables, > corresponding backup manifest for the merged backup image will be updated to > remove dependencies from deleted images. Merged backup image will contains > all the data from original image and from deleted images. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075705#comment-16075705 ] Vladimir Rodionov commented on HBASE-14135: --- {quote} Why is this backup stuff in hbase-server? BackupAdmin, BackupMergeJob, etc. and not in hbase-backup? This is phase 3. I'd have thought the backup module would be well along by now (Where do I go to read on current state of backup feature?) hbase-server is already overly fat with test suite that takes way too long, etc., etc. Lets not compound. {quote} We have separate JIRA for modularization : HBASE-17614. This is part Phase 3. I can start working on that once this one is committed. Long running tests are well-known issue for us. and again we have a separate JIRA for that as well. {quote} BackupMergeJob is a MR job or something? {quote} No it is just a generic Job which can be configured and executed {quote} mergeBackups doesn't return a future? It is synchronous? Doc says nothing on this. {quote} Yes, it is synchronous. All operations are client-driven. Formatting will be fixed in the next patch. > HBase Backup/Restore Phase 3: Merge backup images > - > > Key: HBASE-14135 > URL: https://issues.apache.org/jira/browse/HBASE-14135 > Project: HBase > Issue Type: New Feature >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: HBASE-7912 > > Attachments: HBASE-14135-v1.patch, HBASE-14135-v3.patch > > > User can merge incremental backup images into single incremental backup image. > # Merge supports only incremental images > # Merge supports only images for the same backup destinations > Command: > {code} > hbase backup merge image1,image2,..imageK > {code} > Example: > {code} > hbase backup merge backup_143126764557,backup_143126764456 > {code} > When operation is complete, only the most recent backup image will be kept > (in above example - backup_143126764557) as a merged backup image, all other > images will be deleted from both: file system and backup system tables, > corresponding backup manifest for the merged backup image will be updated to > remove dependencies from deleted images. Merged backup image will contains > all the data from original image and from deleted images. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067636#comment-16067636 ] stack commented on HBASE-14135: --- Why is this backup stuff in hbase-server? BackupAdmin, BackupMergeJob, etc. and not in hbase-backup? This is phase 3. I'd have thought the backup module would be well along by now (Where do I go to read on current state of backup feature?) hbase-server is already overly fat with test suite that takes way too long, etc., etc. Lets not compound. BackupMergeJob is a MR job or something? I presume that is what the 'Job' is about? There is nothing in class comment saying so.. .just generic Interface. Drop the 'Job' on classname if Interface has no requirement that implementation be a MR job (could it be done w/ Spark or in a simple process?) Why does the formatting in this patch differ from that of the rest of the code? (line between class comment or method comment and class opener or method... parens on own lines instead of at end of method spec line... Sometimes operators/parens have spaces around or before them, other times they do not... mergeBackups doesn't return a future? It is synchronous? Doc says nothing on this. > HBase Backup/Restore Phase 3: Merge backup images > - > > Key: HBASE-14135 > URL: https://issues.apache.org/jira/browse/HBASE-14135 > Project: HBase > Issue Type: New Feature >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: HBASE-7912 > > Attachments: HBASE-14135-v1.patch, HBASE-14135-v3.patch > > > User can merge incremental backup images into single incremental backup image. > # Merge supports only incremental images > # Merge supports only images for the same backup destinations > Command: > {code} > hbase backup merge image1,image2,..imageK > {code} > Example: > {code} > hbase backup merge backup_143126764557,backup_143126764456 > {code} > When operation is complete, only the most recent backup image will be kept > (in above example - backup_143126764557) as a merged backup image, all other > images will be deleted from both: file system and backup system tables, > corresponding backup manifest for the merged backup image will be updated to > remove dependencies from deleted images. Merged backup image will contains > all the data from original image and from deleted images. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059512#comment-16059512 ] Ted Yu commented on HBASE-14135: Since a lot of effort has gone into fault tolerance, I think each backup improvement should have builtin fault tolerance design. > HBase Backup/Restore Phase 3: Merge backup images > - > > Key: HBASE-14135 > URL: https://issues.apache.org/jira/browse/HBASE-14135 > Project: HBase > Issue Type: New Feature >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: HBASE-7912 > > Attachments: HBASE-14135-v1.patch > > > User can merge incremental backup images into single incremental backup image. > # Merge supports only incremental images > # Merge supports only images for the same backup destinations > Command: > {code} > hbase backup merge image1,image2,..imageK > {code} > Example: > {code} > hbase backup merge backup_143126764557,backup_143126764456 > {code} > When operation is complete, only the most recent backup image will be kept > (in above example - backup_143126764557) as a merged backup image, all other > images will be deleted from both: file system and backup system tables, > corresponding backup manifest for the merged backup image will be updated to > remove dependencies from deleted images. Merged backup image will contains > all the data from original image and from deleted images. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058292#comment-16058292 ] Vladimir Rodionov commented on HBASE-14135: --- RB: https://reviews.apache.org/r/60309/ > HBase Backup/Restore Phase 3: Merge backup images > - > > Key: HBASE-14135 > URL: https://issues.apache.org/jira/browse/HBASE-14135 > Project: HBase > Issue Type: New Feature >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: HBASE-7912 > > Attachments: HBASE-14135-v1.patch > > > User can merge incremental backup images into single incremental backup image. > # Merge supports only incremental images > # Merge supports only images for the same backup destinations > Command: > {code} > hbase backup merge image1,image2,..imageK > {code} > Example: > {code} > hbase backup merge backup_143126764557,backup_143126764456 > {code} > When operation is complete, only the most recent backup image will be kept > (in above example - backup_143126764557) as a merged backup image, all other > images will be deleted from both: file system and backup system tables, > corresponding backup manifest for the merged backup image will be updated to > remove dependencies from deleted images. Merged backup image will contains > all the data from original image and from deleted images. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058285#comment-16058285 ] Vladimir Rodionov commented on HBASE-14135: --- Patch v1 is attached cc: [~te...@apache.org] > HBase Backup/Restore Phase 3: Merge backup images > - > > Key: HBASE-14135 > URL: https://issues.apache.org/jira/browse/HBASE-14135 > Project: HBase > Issue Type: New Feature >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: HBASE-7912 > > Attachments: HBASE-14135-v1.patch > > > User can merge incremental backup images into single incremental backup image. > # Merge supports only incremental images > # Merge supports only images for the same backup destinations > Command: > {code} > hbase backup merge image1,image2,..imageK > {code} > Example: > {code} > hbase backup merge backup_143126764557,backup_143126764456 > {code} > When operation is complete, only the most recent backup image will be kept > (in above example - backup_143126764557) as a merged backup image, all other > images will be deleted from both: file system and backup system tables, > corresponding backup manifest for the merged backup image will be updated to > remove dependencies from deleted images. Merged backup image will contains > all the data from original image and from deleted images. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15510810#comment-15510810 ] Vladimir Rodionov commented on HBASE-14135: --- Two issues with incremental backup implementation: # Storage usage. WAL files are significantly larger than hfiles, especially when compression is enabled in hfiles # Restore operation time. The most significant is the first one. We can that storage reduction factor will be something between 3-5 once convert (merge) is implemented. Running conversion (merge) on a remote destination (cluster) is not feasible in many cases, so merge will require reading/writing data back and forth between source and destination. I will postpone this feature until filtering at the source during incremental backup is done. > HBase Backup/Restore Phase 3: Merge backup images > - > > Key: HBASE-14135 > URL: https://issues.apache.org/jira/browse/HBASE-14135 > Project: HBase > Issue Type: New Feature >Affects Versions: 2.0.0 >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Fix For: 2.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14135) HBase Backup/Restore Phase 3: Merge backup images
[ https://issues.apache.org/jira/browse/HBASE-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15200131#comment-15200131 ] Vladimir Rodionov commented on HBASE-14135: --- Moved to Phase 3. > HBase Backup/Restore Phase 3: Merge backup images > - > > Key: HBASE-14135 > URL: https://issues.apache.org/jira/browse/HBASE-14135 > Project: HBase > Issue Type: New Feature >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > -- This message was sent by Atlassian JIRA (v6.3.4#6332)