[jira] [Commented] (HBASE-14275) Backport to 0.98 HBASE-10785 Metas own location should be cached
[ https://issues.apache.org/jira/browse/HBASE-14275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14805157#comment-14805157 ] Andrew Purtell commented on HBASE-14275: Haven't had time to look. May just revert from the branch for now. Let me see if I can find some time to debug tomorrow. > Backport to 0.98 HBASE-10785 Metas own location should be cached > > > Key: HBASE-14275 > URL: https://issues.apache.org/jira/browse/HBASE-14275 > Project: HBase > Issue Type: Improvement >Reporter: Jerry He >Assignee: Jerry He > Fix For: 0.98.14 > > Attachments: HBASE-14275-0.98.patch > > > We've seen similar problem reported on 0.98. > It is good improvement to have. > This will cover HBASE-10785 and the a later HBASE-11332. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14275) Backport to 0.98 HBASE-10785 Metas own location should be cached
[
https://issues.apache.org/jira/browse/HBASE-14275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876415#comment-14876415
]
Andrew Purtell commented on HBASE-14275:
Go to this commit in 0.98, run TestAssignmentManagerOnCluster a few times, we
will eventually get stuck cleaning up at the end of
testSSHWhenDisablingTableRegionsInOpeningOrPendingOpenState.
The deleteTable at line 1581 of HTU called from line 678 of the test gets
stuck. This only happens when above in the test, at line 639, META is moved
when colocated with the test table on the victim regionserver. If I add this:
{noformat}
@@ -645,6 +645,8 @@ public class TestAssignmentManagerOnCluster {
.move(HRegionInfo.FIRST_META_REGIONINFO.getEncodedNameAsBytes(),
Bytes.toBytes(rs.getServerName().getServerName()));
am.waitForAssignment(HRegionInfo.FIRST_META_REGIONINFO);
+// Drop the cached location for META
+TEST_UTIL.getHBaseAdmin().getConnection().clearCaches(metaServerName);
}
am.regionOffline(hri);
{noformat}
then the test passes reliably.
Looks like when using MetaReader to wait until all regions are deleted,
deleteTable won't attempt to relocate META should its cached location be stale.
> Backport to 0.98 HBASE-10785 Metas own location should be cached
>
>
> Key: HBASE-14275
> URL: https://issues.apache.org/jira/browse/HBASE-14275
> Project: HBase
> Issue Type: Improvement
>Reporter: Jerry He
>Assignee: Jerry He
> Fix For: 0.98.14
>
> Attachments: HBASE-14275-0.98.patch
>
>
> We've seen similar problem reported on 0.98.
> It is good improvement to have.
> This will cover HBASE-10785 and the a later HBASE-11332.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14275) Backport to 0.98 HBASE-10785 Metas own location should be cached
[ https://issues.apache.org/jira/browse/HBASE-14275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14804711#comment-14804711 ] Andrew Purtell commented on HBASE-14275: Bisect brought me here again. > Backport to 0.98 HBASE-10785 Metas own location should be cached > > > Key: HBASE-14275 > URL: https://issues.apache.org/jira/browse/HBASE-14275 > Project: HBase > Issue Type: Improvement >Reporter: Jerry He >Assignee: Jerry He > Fix For: 0.98.14 > > Attachments: HBASE-14275-0.98.patch > > > We've seen similar problem reported on 0.98. > It is good improvement to have. > This will cover HBASE-10785 and the a later HBASE-11332. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14275) Backport to 0.98 HBASE-10785 Metas own location should be cached
[ https://issues.apache.org/jira/browse/HBASE-14275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14804912#comment-14804912 ] Jerry He commented on HBASE-14275: -- Any interesting finding? > Backport to 0.98 HBASE-10785 Metas own location should be cached > > > Key: HBASE-14275 > URL: https://issues.apache.org/jira/browse/HBASE-14275 > Project: HBase > Issue Type: Improvement >Reporter: Jerry He >Assignee: Jerry He > Fix For: 0.98.14 > > Attachments: HBASE-14275-0.98.patch > > > We've seen similar problem reported on 0.98. > It is good improvement to have. > This will cover HBASE-10785 and the a later HBASE-11332. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14275) Backport to 0.98 HBASE-10785 Metas own location should be cached
[ https://issues.apache.org/jira/browse/HBASE-14275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14711493#comment-14711493 ] Jerry He commented on HBASE-14275: -- I have run YCSB workloads with the patch in hbase client binding. No issues. From Enis's last comment in HBASE-10785, he has had it available in branches including 0.98 internally for a while. Will commit shortly. Thanks for the review. Backport to 0.98 HBASE-10785 Metas own location should be cached Key: HBASE-14275 URL: https://issues.apache.org/jira/browse/HBASE-14275 Project: HBase Issue Type: Improvement Reporter: Jerry He Assignee: Jerry He Fix For: 0.98.15 Attachments: HBASE-14275-0.98.patch We've seen similar problem reported on 0.98. It is good improvement to have. This will cover HBASE-10785 and the a later HBASE-11332. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14275) Backport to 0.98 HBASE-10785 Metas own location should be cached
[ https://issues.apache.org/jira/browse/HBASE-14275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712086#comment-14712086 ] Hudson commented on HBASE-14275: SUCCESS: Integrated in HBase-0.98 #1099 (See [https://builds.apache.org/job/HBase-0.98/1099/]) HBASE-14275 Backport to 0.98 HBASE-10785 Metas own location should be cached (jerryjch: rev c0abda2e110772c58b5520789ffd53f287b399cf) * hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java Backport to 0.98 HBASE-10785 Metas own location should be cached Key: HBASE-14275 URL: https://issues.apache.org/jira/browse/HBASE-14275 Project: HBase Issue Type: Improvement Reporter: Jerry He Assignee: Jerry He Fix For: 0.98.15 Attachments: HBASE-14275-0.98.patch We've seen similar problem reported on 0.98. It is good improvement to have. This will cover HBASE-10785 and the a later HBASE-11332. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14275) Backport to 0.98 HBASE-10785 Metas own location should be cached
[ https://issues.apache.org/jira/browse/HBASE-14275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712173#comment-14712173 ] Hudson commented on HBASE-14275: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1053 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1053/]) HBASE-14275 Backport to 0.98 HBASE-10785 Metas own location should be cached (jerryjch: rev c0abda2e110772c58b5520789ffd53f287b399cf) * hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java Backport to 0.98 HBASE-10785 Metas own location should be cached Key: HBASE-14275 URL: https://issues.apache.org/jira/browse/HBASE-14275 Project: HBase Issue Type: Improvement Reporter: Jerry He Assignee: Jerry He Fix For: 0.98.15 Attachments: HBASE-14275-0.98.patch We've seen similar problem reported on 0.98. It is good improvement to have. This will cover HBASE-10785 and the a later HBASE-11332. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14275) Backport to 0.98 HBASE-10785 Metas own location should be cached
[ https://issues.apache.org/jira/browse/HBASE-14275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14710388#comment-14710388 ] Andrew Purtell commented on HBASE-14275: +1 Backport to 0.98 HBASE-10785 Metas own location should be cached Key: HBASE-14275 URL: https://issues.apache.org/jira/browse/HBASE-14275 Project: HBase Issue Type: Improvement Reporter: Jerry He Assignee: Jerry He Fix For: 0.98.15 Attachments: HBASE-14275-0.98.patch We've seen similar problem reported on 0.98. It is good improvement to have. This will cover HBASE-10785 and the a later HBASE-11332. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14275) Backport to 0.98 HBASE-10785 Metas own location should be cached
[
https://issues.apache.org/jira/browse/HBASE-14275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14710553#comment-14710553
]
Hadoop QA commented on HBASE-14275:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12751849/HBASE-14275-0.98.patch
against 0.98 branch at commit d0873f5a8cc060adbc5a1ae0ed52b84a8942a868.
ATTACHMENT ID: 12751849
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
23 warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15232//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15232//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15232//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15232//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15232//console
This message is automatically generated.
Backport to 0.98 HBASE-10785 Metas own location should be cached
Key: HBASE-14275
URL: https://issues.apache.org/jira/browse/HBASE-14275
Project: HBase
Issue Type: Improvement
Reporter: Jerry He
Assignee: Jerry He
Fix For: 0.98.15
Attachments: HBASE-14275-0.98.patch
We've seen similar problem reported on 0.98.
It is good improvement to have.
This will cover HBASE-10785 and the a later HBASE-11332.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14275) Backport to 0.98 HBASE-10785 Metas own location should be cached
[ https://issues.apache.org/jira/browse/HBASE-14275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705722#comment-14705722 ] Jerry He commented on HBASE-14275: -- It is not a trivial backport since the HConnectionManager had a major refactoring. But it is still a simple backport. [~enis], Can you check the correctness of the backport? [~apurtell], Do you think it is ok for 0.98? Backport to 0.98 HBASE-10785 Metas own location should be cached Key: HBASE-14275 URL: https://issues.apache.org/jira/browse/HBASE-14275 Project: HBase Issue Type: Improvement Reporter: Jerry He Attachments: HBASE-14275-0.98.patch We've seen similar problem reported on 0.98. It is good improvement to have. This will cover HBASE-10785 and the a later HBASE-11332. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14275) Backport to 0.98 HBASE-10785 Metas own location should be cached
[ https://issues.apache.org/jira/browse/HBASE-14275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705854#comment-14705854 ] Enis Soztutar commented on HBASE-14275: --- Yes, the addendum I was talking about was indeed HBASE-11332. Patch looks good to me. Backport to 0.98 HBASE-10785 Metas own location should be cached Key: HBASE-14275 URL: https://issues.apache.org/jira/browse/HBASE-14275 Project: HBase Issue Type: Improvement Reporter: Jerry He Assignee: Jerry He Attachments: HBASE-14275-0.98.patch We've seen similar problem reported on 0.98. It is good improvement to have. This will cover HBASE-10785 and the a later HBASE-11332. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
