[jira] [Commented] (HBASE-14278) Fix NPE that is showing up since HBASE-14274 went in

2015-09-17 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791628#comment-14791628
 ] 

Hudson commented on HBASE-14278:


FAILURE: Integrated in HBase-TRUNK #6817 (See 
[https://builds.apache.org/job/HBase-TRUNK/6817/])
HBASE-14278 Fix NPE that is showing up since HBASE-14274 went in (eclark: rev 
c1ac4bb8601f88eb3fe246eb62c3f40e95faf93d)
* 
hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java
* 
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java
* 
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionAggregateSourceImpl.java
* 
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/metrics2/impl/JmxCacheBuster.java
* 
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java


> Fix NPE that is showing up since HBASE-14274 went in
> 
>
> Key: HBASE-14278
> URL: https://issues.apache.org/jira/browse/HBASE-14278
> Project: HBase
>  Issue Type: Sub-task
>  Components: test
>Affects Versions: 2.0.0, 1.2.0, 1.3.0
>Reporter: stack
>Assignee: Elliott Clark
> Fix For: 2.0.0, 1.2.0, 1.3.0
>
> Attachments: HBASE-14278-v1.patch, HBASE-14278-v2.patch, 
> HBASE-14278-v3.patch, HBASE-14278-v4.patch, HBASE-14278-v5.patch, 
> HBASE-14278.patch
>
>
> Saw this in TestDistributedLogSplitting after HBASE-14274 was applied.
> {code}
> 119113 2015-08-20 15:31:10,704 WARN  [HBase-Metrics2-1] 
> impl.MetricsConfig(124): Cannot locate configuration: tried 
> hadoop-metrics2-hbase.properties,hadoop-metrics2.properties
> 119114 2015-08-20 15:31:10,710 ERROR [HBase-Metrics2-1] 
> lib.MethodMetric$2(118): Error invoking method getBlocksTotal
> 119115 java.lang.reflect.InvocationTargetException
> 119116 ›   at sun.reflect.GeneratedMethodAccessor72.invoke(Unknown Source)
> 119117 ›   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 119118 ›   at java.lang.reflect.Method.invoke(Method.java:606)
> 119119 ›   at 
> org.apache.hadoop.metrics2.lib.MethodMetric$2.snapshot(MethodMetric.java:111)
> 119120 ›   at 
> org.apache.hadoop.metrics2.lib.MethodMetric.snapshot(MethodMetric.java:144)
> 119121 ›   at 
> org.apache.hadoop.metrics2.lib.MetricsRegistry.snapshot(MetricsRegistry.java:387)
> 119122 ›   at 
> org.apache.hadoop.metrics2.lib.MetricsSourceBuilder$1.getMetrics(MetricsSourceBuilder.java:79)
> 119123 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMetrics(MetricsSourceAdapter.java:195)
> 119124 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.updateJmxCache(MetricsSourceAdapter.java:172)
> 119125 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMBeanInfo(MetricsSourceAdapter.java:151)
> 119126 ›   at 
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getNewMBeanClassName(DefaultMBeanServerInterceptor.java:333)
> 119127 ›   at 
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:319)
> 119128 ›   at 
> com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:522)
> 119129 ›   at org.apache.hadoop.metrics2.util.MBeans.register(MBeans.java:57)
> 119130 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.startMBeans(MetricsSourceAdapter.java:221)
> 119131 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.start(MetricsSourceAdapter.java:96)
> 119132 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.registerSource(MetricsSystemImpl.java:245)
> 119133 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl$1.postStart(MetricsSystemImpl.java:229)
> 119134 ›   at sun.reflect.GeneratedMethodAccessor50.invoke(Unknown Source)
> 119135 ›   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 119136 ›   at java.lang.reflect.Method.invoke(Method.java:606)
> 119137 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl$3.invoke(MetricsSystemImpl.java:290)
> 119138 ›   at com.sun.proxy.$Proxy13.postStart(Unknown Source)
> 119139 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:185)
> 119140 ›   at 
> org.apache.hadoop.metrics2.impl.JmxCacheBuster$JmxCacheBusterRunnable.run(JmxCacheBuster.java:81)
> 119141 ›   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> 119142 ›   at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> 119143 ›   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
> 119144 ›   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
> 

[jira] [Commented] (HBASE-14278) Fix NPE that is showing up since HBASE-14274 went in

2015-09-16 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14747242#comment-14747242
 ] 

Hadoop QA commented on HBASE-14278:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12756184/HBASE-14278-v5.patch
  against master branch at commit d2e338181800ae3cef55ddca491901b65259dc7f.
  ATTACHMENT ID: 12756184

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 4 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15617//testReport/
Release Findbugs (version 2.0.3)warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15617//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15617//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15617//console

This message is automatically generated.

> Fix NPE that is showing up since HBASE-14274 went in
> 
>
> Key: HBASE-14278
> URL: https://issues.apache.org/jira/browse/HBASE-14278
> Project: HBase
>  Issue Type: Sub-task
>  Components: test
>Affects Versions: 2.0.0, 1.2.0, 1.3.0
>Reporter: stack
>Assignee: Elliott Clark
> Fix For: 2.0.0, 1.2.0, 1.3.0
>
> Attachments: HBASE-14278-v1.patch, HBASE-14278-v2.patch, 
> HBASE-14278-v3.patch, HBASE-14278-v4.patch, HBASE-14278-v5.patch, 
> HBASE-14278.patch
>
>
> Saw this in TestDistributedLogSplitting after HBASE-14274 was applied.
> {code}
> 119113 2015-08-20 15:31:10,704 WARN  [HBase-Metrics2-1] 
> impl.MetricsConfig(124): Cannot locate configuration: tried 
> hadoop-metrics2-hbase.properties,hadoop-metrics2.properties
> 119114 2015-08-20 15:31:10,710 ERROR [HBase-Metrics2-1] 
> lib.MethodMetric$2(118): Error invoking method getBlocksTotal
> 119115 java.lang.reflect.InvocationTargetException
> 119116 ›   at sun.reflect.GeneratedMethodAccessor72.invoke(Unknown Source)
> 119117 ›   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 119118 ›   at java.lang.reflect.Method.invoke(Method.java:606)
> 119119 ›   at 
> org.apache.hadoop.metrics2.lib.MethodMetric$2.snapshot(MethodMetric.java:111)
> 119120 ›   at 
> org.apache.hadoop.metrics2.lib.MethodMetric.snapshot(MethodMetric.java:144)
> 119121 ›   at 
> org.apache.hadoop.metrics2.lib.MetricsRegistry.snapshot(MetricsRegistry.java:387)
> 119122 ›   at 
> org.apache.hadoop.metrics2.lib.MetricsSourceBuilder$1.getMetrics(MetricsSourceBuilder.java:79)
> 119123 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMetrics(MetricsSourceAdapter.java:195)
> 119124 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.updateJmxCache(MetricsSourceAdapter.java:172)
> 119125 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMBeanInfo(MetricsSourceAdapter.java:151)
> 119126 ›   at 
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getNewMBeanClassName(DefaultMBeanServerInterceptor.java:333)
> 119127 ›   at 
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:319)
> 119128 ›   at 
> com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:522)
> 119129 ›   at org.apache.hadoop.metrics2.util.MBeans.register(MBeans.java:57)
> 119130 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.startMBeans(MetricsSourceAdapter.java:221)
> 119131 ›   at 
> 

[jira] [Commented] (HBASE-14278) Fix NPE that is showing up since HBASE-14274 went in

2015-09-16 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14790710#comment-14790710
 ] 

stack commented on HBASE-14278:
---

kalashnikov:hbase.git.commit stack$ python dev-support/findHangingTests.py  
https://builds.apache.org/job/PreCommit-HBASE-Build/15617/consoleText
Fetching the console output from the URL
Printing hanging tests
Printing Failing tests
Failing test : org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Failing test : org.apache.hadoop.hbase.client.TestReplicaWithCluster

TestReplicaWithCluster I see is showing up as a hang. I'll take a look. The 
other failure loooks unrelated. I'll look at that too.

+1 on patch. This emission is ugly currently spewing all over test runs. Thanks 
[~eclark]

On commit, shove e.getMessage on the end of this log just so we can be sure it 
that old faithful, the NPE: 

76  } catch (Exception e) {
77// Ignored. If this errors out it means that someone is double
78// closing the region source and the region is already nulled out.
79LOG.info("Error trying to remove " + toRemove + " from " + 
this.getClass().getSimpleName());
80  }


> Fix NPE that is showing up since HBASE-14274 went in
> 
>
> Key: HBASE-14278
> URL: https://issues.apache.org/jira/browse/HBASE-14278
> Project: HBase
>  Issue Type: Sub-task
>  Components: test
>Affects Versions: 2.0.0, 1.2.0, 1.3.0
>Reporter: stack
>Assignee: Elliott Clark
> Fix For: 2.0.0, 1.2.0, 1.3.0
>
> Attachments: HBASE-14278-v1.patch, HBASE-14278-v2.patch, 
> HBASE-14278-v3.patch, HBASE-14278-v4.patch, HBASE-14278-v5.patch, 
> HBASE-14278.patch
>
>
> Saw this in TestDistributedLogSplitting after HBASE-14274 was applied.
> {code}
> 119113 2015-08-20 15:31:10,704 WARN  [HBase-Metrics2-1] 
> impl.MetricsConfig(124): Cannot locate configuration: tried 
> hadoop-metrics2-hbase.properties,hadoop-metrics2.properties
> 119114 2015-08-20 15:31:10,710 ERROR [HBase-Metrics2-1] 
> lib.MethodMetric$2(118): Error invoking method getBlocksTotal
> 119115 java.lang.reflect.InvocationTargetException
> 119116 ›   at sun.reflect.GeneratedMethodAccessor72.invoke(Unknown Source)
> 119117 ›   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 119118 ›   at java.lang.reflect.Method.invoke(Method.java:606)
> 119119 ›   at 
> org.apache.hadoop.metrics2.lib.MethodMetric$2.snapshot(MethodMetric.java:111)
> 119120 ›   at 
> org.apache.hadoop.metrics2.lib.MethodMetric.snapshot(MethodMetric.java:144)
> 119121 ›   at 
> org.apache.hadoop.metrics2.lib.MetricsRegistry.snapshot(MetricsRegistry.java:387)
> 119122 ›   at 
> org.apache.hadoop.metrics2.lib.MetricsSourceBuilder$1.getMetrics(MetricsSourceBuilder.java:79)
> 119123 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMetrics(MetricsSourceAdapter.java:195)
> 119124 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.updateJmxCache(MetricsSourceAdapter.java:172)
> 119125 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMBeanInfo(MetricsSourceAdapter.java:151)
> 119126 ›   at 
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getNewMBeanClassName(DefaultMBeanServerInterceptor.java:333)
> 119127 ›   at 
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:319)
> 119128 ›   at 
> com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:522)
> 119129 ›   at org.apache.hadoop.metrics2.util.MBeans.register(MBeans.java:57)
> 119130 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.startMBeans(MetricsSourceAdapter.java:221)
> 119131 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.start(MetricsSourceAdapter.java:96)
> 119132 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.registerSource(MetricsSystemImpl.java:245)
> 119133 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl$1.postStart(MetricsSystemImpl.java:229)
> 119134 ›   at sun.reflect.GeneratedMethodAccessor50.invoke(Unknown Source)
> 119135 ›   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 119136 ›   at java.lang.reflect.Method.invoke(Method.java:606)
> 119137 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl$3.invoke(MetricsSystemImpl.java:290)
> 119138 ›   at com.sun.proxy.$Proxy13.postStart(Unknown Source)
> 119139 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:185)
> 119140 ›   at 
> org.apache.hadoop.metrics2.impl.JmxCacheBuster$JmxCacheBusterRunnable.run(JmxCacheBuster.java:81)
> 119141 ›   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> 119142 ›   at 

[jira] [Commented] (HBASE-14278) Fix NPE that is showing up since HBASE-14274 went in

2015-09-16 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791448#comment-14791448
 ] 

Hudson commented on HBASE-14278:


SUCCESS: Integrated in HBase-1.3-IT #162 (See 
[https://builds.apache.org/job/HBase-1.3-IT/162/])
HBASE-14278 Fix NPE that is showing up since HBASE-14274 went in (eclark: rev 
2029e851827fa1bf59436c7baa1971b52ac5833e)
* 
hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java
* 
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java
* 
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java
* 
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/metrics2/impl/JmxCacheBuster.java
* 
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionAggregateSourceImpl.java


> Fix NPE that is showing up since HBASE-14274 went in
> 
>
> Key: HBASE-14278
> URL: https://issues.apache.org/jira/browse/HBASE-14278
> Project: HBase
>  Issue Type: Sub-task
>  Components: test
>Affects Versions: 2.0.0, 1.2.0, 1.3.0
>Reporter: stack
>Assignee: Elliott Clark
> Fix For: 2.0.0, 1.2.0, 1.3.0
>
> Attachments: HBASE-14278-v1.patch, HBASE-14278-v2.patch, 
> HBASE-14278-v3.patch, HBASE-14278-v4.patch, HBASE-14278-v5.patch, 
> HBASE-14278.patch
>
>
> Saw this in TestDistributedLogSplitting after HBASE-14274 was applied.
> {code}
> 119113 2015-08-20 15:31:10,704 WARN  [HBase-Metrics2-1] 
> impl.MetricsConfig(124): Cannot locate configuration: tried 
> hadoop-metrics2-hbase.properties,hadoop-metrics2.properties
> 119114 2015-08-20 15:31:10,710 ERROR [HBase-Metrics2-1] 
> lib.MethodMetric$2(118): Error invoking method getBlocksTotal
> 119115 java.lang.reflect.InvocationTargetException
> 119116 ›   at sun.reflect.GeneratedMethodAccessor72.invoke(Unknown Source)
> 119117 ›   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 119118 ›   at java.lang.reflect.Method.invoke(Method.java:606)
> 119119 ›   at 
> org.apache.hadoop.metrics2.lib.MethodMetric$2.snapshot(MethodMetric.java:111)
> 119120 ›   at 
> org.apache.hadoop.metrics2.lib.MethodMetric.snapshot(MethodMetric.java:144)
> 119121 ›   at 
> org.apache.hadoop.metrics2.lib.MetricsRegistry.snapshot(MetricsRegistry.java:387)
> 119122 ›   at 
> org.apache.hadoop.metrics2.lib.MetricsSourceBuilder$1.getMetrics(MetricsSourceBuilder.java:79)
> 119123 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMetrics(MetricsSourceAdapter.java:195)
> 119124 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.updateJmxCache(MetricsSourceAdapter.java:172)
> 119125 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMBeanInfo(MetricsSourceAdapter.java:151)
> 119126 ›   at 
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getNewMBeanClassName(DefaultMBeanServerInterceptor.java:333)
> 119127 ›   at 
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:319)
> 119128 ›   at 
> com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:522)
> 119129 ›   at org.apache.hadoop.metrics2.util.MBeans.register(MBeans.java:57)
> 119130 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.startMBeans(MetricsSourceAdapter.java:221)
> 119131 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.start(MetricsSourceAdapter.java:96)
> 119132 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.registerSource(MetricsSystemImpl.java:245)
> 119133 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl$1.postStart(MetricsSystemImpl.java:229)
> 119134 ›   at sun.reflect.GeneratedMethodAccessor50.invoke(Unknown Source)
> 119135 ›   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 119136 ›   at java.lang.reflect.Method.invoke(Method.java:606)
> 119137 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl$3.invoke(MetricsSystemImpl.java:290)
> 119138 ›   at com.sun.proxy.$Proxy13.postStart(Unknown Source)
> 119139 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:185)
> 119140 ›   at 
> org.apache.hadoop.metrics2.impl.JmxCacheBuster$JmxCacheBusterRunnable.run(JmxCacheBuster.java:81)
> 119141 ›   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> 119142 ›   at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> 119143 ›   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
> 119144 ›   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
> 

[jira] [Commented] (HBASE-14278) Fix NPE that is showing up since HBASE-14274 went in

2015-09-16 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791453#comment-14791453
 ] 

Hudson commented on HBASE-14278:


FAILURE: Integrated in HBase-1.2-IT #152 (See 
[https://builds.apache.org/job/HBase-1.2-IT/152/])
HBASE-14278 Fix NPE that is showing up since HBASE-14274 went in (eclark: rev 
a229ac91fbab2608ae89bbe44b1dd05e5aef1183)
* 
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/metrics2/impl/JmxCacheBuster.java
* 
hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java
* 
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionAggregateSourceImpl.java
* 
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java
* 
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java


> Fix NPE that is showing up since HBASE-14274 went in
> 
>
> Key: HBASE-14278
> URL: https://issues.apache.org/jira/browse/HBASE-14278
> Project: HBase
>  Issue Type: Sub-task
>  Components: test
>Affects Versions: 2.0.0, 1.2.0, 1.3.0
>Reporter: stack
>Assignee: Elliott Clark
> Fix For: 2.0.0, 1.2.0, 1.3.0
>
> Attachments: HBASE-14278-v1.patch, HBASE-14278-v2.patch, 
> HBASE-14278-v3.patch, HBASE-14278-v4.patch, HBASE-14278-v5.patch, 
> HBASE-14278.patch
>
>
> Saw this in TestDistributedLogSplitting after HBASE-14274 was applied.
> {code}
> 119113 2015-08-20 15:31:10,704 WARN  [HBase-Metrics2-1] 
> impl.MetricsConfig(124): Cannot locate configuration: tried 
> hadoop-metrics2-hbase.properties,hadoop-metrics2.properties
> 119114 2015-08-20 15:31:10,710 ERROR [HBase-Metrics2-1] 
> lib.MethodMetric$2(118): Error invoking method getBlocksTotal
> 119115 java.lang.reflect.InvocationTargetException
> 119116 ›   at sun.reflect.GeneratedMethodAccessor72.invoke(Unknown Source)
> 119117 ›   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 119118 ›   at java.lang.reflect.Method.invoke(Method.java:606)
> 119119 ›   at 
> org.apache.hadoop.metrics2.lib.MethodMetric$2.snapshot(MethodMetric.java:111)
> 119120 ›   at 
> org.apache.hadoop.metrics2.lib.MethodMetric.snapshot(MethodMetric.java:144)
> 119121 ›   at 
> org.apache.hadoop.metrics2.lib.MetricsRegistry.snapshot(MetricsRegistry.java:387)
> 119122 ›   at 
> org.apache.hadoop.metrics2.lib.MetricsSourceBuilder$1.getMetrics(MetricsSourceBuilder.java:79)
> 119123 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMetrics(MetricsSourceAdapter.java:195)
> 119124 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.updateJmxCache(MetricsSourceAdapter.java:172)
> 119125 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMBeanInfo(MetricsSourceAdapter.java:151)
> 119126 ›   at 
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getNewMBeanClassName(DefaultMBeanServerInterceptor.java:333)
> 119127 ›   at 
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:319)
> 119128 ›   at 
> com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:522)
> 119129 ›   at org.apache.hadoop.metrics2.util.MBeans.register(MBeans.java:57)
> 119130 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.startMBeans(MetricsSourceAdapter.java:221)
> 119131 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.start(MetricsSourceAdapter.java:96)
> 119132 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.registerSource(MetricsSystemImpl.java:245)
> 119133 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl$1.postStart(MetricsSystemImpl.java:229)
> 119134 ›   at sun.reflect.GeneratedMethodAccessor50.invoke(Unknown Source)
> 119135 ›   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 119136 ›   at java.lang.reflect.Method.invoke(Method.java:606)
> 119137 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl$3.invoke(MetricsSystemImpl.java:290)
> 119138 ›   at com.sun.proxy.$Proxy13.postStart(Unknown Source)
> 119139 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:185)
> 119140 ›   at 
> org.apache.hadoop.metrics2.impl.JmxCacheBuster$JmxCacheBusterRunnable.run(JmxCacheBuster.java:81)
> 119141 ›   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> 119142 ›   at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> 119143 ›   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
> 119144 ›   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
> 

[jira] [Commented] (HBASE-14278) Fix NPE that is showing up since HBASE-14274 went in

2015-09-16 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791554#comment-14791554
 ] 

Hudson commented on HBASE-14278:


FAILURE: Integrated in HBase-1.3 #182 (See 
[https://builds.apache.org/job/HBase-1.3/182/])
HBASE-14278 Fix NPE that is showing up since HBASE-14274 went in (eclark: rev 
2029e851827fa1bf59436c7baa1971b52ac5833e)
* 
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/metrics2/impl/JmxCacheBuster.java
* 
hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java
* 
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java
* 
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java
* 
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionAggregateSourceImpl.java


> Fix NPE that is showing up since HBASE-14274 went in
> 
>
> Key: HBASE-14278
> URL: https://issues.apache.org/jira/browse/HBASE-14278
> Project: HBase
>  Issue Type: Sub-task
>  Components: test
>Affects Versions: 2.0.0, 1.2.0, 1.3.0
>Reporter: stack
>Assignee: Elliott Clark
> Fix For: 2.0.0, 1.2.0, 1.3.0
>
> Attachments: HBASE-14278-v1.patch, HBASE-14278-v2.patch, 
> HBASE-14278-v3.patch, HBASE-14278-v4.patch, HBASE-14278-v5.patch, 
> HBASE-14278.patch
>
>
> Saw this in TestDistributedLogSplitting after HBASE-14274 was applied.
> {code}
> 119113 2015-08-20 15:31:10,704 WARN  [HBase-Metrics2-1] 
> impl.MetricsConfig(124): Cannot locate configuration: tried 
> hadoop-metrics2-hbase.properties,hadoop-metrics2.properties
> 119114 2015-08-20 15:31:10,710 ERROR [HBase-Metrics2-1] 
> lib.MethodMetric$2(118): Error invoking method getBlocksTotal
> 119115 java.lang.reflect.InvocationTargetException
> 119116 ›   at sun.reflect.GeneratedMethodAccessor72.invoke(Unknown Source)
> 119117 ›   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 119118 ›   at java.lang.reflect.Method.invoke(Method.java:606)
> 119119 ›   at 
> org.apache.hadoop.metrics2.lib.MethodMetric$2.snapshot(MethodMetric.java:111)
> 119120 ›   at 
> org.apache.hadoop.metrics2.lib.MethodMetric.snapshot(MethodMetric.java:144)
> 119121 ›   at 
> org.apache.hadoop.metrics2.lib.MetricsRegistry.snapshot(MetricsRegistry.java:387)
> 119122 ›   at 
> org.apache.hadoop.metrics2.lib.MetricsSourceBuilder$1.getMetrics(MetricsSourceBuilder.java:79)
> 119123 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMetrics(MetricsSourceAdapter.java:195)
> 119124 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.updateJmxCache(MetricsSourceAdapter.java:172)
> 119125 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMBeanInfo(MetricsSourceAdapter.java:151)
> 119126 ›   at 
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getNewMBeanClassName(DefaultMBeanServerInterceptor.java:333)
> 119127 ›   at 
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:319)
> 119128 ›   at 
> com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:522)
> 119129 ›   at org.apache.hadoop.metrics2.util.MBeans.register(MBeans.java:57)
> 119130 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.startMBeans(MetricsSourceAdapter.java:221)
> 119131 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.start(MetricsSourceAdapter.java:96)
> 119132 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.registerSource(MetricsSystemImpl.java:245)
> 119133 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl$1.postStart(MetricsSystemImpl.java:229)
> 119134 ›   at sun.reflect.GeneratedMethodAccessor50.invoke(Unknown Source)
> 119135 ›   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 119136 ›   at java.lang.reflect.Method.invoke(Method.java:606)
> 119137 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl$3.invoke(MetricsSystemImpl.java:290)
> 119138 ›   at com.sun.proxy.$Proxy13.postStart(Unknown Source)
> 119139 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:185)
> 119140 ›   at 
> org.apache.hadoop.metrics2.impl.JmxCacheBuster$JmxCacheBusterRunnable.run(JmxCacheBuster.java:81)
> 119141 ›   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> 119142 ›   at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> 119143 ›   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
> 119144 ›   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
> 119145 ›   

[jira] [Commented] (HBASE-14278) Fix NPE that is showing up since HBASE-14274 went in

2015-09-16 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791562#comment-14791562
 ] 

Hudson commented on HBASE-14278:


FAILURE: Integrated in HBase-1.2 #180 (See 
[https://builds.apache.org/job/HBase-1.2/180/])
HBASE-14278 Fix NPE that is showing up since HBASE-14274 went in (eclark: rev 
a229ac91fbab2608ae89bbe44b1dd05e5aef1183)
* 
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/metrics2/impl/JmxCacheBuster.java
* 
hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java
* 
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java
* 
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java
* 
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionAggregateSourceImpl.java


> Fix NPE that is showing up since HBASE-14274 went in
> 
>
> Key: HBASE-14278
> URL: https://issues.apache.org/jira/browse/HBASE-14278
> Project: HBase
>  Issue Type: Sub-task
>  Components: test
>Affects Versions: 2.0.0, 1.2.0, 1.3.0
>Reporter: stack
>Assignee: Elliott Clark
> Fix For: 2.0.0, 1.2.0, 1.3.0
>
> Attachments: HBASE-14278-v1.patch, HBASE-14278-v2.patch, 
> HBASE-14278-v3.patch, HBASE-14278-v4.patch, HBASE-14278-v5.patch, 
> HBASE-14278.patch
>
>
> Saw this in TestDistributedLogSplitting after HBASE-14274 was applied.
> {code}
> 119113 2015-08-20 15:31:10,704 WARN  [HBase-Metrics2-1] 
> impl.MetricsConfig(124): Cannot locate configuration: tried 
> hadoop-metrics2-hbase.properties,hadoop-metrics2.properties
> 119114 2015-08-20 15:31:10,710 ERROR [HBase-Metrics2-1] 
> lib.MethodMetric$2(118): Error invoking method getBlocksTotal
> 119115 java.lang.reflect.InvocationTargetException
> 119116 ›   at sun.reflect.GeneratedMethodAccessor72.invoke(Unknown Source)
> 119117 ›   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 119118 ›   at java.lang.reflect.Method.invoke(Method.java:606)
> 119119 ›   at 
> org.apache.hadoop.metrics2.lib.MethodMetric$2.snapshot(MethodMetric.java:111)
> 119120 ›   at 
> org.apache.hadoop.metrics2.lib.MethodMetric.snapshot(MethodMetric.java:144)
> 119121 ›   at 
> org.apache.hadoop.metrics2.lib.MetricsRegistry.snapshot(MetricsRegistry.java:387)
> 119122 ›   at 
> org.apache.hadoop.metrics2.lib.MetricsSourceBuilder$1.getMetrics(MetricsSourceBuilder.java:79)
> 119123 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMetrics(MetricsSourceAdapter.java:195)
> 119124 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.updateJmxCache(MetricsSourceAdapter.java:172)
> 119125 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMBeanInfo(MetricsSourceAdapter.java:151)
> 119126 ›   at 
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getNewMBeanClassName(DefaultMBeanServerInterceptor.java:333)
> 119127 ›   at 
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:319)
> 119128 ›   at 
> com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:522)
> 119129 ›   at org.apache.hadoop.metrics2.util.MBeans.register(MBeans.java:57)
> 119130 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.startMBeans(MetricsSourceAdapter.java:221)
> 119131 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.start(MetricsSourceAdapter.java:96)
> 119132 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.registerSource(MetricsSystemImpl.java:245)
> 119133 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl$1.postStart(MetricsSystemImpl.java:229)
> 119134 ›   at sun.reflect.GeneratedMethodAccessor50.invoke(Unknown Source)
> 119135 ›   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 119136 ›   at java.lang.reflect.Method.invoke(Method.java:606)
> 119137 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl$3.invoke(MetricsSystemImpl.java:290)
> 119138 ›   at com.sun.proxy.$Proxy13.postStart(Unknown Source)
> 119139 ›   at 
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:185)
> 119140 ›   at 
> org.apache.hadoop.metrics2.impl.JmxCacheBuster$JmxCacheBusterRunnable.run(JmxCacheBuster.java:81)
> 119141 ›   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> 119142 ›   at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> 119143 ›   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
> 119144 ›   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
> 119145 ›   

[jira] [Commented] (HBASE-14278) Fix NPE that is showing up since HBASE-14274 went in

2015-08-27 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14718000#comment-14718000
 ] 

Hadoop QA commented on HBASE-14278:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12752878/HBASE-14278-v4.patch
  against master branch at commit cc1542828de93b8d54cc14497fd5937989ea1b6d.
  ATTACHMENT ID: 12752878

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 4 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat2
  
org.apache.hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS

 {color:red}-1 core zombie tests{color}.  There are 9 zombie test(s):   
at 
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL.testLabelsTableOpsWithDifferentUsers(TestVisibilityLabelsWithACL.java:233)

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15311//testReport/
Release Findbugs (version 2.0.3)warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15311//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15311//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15311//console

This message is automatically generated.

 Fix NPE that is showing up since HBASE-14274 went in
 

 Key: HBASE-14278
 URL: https://issues.apache.org/jira/browse/HBASE-14278
 Project: HBase
  Issue Type: Sub-task
  Components: test
Affects Versions: 2.0.0, 1.2.0, 1.3.0
Reporter: stack
Assignee: Elliott Clark
 Fix For: 2.0.0, 1.2.0, 1.3.0

 Attachments: HBASE-14278-v1.patch, HBASE-14278-v2.patch, 
 HBASE-14278-v3.patch, HBASE-14278-v4.patch, HBASE-14278.patch


 Saw this in TestDistributedLogSplitting after HBASE-14274 was applied.
 {code}
 119113 2015-08-20 15:31:10,704 WARN  [HBase-Metrics2-1] 
 impl.MetricsConfig(124): Cannot locate configuration: tried 
 hadoop-metrics2-hbase.properties,hadoop-metrics2.properties
 119114 2015-08-20 15:31:10,710 ERROR [HBase-Metrics2-1] 
 lib.MethodMetric$2(118): Error invoking method getBlocksTotal
 119115 java.lang.reflect.InvocationTargetException
 119116 ›   at sun.reflect.GeneratedMethodAccessor72.invoke(Unknown Source)
 119117 ›   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 119118 ›   at java.lang.reflect.Method.invoke(Method.java:606)
 119119 ›   at 
 org.apache.hadoop.metrics2.lib.MethodMetric$2.snapshot(MethodMetric.java:111)
 119120 ›   at 
 org.apache.hadoop.metrics2.lib.MethodMetric.snapshot(MethodMetric.java:144)
 119121 ›   at 
 org.apache.hadoop.metrics2.lib.MetricsRegistry.snapshot(MetricsRegistry.java:387)
 119122 ›   at 
 org.apache.hadoop.metrics2.lib.MetricsSourceBuilder$1.getMetrics(MetricsSourceBuilder.java:79)
 119123 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMetrics(MetricsSourceAdapter.java:195)
 119124 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.updateJmxCache(MetricsSourceAdapter.java:172)
 119125 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMBeanInfo(MetricsSourceAdapter.java:151)
 119126 ›   at 
 com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getNewMBeanClassName(DefaultMBeanServerInterceptor.java:333)
 119127 ›   at 
 com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:319)
 119128 ›   at 
 

[jira] [Commented] (HBASE-14278) Fix NPE that is showing up since HBASE-14274 went in

2015-08-25 Thread Elliott Clark (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14711825#comment-14711825
 ] 

Elliott Clark commented on HBASE-14278:
---

Hash making is only semi expensive. It's a walk over the region name as a 
string. However it's going to happen no matter what since we always add the 
region to a set which will call the hash code.

 Fix NPE that is showing up since HBASE-14274 went in
 

 Key: HBASE-14278
 URL: https://issues.apache.org/jira/browse/HBASE-14278
 Project: HBase
  Issue Type: Sub-task
  Components: test
Affects Versions: 2.0.0, 1.2.0, 1.3.0
Reporter: stack
Assignee: Elliott Clark
 Fix For: 2.0.0, 1.2.0, 1.3.0

 Attachments: HBASE-14278-v1.patch, HBASE-14278.patch


 Saw this in TestDistributedLogSplitting after HBASE-14274 was applied.
 {code}
 119113 2015-08-20 15:31:10,704 WARN  [HBase-Metrics2-1] 
 impl.MetricsConfig(124): Cannot locate configuration: tried 
 hadoop-metrics2-hbase.properties,hadoop-metrics2.properties
 119114 2015-08-20 15:31:10,710 ERROR [HBase-Metrics2-1] 
 lib.MethodMetric$2(118): Error invoking method getBlocksTotal
 119115 java.lang.reflect.InvocationTargetException
 119116 ›   at sun.reflect.GeneratedMethodAccessor72.invoke(Unknown Source)
 119117 ›   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 119118 ›   at java.lang.reflect.Method.invoke(Method.java:606)
 119119 ›   at 
 org.apache.hadoop.metrics2.lib.MethodMetric$2.snapshot(MethodMetric.java:111)
 119120 ›   at 
 org.apache.hadoop.metrics2.lib.MethodMetric.snapshot(MethodMetric.java:144)
 119121 ›   at 
 org.apache.hadoop.metrics2.lib.MetricsRegistry.snapshot(MetricsRegistry.java:387)
 119122 ›   at 
 org.apache.hadoop.metrics2.lib.MetricsSourceBuilder$1.getMetrics(MetricsSourceBuilder.java:79)
 119123 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMetrics(MetricsSourceAdapter.java:195)
 119124 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.updateJmxCache(MetricsSourceAdapter.java:172)
 119125 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMBeanInfo(MetricsSourceAdapter.java:151)
 119126 ›   at 
 com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getNewMBeanClassName(DefaultMBeanServerInterceptor.java:333)
 119127 ›   at 
 com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:319)
 119128 ›   at 
 com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:522)
 119129 ›   at org.apache.hadoop.metrics2.util.MBeans.register(MBeans.java:57)
 119130 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.startMBeans(MetricsSourceAdapter.java:221)
 119131 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.start(MetricsSourceAdapter.java:96)
 119132 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSystemImpl.registerSource(MetricsSystemImpl.java:245)
 119133 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSystemImpl$1.postStart(MetricsSystemImpl.java:229)
 119134 ›   at sun.reflect.GeneratedMethodAccessor50.invoke(Unknown Source)
 119135 ›   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 119136 ›   at java.lang.reflect.Method.invoke(Method.java:606)
 119137 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSystemImpl$3.invoke(MetricsSystemImpl.java:290)
 119138 ›   at com.sun.proxy.$Proxy13.postStart(Unknown Source)
 119139 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:185)
 119140 ›   at 
 org.apache.hadoop.metrics2.impl.JmxCacheBuster$JmxCacheBusterRunnable.run(JmxCacheBuster.java:81)
 119141 ›   at 
 java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
 119142 ›   at java.util.concurrent.FutureTask.run(FutureTask.java:262)
 119143 ›   at 
 java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
 119144 ›   at 
 java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
 119145 ›   at 
 java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
 119146 ›   at 
 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
 119147 ›   at java.lang.Thread.run(Thread.java:744)
 119148 Caused by: java.lang.NullPointerException
 119149 ›   at 
 org.apache.hadoop.hdfs.server.blockmanagement.BlocksMap.size(BlocksMap.java:198)
 119150 ›   at 
 org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.getTotalBlocks(BlockManager.java:3158)
 119151 ›   at 
 org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlocksTotal(FSNamesystem.java:5652)
 119152 ›   ... 32 more
 {code}



--
This message was sent by Atlassian 

[jira] [Commented] (HBASE-14278) Fix NPE that is showing up since HBASE-14274 went in

2015-08-25 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14711919#comment-14711919
 ] 

Hadoop QA commented on HBASE-14278:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12752299/HBASE-14278-v2.patch
  against master branch at commit 44caba31e4f259ea82d5141d2ba40a6d98f14f61.
  ATTACHMENT ID: 12752299

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   
org.apache.hadoop.hbase.regionserver.TestMetricsRegionSourceImpl

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15252//testReport/
Release Findbugs (version 2.0.3)warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15252//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15252//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15252//console

This message is automatically generated.

 Fix NPE that is showing up since HBASE-14274 went in
 

 Key: HBASE-14278
 URL: https://issues.apache.org/jira/browse/HBASE-14278
 Project: HBase
  Issue Type: Sub-task
  Components: test
Affects Versions: 2.0.0, 1.2.0, 1.3.0
Reporter: stack
Assignee: Elliott Clark
 Fix For: 2.0.0, 1.2.0, 1.3.0

 Attachments: HBASE-14278-v1.patch, HBASE-14278-v2.patch, 
 HBASE-14278.patch


 Saw this in TestDistributedLogSplitting after HBASE-14274 was applied.
 {code}
 119113 2015-08-20 15:31:10,704 WARN  [HBase-Metrics2-1] 
 impl.MetricsConfig(124): Cannot locate configuration: tried 
 hadoop-metrics2-hbase.properties,hadoop-metrics2.properties
 119114 2015-08-20 15:31:10,710 ERROR [HBase-Metrics2-1] 
 lib.MethodMetric$2(118): Error invoking method getBlocksTotal
 119115 java.lang.reflect.InvocationTargetException
 119116 ›   at sun.reflect.GeneratedMethodAccessor72.invoke(Unknown Source)
 119117 ›   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 119118 ›   at java.lang.reflect.Method.invoke(Method.java:606)
 119119 ›   at 
 org.apache.hadoop.metrics2.lib.MethodMetric$2.snapshot(MethodMetric.java:111)
 119120 ›   at 
 org.apache.hadoop.metrics2.lib.MethodMetric.snapshot(MethodMetric.java:144)
 119121 ›   at 
 org.apache.hadoop.metrics2.lib.MetricsRegistry.snapshot(MetricsRegistry.java:387)
 119122 ›   at 
 org.apache.hadoop.metrics2.lib.MetricsSourceBuilder$1.getMetrics(MetricsSourceBuilder.java:79)
 119123 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMetrics(MetricsSourceAdapter.java:195)
 119124 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.updateJmxCache(MetricsSourceAdapter.java:172)
 119125 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMBeanInfo(MetricsSourceAdapter.java:151)
 119126 ›   at 
 com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getNewMBeanClassName(DefaultMBeanServerInterceptor.java:333)
 119127 ›   at 
 com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:319)
 119128 ›   at 
 com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:522)
 119129 ›   at org.apache.hadoop.metrics2.util.MBeans.register(MBeans.java:57)
 119130 ›   at 
 

[jira] [Commented] (HBASE-14278) Fix NPE that is showing up since HBASE-14274 went in

2015-08-25 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712218#comment-14712218
 ] 

Hadoop QA commented on HBASE-14278:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12752320/HBASE-14278-v3.patch
  against master branch at commit 44caba31e4f259ea82d5141d2ba40a6d98f14f61.
  ATTACHMENT ID: 12752320

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 4 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   org.apache.hadoop.hbase.TestIOFencing

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15253//testReport/
Release Findbugs (version 2.0.3)warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15253//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15253//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15253//console

This message is automatically generated.

 Fix NPE that is showing up since HBASE-14274 went in
 

 Key: HBASE-14278
 URL: https://issues.apache.org/jira/browse/HBASE-14278
 Project: HBase
  Issue Type: Sub-task
  Components: test
Affects Versions: 2.0.0, 1.2.0, 1.3.0
Reporter: stack
Assignee: Elliott Clark
 Fix For: 2.0.0, 1.2.0, 1.3.0

 Attachments: HBASE-14278-v1.patch, HBASE-14278-v2.patch, 
 HBASE-14278-v3.patch, HBASE-14278.patch


 Saw this in TestDistributedLogSplitting after HBASE-14274 was applied.
 {code}
 119113 2015-08-20 15:31:10,704 WARN  [HBase-Metrics2-1] 
 impl.MetricsConfig(124): Cannot locate configuration: tried 
 hadoop-metrics2-hbase.properties,hadoop-metrics2.properties
 119114 2015-08-20 15:31:10,710 ERROR [HBase-Metrics2-1] 
 lib.MethodMetric$2(118): Error invoking method getBlocksTotal
 119115 java.lang.reflect.InvocationTargetException
 119116 ›   at sun.reflect.GeneratedMethodAccessor72.invoke(Unknown Source)
 119117 ›   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 119118 ›   at java.lang.reflect.Method.invoke(Method.java:606)
 119119 ›   at 
 org.apache.hadoop.metrics2.lib.MethodMetric$2.snapshot(MethodMetric.java:111)
 119120 ›   at 
 org.apache.hadoop.metrics2.lib.MethodMetric.snapshot(MethodMetric.java:144)
 119121 ›   at 
 org.apache.hadoop.metrics2.lib.MetricsRegistry.snapshot(MetricsRegistry.java:387)
 119122 ›   at 
 org.apache.hadoop.metrics2.lib.MetricsSourceBuilder$1.getMetrics(MetricsSourceBuilder.java:79)
 119123 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMetrics(MetricsSourceAdapter.java:195)
 119124 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.updateJmxCache(MetricsSourceAdapter.java:172)
 119125 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMBeanInfo(MetricsSourceAdapter.java:151)
 119126 ›   at 
 com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getNewMBeanClassName(DefaultMBeanServerInterceptor.java:333)
 119127 ›   at 
 com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:319)
 119128 ›   at 
 com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:522)
 119129 ›   at org.apache.hadoop.metrics2.util.MBeans.register(MBeans.java:57)
 119130 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.startMBeans(MetricsSourceAdapter.java:221)
 119131 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.start(MetricsSourceAdapter.java:96)
 119132 ›   at 
 

[jira] [Commented] (HBASE-14278) Fix NPE that is showing up since HBASE-14274 went in

2015-08-25 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712155#comment-14712155
 ] 

stack commented on HBASE-14278:
---

Ok. Was afraid it was walking all bundled metrics. +1 caveat it passing 
hadoopqa.

 Fix NPE that is showing up since HBASE-14274 went in
 

 Key: HBASE-14278
 URL: https://issues.apache.org/jira/browse/HBASE-14278
 Project: HBase
  Issue Type: Sub-task
  Components: test
Affects Versions: 2.0.0, 1.2.0, 1.3.0
Reporter: stack
Assignee: Elliott Clark
 Fix For: 2.0.0, 1.2.0, 1.3.0

 Attachments: HBASE-14278-v1.patch, HBASE-14278-v2.patch, 
 HBASE-14278-v3.patch, HBASE-14278.patch


 Saw this in TestDistributedLogSplitting after HBASE-14274 was applied.
 {code}
 119113 2015-08-20 15:31:10,704 WARN  [HBase-Metrics2-1] 
 impl.MetricsConfig(124): Cannot locate configuration: tried 
 hadoop-metrics2-hbase.properties,hadoop-metrics2.properties
 119114 2015-08-20 15:31:10,710 ERROR [HBase-Metrics2-1] 
 lib.MethodMetric$2(118): Error invoking method getBlocksTotal
 119115 java.lang.reflect.InvocationTargetException
 119116 ›   at sun.reflect.GeneratedMethodAccessor72.invoke(Unknown Source)
 119117 ›   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 119118 ›   at java.lang.reflect.Method.invoke(Method.java:606)
 119119 ›   at 
 org.apache.hadoop.metrics2.lib.MethodMetric$2.snapshot(MethodMetric.java:111)
 119120 ›   at 
 org.apache.hadoop.metrics2.lib.MethodMetric.snapshot(MethodMetric.java:144)
 119121 ›   at 
 org.apache.hadoop.metrics2.lib.MetricsRegistry.snapshot(MetricsRegistry.java:387)
 119122 ›   at 
 org.apache.hadoop.metrics2.lib.MetricsSourceBuilder$1.getMetrics(MetricsSourceBuilder.java:79)
 119123 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMetrics(MetricsSourceAdapter.java:195)
 119124 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.updateJmxCache(MetricsSourceAdapter.java:172)
 119125 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMBeanInfo(MetricsSourceAdapter.java:151)
 119126 ›   at 
 com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getNewMBeanClassName(DefaultMBeanServerInterceptor.java:333)
 119127 ›   at 
 com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:319)
 119128 ›   at 
 com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:522)
 119129 ›   at org.apache.hadoop.metrics2.util.MBeans.register(MBeans.java:57)
 119130 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.startMBeans(MetricsSourceAdapter.java:221)
 119131 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.start(MetricsSourceAdapter.java:96)
 119132 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSystemImpl.registerSource(MetricsSystemImpl.java:245)
 119133 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSystemImpl$1.postStart(MetricsSystemImpl.java:229)
 119134 ›   at sun.reflect.GeneratedMethodAccessor50.invoke(Unknown Source)
 119135 ›   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 119136 ›   at java.lang.reflect.Method.invoke(Method.java:606)
 119137 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSystemImpl$3.invoke(MetricsSystemImpl.java:290)
 119138 ›   at com.sun.proxy.$Proxy13.postStart(Unknown Source)
 119139 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:185)
 119140 ›   at 
 org.apache.hadoop.metrics2.impl.JmxCacheBuster$JmxCacheBusterRunnable.run(JmxCacheBuster.java:81)
 119141 ›   at 
 java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
 119142 ›   at java.util.concurrent.FutureTask.run(FutureTask.java:262)
 119143 ›   at 
 java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
 119144 ›   at 
 java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
 119145 ›   at 
 java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
 119146 ›   at 
 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
 119147 ›   at java.lang.Thread.run(Thread.java:744)
 119148 Caused by: java.lang.NullPointerException
 119149 ›   at 
 org.apache.hadoop.hdfs.server.blockmanagement.BlocksMap.size(BlocksMap.java:198)
 119150 ›   at 
 org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.getTotalBlocks(BlockManager.java:3158)
 119151 ›   at 
 org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlocksTotal(FSNamesystem.java:5652)
 119152 ›   ... 32 more
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-14278) Fix NPE that is showing up since HBASE-14274 went in

2015-08-24 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14709977#comment-14709977
 ] 

Hadoop QA commented on HBASE-14278:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12752032/HBASE-14278.patch
  against master branch at commit 9334a47d4570f8adfc003f0fb2c5969a88c3bba0.
  ATTACHMENT ID: 12752032

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:red}-1 checkstyle{color}.  The applied patch generated 
1850 checkstyle errors (more than the master's current 1849 errors).

{color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   org.apache.hadoop.hbase.regionserver.TestCompactionState
  org.apache.hadoop.hbase.regionserver.TestEncryptionKeyRotation
  org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildBase
  org.apache.hadoop.hbase.regionserver.TestRegionServerHostname
  org.apache.hadoop.hbase.regionserver.TestHRegionOnCluster
  org.apache.hadoop.hbase.regionserver.TestServerCustomProtocol
  org.apache.hadoop.hbase.util.TestMiniClusterLoadSequential
  org.apache.hadoop.hbase.regionserver.TestHRegion
  org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover
  org.apache.hadoop.hbase.mob.TestExpiredMobFileCleaner
  org.apache.hadoop.hbase.util.TestMiniClusterLoadParallel
  org.apache.hadoop.hbase.regionserver.TestHRegionReplayEvents
  org.apache.hadoop.hbase.namespace.TestNamespaceAuditor
  
org.apache.hadoop.hbase.regionserver.TestRegionServerReportForDuty
  
org.apache.hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster
  
org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
  org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildHole
  org.apache.hadoop.hbase.regionserver.TestClusterId
  
org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildOverlap
  
org.apache.hadoop.hbase.regionserver.compactions.TestCompactionWithThroughputController

 {color:red}-1 core zombie tests{color}.  There are 12 zombie test(s):  
at 
org.apache.hadoop.hbase.regionserver.TestRegionServerReportForDuty.testReportForDutyWithMasterChange(TestRegionServerReportForDuty.java:95)
at 
org.apache.hadoop.hbase.TestClusterBootOrder.testBootRegionServerFirst(TestClusterBootOrder.java:106)
at 
org.apache.hadoop.hbase.regionserver.TestTags.testFlushAndCompactionwithCombinations(TestTags.java:283)
at 
org.apache.hadoop.hbase.util.TestCoprocessorScanPolicy.testBaseCases(TestCoprocessorScanPolicy.java:107)
at 
org.apache.hadoop.hbase.mob.compactions.TestMobCompactor.testCompactionWithoutDelFilesAndWithEncryption(TestMobCompactor.java:276)
at 
org.apache.hadoop.hbase.regionserver.TestSplitWalDataLoss.test(TestSplitWalDataLoss.java:141)
at 
org.apache.hadoop.hbase.util.TestHBaseFsck.testHbckThreadpooling(TestHBaseFsck.java:534)
at 
org.apache.hadoop.hbase.util.TestHBaseFsck.testQuarantineMissingRegionDir(TestHBaseFsck.java:2433)
at 
org.apache.hadoop.hbase.util.TestHBaseFsck.testMissingFirstRegion(TestHBaseFsck.java:1928)
at 
org.apache.hadoop.hbase.util.TestHBaseFsck.testDegenerateRegions(TestHBaseFsck.java:954)
at 
org.apache.hadoop.hbase.util.TestHBaseFsck.testNotInMetaOrDeployedHole(TestHBaseFsck.java:1277)
at 

[jira] [Commented] (HBASE-14278) Fix NPE that is showing up since HBASE-14274 went in

2015-08-24 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14710323#comment-14710323
 ] 

stack commented on HBASE-14278:
---

{code}
kalashnikov:hbase.git stack$ python ./dev-support/findHangingTests.py 
https://builds.apache.org/job/PreCommit-HBASE-Build/15229/consoleFull
Fetching the console output from the URL
Printing hanging tests
Printing Failing tests
{code}

... so ain't sure why failed. All tests passed.

On the patch, is that hash making expensive?

Fix this on commit:

183 if (impl == null)
184   return -1;

Add parens.

Fix a checkstyle or two on commit too so our number stays under the threshold.

+1 (if hash is not expensive)

 Fix NPE that is showing up since HBASE-14274 went in
 

 Key: HBASE-14278
 URL: https://issues.apache.org/jira/browse/HBASE-14278
 Project: HBase
  Issue Type: Sub-task
  Components: test
Affects Versions: 2.0.0, 1.2.0, 1.3.0
Reporter: stack
Assignee: Elliott Clark
 Attachments: HBASE-14278-v1.patch, HBASE-14278.patch


 Saw this in TestDistributedLogSplitting after HBASE-14274 was applied.
 {code}
 119113 2015-08-20 15:31:10,704 WARN  [HBase-Metrics2-1] 
 impl.MetricsConfig(124): Cannot locate configuration: tried 
 hadoop-metrics2-hbase.properties,hadoop-metrics2.properties
 119114 2015-08-20 15:31:10,710 ERROR [HBase-Metrics2-1] 
 lib.MethodMetric$2(118): Error invoking method getBlocksTotal
 119115 java.lang.reflect.InvocationTargetException
 119116 ›   at sun.reflect.GeneratedMethodAccessor72.invoke(Unknown Source)
 119117 ›   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 119118 ›   at java.lang.reflect.Method.invoke(Method.java:606)
 119119 ›   at 
 org.apache.hadoop.metrics2.lib.MethodMetric$2.snapshot(MethodMetric.java:111)
 119120 ›   at 
 org.apache.hadoop.metrics2.lib.MethodMetric.snapshot(MethodMetric.java:144)
 119121 ›   at 
 org.apache.hadoop.metrics2.lib.MetricsRegistry.snapshot(MetricsRegistry.java:387)
 119122 ›   at 
 org.apache.hadoop.metrics2.lib.MetricsSourceBuilder$1.getMetrics(MetricsSourceBuilder.java:79)
 119123 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMetrics(MetricsSourceAdapter.java:195)
 119124 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.updateJmxCache(MetricsSourceAdapter.java:172)
 119125 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMBeanInfo(MetricsSourceAdapter.java:151)
 119126 ›   at 
 com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getNewMBeanClassName(DefaultMBeanServerInterceptor.java:333)
 119127 ›   at 
 com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:319)
 119128 ›   at 
 com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:522)
 119129 ›   at org.apache.hadoop.metrics2.util.MBeans.register(MBeans.java:57)
 119130 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.startMBeans(MetricsSourceAdapter.java:221)
 119131 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.start(MetricsSourceAdapter.java:96)
 119132 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSystemImpl.registerSource(MetricsSystemImpl.java:245)
 119133 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSystemImpl$1.postStart(MetricsSystemImpl.java:229)
 119134 ›   at sun.reflect.GeneratedMethodAccessor50.invoke(Unknown Source)
 119135 ›   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 119136 ›   at java.lang.reflect.Method.invoke(Method.java:606)
 119137 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSystemImpl$3.invoke(MetricsSystemImpl.java:290)
 119138 ›   at com.sun.proxy.$Proxy13.postStart(Unknown Source)
 119139 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:185)
 119140 ›   at 
 org.apache.hadoop.metrics2.impl.JmxCacheBuster$JmxCacheBusterRunnable.run(JmxCacheBuster.java:81)
 119141 ›   at 
 java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
 119142 ›   at java.util.concurrent.FutureTask.run(FutureTask.java:262)
 119143 ›   at 
 java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
 119144 ›   at 
 java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
 119145 ›   at 
 java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
 119146 ›   at 
 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
 119147 ›   at java.lang.Thread.run(Thread.java:744)
 119148 Caused by: java.lang.NullPointerException
 119149 ›   at 
 org.apache.hadoop.hdfs.server.blockmanagement.BlocksMap.size(BlocksMap.java:198)
 119150 ›   at 
 

[jira] [Commented] (HBASE-14278) Fix NPE that is showing up since HBASE-14274 went in

2015-08-24 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14710296#comment-14710296
 ] 

Hadoop QA commented on HBASE-14278:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12752082/HBASE-14278-v1.patch
  against master branch at commit d0873f5a8cc060adbc5a1ae0ed52b84a8942a868.
  ATTACHMENT ID: 12752082

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:red}-1 checkstyle{color}.  The applied patch generated 
1850 checkstyle errors (more than the master's current 1849 errors).

{color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15229//testReport/
Release Findbugs (version 2.0.3)warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15229//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15229//artifact/patchprocess/checkstyle-aggregate.html

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15229//console

This message is automatically generated.

 Fix NPE that is showing up since HBASE-14274 went in
 

 Key: HBASE-14278
 URL: https://issues.apache.org/jira/browse/HBASE-14278
 Project: HBase
  Issue Type: Sub-task
  Components: test
Affects Versions: 2.0.0, 1.2.0, 1.3.0
Reporter: stack
Assignee: Elliott Clark
 Attachments: HBASE-14278-v1.patch, HBASE-14278.patch


 Saw this in TestDistributedLogSplitting after HBASE-14274 was applied.
 {code}
 119113 2015-08-20 15:31:10,704 WARN  [HBase-Metrics2-1] 
 impl.MetricsConfig(124): Cannot locate configuration: tried 
 hadoop-metrics2-hbase.properties,hadoop-metrics2.properties
 119114 2015-08-20 15:31:10,710 ERROR [HBase-Metrics2-1] 
 lib.MethodMetric$2(118): Error invoking method getBlocksTotal
 119115 java.lang.reflect.InvocationTargetException
 119116 ›   at sun.reflect.GeneratedMethodAccessor72.invoke(Unknown Source)
 119117 ›   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 119118 ›   at java.lang.reflect.Method.invoke(Method.java:606)
 119119 ›   at 
 org.apache.hadoop.metrics2.lib.MethodMetric$2.snapshot(MethodMetric.java:111)
 119120 ›   at 
 org.apache.hadoop.metrics2.lib.MethodMetric.snapshot(MethodMetric.java:144)
 119121 ›   at 
 org.apache.hadoop.metrics2.lib.MetricsRegistry.snapshot(MetricsRegistry.java:387)
 119122 ›   at 
 org.apache.hadoop.metrics2.lib.MetricsSourceBuilder$1.getMetrics(MetricsSourceBuilder.java:79)
 119123 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMetrics(MetricsSourceAdapter.java:195)
 119124 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.updateJmxCache(MetricsSourceAdapter.java:172)
 119125 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMBeanInfo(MetricsSourceAdapter.java:151)
 119126 ›   at 
 com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getNewMBeanClassName(DefaultMBeanServerInterceptor.java:333)
 119127 ›   at 
 com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:319)
 119128 ›   at 
 com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:522)
 119129 ›   at org.apache.hadoop.metrics2.util.MBeans.register(MBeans.java:57)
 119130 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.startMBeans(MetricsSourceAdapter.java:221)
 119131 ›   at 
 

[jira] [Commented] (HBASE-14278) Fix NPE that is showing up since HBASE-14274 went in

2015-08-24 Thread Elliott Clark (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14710234#comment-14710234
 ] 

Elliott Clark commented on HBASE-14278:
---

This seems to fix TestIOFencing on my local runs.

 Fix NPE that is showing up since HBASE-14274 went in
 

 Key: HBASE-14278
 URL: https://issues.apache.org/jira/browse/HBASE-14278
 Project: HBase
  Issue Type: Sub-task
  Components: test
Affects Versions: 2.0.0, 1.2.0, 1.3.0
Reporter: stack
Assignee: Elliott Clark
 Attachments: HBASE-14278-v1.patch, HBASE-14278.patch


 Saw this in TestDistributedLogSplitting after HBASE-14274 was applied.
 {code}
 119113 2015-08-20 15:31:10,704 WARN  [HBase-Metrics2-1] 
 impl.MetricsConfig(124): Cannot locate configuration: tried 
 hadoop-metrics2-hbase.properties,hadoop-metrics2.properties
 119114 2015-08-20 15:31:10,710 ERROR [HBase-Metrics2-1] 
 lib.MethodMetric$2(118): Error invoking method getBlocksTotal
 119115 java.lang.reflect.InvocationTargetException
 119116 ›   at sun.reflect.GeneratedMethodAccessor72.invoke(Unknown Source)
 119117 ›   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 119118 ›   at java.lang.reflect.Method.invoke(Method.java:606)
 119119 ›   at 
 org.apache.hadoop.metrics2.lib.MethodMetric$2.snapshot(MethodMetric.java:111)
 119120 ›   at 
 org.apache.hadoop.metrics2.lib.MethodMetric.snapshot(MethodMetric.java:144)
 119121 ›   at 
 org.apache.hadoop.metrics2.lib.MetricsRegistry.snapshot(MetricsRegistry.java:387)
 119122 ›   at 
 org.apache.hadoop.metrics2.lib.MetricsSourceBuilder$1.getMetrics(MetricsSourceBuilder.java:79)
 119123 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMetrics(MetricsSourceAdapter.java:195)
 119124 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.updateJmxCache(MetricsSourceAdapter.java:172)
 119125 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMBeanInfo(MetricsSourceAdapter.java:151)
 119126 ›   at 
 com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getNewMBeanClassName(DefaultMBeanServerInterceptor.java:333)
 119127 ›   at 
 com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:319)
 119128 ›   at 
 com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:522)
 119129 ›   at org.apache.hadoop.metrics2.util.MBeans.register(MBeans.java:57)
 119130 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.startMBeans(MetricsSourceAdapter.java:221)
 119131 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.start(MetricsSourceAdapter.java:96)
 119132 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSystemImpl.registerSource(MetricsSystemImpl.java:245)
 119133 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSystemImpl$1.postStart(MetricsSystemImpl.java:229)
 119134 ›   at sun.reflect.GeneratedMethodAccessor50.invoke(Unknown Source)
 119135 ›   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 119136 ›   at java.lang.reflect.Method.invoke(Method.java:606)
 119137 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSystemImpl$3.invoke(MetricsSystemImpl.java:290)
 119138 ›   at com.sun.proxy.$Proxy13.postStart(Unknown Source)
 119139 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:185)
 119140 ›   at 
 org.apache.hadoop.metrics2.impl.JmxCacheBuster$JmxCacheBusterRunnable.run(JmxCacheBuster.java:81)
 119141 ›   at 
 java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
 119142 ›   at java.util.concurrent.FutureTask.run(FutureTask.java:262)
 119143 ›   at 
 java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
 119144 ›   at 
 java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
 119145 ›   at 
 java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
 119146 ›   at 
 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
 119147 ›   at java.lang.Thread.run(Thread.java:744)
 119148 Caused by: java.lang.NullPointerException
 119149 ›   at 
 org.apache.hadoop.hdfs.server.blockmanagement.BlocksMap.size(BlocksMap.java:198)
 119150 ›   at 
 org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.getTotalBlocks(BlockManager.java:3158)
 119151 ›   at 
 org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlocksTotal(FSNamesystem.java:5652)
 119152 ›   ... 32 more
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-14278) Fix NPE that is showing up since HBASE-14274 went in

2015-08-21 Thread Heng Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14706718#comment-14706718
 ] 

Heng Chen commented on HBASE-14278:
---

I reproduce the problem locally.  I think there is some risk in 
{{JmxCacheBusterRunnable.run}},  
{code}
if (DefaultMetricsSystem.instance() != null) {
  DefaultMetricsSystem.instance().stop();
  DefaultMetricsSystem.instance().start();
}
{code}
Maybe stop is not finished, but start is begin, so there are some conflicts.  

So i add {{Thread.sleep(1000)}} after 
{{DefaultMetricsSystem.instance().stop()}} and rerun testcase. NPE never 
appear!  
Hope it will help, and i will dig it too.

{code}
if (DefaultMetricsSystem.instance() != null) {
  DefaultMetricsSystem.instance().stop();
  Thread.sleep(1000);
  DefaultMetricsSystem.instance().start();
}
{code}


 Fix NPE that is showing up since HBASE-14274 went in
 

 Key: HBASE-14278
 URL: https://issues.apache.org/jira/browse/HBASE-14278
 Project: HBase
  Issue Type: Sub-task
  Components: test
Affects Versions: 2.0.0, 1.2.0, 1.3.0
Reporter: stack

 Saw this in TestDistributedLogSplitting after HBASE-14274 was applied.
 {code}
 119113 2015-08-20 15:31:10,704 WARN  [HBase-Metrics2-1] 
 impl.MetricsConfig(124): Cannot locate configuration: tried 
 hadoop-metrics2-hbase.properties,hadoop-metrics2.properties
 119114 2015-08-20 15:31:10,710 ERROR [HBase-Metrics2-1] 
 lib.MethodMetric$2(118): Error invoking method getBlocksTotal
 119115 java.lang.reflect.InvocationTargetException
 119116 ›   at sun.reflect.GeneratedMethodAccessor72.invoke(Unknown Source)
 119117 ›   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 119118 ›   at java.lang.reflect.Method.invoke(Method.java:606)
 119119 ›   at 
 org.apache.hadoop.metrics2.lib.MethodMetric$2.snapshot(MethodMetric.java:111)
 119120 ›   at 
 org.apache.hadoop.metrics2.lib.MethodMetric.snapshot(MethodMetric.java:144)
 119121 ›   at 
 org.apache.hadoop.metrics2.lib.MetricsRegistry.snapshot(MetricsRegistry.java:387)
 119122 ›   at 
 org.apache.hadoop.metrics2.lib.MetricsSourceBuilder$1.getMetrics(MetricsSourceBuilder.java:79)
 119123 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMetrics(MetricsSourceAdapter.java:195)
 119124 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.updateJmxCache(MetricsSourceAdapter.java:172)
 119125 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMBeanInfo(MetricsSourceAdapter.java:151)
 119126 ›   at 
 com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getNewMBeanClassName(DefaultMBeanServerInterceptor.java:333)
 119127 ›   at 
 com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:319)
 119128 ›   at 
 com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:522)
 119129 ›   at org.apache.hadoop.metrics2.util.MBeans.register(MBeans.java:57)
 119130 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.startMBeans(MetricsSourceAdapter.java:221)
 119131 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.start(MetricsSourceAdapter.java:96)
 119132 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSystemImpl.registerSource(MetricsSystemImpl.java:245)
 119133 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSystemImpl$1.postStart(MetricsSystemImpl.java:229)
 119134 ›   at sun.reflect.GeneratedMethodAccessor50.invoke(Unknown Source)
 119135 ›   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 119136 ›   at java.lang.reflect.Method.invoke(Method.java:606)
 119137 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSystemImpl$3.invoke(MetricsSystemImpl.java:290)
 119138 ›   at com.sun.proxy.$Proxy13.postStart(Unknown Source)
 119139 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:185)
 119140 ›   at 
 org.apache.hadoop.metrics2.impl.JmxCacheBuster$JmxCacheBusterRunnable.run(JmxCacheBuster.java:81)
 119141 ›   at 
 java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
 119142 ›   at java.util.concurrent.FutureTask.run(FutureTask.java:262)
 119143 ›   at 
 java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
 119144 ›   at 
 java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
 119145 ›   at 
 java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
 119146 ›   at 
 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
 119147 ›   at java.lang.Thread.run(Thread.java:744)
 119148 Caused by: java.lang.NullPointerException
 119149 

[jira] [Commented] (HBASE-14278) Fix NPE that is showing up since HBASE-14274 went in

2015-08-21 Thread Elliott Clark (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14707298#comment-14707298
 ] 

Elliott Clark commented on HBASE-14278:
---

Blah tests are making this code so ugly. That test double closes the same 
region.

 Fix NPE that is showing up since HBASE-14274 went in
 

 Key: HBASE-14278
 URL: https://issues.apache.org/jira/browse/HBASE-14278
 Project: HBase
  Issue Type: Sub-task
  Components: test
Affects Versions: 2.0.0, 1.2.0, 1.3.0
Reporter: stack

 Saw this in TestDistributedLogSplitting after HBASE-14274 was applied.
 {code}
 119113 2015-08-20 15:31:10,704 WARN  [HBase-Metrics2-1] 
 impl.MetricsConfig(124): Cannot locate configuration: tried 
 hadoop-metrics2-hbase.properties,hadoop-metrics2.properties
 119114 2015-08-20 15:31:10,710 ERROR [HBase-Metrics2-1] 
 lib.MethodMetric$2(118): Error invoking method getBlocksTotal
 119115 java.lang.reflect.InvocationTargetException
 119116 ›   at sun.reflect.GeneratedMethodAccessor72.invoke(Unknown Source)
 119117 ›   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 119118 ›   at java.lang.reflect.Method.invoke(Method.java:606)
 119119 ›   at 
 org.apache.hadoop.metrics2.lib.MethodMetric$2.snapshot(MethodMetric.java:111)
 119120 ›   at 
 org.apache.hadoop.metrics2.lib.MethodMetric.snapshot(MethodMetric.java:144)
 119121 ›   at 
 org.apache.hadoop.metrics2.lib.MetricsRegistry.snapshot(MetricsRegistry.java:387)
 119122 ›   at 
 org.apache.hadoop.metrics2.lib.MetricsSourceBuilder$1.getMetrics(MetricsSourceBuilder.java:79)
 119123 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMetrics(MetricsSourceAdapter.java:195)
 119124 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.updateJmxCache(MetricsSourceAdapter.java:172)
 119125 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMBeanInfo(MetricsSourceAdapter.java:151)
 119126 ›   at 
 com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getNewMBeanClassName(DefaultMBeanServerInterceptor.java:333)
 119127 ›   at 
 com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:319)
 119128 ›   at 
 com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:522)
 119129 ›   at org.apache.hadoop.metrics2.util.MBeans.register(MBeans.java:57)
 119130 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.startMBeans(MetricsSourceAdapter.java:221)
 119131 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.start(MetricsSourceAdapter.java:96)
 119132 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSystemImpl.registerSource(MetricsSystemImpl.java:245)
 119133 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSystemImpl$1.postStart(MetricsSystemImpl.java:229)
 119134 ›   at sun.reflect.GeneratedMethodAccessor50.invoke(Unknown Source)
 119135 ›   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 119136 ›   at java.lang.reflect.Method.invoke(Method.java:606)
 119137 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSystemImpl$3.invoke(MetricsSystemImpl.java:290)
 119138 ›   at com.sun.proxy.$Proxy13.postStart(Unknown Source)
 119139 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:185)
 119140 ›   at 
 org.apache.hadoop.metrics2.impl.JmxCacheBuster$JmxCacheBusterRunnable.run(JmxCacheBuster.java:81)
 119141 ›   at 
 java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
 119142 ›   at java.util.concurrent.FutureTask.run(FutureTask.java:262)
 119143 ›   at 
 java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
 119144 ›   at 
 java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
 119145 ›   at 
 java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
 119146 ›   at 
 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
 119147 ›   at java.lang.Thread.run(Thread.java:744)
 119148 Caused by: java.lang.NullPointerException
 119149 ›   at 
 org.apache.hadoop.hdfs.server.blockmanagement.BlocksMap.size(BlocksMap.java:198)
 119150 ›   at 
 org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.getTotalBlocks(BlockManager.java:3158)
 119151 ›   at 
 org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlocksTotal(FSNamesystem.java:5652)
 119152 ›   ... 32 more
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-14278) Fix NPE that is showing up since HBASE-14274 went in

2015-08-21 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-14278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14707294#comment-14707294
 ] 

stack commented on HBASE-14278:
---

Seeing this in a recent patch build run:

{code}
testSplitFailedCompactionAndSplit(org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster)
  Time elapsed: 1.494 sec   ERROR!
java.io.IOException: java.lang.NullPointerException
at 
org.apache.hadoop.hbase.regionserver.MetricsRegionSourceImpl.hashCode(MetricsRegionSourceImpl.java:268)
at 
java.util.concurrent.ConcurrentHashMap.hash(ConcurrentHashMap.java:333)
at 
java.util.concurrent.ConcurrentHashMap.remove(ConcurrentHashMap.java:1175)
at java.util.Collections$SetFromMap.remove(Collections.java:3902)
at 
org.apache.hadoop.hbase.regionserver.MetricsRegionAggregateSourceImpl.deregister(MetricsRegionAggregateSourceImpl.java:70)
at 
org.apache.hadoop.hbase.regionserver.MetricsRegionSourceImpl.close(MetricsRegionSourceImpl.java:117)
at 
org.apache.hadoop.hbase.regionserver.MetricsRegion.close(MetricsRegion.java:41)
at 
org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1500)
at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1344)
at 
org.apache.hadoop.hbase.regionserver.SplitTransactionImpl.stepsBeforePONR(SplitTransactionImpl.java:322)
at 
org.apache.hadoop.hbase.regionserver.SplitTransactionImpl.createDaughters(SplitTransactionImpl.java:242)
at 
org.apache.hadoop.hbase.regionserver.SplitTransactionImpl.execute(SplitTransactionImpl.java:456)
at 
org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster.testSplitFailedCompactionAndSplit(TestSplitTransactionOnCluster.java:270)
{code}

 Fix NPE that is showing up since HBASE-14274 went in
 

 Key: HBASE-14278
 URL: https://issues.apache.org/jira/browse/HBASE-14278
 Project: HBase
  Issue Type: Sub-task
  Components: test
Affects Versions: 2.0.0, 1.2.0, 1.3.0
Reporter: stack

 Saw this in TestDistributedLogSplitting after HBASE-14274 was applied.
 {code}
 119113 2015-08-20 15:31:10,704 WARN  [HBase-Metrics2-1] 
 impl.MetricsConfig(124): Cannot locate configuration: tried 
 hadoop-metrics2-hbase.properties,hadoop-metrics2.properties
 119114 2015-08-20 15:31:10,710 ERROR [HBase-Metrics2-1] 
 lib.MethodMetric$2(118): Error invoking method getBlocksTotal
 119115 java.lang.reflect.InvocationTargetException
 119116 ›   at sun.reflect.GeneratedMethodAccessor72.invoke(Unknown Source)
 119117 ›   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 119118 ›   at java.lang.reflect.Method.invoke(Method.java:606)
 119119 ›   at 
 org.apache.hadoop.metrics2.lib.MethodMetric$2.snapshot(MethodMetric.java:111)
 119120 ›   at 
 org.apache.hadoop.metrics2.lib.MethodMetric.snapshot(MethodMetric.java:144)
 119121 ›   at 
 org.apache.hadoop.metrics2.lib.MetricsRegistry.snapshot(MetricsRegistry.java:387)
 119122 ›   at 
 org.apache.hadoop.metrics2.lib.MetricsSourceBuilder$1.getMetrics(MetricsSourceBuilder.java:79)
 119123 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMetrics(MetricsSourceAdapter.java:195)
 119124 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.updateJmxCache(MetricsSourceAdapter.java:172)
 119125 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMBeanInfo(MetricsSourceAdapter.java:151)
 119126 ›   at 
 com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getNewMBeanClassName(DefaultMBeanServerInterceptor.java:333)
 119127 ›   at 
 com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:319)
 119128 ›   at 
 com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:522)
 119129 ›   at org.apache.hadoop.metrics2.util.MBeans.register(MBeans.java:57)
 119130 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.startMBeans(MetricsSourceAdapter.java:221)
 119131 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.start(MetricsSourceAdapter.java:96)
 119132 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSystemImpl.registerSource(MetricsSystemImpl.java:245)
 119133 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSystemImpl$1.postStart(MetricsSystemImpl.java:229)
 119134 ›   at sun.reflect.GeneratedMethodAccessor50.invoke(Unknown Source)
 119135 ›   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 119136 ›   at java.lang.reflect.Method.invoke(Method.java:606)
 119137 ›   at 
 org.apache.hadoop.metrics2.impl.MetricsSystemImpl$3.invoke(MetricsSystemImpl.java:290)
 119138 ›   at com.sun.proxy.$Proxy13.postStart(Unknown Source)
 119139 ›   at