[jira] [Commented] (HBASE-14459) Add request and response sizes metrics
[ https://issues.apache.org/jira/browse/HBASE-14459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939549#comment-14939549 ] Hudson commented on HBASE-14459: FAILURE: Integrated in HBase-1.3-IT #197 (See [https://builds.apache.org/job/HBase-1.3-IT/197/]) HBASE-14459 Add response and request size metrics (apurtell: rev d047c378719eeb352e354c24d88ea6e94125af7f) * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSource.java * hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestRpcMetrics.java * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServer.java * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSourceImpl.java > Add request and response sizes metrics > -- > > Key: HBASE-14459 > URL: https://issues.apache.org/jira/browse/HBASE-14459 > Project: HBase > Issue Type: New Feature > Components: metrics >Affects Versions: 1.2.0 >Reporter: Sanjeev Srivatsa >Assignee: Sanjeev Srivatsa > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15 > > Attachments: HBASE-14459-v1.patch > > > Adding metrics that should be useful: > Request size > Response size -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14459) Add request and response sizes metrics
[ https://issues.apache.org/jira/browse/HBASE-14459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939397#comment-14939397 ] Hudson commented on HBASE-14459: SUCCESS: Integrated in HBase-0.98 #1135 (See [https://builds.apache.org/job/HBase-0.98/1135/]) HBASE-14459 Add response and request size metrics (apurtell: rev 0bec6ea18e8c9be995bb61291556fc86dea5726d) * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServer.java * hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestRpcMetrics.java * hbase-hadoop1-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSourceImpl.java * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSourceImpl.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSource.java > Add request and response sizes metrics > -- > > Key: HBASE-14459 > URL: https://issues.apache.org/jira/browse/HBASE-14459 > Project: HBase > Issue Type: New Feature > Components: metrics >Affects Versions: 1.2.0 >Reporter: Sanjeev Srivatsa >Assignee: Sanjeev Srivatsa > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15 > > Attachments: HBASE-14459-v1.patch > > > Adding metrics that should be useful: > Request size > Response size -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14459) Add request and response sizes metrics
[ https://issues.apache.org/jira/browse/HBASE-14459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939367#comment-14939367 ] Hudson commented on HBASE-14459: FAILURE: Integrated in HBase-TRUNK #6861 (See [https://builds.apache.org/job/HBase-TRUNK/6861/]) HBASE-14459 Add response and request size metrics (apurtell: rev 76463a36f5648f42cdcf64019a825c1e3f0c4fe1) * hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestRpcMetrics.java * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServer.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSource.java * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSourceImpl.java * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java > Add request and response sizes metrics > -- > > Key: HBASE-14459 > URL: https://issues.apache.org/jira/browse/HBASE-14459 > Project: HBase > Issue Type: New Feature > Components: metrics >Affects Versions: 1.2.0 >Reporter: Sanjeev Srivatsa >Assignee: Sanjeev Srivatsa > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15 > > Attachments: HBASE-14459-v1.patch > > > Adding metrics that should be useful: > Request size > Response size -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14459) Add request and response sizes metrics
[ https://issues.apache.org/jira/browse/HBASE-14459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939354#comment-14939354 ] Hudson commented on HBASE-14459: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1088 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1088/]) HBASE-14459 Add response and request size metrics (apurtell: rev 0bec6ea18e8c9be995bb61291556fc86dea5726d) * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServer.java * hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestRpcMetrics.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSource.java * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSourceImpl.java * hbase-hadoop1-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSourceImpl.java > Add request and response sizes metrics > -- > > Key: HBASE-14459 > URL: https://issues.apache.org/jira/browse/HBASE-14459 > Project: HBase > Issue Type: New Feature > Components: metrics >Affects Versions: 1.2.0 >Reporter: Sanjeev Srivatsa >Assignee: Sanjeev Srivatsa > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15 > > Attachments: HBASE-14459-v1.patch > > > Adding metrics that should be useful: > Request size > Response size -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14459) Add request and response sizes metrics
[ https://issues.apache.org/jira/browse/HBASE-14459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939334#comment-14939334 ] Hudson commented on HBASE-14459: SUCCESS: Integrated in HBase-1.2-IT #180 (See [https://builds.apache.org/job/HBase-1.2-IT/180/]) HBASE-14459 Add response and request size metrics (apurtell: rev 26eea98a8212654f463faabc06825fa067496d41) * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSource.java * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSourceImpl.java * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServer.java * hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestRpcMetrics.java > Add request and response sizes metrics > -- > > Key: HBASE-14459 > URL: https://issues.apache.org/jira/browse/HBASE-14459 > Project: HBase > Issue Type: New Feature > Components: metrics >Affects Versions: 1.2.0 >Reporter: Sanjeev Srivatsa >Assignee: Sanjeev Srivatsa > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15 > > Attachments: HBASE-14459-v1.patch > > > Adding metrics that should be useful: > Request size > Response size -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14459) Add request and response sizes metrics
[ https://issues.apache.org/jira/browse/HBASE-14459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939331#comment-14939331 ] Hudson commented on HBASE-14459: FAILURE: Integrated in HBase-1.2 #215 (See [https://builds.apache.org/job/HBase-1.2/215/]) HBASE-14459 Add response and request size metrics (apurtell: rev 26eea98a8212654f463faabc06825fa067496d41) * hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestRpcMetrics.java * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServer.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSource.java * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSourceImpl.java > Add request and response sizes metrics > -- > > Key: HBASE-14459 > URL: https://issues.apache.org/jira/browse/HBASE-14459 > Project: HBase > Issue Type: New Feature > Components: metrics >Affects Versions: 1.2.0 >Reporter: Sanjeev Srivatsa >Assignee: Sanjeev Srivatsa > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15 > > Attachments: HBASE-14459-v1.patch > > > Adding metrics that should be useful: > Request size > Response size -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14459) Add request and response sizes metrics
[ https://issues.apache.org/jira/browse/HBASE-14459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939318#comment-14939318 ] Hudson commented on HBASE-14459: FAILURE: Integrated in HBase-1.3 #221 (See [https://builds.apache.org/job/HBase-1.3/221/]) HBASE-14459 Add response and request size metrics (apurtell: rev d047c378719eeb352e354c24d88ea6e94125af7f) * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSourceImpl.java * hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestRpcMetrics.java * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSource.java * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServer.java > Add request and response sizes metrics > -- > > Key: HBASE-14459 > URL: https://issues.apache.org/jira/browse/HBASE-14459 > Project: HBase > Issue Type: New Feature > Components: metrics >Affects Versions: 1.2.0 >Reporter: Sanjeev Srivatsa >Assignee: Sanjeev Srivatsa > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15 > > Attachments: HBASE-14459-v1.patch > > > Adding metrics that should be useful: > Request size > Response size -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14459) Add request and response sizes metrics
[ https://issues.apache.org/jira/browse/HBASE-14459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938948#comment-14938948 ] Elliott Clark commented on HBASE-14459: --- Nope looks good to me. +1 > Add request and response sizes metrics > -- > > Key: HBASE-14459 > URL: https://issues.apache.org/jira/browse/HBASE-14459 > Project: HBase > Issue Type: New Feature > Components: metrics >Affects Versions: 1.2.0 >Reporter: Sanjeev Srivatsa >Assignee: Sanjeev Srivatsa > Attachments: HBASE-14459-v1.patch > > > Adding metrics that should be useful: > Request size > Response size -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14459) Add request and response sizes metrics
[ https://issues.apache.org/jira/browse/HBASE-14459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938844#comment-14938844 ] Andrew Purtell commented on HBASE-14459: lgtm Any concerns [~eclark] ? > Add request and response sizes metrics > -- > > Key: HBASE-14459 > URL: https://issues.apache.org/jira/browse/HBASE-14459 > Project: HBase > Issue Type: New Feature > Components: metrics >Affects Versions: 1.2.0 >Reporter: Sanjeev Srivatsa >Assignee: Sanjeev Srivatsa > Attachments: HBASE-14459-v1.patch > > > Adding metrics that should be useful: > Request size > Response size -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14459) Add request and response sizes metrics
[
https://issues.apache.org/jira/browse/HBASE-14459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901899#comment-14901899
]
Hadoop QA commented on HBASE-14459:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12761532/HBASE-14459-v1.patch
against master branch at commit 8765ffb0ca2b1c39d864ac495f0b3ee2abc520ed.
ATTACHMENT ID: 12761532
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat2
org.apache.hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS
{color:red}-1 core zombie tests{color}. There are 5 zombie test(s):
at
org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite.testNotCachingDataBlocksDuringCompactionInternals(TestCacheOnWrite.java:484)
at
org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite.testNotCachingDataBlocksDuringCompaction(TestCacheOnWrite.java:509)
at
org.apache.hadoop.hbase.replication.regionserver.TestReplicationWALReaderManager.test(TestReplicationWALReaderManager.java:184)
at
org.apache.hadoop.hbase.io.encoding.TestDataBlockEncoders.testSeekingOnSample(TestDataBlockEncoders.java:217)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15658//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15658//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15658//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15658//console
This message is automatically generated.
> Add request and response sizes metrics
> --
>
> Key: HBASE-14459
> URL: https://issues.apache.org/jira/browse/HBASE-14459
> Project: HBase
> Issue Type: New Feature
> Components: metrics
>Affects Versions: 1.2.0
>Reporter: Sanjeev Srivatsa
>Assignee: Sanjeev Srivatsa
> Attachments: HBASE-14459-v1.patch
>
>
> Adding metrics that should be useful:
> Request size
> Response size
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
