[jira] [Commented] (HBASE-14635) Reenable TestSnapshotCloneIndependence.testOnlineSnapshotDeleteIndependent
[ https://issues.apache.org/jira/browse/HBASE-14635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15113569#comment-15113569 ] Appy commented on HBASE-14635: -- Ping. > Reenable TestSnapshotCloneIndependence.testOnlineSnapshotDeleteIndependent > -- > > Key: HBASE-14635 > URL: https://issues.apache.org/jira/browse/HBASE-14635 > Project: HBase > Issue Type: Task > Components: test >Reporter: stack >Assignee: Appy > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-14635-master-v2.patch, HBASE-14635-master.patch > > > Was disabled in the parent issue because flakey. This issue is about > reenabling it after figuring why its flakey. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14635) Reenable TestSnapshotCloneIndependence.testOnlineSnapshotDeleteIndependent
[
https://issues.apache.org/jira/browse/HBASE-14635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15102779#comment-15102779
]
Appy commented on HBASE-14635:
--
So [~eclark] made couple of good changes in HBASE-14585. But we couldn't see if
those good changes fixed the test because the patch also introduced the
following error which made the test to fail and subsequently removed in
HBASE-14678.
{noformat}
if (!online) {
- admin.enableTable(localTableName);
+ tryDisable(admin, localTableName);
}
{noformat}
Naming is kind of confusing there, so wouldn't blame Elliott. :-)
This patch only fixes that part inside {{if (!online) }} and waits for the
table to come online.
Lets see if it behaves good now.
> Reenable TestSnapshotCloneIndependence.testOnlineSnapshotDeleteIndependent
> --
>
> Key: HBASE-14635
> URL: https://issues.apache.org/jira/browse/HBASE-14635
> Project: HBase
> Issue Type: Task
> Components: test
>Reporter: stack
>Assignee: Appy
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-14635-master-v2.patch, HBASE-14635-master.patch
>
>
> Was disabled in the parent issue because flakey. This issue is about
> reenabling it after figuring why its flakey.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14635) Reenable TestSnapshotCloneIndependence.testOnlineSnapshotDeleteIndependent
[ https://issues.apache.org/jira/browse/HBASE-14635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073702#comment-15073702 ] Appy commented on HBASE-14635: -- Ping > Reenable TestSnapshotCloneIndependence.testOnlineSnapshotDeleteIndependent > -- > > Key: HBASE-14635 > URL: https://issues.apache.org/jira/browse/HBASE-14635 > Project: HBase > Issue Type: Task > Components: test >Reporter: stack >Assignee: Appy > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-14635-master-v2.patch, HBASE-14635-master.patch > > > Was disabled in the parent issue because flakey. This issue is about > reenabling it after figuring why its flakey. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14635) Reenable TestSnapshotCloneIndependence.testOnlineSnapshotDeleteIndependent
[ https://issues.apache.org/jira/browse/HBASE-14635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073741#comment-15073741 ] Heng Chen commented on HBASE-14635: --- Oh, the testcase was removed yet? What's the difference between original code and the patch? > Reenable TestSnapshotCloneIndependence.testOnlineSnapshotDeleteIndependent > -- > > Key: HBASE-14635 > URL: https://issues.apache.org/jira/browse/HBASE-14635 > Project: HBase > Issue Type: Task > Components: test >Reporter: stack >Assignee: Appy > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-14635-master-v2.patch, HBASE-14635-master.patch > > > Was disabled in the parent issue because flakey. This issue is about > reenabling it after figuring why its flakey. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14635) Reenable TestSnapshotCloneIndependence.testOnlineSnapshotDeleteIndependent
[
https://issues.apache.org/jira/browse/HBASE-14635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070542#comment-15070542
]
Hadoop QA commented on HBASE-14635:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12779161/HBASE-14635-master-v2.patch
against master branch at commit 04de427e57d144caf5a9cde3664dac780ed763ab.
ATTACHMENT ID: 12779161
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not generate new
checkstyle errors.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this
patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
{color:green}+1 zombies{color}. No zombie tests found running at the end of
the build.
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/17005//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/17005//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/17005//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/17005//console
This message is automatically generated.
> Reenable TestSnapshotCloneIndependence.testOnlineSnapshotDeleteIndependent
> --
>
> Key: HBASE-14635
> URL: https://issues.apache.org/jira/browse/HBASE-14635
> Project: HBase
> Issue Type: Task
> Components: test
>Reporter: stack
>Assignee: Appy
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-14635-master-v2.patch, HBASE-14635-master.patch
>
>
> Was disabled in the parent issue because flakey. This issue is about
> reenabling it after figuring why its flakey.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14635) Reenable TestSnapshotCloneIndependence.testOnlineSnapshotDeleteIndependent
[ https://issues.apache.org/jira/browse/HBASE-14635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15060945#comment-15060945 ] Sean Busbey commented on HBASE-14635: - moved from subtask of HBASE-14634 to top-level issue pending release. > Reenable TestSnapshotCloneIndependence.testOnlineSnapshotDeleteIndependent > -- > > Key: HBASE-14635 > URL: https://issues.apache.org/jira/browse/HBASE-14635 > Project: HBase > Issue Type: Task > Components: test >Reporter: stack > Fix For: 2.0.0, 1.3.0 > > > Was disabled in the parent issue because flakey. This issue is about > reenabling it after figuring why its flakey. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14635) Reenable TestSnapshotCloneIndependence.testOnlineSnapshotDeleteIndependent
[ https://issues.apache.org/jira/browse/HBASE-14635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14972879#comment-14972879 ] stack commented on HBASE-14635: --- [~eclark] Elliott, see above. I removed this test as part of HBASE-14678 for the time being given it fails still on other methods (all methods run same code it seems so fixing it in one place hopefully gets all) > Reenable TestSnapshotCloneIndependence.testOnlineSnapshotDeleteIndependent > -- > > Key: HBASE-14635 > URL: https://issues.apache.org/jira/browse/HBASE-14635 > Project: HBase > Issue Type: Sub-task > Components: test >Reporter: stack > Fix For: 2.0.0, 1.2.0, 1.3.0 > > > Was disabled in the parent issue because flakey. This issue is about > reenabling it after figuring why its flakey. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14635) Reenable TestSnapshotCloneIndependence.testOnlineSnapshotDeleteIndependent
[
https://issues.apache.org/jira/browse/HBASE-14635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968941#comment-14968941
]
Heng Chen commented on HBASE-14635:
---
{quote}
Is it right? It seems to replace "disable" action to be "enable" action?
{quote}
How do you think about it? [~eclark]
> Reenable TestSnapshotCloneIndependence.testOnlineSnapshotDeleteIndependent
> --
>
> Key: HBASE-14635
> URL: https://issues.apache.org/jira/browse/HBASE-14635
> Project: HBase
> Issue Type: Sub-task
> Components: test
>Reporter: stack
> Fix For: 2.0.0, 1.2.0, 1.3.0
>
>
> Was disabled in the parent issue because flakey. This issue is about
> reenabling it after figuring why its flakey.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14635) Reenable TestSnapshotCloneIndependence.testOnlineSnapshotDeleteIndependent
[ https://issues.apache.org/jira/browse/HBASE-14635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967586#comment-14967586 ] stack commented on HBASE-14635: --- See up in https://issues.apache.org/jira/browse/HBASE-14585 where [~eclark] trips over same issue. > Reenable TestSnapshotCloneIndependence.testOnlineSnapshotDeleteIndependent > -- > > Key: HBASE-14635 > URL: https://issues.apache.org/jira/browse/HBASE-14635 > Project: HBase > Issue Type: Sub-task > Components: test >Reporter: stack > Fix For: 2.0.0, 1.2.0, 1.3.0 > > > Was disabled in the parent issue because flakey. This issue is about > reenabling it after figuring why its flakey. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14635) Reenable TestSnapshotCloneIndependence.testOnlineSnapshotDeleteIndependent
[
https://issues.apache.org/jira/browse/HBASE-14635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966399#comment-14966399
]
Heng Chen commented on HBASE-14635:
---
As this testcase, i found some flakey code which i can't understand.
{code}
SnapshotTestingUtils.createSnapshotAndValidate(admin, localTableName,
TEST_FAM_STR,
snapshotNameAsString, rootDir, fs, online);
if (!online) {
tryDisable(admin, localTableName); //Why we disable again ? ? ?
}
{code}
As comments of {{SnapshotTestingUtils.createSnapshotAndValidate}} , if online
be false, the function will disable {{localTable}}, why disable again?
And after disable the table, {{admin.majorCompact(localTableName)}} was
called.
Is it right? It seems to replace "disable" action to be "enable" action?
> Reenable TestSnapshotCloneIndependence.testOnlineSnapshotDeleteIndependent
> --
>
> Key: HBASE-14635
> URL: https://issues.apache.org/jira/browse/HBASE-14635
> Project: HBase
> Issue Type: Sub-task
> Components: test
>Reporter: stack
> Fix For: 2.0.0, 1.2.0, 1.3.0
>
>
> Was disabled in the parent issue because flakey. This issue is about
> reenabling it after figuring why its flakey.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
