[jira] [Commented] (HBASE-14679) Separate security shell tests from other shell tests
[ https://issues.apache.org/jira/browse/HBASE-14679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14984755#comment-14984755 ] stack commented on HBASE-14679: --- bq. Investigation on TestShell is needed. And so. bq. Resolving. ? > Separate security shell tests from other shell tests > > > Key: HBASE-14679 > URL: https://issues.apache.org/jira/browse/HBASE-14679 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Attachments: 14679-branch-1-v1.txt, 14679-branch-1-v1.txt > > > TestShell takes a long time to run, sometimes timing out (especially on > branch-1). > This issue proposes the following changes: > separate security shell tests into their own test class > use unique table names for different tests -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14679) Separate security shell tests from other shell tests
[ https://issues.apache.org/jira/browse/HBASE-14679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14971661#comment-14971661 ] Andrew Purtell commented on HBASE-14679: This is just moving the problem around. The security tests are sensitive to weirdness in Connection level matters like ZooKeeper watchers, connection caching. As an example, I fixed a problem in this area before on HBASE-14209. Should do the same type of investigation and test fix here IMHO > Separate security shell tests from other shell tests > > > Key: HBASE-14679 > URL: https://issues.apache.org/jira/browse/HBASE-14679 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Attachments: 14679-branch-1-v1.txt, 14679-branch-1-v1.txt > > > TestShell takes a long time to run, sometimes timing out (especially on > branch-1). > This issue proposes the following changes: > separate security shell tests into their own test class > use unique table names for different tests -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14679) Separate security shell tests from other shell tests
[ https://issues.apache.org/jira/browse/HBASE-14679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14969833#comment-14969833 ] stack commented on HBASE-14679: --- You know what it runs so long or which test is timing out? > Separate security shell tests from other shell tests > > > Key: HBASE-14679 > URL: https://issues.apache.org/jira/browse/HBASE-14679 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Attachments: 14679-branch-1-v1.txt > > > TestShell takes a long time to run, sometimes timing out (especially on > branch-1). > This issue proposes the following changes: > separate security shell tests into their own test class > use unique table names for different tests -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14679) Separate security shell tests from other shell tests
[
https://issues.apache.org/jira/browse/HBASE-14679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14969851#comment-14969851
]
Ted Yu commented on HBASE-14679:
I haven't dug deep enough to pinpoint the exact cause.
>From what I observed, it was related to security shell test:
{code}
2015-10-22 09:31:32,755 DEBUG [main]
client.ConnectionManager$HConnectionImplementation(1349): locateRegionInMeta
parentTable=hbase:meta, metaLocation=, attempt=1 of 6 failed; retrying after
sleep of 500 because: Failed after attempts=7, exceptions:
Thu Oct 22 09:31:32 PDT 2015, null, java.net.SocketTimeoutException:
callTimeout=6, callDuration=60756: row 'hbase:acl,,99' on table
'hbase:meta' atregion=hbase:meta,,1.1588230740,
hostname=cn012.l42scl.hortonworks.com,46788,1445530781461, seqNum=0
{code}
> Separate security shell tests from other shell tests
>
>
> Key: HBASE-14679
> URL: https://issues.apache.org/jira/browse/HBASE-14679
> Project: HBase
> Issue Type: Task
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Attachments: 14679-branch-1-v1.txt
>
>
> TestShell takes a long time to run, sometimes timing out (especially on
> branch-1).
> This issue proposes the following changes:
> separate security shell tests into their own test class
> use unique table names for different tests
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14679) Separate security shell tests from other shell tests
[ https://issues.apache.org/jira/browse/HBASE-14679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14969917#comment-14969917 ] Ted Yu commented on HBASE-14679: Separating existing test into smaller ones has been used by others. e.g. HBASE-14570 Will continue digging into balancer test hang though I haven't seen recent occurrence. > Separate security shell tests from other shell tests > > > Key: HBASE-14679 > URL: https://issues.apache.org/jira/browse/HBASE-14679 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Attachments: 14679-branch-1-v1.txt > > > TestShell takes a long time to run, sometimes timing out (especially on > branch-1). > This issue proposes the following changes: > separate security shell tests into their own test class > use unique table names for different tests -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14679) Separate security shell tests from other shell tests
[
https://issues.apache.org/jira/browse/HBASE-14679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14969825#comment-14969825
]
Ted Yu commented on HBASE-14679:
Here is result with patch and patch from HBASE-14583 :
{code}
Running org.apache.hadoop.hbase.client.TestReplicationShell
Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.002 sec - in
org.apache.hadoop.hbase.client.TestReplicationShell
Running org.apache.hadoop.hbase.client.TestShell
Running org.apache.hadoop.hbase.client.TestSecurityShell
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 15.182 sec - in
org.apache.hadoop.hbase.client.TestSecurityShell
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 364.39 sec - in
org.apache.hadoop.hbase.client.TestShell
Results :
Tests run: 3, Failures: 0, Errors: 0, Skipped: 1
{code}
Previously TestShell times out on the following platform on branch-1:
{code}
Linux cn012.a.com 2.6.32-504.el6.x86_64 #1 SMP Wed Oct 15 04:27:16 UTC 2014
x86_64 x86_64 x86_64 GNU/Linux
{code}
> Separate security shell tests from other shell tests
>
>
> Key: HBASE-14679
> URL: https://issues.apache.org/jira/browse/HBASE-14679
> Project: HBase
> Issue Type: Task
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Attachments: 14679-branch-1-v1.txt
>
>
> TestShell takes a long time to run, sometimes timing out (especially on
> branch-1).
> This issue proposes the following changes:
> separate security shell tests into their own test class
> use unique table names for different tests
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14679) Separate security shell tests from other shell tests
[ https://issues.apache.org/jira/browse/HBASE-14679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14969901#comment-14969901 ] stack commented on HBASE-14679: --- bq. I haven't dug deep enough to pinpoint the exact cause. It would help all around if you did. Cutting the balancer test in two, a tactic you tried in the past, does not seem to have got us over the hanging balancer problem... it seems to be still there. bq. From what I observed, it was related to security shell test: So, splitting the test would just move the problem into a new class? > Separate security shell tests from other shell tests > > > Key: HBASE-14679 > URL: https://issues.apache.org/jira/browse/HBASE-14679 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Attachments: 14679-branch-1-v1.txt > > > TestShell takes a long time to run, sometimes timing out (especially on > branch-1). > This issue proposes the following changes: > separate security shell tests into their own test class > use unique table names for different tests -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14679) Separate security shell tests from other shell tests
[
https://issues.apache.org/jira/browse/HBASE-14679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14970272#comment-14970272
]
Hadoop QA commented on HBASE-14679:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12768183/14679-branch-1-v1.txt
against branch-1 branch at commit eb4f9b8b32cf0551088a342cfa9b46b20593ac27.
ATTACHMENT ID: 12768183
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 19 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16187//console
This message is automatically generated.
> Separate security shell tests from other shell tests
>
>
> Key: HBASE-14679
> URL: https://issues.apache.org/jira/browse/HBASE-14679
> Project: HBase
> Issue Type: Task
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Attachments: 14679-branch-1-v1.txt, 14679-branch-1-v1.txt
>
>
> TestShell takes a long time to run, sometimes timing out (especially on
> branch-1).
> This issue proposes the following changes:
> separate security shell tests into their own test class
> use unique table names for different tests
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14679) Separate security shell tests from other shell tests
[ https://issues.apache.org/jira/browse/HBASE-14679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14970442#comment-14970442 ] stack commented on HBASE-14679: --- bq. Separating existing test into smaller ones has been used by others. Difference context. The case you cite was shot-in-the-dark. Here you seem to think the problem will exist post-split (going by your own words). > Separate security shell tests from other shell tests > > > Key: HBASE-14679 > URL: https://issues.apache.org/jira/browse/HBASE-14679 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Attachments: 14679-branch-1-v1.txt, 14679-branch-1-v1.txt > > > TestShell takes a long time to run, sometimes timing out (especially on > branch-1). > This issue proposes the following changes: > separate security shell tests into their own test class > use unique table names for different tests -- This message was sent by Atlassian JIRA (v6.3.4#6332)
