[jira] [Commented] (HBASE-14793) Allow limiting size of block into L1 block cache.
[ https://issues.apache.org/jira/browse/HBASE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15024405#comment-15024405 ] Hudson commented on HBASE-14793: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1137 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1137/]) HBASE-14793 Allow limiting size of block into L1 block cache. (apurtell: rev b5bb47f72159c340ec60956817819743a3a831b8) * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapper.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperStub.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java * hbase-hadoop1-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionServer.java * hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestLruBlockCache.java * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheStats.java > Allow limiting size of block into L1 block cache. > - > > Key: HBASE-14793 > URL: https://issues.apache.org/jira/browse/HBASE-14793 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.0, 1.1.2 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.17 > > Attachments: HBASE-14793-v1.patch, HBASE-14793-v3.patch, > HBASE-14793-v4.patch, HBASE-14793-v5.patch, HBASE-14793-v6.patch, > HBASE-14793-v7.patch, HBASE-14793.patch > > > G1GC does really badly with long lived large objects. Lets allow limiting the > size of a block that can be kept in the block cache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14793) Allow limiting size of block into L1 block cache.
[ https://issues.apache.org/jira/browse/HBASE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15024441#comment-15024441 ] Hudson commented on HBASE-14793: FAILURE: Integrated in HBase-0.98-matrix #264 (See [https://builds.apache.org/job/HBase-0.98-matrix/264/]) HBASE-14793 Allow limiting size of block into L1 block cache. (apurtell: rev b5bb47f72159c340ec60956817819743a3a831b8) * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java * hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestLruBlockCache.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapper.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperStub.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheStats.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java * hbase-hadoop1-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionServer.java * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java > Allow limiting size of block into L1 block cache. > - > > Key: HBASE-14793 > URL: https://issues.apache.org/jira/browse/HBASE-14793 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.0, 1.1.2 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.17 > > Attachments: HBASE-14793-v1.patch, HBASE-14793-v3.patch, > HBASE-14793-v4.patch, HBASE-14793-v5.patch, HBASE-14793-v6.patch, > HBASE-14793-v7.patch, HBASE-14793.patch > > > G1GC does really badly with long lived large objects. Lets allow limiting the > size of a block that can be kept in the block cache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14793) Allow limiting size of block into L1 block cache.
[ https://issues.apache.org/jira/browse/HBASE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015242#comment-15015242 ] Anoop Sam John commented on HBASE-14793: Sorry for being late here and asking after commit. Some Qs When the size of the block is more than this defined size and we have L1 and L2 cache, we can make sure at least we will cache it in L2? Data blocks will go to L2 block only by default unless we marked it for L1 cache. In that case also (marked for L1 cache) we can allow it to be cached to L2 ? In case of a setup of L1 and L2 cache with combinedMode=false (ie. L2 is set as victim handler for L1) we will just avoid caching the bigger blocks as the caching there 1st happens to L1. Here also we can directly put that block to L2 cache only? > Allow limiting size of block into L1 block cache. > - > > Key: HBASE-14793 > URL: https://issues.apache.org/jira/browse/HBASE-14793 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.0, 1.1.2 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: HBASE-14793-v1.patch, HBASE-14793-v3.patch, > HBASE-14793-v4.patch, HBASE-14793-v5.patch, HBASE-14793-v6.patch, > HBASE-14793-v7.patch, HBASE-14793.patch > > > G1GC does really badly with long lived large objects. Lets allow limiting the > size of a block that can be kept in the block cache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14793) Allow limiting size of block into L1 block cache.
[ https://issues.apache.org/jira/browse/HBASE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015244#comment-15015244 ] Elliott Clark commented on HBASE-14793: --- The L2 will never take a block that large. The are no arenas that large. > Allow limiting size of block into L1 block cache. > - > > Key: HBASE-14793 > URL: https://issues.apache.org/jira/browse/HBASE-14793 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.0, 1.1.2 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: HBASE-14793-v1.patch, HBASE-14793-v3.patch, > HBASE-14793-v4.patch, HBASE-14793-v5.patch, HBASE-14793-v6.patch, > HBASE-14793-v7.patch, HBASE-14793.patch > > > G1GC does really badly with long lived large objects. Lets allow limiting the > size of a block that can be kept in the block cache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14793) Allow limiting size of block into L1 block cache.
[ https://issues.apache.org/jira/browse/HBASE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15008907#comment-15008907 ] stack commented on HBASE-14793: --- When G1GC, there is no L2 going on? If there is an L2, the L1 only has index blocksand an index block in L1 needs limiting? Must be the former case? Its good to have a limit regardless. +1 on patch. Add release note honey. > Allow limiting size of block into L1 block cache. > - > > Key: HBASE-14793 > URL: https://issues.apache.org/jira/browse/HBASE-14793 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.0, 1.1.2 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: HBASE-14793-v1.patch, HBASE-14793-v3.patch, > HBASE-14793-v4.patch, HBASE-14793-v5.patch, HBASE-14793-v6.patch, > HBASE-14793.patch > > > G1GC does really badly with long lived large objects. Lets allow limiting the > size of a block that can be kept in the block cache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14793) Allow limiting size of block into L1 block cache.
[ https://issues.apache.org/jira/browse/HBASE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15009015#comment-15009015 ] Elliott Clark commented on HBASE-14793: --- bq.When G1GC, there is no L2 going on? That's one of the things we tried. A larger on heap cache with the g1. bq.Add release note honey. Will do honey. > Allow limiting size of block into L1 block cache. > - > > Key: HBASE-14793 > URL: https://issues.apache.org/jira/browse/HBASE-14793 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.0, 1.1.2 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: HBASE-14793-v1.patch, HBASE-14793-v3.patch, > HBASE-14793-v4.patch, HBASE-14793-v5.patch, HBASE-14793-v6.patch, > HBASE-14793.patch > > > G1GC does really badly with long lived large objects. Lets allow limiting the > size of a block that can be kept in the block cache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14793) Allow limiting size of block into L1 block cache.
[ https://issues.apache.org/jira/browse/HBASE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15009772#comment-15009772 ] Hudson commented on HBASE-14793: SUCCESS: Integrated in HBase-1.3-IT #317 (See [https://builds.apache.org/job/HBase-1.3-IT/317/]) HBASE-14793 Allow limiting size of block into L1 block cache. (eclark: rev 604c9b2cca3db8b40eccd37652d0bb9d348480f3) * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionServer.java * hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestLruBlockCache.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheStats.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapper.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperStub.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java > Allow limiting size of block into L1 block cache. > - > > Key: HBASE-14793 > URL: https://issues.apache.org/jira/browse/HBASE-14793 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.0, 1.1.2 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: HBASE-14793-v1.patch, HBASE-14793-v3.patch, > HBASE-14793-v4.patch, HBASE-14793-v5.patch, HBASE-14793-v6.patch, > HBASE-14793-v7.patch, HBASE-14793.patch > > > G1GC does really badly with long lived large objects. Lets allow limiting the > size of a block that can be kept in the block cache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14793) Allow limiting size of block into L1 block cache.
[ https://issues.apache.org/jira/browse/HBASE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15009812#comment-15009812 ] Hudson commented on HBASE-14793: FAILURE: Integrated in HBase-Trunk_matrix #475 (See [https://builds.apache.org/job/HBase-Trunk_matrix/475/]) HBASE-14793 Allow limiting size of block into L1 block cache. (eclark: rev a48d30984a9afad0b759aba6933e1b9807fdcd26) * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperStub.java * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionServer.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java * hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestLruBlockCache.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheStats.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapper.java > Allow limiting size of block into L1 block cache. > - > > Key: HBASE-14793 > URL: https://issues.apache.org/jira/browse/HBASE-14793 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.0, 1.1.2 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: HBASE-14793-v1.patch, HBASE-14793-v3.patch, > HBASE-14793-v4.patch, HBASE-14793-v5.patch, HBASE-14793-v6.patch, > HBASE-14793-v7.patch, HBASE-14793.patch > > > G1GC does really badly with long lived large objects. Lets allow limiting the > size of a block that can be kept in the block cache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14793) Allow limiting size of block into L1 block cache.
[ https://issues.apache.org/jira/browse/HBASE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15009356#comment-15009356 ] Hudson commented on HBASE-14793: SUCCESS: Integrated in HBase-1.2-IT #286 (See [https://builds.apache.org/job/HBase-1.2-IT/286/]) HBASE-14793 Allow limiting size of block into L1 block cache. (eclark: rev a5a12223059ef18c9cbb2d76c89277a927b97b99) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapper.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheStats.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperStub.java * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionServer.java * hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestLruBlockCache.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java > Allow limiting size of block into L1 block cache. > - > > Key: HBASE-14793 > URL: https://issues.apache.org/jira/browse/HBASE-14793 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.0, 1.1.2 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: HBASE-14793-v1.patch, HBASE-14793-v3.patch, > HBASE-14793-v4.patch, HBASE-14793-v5.patch, HBASE-14793-v6.patch, > HBASE-14793-v7.patch, HBASE-14793.patch > > > G1GC does really badly with long lived large objects. Lets allow limiting the > size of a block that can be kept in the block cache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14793) Allow limiting size of block into L1 block cache.
[
https://issues.apache.org/jira/browse/HBASE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15009379#comment-15009379
]
Hadoop QA commented on HBASE-14793:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12772782/HBASE-14793-v7.patch
against master branch at commit db42fc64f1e54ab8b47799eae7920f7298a5a406.
ATTACHMENT ID: 12772782
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 11 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16552//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16552//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16552//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16552//console
This message is automatically generated.
> Allow limiting size of block into L1 block cache.
> -
>
> Key: HBASE-14793
> URL: https://issues.apache.org/jira/browse/HBASE-14793
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 1.1.2
>Reporter: Elliott Clark
>Assignee: Elliott Clark
> Fix For: 2.0.0, 1.2.0, 1.3.0
>
> Attachments: HBASE-14793-v1.patch, HBASE-14793-v3.patch,
> HBASE-14793-v4.patch, HBASE-14793-v5.patch, HBASE-14793-v6.patch,
> HBASE-14793-v7.patch, HBASE-14793.patch
>
>
> G1GC does really badly with long lived large objects. Lets allow limiting the
> size of a block that can be kept in the block cache.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14793) Allow limiting size of block into L1 block cache.
[ https://issues.apache.org/jira/browse/HBASE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15009422#comment-15009422 ] Appy commented on HBASE-14793: -- +1 And... Yummyy! !http://fairtradeusa.org/sites/default/files/imagecache/feature_image/products/photo_carousel/honey.jpg|width=200! > Allow limiting size of block into L1 block cache. > - > > Key: HBASE-14793 > URL: https://issues.apache.org/jira/browse/HBASE-14793 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.0, 1.1.2 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: HBASE-14793-v1.patch, HBASE-14793-v3.patch, > HBASE-14793-v4.patch, HBASE-14793-v5.patch, HBASE-14793-v6.patch, > HBASE-14793-v7.patch, HBASE-14793.patch > > > G1GC does really badly with long lived large objects. Lets allow limiting the > size of a block that can be kept in the block cache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14793) Allow limiting size of block into L1 block cache.
[
https://issues.apache.org/jira/browse/HBASE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15008335#comment-15008335
]
Appy commented on HBASE-14793:
--
Hmm..this is new to me. Is {{CACHE_FIXED_OVERHEAD}} tracking the size of
LruBlockCache class? If yes, am confused why are we incrementing
{{ClassSize.REFERENCE}} instead of {{Bytes.SIZEOF_LONG}}.
To make sure if it was really tracking size of the class, I tried to
cross-check class members with the count for each type. Seems like the count
for boolean is wrong. {{forceInMemory}} was added in HBASE-10263 but isn't
accounted. It's a one line change. In case you update the patch, can you please
fix that too.
> Allow limiting size of block into L1 block cache.
> -
>
> Key: HBASE-14793
> URL: https://issues.apache.org/jira/browse/HBASE-14793
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 1.1.2
>Reporter: Elliott Clark
>Assignee: Elliott Clark
> Fix For: 2.0.0, 1.2.0, 1.3.0
>
> Attachments: HBASE-14793-v1.patch, HBASE-14793-v3.patch,
> HBASE-14793-v4.patch, HBASE-14793-v5.patch, HBASE-14793-v6.patch,
> HBASE-14793.patch
>
>
> G1GC does really badly with long lived large objects. Lets allow limiting the
> size of a block that can be kept in the block cache.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14793) Allow limiting size of block into L1 block cache.
[ https://issues.apache.org/jira/browse/HBASE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15008397#comment-15008397 ] Elliott Clark commented on HBASE-14793: --- The class doesn't actually have a long in it. It has a reference to an object AtomicLong. That reference usually is as the same size as a long but it doesn't have to be. > Allow limiting size of block into L1 block cache. > - > > Key: HBASE-14793 > URL: https://issues.apache.org/jira/browse/HBASE-14793 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.0, 1.1.2 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: HBASE-14793-v1.patch, HBASE-14793-v3.patch, > HBASE-14793-v4.patch, HBASE-14793-v5.patch, HBASE-14793-v6.patch, > HBASE-14793.patch > > > G1GC does really badly with long lived large objects. Lets allow limiting the > size of a block that can be kept in the block cache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14793) Allow limiting size of block into L1 block cache.
[ https://issues.apache.org/jira/browse/HBASE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15009678#comment-15009678 ] Hudson commented on HBASE-14793: SUCCESS: Integrated in HBase-1.3 #374 (See [https://builds.apache.org/job/HBase-1.3/374/]) HBASE-14793 Allow limiting size of block into L1 block cache. (eclark: rev 604c9b2cca3db8b40eccd37652d0bb9d348480f3) * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperStub.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionServer.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapper.java * hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestLruBlockCache.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheStats.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java > Allow limiting size of block into L1 block cache. > - > > Key: HBASE-14793 > URL: https://issues.apache.org/jira/browse/HBASE-14793 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.0, 1.1.2 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: HBASE-14793-v1.patch, HBASE-14793-v3.patch, > HBASE-14793-v4.patch, HBASE-14793-v5.patch, HBASE-14793-v6.patch, > HBASE-14793-v7.patch, HBASE-14793.patch > > > G1GC does really badly with long lived large objects. Lets allow limiting the > size of a block that can be kept in the block cache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14793) Allow limiting size of block into L1 block cache.
[ https://issues.apache.org/jira/browse/HBASE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15009623#comment-15009623 ] Hudson commented on HBASE-14793: FAILURE: Integrated in HBase-1.2 #378 (See [https://builds.apache.org/job/HBase-1.2/378/]) HBASE-14793 Allow limiting size of block into L1 block cache. (eclark: rev a5a12223059ef18c9cbb2d76c89277a927b97b99) * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java * hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestLruBlockCache.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheStats.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapper.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionServer.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperStub.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java > Allow limiting size of block into L1 block cache. > - > > Key: HBASE-14793 > URL: https://issues.apache.org/jira/browse/HBASE-14793 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.0, 1.1.2 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: HBASE-14793-v1.patch, HBASE-14793-v3.patch, > HBASE-14793-v4.patch, HBASE-14793-v5.patch, HBASE-14793-v6.patch, > HBASE-14793-v7.patch, HBASE-14793.patch > > > G1GC does really badly with long lived large objects. Lets allow limiting the > size of a block that can be kept in the block cache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14793) Allow limiting size of block into L1 block cache.
[
https://issues.apache.org/jira/browse/HBASE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15008024#comment-15008024
]
Hadoop QA commented on HBASE-14793:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12772646/HBASE-14793-v5.patch
against master branch at commit db42fc64f1e54ab8b47799eae7920f7298a5a406.
ATTACHMENT ID: 12772646
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 11 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.io.TestHeapSize
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16543//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16543//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16543//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16543//console
This message is automatically generated.
> Allow limiting size of block into L1 block cache.
> -
>
> Key: HBASE-14793
> URL: https://issues.apache.org/jira/browse/HBASE-14793
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 1.1.2
>Reporter: Elliott Clark
>Assignee: Elliott Clark
> Fix For: 2.0.0, 1.2.0, 1.3.0
>
> Attachments: HBASE-14793-v1.patch, HBASE-14793-v3.patch,
> HBASE-14793-v4.patch, HBASE-14793-v5.patch, HBASE-14793-v6.patch,
> HBASE-14793.patch
>
>
> G1GC does really badly with long lived large objects. Lets allow limiting the
> size of a block that can be kept in the block cache.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14793) Allow limiting size of block into L1 block cache.
[
https://issues.apache.org/jira/browse/HBASE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007963#comment-15007963
]
Hadoop QA commented on HBASE-14793:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12772640/HBASE-14793-v4.patch
against master branch at commit db42fc64f1e54ab8b47799eae7920f7298a5a406.
ATTACHMENT ID: 12772640
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 11 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.io.TestHeapSize
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16542//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16542//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16542//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16542//console
This message is automatically generated.
> Allow limiting size of block into L1 block cache.
> -
>
> Key: HBASE-14793
> URL: https://issues.apache.org/jira/browse/HBASE-14793
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 1.1.2
>Reporter: Elliott Clark
>Assignee: Elliott Clark
> Fix For: 2.0.0, 1.2.0, 1.3.0
>
> Attachments: HBASE-14793-v1.patch, HBASE-14793-v3.patch,
> HBASE-14793-v4.patch, HBASE-14793-v5.patch, HBASE-14793.patch
>
>
> G1GC does really badly with long lived large objects. Lets allow limiting the
> size of a block that can be kept in the block cache.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14793) Allow limiting size of block into L1 block cache.
[ https://issues.apache.org/jira/browse/HBASE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007786#comment-15007786 ] Elliott Clark commented on HBASE-14793: --- Sure let me get that. > Allow limiting size of block into L1 block cache. > - > > Key: HBASE-14793 > URL: https://issues.apache.org/jira/browse/HBASE-14793 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.0, 1.1.2 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: HBASE-14793-v1.patch, HBASE-14793.patch > > > G1GC does really badly with long lived large objects. Lets allow limiting the > size of a block that can be kept in the block cache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14793) Allow limiting size of block into L1 block cache.
[
https://issues.apache.org/jira/browse/HBASE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007854#comment-15007854
]
Appy commented on HBASE-14793:
--
+1 lgtm
nit: Seems like {{failedBlockAdditions}} is unused now. Maybe remove it's
declaration too?
> Allow limiting size of block into L1 block cache.
> -
>
> Key: HBASE-14793
> URL: https://issues.apache.org/jira/browse/HBASE-14793
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 1.1.2
>Reporter: Elliott Clark
>Assignee: Elliott Clark
> Fix For: 2.0.0, 1.2.0, 1.3.0
>
> Attachments: HBASE-14793-v1.patch, HBASE-14793-v3.patch,
> HBASE-14793-v4.patch, HBASE-14793.patch
>
>
> G1GC does really badly with long lived large objects. Lets allow limiting the
> size of a block that can be kept in the block cache.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14793) Allow limiting size of block into L1 block cache.
[
https://issues.apache.org/jira/browse/HBASE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15008180#comment-15008180
]
Hadoop QA commented on HBASE-14793:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12772650/HBASE-14793-v6.patch
against master branch at commit db42fc64f1e54ab8b47799eae7920f7298a5a406.
ATTACHMENT ID: 12772650
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 11 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16544//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16544//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16544//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16544//console
This message is automatically generated.
> Allow limiting size of block into L1 block cache.
> -
>
> Key: HBASE-14793
> URL: https://issues.apache.org/jira/browse/HBASE-14793
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 1.1.2
>Reporter: Elliott Clark
>Assignee: Elliott Clark
> Fix For: 2.0.0, 1.2.0, 1.3.0
>
> Attachments: HBASE-14793-v1.patch, HBASE-14793-v3.patch,
> HBASE-14793-v4.patch, HBASE-14793-v5.patch, HBASE-14793-v6.patch,
> HBASE-14793.patch
>
>
> G1GC does really badly with long lived large objects. Lets allow limiting the
> size of a block that can be kept in the block cache.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14793) Allow limiting size of block into L1 block cache.
[ https://issues.apache.org/jira/browse/HBASE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002720#comment-15002720 ] Andrew Purtell commented on HBASE-14793: bq. Emm, what about a metric to count the blocks which couldn't be cached because of this new threshold. Can that be useful? Maybe for tuning? what do you think? +1, I'd like that > Allow limiting size of block into L1 block cache. > - > > Key: HBASE-14793 > URL: https://issues.apache.org/jira/browse/HBASE-14793 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.0, 1.1.2 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: HBASE-14793-v1.patch, HBASE-14793.patch > > > G1GC does really badly with long lived large objects. Lets allow limiting the > size of a block that can be kept in the block cache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14793) Allow limiting size of block into L1 block cache.
[
https://issues.apache.org/jira/browse/HBASE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14999355#comment-14999355
]
Appy commented on HBASE-14793:
--
[~eclark], how do you plan to use the new variable 'maxBlockSize'?
Btw, there's an incomplete log message here. Also, please consider writing a
comment about why 12MB was chosen.
{code:java}
+
+if (buf.heapSize() > 12 * 1024 * 1024) {
+ LOG.warn("Trying to cache too large a ");
+}
+
{code}
> Allow limiting size of block into L1 block cache.
> -
>
> Key: HBASE-14793
> URL: https://issues.apache.org/jira/browse/HBASE-14793
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 1.1.2
>Reporter: Elliott Clark
>Assignee: Elliott Clark
> Fix For: 2.0.0, 1.2.0, 1.3.0
>
> Attachments: HBASE-14793.patch
>
>
> G1GC does really badly with long lived large objects. Lets allow limiting the
> size of a block that can be kept in the block cache.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14793) Allow limiting size of block into L1 block cache.
[ https://issues.apache.org/jira/browse/HBASE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14999371#comment-14999371 ] Elliott Clark commented on HBASE-14793: --- Yeah for some reason I hadn't committed the last version. oops. > Allow limiting size of block into L1 block cache. > - > > Key: HBASE-14793 > URL: https://issues.apache.org/jira/browse/HBASE-14793 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.0, 1.1.2 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: HBASE-14793.patch > > > G1GC does really badly with long lived large objects. Lets allow limiting the > size of a block that can be kept in the block cache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14793) Allow limiting size of block into L1 block cache.
[
https://issues.apache.org/jira/browse/HBASE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14999440#comment-14999440
]
Hadoop QA commented on HBASE-14793:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12771612/HBASE-14793.patch
against master branch at commit 1a6ec1bac65fa04a30a57891fb66dd248f3bed9c.
ATTACHMENT ID: 12771612
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.io.TestHeapSize
org.apache.hadoop.hbase.io.hfile.TestLruBlockCache
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16483//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16483//artifact/patchprocess/patchReleaseAuditWarnings.txt
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16483//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16483//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16483//console
This message is automatically generated.
> Allow limiting size of block into L1 block cache.
> -
>
> Key: HBASE-14793
> URL: https://issues.apache.org/jira/browse/HBASE-14793
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 1.1.2
>Reporter: Elliott Clark
>Assignee: Elliott Clark
> Fix For: 2.0.0, 1.2.0, 1.3.0
>
> Attachments: HBASE-14793-v1.patch, HBASE-14793.patch
>
>
> G1GC does really badly with long lived large objects. Lets allow limiting the
> size of a block that can be kept in the block cache.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14793) Allow limiting size of block into L1 block cache.
[ https://issues.apache.org/jira/browse/HBASE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14999446#comment-14999446 ] Appy commented on HBASE-14793: -- Emm, what about a metric to count the blocks which couldn't be cached because of this new threshold. Can that be useful? Maybe for tuning? what do you think? > Allow limiting size of block into L1 block cache. > - > > Key: HBASE-14793 > URL: https://issues.apache.org/jira/browse/HBASE-14793 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.0, 1.1.2 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: HBASE-14793-v1.patch, HBASE-14793.patch > > > G1GC does really badly with long lived large objects. Lets allow limiting the > size of a block that can be kept in the block cache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14793) Allow limiting size of block into L1 block cache.
[
https://issues.apache.org/jira/browse/HBASE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14999575#comment-14999575
]
Hadoop QA commented on HBASE-14793:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12771630/HBASE-14793-v1.patch
against master branch at commit c817aa386cdbadbfd8aae2721862b11a7034ab14.
ATTACHMENT ID: 12771630
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.io.TestHeapSize
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16486//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16486//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16486//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16486//console
This message is automatically generated.
> Allow limiting size of block into L1 block cache.
> -
>
> Key: HBASE-14793
> URL: https://issues.apache.org/jira/browse/HBASE-14793
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 1.1.2
>Reporter: Elliott Clark
>Assignee: Elliott Clark
> Fix For: 2.0.0, 1.2.0, 1.3.0
>
> Attachments: HBASE-14793-v1.patch, HBASE-14793.patch
>
>
> G1GC does really badly with long lived large objects. Lets allow limiting the
> size of a block that can be kept in the block cache.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14793) Allow limiting size of block into L1 block cache.
[ https://issues.apache.org/jira/browse/HBASE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14999758#comment-14999758 ] Jean-Marc Spaggiari commented on HBASE-14793: - Should we also put kind of a warning somewhere if someone configures blocks to be > the max, that mean they will never go into the cache? > Allow limiting size of block into L1 block cache. > - > > Key: HBASE-14793 > URL: https://issues.apache.org/jira/browse/HBASE-14793 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.0, 1.1.2 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: HBASE-14793-v1.patch, HBASE-14793.patch > > > G1GC does really badly with long lived large objects. Lets allow limiting the > size of a block that can be kept in the block cache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
