[jira] [Commented] (HBASE-14902) Revert some of the stringency recently introduced by checkstyle tightening
[ https://issues.apache.org/jira/browse/HBASE-14902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109270#comment-15109270 ] Hudson commented on HBASE-14902: FAILURE: Integrated in HBase-Trunk_matrix #646 (See [https://builds.apache.org/job/HBase-Trunk_matrix/646/]) Revert "HBASE-14902 Revert some of the stringency recently introduced by (stack: rev 5e08e2ceb6af231eebeff9f46e18d654a7b89338) * hbase-checkstyle/src/main/resources/hbase/checkstyle.xml > Revert some of the stringency recently introduced by checkstyle tightening > -- > > Key: HBASE-14902 > URL: https://issues.apache.org/jira/browse/HBASE-14902 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack > Fix For: 2.0.0 > > Attachments: 14902.part1.patch, 14902.patch, 14902.patch, braces.patch > > > I think we should undo some of the plugins that were recently added to > checkstyle. They are too much. > JavadocTagContinuationIndentationCheck is about adding indent if javadoc is > two lines or more (javadoc tool doesn't care) > NonEmptyAtclauseDescriptionCheck would have us add javadoc on each exception: > e.g. @throws IOException needs to have text added. > NeedBracesCheck has us undoing cases where an if fits all on one line (don't > want to start style wars but if short and fits on one line, I think its more > readable... but I could relent on this one ). > The first two at least should go. > You ok w/ that [~appy] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14902) Revert some of the stringency recently introduced by checkstyle tightening
[ https://issues.apache.org/jira/browse/HBASE-14902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15107601#comment-15107601 ] stack commented on HBASE-14902: --- Pushed the patch. Lets see if it breaks checkstyle again. > Revert some of the stringency recently introduced by checkstyle tightening > -- > > Key: HBASE-14902 > URL: https://issues.apache.org/jira/browse/HBASE-14902 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack > Fix For: 2.0.0 > > Attachments: 14902.part1.patch, 14902.patch, 14902.patch, braces.patch > > > I think we should undo some of the plugins that were recently added to > checkstyle. They are too much. > JavadocTagContinuationIndentationCheck is about adding indent if javadoc is > two lines or more (javadoc tool doesn't care) > NonEmptyAtclauseDescriptionCheck would have us add javadoc on each exception: > e.g. @throws IOException needs to have text added. > NeedBracesCheck has us undoing cases where an if fits all on one line (don't > want to start style wars but if short and fits on one line, I think its more > readable... but I could relent on this one ). > The first two at least should go. > You ok w/ that [~appy] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14902) Revert some of the stringency recently introduced by checkstyle tightening
[
https://issues.apache.org/jira/browse/HBASE-14902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15107571#comment-15107571
]
Hadoop QA commented on HBASE-14902:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
4s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
8s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 7s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
7s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
7s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s
{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
27m 48s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 9s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 20s
{color} | {color:green} hbase-checkstyle in the patch passed with JDK v1.8.0.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 10s
{color} | {color:green} hbase-checkstyle in the patch passed with JDK
v1.7.0_79. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 32m 56s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12783160/braces.patch |
| JIRA Issue | HBASE-14902 |
| Optional Tests | asflicense javac javadoc unit xml |
| uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 318814d |
| JDK v1.7.0_79 Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/189/testReport/ |
| modules | C: hbase-checkstyle U: hbase-checkstyle |
| Max memory used | 191MB |
| Powered by | Apache Yetus 0.1.0 http://yetus.apache.org |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/189/console |
This message was automatically generated.
> Revert some of the stringency recently introduced by checkstyle tightening
> --
>
> Key: HBASE-14902
> URL: https://issues.apache.org/jira/browse/HBASE-14902
> Project: HBase
> Issue Type: Sub-task
>Reporter: stack
>Assignee: stack
> Fix For: 2.0.0
>
> Attachments: 14902.part1.patch, 14902.patch, 14902.patch, braces.patch
>
>
> I think we should undo some of the plugins that were recently added to
> checkstyle. They are too much.
> JavadocTagContinuationIndentationCheck is about adding indent if javadoc is
> two lines or more (javadoc tool doesn't care)
> NonEmptyAtclauseDescriptionCheck would have us add javadoc on each exception:
> e.g. @throws IOException needs to have text added.
> NeedBracesCheck has us undoing cases where an if fits all on one line (don't
> want to start style wars but if short and fits on one line, I think its more
>
[jira] [Commented] (HBASE-14902) Revert some of the stringency recently introduced by checkstyle tightening
[ https://issues.apache.org/jira/browse/HBASE-14902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15107937#comment-15107937 ] Hudson commented on HBASE-14902: FAILURE: Integrated in HBase-Trunk_matrix #643 (See [https://builds.apache.org/job/HBase-Trunk_matrix/643/]) HBASE-14902 Revert some of the stringency recently introduced by (stack: rev 2c0394f078158ef668e75b74f589a7da59ff9e0e) * hbase-checkstyle/src/main/resources/hbase/checkstyle.xml > Revert some of the stringency recently introduced by checkstyle tightening > -- > > Key: HBASE-14902 > URL: https://issues.apache.org/jira/browse/HBASE-14902 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack > Fix For: 2.0.0 > > Attachments: 14902.part1.patch, 14902.patch, 14902.patch, braces.patch > > > I think we should undo some of the plugins that were recently added to > checkstyle. They are too much. > JavadocTagContinuationIndentationCheck is about adding indent if javadoc is > two lines or more (javadoc tool doesn't care) > NonEmptyAtclauseDescriptionCheck would have us add javadoc on each exception: > e.g. @throws IOException needs to have text added. > NeedBracesCheck has us undoing cases where an if fits all on one line (don't > want to start style wars but if short and fits on one line, I think its more > readable... but I could relent on this one ). > The first two at least should go. > You ok w/ that [~appy] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14902) Revert some of the stringency recently introduced by checkstyle tightening
[ https://issues.apache.org/jira/browse/HBASE-14902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15083487#comment-15083487 ] Mikhail Antonov commented on HBASE-14902: - Yeah after checkstyle rules have been tightened up, it became tricky to get a green response from build bot.. So I'm on reverting it. > Revert some of the stringency recently introduced by checkstyle tightening > -- > > Key: HBASE-14902 > URL: https://issues.apache.org/jira/browse/HBASE-14902 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack > Fix For: 2.0.0 > > Attachments: 14902.patch, 14902.patch > > > I think we should undo some of the plugins that were recently added to > checkstyle. They are too much. > JavadocTagContinuationIndentationCheck is about adding indent if javadoc is > two lines or more (javadoc tool doesn't care) > NonEmptyAtclauseDescriptionCheck would have us add javadoc on each exception: > e.g. @throws IOException needs to have text added. > NeedBracesCheck has us undoing cases where an if fits all on one line (don't > want to start style wars but if short and fits on one line, I think its more > readable... but I could relent on this one ). > The first two at least should go. > You ok w/ that [~appy] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14902) Revert some of the stringency recently introduced by checkstyle tightening
[ https://issues.apache.org/jira/browse/HBASE-14902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15084932#comment-15084932 ] Hudson commented on HBASE-14902: FAILURE: Integrated in HBase-Trunk_matrix #612 (See [https://builds.apache.org/job/HBase-Trunk_matrix/612/]) HBASE-14902 Revert some of the stringency recently introduced by (stack: rev 72d32cc96b6cda7d7dc17cf3dc88235b01534d43) * hbase-checkstyle/src/main/resources/hbase/checkstyle.xml > Revert some of the stringency recently introduced by checkstyle tightening > -- > > Key: HBASE-14902 > URL: https://issues.apache.org/jira/browse/HBASE-14902 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack > Fix For: 2.0.0 > > Attachments: 14902.part1.patch, 14902.patch, 14902.patch > > > I think we should undo some of the plugins that were recently added to > checkstyle. They are too much. > JavadocTagContinuationIndentationCheck is about adding indent if javadoc is > two lines or more (javadoc tool doesn't care) > NonEmptyAtclauseDescriptionCheck would have us add javadoc on each exception: > e.g. @throws IOException needs to have text added. > NeedBracesCheck has us undoing cases where an if fits all on one line (don't > want to start style wars but if short and fits on one line, I think its more > readable... but I could relent on this one ). > The first two at least should go. > You ok w/ that [~appy] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14902) Revert some of the stringency recently introduced by checkstyle tightening
[ https://issues.apache.org/jira/browse/HBASE-14902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15083970#comment-15083970 ] stack commented on HBASE-14902: --- Let me make a change at a time and see if I can see which breaks checkstyle. > Revert some of the stringency recently introduced by checkstyle tightening > -- > > Key: HBASE-14902 > URL: https://issues.apache.org/jira/browse/HBASE-14902 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack > Fix For: 2.0.0 > > Attachments: 14902.patch, 14902.patch > > > I think we should undo some of the plugins that were recently added to > checkstyle. They are too much. > JavadocTagContinuationIndentationCheck is about adding indent if javadoc is > two lines or more (javadoc tool doesn't care) > NonEmptyAtclauseDescriptionCheck would have us add javadoc on each exception: > e.g. @throws IOException needs to have text added. > NeedBracesCheck has us undoing cases where an if fits all on one line (don't > want to start style wars but if short and fits on one line, I think its more > readable... but I could relent on this one ). > The first two at least should go. > You ok w/ that [~appy] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14902) Revert some of the stringency recently introduced by checkstyle tightening
[ https://issues.apache.org/jira/browse/HBASE-14902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15083912#comment-15083912 ] Hudson commented on HBASE-14902: FAILURE: Integrated in HBase-Trunk_matrix #611 (See [https://builds.apache.org/job/HBase-Trunk_matrix/611/]) Revert "HBASE-14902 Revert some of the stringency recently introduced by (stack: rev 1c4edd2ab702488e21c4929a998c49a4208633fc) * hbase-checkstyle/src/main/resources/hbase/checkstyle.xml > Revert some of the stringency recently introduced by checkstyle tightening > -- > > Key: HBASE-14902 > URL: https://issues.apache.org/jira/browse/HBASE-14902 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack > Fix For: 2.0.0 > > Attachments: 14902.patch, 14902.patch > > > I think we should undo some of the plugins that were recently added to > checkstyle. They are too much. > JavadocTagContinuationIndentationCheck is about adding indent if javadoc is > two lines or more (javadoc tool doesn't care) > NonEmptyAtclauseDescriptionCheck would have us add javadoc on each exception: > e.g. @throws IOException needs to have text added. > NeedBracesCheck has us undoing cases where an if fits all on one line (don't > want to start style wars but if short and fits on one line, I think its more > readable... but I could relent on this one ). > The first two at least should go. > You ok w/ that [~appy] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14902) Revert some of the stringency recently introduced by checkstyle tightening
[ https://issues.apache.org/jira/browse/HBASE-14902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15082318#comment-15082318 ] Hudson commented on HBASE-14902: FAILURE: Integrated in HBase-Trunk_matrix #609 (See [https://builds.apache.org/job/HBase-Trunk_matrix/609/]) HBASE-14902 Revert some of the stringency recently introduced by (stack: rev 998b9371c9d9a6fe4a93e734ba0055c3e20e0b3e) * hbase-checkstyle/src/main/resources/hbase/checkstyle.xml > Revert some of the stringency recently introduced by checkstyle tightening > -- > > Key: HBASE-14902 > URL: https://issues.apache.org/jira/browse/HBASE-14902 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack > Fix For: 2.0.0 > > Attachments: 14902.patch, 14902.patch > > > I think we should undo some of the plugins that were recently added to > checkstyle. They are too much. > JavadocTagContinuationIndentationCheck is about adding indent if javadoc is > two lines or more (javadoc tool doesn't care) > NonEmptyAtclauseDescriptionCheck would have us add javadoc on each exception: > e.g. @throws IOException needs to have text added. > NeedBracesCheck has us undoing cases where an if fits all on one line (don't > want to start style wars but if short and fits on one line, I think its more > readable... but I could relent on this one ). > The first two at least should go. > You ok w/ that [~appy] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14902) Revert some of the stringency recently introduced by checkstyle tightening
[ https://issues.apache.org/jira/browse/HBASE-14902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15036684#comment-15036684 ] Appy commented on HBASE-14902: -- +1 on patch. Yeah, explicitly telling everyone about changes in checkstyles and reporting will be really good. Does sending a mail to dev@ sound good? I can do that. Or anything else you have in mind. > Revert some of the stringency recently introduced by checkstyle tightening > -- > > Key: HBASE-14902 > URL: https://issues.apache.org/jira/browse/HBASE-14902 > Project: HBase > Issue Type: Sub-task >Reporter: stack > Fix For: 2.0.0 > > Attachments: 14902.patch > > > I think we should undo some of the plugins that were recently added to > checkstyle. They are too much. > JavadocTagContinuationIndentationCheck is about adding indent if javadoc is > two lines or more (javadoc tool doesn't care) > NonEmptyAtclauseDescriptionCheck would have us add javadoc on each exception: > e.g. @throws IOException needs to have text added. > NeedBracesCheck has us undoing cases where an if fits all on one line (don't > want to start style wars but if short and fits on one line, I think its more > readable... but I could relent on this one ). > The first two at least should go. > You ok w/ that [~appy] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14902) Revert some of the stringency recently introduced by checkstyle tightening
[ https://issues.apache.org/jira/browse/HBASE-14902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15036720#comment-15036720 ] stack commented on HBASE-14902: --- I think mail to dev by the man who did the work would be good starting point. After any questions have all been resolved, we should add a little doc to refguide. Nice. > Revert some of the stringency recently introduced by checkstyle tightening > -- > > Key: HBASE-14902 > URL: https://issues.apache.org/jira/browse/HBASE-14902 > Project: HBase > Issue Type: Sub-task >Reporter: stack > Fix For: 2.0.0 > > Attachments: 14902.patch > > > I think we should undo some of the plugins that were recently added to > checkstyle. They are too much. > JavadocTagContinuationIndentationCheck is about adding indent if javadoc is > two lines or more (javadoc tool doesn't care) > NonEmptyAtclauseDescriptionCheck would have us add javadoc on each exception: > e.g. @throws IOException needs to have text added. > NeedBracesCheck has us undoing cases where an if fits all on one line (don't > want to start style wars but if short and fits on one line, I think its more > readable... but I could relent on this one ). > The first two at least should go. > You ok w/ that [~appy] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14902) Revert some of the stringency recently introduced by checkstyle tightening
[ https://issues.apache.org/jira/browse/HBASE-14902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15035036#comment-15035036 ] Appy commented on HBASE-14902: -- Here are the reasons why I think it'd be good to have them. Would be easy to turn off if people feel otherwise JavadocTagContinuationIndentationCheck : Javadoc tool certainly doesn't care about it since it simply wraps the text in the browser based on width. However, we almost always see the comments in IDEs, and there are easily 5+ different ways I have seen them formatted. Having formatted comments isn't anything worth much worry, but wouldn't hurt if there are 2-3 simple rules which makes commenting more consistent. NonEmptyAtclauseDescriptionCheck: Ref guide has this guideline [here|http://hbase.apache.org/book.html#common.patch.feedback.javadoc.defaults] . I also feel like we should have this. "@throws SomeException" before functions isn't really of any use unless it explains why and when the exception is thrown. Same for arguments and return types. These are always auto-generated, and having checks around these tags will make devs think about them and write better comments (or at the very least, get rid of useless lines). NeedBracesCheck: Anything is fine. [Here's|http://checkstyle.sourceforge.net/config_blocks.html#NeedBraces] how to allow single line statements > Revert some of the stringency recently introduced by checkstyle tightening > -- > > Key: HBASE-14902 > URL: https://issues.apache.org/jira/browse/HBASE-14902 > Project: HBase > Issue Type: Sub-task >Reporter: stack > Fix For: 2.0.0 > > > I think we should undo some of the plugins that were recently added to > checkstyle. They are too much. > JavadocTagContinuationIndentationCheck is about adding indent if javadoc is > two lines or more (javadoc tool doesn't care) > NonEmptyAtclauseDescriptionCheck would have us add javadoc on each exception: > e.g. @throws IOException needs to have text added. > NeedBracesCheck has us undoing cases where an if fits all on one line (don't > want to start style wars but if short and fits on one line, I think its more > readable... but I could relent on this one ). > The first two at least should go. > You ok w/ that [~appy] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14902) Revert some of the stringency recently introduced by checkstyle tightening
[ https://issues.apache.org/jira/browse/HBASE-14902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15035071#comment-15035071 ] stack commented on HBASE-14902: --- Let me add the single line allowance. Thanks for quoting the Ref guide on empty lines. Agree. Let me make sure javadoc does not complain if @throws not present. On first item, when it says this: JavadocTagContinuationIndentation Line continuation have incorrect indentation level, expected level should be 4. it wants me to put four spaces after the '*' when I add a second line on javadoc? It seems so arbitrary. Why not two or none? Most of the code seems to have none.. just continue on the line below? Shouldn't this be the default? > Revert some of the stringency recently introduced by checkstyle tightening > -- > > Key: HBASE-14902 > URL: https://issues.apache.org/jira/browse/HBASE-14902 > Project: HBase > Issue Type: Sub-task >Reporter: stack > Fix For: 2.0.0 > > > I think we should undo some of the plugins that were recently added to > checkstyle. They are too much. > JavadocTagContinuationIndentationCheck is about adding indent if javadoc is > two lines or more (javadoc tool doesn't care) > NonEmptyAtclauseDescriptionCheck would have us add javadoc on each exception: > e.g. @throws IOException needs to have text added. > NeedBracesCheck has us undoing cases where an if fits all on one line (don't > want to start style wars but if short and fits on one line, I think its more > readable... but I could relent on this one ). > The first two at least should go. > You ok w/ that [~appy] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14902) Revert some of the stringency recently introduced by checkstyle tightening
[
https://issues.apache.org/jira/browse/HBASE-14902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15035139#comment-15035139
]
Appy commented on HBASE-14902:
--
{quote}
Let me add the single line allowance.
{quote}
Seems fairly prevalent in the code
([trunkCheckstyle|https://builds.apache.org/job/PreCommit-HBASE-Build/16722/artifact/patchprocess/trunkCheckstyle.xml]
~1700) . Let's do it.
{noquote}
Thanks for quoting the Ref guide on empty lines. Agree. Let me make sure
javadoc does not complain if @throws not present.
On first item, when it says this: JavadocTagContinuationIndentation Line
continuation have incorrect indentation level, expected level should be 4.
it wants me to put four spaces after the '*' when I add a second line on
javadoc? It seems so arbitrary. Why not two or none? Most of the code seems to
have none.. just continue on the line below? Shouldn't this be the default?
{quote}
Yeah, 'what's the right number' is kind of an issue. Since there's no good
answer and corresponding justification, the best I can think is, lets choose
what's most prevalent in the code.
With 4 spaces, #errors = 844
With 2 spaces, #errors = 790
With 0 spaces, #errors = 0 (Something's clearly wrong, it throws no error. So
won't be useful in checking anything)
Lets choose 2, given it's also the indentation we follow in code.
> Revert some of the stringency recently introduced by checkstyle tightening
> --
>
> Key: HBASE-14902
> URL: https://issues.apache.org/jira/browse/HBASE-14902
> Project: HBase
> Issue Type: Sub-task
>Reporter: stack
> Fix For: 2.0.0
>
>
> I think we should undo some of the plugins that were recently added to
> checkstyle. They are too much.
> JavadocTagContinuationIndentationCheck is about adding indent if javadoc is
> two lines or more (javadoc tool doesn't care)
> NonEmptyAtclauseDescriptionCheck would have us add javadoc on each exception:
> e.g. @throws IOException needs to have text added.
> NeedBracesCheck has us undoing cases where an if fits all on one line (don't
> want to start style wars but if short and fits on one line, I think its more
> readable... but I could relent on this one ).
> The first two at least should go.
> You ok w/ that [~appy]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
