[jira] [Commented] (HBASE-15059) Allow 0.94 to compile against Hadoop 2.7.x
[
https://issues.apache.org/jira/browse/HBASE-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15102894#comment-15102894
]
Sean Busbey commented on HBASE-15059:
-
yeah, it's just to set {{-DcompileSource=1.7}} if you want to run with Hadoop
2.7. It should include a warning about how this will mean the generated jars
won't be usable with jdk 6.
> Allow 0.94 to compile against Hadoop 2.7.x
> --
>
> Key: HBASE-15059
> URL: https://issues.apache.org/jira/browse/HBASE-15059
> Project: HBase
> Issue Type: Bug
>Reporter: Lars Hofhansl
>Assignee: Lars Hofhansl
> Fix For: 0.94.28
>
> Attachments: 15059-v2.txt, 15059.txt
>
>
> Currently HBase 0.94 cannot be compiled against Hadoop 2.7.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15059) Allow 0.94 to compile against Hadoop 2.7.x
[ https://issues.apache.org/jira/browse/HBASE-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15102882#comment-15102882 ] Lars Hofhansl commented on HBASE-15059: --- Chatted with [~stack] about TimeStampingFileContext occurring in hadoop-metrics.properties. We think it's still OK to remove. So I'll update the release notes and the instructions in the pom to use JDK7 when building with Hadoop 2.7. > Allow 0.94 to compile against Hadoop 2.7.x > -- > > Key: HBASE-15059 > URL: https://issues.apache.org/jira/browse/HBASE-15059 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl > Fix For: 0.94.28 > > Attachments: 15059-v2.txt, 15059.txt > > > Currently HBase 0.94 cannot be compiled against Hadoop 2.7. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15059) Allow 0.94 to compile against Hadoop 2.7.x
[ https://issues.apache.org/jira/browse/HBASE-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15102872#comment-15102872 ] Lars Hofhansl commented on HBASE-15059: --- [~busbey], aren't the new instructions just to build with JDK7 or later? > Allow 0.94 to compile against Hadoop 2.7.x > -- > > Key: HBASE-15059 > URL: https://issues.apache.org/jira/browse/HBASE-15059 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl > Fix For: 0.94.28 > > Attachments: 15059-v2.txt, 15059.txt > > > Currently HBase 0.94 cannot be compiled against Hadoop 2.7. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15059) Allow 0.94 to compile against Hadoop 2.7.x
[ https://issues.apache.org/jira/browse/HBASE-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15097703#comment-15097703 ] Lars Hofhansl commented on HBASE-15059: --- Ah yes, I built with JDK7 and JDK8 only. I do have an env with JDK6 anymore (other than the Apache Jenkins boxes). Could document the compile instructions (just like I did w.r.t. recompiling the PB generated files) I also found the class I removed shows up hadoop-metrics.properties (only commented out, but clearly with the intend to be used when uncommented). So without going to multiple modules like in 0.98+ this might be hard to impossible to do now. I have very little time in in the next few weeks, I'll try to look into this. There's no hurry really, I'll do the last 0.94 when it's ready. > Allow 0.94 to compile against Hadoop 2.7.x > -- > > Key: HBASE-15059 > URL: https://issues.apache.org/jira/browse/HBASE-15059 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl > Fix For: 0.94.28 > > Attachments: 15059-v2.txt, 15059.txt > > > Currently HBase 0.94 cannot be compiled against Hadoop 2.7. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15059) Allow 0.94 to compile against Hadoop 2.7.x
[ https://issues.apache.org/jira/browse/HBASE-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15083971#comment-15083971 ] Hudson commented on HBASE-15059: SUCCESS: Integrated in HBase-0.94-security #590 (See [https://builds.apache.org/job/HBase-0.94-security/590/]) HBASE-15059 Allow 0.94 to compile against Hadoop 2.7.x. (larsh: rev dd5660444a2587840bf982559d5b48f8a8e74e3c) * pom.xml * src/main/java/org/apache/hadoop/hbase/regionserver/RSDumpServlet.java * src/main/java/org/apache/hadoop/hbase/master/MasterDumpServlet.java * src/main/java/org/apache/hadoop/hbase/util/Threads.java * dev-support/build-proto.sh * src/test/java/org/apache/hadoop/hbase/metrics/file/TestTimeStampingMetricsContext.java * src/main/java/org/apache/hadoop/hbase/metrics/file/TimeStampingFileContext.java > Allow 0.94 to compile against Hadoop 2.7.x > -- > > Key: HBASE-15059 > URL: https://issues.apache.org/jira/browse/HBASE-15059 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl > Fix For: 0.94.28 > > Attachments: 15059-v2.txt, 15059.txt > > > Currently HBase 0.94 cannot be compiled against Hadoop 2.7. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15059) Allow 0.94 to compile against Hadoop 2.7.x
[ https://issues.apache.org/jira/browse/HBASE-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15083791#comment-15083791 ] Hudson commented on HBASE-15059: FAILURE: Integrated in HBase-0.94-JDK7 #247 (See [https://builds.apache.org/job/HBase-0.94-JDK7/247/]) HBASE-15059 Allow 0.94 to compile against Hadoop 2.7.x. (larsh: rev dd5660444a2587840bf982559d5b48f8a8e74e3c) * src/main/java/org/apache/hadoop/hbase/regionserver/RSDumpServlet.java * src/main/java/org/apache/hadoop/hbase/util/Threads.java * src/main/java/org/apache/hadoop/hbase/master/MasterDumpServlet.java * src/test/java/org/apache/hadoop/hbase/metrics/file/TestTimeStampingMetricsContext.java * pom.xml * src/main/java/org/apache/hadoop/hbase/metrics/file/TimeStampingFileContext.java * dev-support/build-proto.sh > Allow 0.94 to compile against Hadoop 2.7.x > -- > > Key: HBASE-15059 > URL: https://issues.apache.org/jira/browse/HBASE-15059 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl > Fix For: 0.94.28 > > Attachments: 15059-v2.txt, 15059.txt > > > Currently HBase 0.94 cannot be compiled against Hadoop 2.7. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15059) Allow 0.94 to compile against Hadoop 2.7.x
[ https://issues.apache.org/jira/browse/HBASE-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15082574#comment-15082574 ] Hudson commented on HBASE-15059: FAILURE: Integrated in HBase-0.94 #1480 (See [https://builds.apache.org/job/HBase-0.94/1480/]) HBASE-15059 Allow 0.94 to compile against Hadoop 2.7.x. (larsh: rev dd5660444a2587840bf982559d5b48f8a8e74e3c) * src/main/java/org/apache/hadoop/hbase/master/MasterDumpServlet.java * src/main/java/org/apache/hadoop/hbase/metrics/file/TimeStampingFileContext.java * src/main/java/org/apache/hadoop/hbase/util/Threads.java * dev-support/build-proto.sh * src/test/java/org/apache/hadoop/hbase/metrics/file/TestTimeStampingMetricsContext.java * src/main/java/org/apache/hadoop/hbase/regionserver/RSDumpServlet.java * pom.xml > Allow 0.94 to compile against Hadoop 2.7.x > -- > > Key: HBASE-15059 > URL: https://issues.apache.org/jira/browse/HBASE-15059 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl > Fix For: 0.94.28 > > Attachments: 15059-v2.txt, 15059.txt > > > Currently HBase 0.94 cannot be compiled against Hadoop 2.7. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15059) Allow 0.94 to compile against Hadoop 2.7.x
[ https://issues.apache.org/jira/browse/HBASE-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15082202#comment-15082202 ] Lars Hofhansl commented on HBASE-15059: --- bq. Where you going to doc how to make it work on 2.7/jdk8? In the release message for the release? That should be enough I'd say. Was thinking 3 places: # comment in the pom (where it defines the 2.7 profile), can have a prominent comment there, that pb classes need to be recompiled and how to do that # in the release notes here # in the release message for the release > Allow 0.94 to compile against Hadoop 2.7.x > -- > > Key: HBASE-15059 > URL: https://issues.apache.org/jira/browse/HBASE-15059 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl > Fix For: 0.94.28 > > Attachments: 15059-v2.txt, 15059.txt > > > Currently HBase 0.94 cannot be compiled against Hadoop 2.7. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15059) Allow 0.94 to compile against Hadoop 2.7.x
[ https://issues.apache.org/jira/browse/HBASE-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15082088#comment-15082088 ] stack commented on HBASE-15059: --- Ok on doc'ing how. Yeah, need to minimize change in last point release. We have a hadoop 2.6 profile? I suppose anyone who needs it can figure how with this 2.7 profile in place. Yeah, shout that TimeStampingFileContext is gone (but ok to remove it since messes up jdk8) +1 on patch. Where you going to doc how to make it work on 2.7/jdk8? In the release message for the release? That should be enough I'd say. > Allow 0.94 to compile against Hadoop 2.7.x > -- > > Key: HBASE-15059 > URL: https://issues.apache.org/jira/browse/HBASE-15059 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl > Fix For: 0.94.28 > > Attachments: 15059-v2.txt, 15059.txt > > > Currently HBase 0.94 cannot be compiled against Hadoop 2.7. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15059) Allow 0.94 to compile against Hadoop 2.7.x
[ https://issues.apache.org/jira/browse/HBASE-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15081994#comment-15081994 ] Andrew Purtell commented on HBASE-15059: bq. I think I'd rather document the process (over recompiling PB every time, since that requires the correct version of protoc on the machine as you say, even when it is not needed). Ok, it's the last release before EOL anyway > Allow 0.94 to compile against Hadoop 2.7.x > -- > > Key: HBASE-15059 > URL: https://issues.apache.org/jira/browse/HBASE-15059 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl > Fix For: 0.94.28 > > Attachments: 15059-v2.txt, 15059.txt > > > Currently HBase 0.94 cannot be compiled against Hadoop 2.7. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15059) Allow 0.94 to compile against Hadoop 2.7.x
[ https://issues.apache.org/jira/browse/HBASE-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15081976#comment-15081976 ] Lars Hofhansl commented on HBASE-15059: --- I think I'd rather document the process (over recompiling PB every time, since that requires the correct version of protoc on the machine as you say, even when it is not needed). At least it is possible to build against Hadoop 7.x Another option is to not override the protobuf version to pull in, but require an explicit -Dprotobuf.version=2.5.0 (could even add a comment in pom.xml to that extend). That would make the failure explicit at runtime. Folks would then look into what failed and find the instructions here, which would include to call build-proto.sh. Trying not to overcomplicate things. :) Thoughts? > Allow 0.94 to compile against Hadoop 2.7.x > -- > > Key: HBASE-15059 > URL: https://issues.apache.org/jira/browse/HBASE-15059 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl > Fix For: 0.94.28 > > Attachments: 15059-v2.txt, 15059.txt > > > Currently HBase 0.94 cannot be compiled against Hadoop 2.7. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15059) Allow 0.94 to compile against Hadoop 2.7.x
[ https://issues.apache.org/jira/browse/HBASE-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15081554#comment-15081554 ] Andrew Purtell commented on HBASE-15059: I think it's ok to change the protobuf dependency and required compiler version only when asked for with a specific Hadoop profile. However, then we should probably invoke build-proto.sh via maven at every build, in case the pbuf target versions has changed (2.4 vs 2.5)? And also check which version of the compiler we have on the path to ensure it's the necessary one for the build parameters. Lovely. Removing TimeStampingFileContext in a point release is iffy. Since this is the last expected release of 0.94 I think it's fine, but be sure to mention it in the release notes. > Allow 0.94 to compile against Hadoop 2.7.x > -- > > Key: HBASE-15059 > URL: https://issues.apache.org/jira/browse/HBASE-15059 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl > Fix For: 0.94.28 > > Attachments: 15059-v2.txt, 15059.txt > > > Currently HBase 0.94 cannot be compiled against Hadoop 2.7. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15059) Allow 0.94 to compile against Hadoop 2.7.x
[ https://issues.apache.org/jira/browse/HBASE-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15076751#comment-15076751 ] Lars Hofhansl commented on HBASE-15059: --- Ping... :) Good to commit V2? > Allow 0.94 to compile against Hadoop 2.7.x > -- > > Key: HBASE-15059 > URL: https://issues.apache.org/jira/browse/HBASE-15059 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl > Fix For: 0.94.28 > > Attachments: 15059-v2.txt, 15059.txt > > > Currently HBase 0.94 cannot be compiled against Hadoop 2.7. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15059) Allow 0.94 to compile against Hadoop 2.7.x
[ https://issues.apache.org/jira/browse/HBASE-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15076053#comment-15076053 ] Lars Hofhansl commented on HBASE-15059: --- [~stack] you OK with committing V2? > Allow 0.94 to compile against Hadoop 2.7.x > -- > > Key: HBASE-15059 > URL: https://issues.apache.org/jira/browse/HBASE-15059 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl > Fix For: 0.94.28 > > Attachments: 15059-v2.txt, 15059.txt > > > Currently HBase 0.94 cannot be compiled against Hadoop 2.7. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15059) Allow 0.94 to compile against Hadoop 2.7.x
[ https://issues.apache.org/jira/browse/HBASE-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075526#comment-15075526 ] Lars Hofhansl commented on HBASE-15059: --- bq. Too big a change for point release. Will make it so can't run on hadoop 1s. Agreed. The patch does this now: * PB 2.4.0a is used by default. * If -Dhadoop.profile=2.7 is specified then PB 2.5 and commons.io 2.4 will be pulled in as dependencies * When building for later Hadoops the user has to manually execute dev-support.build-proto.sh, before building the rest of HBase Would be nice to automate the last part via maven, but I think for 0.94 that might be overkill. > Allow 0.94 to compile against Hadoop 2.7.x > -- > > Key: HBASE-15059 > URL: https://issues.apache.org/jira/browse/HBASE-15059 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl > Fix For: 0.94.28 > > Attachments: 15059-v2.txt, 15059.txt > > > Currently HBase 0.94 cannot be compiled against Hadoop 2.7. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15059) Allow 0.94 to compile against Hadoop 2.7.x
[ https://issues.apache.org/jira/browse/HBASE-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075517#comment-15075517 ] Lars Hofhansl commented on HBASE-15059: --- Thanks. What do you think about this change? Need to state somewhere that one needs to regenerate the protobuf code (and since I couldn't figure out how to do that, I added the older shell-script that master used to have). > Allow 0.94 to compile against Hadoop 2.7.x > -- > > Key: HBASE-15059 > URL: https://issues.apache.org/jira/browse/HBASE-15059 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl > Fix For: 0.94.28 > > Attachments: 15059-v2.txt, 15059.txt > > > Currently HBase 0.94 cannot be compiled against Hadoop 2.7. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15059) Allow 0.94 to compile against Hadoop 2.7.x
[ https://issues.apache.org/jira/browse/HBASE-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075472#comment-15075472 ] stack commented on HBASE-15059: --- bq. Could always force protobug 2.5.0, but not sure what implications this has. Too big a change for point release. Will make it so can't run on hadoop 1s. > Allow 0.94 to compile against Hadoop 2.7.x > -- > > Key: HBASE-15059 > URL: https://issues.apache.org/jira/browse/HBASE-15059 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl > Fix For: 0.94.28 > > Attachments: 15059-v2.txt, 15059.txt > > > Currently HBase 0.94 cannot be compiled against Hadoop 2.7. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15059) Allow 0.94 to compile against Hadoop 2.7.x
[ https://issues.apache.org/jira/browse/HBASE-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075455#comment-15075455 ] stack commented on HBASE-15059: --- +1 Just shout loud you've removed this file. Anyone interested can do the work to get it going w/ later hadoop versions > Allow 0.94 to compile against Hadoop 2.7.x > -- > > Key: HBASE-15059 > URL: https://issues.apache.org/jira/browse/HBASE-15059 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl > Fix For: 0.94.28 > > Attachments: 15059.txt > > > Currently HBase 0.94 cannot be compiled against Hadoop 2.7. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
