[jira] [Commented] (HBASE-15087) Fix hbase-common findbugs complaints
[ https://issues.apache.org/jira/browse/HBASE-15087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101154#comment-15101154 ] Hudson commented on HBASE-15087: SUCCESS: Integrated in HBase-1.3-IT #438 (See [https://builds.apache.org/job/HBase-1.3-IT/438/]) HBASE-15087 Fix hbase-common findbugs complaints (stack: rev 546adefcd606d63b8b838244ba309e99af80c05c) * hbase-common/src/main/java/org/apache/hadoop/hbase/types/CopyOnWriteArrayMap.java * hbase-common/src/main/java/org/apache/hadoop/hbase/trace/SpanReceiverHost.java * hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAccess.java * hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java * hbase-common/src/main/java/org/apache/hadoop/hbase/util/Threads.java * hbase-common/src/main/java/org/apache/hadoop/hbase/ProcedureInfo.java * hbase-common/src/main/java/org/apache/hadoop/hbase/JitterScheduledThreadPoolExecutorImpl.java * hbase-common/src/main/java/org/apache/hadoop/hbase/util/DNS.java * hbase-common/src/main/java/org/apache/hadoop/hbase/util/DynamicClassLoader.java * hbase-common/src/main/java/org/apache/hadoop/hbase/util/PrettyPrinter.java > Fix hbase-common findbugs complaints > > > Key: HBASE-15087 > URL: https://issues.apache.org/jira/browse/HBASE-15087 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: stack >Assignee: Stack > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: 15087.patch, 15087v2.patch, 15087v3.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15087) Fix hbase-common findbugs complaints
[ https://issues.apache.org/jira/browse/HBASE-15087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15099257#comment-15099257 ] stack commented on HBASE-15087: --- Backported to branch-1 and branch-1.2 > Fix hbase-common findbugs complaints > > > Key: HBASE-15087 > URL: https://issues.apache.org/jira/browse/HBASE-15087 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: stack >Assignee: Stack > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: 15087.patch, 15087v2.patch, 15087v3.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15087) Fix hbase-common findbugs complaints
[ https://issues.apache.org/jira/browse/HBASE-15087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101169#comment-15101169 ] Hudson commented on HBASE-15087: SUCCESS: Integrated in HBase-1.2-IT #395 (See [https://builds.apache.org/job/HBase-1.2-IT/395/]) HBASE-15087 Fix hbase-common findbugs complaints (stack: rev ab0651ed2bde277512f0ba869858fc77ebada92c) * hbase-common/src/main/java/org/apache/hadoop/hbase/util/DynamicClassLoader.java * hbase-common/src/main/java/org/apache/hadoop/hbase/util/Threads.java * hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java * hbase-common/src/main/java/org/apache/hadoop/hbase/types/CopyOnWriteArrayMap.java * hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAccess.java * hbase-common/src/main/java/org/apache/hadoop/hbase/JitterScheduledThreadPoolExecutorImpl.java * hbase-common/src/main/java/org/apache/hadoop/hbase/ProcedureInfo.java * hbase-common/src/main/java/org/apache/hadoop/hbase/trace/SpanReceiverHost.java * hbase-common/src/main/java/org/apache/hadoop/hbase/util/PrettyPrinter.java * hbase-common/src/main/java/org/apache/hadoop/hbase/util/DNS.java > Fix hbase-common findbugs complaints > > > Key: HBASE-15087 > URL: https://issues.apache.org/jira/browse/HBASE-15087 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: stack >Assignee: Stack > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: 15087.patch, 15087v2.patch, 15087v3.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15087) Fix hbase-common findbugs complaints
[ https://issues.apache.org/jira/browse/HBASE-15087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101224#comment-15101224 ] Hudson commented on HBASE-15087: FAILURE: Integrated in HBase-1.2 #505 (See [https://builds.apache.org/job/HBase-1.2/505/]) HBASE-15087 Fix hbase-common findbugs complaints (stack: rev ab0651ed2bde277512f0ba869858fc77ebada92c) * hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAccess.java * hbase-common/src/main/java/org/apache/hadoop/hbase/util/DynamicClassLoader.java * hbase-common/src/main/java/org/apache/hadoop/hbase/util/DNS.java * hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java * hbase-common/src/main/java/org/apache/hadoop/hbase/JitterScheduledThreadPoolExecutorImpl.java * hbase-common/src/main/java/org/apache/hadoop/hbase/ProcedureInfo.java * hbase-common/src/main/java/org/apache/hadoop/hbase/trace/SpanReceiverHost.java * hbase-common/src/main/java/org/apache/hadoop/hbase/util/Threads.java * hbase-common/src/main/java/org/apache/hadoop/hbase/util/PrettyPrinter.java * hbase-common/src/main/java/org/apache/hadoop/hbase/types/CopyOnWriteArrayMap.java > Fix hbase-common findbugs complaints > > > Key: HBASE-15087 > URL: https://issues.apache.org/jira/browse/HBASE-15087 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: stack >Assignee: Stack > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: 15087.patch, 15087v2.patch, 15087v3.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15087) Fix hbase-common findbugs complaints
[ https://issues.apache.org/jira/browse/HBASE-15087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101355#comment-15101355 ] Hudson commented on HBASE-15087: SUCCESS: Integrated in HBase-1.3 #496 (See [https://builds.apache.org/job/HBase-1.3/496/]) HBASE-15087 Fix hbase-common findbugs complaints (stack: rev 546adefcd606d63b8b838244ba309e99af80c05c) * hbase-common/src/main/java/org/apache/hadoop/hbase/trace/SpanReceiverHost.java * hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java * hbase-common/src/main/java/org/apache/hadoop/hbase/util/Threads.java * hbase-common/src/main/java/org/apache/hadoop/hbase/types/CopyOnWriteArrayMap.java * hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAccess.java * hbase-common/src/main/java/org/apache/hadoop/hbase/ProcedureInfo.java * hbase-common/src/main/java/org/apache/hadoop/hbase/util/DNS.java * hbase-common/src/main/java/org/apache/hadoop/hbase/util/PrettyPrinter.java * hbase-common/src/main/java/org/apache/hadoop/hbase/JitterScheduledThreadPoolExecutorImpl.java * hbase-common/src/main/java/org/apache/hadoop/hbase/util/DynamicClassLoader.java > Fix hbase-common findbugs complaints > > > Key: HBASE-15087 > URL: https://issues.apache.org/jira/browse/HBASE-15087 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: stack >Assignee: Stack > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: 15087.patch, 15087v2.patch, 15087v3.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15087) Fix hbase-common findbugs complaints
[ https://issues.apache.org/jira/browse/HBASE-15087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15093532#comment-15093532 ] stack commented on HBASE-15087: --- Thanks for +1s lads. I pushed the patch. This fixes the findbugs complaints noted above in common though it complains they still exist. Lets see if commit changes hbase-common findbugs counts. > Fix hbase-common findbugs complaints > > > Key: HBASE-15087 > URL: https://issues.apache.org/jira/browse/HBASE-15087 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: stack >Assignee: Stack > Fix For: 2.0.0 > > Attachments: 15087.patch, 15087v2.patch, 15087v3.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15087) Fix hbase-common findbugs complaints
[ https://issues.apache.org/jira/browse/HBASE-15087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15093777#comment-15093777 ] Hudson commented on HBASE-15087: FAILURE: Integrated in HBase-Trunk_matrix #627 (See [https://builds.apache.org/job/HBase-Trunk_matrix/627/]) HBASE-15087 Fix hbase-common findbugs complaints (stack: rev 83c506d9d49e900f3d4d5feca2ded135fb19b827) * hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAccess.java * hbase-common/src/main/java/org/apache/hadoop/hbase/OffheapKeyValue.java * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestByteBufferUtils.java * hbase-common/src/main/java/org/apache/hadoop/hbase/ProcedureInfo.java * hbase-common/src/main/java/org/apache/hadoop/hbase/JitterScheduledThreadPoolExecutorImpl.java * hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java * hbase-common/src/main/java/org/apache/hadoop/hbase/util/DynamicClassLoader.java * hbase-common/src/main/java/org/apache/hadoop/hbase/types/CopyOnWriteArrayMap.java * hbase-common/src/main/java/org/apache/hadoop/hbase/CellComparator.java * hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java * hbase-common/src/main/java/org/apache/hadoop/hbase/util/DNS.java > Fix hbase-common findbugs complaints > > > Key: HBASE-15087 > URL: https://issues.apache.org/jira/browse/HBASE-15087 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: stack >Assignee: Stack > Fix For: 2.0.0 > > Attachments: 15087.patch, 15087v2.patch, 15087v3.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15087) Fix hbase-common findbugs complaints
[ https://issues.apache.org/jira/browse/HBASE-15087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15092817#comment-15092817 ] stack commented on HBASE-15087: --- bq. ERROR: Docker failed to build image. Let me retry > Fix hbase-common findbugs complaints > > > Key: HBASE-15087 > URL: https://issues.apache.org/jira/browse/HBASE-15087 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: stack >Assignee: Stack > Attachments: 15087.patch, 15087v2.patch, 15087v3.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15087) Fix hbase-common findbugs complaints
[
https://issues.apache.org/jira/browse/HBASE-15087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15091591#comment-15091591
]
Anoop Sam John commented on HBASE-15087:
{code}
return
ByteBufferUtils.compareTo(((ByteBufferedCell)left).getFamilyByteBuffer(),
179 ((ByteBufferedCell)left).getFamilyPosition(),
left.getFamilyLength(),
180 right.getFamilyArray(), right.getFamilyOffset(),
right.getFamilyLength());
{code}
here right is a BBCell and left is normal Cell. So we should be calling
getXXXByteBuffer() method on right and getXXXArray() method on left and here it
is just reverse. Not correct for the performance reasons.
To avoid the negation, we should add method in BBUtil
compareTo(byte[] buf1, int o1, int l1, ByteBuffer buf2, int o2, int l2)
We already have compareTo(ByteBuffer buf1, int o1, int l1, byte[] buf2, int o2,
int l2)
> Fix hbase-common findbugs complaints
>
>
> Key: HBASE-15087
> URL: https://issues.apache.org/jira/browse/HBASE-15087
> Project: HBase
> Issue Type: Sub-task
> Components: build
>Reporter: stack
>Assignee: Stack
> Attachments: 15087.patch, 15087v2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15087) Fix hbase-common findbugs complaints
[ https://issues.apache.org/jira/browse/HBASE-15087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15093195#comment-15093195 ] Anoop Sam John commented on HBASE-15087: +1 > Fix hbase-common findbugs complaints > > > Key: HBASE-15087 > URL: https://issues.apache.org/jira/browse/HBASE-15087 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: stack >Assignee: Stack > Attachments: 15087.patch, 15087v2.patch, 15087v3.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15087) Fix hbase-common findbugs complaints
[
https://issues.apache.org/jira/browse/HBASE-15087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15093132#comment-15093132
]
Hadoop QA commented on HBASE-15087:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
1s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
26s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 44s
{color} | {color:green} master passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 50s
{color} | {color:green} master passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 5m
14s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
26s {color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 43s
{color} | {color:red} hbase-common in master has 14 extant Findbugs warnings.
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 51s
{color} | {color:red} hbase-server in master has 84 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 38s
{color} | {color:green} master passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 49s
{color} | {color:green} master passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
1s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 43s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 5m 5s {color}
| {color:red} hbase-common-jdk1.8.0_66 with JDK v1.8.0_66 generated 19 new
issues (was 25, now 26). {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 43s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 50s
{color} | {color:green} the patch passed with JDK v1.7.0_91 {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 5m 55s {color}
| {color:red} hbase-common-jdk1.7.0_91 with JDK v1.7.0_91 generated 19 new
issues (was 25, now 26). {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 50s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 5m
19s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
26s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m 29s
{color} | {color:red} Patch causes 11 errors with Hadoop v2.4.0. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m 58s
{color} | {color:red} Patch causes 11 errors with Hadoop v2.4.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m 29s
{color} | {color:red} Patch causes 11 errors with Hadoop v2.5.0. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 5m 59s
{color} | {color:red} Patch causes 11 errors with Hadoop v2.5.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 7m 27s
{color} | {color:red} Patch causes 11 errors with Hadoop v2.5.2. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 8m 57s
{color} | {color:red} Patch causes 11 errors with Hadoop v2.6.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 10m 26s
{color} | {color:red} Patch causes 11 errors with Hadoop v2.6.2. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 11m 56s
{color} | {color:red} Patch causes 11 errors with Hadoop v2.6.3. {color} |
|
[jira] [Commented] (HBASE-15087) Fix hbase-common findbugs complaints
[ https://issues.apache.org/jira/browse/HBASE-15087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15093198#comment-15093198 ] ramkrishna.s.vasudevan commented on HBASE-15087: +1 > Fix hbase-common findbugs complaints > > > Key: HBASE-15087 > URL: https://issues.apache.org/jira/browse/HBASE-15087 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: stack >Assignee: Stack > Attachments: 15087.patch, 15087v2.patch, 15087v3.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15087) Fix hbase-common findbugs complaints
[ https://issues.apache.org/jira/browse/HBASE-15087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15092364#comment-15092364 ] stack commented on HBASE-15087: --- Thank you for the review [~anoop.hbase] Let me fix. > Fix hbase-common findbugs complaints > > > Key: HBASE-15087 > URL: https://issues.apache.org/jira/browse/HBASE-15087 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: stack >Assignee: Stack > Attachments: 15087.patch, 15087v2.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15087) Fix hbase-common findbugs complaints
[ https://issues.apache.org/jira/browse/HBASE-15087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15092472#comment-15092472 ] Sean Busbey commented on HBASE-15087: - If those three checkstyle errors are removed by the patch, that sounds like a bug with how Yetus is calculating diffs. > Fix hbase-common findbugs complaints > > > Key: HBASE-15087 > URL: https://issues.apache.org/jira/browse/HBASE-15087 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: stack >Assignee: Stack > Attachments: 15087.patch, 15087v2.patch, 15087v3.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15087) Fix hbase-common findbugs complaints
[
https://issues.apache.org/jira/browse/HBASE-15087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15092565#comment-15092565
]
Hadoop QA commented on HBASE-15087:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | {color:red} docker {color} | {color:red} 17m 45s
{color} | {color:red} Docker failed to build yetus/hbase:date2016-01-11.
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12781615/15087v3.patch |
| JIRA Issue | HBASE-15087 |
| Powered by | Apache Yetus 0.1.0 http://yetus.apache.org |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/64/console |
This message was automatically generated.
> Fix hbase-common findbugs complaints
>
>
> Key: HBASE-15087
> URL: https://issues.apache.org/jira/browse/HBASE-15087
> Project: HBase
> Issue Type: Sub-task
> Components: build
>Reporter: stack
>Assignee: Stack
> Attachments: 15087.patch, 15087v2.patch, 15087v3.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15087) Fix hbase-common findbugs complaints
[ https://issues.apache.org/jira/browse/HBASE-15087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090865#comment-15090865 ] Jonathan Hsieh commented on HBASE-15087: lgtm if bot is happy. I kicked the bot to try the patch. > Fix hbase-common findbugs complaints > > > Key: HBASE-15087 > URL: https://issues.apache.org/jira/browse/HBASE-15087 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: stack >Assignee: Stack > Attachments: 15087.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15087) Fix hbase-common findbugs complaints
[
https://issues.apache.org/jira/browse/HBASE-15087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090910#comment-15090910
]
Hadoop QA commented on HBASE-15087:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
45s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 20s
{color} | {color:green} master passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 18s
{color} | {color:green} master passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
7s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
10s {color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 50s
{color} | {color:red} hbase-common in master has 14 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 21s
{color} | {color:green} master passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s
{color} | {color:green} master passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
19s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 20s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 2m 11s {color}
| {color:red} hbase-common-jdk1.8.0_66 with JDK v1.8.0_66 generated 15 new
issues (was 25, now 25). {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 20s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 19s
{color} | {color:green} the patch passed with JDK v1.7.0_91 {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 2m 30s {color}
| {color:red} hbase-common-jdk1.7.0_91 with JDK v1.7.0_91 generated 15 new
issues (was 25, now 25). {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 19s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 11s
{color} | {color:red} Patch generated 3 new checkstyle issues in hbase-common
(total was 195, now 198). {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
11s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
24m 49s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 1s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 23s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s
{color} | {color:green} the patch passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 54s
{color} | {color:green} hbase-common in the patch passed with JDK v1.8.0_66.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 50s
{color} | {color:green} hbase-common in the patch passed with JDK v1.7.0_91.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}
[jira] [Commented] (HBASE-15087) Fix hbase-common findbugs complaints
[ https://issues.apache.org/jira/browse/HBASE-15087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090930#comment-15090930 ] Sean Busbey commented on HBASE-15087: - bq. Not sure about the javac warnings (was 25 and now is 25). might be YETUS-187, or a variant of YETUS-270. bq. We just build hbase-common? If so, nice (Thats where changes happened). Yeah, Yetus only checks modules that have changed unless the project personality tells it otherwise. > Fix hbase-common findbugs complaints > > > Key: HBASE-15087 > URL: https://issues.apache.org/jira/browse/HBASE-15087 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: stack >Assignee: Stack > Attachments: 15087.patch, 15087v2.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
