[jira] [Commented] (HBASE-15126) HBaseFsck's checkRegionBoundaries function set incorrect 'storesFirstKey'
[
https://issues.apache.org/jira/browse/HBASE-15126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110403#comment-15110403
]
Hadoop QA commented on HBASE-15126:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
45s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 17s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 49s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 5m
22s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
25s {color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 42s
{color} | {color:red} hbase-server in master has 1 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 49s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 51s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
9s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 13s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 13s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 50s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 50s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 6m
35s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
26s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s
{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
32m 4s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
59s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 48s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 48s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 149m 11s
{color} | {color:red} hbase-server in the patch failed with JDK v1.8.0. {color}
|
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 146m 12s
{color} | {color:red} hbase-server in the patch failed with JDK v1.7.0_79.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
33s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 359m 25s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| JDK v1.8.0 Failed junit tests | hadoop.hbase.quotas.TestQuotaThrottle |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12783507/HBASE-15126-v006.patch
|
| JIRA Issue | HBASE-15126 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
[jira] [Commented] (HBASE-15126) HBaseFsck's checkRegionBoundaries function set incorrect 'storesFirstKey'
[
https://issues.apache.org/jira/browse/HBASE-15126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110799#comment-15110799
]
Ted Yu commented on HBASE-15126:
{code}
Failed tests:
TestReplicationKillSlaveRS.killOneSlaveRS:34->TestReplicationKillRS.loadTableAndKillRS:88
Waited too much time for queueFailover replication. Waited 18130ms.
{code}
The above test failure was not related to patch.
TestQuotaThrottle failure was not related either.
> HBaseFsck's checkRegionBoundaries function set incorrect 'storesFirstKey'
> -
>
> Key: HBASE-15126
> URL: https://issues.apache.org/jira/browse/HBASE-15126
> Project: HBase
> Issue Type: Bug
> Components: hbck
>Affects Versions: 2.0.0
>Reporter: chenrongwei
>Assignee: chenrongwei
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-15126-v001.patch, HBASE-15126-v002.patch,
> HBASE-15126-v003.patch, HBASE-15126-v004.patch, HBASE-15126-v005.patch,
> HBASE-15126-v006.patch
>
>
> HBaseFsck's checkRegionBoundaries function set the
> 'currentRegionBoundariesInformation.storesFirstKey' was incorrect.I think it
> should be set like below,
> currentRegionBoundariesInformation.storesFirstKey = keyOnly(storeFirstKey);
> but current the 'currentRegionBoundariesInformation.storesFirstKey ' is just
> set to 'storeFirstKey',which will cause to
> comparator.compare(currentRegionBoundariesInformation.storesFirstKey,
> currentRegionBoundariesInformation.metaFirstKey) get a wrong
> result. Because it just compared the rowkey's length.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15126) HBaseFsck's checkRegionBoundaries function set incorrect 'storesFirstKey'
[
https://issues.apache.org/jira/browse/HBASE-15126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110144#comment-15110144
]
Hadoop QA commented on HBASE-15126:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
49s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 55s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 36s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
32s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
17s {color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 11s
{color} | {color:red} hbase-server in master has 1 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 39s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 39s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
47s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 53s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 53s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 36s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 36s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
15s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
17s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s
{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
22m 49s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
26s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 43s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 40s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 122m 11s
{color} | {color:red} hbase-server in the patch failed with JDK v1.8.0. {color}
|
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 87m 32s {color}
| {color:red} hbase-server in the patch failed with JDK v1.7.0_79. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
25s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 256m 35s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| JDK v1.8.0 Failed junit tests |
hadoop.hbase.master.balancer.TestStochasticLoadBalancer |
| JDK v1.7.0_79 Timed out junit tests |
org.apache.hadoop.hbase.client.TestReplicasClient |
| | org.apache.hadoop.hbase.client.TestFromClientSide |
| | org.apache.hadoop.hbase.client.TestScannerTimeout |
| |
org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClientWithRegionReplicas |
| | org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClient |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12783495/HBASE-15126-v005.patch
|
| JIRA Issue |
[jira] [Commented] (HBASE-15126) HBaseFsck's checkRegionBoundaries function set incorrect 'storesFirstKey'
[
https://issues.apache.org/jira/browse/HBASE-15126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109950#comment-15109950
]
Ted Yu commented on HBASE-15126:
Table name still doesn't match test name:
{code}
588 public void testRegionBoundariesCheckWithFlushTable() throws
Exception {
589 HBaseFsck hbck = doFsck(conf, false);
590 assertNoErrors(hbck); // no errors
591 TableName table =
TableName.valueOf("testRegionBoundariesCheckWithTestFlushTable");
{code}
> HBaseFsck's checkRegionBoundaries function set incorrect 'storesFirstKey'
> -
>
> Key: HBASE-15126
> URL: https://issues.apache.org/jira/browse/HBASE-15126
> Project: HBase
> Issue Type: Bug
> Components: hbck
>Affects Versions: 2.0.0
>Reporter: chenrongwei
>Assignee: chenrongwei
> Attachments: HBASE-15126-v001.patch, HBASE-15126-v002.patch,
> HBASE-15126-v003.patch, HBASE-15126-v004.patch, HBASE-15126-v005.patch
>
>
> HBaseFsck's checkRegionBoundaries function set the
> 'currentRegionBoundariesInformation.storesFirstKey' was incorrect.I think it
> should be set like below,
> currentRegionBoundariesInformation.storesFirstKey = keyOnly(storeFirstKey);
> but current the 'currentRegionBoundariesInformation.storesFirstKey ' is just
> set to 'storeFirstKey',which will cause to
> comparator.compare(currentRegionBoundariesInformation.storesFirstKey,
> currentRegionBoundariesInformation.metaFirstKey) get a wrong
> result. Because it just compared the rowkey's length.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
