[jira] [Commented] (HBASE-15229) Canary Tools should not call System.Exit on error
[
https://issues.apache.org/jira/browse/HBASE-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145290#comment-15145290
]
Ted Yu commented on HBASE-15229:
This may have resulted in exit code from Canary to always be 0.
> Canary Tools should not call System.Exit on error
> -
>
> Key: HBASE-15229
> URL: https://issues.apache.org/jira/browse/HBASE-15229
> Project: HBase
> Issue Type: Bug
> Components: canary
>Affects Versions: 0.98.17
>Reporter: Vishal Khandelwal
>Assignee: Vishal Khandelwal
>Priority: Critical
> Fix For: 2.0.0, 1.3.0, 1.2.1, 0.98.18
>
> Attachments: HBASE-15229-0.98.patch, HBASE-15229.patch,
> HBASE-15229.v1.patch, HBASE-15229.v2.patch, HBASE-15229.v3.patch
>
>
> run method in canary tool calls system.Exit on failure. Due to this it can't
> be integrated as an API as jvm will stop on failure. It should only return
> (exit code)
> So any integration with unit test also fail with
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.14:test (default-test) on
> project <>: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.14:test failed: The forked
> VM terminated without saying properly goodbye. VM crash or System.exit called
> ?
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15229) Canary Tools should not call System.Exit on error
[
https://issues.apache.org/jira/browse/HBASE-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143041#comment-15143041
]
Hudson commented on HBASE-15229:
FAILURE: Integrated in HBase-0.98-matrix #296 (See
[https://builds.apache.org/job/HBase-0.98-matrix/296/])
HBASE-15229 Canary Tools should not call System.Exit on error (Vishal
(apurtell: rev 6bc355721e1f5ec3934cf014f042702345d7e7b7)
* hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java
> Canary Tools should not call System.Exit on error
> -
>
> Key: HBASE-15229
> URL: https://issues.apache.org/jira/browse/HBASE-15229
> Project: HBase
> Issue Type: Bug
> Components: canary
>Affects Versions: 0.98.17
>Reporter: Vishal Khandelwal
>Assignee: Vishal Khandelwal
>Priority: Critical
> Fix For: 2.0.0, 1.3.0, 1.2.1, 0.98.18
>
> Attachments: HBASE-15229-0.98.patch, HBASE-15229.patch,
> HBASE-15229.v1.patch, HBASE-15229.v2.patch, HBASE-15229.v3.patch
>
>
> run method in canary tool calls system.Exit on failure. Due to this it can't
> be integrated as an API as jvm will stop on failure. It should only return
> (exit code)
> So any integration with unit test also fail with
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.14:test (default-test) on
> project <>: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.14:test failed: The forked
> VM terminated without saying properly goodbye. VM crash or System.exit called
> ?
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15229) Canary Tools should not call System.Exit on error
[
https://issues.apache.org/jira/browse/HBASE-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143080#comment-15143080
]
Hudson commented on HBASE-15229:
FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1170 (See
[https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1170/])
HBASE-15229 Canary Tools should not call System.Exit on error (Vishal
(apurtell: rev 6bc355721e1f5ec3934cf014f042702345d7e7b7)
* hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java
> Canary Tools should not call System.Exit on error
> -
>
> Key: HBASE-15229
> URL: https://issues.apache.org/jira/browse/HBASE-15229
> Project: HBase
> Issue Type: Bug
> Components: canary
>Affects Versions: 0.98.17
>Reporter: Vishal Khandelwal
>Assignee: Vishal Khandelwal
>Priority: Critical
> Fix For: 2.0.0, 1.3.0, 1.2.1, 0.98.18
>
> Attachments: HBASE-15229-0.98.patch, HBASE-15229.patch,
> HBASE-15229.v1.patch, HBASE-15229.v2.patch, HBASE-15229.v3.patch
>
>
> run method in canary tool calls system.Exit on failure. Due to this it can't
> be integrated as an API as jvm will stop on failure. It should only return
> (exit code)
> So any integration with unit test also fail with
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.14:test (default-test) on
> project <>: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.14:test failed: The forked
> VM terminated without saying properly goodbye. VM crash or System.exit called
> ?
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15229) Canary Tools should not call System.Exit on error
[
https://issues.apache.org/jira/browse/HBASE-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15141470#comment-15141470
]
Hudson commented on HBASE-15229:
SUCCESS: Integrated in HBase-1.3-IT #491 (See
[https://builds.apache.org/job/HBase-1.3-IT/491/])
HBASE-15229 Canary Tools should not call System.Exit on error (Vishal
(apurtell: rev e85575f5683e25fa8e44969ede68330358de63a4)
* hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java
> Canary Tools should not call System.Exit on error
> -
>
> Key: HBASE-15229
> URL: https://issues.apache.org/jira/browse/HBASE-15229
> Project: HBase
> Issue Type: Bug
> Components: canary
>Affects Versions: 0.98.17
>Reporter: Vishal Khandelwal
>Assignee: Vishal Khandelwal
>Priority: Critical
> Fix For: 2.0.0, 1.3.0, 1.2.1, 0.98.18
>
> Attachments: HBASE-15229-0.98.patch, HBASE-15229.patch,
> HBASE-15229.v1.patch, HBASE-15229.v2.patch, HBASE-15229.v3.patch
>
>
> run method in canary tool calls system.Exit on failure. Due to this it can't
> be integrated as an API as jvm will stop on failure. It should only return
> (exit code)
> So any integration with unit test also fail with
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.14:test (default-test) on
> project <>: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.14:test failed: The forked
> VM terminated without saying properly goodbye. VM crash or System.exit called
> ?
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15229) Canary Tools should not call System.Exit on error
[
https://issues.apache.org/jira/browse/HBASE-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15141308#comment-15141308
]
Andrew Purtell commented on HBASE-15229:
This needs to be rebased after HBASE-15219. Let me do that now and commit.
> Canary Tools should not call System.Exit on error
> -
>
> Key: HBASE-15229
> URL: https://issues.apache.org/jira/browse/HBASE-15229
> Project: HBase
> Issue Type: Bug
> Components: canary
>Affects Versions: 0.98.17
>Reporter: Vishal Khandelwal
>Assignee: Vishal Khandelwal
>Priority: Critical
> Attachments: HBASE-15229.v1.patch, HBASE-15229.v2.patch,
> HBASE-15229.v3.patch
>
>
> run method in canary tool calls system.Exit on failure. Due to this it can't
> be integrated as an API as jvm will stop on failure. It should only return
> (exit code)
> So any integration with unit test also fail with
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.14:test (default-test) on
> project <>: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.14:test failed: The forked
> VM terminated without saying properly goodbye. VM crash or System.exit called
> ?
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15229) Canary Tools should not call System.Exit on error
[
https://issues.apache.org/jira/browse/HBASE-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15141546#comment-15141546
]
Hudson commented on HBASE-15229:
SUCCESS: Integrated in HBase-1.2-IT #428 (See
[https://builds.apache.org/job/HBase-1.2-IT/428/])
HBASE-15229 Canary Tools should not call System.Exit on error (Vishal
(apurtell: rev 3b6c3057d24ac1b72a2072ed2a4c34554e5c3a6d)
* hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java
> Canary Tools should not call System.Exit on error
> -
>
> Key: HBASE-15229
> URL: https://issues.apache.org/jira/browse/HBASE-15229
> Project: HBase
> Issue Type: Bug
> Components: canary
>Affects Versions: 0.98.17
>Reporter: Vishal Khandelwal
>Assignee: Vishal Khandelwal
>Priority: Critical
> Fix For: 2.0.0, 1.3.0, 1.2.1, 0.98.18
>
> Attachments: HBASE-15229-0.98.patch, HBASE-15229.patch,
> HBASE-15229.v1.patch, HBASE-15229.v2.patch, HBASE-15229.v3.patch
>
>
> run method in canary tool calls system.Exit on failure. Due to this it can't
> be integrated as an API as jvm will stop on failure. It should only return
> (exit code)
> So any integration with unit test also fail with
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.14:test (default-test) on
> project <>: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.14:test failed: The forked
> VM terminated without saying properly goodbye. VM crash or System.exit called
> ?
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15229) Canary Tools should not call System.Exit on error
[
https://issues.apache.org/jira/browse/HBASE-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15141790#comment-15141790
]
Hudson commented on HBASE-15229:
FAILURE: Integrated in HBase-1.2 #540 (See
[https://builds.apache.org/job/HBase-1.2/540/])
HBASE-15229 Canary Tools should not call System.Exit on error (Vishal
(apurtell: rev 3b6c3057d24ac1b72a2072ed2a4c34554e5c3a6d)
* hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java
> Canary Tools should not call System.Exit on error
> -
>
> Key: HBASE-15229
> URL: https://issues.apache.org/jira/browse/HBASE-15229
> Project: HBase
> Issue Type: Bug
> Components: canary
>Affects Versions: 0.98.17
>Reporter: Vishal Khandelwal
>Assignee: Vishal Khandelwal
>Priority: Critical
> Fix For: 2.0.0, 1.3.0, 1.2.1, 0.98.18
>
> Attachments: HBASE-15229-0.98.patch, HBASE-15229.patch,
> HBASE-15229.v1.patch, HBASE-15229.v2.patch, HBASE-15229.v3.patch
>
>
> run method in canary tool calls system.Exit on failure. Due to this it can't
> be integrated as an API as jvm will stop on failure. It should only return
> (exit code)
> So any integration with unit test also fail with
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.14:test (default-test) on
> project <>: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.14:test failed: The forked
> VM terminated without saying properly goodbye. VM crash or System.exit called
> ?
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15229) Canary Tools should not call System.Exit on error
[
https://issues.apache.org/jira/browse/HBASE-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15141906#comment-15141906
]
Hudson commented on HBASE-15229:
SUCCESS: Integrated in HBase-1.3 #547 (See
[https://builds.apache.org/job/HBase-1.3/547/])
HBASE-15229 Canary Tools should not call System.Exit on error (Vishal
(apurtell: rev e85575f5683e25fa8e44969ede68330358de63a4)
* hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java
> Canary Tools should not call System.Exit on error
> -
>
> Key: HBASE-15229
> URL: https://issues.apache.org/jira/browse/HBASE-15229
> Project: HBase
> Issue Type: Bug
> Components: canary
>Affects Versions: 0.98.17
>Reporter: Vishal Khandelwal
>Assignee: Vishal Khandelwal
>Priority: Critical
> Fix For: 2.0.0, 1.3.0, 1.2.1, 0.98.18
>
> Attachments: HBASE-15229-0.98.patch, HBASE-15229.patch,
> HBASE-15229.v1.patch, HBASE-15229.v2.patch, HBASE-15229.v3.patch
>
>
> run method in canary tool calls system.Exit on failure. Due to this it can't
> be integrated as an API as jvm will stop on failure. It should only return
> (exit code)
> So any integration with unit test also fail with
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.14:test (default-test) on
> project <>: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.14:test failed: The forked
> VM terminated without saying properly goodbye. VM crash or System.exit called
> ?
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15229) Canary Tools should not call System.Exit on error
[
https://issues.apache.org/jira/browse/HBASE-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15141964#comment-15141964
]
Hudson commented on HBASE-15229:
FAILURE: Integrated in HBase-Trunk_matrix #698 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/698/])
HBASE-15229 Canary Tools should not call System.Exit on error (Vishal
(apurtell: rev 2963d59ed21de246390426cbdb57c160a4f65303)
* hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java
> Canary Tools should not call System.Exit on error
> -
>
> Key: HBASE-15229
> URL: https://issues.apache.org/jira/browse/HBASE-15229
> Project: HBase
> Issue Type: Bug
> Components: canary
>Affects Versions: 0.98.17
>Reporter: Vishal Khandelwal
>Assignee: Vishal Khandelwal
>Priority: Critical
> Fix For: 2.0.0, 1.3.0, 1.2.1, 0.98.18
>
> Attachments: HBASE-15229-0.98.patch, HBASE-15229.patch,
> HBASE-15229.v1.patch, HBASE-15229.v2.patch, HBASE-15229.v3.patch
>
>
> run method in canary tool calls system.Exit on failure. Due to this it can't
> be integrated as an API as jvm will stop on failure. It should only return
> (exit code)
> So any integration with unit test also fail with
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.14:test (default-test) on
> project <>: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.14:test failed: The forked
> VM terminated without saying properly goodbye. VM crash or System.exit called
> ?
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15229) Canary Tools should not call System.Exit on error
[
https://issues.apache.org/jira/browse/HBASE-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138740#comment-15138740
]
Hadoop QA commented on HBASE-15229:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 1s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
43s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 32s
{color} | {color:green} master passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 33s
{color} | {color:green} master passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
14s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
17s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
50s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 26s
{color} | {color:green} master passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 33s
{color} | {color:green} master passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
43s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 33s
{color} | {color:green} the patch passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 33s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 35s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 35s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 4m 21s
{color} | {color:red} Patch generated 1 new checkstyle issues in hbase-server
(total was 15, now 16). {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
21m 44s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
59s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 25s
{color} | {color:green} the patch passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 32s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 91m 49s {color}
| {color:red} hbase-server in the patch failed with JDK v1.8.0_72. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 89m 0s {color}
| {color:red} hbase-server in the patch failed with JDK v1.7.0_95. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 223m 56s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| JDK v1.8.0_72 Failed junit tests | hadoop.hbase.mapreduce.TestHashTable |
| JDK v1.7.0_95 Timed out junit tests |
org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-02-09 |
| JIRA Patch URL |
[jira] [Commented] (HBASE-15229) Canary Tools should not call System.Exit on error
[
https://issues.apache.org/jira/browse/HBASE-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138778#comment-15138778
]
Hadoop QA commented on HBASE-15229:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
55s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 34s
{color} | {color:green} master passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 35s
{color} | {color:green} master passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
9s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
17s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
54s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 24s
{color} | {color:green} master passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 33s
{color} | {color:green} master passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
44s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 32s
{color} | {color:green} the patch passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 32s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 37s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 37s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 3m 58s
{color} | {color:red} Patch generated 1 new checkstyle issues in hbase-server
(total was 15, now 16). {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
17s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
23m 53s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 1s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 26s
{color} | {color:green} the patch passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 33s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 96m 37s
{color} | {color:green} hbase-server in the patch passed with JDK v1.8.0_72.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 101m 41s
{color} | {color:green} hbase-server in the patch passed with JDK v1.7.0_95.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 264m 18s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-02-09 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12787005/HBASE-15229.v3.patch |
| JIRA Issue | HBASE-15229 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux
[jira] [Commented] (HBASE-15229) Canary Tools should not call System.Exit on error
[
https://issues.apache.org/jira/browse/HBASE-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138417#comment-15138417
]
Vishal Khandelwal commented on HBASE-15229:
---
Submitted the patch by fixing formatting errors. Other failures are not related
to the Canary
> Canary Tools should not call System.Exit on error
> -
>
> Key: HBASE-15229
> URL: https://issues.apache.org/jira/browse/HBASE-15229
> Project: HBase
> Issue Type: Bug
> Components: canary
>Affects Versions: 0.98.17
>Reporter: Vishal Khandelwal
>Assignee: Vishal Khandelwal
>Priority: Critical
> Attachments: HBASE-15229.v1.patch, HBASE-15229.v2.patch
>
>
> run method in canary tool calls system.Exit on failure. Due to this it can't
> be integrated as an API as jvm will stop on failure. It should only return
> (exit code)
> So any integration with unit test also fail with
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.14:test (default-test) on
> project <>: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.14:test failed: The forked
> VM terminated without saying properly goodbye. VM crash or System.exit called
> ?
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15229) Canary Tools should not call System.Exit on error
[
https://issues.apache.org/jira/browse/HBASE-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15137054#comment-15137054
]
Hadoop QA commented on HBASE-15229:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
3s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 43s
{color} | {color:green} master passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 38s
{color} | {color:green} master passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
26s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
17s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 2s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 34s
{color} | {color:green} master passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 35s
{color} | {color:green} master passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
51s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 40s
{color} | {color:green} the patch passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 40s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 36s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 36s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 4m 3s
{color} | {color:red} Patch generated 10 new checkstyle issues in hbase-server
(total was 15, now 25). {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
17s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s
{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix. {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s
{color} | {color:red} The patch has 9 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
22m 41s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
19s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 32s
{color} | {color:green} the patch passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 33s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 99m 48s {color}
| {color:red} hbase-server in the patch failed with JDK v1.8.0_72. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 28s {color}
| {color:red} hbase-server in the patch failed with JDK v1.7.0_95. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
16s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 146m 11s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| JDK v1.8.0_72 Failed junit tests | hadoop.hbase.mapreduce.TestRowCounter |
| JDK v1.8.0_72 Timed out junit tests |
