[jira] [Commented] (HBASE-15247) InclusiveStopFilter does not respect reverse Filter property
[
https://issues.apache.org/jira/browse/HBASE-15247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197222#comment-15197222
]
Hudson commented on HBASE-15247:
ABORTED: Integrated in HBase-0.98-matrix #312 (See
[https://builds.apache.org/job/HBase-0.98-matrix/312/])
HBASE-15247 InclusiveStopFilter does not respect reverse Filter (apurtell: rev
92eea6db5cbe0abfd4acf5575929863bac2d8c02)
*
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilter.java
> InclusiveStopFilter does not respect reverse Filter property
>
>
> Key: HBASE-15247
> URL: https://issues.apache.org/jira/browse/HBASE-15247
> Project: HBase
> Issue Type: Bug
> Components: Filters
>Affects Versions: 2.0.0, 1.1.1
>Reporter: Rick Moritz
>Assignee: Amal Joshy
> Fix For: 2.0.0, 1.3.0, 0.98.18
>
> Attachments: HBASE-15247-branch-1.1.patch, HBASE-15247.patch
>
>
> InclusiveStopFilter only works with non-reversed Scans, it will not filter
> for reversed Scans, because it doesn't flip the cmp-operand in the reversed
> case. In fact, it doesn't even use the Filter.reverse flag.
> it should be something like this:
> if (reversed) {
> if (cmp > 0) {
> done = true;
> }
> }
> else {
> if (cmp < 0) {
> done = true;
> }
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15247) InclusiveStopFilter does not respect reverse Filter property
[
https://issues.apache.org/jira/browse/HBASE-15247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197840#comment-15197840
]
Hudson commented on HBASE-15247:
FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1186 (See
[https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1186/])
HBASE-15247 InclusiveStopFilter does not respect reverse Filter (apurtell: rev
92eea6db5cbe0abfd4acf5575929863bac2d8c02)
* hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilter.java
*
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java
> InclusiveStopFilter does not respect reverse Filter property
>
>
> Key: HBASE-15247
> URL: https://issues.apache.org/jira/browse/HBASE-15247
> Project: HBase
> Issue Type: Bug
> Components: Filters
>Affects Versions: 2.0.0, 1.1.1
>Reporter: Rick Moritz
>Assignee: Amal Joshy
> Fix For: 2.0.0, 1.3.0, 0.98.18
>
> Attachments: HBASE-15247-branch-1.1.patch, HBASE-15247.patch
>
>
> InclusiveStopFilter only works with non-reversed Scans, it will not filter
> for reversed Scans, because it doesn't flip the cmp-operand in the reversed
> case. In fact, it doesn't even use the Filter.reverse flag.
> it should be something like this:
> if (reversed) {
> if (cmp > 0) {
> done = true;
> }
> }
> else {
> if (cmp < 0) {
> done = true;
> }
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15247) InclusiveStopFilter does not respect reverse Filter property
[
https://issues.apache.org/jira/browse/HBASE-15247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158687#comment-15158687
]
Hudson commented on HBASE-15247:
SUCCESS: Integrated in HBase-1.3 #565 (See
[https://builds.apache.org/job/HBase-1.3/565/])
HBASE-15247 InclusiveStopFilter does not respect reverse Filter (anoopsamjohn:
rev cc45b4ab38edee680a4356d3f57437d12a55de24)
* hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilter.java
*
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java
> InclusiveStopFilter does not respect reverse Filter property
>
>
> Key: HBASE-15247
> URL: https://issues.apache.org/jira/browse/HBASE-15247
> Project: HBase
> Issue Type: Bug
> Components: Filters
>Affects Versions: 2.0.0, 1.1.1
>Reporter: Rick Moritz
>Assignee: Amal Joshy
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-15247-branch-1.1.patch, HBASE-15247.patch
>
>
> InclusiveStopFilter only works with non-reversed Scans, it will not filter
> for reversed Scans, because it doesn't flip the cmp-operand in the reversed
> case. In fact, it doesn't even use the Filter.reverse flag.
> it should be something like this:
> if (reversed) {
> if (cmp > 0) {
> done = true;
> }
> }
> else {
> if (cmp < 0) {
> done = true;
> }
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15247) InclusiveStopFilter does not respect reverse Filter property
[
https://issues.apache.org/jira/browse/HBASE-15247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158461#comment-15158461
]
Hudson commented on HBASE-15247:
FAILURE: Integrated in HBase-Trunk_matrix #728 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/728/])
HBASE-15247 InclusiveStopFilter does not respect reverse Filter (anoopsamjohn:
rev 2d66cd86d08120887efe05b65fa53bd667a5be76)
* hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilter.java
*
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java
> InclusiveStopFilter does not respect reverse Filter property
>
>
> Key: HBASE-15247
> URL: https://issues.apache.org/jira/browse/HBASE-15247
> Project: HBase
> Issue Type: Bug
> Components: Filters
>Affects Versions: 2.0.0, 1.1.1
>Reporter: Rick Moritz
>Assignee: Amal Joshy
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-15247-branch-1.1.patch, HBASE-15247.patch
>
>
> InclusiveStopFilter only works with non-reversed Scans, it will not filter
> for reversed Scans, because it doesn't flip the cmp-operand in the reversed
> case. In fact, it doesn't even use the Filter.reverse flag.
> it should be something like this:
> if (reversed) {
> if (cmp > 0) {
> done = true;
> }
> }
> else {
> if (cmp < 0) {
> done = true;
> }
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15247) InclusiveStopFilter does not respect reverse Filter property
[
https://issues.apache.org/jira/browse/HBASE-15247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158428#comment-15158428
]
Hudson commented on HBASE-15247:
SUCCESS: Integrated in HBase-1.3-IT #510 (See
[https://builds.apache.org/job/HBase-1.3-IT/510/])
HBASE-15247 InclusiveStopFilter does not respect reverse Filter (anoopsamjohn:
rev cc45b4ab38edee680a4356d3f57437d12a55de24)
*
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilter.java
> InclusiveStopFilter does not respect reverse Filter property
>
>
> Key: HBASE-15247
> URL: https://issues.apache.org/jira/browse/HBASE-15247
> Project: HBase
> Issue Type: Bug
> Components: Filters
>Affects Versions: 2.0.0, 1.1.1
>Reporter: Rick Moritz
>Assignee: Amal Joshy
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-15247-branch-1.1.patch, HBASE-15247.patch
>
>
> InclusiveStopFilter only works with non-reversed Scans, it will not filter
> for reversed Scans, because it doesn't flip the cmp-operand in the reversed
> case. In fact, it doesn't even use the Filter.reverse flag.
> it should be something like this:
> if (reversed) {
> if (cmp > 0) {
> done = true;
> }
> }
> else {
> if (cmp < 0) {
> done = true;
> }
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15247) InclusiveStopFilter does not respect reverse Filter property
[
https://issues.apache.org/jira/browse/HBASE-15247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158381#comment-15158381
]
Rick Moritz commented on HBASE-15247:
-
Thanks for the quick fix, Amal!
> InclusiveStopFilter does not respect reverse Filter property
>
>
> Key: HBASE-15247
> URL: https://issues.apache.org/jira/browse/HBASE-15247
> Project: HBase
> Issue Type: Bug
> Components: Filters
>Affects Versions: 2.0.0, 1.1.1
>Reporter: Rick Moritz
>Assignee: Amal Joshy
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-15247-branch-1.1.patch, HBASE-15247.patch
>
>
> InclusiveStopFilter only works with non-reversed Scans, it will not filter
> for reversed Scans, because it doesn't flip the cmp-operand in the reversed
> case. In fact, it doesn't even use the Filter.reverse flag.
> it should be something like this:
> if (reversed) {
> if (cmp > 0) {
> done = true;
> }
> }
> else {
> if (cmp < 0) {
> done = true;
> }
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15247) InclusiveStopFilter does not respect reverse Filter property
[
https://issues.apache.org/jira/browse/HBASE-15247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15156691#comment-15156691
]
Hadoop QA commented on HBASE-15247:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
40s {color} | {color:green} branch-1.1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 1s
{color} | {color:green} branch-1.1 passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 54s
{color} | {color:green} branch-1.1 passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
27s {color} | {color:green} branch-1.1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
30s {color} | {color:green} branch-1.1 passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 7s
{color} | {color:red} hbase-client in branch-1.1 has 15 extant Findbugs
warnings. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 19s
{color} | {color:red} hbase-server in branch-1.1 has 79 extant Findbugs
warnings. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 33s
{color} | {color:red} hbase-client in branch-1.1 failed with JDK v1.8.0_72.
{color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 48s
{color} | {color:red} hbase-server in branch-1.1 failed with JDK v1.8.0_72.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 8s
{color} | {color:green} branch-1.1 passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
15s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 19s
{color} | {color:green} the patch passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 19s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 1s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 1s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
29s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
34s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 5m
10s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.1
2.5.2 2.6.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 3s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 32s
{color} | {color:red} hbase-client in the patch failed with JDK v1.8.0_72.
{color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 42s
{color} | {color:red} hbase-server in the patch failed with JDK v1.8.0_72.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 10s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 58s
{color} | {color:green} hbase-client in the patch passed with JDK v1.8.0_72.
{color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 112m 15s
{color} | {color:red} hbase-server in the patch failed with JDK v1.8.0_72.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 57s
{color} | {color:green} hbase-client in the patch passed with JDK v1.7.0_95.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 102m 1s
{color} | {color:green} hbase-server in the patch passed
[jira] [Commented] (HBASE-15247) InclusiveStopFilter does not respect reverse Filter property
[
https://issues.apache.org/jira/browse/HBASE-15247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15153818#comment-15153818
]
Ted Yu commented on HBASE-15247:
+1, pending QA run.
> InclusiveStopFilter does not respect reverse Filter property
>
>
> Key: HBASE-15247
> URL: https://issues.apache.org/jira/browse/HBASE-15247
> Project: HBase
> Issue Type: Bug
> Components: Filters
>Affects Versions: 2.0.0, 1.1.1
>Reporter: Rick Moritz
>Assignee: Amal Joshy
> Fix For: 2.0.0, 1.1.1, 1.3.0
>
> Attachments: HBASE-15247-branch-1.1.patch, HBASE-15247.patch
>
>
> InclusiveStopFilter only works with non-reversed Scans, it will not filter
> for reversed Scans, because it doesn't flip the cmp-operand in the reversed
> case. In fact, it doesn't even use the Filter.reverse flag.
> it should be something like this:
> if (reversed) {
> if (cmp > 0) {
> done = true;
> }
> }
> else {
> if (cmp < 0) {
> done = true;
> }
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15247) InclusiveStopFilter does not respect reverse Filter property
[
https://issues.apache.org/jira/browse/HBASE-15247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15153812#comment-15153812
]
Anoop Sam John commented on HBASE-15247:
+1. Will commit after QA report.
> InclusiveStopFilter does not respect reverse Filter property
>
>
> Key: HBASE-15247
> URL: https://issues.apache.org/jira/browse/HBASE-15247
> Project: HBase
> Issue Type: Bug
> Components: Filters
>Affects Versions: 2.0.0, 1.1.1
>Reporter: Rick Moritz
>Assignee: Amal Joshy
> Fix For: 2.0.0, 1.1.1, 1.3.0
>
> Attachments: HBASE-15247-branch-1.1.patch, HBASE-15247.patch
>
>
> InclusiveStopFilter only works with non-reversed Scans, it will not filter
> for reversed Scans, because it doesn't flip the cmp-operand in the reversed
> case. In fact, it doesn't even use the Filter.reverse flag.
> it should be something like this:
> if (reversed) {
> if (cmp > 0) {
> done = true;
> }
> }
> else {
> if (cmp < 0) {
> done = true;
> }
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15247) InclusiveStopFilter does not respect reverse Filter property
[
https://issues.apache.org/jira/browse/HBASE-15247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15141069#comment-15141069
]
Anoop Sam John commented on HBASE-15247:
Planning to give a patch?
> InclusiveStopFilter does not respect reverse Filter property
>
>
> Key: HBASE-15247
> URL: https://issues.apache.org/jira/browse/HBASE-15247
> Project: HBase
> Issue Type: Bug
> Components: Filters
>Affects Versions: 1.1.1
>Reporter: Rick Moritz
>
> InclusiveStopFilter only works with non-reversed Scans, it will not filter
> for reversed Scans, because it doesn't flip the cmp-operand in the reversed
> case. In fact, it doesn't even use the Filter.reverse flag.
> it should be something like this:
> if (reversed) {
> if (cmp > 0) {
> done = true;
> }
> }
> else {
> if (cmp < 0) {
> done = true;
> }
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15247) InclusiveStopFilter does not respect reverse Filter property
[
https://issues.apache.org/jira/browse/HBASE-15247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15141076#comment-15141076
]
Rick Moritz commented on HBASE-15247:
-
I'd rather leave this as a "noobie"-level issue for someone wanting to get into
HBase. The bit of code itself is pretty simple, but I'm not too keen to figure
out the project structure, test design etc. at this point.
Still, if no one picks it up by end of this month, I'll give it a go myself.
> InclusiveStopFilter does not respect reverse Filter property
>
>
> Key: HBASE-15247
> URL: https://issues.apache.org/jira/browse/HBASE-15247
> Project: HBase
> Issue Type: Bug
> Components: Filters
>Affects Versions: 1.1.1
>Reporter: Rick Moritz
>
> InclusiveStopFilter only works with non-reversed Scans, it will not filter
> for reversed Scans, because it doesn't flip the cmp-operand in the reversed
> case. In fact, it doesn't even use the Filter.reverse flag.
> it should be something like this:
> if (reversed) {
> if (cmp > 0) {
> done = true;
> }
> }
> else {
> if (cmp < 0) {
> done = true;
> }
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
