[jira] [Commented] (HBASE-15283) Revert to IOException in TimeRange constructor to maintain API compat in 1.x line
[
https://issues.apache.org/jira/browse/HBASE-15283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151811#comment-15151811
]
Hudson commented on HBASE-15283:
FAILURE: Integrated in HBase-1.2 #553 (See
[https://builds.apache.org/job/HBase-1.2/553/])
HBASE-15283 Revert to IOException in TimeRange constructor to maintain
(jmhsieh: rev a8314301c28aa0738596f1dc2dd87f4d8dcb2a16)
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/Query.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/io/TimeRange.java
> Revert to IOException in TimeRange constructor to maintain API compat in 1.x
> line
> -
>
> Key: HBASE-15283
> URL: https://issues.apache.org/jira/browse/HBASE-15283
> Project: HBase
> Issue Type: Bug
> Components: Client
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Jonathan Hsieh
>Assignee: Jonathan Hsieh
> Fix For: 1.2.0, 1.3.0
>
> Attachments: hbase-15283.branch-1.patch, hbase-15283.v2.branch-1.patch
>
>
> From the 1.2 rc3 conversation:
> [~busbey]
> {quote}
> * TimeRange's constructor with a min/max came in HBASE-14355. The
> constructor changed from IOException in the case of min > max to
> IllegalArgumentException. That's probably a more accurate exception,
> but it's a substantial source compat and behavior change for
> downstream. I've flagged the issue as incompatible and asked for a
> release note. For some reason the javadocs for TimeRange claim it's
> "for internal use only" so maybe it shouldn't have been IA.Public in
> the first place.
> {quote}
> Jon:
> {quote}
> A user could trigger the TimeRange constructed exception change by with the
> Get#setTimeRange/Scan#setTimeRange/Increment#setTimeRange apis. The
> signature in these classes don't change. (master [1], branch-1.2[2], tag
> 1.1.3[3])
> Doing a little digging, it is worth noting that no public APIs take time
> range as an argument (HRegion, TimeRangeTracker do but they are private),
> however a few public metrics return it (Get, Scan, Increment). The comment
> also basically says don't use the constructor.
> {quote}
> [1]https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L205
> [2]https://github.com/apache/hbase/blob/branch-1.2/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L195
> [3]
> https://github.com/apache/hbase/blob/rel/1.1.3/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L191
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15283) Revert to IOException in TimeRange constructor to maintain API compat in 1.x line
[
https://issues.apache.org/jira/browse/HBASE-15283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151699#comment-15151699
]
Hudson commented on HBASE-15283:
SUCCESS: Integrated in HBase-1.2-IT #440 (See
[https://builds.apache.org/job/HBase-1.2-IT/440/])
HBASE-15283 Revert to IOException in TimeRange constructor to maintain
(jmhsieh: rev a8314301c28aa0738596f1dc2dd87f4d8dcb2a16)
* hbase-common/src/main/java/org/apache/hadoop/hbase/io/TimeRange.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/Query.java
> Revert to IOException in TimeRange constructor to maintain API compat in 1.x
> line
> -
>
> Key: HBASE-15283
> URL: https://issues.apache.org/jira/browse/HBASE-15283
> Project: HBase
> Issue Type: Bug
> Components: Client
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Jonathan Hsieh
>Assignee: Jonathan Hsieh
> Fix For: 1.2.0, 1.3.0
>
> Attachments: hbase-15283.branch-1.patch, hbase-15283.v2.branch-1.patch
>
>
> From the 1.2 rc3 conversation:
> [~busbey]
> {quote}
> * TimeRange's constructor with a min/max came in HBASE-14355. The
> constructor changed from IOException in the case of min > max to
> IllegalArgumentException. That's probably a more accurate exception,
> but it's a substantial source compat and behavior change for
> downstream. I've flagged the issue as incompatible and asked for a
> release note. For some reason the javadocs for TimeRange claim it's
> "for internal use only" so maybe it shouldn't have been IA.Public in
> the first place.
> {quote}
> Jon:
> {quote}
> A user could trigger the TimeRange constructed exception change by with the
> Get#setTimeRange/Scan#setTimeRange/Increment#setTimeRange apis. The
> signature in these classes don't change. (master [1], branch-1.2[2], tag
> 1.1.3[3])
> Doing a little digging, it is worth noting that no public APIs take time
> range as an argument (HRegion, TimeRangeTracker do but they are private),
> however a few public metrics return it (Get, Scan, Increment). The comment
> also basically says don't use the constructor.
> {quote}
> [1]https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L205
> [2]https://github.com/apache/hbase/blob/branch-1.2/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L195
> [3]
> https://github.com/apache/hbase/blob/rel/1.1.3/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L191
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15283) Revert to IOException in TimeRange constructor to maintain API compat in 1.x line
[
https://issues.apache.org/jira/browse/HBASE-15283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151666#comment-15151666
]
Hudson commented on HBASE-15283:
SUCCESS: Integrated in HBase-1.3-IT #504 (See
[https://builds.apache.org/job/HBase-1.3-IT/504/])
HBASE-15283 Revert to IOException in TimeRange constructor to maintain
(jmhsieh: rev 2e1a3ef644be31fd35d10769722c7b1ea8be443f)
* hbase-common/src/main/java/org/apache/hadoop/hbase/io/TimeRange.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/Query.java
> Revert to IOException in TimeRange constructor to maintain API compat in 1.x
> line
> -
>
> Key: HBASE-15283
> URL: https://issues.apache.org/jira/browse/HBASE-15283
> Project: HBase
> Issue Type: Bug
> Components: Client
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Jonathan Hsieh
>Assignee: Jonathan Hsieh
> Fix For: 1.2.0, 1.3.0
>
> Attachments: hbase-15283.branch-1.patch, hbase-15283.v2.branch-1.patch
>
>
> From the 1.2 rc3 conversation:
> [~busbey]
> {quote}
> * TimeRange's constructor with a min/max came in HBASE-14355. The
> constructor changed from IOException in the case of min > max to
> IllegalArgumentException. That's probably a more accurate exception,
> but it's a substantial source compat and behavior change for
> downstream. I've flagged the issue as incompatible and asked for a
> release note. For some reason the javadocs for TimeRange claim it's
> "for internal use only" so maybe it shouldn't have been IA.Public in
> the first place.
> {quote}
> Jon:
> {quote}
> A user could trigger the TimeRange constructed exception change by with the
> Get#setTimeRange/Scan#setTimeRange/Increment#setTimeRange apis. The
> signature in these classes don't change. (master [1], branch-1.2[2], tag
> 1.1.3[3])
> Doing a little digging, it is worth noting that no public APIs take time
> range as an argument (HRegion, TimeRangeTracker do but they are private),
> however a few public metrics return it (Get, Scan, Increment). The comment
> also basically says don't use the constructor.
> {quote}
> [1]https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L205
> [2]https://github.com/apache/hbase/blob/branch-1.2/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L195
> [3]
> https://github.com/apache/hbase/blob/rel/1.1.3/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L191
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15283) Revert to IOException in TimeRange constructor to maintain API compat in 1.x line
[
https://issues.apache.org/jira/browse/HBASE-15283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151652#comment-15151652
]
Sean Busbey commented on HBASE-15283:
-
should get pulled to 0.98 as well
> Revert to IOException in TimeRange constructor to maintain API compat in 1.x
> line
> -
>
> Key: HBASE-15283
> URL: https://issues.apache.org/jira/browse/HBASE-15283
> Project: HBase
> Issue Type: Bug
> Components: Client
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Jonathan Hsieh
>Assignee: Jonathan Hsieh
> Fix For: 1.2.0, 1.3.0
>
> Attachments: hbase-15283.branch-1.patch, hbase-15283.v2.branch-1.patch
>
>
> From the 1.2 rc3 conversation:
> [~busbey]
> {quote}
> * TimeRange's constructor with a min/max came in HBASE-14355. The
> constructor changed from IOException in the case of min > max to
> IllegalArgumentException. That's probably a more accurate exception,
> but it's a substantial source compat and behavior change for
> downstream. I've flagged the issue as incompatible and asked for a
> release note. For some reason the javadocs for TimeRange claim it's
> "for internal use only" so maybe it shouldn't have been IA.Public in
> the first place.
> {quote}
> Jon:
> {quote}
> A user could trigger the TimeRange constructed exception change by with the
> Get#setTimeRange/Scan#setTimeRange/Increment#setTimeRange apis. The
> signature in these classes don't change. (master [1], branch-1.2[2], tag
> 1.1.3[3])
> Doing a little digging, it is worth noting that no public APIs take time
> range as an argument (HRegion, TimeRangeTracker do but they are private),
> however a few public metrics return it (Get, Scan, Increment). The comment
> also basically says don't use the constructor.
> {quote}
> [1]https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L205
> [2]https://github.com/apache/hbase/blob/branch-1.2/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L195
> [3]
> https://github.com/apache/hbase/blob/rel/1.1.3/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L191
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15283) Revert to IOException in TimeRange constructor to maintain API compat in 1.x line
[
https://issues.apache.org/jira/browse/HBASE-15283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151634#comment-15151634
]
Hudson commented on HBASE-15283:
SUCCESS: Integrated in HBase-1.3 #557 (See
[https://builds.apache.org/job/HBase-1.3/557/])
HBASE-15283 Revert to IOException in TimeRange constructor to maintain
(jmhsieh: rev 2e1a3ef644be31fd35d10769722c7b1ea8be443f)
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/Query.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/io/TimeRange.java
> Revert to IOException in TimeRange constructor to maintain API compat in 1.x
> line
> -
>
> Key: HBASE-15283
> URL: https://issues.apache.org/jira/browse/HBASE-15283
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Jonathan Hsieh
>Assignee: Jonathan Hsieh
> Fix For: 1.2.0, 1.3.0
>
> Attachments: hbase-15283.branch-1.patch, hbase-15283.v2.branch-1.patch
>
>
> From the 1.2 rc3 conversation:
> [~busbey]
> {quote}
> * TimeRange's constructor with a min/max came in HBASE-14355. The
> constructor changed from IOException in the case of min > max to
> IllegalArgumentException. That's probably a more accurate exception,
> but it's a substantial source compat and behavior change for
> downstream. I've flagged the issue as incompatible and asked for a
> release note. For some reason the javadocs for TimeRange claim it's
> "for internal use only" so maybe it shouldn't have been IA.Public in
> the first place.
> {quote}
> Jon:
> {quote}
> A user could trigger the TimeRange constructed exception change by with the
> Get#setTimeRange/Scan#setTimeRange/Increment#setTimeRange apis. The
> signature in these classes don't change. (master [1], branch-1.2[2], tag
> 1.1.3[3])
> Doing a little digging, it is worth noting that no public APIs take time
> range as an argument (HRegion, TimeRangeTracker do but they are private),
> however a few public metrics return it (Get, Scan, Increment). The comment
> also basically says don't use the constructor.
> {quote}
> [1]https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L205
> [2]https://github.com/apache/hbase/blob/branch-1.2/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L195
> [3]
> https://github.com/apache/hbase/blob/rel/1.1.3/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L191
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15283) Revert to IOException in TimeRange constructor to maintain API compat in 1.x line
[
https://issues.apache.org/jira/browse/HBASE-15283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151450#comment-15151450
]
Matteo Bertozzi commented on HBASE-15283:
-
+1
> Revert to IOException in TimeRange constructor to maintain API compat in 1.x
> line
> -
>
> Key: HBASE-15283
> URL: https://issues.apache.org/jira/browse/HBASE-15283
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Jonathan Hsieh
>Assignee: Jonathan Hsieh
> Fix For: 1.2.0, 1.3.0
>
> Attachments: hbase-15283.branch-1.patch, hbase-15283.v2.branch-1.patch
>
>
> From the 1.2 rc3 conversation:
> [~busbey]
> {quote}
> * TimeRange's constructor with a min/max came in HBASE-14355. The
> constructor changed from IOException in the case of min > max to
> IllegalArgumentException. That's probably a more accurate exception,
> but it's a substantial source compat and behavior change for
> downstream. I've flagged the issue as incompatible and asked for a
> release note. For some reason the javadocs for TimeRange claim it's
> "for internal use only" so maybe it shouldn't have been IA.Public in
> the first place.
> {quote}
> Jon:
> {quote}
> A user could trigger the TimeRange constructed exception change by with the
> Get#setTimeRange/Scan#setTimeRange/Increment#setTimeRange apis. The
> signature in these classes don't change. (master [1], branch-1.2[2], tag
> 1.1.3[3])
> Doing a little digging, it is worth noting that no public APIs take time
> range as an argument (HRegion, TimeRangeTracker do but they are private),
> however a few public metrics return it (Get, Scan, Increment). The comment
> also basically says don't use the constructor.
> {quote}
> [1]https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L205
> [2]https://github.com/apache/hbase/blob/branch-1.2/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L195
> [3]
> https://github.com/apache/hbase/blob/rel/1.1.3/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L191
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15283) Revert to IOException in TimeRange constructor to maintain API compat in 1.x line
[
https://issues.apache.org/jira/browse/HBASE-15283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151305#comment-15151305
]
Hadoop QA commented on HBASE-15283:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 15s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
35s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 27s
{color} | {color:green} branch-1 passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 32s
{color} | {color:green} branch-1 passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
20s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
21s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
38s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 28s
{color} | {color:green} branch-1 passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 36s
{color} | {color:green} branch-1 passed with JDK v1.7.0_95 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 14s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
36s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 26s
{color} | {color:green} the patch passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 26s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 33s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 33s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
21s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
21s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 4m
17s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.1
2.5.2 2.6.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 3s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 28s
{color} | {color:green} the patch passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 36s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 32s
{color} | {color:green} hbase-common in the patch passed with JDK v1.8.0_72.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 24s
{color} | {color:green} hbase-client in the patch passed with JDK v1.8.0_72.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 45s
{color} | {color:green} hbase-common in the patch passed with JDK v1.7.0_95.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 34s
{color} | {color:green} hbase-client in the patch passed with JDK v1.7.0_95.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s {color} |
[jira] [Commented] (HBASE-15283) Revert to IOException in TimeRange constructor to maintain API compat in 1.x line
[
https://issues.apache.org/jira/browse/HBASE-15283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151207#comment-15151207
]
Jonathan Hsieh commented on HBASE-15283:
No worries, and no need to give yourself a hard time. What you did was
reasonable given the comments that were there. :)
> Revert to IOException in TimeRange constructor to maintain API compat in 1.x
> line
> -
>
> Key: HBASE-15283
> URL: https://issues.apache.org/jira/browse/HBASE-15283
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Jonathan Hsieh
>Assignee: Jonathan Hsieh
> Fix For: 1.2.0, 1.3.0
>
> Attachments: hbase-15283.branch-1.patch, hbase-15283.v2.branch-1.patch
>
>
> From the 1.2 rc3 conversation:
> [~busbey]
> {quote}
> * TimeRange's constructor with a min/max came in HBASE-14355. The
> constructor changed from IOException in the case of min > max to
> IllegalArgumentException. That's probably a more accurate exception,
> but it's a substantial source compat and behavior change for
> downstream. I've flagged the issue as incompatible and asked for a
> release note. For some reason the javadocs for TimeRange claim it's
> "for internal use only" so maybe it shouldn't have been IA.Public in
> the first place.
> {quote}
> Jon:
> {quote}
> A user could trigger the TimeRange constructed exception change by with the
> Get#setTimeRange/Scan#setTimeRange/Increment#setTimeRange apis. The
> signature in these classes don't change. (master [1], branch-1.2[2], tag
> 1.1.3[3])
> Doing a little digging, it is worth noting that no public APIs take time
> range as an argument (HRegion, TimeRangeTracker do but they are private),
> however a few public metrics return it (Get, Scan, Increment). The comment
> also basically says don't use the constructor.
> {quote}
> [1]https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L205
> [2]https://github.com/apache/hbase/blob/branch-1.2/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L195
> [3]
> https://github.com/apache/hbase/blob/rel/1.1.3/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L191
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15283) Revert to IOException in TimeRange constructor to maintain API compat in 1.x line
[
https://issues.apache.org/jira/browse/HBASE-15283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151196#comment-15151196
]
Jonathan Hsieh commented on HBASE-15283:
Cool. Thanks for the pointer. I've kicked of a job to give it a try.
> Revert to IOException in TimeRange constructor to maintain API compat in 1.x
> line
> -
>
> Key: HBASE-15283
> URL: https://issues.apache.org/jira/browse/HBASE-15283
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Jonathan Hsieh
>Assignee: Jonathan Hsieh
> Fix For: 1.2.0, 1.3.0
>
> Attachments: hbase-15283.branch-1.patch, hbase-15283.v2.branch-1.patch
>
>
> From the 1.2 rc3 conversation:
> [~busbey]
> {quote}
> * TimeRange's constructor with a min/max came in HBASE-14355. The
> constructor changed from IOException in the case of min > max to
> IllegalArgumentException. That's probably a more accurate exception,
> but it's a substantial source compat and behavior change for
> downstream. I've flagged the issue as incompatible and asked for a
> release note. For some reason the javadocs for TimeRange claim it's
> "for internal use only" so maybe it shouldn't have been IA.Public in
> the first place.
> {quote}
> Jon:
> {quote}
> A user could trigger the TimeRange constructed exception change by with the
> Get#setTimeRange/Scan#setTimeRange/Increment#setTimeRange apis. The
> signature in these classes don't change. (master [1], branch-1.2[2], tag
> 1.1.3[3])
> Doing a little digging, it is worth noting that no public APIs take time
> range as an argument (HRegion, TimeRangeTracker do but they are private),
> however a few public metrics return it (Get, Scan, Increment). The comment
> also basically says don't use the constructor.
> {quote}
> [1]https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L205
> [2]https://github.com/apache/hbase/blob/branch-1.2/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L195
> [3]
> https://github.com/apache/hbase/blob/rel/1.1.3/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L191
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15283) Revert to IOException in TimeRange constructor to maintain API compat in 1.x line
[
https://issues.apache.org/jira/browse/HBASE-15283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151185#comment-15151185
]
churro morales commented on HBASE-15283:
[~jmhsieh] thanks for the patch, I caused a mess on that one.
> Revert to IOException in TimeRange constructor to maintain API compat in 1.x
> line
> -
>
> Key: HBASE-15283
> URL: https://issues.apache.org/jira/browse/HBASE-15283
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Jonathan Hsieh
>Assignee: Jonathan Hsieh
> Fix For: 1.2.0, 1.3.0
>
> Attachments: hbase-15283.branch-1.patch, hbase-15283.v2.branch-1.patch
>
>
> From the 1.2 rc3 conversation:
> [~busbey]
> {quote}
> * TimeRange's constructor with a min/max came in HBASE-14355. The
> constructor changed from IOException in the case of min > max to
> IllegalArgumentException. That's probably a more accurate exception,
> but it's a substantial source compat and behavior change for
> downstream. I've flagged the issue as incompatible and asked for a
> release note. For some reason the javadocs for TimeRange claim it's
> "for internal use only" so maybe it shouldn't have been IA.Public in
> the first place.
> {quote}
> Jon:
> {quote}
> A user could trigger the TimeRange constructed exception change by with the
> Get#setTimeRange/Scan#setTimeRange/Increment#setTimeRange apis. The
> signature in these classes don't change. (master [1], branch-1.2[2], tag
> 1.1.3[3])
> Doing a little digging, it is worth noting that no public APIs take time
> range as an argument (HRegion, TimeRangeTracker do but they are private),
> however a few public metrics return it (Get, Scan, Increment). The comment
> also basically says don't use the constructor.
> {quote}
> [1]https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L205
> [2]https://github.com/apache/hbase/blob/branch-1.2/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L195
> [3]
> https://github.com/apache/hbase/blob/rel/1.1.3/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L191
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15283) Revert to IOException in TimeRange constructor to maintain API compat in 1.x line
[
https://issues.apache.org/jira/browse/HBASE-15283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151141#comment-15151141
]
Sean Busbey commented on HBASE-15283:
-
The build error for module ordering is YETUS-280. you can build with this
change in place if you go to the precommit job and use "build with parameters"
to check the USE_YETUS_PRERELEASE option.
> Revert to IOException in TimeRange constructor to maintain API compat in 1.x
> line
> -
>
> Key: HBASE-15283
> URL: https://issues.apache.org/jira/browse/HBASE-15283
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Jonathan Hsieh
>Assignee: Jonathan Hsieh
> Fix For: 1.2.0, 1.3.0
>
> Attachments: hbase-15283.branch-1.patch, hbase-15283.v2.branch-1.patch
>
>
> From the 1.2 rc3 conversation:
> [~busbey]
> {quote}
> * TimeRange's constructor with a min/max came in HBASE-14355. The
> constructor changed from IOException in the case of min > max to
> IllegalArgumentException. That's probably a more accurate exception,
> but it's a substantial source compat and behavior change for
> downstream. I've flagged the issue as incompatible and asked for a
> release note. For some reason the javadocs for TimeRange claim it's
> "for internal use only" so maybe it shouldn't have been IA.Public in
> the first place.
> {quote}
> Jon:
> {quote}
> A user could trigger the TimeRange constructed exception change by with the
> Get#setTimeRange/Scan#setTimeRange/Increment#setTimeRange apis. The
> signature in these classes don't change. (master [1], branch-1.2[2], tag
> 1.1.3[3])
> Doing a little digging, it is worth noting that no public APIs take time
> range as an argument (HRegion, TimeRangeTracker do but they are private),
> however a few public metrics return it (Get, Scan, Increment). The comment
> also basically says don't use the constructor.
> {quote}
> [1]https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L205
> [2]https://github.com/apache/hbase/blob/branch-1.2/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L195
> [3]
> https://github.com/apache/hbase/blob/rel/1.1.3/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L191
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15283) Revert to IOException in TimeRange constructor to maintain API compat in 1.x line
[
https://issues.apache.org/jira/browse/HBASE-15283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151126#comment-15151126
]
Jonathan Hsieh commented on HBASE-15283:
[~busbey], Looks like yetus didn't follow dependency order -- hbase-common's
mvn install needed to happen before hbase-client's.l
I'm going to run the patch on my setup and if it passes commit.
{code}
cd /testptch/hbase/hbase-client
mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hbase-branch-1-1
-DHBasePatchProcess -fae clean install -DskipTests=true
-Dmaven.javadoc.skip=true >
/testptch/patchprocess/patch-mvninstall-hbase-client.txt 2>&1
Elapsed: 0m 17s
cd /testptch/hbase/hbase-common
mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hbase-branch-1-1
-DHBasePatchProcess -fae clean install -DskipTests=true
-Dmaven.javadoc.skip=true >
/testptch/patchprocess/patch-mvninstall-hbase-common.txt 2>&1
Elapsed: 0m 20s
hbase-client in the patch failed.
{code}
> Revert to IOException in TimeRange constructor to maintain API compat in 1.x
> line
> -
>
> Key: HBASE-15283
> URL: https://issues.apache.org/jira/browse/HBASE-15283
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Jonathan Hsieh
>Assignee: Jonathan Hsieh
> Fix For: 1.2.0, 1.3.0
>
> Attachments: hbase-15283.branch-1.patch, hbase-15283.v2.branch-1.patch
>
>
> From the 1.2 rc3 conversation:
> [~busbey]
> {quote}
> * TimeRange's constructor with a min/max came in HBASE-14355. The
> constructor changed from IOException in the case of min > max to
> IllegalArgumentException. That's probably a more accurate exception,
> but it's a substantial source compat and behavior change for
> downstream. I've flagged the issue as incompatible and asked for a
> release note. For some reason the javadocs for TimeRange claim it's
> "for internal use only" so maybe it shouldn't have been IA.Public in
> the first place.
> {quote}
> Jon:
> {quote}
> A user could trigger the TimeRange constructed exception change by with the
> Get#setTimeRange/Scan#setTimeRange/Increment#setTimeRange apis. The
> signature in these classes don't change. (master [1], branch-1.2[2], tag
> 1.1.3[3])
> Doing a little digging, it is worth noting that no public APIs take time
> range as an argument (HRegion, TimeRangeTracker do but they are private),
> however a few public metrics return it (Get, Scan, Increment). The comment
> also basically says don't use the constructor.
> {quote}
> [1]https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L205
> [2]https://github.com/apache/hbase/blob/branch-1.2/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L195
> [3]
> https://github.com/apache/hbase/blob/rel/1.1.3/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L191
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15283) Revert to IOException in TimeRange constructor to maintain API compat in 1.x line
[
https://issues.apache.org/jira/browse/HBASE-15283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151103#comment-15151103
]
Hadoop QA commented on HBASE-15283:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
31s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 41s
{color} | {color:green} branch-1 passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 35s
{color} | {color:green} branch-1 passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
20s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
22s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
50s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 44s
{color} | {color:green} branch-1 passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 41s
{color} | {color:green} branch-1 passed with JDK v1.7.0_95 {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 17s
{color} | {color:red} hbase-client in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 42s
{color} | {color:green} the patch passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 42s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 37s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 37s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
20s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
23s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 4m
41s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.1
2.5.2 2.6.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 9s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 43s
{color} | {color:green} the patch passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 40s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 37s
{color} | {color:green} hbase-client in the patch passed with JDK v1.8.0_72.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 51s
{color} | {color:green} hbase-common in the patch passed with JDK v1.8.0_72.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 38s
{color} | {color:green} hbase-client in the patch passed with JDK v1.7.0_95.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 47s
{color} | {color:green} hbase-common in the patch passed with JDK v1.7.0_95.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 22s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-02-17 |
|
[jira] [Commented] (HBASE-15283) Revert to IOException in TimeRange constructor to maintain API compat in 1.x line
[
https://issues.apache.org/jira/browse/HBASE-15283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151084#comment-15151084
]
Jonathan Hsieh commented on HBASE-15283:
Going to wait for v2's tests to run. I believe both compiled and ran for me --
might be due to 'mvn install' vs 'mvn clean test -DskipTests'?
> Revert to IOException in TimeRange constructor to maintain API compat in 1.x
> line
> -
>
> Key: HBASE-15283
> URL: https://issues.apache.org/jira/browse/HBASE-15283
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Jonathan Hsieh
>Assignee: Jonathan Hsieh
> Fix For: 1.2.0, 1.3.0
>
> Attachments: hbase-15283.branch-1.patch, hbase-15283.v2.branch-1.patch
>
>
> From the 1.2 rc3 conversation:
> [~busbey]
> {quote}
> * TimeRange's constructor with a min/max came in HBASE-14355. The
> constructor changed from IOException in the case of min > max to
> IllegalArgumentException. That's probably a more accurate exception,
> but it's a substantial source compat and behavior change for
> downstream. I've flagged the issue as incompatible and asked for a
> release note. For some reason the javadocs for TimeRange claim it's
> "for internal use only" so maybe it shouldn't have been IA.Public in
> the first place.
> {quote}
> Jon:
> {quote}
> A user could trigger the TimeRange constructed exception change by with the
> Get#setTimeRange/Scan#setTimeRange/Increment#setTimeRange apis. The
> signature in these classes don't change. (master [1], branch-1.2[2], tag
> 1.1.3[3])
> Doing a little digging, it is worth noting that no public APIs take time
> range as an argument (HRegion, TimeRangeTracker do but they are private),
> however a few public metrics return it (Get, Scan, Increment). The comment
> also basically says don't use the constructor.
> {quote}
> [1]https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L205
> [2]https://github.com/apache/hbase/blob/branch-1.2/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L195
> [3]
> https://github.com/apache/hbase/blob/rel/1.1.3/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L191
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15283) Revert to IOException in TimeRange constructor to maintain API compat in 1.x line
[
https://issues.apache.org/jira/browse/HBASE-15283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151073#comment-15151073
]
stack commented on HBASE-15283:
---
+1 on patch.
> Revert to IOException in TimeRange constructor to maintain API compat in 1.x
> line
> -
>
> Key: HBASE-15283
> URL: https://issues.apache.org/jira/browse/HBASE-15283
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Jonathan Hsieh
>Assignee: Jonathan Hsieh
> Fix For: 1.2.0, 1.3.0
>
> Attachments: hbase-15283.branch-1.patch, hbase-15283.v2.branch-1.patch
>
>
> From the 1.2 rc3 conversation:
> [~busbey]
> {quote}
> * TimeRange's constructor with a min/max came in HBASE-14355. The
> constructor changed from IOException in the case of min > max to
> IllegalArgumentException. That's probably a more accurate exception,
> but it's a substantial source compat and behavior change for
> downstream. I've flagged the issue as incompatible and asked for a
> release note. For some reason the javadocs for TimeRange claim it's
> "for internal use only" so maybe it shouldn't have been IA.Public in
> the first place.
> {quote}
> Jon:
> {quote}
> A user could trigger the TimeRange constructed exception change by with the
> Get#setTimeRange/Scan#setTimeRange/Increment#setTimeRange apis. The
> signature in these classes don't change. (master [1], branch-1.2[2], tag
> 1.1.3[3])
> Doing a little digging, it is worth noting that no public APIs take time
> range as an argument (HRegion, TimeRangeTracker do but they are private),
> however a few public metrics return it (Get, Scan, Increment). The comment
> also basically says don't use the constructor.
> {quote}
> [1]https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L205
> [2]https://github.com/apache/hbase/blob/branch-1.2/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L195
> [3]
> https://github.com/apache/hbase/blob/rel/1.1.3/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L191
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15283) Revert to IOException in TimeRange constructor to maintain API compat in 1.x line
[
https://issues.apache.org/jira/browse/HBASE-15283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151061#comment-15151061
]
Hadoop QA commented on HBASE-15283:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
49s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 48s
{color} | {color:green} branch-1 passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 39s
{color} | {color:green} branch-1 passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
27s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
31s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
42s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 48s
{color} | {color:green} branch-1 passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 42s
{color} | {color:green} branch-1 passed with JDK v1.7.0_95 {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 16s
{color} | {color:red} hbase-client in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 41s
{color} | {color:green} the patch passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 41s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 35s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 35s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
20s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
23s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 4m
36s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.1
2.5.2 2.6.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 6s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 44s
{color} | {color:green} the patch passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 42s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 40s
{color} | {color:green} hbase-client in the patch passed with JDK v1.8.0_72.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 50s
{color} | {color:green} hbase-common in the patch passed with JDK v1.8.0_72.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 37s
{color} | {color:green} hbase-client in the patch passed with JDK v1.7.0_95.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 51s
{color} | {color:green} hbase-common in the patch passed with JDK v1.7.0_95.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
16s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 29m 7s {color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-02-17 |
|
