[jira] [Commented] (HBASE-15358) canEnforceTimeLimitFromScope should use timeScope instead of sizeScope
[ https://issues.apache.org/jira/browse/HBASE-15358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15172184#comment-15172184 ] Hudson commented on HBASE-15358: FAILURE: Integrated in HBase-1.1-JDK7 #1672 (See [https://builds.apache.org/job/HBase-1.1-JDK7/1672/]) HBASE-15358 canEnforceTimeLimitFromScope should use timeScope instead of (zhangduo: rev 84c4fe2bd00841fe757d00759a0492a50daaa2b2) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ScannerContext.java > canEnforceTimeLimitFromScope should use timeScope instead of sizeScope > -- > > Key: HBASE-15358 > URL: https://issues.apache.org/jira/browse/HBASE-15358 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 2.0.0, 1.2.0, 1.3.0, 1.1.3, 1.4.0 >Reporter: Phil Yang >Assignee: Phil Yang > Fix For: 2.0.0, 1.3.0, 1.2.1, 1.1.4, 1.4.0 > > Attachments: HBASE-15358-v1.txt > > > A small but maybe critical bug -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15358) canEnforceTimeLimitFromScope should use timeScope instead of sizeScope
[ https://issues.apache.org/jira/browse/HBASE-15358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15172057#comment-15172057 ] Hudson commented on HBASE-15358: SUCCESS: Integrated in HBase-Trunk_matrix #745 (See [https://builds.apache.org/job/HBase-Trunk_matrix/745/]) HBASE-15358 canEnforceTimeLimitFromScope should use timeScope instead of (zhangduo: rev 88f775996b3b52d784ad13ab07515134619316ba) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ScannerContext.java > canEnforceTimeLimitFromScope should use timeScope instead of sizeScope > -- > > Key: HBASE-15358 > URL: https://issues.apache.org/jira/browse/HBASE-15358 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 2.0.0, 1.2.0, 1.3.0, 1.1.3, 1.4.0 >Reporter: Phil Yang >Assignee: Phil Yang > Fix For: 2.0.0, 1.3.0, 1.2.1, 1.1.4, 1.4.0 > > Attachments: HBASE-15358-v1.txt > > > A small but maybe critical bug -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15358) canEnforceTimeLimitFromScope should use timeScope instead of sizeScope
[ https://issues.apache.org/jira/browse/HBASE-15358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15172053#comment-15172053 ] Hudson commented on HBASE-15358: FAILURE: Integrated in HBase-1.1-JDK8 #1758 (See [https://builds.apache.org/job/HBase-1.1-JDK8/1758/]) HBASE-15358 canEnforceTimeLimitFromScope should use timeScope instead of (zhangduo: rev 84c4fe2bd00841fe757d00759a0492a50daaa2b2) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ScannerContext.java > canEnforceTimeLimitFromScope should use timeScope instead of sizeScope > -- > > Key: HBASE-15358 > URL: https://issues.apache.org/jira/browse/HBASE-15358 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 2.0.0, 1.2.0, 1.3.0, 1.1.3, 1.4.0 >Reporter: Phil Yang >Assignee: Phil Yang > Fix For: 2.0.0, 1.3.0, 1.2.1, 1.1.4, 1.4.0 > > Attachments: HBASE-15358-v1.txt > > > A small but maybe critical bug -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15358) canEnforceTimeLimitFromScope should use timeScope instead of sizeScope
[ https://issues.apache.org/jira/browse/HBASE-15358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171920#comment-15171920 ] Hudson commented on HBASE-15358: SUCCESS: Integrated in HBase-1.3 #579 (See [https://builds.apache.org/job/HBase-1.3/579/]) HBASE-15358 canEnforceTimeLimitFromScope should use timeScope instead of (zhangduo: rev 03a02969c47b2cc3d9f4918b0dd0886f1835d783) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ScannerContext.java > canEnforceTimeLimitFromScope should use timeScope instead of sizeScope > -- > > Key: HBASE-15358 > URL: https://issues.apache.org/jira/browse/HBASE-15358 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 2.0.0, 1.2.0, 1.3.0, 1.1.3, 1.4.0 >Reporter: Phil Yang >Assignee: Phil Yang > Fix For: 2.0.0, 1.3.0, 1.2.1, 1.1.4, 1.4.0 > > Attachments: HBASE-15358-v1.txt > > > A small but maybe critical bug -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15358) canEnforceTimeLimitFromScope should use timeScope instead of sizeScope
[ https://issues.apache.org/jira/browse/HBASE-15358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171914#comment-15171914 ] Hudson commented on HBASE-15358: FAILURE: Integrated in HBase-1.2 #565 (See [https://builds.apache.org/job/HBase-1.2/565/]) HBASE-15358 canEnforceTimeLimitFromScope should use timeScope instead of (zhangduo: rev 01a113e5ec7feb3571fe5aa8253934db30ce6cea) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ScannerContext.java > canEnforceTimeLimitFromScope should use timeScope instead of sizeScope > -- > > Key: HBASE-15358 > URL: https://issues.apache.org/jira/browse/HBASE-15358 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 2.0.0, 1.2.0, 1.3.0, 1.1.3, 1.4.0 >Reporter: Phil Yang >Assignee: Phil Yang > Fix For: 2.0.0, 1.3.0, 1.2.1, 1.1.4, 1.4.0 > > Attachments: HBASE-15358-v1.txt > > > A small but maybe critical bug -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15358) canEnforceTimeLimitFromScope should use timeScope instead of sizeScope
[ https://issues.apache.org/jira/browse/HBASE-15358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171782#comment-15171782 ] Hudson commented on HBASE-15358: SUCCESS: Integrated in HBase-1.2-IT #450 (See [https://builds.apache.org/job/HBase-1.2-IT/450/]) HBASE-15358 canEnforceTimeLimitFromScope should use timeScope instead of (zhangduo: rev 01a113e5ec7feb3571fe5aa8253934db30ce6cea) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ScannerContext.java > canEnforceTimeLimitFromScope should use timeScope instead of sizeScope > -- > > Key: HBASE-15358 > URL: https://issues.apache.org/jira/browse/HBASE-15358 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 2.0.0, 1.2.0, 1.3.0, 1.1.3, 1.4.0 >Reporter: Phil Yang >Assignee: Phil Yang > Fix For: 2.0.0, 1.3.0, 1.2.1, 1.1.4, 1.4.0 > > Attachments: HBASE-15358-v1.txt > > > A small but maybe critical bug -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15358) canEnforceTimeLimitFromScope should use timeScope instead of sizeScope
[ https://issues.apache.org/jira/browse/HBASE-15358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171741#comment-15171741 ] Hudson commented on HBASE-15358: SUCCESS: Integrated in HBase-1.3-IT #526 (See [https://builds.apache.org/job/HBase-1.3-IT/526/]) HBASE-15358 canEnforceTimeLimitFromScope should use timeScope instead of (zhangduo: rev 03a02969c47b2cc3d9f4918b0dd0886f1835d783) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ScannerContext.java > canEnforceTimeLimitFromScope should use timeScope instead of sizeScope > -- > > Key: HBASE-15358 > URL: https://issues.apache.org/jira/browse/HBASE-15358 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 2.0.0, 1.2.0, 1.3.0, 1.1.3, 1.4.0 >Reporter: Phil Yang >Assignee: Phil Yang > Fix For: 2.0.0, 1.3.0, 1.2.1, 1.1.4, 1.4.0 > > Attachments: HBASE-15358-v1.txt > > > A small but maybe critical bug -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15358) canEnforceTimeLimitFromScope should use timeScope instead of sizeScope
[ https://issues.apache.org/jira/browse/HBASE-15358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171623#comment-15171623 ] Duo Zhang commented on HBASE-15358: --- Fine. Let's just commit this. > canEnforceTimeLimitFromScope should use timeScope instead of sizeScope > -- > > Key: HBASE-15358 > URL: https://issues.apache.org/jira/browse/HBASE-15358 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.0, 1.1.3 >Reporter: Phil Yang >Assignee: Phil Yang > Attachments: HBASE-15358-v1.txt > > > A small but maybe critical bug -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15358) canEnforceTimeLimitFromScope should use timeScope instead of sizeScope
[
https://issues.apache.org/jira/browse/HBASE-15358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171613#comment-15171613
]
Phil Yang commented on HBASE-15358:
---
{code}
final LimitScope sizeScope = allowPartialResults ? LimitScope.BETWEEN_CELLS :
LimitScope.BETWEEN_ROWS;
final LimitScope timeScope = allowHeartbeatMessages ? LimitScope.BETWEEN_CELLS
: LimitScope.BETWEEN_ROWS;
{code}
Because we supported HBASE-11544 before HBASE-13090, so there are three
possible situations: allow none, allow PartialResults but don't allow
HeartbeatMessages, or allow both. So if a client only support PartialResults,
at canEnforceTimeLimitFromScope it may be return true and may send back a wrong
heartbeat which is not supported by client.
However, both HBASE-11544 and HBASE-13090 are fixed on 1.1.0, so there are
only two situations in all released versions: allow both or none. So maybe it
will not be a critical bug, actually it has no bad effect on released
versions...
I think if we want to add a testcase to reproduce this bug, we should disable
allowHeartbeatMessages which will not be disabled by users. Should we still add
the testcase?
> canEnforceTimeLimitFromScope should use timeScope instead of sizeScope
> --
>
> Key: HBASE-15358
> URL: https://issues.apache.org/jira/browse/HBASE-15358
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 1.1.3
>Reporter: Phil Yang
>Assignee: Phil Yang
> Attachments: HBASE-15358-v1.txt
>
>
> A small but maybe critical bug
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15358) canEnforceTimeLimitFromScope should use timeScope instead of sizeScope
[ https://issues.apache.org/jira/browse/HBASE-15358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171592#comment-15171592 ] Duo Zhang commented on HBASE-15358: --- Yes this should be a typo. Can we add a testcase for it? > canEnforceTimeLimitFromScope should use timeScope instead of sizeScope > -- > > Key: HBASE-15358 > URL: https://issues.apache.org/jira/browse/HBASE-15358 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.0, 1.1.3 >Reporter: Phil Yang >Assignee: Phil Yang > Attachments: HBASE-15358-v1.txt > > > A small but maybe critical bug -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15358) canEnforceTimeLimitFromScope should use timeScope instead of sizeScope
[ https://issues.apache.org/jira/browse/HBASE-15358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171583#comment-15171583 ] Phil Yang commented on HBASE-15358: --- This patch can be and should be applied to branch-1.1 branch-1.2 branch-1.3 branch-1 and master. Thanks. > canEnforceTimeLimitFromScope should use timeScope instead of sizeScope > -- > > Key: HBASE-15358 > URL: https://issues.apache.org/jira/browse/HBASE-15358 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.0, 1.1.3 >Reporter: Phil Yang >Assignee: Phil Yang > Attachments: HBASE-15358-v1.txt > > > A small but maybe critical bug -- This message was sent by Atlassian JIRA (v6.3.4#6332)
