[jira] [Commented] (HBASE-15451) Remove unnecessary wait in MVCC
[
https://issues.apache.org/jira/browse/HBASE-15451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15340183#comment-15340183
]
Mikhail Antonov commented on HBASE-15451:
-
Seems like Hudson mis-reporting the branchs stuff was integrated in, 1.3-IT
shouldn't have been show up here. Marking fixVer as 1.4.
> Remove unnecessary wait in MVCC
> ---
>
> Key: HBASE-15451
> URL: https://issues.apache.org/jira/browse/HBASE-15451
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.0.0, 1.2.0
>Reporter: Yu Li
>Assignee: Yu Li
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-15451.patch, HBASE-15451.test
>
>
> Currently the return value of MVCC#complete indicates whether readPoint
> already advanced over write number of the given WriteEntry:
> {code}
> return readPoint.get() >= writeEntry.getWriteNumber();
> {code}
> While in MVCC#checkAndWait we never take usage of this but always call
> waitForRead which will acquire and release lock on {{readWaiters}} and cause
> additional context switch. This JIRA will improve this logic and remove the
> unnecessary wait.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15451) Remove unnecessary wait in MVCC
[
https://issues.apache.org/jira/browse/HBASE-15451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15203062#comment-15203062
]
Hudson commented on HBASE-15451:
SUCCESS: Integrated in HBase-1.3-IT #567 (See
[https://builds.apache.org/job/HBase-1.3-IT/567/])
HBASE-15451 Remove unnecessary wait in MVCC (liyu: rev
463374ecfa770645c7098b4648cb805933eb7aab)
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MultiVersionConcurrencyControl.java
> Remove unnecessary wait in MVCC
> ---
>
> Key: HBASE-15451
> URL: https://issues.apache.org/jira/browse/HBASE-15451
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.0.0, 1.2.0
>Reporter: Yu Li
>Assignee: Yu Li
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-15451.patch, HBASE-15451.test
>
>
> Currently the return value of MVCC#complete indicates whether readPoint
> already advanced over write number of the given WriteEntry:
> {code}
> return readPoint.get() >= writeEntry.getWriteNumber();
> {code}
> While in MVCC#checkAndWait we never take usage of this but always call
> waitForRead which will acquire and release lock on {{readWaiters}} and cause
> additional context switch. This JIRA will improve this logic and remove the
> unnecessary wait.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15451) Remove unnecessary wait in MVCC
[
https://issues.apache.org/jira/browse/HBASE-15451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202991#comment-15202991
]
Hudson commented on HBASE-15451:
SUCCESS: Integrated in HBase-1.4 #33 (See
[https://builds.apache.org/job/HBase-1.4/33/])
HBASE-15451 Remove unnecessary wait in MVCC (liyu: rev
463374ecfa770645c7098b4648cb805933eb7aab)
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MultiVersionConcurrencyControl.java
> Remove unnecessary wait in MVCC
> ---
>
> Key: HBASE-15451
> URL: https://issues.apache.org/jira/browse/HBASE-15451
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.0.0, 1.2.0
>Reporter: Yu Li
>Assignee: Yu Li
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-15451.patch, HBASE-15451.test
>
>
> Currently the return value of MVCC#complete indicates whether readPoint
> already advanced over write number of the given WriteEntry:
> {code}
> return readPoint.get() >= writeEntry.getWriteNumber();
> {code}
> While in MVCC#checkAndWait we never take usage of this but always call
> waitForRead which will acquire and release lock on {{readWaiters}} and cause
> additional context switch. This JIRA will improve this logic and remove the
> unnecessary wait.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15451) Remove unnecessary wait in MVCC
[
https://issues.apache.org/jira/browse/HBASE-15451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202979#comment-15202979
]
Hudson commented on HBASE-15451:
FAILURE: Integrated in HBase-Trunk_matrix #789 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/789/])
HBASE-15451 Remove unnecessary wait in MVCC (liyu: rev
d2d8058ab35ec16e1f27a117aee8baa18e52a136)
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MultiVersionConcurrencyControl.java
> Remove unnecessary wait in MVCC
> ---
>
> Key: HBASE-15451
> URL: https://issues.apache.org/jira/browse/HBASE-15451
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.0.0, 1.2.0
>Reporter: Yu Li
>Assignee: Yu Li
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-15451.patch, HBASE-15451.test
>
>
> Currently the return value of MVCC#complete indicates whether readPoint
> already advanced over write number of the given WriteEntry:
> {code}
> return readPoint.get() >= writeEntry.getWriteNumber();
> {code}
> While in MVCC#checkAndWait we never take usage of this but always call
> waitForRead which will acquire and release lock on {{readWaiters}} and cause
> additional context switch. This JIRA will improve this logic and remove the
> unnecessary wait.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15451) Remove unnecessary wait in MVCC
[
https://issues.apache.org/jira/browse/HBASE-15451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192672#comment-15192672
]
Yu Li commented on HBASE-15451:
---
Thanks for review and help trigger HadoopQA run [~tedyu]!
> Remove unnecessary wait in MVCC
> ---
>
> Key: HBASE-15451
> URL: https://issues.apache.org/jira/browse/HBASE-15451
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.0.0, 1.2.0
>Reporter: Yu Li
>Assignee: Yu Li
> Attachments: HBASE-15451.patch, HBASE-15451.test
>
>
> Currently the return value of MVCC#complete indicates whether readPoint
> already advanced over write number of the given WriteEntry:
> {code}
> return readPoint.get() >= writeEntry.getWriteNumber();
> {code}
> While in MVCC#checkAndWait we never take usage of this but always call
> waitForRead which will acquire and release lock on {{readWaiters}} and cause
> additional context switch. This JIRA will improve this logic and remove the
> unnecessary wait.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15451) Remove unnecessary wait in MVCC
[
https://issues.apache.org/jira/browse/HBASE-15451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192502#comment-15192502
]
Ted Yu commented on HBASE-15451:
+1
> Remove unnecessary wait in MVCC
> ---
>
> Key: HBASE-15451
> URL: https://issues.apache.org/jira/browse/HBASE-15451
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.0.0, 1.2.0
>Reporter: Yu Li
>Assignee: Yu Li
> Attachments: HBASE-15451.patch, HBASE-15451.test
>
>
> Currently the return value of MVCC#complete indicates whether readPoint
> already advanced over write number of the given WriteEntry:
> {code}
> return readPoint.get() >= writeEntry.getWriteNumber();
> {code}
> While in MVCC#checkAndWait we never take usage of this but always call
> waitForRead which will acquire and release lock on {{readWaiters}} and cause
> additional context switch. This JIRA will improve this logic and remove the
> unnecessary wait.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15451) Remove unnecessary wait in MVCC
[
https://issues.apache.org/jira/browse/HBASE-15451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192455#comment-15192455
]
Hadoop QA commented on HBASE-15451:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m 0s
{color} | {color:blue} The patch file was not named according to hbase's naming
conventions. Please see
https://yetus.apache.org/documentation/0.2.0/precommit-patchnames for
instructions. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
5s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 41s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 32s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
35s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
50s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 27s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 32s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
41s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 37s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 37s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 31s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 31s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
8s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
24m 38s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 7s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 26s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 32s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 89m 29s
{color} | {color:green} hbase-server in the patch passed with JDK v1.8.0.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 88m 15s
{color} | {color:green} hbase-server in the patch passed with JDK v1.7.0_79.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
22s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 224m 23s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12793194/HBASE-15451.test |
| JIRA Issue | HBASE-15451 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU
[jira] [Commented] (HBASE-15451) Remove unnecessary wait in MVCC
[
https://issues.apache.org/jira/browse/HBASE-15451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192363#comment-15192363
]
Ted Yu commented on HBASE-15451:
Makes sense.
I have triggered another QA run.
> Remove unnecessary wait in MVCC
> ---
>
> Key: HBASE-15451
> URL: https://issues.apache.org/jira/browse/HBASE-15451
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.0.0, 1.2.0
>Reporter: Yu Li
>Assignee: Yu Li
> Attachments: HBASE-15451.patch, HBASE-15451.test
>
>
> Currently the return value of MVCC#complete indicates whether readPoint
> already advanced over write number of the given WriteEntry:
> {code}
> return readPoint.get() >= writeEntry.getWriteNumber();
> {code}
> While in MVCC#checkAndWait we never take usage of this but always call
> waitForRead which will acquire and release lock on {{readWaiters}} and cause
> additional context switch. This JIRA will improve this logic and remove the
> unnecessary wait.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15451) Remove unnecessary wait in MVCC
[
https://issues.apache.org/jira/browse/HBASE-15451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192312#comment-15192312
]
Hadoop QA commented on HBASE-15451:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m 1s
{color} | {color:blue} The patch file was not named according to hbase's naming
conventions. Please see
https://yetus.apache.org/documentation/0.2.0/precommit-patchnames for
instructions. {color} |
| {color:red}-1{color} | {color:red} docker {color} | {color:red} 10m 50s
{color} | {color:red} Docker failed to build yetus/hbase:date2016-03-13.
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12793194/HBASE-15451.test |
| JIRA Issue | HBASE-15451 |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/947/console |
| Powered by | Apache Yetus 0.2.0 http://yetus.apache.org |
This message was automatically generated.
> Remove unnecessary wait in MVCC
> ---
>
> Key: HBASE-15451
> URL: https://issues.apache.org/jira/browse/HBASE-15451
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.0.0, 1.2.0
>Reporter: Yu Li
>Assignee: Yu Li
> Attachments: HBASE-15451.patch, HBASE-15451.test
>
>
> Currently the return value of MVCC#complete indicates whether readPoint
> already advanced over write number of the given WriteEntry:
> {code}
> return readPoint.get() >= writeEntry.getWriteNumber();
> {code}
> While in MVCC#checkAndWait we never take usage of this but always call
> waitForRead which will acquire and release lock on {{readWaiters}} and cause
> additional context switch. This JIRA will improve this logic and remove the
> unnecessary wait.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
