[jira] [Commented] (HBASE-15456) CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200696#comment-15200696 ] Hudson commented on HBASE-15456: SUCCESS: Integrated in HBase-1.3-IT #560 (See [https://builds.apache.org/job/HBase-1.3-IT/560/]) HBASE-15456 CreateTableProcedure/ModifyTableProcedure needs to fail when (tedyu: rev e4409c2f8c82f1b061f4dce2eb342c61999bf2e3) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestOpenRegionHandler.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/namespace/TestNamespaceAuditor.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CreateTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestOpenedRegionHandler.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestCloseRegionHandler.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestCreateTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestModifyTableProcedure.java > CreateTableProcedure/ModifyTableProcedure needs to fail when there is no > family in table descriptor > --- > > Key: HBASE-15456 > URL: https://issues.apache.org/jira/browse/HBASE-15456 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15456-001_branch-1.patch, > HBASE-15456-branch-1.patch, HBASE-15456-branch-1.patch, > HBASE-15456-v001.patch, HBASE-15456-v002.patch, HBASE-15456-v002.patch, > HBASE-15456-v003.patch > > > If there is only one family in the table, DeleteColumnFamilyProcedure will > fail. > Currently, when hbase.table.sanity.checks is set to false, hbase master logs > a warning and CreateTableProcedure/ModifyTableProcedure will succeed. > This behavior is not consistent with DeleteColumnFamilyProcedure's. > Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the > following exception. lastStoreFlushTimeMap is populated for families, if > there is no family in the table, there is no entry in lastStoreFlushTimeMap. > {code} > 16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: > Caught exception > java.util.NoSuchElementException > at > java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) > > at > java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) > > at java.util.Collections.min(Collections.java:628) > at > org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) > > at > org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) > at > org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) > > at org.apache.hadoop.hbase.Chore.run(Chore.java:87) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15456) CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200706#comment-15200706 ] Ted Yu commented on HBASE-15456: [~huaxiang]: Looks like there were some thrift tests which should have been modified - even for master branch. Can you run tests in modules other than hbase-server so that we get this right ? Thanks > CreateTableProcedure/ModifyTableProcedure needs to fail when there is no > family in table descriptor > --- > > Key: HBASE-15456 > URL: https://issues.apache.org/jira/browse/HBASE-15456 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15456-001_branch-1.patch, > HBASE-15456-branch-1.patch, HBASE-15456-branch-1.patch, > HBASE-15456-v001.patch, HBASE-15456-v002.patch, HBASE-15456-v002.patch, > HBASE-15456-v003.patch > > > If there is only one family in the table, DeleteColumnFamilyProcedure will > fail. > Currently, when hbase.table.sanity.checks is set to false, hbase master logs > a warning and CreateTableProcedure/ModifyTableProcedure will succeed. > This behavior is not consistent with DeleteColumnFamilyProcedure's. > Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the > following exception. lastStoreFlushTimeMap is populated for families, if > there is no family in the table, there is no entry in lastStoreFlushTimeMap. > {code} > 16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: > Caught exception > java.util.NoSuchElementException > at > java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) > > at > java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) > > at java.util.Collections.min(Collections.java:628) > at > org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) > > at > org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) > at > org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) > > at org.apache.hadoop.hbase.Chore.run(Chore.java:87) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15456) CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201412#comment-15201412 ] Ted Yu commented on HBASE-15456: Integrated to branch-1 after running TestThriftServer locally. If the build is green, will integrate to other branches. > CreateTableProcedure/ModifyTableProcedure needs to fail when there is no > family in table descriptor > --- > > Key: HBASE-15456 > URL: https://issues.apache.org/jira/browse/HBASE-15456 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15456-001_branch-1.patch, > HBASE-15456-branch-1.patch, HBASE-15456-branch-1.patch, > HBASE-15456-branch-1_v002.patch, HBASE-15456-v001.patch, > HBASE-15456-v002.patch, HBASE-15456-v002.patch, HBASE-15456-v003.patch, > HBASE-15456-v004.patch > > > If there is only one family in the table, DeleteColumnFamilyProcedure will > fail. > Currently, when hbase.table.sanity.checks is set to false, hbase master logs > a warning and CreateTableProcedure/ModifyTableProcedure will succeed. > This behavior is not consistent with DeleteColumnFamilyProcedure's. > Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the > following exception. lastStoreFlushTimeMap is populated for families, if > there is no family in the table, there is no entry in lastStoreFlushTimeMap. > {code} > 16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: > Caught exception > java.util.NoSuchElementException > at > java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) > > at > java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) > > at java.util.Collections.min(Collections.java:628) > at > org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) > > at > org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) > at > org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) > > at org.apache.hadoop.hbase.Chore.run(Chore.java:87) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15456) CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202233#comment-15202233 ] Hudson commented on HBASE-15456: FAILURE: Integrated in HBase-Trunk_matrix #788 (See [https://builds.apache.org/job/HBase-Trunk_matrix/788/]) HBASE-15456 CreateTableProcedure/ModifyTableProcedure needs to fail when (tedyu: rev 3a6d683d63089c1986e68e531939df7328e58300) * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CreateTableProcedure.java * hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestModifyTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/namespace/TestNamespaceAuditor.java * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestRegionMover.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestCreateTableProcedure.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > CreateTableProcedure/ModifyTableProcedure needs to fail when there is no > family in table descriptor > --- > > Key: HBASE-15456 > URL: https://issues.apache.org/jira/browse/HBASE-15456 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15456-001_branch-1.patch, > HBASE-15456-branch-1.patch, HBASE-15456-branch-1.patch, > HBASE-15456-branch-1_v002.patch, HBASE-15456-v001.patch, > HBASE-15456-v002.patch, HBASE-15456-v002.patch, HBASE-15456-v003.patch, > HBASE-15456-v004.patch > > > If there is only one family in the table, DeleteColumnFamilyProcedure will > fail. > Currently, when hbase.table.sanity.checks is set to false, hbase master logs > a warning and CreateTableProcedure/ModifyTableProcedure will succeed. > This behavior is not consistent with DeleteColumnFamilyProcedure's. > Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the > following exception. lastStoreFlushTimeMap is populated for families, if > there is no family in the table, there is no entry in lastStoreFlushTimeMap. > {code} > 16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: > Caught exception > java.util.NoSuchElementException > at > java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) > > at > java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) > > at java.util.Collections.min(Collections.java:628) > at > org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) > > at > org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) > at > org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) > > at org.apache.hadoop.hbase.Chore.run(Chore.java:87) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15456) CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201798#comment-15201798 ] Hudson commented on HBASE-15456: SUCCESS: Integrated in HBase-1.4 #29 (See [https://builds.apache.org/job/HBase-1.4/29/]) HBASE-15456 CreateTableProcedure/ModifyTableProcedure needs to fail when (tedyu: rev eda2656b88edc829d4d520ea5fc39cf73aca270f) * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestOpenedRegionHandler.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestOpenRegionHandler.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestCloseRegionHandler.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CreateTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/namespace/TestNamespaceAuditor.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestCreateTableProcedure.java * hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestModifyTableProcedure.java > CreateTableProcedure/ModifyTableProcedure needs to fail when there is no > family in table descriptor > --- > > Key: HBASE-15456 > URL: https://issues.apache.org/jira/browse/HBASE-15456 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15456-001_branch-1.patch, > HBASE-15456-branch-1.patch, HBASE-15456-branch-1.patch, > HBASE-15456-branch-1_v002.patch, HBASE-15456-v001.patch, > HBASE-15456-v002.patch, HBASE-15456-v002.patch, HBASE-15456-v003.patch, > HBASE-15456-v004.patch > > > If there is only one family in the table, DeleteColumnFamilyProcedure will > fail. > Currently, when hbase.table.sanity.checks is set to false, hbase master logs > a warning and CreateTableProcedure/ModifyTableProcedure will succeed. > This behavior is not consistent with DeleteColumnFamilyProcedure's. > Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the > following exception. lastStoreFlushTimeMap is populated for families, if > there is no family in the table, there is no entry in lastStoreFlushTimeMap. > {code} > 16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: > Caught exception > java.util.NoSuchElementException > at > java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) > > at > java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) > > at java.util.Collections.min(Collections.java:628) > at > org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) > > at > org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) > at > org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) > > at org.apache.hadoop.hbase.Chore.run(Chore.java:87) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15456) CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198157#comment-15198157 ] huaxiang sun commented on HBASE-15456: -- Hi [~te...@apache.org] I attached a patch for branch-1, thanks! > CreateTableProcedure/ModifyTableProcedure needs to fail when there is no > family in table descriptor > --- > > Key: HBASE-15456 > URL: https://issues.apache.org/jira/browse/HBASE-15456 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15456-001_branch-1.patch, HBASE-15456-v001.patch, > HBASE-15456-v002.patch, HBASE-15456-v002.patch, HBASE-15456-v003.patch > > > If there is only one family in the table, DeleteColumnFamilyProcedure will > fail. > Currently, when hbase.table.sanity.checks is set to false, hbase master logs > a warning and CreateTableProcedure/ModifyTableProcedure will succeed. > This behavior is not consistent with DeleteColumnFamilyProcedure's. > Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the > following exception. lastStoreFlushTimeMap is populated for families, if > there is no family in the table, there is no entry in lastStoreFlushTimeMap. > {code} > 16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: > Caught exception > java.util.NoSuchElementException > at > java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) > > at > java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) > > at java.util.Collections.min(Collections.java:628) > at > org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) > > at > org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) > at > org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) > > at org.apache.hadoop.hbase.Chore.run(Chore.java:87) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15456) CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201363#comment-15201363 ] Hudson commented on HBASE-15456: SUCCESS: Integrated in HBase-1.3 #609 (See [https://builds.apache.org/job/HBase-1.3/609/]) HBASE-15456 Revert due to unit test failure in thrift module (tedyu: rev 944d9f6b46b9d576f2dfc9f52eb7acb1f41453b2) * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestOpenRegionHandler.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestCloseRegionHandler.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CreateTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/namespace/TestNamespaceAuditor.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestModifyTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestOpenedRegionHandler.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestCreateTableProcedure.java > CreateTableProcedure/ModifyTableProcedure needs to fail when there is no > family in table descriptor > --- > > Key: HBASE-15456 > URL: https://issues.apache.org/jira/browse/HBASE-15456 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15456-001_branch-1.patch, > HBASE-15456-branch-1.patch, HBASE-15456-branch-1.patch, > HBASE-15456-branch-1_v002.patch, HBASE-15456-v001.patch, > HBASE-15456-v002.patch, HBASE-15456-v002.patch, HBASE-15456-v003.patch, > HBASE-15456-v004.patch > > > If there is only one family in the table, DeleteColumnFamilyProcedure will > fail. > Currently, when hbase.table.sanity.checks is set to false, hbase master logs > a warning and CreateTableProcedure/ModifyTableProcedure will succeed. > This behavior is not consistent with DeleteColumnFamilyProcedure's. > Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the > following exception. lastStoreFlushTimeMap is populated for families, if > there is no family in the table, there is no entry in lastStoreFlushTimeMap. > {code} > 16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: > Caught exception > java.util.NoSuchElementException > at > java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) > > at > java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) > > at java.util.Collections.min(Collections.java:628) > at > org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) > > at > org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) > at > org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) > > at org.apache.hadoop.hbase.Chore.run(Chore.java:87) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15456) CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200793#comment-15200793 ] huaxiang sun commented on HBASE-15456: -- [~te...@apache.org] I am looking at this. I thought I run the whole unittest job, but it seems not. Sorry about it. > CreateTableProcedure/ModifyTableProcedure needs to fail when there is no > family in table descriptor > --- > > Key: HBASE-15456 > URL: https://issues.apache.org/jira/browse/HBASE-15456 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15456-001_branch-1.patch, > HBASE-15456-branch-1.patch, HBASE-15456-branch-1.patch, > HBASE-15456-v001.patch, HBASE-15456-v002.patch, HBASE-15456-v002.patch, > HBASE-15456-v003.patch > > > If there is only one family in the table, DeleteColumnFamilyProcedure will > fail. > Currently, when hbase.table.sanity.checks is set to false, hbase master logs > a warning and CreateTableProcedure/ModifyTableProcedure will succeed. > This behavior is not consistent with DeleteColumnFamilyProcedure's. > Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the > following exception. lastStoreFlushTimeMap is populated for families, if > there is no family in the table, there is no entry in lastStoreFlushTimeMap. > {code} > 16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: > Caught exception > java.util.NoSuchElementException > at > java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) > > at > java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) > > at java.util.Collections.min(Collections.java:628) > at > org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) > > at > org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) > at > org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) > > at org.apache.hadoop.hbase.Chore.run(Chore.java:87) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15456) CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199810#comment-15199810 ] huaxiang sun commented on HBASE-15456: -- Thanks [~te...@apache.org], I will rename the patch and reattach. > CreateTableProcedure/ModifyTableProcedure needs to fail when there is no > family in table descriptor > --- > > Key: HBASE-15456 > URL: https://issues.apache.org/jira/browse/HBASE-15456 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15456-001_branch-1.patch, HBASE-15456-v001.patch, > HBASE-15456-v002.patch, HBASE-15456-v002.patch, HBASE-15456-v003.patch > > > If there is only one family in the table, DeleteColumnFamilyProcedure will > fail. > Currently, when hbase.table.sanity.checks is set to false, hbase master logs > a warning and CreateTableProcedure/ModifyTableProcedure will succeed. > This behavior is not consistent with DeleteColumnFamilyProcedure's. > Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the > following exception. lastStoreFlushTimeMap is populated for families, if > there is no family in the table, there is no entry in lastStoreFlushTimeMap. > {code} > 16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: > Caught exception > java.util.NoSuchElementException > at > java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) > > at > java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) > > at java.util.Collections.min(Collections.java:628) > at > org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) > > at > org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) > at > org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) > > at org.apache.hadoop.hbase.Chore.run(Chore.java:87) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15456) CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198676#comment-15198676 ] Ted Yu commented on HBASE-15456: I think the patch should be named HBASE-15456-branch-1.patch for QA bot to pick up. > CreateTableProcedure/ModifyTableProcedure needs to fail when there is no > family in table descriptor > --- > > Key: HBASE-15456 > URL: https://issues.apache.org/jira/browse/HBASE-15456 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15456-001_branch-1.patch, HBASE-15456-v001.patch, > HBASE-15456-v002.patch, HBASE-15456-v002.patch, HBASE-15456-v003.patch > > > If there is only one family in the table, DeleteColumnFamilyProcedure will > fail. > Currently, when hbase.table.sanity.checks is set to false, hbase master logs > a warning and CreateTableProcedure/ModifyTableProcedure will succeed. > This behavior is not consistent with DeleteColumnFamilyProcedure's. > Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the > following exception. lastStoreFlushTimeMap is populated for families, if > there is no family in the table, there is no entry in lastStoreFlushTimeMap. > {code} > 16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: > Caught exception > java.util.NoSuchElementException > at > java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) > > at > java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) > > at java.util.Collections.min(Collections.java:628) > at > org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) > > at > org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) > at > org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) > > at org.apache.hadoop.hbase.Chore.run(Chore.java:87) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15456) CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200654#comment-15200654 ] Hudson commented on HBASE-15456: FAILURE: Integrated in HBase-1.3 #608 (See [https://builds.apache.org/job/HBase-1.3/608/]) HBASE-15456 CreateTableProcedure/ModifyTableProcedure needs to fail when (tedyu: rev 9cab7b53c0549d4a513b178b3008504fc99a7542) * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestCloseRegionHandler.java * hbase-server/src/test/java/org/apache/hadoop/hbase/namespace/TestNamespaceAuditor.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestOpenedRegionHandler.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CreateTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestOpenRegionHandler.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestCreateTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestModifyTableProcedure.java > CreateTableProcedure/ModifyTableProcedure needs to fail when there is no > family in table descriptor > --- > > Key: HBASE-15456 > URL: https://issues.apache.org/jira/browse/HBASE-15456 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15456-001_branch-1.patch, > HBASE-15456-branch-1.patch, HBASE-15456-branch-1.patch, > HBASE-15456-v001.patch, HBASE-15456-v002.patch, HBASE-15456-v002.patch, > HBASE-15456-v003.patch > > > If there is only one family in the table, DeleteColumnFamilyProcedure will > fail. > Currently, when hbase.table.sanity.checks is set to false, hbase master logs > a warning and CreateTableProcedure/ModifyTableProcedure will succeed. > This behavior is not consistent with DeleteColumnFamilyProcedure's. > Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the > following exception. lastStoreFlushTimeMap is populated for families, if > there is no family in the table, there is no entry in lastStoreFlushTimeMap. > {code} > 16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: > Caught exception > java.util.NoSuchElementException > at > java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) > > at > java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) > > at java.util.Collections.min(Collections.java:628) > at > org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) > > at > org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) > at > org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) > > at org.apache.hadoop.hbase.Chore.run(Chore.java:87) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15456) CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197380#comment-15197380 ] Hudson commented on HBASE-15456: FAILURE: Integrated in HBase-1.3 #603 (See [https://builds.apache.org/job/HBase-1.3/603/]) HBASE-15456 Revert due to TestCloseRegionHandler failure (tedyu: rev 94239759e89fb3b7be2c087b640ce20bff259606) * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestCreateTableProcedure.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CreateTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestModifyTableProcedure.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/namespace/TestNamespaceAuditor.java > CreateTableProcedure/ModifyTableProcedure needs to fail when there is no > family in table descriptor > --- > > Key: HBASE-15456 > URL: https://issues.apache.org/jira/browse/HBASE-15456 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15456-v001.patch, HBASE-15456-v002.patch, > HBASE-15456-v002.patch, HBASE-15456-v003.patch > > > If there is only one family in the table, DeleteColumnFamilyProcedure will > fail. > Currently, when hbase.table.sanity.checks is set to false, hbase master logs > a warning and CreateTableProcedure/ModifyTableProcedure will succeed. > This behavior is not consistent with DeleteColumnFamilyProcedure's. > Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the > following exception. lastStoreFlushTimeMap is populated for families, if > there is no family in the table, there is no entry in lastStoreFlushTimeMap. > {code} > 16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: > Caught exception > java.util.NoSuchElementException > at > java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) > > at > java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) > > at java.util.Collections.min(Collections.java:628) > at > org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) > > at > org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) > at > org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) > > at org.apache.hadoop.hbase.Chore.run(Chore.java:87) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15456) CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201082#comment-15201082 ] Hudson commented on HBASE-15456: FAILURE: Integrated in HBase-1.4 #28 (See [https://builds.apache.org/job/HBase-1.4/28/]) HBASE-15456 Revert due to unit test failure in thrift module (tedyu: rev a3199414252694296a01018ec4e89316f8763daf) * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestOpenRegionHandler.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestCloseRegionHandler.java * hbase-server/src/test/java/org/apache/hadoop/hbase/namespace/TestNamespaceAuditor.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestOpenedRegionHandler.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CreateTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestModifyTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestCreateTableProcedure.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > CreateTableProcedure/ModifyTableProcedure needs to fail when there is no > family in table descriptor > --- > > Key: HBASE-15456 > URL: https://issues.apache.org/jira/browse/HBASE-15456 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15456-001_branch-1.patch, > HBASE-15456-branch-1.patch, HBASE-15456-branch-1.patch, > HBASE-15456-branch-1_v002.patch, HBASE-15456-v001.patch, > HBASE-15456-v002.patch, HBASE-15456-v002.patch, HBASE-15456-v003.patch, > HBASE-15456-v004.patch > > > If there is only one family in the table, DeleteColumnFamilyProcedure will > fail. > Currently, when hbase.table.sanity.checks is set to false, hbase master logs > a warning and CreateTableProcedure/ModifyTableProcedure will succeed. > This behavior is not consistent with DeleteColumnFamilyProcedure's. > Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the > following exception. lastStoreFlushTimeMap is populated for families, if > there is no family in the table, there is no entry in lastStoreFlushTimeMap. > {code} > 16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: > Caught exception > java.util.NoSuchElementException > at > java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) > > at > java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) > > at java.util.Collections.min(Collections.java:628) > at > org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) > > at > org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) > at > org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) > > at org.apache.hadoop.hbase.Chore.run(Chore.java:87) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15456) CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200426#comment-15200426 ] huaxiang sun commented on HBASE-15456: -- [~te...@apache.org] thanks for the review and commit. > CreateTableProcedure/ModifyTableProcedure needs to fail when there is no > family in table descriptor > --- > > Key: HBASE-15456 > URL: https://issues.apache.org/jira/browse/HBASE-15456 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15456-001_branch-1.patch, > HBASE-15456-branch-1.patch, HBASE-15456-branch-1.patch, > HBASE-15456-v001.patch, HBASE-15456-v002.patch, HBASE-15456-v002.patch, > HBASE-15456-v003.patch > > > If there is only one family in the table, DeleteColumnFamilyProcedure will > fail. > Currently, when hbase.table.sanity.checks is set to false, hbase master logs > a warning and CreateTableProcedure/ModifyTableProcedure will succeed. > This behavior is not consistent with DeleteColumnFamilyProcedure's. > Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the > following exception. lastStoreFlushTimeMap is populated for families, if > there is no family in the table, there is no entry in lastStoreFlushTimeMap. > {code} > 16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: > Caught exception > java.util.NoSuchElementException > at > java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) > > at > java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) > > at java.util.Collections.min(Collections.java:628) > at > org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) > > at > org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) > at > org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) > > at org.apache.hadoop.hbase.Chore.run(Chore.java:87) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15456) CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197556#comment-15197556 ] Hudson commented on HBASE-15456: SUCCESS: Integrated in HBase-1.4 #21 (See [https://builds.apache.org/job/HBase-1.4/21/]) HBASE-15456 Revert due to TestCloseRegionHandler failure (tedyu: rev a00ed93faef7ce10bfd84f7e436c8a7912ce3725) * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestCreateTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/namespace/TestNamespaceAuditor.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CreateTableProcedure.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestModifyTableProcedure.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java > CreateTableProcedure/ModifyTableProcedure needs to fail when there is no > family in table descriptor > --- > > Key: HBASE-15456 > URL: https://issues.apache.org/jira/browse/HBASE-15456 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15456-v001.patch, HBASE-15456-v002.patch, > HBASE-15456-v002.patch, HBASE-15456-v003.patch > > > If there is only one family in the table, DeleteColumnFamilyProcedure will > fail. > Currently, when hbase.table.sanity.checks is set to false, hbase master logs > a warning and CreateTableProcedure/ModifyTableProcedure will succeed. > This behavior is not consistent with DeleteColumnFamilyProcedure's. > Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the > following exception. lastStoreFlushTimeMap is populated for families, if > there is no family in the table, there is no entry in lastStoreFlushTimeMap. > {code} > 16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: > Caught exception > java.util.NoSuchElementException > at > java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) > > at > java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) > > at java.util.Collections.min(Collections.java:628) > at > org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) > > at > org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) > at > org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) > > at org.apache.hadoop.hbase.Chore.run(Chore.java:87) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15456) CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200963#comment-15200963 ] Hudson commented on HBASE-15456: FAILURE: Integrated in HBase-1.3-IT #561 (See [https://builds.apache.org/job/HBase-1.3-IT/561/]) HBASE-15456 Revert due to unit test failure in thrift module (tedyu: rev a3199414252694296a01018ec4e89316f8763daf) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestModifyTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestCreateTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestOpenedRegionHandler.java * hbase-server/src/test/java/org/apache/hadoop/hbase/namespace/TestNamespaceAuditor.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestCloseRegionHandler.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CreateTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestOpenRegionHandler.java > CreateTableProcedure/ModifyTableProcedure needs to fail when there is no > family in table descriptor > --- > > Key: HBASE-15456 > URL: https://issues.apache.org/jira/browse/HBASE-15456 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15456-001_branch-1.patch, > HBASE-15456-branch-1.patch, HBASE-15456-branch-1.patch, > HBASE-15456-v001.patch, HBASE-15456-v002.patch, HBASE-15456-v002.patch, > HBASE-15456-v003.patch > > > If there is only one family in the table, DeleteColumnFamilyProcedure will > fail. > Currently, when hbase.table.sanity.checks is set to false, hbase master logs > a warning and CreateTableProcedure/ModifyTableProcedure will succeed. > This behavior is not consistent with DeleteColumnFamilyProcedure's. > Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the > following exception. lastStoreFlushTimeMap is populated for families, if > there is no family in the table, there is no entry in lastStoreFlushTimeMap. > {code} > 16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: > Caught exception > java.util.NoSuchElementException > at > java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) > > at > java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) > > at java.util.Collections.min(Collections.java:628) > at > org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) > > at > org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) > at > org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) > > at org.apache.hadoop.hbase.Chore.run(Chore.java:87) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15456) CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202485#comment-15202485 ] Hudson commented on HBASE-15456: SUCCESS: Integrated in HBase-1.3 #610 (See [https://builds.apache.org/job/HBase-1.3/610/]) HBASE-15456 CreateTableProcedure/ModifyTableProcedure needs to fail when (tedyu: rev ce00fc1bcfd23c4b3cacb25bf0dc74f55ac6f27d) * hbase-server/src/test/java/org/apache/hadoop/hbase/namespace/TestNamespaceAuditor.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java * hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestOpenedRegionHandler.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestModifyTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestOpenRegionHandler.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestCreateTableProcedure.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CreateTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestCloseRegionHandler.java > CreateTableProcedure/ModifyTableProcedure needs to fail when there is no > family in table descriptor > --- > > Key: HBASE-15456 > URL: https://issues.apache.org/jira/browse/HBASE-15456 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15456-001_branch-1.patch, > HBASE-15456-branch-1.patch, HBASE-15456-branch-1.patch, > HBASE-15456-branch-1_v002.patch, HBASE-15456-v001.patch, > HBASE-15456-v002.patch, HBASE-15456-v002.patch, HBASE-15456-v003.patch, > HBASE-15456-v004.patch > > > If there is only one family in the table, DeleteColumnFamilyProcedure will > fail. > Currently, when hbase.table.sanity.checks is set to false, hbase master logs > a warning and CreateTableProcedure/ModifyTableProcedure will succeed. > This behavior is not consistent with DeleteColumnFamilyProcedure's. > Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the > following exception. lastStoreFlushTimeMap is populated for families, if > there is no family in the table, there is no entry in lastStoreFlushTimeMap. > {code} > 16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: > Caught exception > java.util.NoSuchElementException > at > java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) > > at > java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) > > at java.util.Collections.min(Collections.java:628) > at > org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) > > at > org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) > at > org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) > > at org.apache.hadoop.hbase.Chore.run(Chore.java:87) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15456) CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199101#comment-15199101 ] Hadoop QA commented on HBASE-15456: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s {color} | {color:red} HBASE-15456 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.2.0/precommit-patchnames for help. {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12793852/HBASE-15456-001_branch-1.patch | | JIRA Issue | HBASE-15456 | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/1041/console | | Powered by | Apache Yetus 0.2.0 http://yetus.apache.org | This message was automatically generated. > CreateTableProcedure/ModifyTableProcedure needs to fail when there is no > family in table descriptor > --- > > Key: HBASE-15456 > URL: https://issues.apache.org/jira/browse/HBASE-15456 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15456-001_branch-1.patch, HBASE-15456-v001.patch, > HBASE-15456-v002.patch, HBASE-15456-v002.patch, HBASE-15456-v003.patch > > > If there is only one family in the table, DeleteColumnFamilyProcedure will > fail. > Currently, when hbase.table.sanity.checks is set to false, hbase master logs > a warning and CreateTableProcedure/ModifyTableProcedure will succeed. > This behavior is not consistent with DeleteColumnFamilyProcedure's. > Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the > following exception. lastStoreFlushTimeMap is populated for families, if > there is no family in the table, there is no entry in lastStoreFlushTimeMap. > {code} > 16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: > Caught exception > java.util.NoSuchElementException > at > java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) > > at > java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) > > at java.util.Collections.min(Collections.java:628) > at > org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) > > at > org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) > at > org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) > > at org.apache.hadoop.hbase.Chore.run(Chore.java:87) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15456) CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200934#comment-15200934 ] Hudson commented on HBASE-15456: FAILURE: Integrated in HBase-1.4 #27 (See [https://builds.apache.org/job/HBase-1.4/27/]) HBASE-15456 CreateTableProcedure/ModifyTableProcedure needs to fail when (tedyu: rev e4409c2f8c82f1b061f4dce2eb342c61999bf2e3) * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestModifyTableProcedure.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestOpenRegionHandler.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestCloseRegionHandler.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestCreateTableProcedure.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/namespace/TestNamespaceAuditor.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestOpenedRegionHandler.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CreateTableProcedure.java > CreateTableProcedure/ModifyTableProcedure needs to fail when there is no > family in table descriptor > --- > > Key: HBASE-15456 > URL: https://issues.apache.org/jira/browse/HBASE-15456 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15456-001_branch-1.patch, > HBASE-15456-branch-1.patch, HBASE-15456-branch-1.patch, > HBASE-15456-v001.patch, HBASE-15456-v002.patch, HBASE-15456-v002.patch, > HBASE-15456-v003.patch > > > If there is only one family in the table, DeleteColumnFamilyProcedure will > fail. > Currently, when hbase.table.sanity.checks is set to false, hbase master logs > a warning and CreateTableProcedure/ModifyTableProcedure will succeed. > This behavior is not consistent with DeleteColumnFamilyProcedure's. > Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the > following exception. lastStoreFlushTimeMap is populated for families, if > there is no family in the table, there is no entry in lastStoreFlushTimeMap. > {code} > 16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: > Caught exception > java.util.NoSuchElementException > at > java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) > > at > java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) > > at java.util.Collections.min(Collections.java:628) > at > org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) > > at > org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) > at > org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) > > at org.apache.hadoop.hbase.Chore.run(Chore.java:87) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15456) CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200995#comment-15200995 ] Hudson commented on HBASE-15456: FAILURE: Integrated in HBase-Trunk_matrix #787 (See [https://builds.apache.org/job/HBase-Trunk_matrix/787/]) HBASE-15456 Revert due to unit test failure in thrift module (tedyu: rev 8c031e9d6b39d9e385bc545215efc73a3cd6d199) * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestCreateTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/namespace/TestNamespaceAuditor.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestModifyTableProcedure.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CreateTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestRegionMover.java > CreateTableProcedure/ModifyTableProcedure needs to fail when there is no > family in table descriptor > --- > > Key: HBASE-15456 > URL: https://issues.apache.org/jira/browse/HBASE-15456 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15456-001_branch-1.patch, > HBASE-15456-branch-1.patch, HBASE-15456-branch-1.patch, > HBASE-15456-v001.patch, HBASE-15456-v002.patch, HBASE-15456-v002.patch, > HBASE-15456-v003.patch > > > If there is only one family in the table, DeleteColumnFamilyProcedure will > fail. > Currently, when hbase.table.sanity.checks is set to false, hbase master logs > a warning and CreateTableProcedure/ModifyTableProcedure will succeed. > This behavior is not consistent with DeleteColumnFamilyProcedure's. > Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the > following exception. lastStoreFlushTimeMap is populated for families, if > there is no family in the table, there is no entry in lastStoreFlushTimeMap. > {code} > 16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: > Caught exception > java.util.NoSuchElementException > at > java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) > > at > java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) > > at java.util.Collections.min(Collections.java:628) > at > org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) > > at > org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) > at > org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) > > at org.apache.hadoop.hbase.Chore.run(Chore.java:87) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15456) CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200165#comment-15200165 ] Hadoop QA commented on HBASE-15456: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s {color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 6 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 39s {color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 45s {color} | {color:green} branch-1 passed with JDK v1.8.0 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 31s {color} | {color:green} branch-1 passed with JDK v1.7.0_79 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 22s {color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 18s {color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 48s {color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 31s {color} | {color:green} branch-1 passed with JDK v1.8.0 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 34s {color} | {color:green} branch-1 passed with JDK v1.7.0_79 {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 42s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 36s {color} | {color:green} the patch passed with JDK v1.8.0 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 36s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 30s {color} | {color:green} the patch passed with JDK v1.7.0_79 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 30s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 19s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 13s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 1s {color} | {color:green} Patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 12m 7s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 8s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 26s {color} | {color:green} the patch passed with JDK v1.8.0 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 31s {color} | {color:green} the patch passed with JDK v1.7.0_79 {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 110m 50s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 18s {color} | {color:green} Patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 138m 35s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.regionserver.throttle.TestFlushWithThroughputController | \\ \\ || Subsystem || Report/Notes || | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12794008/HBASE-15456-branch-1.patch | | JIRA Issue | HBASE-15456 | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux proserpina.apache.org 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | branch-1 / a317a0f | | Default Java | 1.7.0_79 | | Multi-JDK versions | /home/jenkins/tools/java/jdk1.8.0:1.8.0 /usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79 | |
[jira] [Commented] (HBASE-15456) CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201085#comment-15201085 ] huaxiang sun commented on HBASE-15456: -- [~te...@apache.org] I addressed the thrift unittest failures with the latest patches and got green runs for both master and branch-l locally. Please let me know if this is ok. Sorry for the trouble and will get green runs for future efforts, thanks. > CreateTableProcedure/ModifyTableProcedure needs to fail when there is no > family in table descriptor > --- > > Key: HBASE-15456 > URL: https://issues.apache.org/jira/browse/HBASE-15456 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15456-001_branch-1.patch, > HBASE-15456-branch-1.patch, HBASE-15456-branch-1.patch, > HBASE-15456-branch-1_v002.patch, HBASE-15456-v001.patch, > HBASE-15456-v002.patch, HBASE-15456-v002.patch, HBASE-15456-v003.patch, > HBASE-15456-v004.patch > > > If there is only one family in the table, DeleteColumnFamilyProcedure will > fail. > Currently, when hbase.table.sanity.checks is set to false, hbase master logs > a warning and CreateTableProcedure/ModifyTableProcedure will succeed. > This behavior is not consistent with DeleteColumnFamilyProcedure's. > Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the > following exception. lastStoreFlushTimeMap is populated for families, if > there is no family in the table, there is no entry in lastStoreFlushTimeMap. > {code} > 16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: > Caught exception > java.util.NoSuchElementException > at > java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) > > at > java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) > > at java.util.Collections.min(Collections.java:628) > at > org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) > > at > org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) > at > org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) > > at org.apache.hadoop.hbase.Chore.run(Chore.java:87) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15456) CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201688#comment-15201688 ] Hudson commented on HBASE-15456: SUCCESS: Integrated in HBase-1.3-IT #562 (See [https://builds.apache.org/job/HBase-1.3-IT/562/]) HBASE-15456 CreateTableProcedure/ModifyTableProcedure needs to fail when (tedyu: rev eda2656b88edc829d4d520ea5fc39cf73aca270f) * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestOpenRegionHandler.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestCloseRegionHandler.java * hbase-server/src/test/java/org/apache/hadoop/hbase/namespace/TestNamespaceAuditor.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestOpenedRegionHandler.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestCreateTableProcedure.java * hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestModifyTableProcedure.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CreateTableProcedure.java > CreateTableProcedure/ModifyTableProcedure needs to fail when there is no > family in table descriptor > --- > > Key: HBASE-15456 > URL: https://issues.apache.org/jira/browse/HBASE-15456 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15456-001_branch-1.patch, > HBASE-15456-branch-1.patch, HBASE-15456-branch-1.patch, > HBASE-15456-branch-1_v002.patch, HBASE-15456-v001.patch, > HBASE-15456-v002.patch, HBASE-15456-v002.patch, HBASE-15456-v003.patch, > HBASE-15456-v004.patch > > > If there is only one family in the table, DeleteColumnFamilyProcedure will > fail. > Currently, when hbase.table.sanity.checks is set to false, hbase master logs > a warning and CreateTableProcedure/ModifyTableProcedure will succeed. > This behavior is not consistent with DeleteColumnFamilyProcedure's. > Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the > following exception. lastStoreFlushTimeMap is populated for families, if > there is no family in the table, there is no entry in lastStoreFlushTimeMap. > {code} > 16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: > Caught exception > java.util.NoSuchElementException > at > java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) > > at > java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) > > at java.util.Collections.min(Collections.java:628) > at > org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) > > at > org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) > at > org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) > > at org.apache.hadoop.hbase.Chore.run(Chore.java:87) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15456) CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198196#comment-15198196 ] huaxiang sun commented on HBASE-15456: -- For branch-1 patch, the new change is to address the unittest failures listed as follows, due to open a region without any column family. org.apache.hadoop.hbase.master.TestOpenedRegionHandler.testShouldNotCompeleteOpenedRegionSuccessfullyIfVersionMismatches org.apache.hadoop.hbase.regionserver.handler.TestOpenRegionHandler.testRegionServerAbortionDueToFailureTransitioningToOpened org.apache.hadoop.hbase.regionserver.handler.TestOpenRegionHandler.testYankingRegionFromUnderIt org.apache.hadoop.hbase.regionserver.handler.TestCloseRegionHandler > CreateTableProcedure/ModifyTableProcedure needs to fail when there is no > family in table descriptor > --- > > Key: HBASE-15456 > URL: https://issues.apache.org/jira/browse/HBASE-15456 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15456-001_branch-1.patch, HBASE-15456-v001.patch, > HBASE-15456-v002.patch, HBASE-15456-v002.patch, HBASE-15456-v003.patch > > > If there is only one family in the table, DeleteColumnFamilyProcedure will > fail. > Currently, when hbase.table.sanity.checks is set to false, hbase master logs > a warning and CreateTableProcedure/ModifyTableProcedure will succeed. > This behavior is not consistent with DeleteColumnFamilyProcedure's. > Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the > following exception. lastStoreFlushTimeMap is populated for families, if > there is no family in the table, there is no entry in lastStoreFlushTimeMap. > {code} > 16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: > Caught exception > java.util.NoSuchElementException > at > java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) > > at > java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) > > at java.util.Collections.min(Collections.java:628) > at > org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) > > at > org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) > at > org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) > > at org.apache.hadoop.hbase.Chore.run(Chore.java:87) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15456) CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196947#comment-15196947 ] Hudson commented on HBASE-15456: SUCCESS: Integrated in HBase-1.3-IT #555 (See [https://builds.apache.org/job/HBase-1.3-IT/555/]) HBASE-15456 Revert due to TestCloseRegionHandler failure (tedyu: rev a00ed93faef7ce10bfd84f7e436c8a7912ce3725) * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CreateTableProcedure.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestCreateTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/namespace/TestNamespaceAuditor.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestModifyTableProcedure.java > CreateTableProcedure/ModifyTableProcedure needs to fail when there is no > family in table descriptor > --- > > Key: HBASE-15456 > URL: https://issues.apache.org/jira/browse/HBASE-15456 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15456-v001.patch, HBASE-15456-v002.patch, > HBASE-15456-v002.patch, HBASE-15456-v003.patch > > > If there is only one family in the table, DeleteColumnFamilyProcedure will > fail. > Currently, when hbase.table.sanity.checks is set to false, hbase master logs > a warning and CreateTableProcedure/ModifyTableProcedure will succeed. > This behavior is not consistent with DeleteColumnFamilyProcedure's. > Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the > following exception. lastStoreFlushTimeMap is populated for families, if > there is no family in the table, there is no entry in lastStoreFlushTimeMap. > {code} > 16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: > Caught exception > java.util.NoSuchElementException > at > java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) > > at > java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) > > at java.util.Collections.min(Collections.java:628) > at > org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) > > at > org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) > at > org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) > > at org.apache.hadoop.hbase.Chore.run(Chore.java:87) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15456) CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196833#comment-15196833 ] huaxiang sun commented on HBASE-15456: -- Thanks [~ted_yu] and the others for the review and commit. I will work on a patch for branch-1 tomorrow. > CreateTableProcedure/ModifyTableProcedure needs to fail when there is no > family in table descriptor > --- > > Key: HBASE-15456 > URL: https://issues.apache.org/jira/browse/HBASE-15456 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15456-v001.patch, HBASE-15456-v002.patch, > HBASE-15456-v002.patch, HBASE-15456-v003.patch > > > If there is only one family in the table, DeleteColumnFamilyProcedure will > fail. > Currently, when hbase.table.sanity.checks is set to false, hbase master logs > a warning and CreateTableProcedure/ModifyTableProcedure will succeed. > This behavior is not consistent with DeleteColumnFamilyProcedure's. > Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the > following exception. lastStoreFlushTimeMap is populated for families, if > there is no family in the table, there is no entry in lastStoreFlushTimeMap. > {code} > 16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: > Caught exception > java.util.NoSuchElementException > at > java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) > > at > java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) > > at java.util.Collections.min(Collections.java:628) > at > org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) > > at > org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) > at > org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) > > at org.apache.hadoop.hbase.Chore.run(Chore.java:87) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15456) CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196790#comment-15196790 ] Hudson commented on HBASE-15456: FAILURE: Integrated in HBase-Trunk_matrix #780 (See [https://builds.apache.org/job/HBase-Trunk_matrix/780/]) HBASE-15456 CreateTableProcedure/ModifyTableProcedure needs to fail when (tedyu: rev f120602f1e3ac2260bce9d7925f01e79bbf0f6df) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestCreateTableProcedure.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CreateTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestRegionMover.java * hbase-server/src/test/java/org/apache/hadoop/hbase/namespace/TestNamespaceAuditor.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestModifyTableProcedure.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java > CreateTableProcedure/ModifyTableProcedure needs to fail when there is no > family in table descriptor > --- > > Key: HBASE-15456 > URL: https://issues.apache.org/jira/browse/HBASE-15456 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15456-v001.patch, HBASE-15456-v002.patch, > HBASE-15456-v002.patch, HBASE-15456-v003.patch > > > If there is only one family in the table, DeleteColumnFamilyProcedure will > fail. > Currently, when hbase.table.sanity.checks is set to false, hbase master logs > a warning and CreateTableProcedure/ModifyTableProcedure will succeed. > This behavior is not consistent with DeleteColumnFamilyProcedure's. > Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the > following exception. lastStoreFlushTimeMap is populated for families, if > there is no family in the table, there is no entry in lastStoreFlushTimeMap. > {code} > 16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: > Caught exception > java.util.NoSuchElementException > at > java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) > > at > java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) > > at java.util.Collections.min(Collections.java:628) > at > org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) > > at > org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) > at > org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) > > at org.apache.hadoop.hbase.Chore.run(Chore.java:87) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15456) CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196748#comment-15196748 ] Hudson commented on HBASE-15456: SUCCESS: Integrated in HBase-1.3-IT #554 (See [https://builds.apache.org/job/HBase-1.3-IT/554/]) HBASE-15456 CreateTableProcedure/ModifyTableProcedure needs to fail when (tedyu: rev f8bcb5447923ed1cd93087b3b4f4d4b3240a928b) * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestModifyTableProcedure.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CreateTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/namespace/TestNamespaceAuditor.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestCreateTableProcedure.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java > CreateTableProcedure/ModifyTableProcedure needs to fail when there is no > family in table descriptor > --- > > Key: HBASE-15456 > URL: https://issues.apache.org/jira/browse/HBASE-15456 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15456-v001.patch, HBASE-15456-v002.patch, > HBASE-15456-v002.patch, HBASE-15456-v003.patch > > > If there is only one family in the table, DeleteColumnFamilyProcedure will > fail. > Currently, when hbase.table.sanity.checks is set to false, hbase master logs > a warning and CreateTableProcedure/ModifyTableProcedure will succeed. > This behavior is not consistent with DeleteColumnFamilyProcedure's. > Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the > following exception. lastStoreFlushTimeMap is populated for families, if > there is no family in the table, there is no entry in lastStoreFlushTimeMap. > {code} > 16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: > Caught exception > java.util.NoSuchElementException > at > java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) > > at > java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) > > at java.util.Collections.min(Collections.java:628) > at > org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) > > at > org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) > at > org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) > > at org.apache.hadoop.hbase.Chore.run(Chore.java:87) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15456) CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196741#comment-15196741 ] Ted Yu commented on HBASE-15456: [~huaxiang]: Can you attach patch for branch-1 ? Thanks > CreateTableProcedure/ModifyTableProcedure needs to fail when there is no > family in table descriptor > --- > > Key: HBASE-15456 > URL: https://issues.apache.org/jira/browse/HBASE-15456 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15456-v001.patch, HBASE-15456-v002.patch, > HBASE-15456-v002.patch, HBASE-15456-v003.patch > > > If there is only one family in the table, DeleteColumnFamilyProcedure will > fail. > Currently, when hbase.table.sanity.checks is set to false, hbase master logs > a warning and CreateTableProcedure/ModifyTableProcedure will succeed. > This behavior is not consistent with DeleteColumnFamilyProcedure's. > Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the > following exception. lastStoreFlushTimeMap is populated for families, if > there is no family in the table, there is no entry in lastStoreFlushTimeMap. > {code} > 16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: > Caught exception > java.util.NoSuchElementException > at > java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) > > at > java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) > > at java.util.Collections.min(Collections.java:628) > at > org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) > > at > org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) > at > org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) > > at org.apache.hadoop.hbase.Chore.run(Chore.java:87) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15456) CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196725#comment-15196725 ] Hudson commented on HBASE-15456: FAILURE: Integrated in HBase-1.3 #602 (See [https://builds.apache.org/job/HBase-1.3/602/]) HBASE-15456 CreateTableProcedure/ModifyTableProcedure needs to fail when (tedyu: rev 1d565e6e936b8c215098dd039ec8e9df5f4a7b6d) * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestCreateTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/namespace/TestNamespaceAuditor.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CreateTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestModifyTableProcedure.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > CreateTableProcedure/ModifyTableProcedure needs to fail when there is no > family in table descriptor > --- > > Key: HBASE-15456 > URL: https://issues.apache.org/jira/browse/HBASE-15456 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15456-v001.patch, HBASE-15456-v002.patch, > HBASE-15456-v002.patch, HBASE-15456-v003.patch > > > If there is only one family in the table, DeleteColumnFamilyProcedure will > fail. > Currently, when hbase.table.sanity.checks is set to false, hbase master logs > a warning and CreateTableProcedure/ModifyTableProcedure will succeed. > This behavior is not consistent with DeleteColumnFamilyProcedure's. > Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the > following exception. lastStoreFlushTimeMap is populated for families, if > there is no family in the table, there is no entry in lastStoreFlushTimeMap. > {code} > 16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: > Caught exception > java.util.NoSuchElementException > at > java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) > > at > java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) > > at java.util.Collections.min(Collections.java:628) > at > org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) > > at > org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) > at > org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) > > at org.apache.hadoop.hbase.Chore.run(Chore.java:87) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15456) CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196715#comment-15196715 ] Hudson commented on HBASE-15456: FAILURE: Integrated in HBase-1.4 #19 (See [https://builds.apache.org/job/HBase-1.4/19/]) HBASE-15456 CreateTableProcedure/ModifyTableProcedure needs to fail when (tedyu: rev f8bcb5447923ed1cd93087b3b4f4d4b3240a928b) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestModifyTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestCreateTableProcedure.java * hbase-server/src/test/java/org/apache/hadoop/hbase/namespace/TestNamespaceAuditor.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CreateTableProcedure.java > CreateTableProcedure/ModifyTableProcedure needs to fail when there is no > family in table descriptor > --- > > Key: HBASE-15456 > URL: https://issues.apache.org/jira/browse/HBASE-15456 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 2.0.0 >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15456-v001.patch, HBASE-15456-v002.patch, > HBASE-15456-v002.patch, HBASE-15456-v003.patch > > > If there is only one family in the table, DeleteColumnFamilyProcedure will > fail. > Currently, when hbase.table.sanity.checks is set to false, hbase master logs > a warning and CreateTableProcedure/ModifyTableProcedure will succeed. > This behavior is not consistent with DeleteColumnFamilyProcedure's. > Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the > following exception. lastStoreFlushTimeMap is populated for families, if > there is no family in the table, there is no entry in lastStoreFlushTimeMap. > {code} > 16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: > Caught exception > java.util.NoSuchElementException > at > java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) > > at > java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) > > at java.util.Collections.min(Collections.java:628) > at > org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) > > at > org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) > at > org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) > > at org.apache.hadoop.hbase.Chore.run(Chore.java:87) > at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15456) CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
[ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196598#comment-15196598 ] Hadoop QA commented on HBASE-15456: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s {color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 4 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 24s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 26s {color} | {color:green} master passed with JDK v1.8.0 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 5s {color} | {color:green} master passed with JDK v1.7.0_79 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 7m 10s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 35s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 46s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 1s {color} | {color:green} master passed with JDK v1.8.0 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 17s {color} | {color:green} master passed with JDK v1.7.0_79 {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 24s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 27s {color} | {color:green} the patch passed with JDK v1.8.0 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 27s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 33s {color} | {color:green} the patch passed with JDK v1.7.0_79 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 33s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 7m 51s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 28s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} Patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 46m 53s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 10s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 8s {color} | {color:green} the patch passed with JDK v1.8.0 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 15s {color} | {color:green} the patch passed with JDK v1.7.0_79 {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 105m 3s {color} | {color:red} hbase-server in the patch failed with JDK v1.8.0. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 125m 23s {color} | {color:red} hbase-server in the patch failed with JDK v1.7.0_79. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 18s {color} | {color:green} Patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 319m 25s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | JDK v1.8.0 Timed out junit tests | org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure | | | org.apache.hadoop.hbase.regionserver.TestCorruptedRegionStoreFile | | | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId | | | org.apache.hadoop.hbase.regionserver.TestCompaction | | | org.apache.hadoop.hbase.snapshot.TestSnapshotClientRetries | | | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 | | | org.apache.hadoop.hbase.master.TestMasterFailover | | | org.apache.hadoop.hbase.master.TestGetInfoPort | | | org.apache.hadoop.hbase.master.TestMasterFailoverBalancerPersistence | | |