[jira] [Commented] (HBASE-15497) Incorrect javadoc for atomicity guarantee of Increment and Append
[
https://issues.apache.org/jira/browse/HBASE-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152528#comment-16152528
]
Hudson commented on HBASE-15497:
FAILURE: Integrated in Jenkins build HBase-2.0 #453 (See
[https://builds.apache.org/job/HBase-2.0/453/])
HBASE-15497 Incorrect javadoc for atomicity guarantee of Increment and
(chia7712: rev a1efda29e9f89f6ded192213e90164c7a221f041)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java
> Incorrect javadoc for atomicity guarantee of Increment and Append
> -
>
> Key: HBASE-15497
> URL: https://issues.apache.org/jira/browse/HBASE-15497
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.0.0
>Reporter: Jianwei Cui
>Assignee: Jianwei Cui
>Priority: Minor
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-15497-v1.patch
>
>
> At the front of {{Increment.java}} file, there is comment about read
> atomicity:
> {code}
> * This operation does not appear atomic to readers. Increments are done
> * under a single row lock, so write operations to a row are synchronized, but
> * readers do not take row locks so get and scan operations can see this
> * operation partially completed.
> {code}
> It seems this comment is not true after MVCC integrated
> [HBASE-4583|https://issues.apache.org/jira/browse/HBASE-4583]. Currently, the
> readers can be guaranteed to read the whole result of Increment if I am not
> wrong. Similar comments also exist in {{Append.java}}, {{Table#append(...)}}
> and {{Table#increment(...)}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-15497) Incorrect javadoc for atomicity guarantee of Increment and Append
[
https://issues.apache.org/jira/browse/HBASE-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152507#comment-16152507
]
Hudson commented on HBASE-15497:
SUCCESS: Integrated in Jenkins build HBase-1.2-JDK8 #209 (See
[https://builds.apache.org/job/HBase-1.2-JDK8/209/])
HBASE-15497 Incorrect javadoc for atomicity guarantee of Increment and
(chia7712: rev 55629b2c675311468caf76069dc3e276421d25c0)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
> Incorrect javadoc for atomicity guarantee of Increment and Append
> -
>
> Key: HBASE-15497
> URL: https://issues.apache.org/jira/browse/HBASE-15497
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.0.0
>Reporter: Jianwei Cui
>Assignee: Jianwei Cui
>Priority: Minor
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-15497-v1.patch
>
>
> At the front of {{Increment.java}} file, there is comment about read
> atomicity:
> {code}
> * This operation does not appear atomic to readers. Increments are done
> * under a single row lock, so write operations to a row are synchronized, but
> * readers do not take row locks so get and scan operations can see this
> * operation partially completed.
> {code}
> It seems this comment is not true after MVCC integrated
> [HBASE-4583|https://issues.apache.org/jira/browse/HBASE-4583]. Currently, the
> readers can be guaranteed to read the whole result of Increment if I am not
> wrong. Similar comments also exist in {{Append.java}}, {{Table#append(...)}}
> and {{Table#increment(...)}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-15497) Incorrect javadoc for atomicity guarantee of Increment and Append
[
https://issues.apache.org/jira/browse/HBASE-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152478#comment-16152478
]
Hudson commented on HBASE-15497:
SUCCESS: Integrated in Jenkins build HBase-1.3-JDK8 #275 (See
[https://builds.apache.org/job/HBase-1.3-JDK8/275/])
HBASE-15497 Incorrect javadoc for atomicity guarantee of Increment and
(chia7712: rev 67be2d11e4389d5ced9317c67dabb195afa8a25b)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java
> Incorrect javadoc for atomicity guarantee of Increment and Append
> -
>
> Key: HBASE-15497
> URL: https://issues.apache.org/jira/browse/HBASE-15497
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.0.0
>Reporter: Jianwei Cui
>Assignee: Jianwei Cui
>Priority: Minor
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-15497-v1.patch
>
>
> At the front of {{Increment.java}} file, there is comment about read
> atomicity:
> {code}
> * This operation does not appear atomic to readers. Increments are done
> * under a single row lock, so write operations to a row are synchronized, but
> * readers do not take row locks so get and scan operations can see this
> * operation partially completed.
> {code}
> It seems this comment is not true after MVCC integrated
> [HBASE-4583|https://issues.apache.org/jira/browse/HBASE-4583]. Currently, the
> readers can be guaranteed to read the whole result of Increment if I am not
> wrong. Similar comments also exist in {{Append.java}}, {{Table#append(...)}}
> and {{Table#increment(...)}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-15497) Incorrect javadoc for atomicity guarantee of Increment and Append
[
https://issues.apache.org/jira/browse/HBASE-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152419#comment-16152419
]
Hudson commented on HBASE-15497:
FAILURE: Integrated in Jenkins build HBase-1.5 #44 (See
[https://builds.apache.org/job/HBase-1.5/44/])
HBASE-15497 Incorrect javadoc for atomicity guarantee of Increment and
(chia7712: rev 8ce811c6edd9c745710f31c3781425e75ec49361)
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
> Incorrect javadoc for atomicity guarantee of Increment and Append
> -
>
> Key: HBASE-15497
> URL: https://issues.apache.org/jira/browse/HBASE-15497
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.0.0
>Reporter: Jianwei Cui
>Assignee: Jianwei Cui
>Priority: Minor
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-15497-v1.patch
>
>
> At the front of {{Increment.java}} file, there is comment about read
> atomicity:
> {code}
> * This operation does not appear atomic to readers. Increments are done
> * under a single row lock, so write operations to a row are synchronized, but
> * readers do not take row locks so get and scan operations can see this
> * operation partially completed.
> {code}
> It seems this comment is not true after MVCC integrated
> [HBASE-4583|https://issues.apache.org/jira/browse/HBASE-4583]. Currently, the
> readers can be guaranteed to read the whole result of Increment if I am not
> wrong. Similar comments also exist in {{Append.java}}, {{Table#append(...)}}
> and {{Table#increment(...)}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-15497) Incorrect javadoc for atomicity guarantee of Increment and Append
[
https://issues.apache.org/jira/browse/HBASE-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152370#comment-16152370
]
Hudson commented on HBASE-15497:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3655 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/3655/])
HBASE-15497 Incorrect javadoc for atomicity guarantee of Increment and
(chia7712: rev 6e3ffd03e7a27274315b859a3b624736ef0ed20b)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java
Revert "HBASE-15497 Incorrect javadoc for atomicity guarantee of (chia7712: rev
0a3a9a5417932da30d12dda2baa1464d4294ace4)
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
HBASE-15497 Incorrect javadoc for atomicity guarantee of Increment and
(chia7712: rev 476973654c297198e33405ff7bc588ffe213aae9)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
> Incorrect javadoc for atomicity guarantee of Increment and Append
> -
>
> Key: HBASE-15497
> URL: https://issues.apache.org/jira/browse/HBASE-15497
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.0.0
>Reporter: Jianwei Cui
>Assignee: Jianwei Cui
>Priority: Minor
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-15497-v1.patch
>
>
> At the front of {{Increment.java}} file, there is comment about read
> atomicity:
> {code}
> * This operation does not appear atomic to readers. Increments are done
> * under a single row lock, so write operations to a row are synchronized, but
> * readers do not take row locks so get and scan operations can see this
> * operation partially completed.
> {code}
> It seems this comment is not true after MVCC integrated
> [HBASE-4583|https://issues.apache.org/jira/browse/HBASE-4583]. Currently, the
> readers can be guaranteed to read the whole result of Increment if I am not
> wrong. Similar comments also exist in {{Append.java}}, {{Table#append(...)}}
> and {{Table#increment(...)}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-15497) Incorrect javadoc for atomicity guarantee of Increment and Append
[
https://issues.apache.org/jira/browse/HBASE-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152267#comment-16152267
]
Hudson commented on HBASE-15497:
FAILURE: Integrated in Jenkins build HBase-1.3-IT #199 (See
[https://builds.apache.org/job/HBase-1.3-IT/199/])
HBASE-15497 Incorrect javadoc for atomicity guarantee of Increment and
(chia7712: rev 67be2d11e4389d5ced9317c67dabb195afa8a25b)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java
> Incorrect javadoc for atomicity guarantee of Increment and Append
> -
>
> Key: HBASE-15497
> URL: https://issues.apache.org/jira/browse/HBASE-15497
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.0.0
>Reporter: Jianwei Cui
>Assignee: Jianwei Cui
>Priority: Minor
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-15497-v1.patch
>
>
> At the front of {{Increment.java}} file, there is comment about read
> atomicity:
> {code}
> * This operation does not appear atomic to readers. Increments are done
> * under a single row lock, so write operations to a row are synchronized, but
> * readers do not take row locks so get and scan operations can see this
> * operation partially completed.
> {code}
> It seems this comment is not true after MVCC integrated
> [HBASE-4583|https://issues.apache.org/jira/browse/HBASE-4583]. Currently, the
> readers can be guaranteed to read the whole result of Increment if I am not
> wrong. Similar comments also exist in {{Append.java}}, {{Table#append(...)}}
> and {{Table#increment(...)}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-15497) Incorrect javadoc for atomicity guarantee of Increment and Append
[
https://issues.apache.org/jira/browse/HBASE-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152264#comment-16152264
]
Hudson commented on HBASE-15497:
FAILURE: Integrated in Jenkins build HBase-1.2-JDK7 #214 (See
[https://builds.apache.org/job/HBase-1.2-JDK7/214/])
HBASE-15497 Incorrect javadoc for atomicity guarantee of Increment and
(chia7712: rev 55629b2c675311468caf76069dc3e276421d25c0)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
> Incorrect javadoc for atomicity guarantee of Increment and Append
> -
>
> Key: HBASE-15497
> URL: https://issues.apache.org/jira/browse/HBASE-15497
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.0.0
>Reporter: Jianwei Cui
>Assignee: Jianwei Cui
>Priority: Minor
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-15497-v1.patch
>
>
> At the front of {{Increment.java}} file, there is comment about read
> atomicity:
> {code}
> * This operation does not appear atomic to readers. Increments are done
> * under a single row lock, so write operations to a row are synchronized, but
> * readers do not take row locks so get and scan operations can see this
> * operation partially completed.
> {code}
> It seems this comment is not true after MVCC integrated
> [HBASE-4583|https://issues.apache.org/jira/browse/HBASE-4583]. Currently, the
> readers can be guaranteed to read the whole result of Increment if I am not
> wrong. Similar comments also exist in {{Append.java}}, {{Table#append(...)}}
> and {{Table#increment(...)}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-15497) Incorrect javadoc for atomicity guarantee of Increment and Append
[
https://issues.apache.org/jira/browse/HBASE-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152262#comment-16152262
]
Hudson commented on HBASE-15497:
FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #267 (See
[https://builds.apache.org/job/HBase-1.3-JDK7/267/])
HBASE-15497 Incorrect javadoc for atomicity guarantee of Increment and
(chia7712: rev 67be2d11e4389d5ced9317c67dabb195afa8a25b)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
> Incorrect javadoc for atomicity guarantee of Increment and Append
> -
>
> Key: HBASE-15497
> URL: https://issues.apache.org/jira/browse/HBASE-15497
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.0.0
>Reporter: Jianwei Cui
>Assignee: Jianwei Cui
>Priority: Minor
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-15497-v1.patch
>
>
> At the front of {{Increment.java}} file, there is comment about read
> atomicity:
> {code}
> * This operation does not appear atomic to readers. Increments are done
> * under a single row lock, so write operations to a row are synchronized, but
> * readers do not take row locks so get and scan operations can see this
> * operation partially completed.
> {code}
> It seems this comment is not true after MVCC integrated
> [HBASE-4583|https://issues.apache.org/jira/browse/HBASE-4583]. Currently, the
> readers can be guaranteed to read the whole result of Increment if I am not
> wrong. Similar comments also exist in {{Append.java}}, {{Table#append(...)}}
> and {{Table#increment(...)}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-15497) Incorrect javadoc for atomicity guarantee of Increment and Append
[
https://issues.apache.org/jira/browse/HBASE-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152253#comment-16152253
]
Hudson commented on HBASE-15497:
FAILURE: Integrated in Jenkins build HBase-1.2-IT #950 (See
[https://builds.apache.org/job/HBase-1.2-IT/950/])
HBASE-15497 Incorrect javadoc for atomicity guarantee of Increment and
(chia7712: rev 55629b2c675311468caf76069dc3e276421d25c0)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java
> Incorrect javadoc for atomicity guarantee of Increment and Append
> -
>
> Key: HBASE-15497
> URL: https://issues.apache.org/jira/browse/HBASE-15497
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.0.0
>Reporter: Jianwei Cui
>Assignee: Jianwei Cui
>Priority: Minor
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-15497-v1.patch
>
>
> At the front of {{Increment.java}} file, there is comment about read
> atomicity:
> {code}
> * This operation does not appear atomic to readers. Increments are done
> * under a single row lock, so write operations to a row are synchronized, but
> * readers do not take row locks so get and scan operations can see this
> * operation partially completed.
> {code}
> It seems this comment is not true after MVCC integrated
> [HBASE-4583|https://issues.apache.org/jira/browse/HBASE-4583]. Currently, the
> readers can be guaranteed to read the whole result of Increment if I am not
> wrong. Similar comments also exist in {{Append.java}}, {{Table#append(...)}}
> and {{Table#increment(...)}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-15497) Incorrect javadoc for atomicity guarantee of Increment and Append
[
https://issues.apache.org/jira/browse/HBASE-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152252#comment-16152252
]
Hudson commented on HBASE-15497:
FAILURE: Integrated in Jenkins build HBase-1.4 #899 (See
[https://builds.apache.org/job/HBase-1.4/899/])
HBASE-15497 Incorrect javadoc for atomicity guarantee of Increment and
(chia7712: rev ccaef7c029fb210cf1dfeb992c9d3b4e4427111b)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
> Incorrect javadoc for atomicity guarantee of Increment and Append
> -
>
> Key: HBASE-15497
> URL: https://issues.apache.org/jira/browse/HBASE-15497
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.0.0
>Reporter: Jianwei Cui
>Assignee: Jianwei Cui
>Priority: Minor
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-15497-v1.patch
>
>
> At the front of {{Increment.java}} file, there is comment about read
> atomicity:
> {code}
> * This operation does not appear atomic to readers. Increments are done
> * under a single row lock, so write operations to a row are synchronized, but
> * readers do not take row locks so get and scan operations can see this
> * operation partially completed.
> {code}
> It seems this comment is not true after MVCC integrated
> [HBASE-4583|https://issues.apache.org/jira/browse/HBASE-4583]. Currently, the
> readers can be guaranteed to read the whole result of Increment if I am not
> wrong. Similar comments also exist in {{Append.java}}, {{Table#append(...)}}
> and {{Table#increment(...)}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-15497) Incorrect javadoc for atomicity guarantee of Increment and Append
[
https://issues.apache.org/jira/browse/HBASE-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152008#comment-16152008
]
Jerry He commented on HBASE-15497:
--
+1
> Incorrect javadoc for atomicity guarantee of Increment and Append
> -
>
> Key: HBASE-15497
> URL: https://issues.apache.org/jira/browse/HBASE-15497
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.0.0
>Reporter: Jianwei Cui
>Assignee: Jianwei Cui
>Priority: Minor
> Attachments: HBASE-15497-v1.patch
>
>
> At the front of {{Increment.java}} file, there is comment about read
> atomicity:
> {code}
> * This operation does not appear atomic to readers. Increments are done
> * under a single row lock, so write operations to a row are synchronized, but
> * readers do not take row locks so get and scan operations can see this
> * operation partially completed.
> {code}
> It seems this comment is not true after MVCC integrated
> [HBASE-4583|https://issues.apache.org/jira/browse/HBASE-4583]. Currently, the
> readers can be guaranteed to read the whole result of Increment if I am not
> wrong. Similar comments also exist in {{Append.java}}, {{Table#append(...)}}
> and {{Table#increment(...)}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-15497) Incorrect javadoc for atomicity guarantee of Increment and Append
[
https://issues.apache.org/jira/browse/HBASE-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151917#comment-16151917
]
Hadoop QA commented on HBASE-15497:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
22s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
36m 10s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
21s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
6s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 48m 13s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:47a5614 |
| JIRA Issue | HBASE-15497 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12797898/HBASE-15497-v1.patch |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 008b229ddbe1 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 83175fd |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8452/testReport/ |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8452/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Incorrect javadoc for atomicity guarantee of Increment and Append
> -
>
> Key: HBASE-15497
> URL: https://issues.apache.org/jira/browse/HBASE-15497
> Project: HBase
> Issue Type: Bug
> Components: documentation
>
[jira] [Commented] (HBASE-15497) Incorrect javadoc for atomicity guarantee of Increment and Append
[
https://issues.apache.org/jira/browse/HBASE-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151893#comment-16151893
]
Chia-Ping Tsai commented on HBASE-15497:
LGTM
> Incorrect javadoc for atomicity guarantee of Increment and Append
> -
>
> Key: HBASE-15497
> URL: https://issues.apache.org/jira/browse/HBASE-15497
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.0.0
>Reporter: Jianwei Cui
>Priority: Minor
> Attachments: HBASE-15497-v1.patch
>
>
> At the front of {{Increment.java}} file, there is comment about read
> atomicity:
> {code}
> * This operation does not appear atomic to readers. Increments are done
> * under a single row lock, so write operations to a row are synchronized, but
> * readers do not take row locks so get and scan operations can see this
> * operation partially completed.
> {code}
> It seems this comment is not true after MVCC integrated
> [HBASE-4583|https://issues.apache.org/jira/browse/HBASE-4583]. Currently, the
> readers can be guaranteed to read the whole result of Increment if I am not
> wrong. Similar comments also exist in {{Append.java}}, {{Table#append(...)}}
> and {{Table#increment(...)}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-15497) Incorrect javadoc for atomicity guarantee of Increment and Append
[
https://issues.apache.org/jira/browse/HBASE-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233922#comment-15233922
]
Jianwei Cui commented on HBASE-15497:
-
Can anyone help to review the patch? Thanks:)
> Incorrect javadoc for atomicity guarantee of Increment and Append
> -
>
> Key: HBASE-15497
> URL: https://issues.apache.org/jira/browse/HBASE-15497
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.0.0
>Reporter: Jianwei Cui
>Priority: Minor
> Attachments: HBASE-15497-v1.patch
>
>
> At the front of {{Increment.java}} file, there is comment about read
> atomicity:
> {code}
> * This operation does not appear atomic to readers. Increments are done
> * under a single row lock, so write operations to a row are synchronized, but
> * readers do not take row locks so get and scan operations can see this
> * operation partially completed.
> {code}
> It seems this comment is not true after MVCC integrated
> [HBASE-4583|https://issues.apache.org/jira/browse/HBASE-4583]. Currently, the
> readers can be guaranteed to read the whole result of Increment if I am not
> wrong. Similar comments also exist in {{Append.java}}, {{Table#append(...)}}
> and {{Table#increment(...)}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
