[jira] [Commented] (HBASE-15783) AccessControlConstants#OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST not used any more.
[ https://issues.apache.org/jira/browse/HBASE-15783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353404#comment-15353404 ] Hudson commented on HBASE-15783: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1232 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1232/]) HBASE-15783 AccessControlConstants#OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST (apurtell: rev 5133a8b3cd6dc2e6956a092e6dcaca8753c6ba27) * hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlConstants.java > AccessControlConstants#OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST not used any more. > -- > > Key: HBASE-15783 > URL: https://issues.apache.org/jira/browse/HBASE-15783 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 1.4.0, 0.98.21 > > Attachments: HBASE-15783.patch, HBASE-15783_branch_1.patch > > > This is based on a mail in the user list. > OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST in AccessControlConstants is not used > any more in the code and AccessControlconstants is Public. We need to either > bring in this feature or remove the constant from the Public APi which may be > misleading. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15783) AccessControlConstants#OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST not used any more.
[ https://issues.apache.org/jira/browse/HBASE-15783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353353#comment-15353353 ] Hudson commented on HBASE-15783: FAILURE: Integrated in HBase-0.98-matrix #360 (See [https://builds.apache.org/job/HBase-0.98-matrix/360/]) HBASE-15783 AccessControlConstants#OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST (apurtell: rev 5133a8b3cd6dc2e6956a092e6dcaca8753c6ba27) * hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlConstants.java > AccessControlConstants#OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST not used any more. > -- > > Key: HBASE-15783 > URL: https://issues.apache.org/jira/browse/HBASE-15783 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 1.4.0, 0.98.21 > > Attachments: HBASE-15783.patch, HBASE-15783_branch_1.patch > > > This is based on a mail in the user list. > OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST in AccessControlConstants is not used > any more in the code and AccessControlconstants is Public. We need to either > bring in this feature or remove the constant from the Public APi which may be > misleading. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15783) AccessControlConstants#OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST not used any more.
[ https://issues.apache.org/jira/browse/HBASE-15783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341815#comment-15341815 ] Hudson commented on HBASE-15783: FAILURE: Integrated in HBase-1.4 #232 (See [https://builds.apache.org/job/HBase-1.4/232/]) HBASE-15783 AccessControlConstants#OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST (ramkrishna: rev f06945ae6c4bfbfed31dd552a24024b90865c1fb) * hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlConstants.java > AccessControlConstants#OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST not used any more. > -- > > Key: HBASE-15783 > URL: https://issues.apache.org/jira/browse/HBASE-15783 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-15783.patch, HBASE-15783_branch_1.patch > > > This is based on a mail in the user list. > OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST in AccessControlConstants is not used > any more in the code and AccessControlconstants is Public. We need to either > bring in this feature or remove the constant from the Public APi which may be > misleading. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15783) AccessControlConstants#OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST not used any more.
[ https://issues.apache.org/jira/browse/HBASE-15783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341290#comment-15341290 ] Hudson commented on HBASE-15783: FAILURE: Integrated in HBase-Trunk_matrix #1086 (See [https://builds.apache.org/job/HBase-Trunk_matrix/1086/]) HBASE-15783 AccessControlConstants#OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST (ramkrishna: rev a9950e000187333d66dbad07a7a29f2f13ff910d) * hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlConstants.java > AccessControlConstants#OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST not used any more. > -- > > Key: HBASE-15783 > URL: https://issues.apache.org/jira/browse/HBASE-15783 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-15783.patch, HBASE-15783_branch_1.patch > > > This is based on a mail in the user list. > OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST in AccessControlConstants is not used > any more in the code and AccessControlconstants is Public. We need to either > bring in this feature or remove the constant from the Public APi which may be > misleading. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15783) AccessControlConstants#OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST not used any more.
[ https://issues.apache.org/jira/browse/HBASE-15783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341112#comment-15341112 ] Anoop Sam John commented on HBASE-15783: Ya ideally the deprecation has to be in whole of a major version and then remove. Am +1 for remove in 2.0 and deprecate in 1.4 > AccessControlConstants#OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST not used any more. > -- > > Key: HBASE-15783 > URL: https://issues.apache.org/jira/browse/HBASE-15783 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 1.0.4, 1.4.0 > > Attachments: HBASE-15783.patch > > > This is based on a mail in the user list. > OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST in AccessControlConstants is not used > any more in the code and AccessControlconstants is Public. We need to either > bring in this feature or remove the constant from the Public APi which may be > misleading. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15783) AccessControlConstants#OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST not used any more.
[ https://issues.apache.org/jira/browse/HBASE-15783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341106#comment-15341106 ] ramkrishna.s.vasudevan commented on HBASE-15783: No refs in book. So no doc updation needed. bq.This breaks src compatibility. But ya users must change/remove code if compiled with new version. So we will only deprecate in branch-1 ? > AccessControlConstants#OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST not used any more. > -- > > Key: HBASE-15783 > URL: https://issues.apache.org/jira/browse/HBASE-15783 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 1.0.4, 1.4.0 > > Attachments: HBASE-15783.patch > > > This is based on a mail in the user list. > OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST in AccessControlConstants is not used > any more in the code and AccessControlconstants is Public. We need to either > bring in this feature or remove the constant from the Public APi which may be > misleading. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15783) AccessControlConstants#OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST not used any more.
[ https://issues.apache.org/jira/browse/HBASE-15783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341102#comment-15341102 ] Anoop Sam John commented on HBASE-15783: We can keep it commit in 2.0 only? This breaks src compatibility. But ya users must change/remove code if compiled with new version. Any ref for these in book? > AccessControlConstants#OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST not used any more. > -- > > Key: HBASE-15783 > URL: https://issues.apache.org/jira/browse/HBASE-15783 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 1.0.4, 1.4.0 > > Attachments: HBASE-15783.patch > > > This is based on a mail in the user list. > OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST in AccessControlConstants is not used > any more in the code and AccessControlconstants is Public. We need to either > bring in this feature or remove the constant from the Public APi which may be > misleading. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15783) AccessControlConstants#OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST not used any more.
[ https://issues.apache.org/jira/browse/HBASE-15783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341091#comment-15341091 ] ramkrishna.s.vasudevan commented on HBASE-15783: Will commit this unless objections. > AccessControlConstants#OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST not used any more. > -- > > Key: HBASE-15783 > URL: https://issues.apache.org/jira/browse/HBASE-15783 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 1.0.4, 1.4.0 > > Attachments: HBASE-15783.patch > > > This is based on a mail in the user list. > OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST in AccessControlConstants is not used > any more in the code and AccessControlconstants is Public. We need to either > bring in this feature or remove the constant from the Public APi which may be > misleading. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15783) AccessControlConstants#OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST not used any more.
[
https://issues.apache.org/jira/browse/HBASE-15783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339021#comment-15339021
]
Hadoop QA commented on HBASE-15783:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
17s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 26s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 16s
{color} | {color:green} master passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
25s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
10s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 2s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 27s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s
{color} | {color:green} master passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
19s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 19s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 19s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 18s
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 18s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
24s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
10s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
26m 41s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
13s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 27s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 57s
{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 37m 58s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12811751/HBASE-15783.patch |
| JIRA Issue | HBASE-15783 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 4421fdf |
| Default Java | 1.7.0_80 |
| Multi-JDK versions | /home/jenkins/tools/java/jdk1.8.0:1.8.0
[jira] [Commented] (HBASE-15783) AccessControlConstants#OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST not used any more.
[
https://issues.apache.org/jira/browse/HBASE-15783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273716#comment-15273716
]
Anoop Sam John commented on HBASE-15783:
Removed the feature in HBASE-11432.
As I added in a comment in that issue now
AccessControlConstants which is Public class still have reference
/** Cell level ACL evaluation strategy */
public static final String OP_ATTRIBUTE_ACL_STRATEGY = "acl.strategy";
/** Default cell ACL evaluation strategy: Table and CF first, then ACL */
public static final byte[] OP_ATTRIBUTE_ACL_STRATEGY_DEFAULT = new byte[]
{ 0 }
;
/** Alternate cell ACL evaluation strategy: Cell ACL first, then table and CF */
public static final byte[] OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST = new byte[]
{ 1 }
;
We need to remove them. And also in hbase book if any ref ?
> AccessControlConstants#OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST not used any more.
> --
>
> Key: HBASE-15783
> URL: https://issues.apache.org/jira/browse/HBASE-15783
> Project: HBase
> Issue Type: Bug
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 2.0.0, 1.3.0, 1.0.4, 1.4.0
>
>
> This is based on a mail in the user list.
> OP_ATTRIBUTE_ACL_STRATEGY_CELL_FIRST in AccessControlConstants is not used
> any more in the code and AccessControlconstants is Public. We need to either
> bring in this feature or remove the constant from the Public APi which may be
> misleading.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
