[jira] [Commented] (HBASE-16035) Nested AutoCloseables might not all get closed
[
https://issues.apache.org/jira/browse/HBASE-16035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341028#comment-15341028
]
Hudson commented on HBASE-16035:
FAILURE: Integrated in HBase-Trunk_matrix #1085 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/1085/])
HBASE-16035 Nested AutoCloseables might not all get closed (Sean (tedyu: rev
3de0c631050ea7dfb72fa8e1430aa8e7c0e87088)
* hbase-server/src/main/java/org/apache/hadoop/hbase/http/log/LogLevel.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/JarFinder.java
> Nested AutoCloseables might not all get closed
> --
>
> Key: HBASE-16035
> URL: https://issues.apache.org/jira/browse/HBASE-16035
> Project: HBase
> Issue Type: Bug
>Reporter: Sean Mackrory
> Fix For: 2.0.0
>
> Attachments: HBASE-16035-v1.patch
>
>
> Subtle problem in HBASE-15891:
> {code}try (A myA = new A(new B())){code}
> An exception thrown between B starting to open an A finishing initialization
> may not result in B being closed. A safer syntax would be:
> {code}try(B myB = new B(); A myA = newA(myB)){code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16035) Nested AutoCloseables might not all get closed
[
https://issues.apache.org/jira/browse/HBASE-16035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340665#comment-15340665
]
Ted Yu commented on HBASE-16035:
{code}
Failed tests:
TestReplicationKillMasterRSCompressedWithMultipleWAL>TestReplicationKillMasterRS.killOneMasterRS:34->TestReplicationKillRS.loadTableAndKillRS:88
Waited too much time for queueFailover replication. Waited 15112ms.
Flaked tests:
{code}
The above is not related to the patch.
> Nested AutoCloseables might not all get closed
> --
>
> Key: HBASE-16035
> URL: https://issues.apache.org/jira/browse/HBASE-16035
> Project: HBase
> Issue Type: Bug
>Reporter: Sean Mackrory
> Attachments: HBASE-16035-v1.patch
>
>
> Subtle problem in HBASE-15891:
> {code}try (A myA = new A(new B())){code}
> An exception thrown between B starting to open an A finishing initialization
> may not result in B being closed. A safer syntax would be:
> {code}try(B myB = new B(); A myA = newA(myB)){code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16035) Nested AutoCloseables might not all get closed
[
https://issues.apache.org/jira/browse/HBASE-16035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335074#comment-15335074
]
Hadoop QA commented on HBASE-16035:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
57s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 53s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 38s
{color} | {color:green} master passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
57s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
17s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
14s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 37s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 38s
{color} | {color:green} master passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
50s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 51s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 51s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 39s
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 39s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
56s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
17s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
31m 20s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
26s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 37s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 37s
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 117m 38s
{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 167m 6s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12811218/HBASE-16035-v1.patch |
| JIRA Issue | HBASE-16035 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux asf910.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 62a4a2c |
| Default Java | 1.7.0_80 |
| Multi-JDK versions | /home/jenkins/tools/java/jdk1.8.0:1.8.0
[jira] [Commented] (HBASE-16035) Nested AutoCloseables might not all get closed
[
https://issues.apache.org/jira/browse/HBASE-16035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334700#comment-15334700
]
Ted Yu commented on HBASE-16035:
Please re-attach for QA run.
> Nested AutoCloseables might not all get closed
> --
>
> Key: HBASE-16035
> URL: https://issues.apache.org/jira/browse/HBASE-16035
> Project: HBase
> Issue Type: Bug
>Reporter: Sean Mackrory
> Attachments: HBASE-16035-v1.patch
>
>
> Subtle problem in HBASE-15891:
> {code}try (A myA = new A(new B())){code}
> An exception thrown between B starting to open an A finishing initialization
> may not result in B being closed. A safer syntax would be:
> {code}try(B myB = new B(); A myA = newA(myB)){code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16035) Nested AutoCloseables might not all get closed
[
https://issues.apache.org/jira/browse/HBASE-16035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15332564#comment-15332564
]
Hadoop QA commented on HBASE-16035:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | {color:red} pre-patch {color} | {color:red} 0m 0s
{color} | {color:red} JAVA_HOME is not defined. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12810919/HBASE-16035-v1.patch |
| JIRA Issue | HBASE-16035 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux pietas.apache.org 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT
Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / bff35d6 |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/2235/console |
| Powered by | Apache Yetus 0.2.1 http://yetus.apache.org |
This message was automatically generated.
> Nested AutoCloseables might not all get closed
> --
>
> Key: HBASE-16035
> URL: https://issues.apache.org/jira/browse/HBASE-16035
> Project: HBase
> Issue Type: Bug
>Reporter: Sean Mackrory
> Attachments: HBASE-16035-v1.patch
>
>
> Subtle problem in HBASE-15891:
> {code}try (A myA = new A(new B())){code}
> An exception thrown between B starting to open an A finishing initialization
> may not result in B being closed. A safer syntax would be:
> {code}try(B myB = new B(); A myA = newA(myB)){code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
