[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15453260#comment-15453260 ] Ted Yu commented on HBASE-16255: bulk loading is just one step in restore. Haven't compared the amount of data being bulk loaded between IntegrationTestBulkLoad and backup IT though. > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2, > 16255.addendum4, 16255.addendum5, 16255.addendum6, HBASE-16255-v1.patch, > HBASE-16255-v2.patch, HBASE-16255-v3.patch, HBASE-16255-v4.patch, > HBASE-16255-v5.patch, HBASE-16255-v6.patch, backup-it-7912-8-30.out, > backup-it-8-30.out, backup-it-success.out > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15453184#comment-15453184 ] Dima Spivak commented on HBASE-16255: - Yeah, I think the requirement of adding a working backup/restore IT has been satisfied. I'd still be very curious to find out why this feature is apparently so much more resource intensive than both bulk loading and ITBLL, though. Any idea, [~tedyu] or [~vrodionov]? > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2, > 16255.addendum4, 16255.addendum5, 16255.addendum6, HBASE-16255-v1.patch, > HBASE-16255-v2.patch, HBASE-16255-v3.patch, HBASE-16255-v4.patch, > HBASE-16255-v5.patch, HBASE-16255-v6.patch, backup-it-7912-8-30.out, > backup-it-8-30.out, backup-it-success.out > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15453176#comment-15453176 ] Ted Yu commented on HBASE-16255: [~dimaspivak]: Can this issue be resolved ? > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2, > 16255.addendum4, 16255.addendum5, 16255.addendum6, HBASE-16255-v1.patch, > HBASE-16255-v2.patch, HBASE-16255-v3.patch, HBASE-16255-v4.patch, > HBASE-16255-v5.patch, HBASE-16255-v6.patch, backup-it-7912-8-30.out, > backup-it-8-30.out, backup-it-success.out > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15451467#comment-15451467 ] Devaraj Das commented on HBASE-16255: - No idea [~dspivak]. It could be various factors including the memory used by the underlying libraries. But I think we should move on at this point. > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2, > 16255.addendum4, 16255.addendum5, 16255.addendum6, HBASE-16255-v1.patch, > HBASE-16255-v2.patch, HBASE-16255-v3.patch, HBASE-16255-v4.patch, > HBASE-16255-v5.patch, HBASE-16255-v6.patch, backup-it-7912-8-30.out, > backup-it-8-30.out, backup-it-success.out > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15451453#comment-15451453 ] Dima Spivak commented on HBASE-16255: - Hm, weird. ITBLL and ITBulkLoad pass just fine without any modifications. Any reason this feature has bigger resource requirements than those tests? -- -Dima > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2, > 16255.addendum4, 16255.addendum5, 16255.addendum6, HBASE-16255-v1.patch, > HBASE-16255-v2.patch, HBASE-16255-v3.patch, HBASE-16255-v4.patch, > HBASE-16255-v5.patch, HBASE-16255-v6.patch, backup-it-7912-8-30.out, > backup-it-8-30.out, backup-it-success.out > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15451449#comment-15451449 ] Devaraj Das commented on HBASE-16255: - And the test came out successful. Mission accomplished. > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2, > 16255.addendum4, 16255.addendum5, 16255.addendum6, HBASE-16255-v1.patch, > HBASE-16255-v2.patch, HBASE-16255-v3.patch, HBASE-16255-v4.patch, > HBASE-16255-v5.patch, HBASE-16255-v6.patch, backup-it-7912-8-30.out, > backup-it-8-30.out, backup-it-success.out > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[
https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15451445#comment-15451445
]
Devaraj Das commented on HBASE-16255:
-
Sorry, I was off on my previous guess at the issue. I dug deeper and this seems
like a yarn issue to do with the minimum memory for the containers.
The default heap size (-Xmx200m) for the tasks was too low ([~dspivak],
curious, if you ran other IT tests that do mapreduce, and did/didn't see this
issue)
I added the following in yarn-site.xml:
{noformat}
yarn.scheduler.minimum-allocation-mb
1024
mapreduce.map.memory.mb
1024
mapreduce.reduce.memory.mb
1024
mapred.child.java.opts
-Xmx1024m
mapred.map.child.java.opts
-Xmx1024m
mapred.reduce.child.java.opts
-Xmx1024m
{noformat}
And in mapred-site.xml, added the following:
{noformat}
mapred.map.child.java.opts
-Xmx1024m
mapred.reduce.child.java.opts
-Xmx1024m
mapred.child.java.opts
-Xmx1024m
{noformat}
At the time of this writing, the test was still running (it proceeded beyond
your failure point [~dspivak]). Fingers crossed.
> Backup/Restore IT
> -
>
> Key: HBASE-16255
> URL: https://issues.apache.org/jira/browse/HBASE-16255
> Project: HBase
> Issue Type: Task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Labels: backup
> Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2,
> 16255.addendum4, 16255.addendum5, 16255.addendum6, HBASE-16255-v1.patch,
> HBASE-16255-v2.patch, HBASE-16255-v3.patch, HBASE-16255-v4.patch,
> HBASE-16255-v5.patch, HBASE-16255-v6.patch, backup-it-7912-8-30.out,
> backup-it-8-30.out, backup-it-success.out
>
>
> Integration test for backup restore.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[
https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15451248#comment-15451248
]
Dima Spivak commented on HBASE-16255:
-
[~devaraj], if the feature fails on an insecure deployment when run as a user
not named {{hbase}}, that sounds like a bug in the feature.
> Backup/Restore IT
> -
>
> Key: HBASE-16255
> URL: https://issues.apache.org/jira/browse/HBASE-16255
> Project: HBase
> Issue Type: Task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Labels: backup
> Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2,
> 16255.addendum4, 16255.addendum5, 16255.addendum6, HBASE-16255-v1.patch,
> HBASE-16255-v2.patch, HBASE-16255-v3.patch, HBASE-16255-v4.patch,
> HBASE-16255-v5.patch, HBASE-16255-v6.patch, backup-it-7912-8-30.out,
> backup-it-8-30.out, backup-it-success.out
>
>
> Integration test for backup restore.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15451197#comment-15451197 ] Devaraj Das commented on HBASE-16255: - Ah I think the issue is that in the docker env, all the hbase processes run as 'root', and hence the backup dirs end up being created as 'root'. But at some point in the sanpshot copy or something, the user switches to hbase and fails to perform the filesystem operations. I bet if things are run as 'hbase' things will work. [~dspivak] can you please check the docker stuff to run the processes in the more natural deployment style - hbase processes as hbase, etc.. > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2, > 16255.addendum4, 16255.addendum5, 16255.addendum6, HBASE-16255-v1.patch, > HBASE-16255-v2.patch, HBASE-16255-v3.patch, HBASE-16255-v4.patch, > HBASE-16255-v5.patch, HBASE-16255-v6.patch, backup-it-7912-8-30.out, > backup-it-8-30.out, backup-it-success.out > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[
https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15451179#comment-15451179
]
Devaraj Das commented on HBASE-16255:
-
Interesting. The test creates the directory as "root" even if the test is run
as "hbase". But later on, the snapshot fails with permission issues.
{noformat}
2016-08-31 04:34:56,399 INFO [main] hbase.IntegrationTestBackupRestore: create
full backup image for all tables
2016-08-31 04:34:56,584 INFO [main] util.BackupClientUtil: Backup root dir
hdfs://node-1.network21368:8020/user/hbase/test-data/6a446bec-cfae-409c-96c4-099a70bddc24/backupIT
does not exist. Will be created.
{noformat}
When I run the command
{noformat}
[hbase@node-1 root]$ hadoop dfs -ls /user/hbase
DEPRECATED: Use of this script to execute hdfs command is deprecated.
Instead use the hdfs command for it.
16/08/31 04:35:18 WARN util.NativeCodeLoader: Unable to load native-hadoop
library for your platform... using builtin-java classes where applicable
Found 1 items
drwxr-xr-x - root supergroup 0 2016-08-31 04:35 /user/hbase/test-data
{noformat}
> Backup/Restore IT
> -
>
> Key: HBASE-16255
> URL: https://issues.apache.org/jira/browse/HBASE-16255
> Project: HBase
> Issue Type: Task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Labels: backup
> Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2,
> 16255.addendum4, 16255.addendum5, 16255.addendum6, HBASE-16255-v1.patch,
> HBASE-16255-v2.patch, HBASE-16255-v3.patch, HBASE-16255-v4.patch,
> HBASE-16255-v5.patch, HBASE-16255-v6.patch, backup-it-7912-8-30.out,
> backup-it-8-30.out, backup-it-success.out
>
>
> Integration test for backup restore.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15450754#comment-15450754 ] Ted Yu commented on HBASE-16255: In the above procedure, did you switch to user 'hbase' ? > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2, > 16255.addendum4, 16255.addendum5, 16255.addendum6, HBASE-16255-v1.patch, > HBASE-16255-v2.patch, HBASE-16255-v3.patch, HBASE-16255-v4.patch, > HBASE-16255-v5.patch, HBASE-16255-v6.patch, backup-it-7912-8-30.out, > backup-it-8-30.out, backup-it-success.out > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15450544#comment-15450544 ] Devaraj Das commented on HBASE-16255: - Ok am trying this thing out on my laptop. Will report back (if my laptop doesn't melt :) ) > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2, > 16255.addendum4, 16255.addendum5, 16255.addendum6, HBASE-16255-v1.patch, > HBASE-16255-v2.patch, HBASE-16255-v3.patch, HBASE-16255-v4.patch, > HBASE-16255-v5.patch, HBASE-16255-v6.patch, backup-it-7912-8-30.out, > backup-it-8-30.out, backup-it-success.out > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[
https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15450417#comment-15450417
]
Dima Spivak commented on HBASE-16255:
-
Hey [~devaraj], I've already destroyed the cluster in question. Let me know if
you run into any problems with the {{clusterdock}} command and I'd be happy to
help out.
> Backup/Restore IT
> -
>
> Key: HBASE-16255
> URL: https://issues.apache.org/jira/browse/HBASE-16255
> Project: HBase
> Issue Type: Task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Labels: backup
> Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2,
> 16255.addendum4, 16255.addendum5, 16255.addendum6, HBASE-16255-v1.patch,
> HBASE-16255-v2.patch, HBASE-16255-v3.patch, HBASE-16255-v4.patch,
> HBASE-16255-v5.patch, HBASE-16255-v6.patch, backup-it-7912-8-30.out,
> backup-it-8-30.out, backup-it-success.out
>
>
> Integration test for backup restore.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15450413#comment-15450413 ] Devaraj Das commented on HBASE-16255: - [~dspivak] But pardon me for belaboring this point - can you please upload the logs (presumably you have them already), and check if the necessary directories exist on the hdfs side (like /home/root, etc.) and has enough permissions. Given that Docker setup and such might take some time, I am requesting this of you. Thanks a bunch again :-) > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2, > 16255.addendum4, 16255.addendum5, 16255.addendum6, HBASE-16255-v1.patch, > HBASE-16255-v2.patch, HBASE-16255-v3.patch, HBASE-16255-v4.patch, > HBASE-16255-v5.patch, HBASE-16255-v6.patch, backup-it-7912-8-30.out, > backup-it-8-30.out, backup-it-success.out > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15450400#comment-15450400 ] Vladimir Rodionov commented on HBASE-16255: --- [~dspivak], do you usually run ITs with DEBUG disabled? Ted spotted the permission issue just looking on the test's output. From your output, the only thing we can tell is M/R job fails with code 1. Not too much. You would save us a lot of time here. > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2, > 16255.addendum4, 16255.addendum5, 16255.addendum6, HBASE-16255-v1.patch, > HBASE-16255-v2.patch, HBASE-16255-v3.patch, HBASE-16255-v4.patch, > HBASE-16255-v5.patch, HBASE-16255-v6.patch, backup-it-7912-8-30.out, > backup-it-8-30.out, backup-it-success.out > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15450374#comment-15450374 ] Dima Spivak commented on HBASE-16255: - Hey [~devaraj], I've provided about as simple of instructions as I can to help you guys repro, so could you please give it a shot on your end? Having already tried unsuccessfully to run 7 different revisions of this patch, I'd really like to stop being the bottleneck to testing on this. ;) > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2, > 16255.addendum4, 16255.addendum5, 16255.addendum6, HBASE-16255-v1.patch, > HBASE-16255-v2.patch, HBASE-16255-v3.patch, HBASE-16255-v4.patch, > HBASE-16255-v5.patch, HBASE-16255-v6.patch, backup-it-7912-8-30.out, > backup-it-8-30.out, backup-it-success.out > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[
https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15450373#comment-15450373
]
Vladimir Rodionov commented on HBASE-16255:
---
{quote}
Mind attaching the logs please Dima Spivak. Thanks a bunch.
{quote}
DEBUG logging would help a lot, as well.
> Backup/Restore IT
> -
>
> Key: HBASE-16255
> URL: https://issues.apache.org/jira/browse/HBASE-16255
> Project: HBase
> Issue Type: Task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Labels: backup
> Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2,
> 16255.addendum4, 16255.addendum5, 16255.addendum6, HBASE-16255-v1.patch,
> HBASE-16255-v2.patch, HBASE-16255-v3.patch, HBASE-16255-v4.patch,
> HBASE-16255-v5.patch, HBASE-16255-v6.patch, backup-it-7912-8-30.out,
> backup-it-8-30.out, backup-it-success.out
>
>
> Integration test for backup restore.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15450355#comment-15450355 ] Devaraj Das commented on HBASE-16255: - [~dspivak] appreciate your efforts in running the IT with Docker. Out of curiosity, does hdfs://node-1.network3783:8020/user/root/test-data/0919b2b6-c990-4d3e-9aa4-c0d249014545/backupIT/backup_1472586845117/default/IntegrationTestBackupRestore.table2/ exist and there are enough permissions? I mean this seems like something that we should be able to look at logs and figure out the reason for failure. Mind attaching the logs please [~dspivak]. Thanks a bunch. > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2, > 16255.addendum4, 16255.addendum5, 16255.addendum6, HBASE-16255-v1.patch, > HBASE-16255-v2.patch, HBASE-16255-v3.patch, HBASE-16255-v4.patch, > HBASE-16255-v5.patch, HBASE-16255-v6.patch, backup-it-7912-8-30.out, > backup-it-8-30.out, backup-it-success.out > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15450318#comment-15450318 ] Dima Spivak commented on HBASE-16255: - No. Docker 1.11 is required. > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2, > 16255.addendum4, 16255.addendum5, 16255.addendum6, HBASE-16255-v1.patch, > HBASE-16255-v2.patch, HBASE-16255-v3.patch, HBASE-16255-v4.patch, > HBASE-16255-v5.patch, HBASE-16255-v6.patch, backup-it-7912-8-30.out, > backup-it-8-30.out, backup-it-success.out > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15450315#comment-15450315 ] Ted Yu commented on HBASE-16255: What feature from Docker 1.11 is required ? Is the following good enough ? http://pastebin.com/fzNzm7Ng > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2, > 16255.addendum4, 16255.addendum5, 16255.addendum6, HBASE-16255-v1.patch, > HBASE-16255-v2.patch, HBASE-16255-v3.patch, HBASE-16255-v4.patch, > HBASE-16255-v5.patch, HBASE-16255-v6.patch, backup-it-7912-8-30.out, > backup-it-8-30.out, backup-it-success.out > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15450296#comment-15450296 ] Dima Spivak commented on HBASE-16255: - [~tedyu], I copied and pasted exactly what I ran to repro the failures I'm seeing. Can you please do the same and look into why it's happening? All the other ITs I run continue to behave. > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2, > 16255.addendum4, 16255.addendum5, 16255.addendum6, HBASE-16255-v1.patch, > HBASE-16255-v2.patch, HBASE-16255-v3.patch, HBASE-16255-v4.patch, > HBASE-16255-v5.patch, HBASE-16255-v6.patch, backup-it-7912-8-30.out, > backup-it-8-30.out, backup-it-success.out > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15450284#comment-15450284 ] Ted Yu commented on HBASE-16255: Deployed build as of commit d7022551cf3ad8b9e97292d04d8f68e04d0e068a onto Openstack. So far IT test runs fine. Will report back with final result. > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2, > 16255.addendum4, 16255.addendum5, 16255.addendum6, HBASE-16255-v1.patch, > HBASE-16255-v2.patch, HBASE-16255-v3.patch, HBASE-16255-v4.patch, > HBASE-16255-v5.patch, HBASE-16255-v6.patch, backup-it-8-30.out, > backup-it-success.out > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[
https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15450098#comment-15450098
]
Dima Spivak commented on HBASE-16255:
-
Well here's what I run (assuming, again, Docker 1.11+ is installed). I'd highly
recommend it since it takes no time at all and isn't subject to the issues
you're hitting trying to keep your cluster updated:
{noformat}
source /dev/stdin <<< "$(curl -sL http://tiny.cloudera.com/clusterdock.sh)"
CLUSTERDOCK_TOPOLOGY_IMAGE=hbasejenkinsuser-docker-hbase.bintray.io/dev/clusterdock:apache_hbase_topology
clusterdock_run ./bin/build_cluster
--registry-url=hbasejenkinsuser-docker-hbase.bintray.io --namespace=dev
apache_hbase --hbase-version=hbase-7912 --hbase-git-commit=HBASE-7912
--hadoop-version=2.7.1
--hadoop-tarball=https://archive.apache.org/dist/hadoop/core/hadoop-2.7.1/hadoop-2.7.1.tar.gz
NETWORK="network${RANDOM}"
CLUSTERDOCK_TOPOLOGY_IMAGE=hbasejenkinsuser-docker-hbase.bintray.io/dev/clusterdock:apache_hbase_topology
clusterdock_run ./bin/start_cluster -n ${NETWORK}
--registry-url=hbasejenkinsuser-docker-hbase.bintray.io --namespace=dev
apache_hbase --hbase-version=hbase-7912 --hadoop-version=2.7.1
clusterdock_ssh node-1.${NETWORK} hbase
org.apache.hadoop.hbase.IntegrationTestBackupRestore
{noformat}
In order, these commands:
1. Source the helper script we use to run {{clusterdock}} (it currently lives
on Cloudera's GitHub).
2. Build a cluster from {{HBASE-7912}} (which saves the Docker images locally).
3. Sets a {{NETWORK}} variable (used solely to name clusters and then reference
them later when running commands over SSH).
4. Start the cluster built from {{HBASE-7912}} in step 2.
5. SSH to node-1 of your cluster and run the test.
Give that a try and then report back if you can repro what I'm seeing.
> Backup/Restore IT
> -
>
> Key: HBASE-16255
> URL: https://issues.apache.org/jira/browse/HBASE-16255
> Project: HBase
> Issue Type: Task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Labels: backup
> Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2,
> 16255.addendum4, 16255.addendum5, 16255.addendum6, HBASE-16255-v1.patch,
> HBASE-16255-v2.patch, HBASE-16255-v3.patch, HBASE-16255-v4.patch,
> HBASE-16255-v5.patch, HBASE-16255-v6.patch, backup-it-8-30.out,
> backup-it-success.out
>
>
> Integration test for backup restore.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15450082#comment-15450082 ] Ted Yu commented on HBASE-16255: I can go that route if I still cannot reproduce what you see. Currently I don't have Linux with Docker. > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2, > 16255.addendum4, 16255.addendum5, 16255.addendum6, HBASE-16255-v1.patch, > HBASE-16255-v2.patch, HBASE-16255-v3.patch, HBASE-16255-v4.patch, > HBASE-16255-v5.patch, HBASE-16255-v6.patch, backup-it-8-30.out, > backup-it-success.out > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15450079#comment-15450079 ] Dima Spivak commented on HBASE-16255: - Do you have access to a Linux box that has Docker 1.11+ installed, [~tedyu]? If so, I can copy and paste the three lines of code you'd need to build a cluster from source, start it, and then execute your test. That's what I've been doing. > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2, > 16255.addendum4, 16255.addendum5, 16255.addendum6, HBASE-16255-v1.patch, > HBASE-16255-v2.patch, HBASE-16255-v3.patch, HBASE-16255-v4.patch, > HBASE-16255-v5.patch, HBASE-16255-v6.patch, backup-it-8-30.out, > backup-it-success.out > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15450069#comment-15450069 ] Ted Yu commented on HBASE-16255: I am re-deploying HBASE-7912 branch onto the cluster so that I can reproduce what you saw. Meanwhile, if you can check master log to see why snapshot export failed, that would be nice. I checked /tmp on hdfs again - there is no hbase-hbase dir. > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2, > 16255.addendum4, 16255.addendum5, 16255.addendum6, HBASE-16255-v1.patch, > HBASE-16255-v2.patch, HBASE-16255-v3.patch, HBASE-16255-v4.patch, > HBASE-16255-v5.patch, HBASE-16255-v6.patch, backup-it-8-30.out, > backup-it-success.out > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[
https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15450051#comment-15450051
]
Dima Spivak commented on HBASE-16255:
-
Interesting. Yeah, I dunno why the cluster you have set up passes, but it fails
reliably on my side. What do you see when you run {{hbase version}} on your
cluster, [~tedyu]? And how are you executing the test exactly? Here's what I'm
seeing:
{noformat}
[root@node-1 ~]# hbase org.apache.hadoop.hbase.IntegrationTestBackupRestore
2016-08-30 12:53:33,279 INFO [main] hbase.IntegrationTestBackupRestore: Parsed
Options{regions_per_rs=10, region_servers=2, rows_in_batch=2}
2016-08-30 12:53:33,306 INFO [main] hbase.IntegrationTestBackupRestore:
Initializing cluster with 2 region servers.
2016-08-30 12:53:33,365 WARN [main] util.NativeCodeLoader: Unable to load
native-hadoop library for your platform... using builtin-java classes where
applicable
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in
[jar:file:/hbase/lib/slf4j-log4j12-1.6.1.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in
[jar:file:/hadoop/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
2016-08-30 12:53:33,537 INFO [main] zookeeper.RecoverableZooKeeper: Process
identifier=hconnection-0x5aebe890 connecting to ZooKeeper
ensemble=node-1.network3783:2181
2016-08-30 12:53:33,543 INFO [main] zookeeper.ZooKeeper: Client
environment:zookeeper.version=3.4.6-1569965, built on 02/20/2014 09:09 GMT
2016-08-30 12:53:33,543 INFO [main] zookeeper.ZooKeeper: Client
environment:host.name=node-1.network3783
2016-08-30 12:53:33,543 INFO [main] zookeeper.ZooKeeper: Client
environment:java.version=1.8.0_91
2016-08-30 12:53:33,543 INFO [main] zookeeper.ZooKeeper: Client
environment:java.vendor=Oracle Corporation
2016-08-30 12:53:33,548 INFO [main] zookeeper.ZooKeeper: Client
environment:java.home=/java/jre
2016-08-30 12:53:33,548 INFO [main] zookeeper.ZooKeeper: Client
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15449989#comment-15449989 ] Dima Spivak commented on HBASE-16255: - [~tedyu] it still fails for me. Can you please post the console output from your successful run? > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2, > 16255.addendum4, 16255.addendum5, 16255.addendum6, HBASE-16255-v1.patch, > HBASE-16255-v2.patch, HBASE-16255-v3.patch, HBASE-16255-v4.patch, > HBASE-16255-v5.patch, HBASE-16255-v6.patch, backup-it-success.out > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[
https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15449775#comment-15449775
]
Dima Spivak commented on HBASE-16255:
-
[~tedyu], you're using {{getDataTestDirOnTestFS}} incorrectly (please see how
other tests use it). As a result, I'm now seeing this when running the test...
{noformat}
[root@node-1 ~]# hbase org.apache.hadoop.hbase.IntegrationTestBackupRestore
2016-08-30 11:33:32,426 INFO [main] hbase.IntegrationTestBackupRestore: Parsed
Options{regions_per_rs=10, region_servers=2, rows_in_batch=2}
2016-08-30 11:33:32,445 INFO [main] hbase.IntegrationTestBackupRestore:
Initializing cluster with 2 region servers.
2016-08-30 11:33:32,501 WARN [main] util.NativeCodeLoader: Unable to load
native-hadoop library for your platform... using builtin-java classes where
applicable
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in
[jar:file:/hbase/lib/slf4j-log4j12-1.6.1.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in
[jar:file:/hadoop/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
2016-08-30 11:33:32,672 INFO [main] zookeeper.RecoverableZooKeeper: Process
identifier=hconnection-0x5aebe890 connecting to ZooKeeper
ensemble=node-1.network27632:2181
2016-08-30 11:33:32,678 INFO [main] zookeeper.ZooKeeper: Client
environment:zookeeper.version=3.4.6-1569965, built on 02/20/2014 09:09 GMT
2016-08-30 11:33:32,678 INFO [main] zookeeper.ZooKeeper: Client
environment:host.name=node-1.network27632
2016-08-30 11:33:32,678 INFO [main] zookeeper.ZooKeeper: Client
environment:java.version=1.8.0_91
2016-08-30 11:33:32,678 INFO [main] zookeeper.ZooKeeper: Client
environment:java.vendor=Oracle Corporation
2016-08-30 11:33:32,683 INFO [main] zookeeper.ZooKeeper: Client
environment:java.home=/java/jre
2016-08-30 11:33:32,683 INFO [main] zookeeper.ZooKeeper: Client
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15447870#comment-15447870 ] Ted Yu commented on HBASE-16255: Addendum 5 pushed to HBASE-7912 branch. > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2, > 16255.addendum4, 16255.addendum5, HBASE-16255-v1.patch, HBASE-16255-v2.patch, > HBASE-16255-v3.patch, HBASE-16255-v4.patch, HBASE-16255-v5.patch, > HBASE-16255-v6.patch, backup-it-success.out > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[
https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15447437#comment-15447437
]
Dima Spivak commented on HBASE-16255:
-
[~tedyu], did you see my comment above about using {{getDataTestDirOnTestFS}}?
> Backup/Restore IT
> -
>
> Key: HBASE-16255
> URL: https://issues.apache.org/jira/browse/HBASE-16255
> Project: HBase
> Issue Type: Task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Labels: backup
> Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2,
> 16255.addendum4, HBASE-16255-v1.patch, HBASE-16255-v2.patch,
> HBASE-16255-v3.patch, HBASE-16255-v4.patch, HBASE-16255-v5.patch,
> HBASE-16255-v6.patch, backup-it-success.out
>
>
> Integration test for backup restore.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15447426#comment-15447426 ] Ted Yu commented on HBASE-16255: [~dimaspivak]: Mind giving the IT test one more try ? Thanks > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2, > 16255.addendum4, HBASE-16255-v1.patch, HBASE-16255-v2.patch, > HBASE-16255-v3.patch, HBASE-16255-v4.patch, HBASE-16255-v5.patch, > HBASE-16255-v6.patch, backup-it-success.out > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15447009#comment-15447009 ] Dima Spivak commented on HBASE-16255: - [~tedyu], I think you'd be better off using [HBTU.getDataTestDirOnTestFS|https://github.com/apache/hbase/blob/master/hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java#L535] for this instead of rolling your own. (SO to [~mbertozzi] for reminding me what the method was called. :D.) > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2, > 16255.addendum4, HBASE-16255-v1.patch, HBASE-16255-v2.patch, > HBASE-16255-v3.patch, HBASE-16255-v4.patch, HBASE-16255-v5.patch, > HBASE-16255-v6.patch > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[
https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15446622#comment-15446622
]
Ted Yu commented on HBASE-16255:
The cause was likely the following:
{code}
Caused by: org.apache.hadoop.security.AccessControlException: Permission
denied: user=hbase, access=WRITE,
inode="/backupIT/backup_1472488325711/default/IntegrationTestBackupRestore.table1/.hbase-
snapshot/.tmp/snapshot_1472488327003_default_IntegrationTestBackupRestore.table1":hdfs:hdfs:drwxr-xr-x
at
org.apache.hadoop.hdfs.server.namenode.FSPermissionChecker.check(FSPermissionChecker.java:319)
at
org.apache.hadoop.hdfs.server.namenode.FSPermissionChecker.check(FSPermissionChecker.java:292)
at
org.apache.hadoop.hdfs.server.namenode.FSPermissionChecker.checkPermission(FSPermissionChecker.java:213)
{code}
which means that backupIT dir should not have been chosen under the root.
Testing small fix on the cluster now.
> Backup/Restore IT
> -
>
> Key: HBASE-16255
> URL: https://issues.apache.org/jira/browse/HBASE-16255
> Project: HBase
> Issue Type: Task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Labels: backup
> Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2,
> HBASE-16255-v1.patch, HBASE-16255-v2.patch, HBASE-16255-v3.patch,
> HBASE-16255-v4.patch, HBASE-16255-v5.patch, HBASE-16255-v6.patch
>
>
> Integration test for backup restore.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15446374#comment-15446374 ] Ted Yu commented on HBASE-16255: I was able to reproduce what Dima saw in an OpenStack cluster. Investigating ... > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2, > HBASE-16255-v1.patch, HBASE-16255-v2.patch, HBASE-16255-v3.patch, > HBASE-16255-v4.patch, HBASE-16255-v5.patch, HBASE-16255-v6.patch > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[
https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15440274#comment-15440274
]
Dima Spivak commented on HBASE-16255:
-
Yep.
{noformat}
[root@node-1 ~]# yarn version
Hadoop 2.7.1
Subversion https://git-wip-us.apache.org/repos/asf/hadoop.git -r
15ecc87ccf4a0228f35af08fc56de536e6ce657a
Compiled by jenkins on 2015-06-29T06:04Z
Compiled with protoc 2.5.0
>From source with checksum fc0a1a23fc1868e4d5ee7fa2b28a58a
This command was run using /hadoop/share/hadoop/common/hadoop-common-2.7.1.jar
{noformat}
Have you tried running this test on a real cluster? I mentioned earlier that
it's worth doing so before checking in more code.
> Backup/Restore IT
> -
>
> Key: HBASE-16255
> URL: https://issues.apache.org/jira/browse/HBASE-16255
> Project: HBase
> Issue Type: Task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Labels: backup
> Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2,
> HBASE-16255-v1.patch, HBASE-16255-v2.patch, HBASE-16255-v3.patch,
> HBASE-16255-v4.patch, HBASE-16255-v5.patch, HBASE-16255-v6.patch
>
>
> Integration test for backup restore.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15440271#comment-15440271 ] Vladimir Rodionov commented on HBASE-16255: --- [~dspivak], do you run Yarn/MapReduce service? > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2, > HBASE-16255-v1.patch, HBASE-16255-v2.patch, HBASE-16255-v3.patch, > HBASE-16255-v4.patch, HBASE-16255-v5.patch, HBASE-16255-v6.patch > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[
https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15440215#comment-15440215
]
Dima Spivak commented on HBASE-16255:
-
Built a 2-node cluster using the {{apache_hbase}} {{clusterdock}} topology and
HBASE-7912 compiled from source. Upon SSHing, I ran the test and got the
following...
{noformat}
[root@node-1 ~]# hbase org.apache.hadoop.hbase.IntegrationTestBackupRestore
2016-08-26 16:40:12,639 INFO [main] hbase.IntegrationTestBackupRestore: Parsed
Options{regions_per_rs=10, region_servers=2, rows_in_batch=2}
2016-08-26 16:40:12,659 INFO [main] hbase.IntegrationTestBackupRestore:
Initializing cluster with 2 region servers.
2016-08-26 16:40:12,719 WARN [main] util.NativeCodeLoader: Unable to load
native-hadoop library for your platform... using builtin-java classes where
applicable
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in
[jar:file:/hbase/lib/slf4j-log4j12-1.6.1.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in
[jar:file:/hadoop/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
2016-08-26 16:40:12,896 INFO [main] zookeeper.RecoverableZooKeeper: Process
identifier=hconnection-0x5aebe890 connecting to ZooKeeper
ensemble=node-1.cluster:2181
2016-08-26 16:40:12,901 INFO [main] zookeeper.ZooKeeper: Client
environment:zookeeper.version=3.4.6-1569965, built on 02/20/2014 09:09 GMT
2016-08-26 16:40:12,901 INFO [main] zookeeper.ZooKeeper: Client
environment:host.name=node-1.cluster
2016-08-26 16:40:12,901 INFO [main] zookeeper.ZooKeeper: Client
environment:java.version=1.8.0_91
2016-08-26 16:40:12,901 INFO [main] zookeeper.ZooKeeper: Client
environment:java.vendor=Oracle Corporation
2016-08-26 16:40:12,905 INFO [main] zookeeper.ZooKeeper: Client
environment:java.home=/java/jre
2016-08-26 16:40:12,906 INFO [main] zookeeper.ZooKeeper: Client
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15440175#comment-15440175 ] Ted Yu commented on HBASE-16255: Pushed to HBASE-7912 branch. > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: 16255-addendum.3.txt, 16255.addendum, 16255.addendum2, > HBASE-16255-v1.patch, HBASE-16255-v2.patch, HBASE-16255-v3.patch, > HBASE-16255-v4.patch, HBASE-16255-v5.patch, HBASE-16255-v6.patch > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[
https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439561#comment-15439561
]
Dima Spivak commented on HBASE-16255:
-
Switched to a 6-node cluster. Now getting this error:
{noformat}
[root@node-1 ~]# hbase org.apache.hadoop.hbase.IntegrationTestBackupRestore
2016-08-26 11:50:03,135 INFO [main] hbase.IntegrationTestBackupRestore: Parsed
Options{regions_per_rs=10, region_servers=5, rows_in_batch=2}
2016-08-26 11:50:03,160 INFO [main] hbase.IntegrationTestBackupRestore:
Initializing cluster with 5 region servers.
2016-08-26 11:50:03,215 WARN [main] util.NativeCodeLoader: Unable to load
native-hadoop library for your platform... using builtin-java classes where
applicable
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in
[jar:file:/hbase/lib/slf4j-log4j12-1.6.1.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in
[jar:file:/hadoop/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
2016-08-26 11:50:03,375 INFO [main] zookeeper.RecoverableZooKeeper: Process
identifier=hconnection-0x5aebe890 connecting to ZooKeeper
ensemble=node-1.cluster:2181
2016-08-26 11:50:03,380 INFO [main] zookeeper.ZooKeeper: Client
environment:zookeeper.version=3.4.6-1569965, built on 02/20/2014 09:09 GMT
2016-08-26 11:50:03,380 INFO [main] zookeeper.ZooKeeper: Client
environment:host.name=node-1.cluster
2016-08-26 11:50:03,380 INFO [main] zookeeper.ZooKeeper: Client
environment:java.version=1.8.0_91
2016-08-26 11:50:03,380 INFO [main] zookeeper.ZooKeeper: Client
environment:java.vendor=Oracle Corporation
2016-08-26 11:50:03,384 INFO [main] zookeeper.ZooKeeper: Client
environment:java.home=/java/jre
2016-08-26 11:50:03,385 INFO [main] zookeeper.ZooKeeper: Client
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[
https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439556#comment-15439556
]
Dima Spivak commented on HBASE-16255:
-
Tried the new revision of the branch and got
{noformat}
2016-08-26 11:46:48,357 ERROR [main] util.AbstractHBaseTool: Error running
command-line tool
java.lang.Exception: Cluster does not have enough nodes:5
at
org.apache.hadoop.hbase.IntegrationTestingUtility.checkNodeCount(IntegrationTestingUtility.java:89)
at
org.apache.hadoop.hbase.IntegrationTestingUtility.initializeCluster(IntegrationTestingUtility.java:76)
at
org.apache.hadoop.hbase.IntegrationTestBackupRestore.setUp(IntegrationTestBackupRestore.java:90)
at
org.apache.hadoop.hbase.IntegrationTestBase.doWork(IntegrationTestBase.java:120)
at
org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:112)
at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
at
org.apache.hadoop.hbase.IntegrationTestBackupRestore.main(IntegrationTestBackupRestore.java:288)
{noformat}
Is there a good reason for requiring a 5-RS cluster to test this feature? If
not, please change this to a lower value.
> Backup/Restore IT
> -
>
> Key: HBASE-16255
> URL: https://issues.apache.org/jira/browse/HBASE-16255
> Project: HBase
> Issue Type: Task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Labels: backup
> Attachments: 16255.addendum, 16255.addendum2, HBASE-16255-v1.patch,
> HBASE-16255-v2.patch, HBASE-16255-v3.patch, HBASE-16255-v4.patch,
> HBASE-16255-v5.patch, HBASE-16255-v6.patch
>
>
> Integration test for backup restore.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438221#comment-15438221 ] Ted Yu commented on HBASE-16255: Pushed addendum v2. [~dimaspivak]: Mind giving it a second shot ? Thanks > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: 16255.addendum, 16255.addendum2, HBASE-16255-v1.patch, > HBASE-16255-v2.patch, HBASE-16255-v3.patch, HBASE-16255-v4.patch, > HBASE-16255-v5.patch, HBASE-16255-v6.patch > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438200#comment-15438200 ] Vladimir Rodionov commented on HBASE-16255: --- Looks good to me. > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: 16255.addendum, HBASE-16255-v1.patch, > HBASE-16255-v2.patch, HBASE-16255-v3.patch, HBASE-16255-v4.patch, > HBASE-16255-v5.patch, HBASE-16255-v6.patch > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438145#comment-15438145 ] Vladimir Rodionov commented on HBASE-16255: --- Sorry about that. Fix will follow shortly. > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: HBASE-16255-v1.patch, HBASE-16255-v2.patch, > HBASE-16255-v3.patch, HBASE-16255-v4.patch, HBASE-16255-v5.patch, > HBASE-16255-v6.patch > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[
https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437843#comment-15437843
]
Dima Spivak commented on HBASE-16255:
-
Well that was quick... Built a {{clusterdock}} cluster from the source code of
{{HBASE-7912}}. Started it, SSHed in, and then tried running the test:
{noformat}
[root@node-1 ~]# hbase org.apache.hadoop.hbase.IntegrationTestBackupRestore
Exception in thread "main" java.lang.IllegalArgumentException: opt contains
illegal character value '.'
at
org.apache.commons.cli.OptionValidator.validateOption(OptionValidator.java:73)
at org.apache.commons.cli.Option.(Option.java:123)
at org.apache.commons.cli.Options.addOption(Options.java:131)
at org.apache.commons.cli.Options.addOption(Options.java:114)
at
org.apache.hadoop.hbase.util.AbstractHBaseTool.addOptWithArg(AbstractHBaseTool.java:168)
at
org.apache.hadoop.hbase.IntegrationTestBackupRestore.addOptions(IntegrationTestBackupRestore.java:262)
at
org.apache.hadoop.hbase.util.AbstractHBaseTool.parseArgs(AbstractHBaseTool.java:133)
at
org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:94)
at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
at
org.apache.hadoop.hbase.IntegrationTestBackupRestore.main(IntegrationTestBackupRestore.java:290)
{noformat}
> Backup/Restore IT
> -
>
> Key: HBASE-16255
> URL: https://issues.apache.org/jira/browse/HBASE-16255
> Project: HBase
> Issue Type: Task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Labels: backup
> Attachments: HBASE-16255-v1.patch, HBASE-16255-v2.patch,
> HBASE-16255-v3.patch, HBASE-16255-v4.patch, HBASE-16255-v5.patch,
> HBASE-16255-v6.patch
>
>
> Integration test for backup restore.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[
https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437685#comment-15437685
]
Dima Spivak commented on HBASE-16255:
-
Hey [~tedyu], I haven't had a chance, sorry. I see that it got integrated into
the {{HBASE-7912}} branch, though, so lemme give it a shot now. I'll report
back shortly...
> Backup/Restore IT
> -
>
> Key: HBASE-16255
> URL: https://issues.apache.org/jira/browse/HBASE-16255
> Project: HBase
> Issue Type: Task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Labels: backup
> Attachments: HBASE-16255-v1.patch, HBASE-16255-v2.patch,
> HBASE-16255-v3.patch, HBASE-16255-v4.patch, HBASE-16255-v5.patch,
> HBASE-16255-v6.patch
>
>
> Integration test for backup restore.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437654#comment-15437654 ] Ted Yu commented on HBASE-16255: [~dimaspivak]: Did you have a chance to run the IT test ? Thanks > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: HBASE-16255-v1.patch, HBASE-16255-v2.patch, > HBASE-16255-v3.patch, HBASE-16255-v4.patch, HBASE-16255-v5.patch, > HBASE-16255-v6.patch > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15431975#comment-15431975 ] Ted Yu commented on HBASE-16255: Thanks for the review, Dima. > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: HBASE-16255-v1.patch, HBASE-16255-v2.patch, > HBASE-16255-v3.patch, HBASE-16255-v4.patch, HBASE-16255-v5.patch, > HBASE-16255-v6.patch > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15431356#comment-15431356 ] Dima Spivak commented on HBASE-16255: - Just did one last go through and it looks great to me except for a handful of minor fixes. Thanks again for taking this on, [~vrodionov]; it makes feature merges much less contentious to have solid automation like this to demonstrate functionality. > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: HBASE-16255-v1.patch, HBASE-16255-v2.patch, > HBASE-16255-v3.patch, HBASE-16255-v4.patch, HBASE-16255-v5.patch > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15431162#comment-15431162 ] Ted Yu commented on HBASE-16255: [~dspivak]: Do you have any further comment ? > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: HBASE-16255-v1.patch, HBASE-16255-v2.patch, > HBASE-16255-v3.patch, HBASE-16255-v4.patch, HBASE-16255-v5.patch > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421951#comment-15421951 ] Dima Spivak commented on HBASE-16255: - Sure, [~vrodionov], let me take a look first thing in the morning. > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: HBASE-16255-v1.patch, HBASE-16255-v2.patch, > HBASE-16255-v3.patch, HBASE-16255-v4.patch > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421891#comment-15421891 ] Vladimir Rodionov commented on HBASE-16255: --- [~dimaspivak], can review the last patch? > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: HBASE-16255-v1.patch, HBASE-16255-v2.patch, > HBASE-16255-v3.patch, HBASE-16255-v4.patch > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418092#comment-15418092 ] Dima Spivak commented on HBASE-16255: - Reviewed! > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: HBASE-16255-v1.patch, HBASE-16255-v2.patch, > HBASE-16255-v3.patch > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417804#comment-15417804 ] Vladimir Rodionov commented on HBASE-16255: --- Here it is: https://reviews.apache.org/r/51003/ > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: HBASE-16255-v1.patch, HBASE-16255-v2.patch, > HBASE-16255-v3.patch > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417722#comment-15417722 ] Dima Spivak commented on HBASE-16255: - [~vrodionov] could you please upload the patch to RB? I have some minor comments and it's a pain to make them here on JIRA. I'll also get a run of this underway today and then +1 it on my end. Thanks so much for doing this! > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: HBASE-16255-v1.patch, HBASE-16255-v2.patch, > HBASE-16255-v3.patch > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417673#comment-15417673 ] Ted Yu commented on HBASE-16255: [~dimaspivak]: Is patch v3 good by you ? > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: HBASE-16255-v1.patch, HBASE-16255-v2.patch, > HBASE-16255-v3.patch > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414103#comment-15414103 ] Dima Spivak commented on HBASE-16255: - I'd prefer to not disable using monkeys and just specify in our release notes that it hasn't been subject to fault injection testing. What inevitably happens if we disable it in code is that we forget to enable it once things improve :). > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: HBASE-16255-v1.patch, HBASE-16255-v2.patch > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[
https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412242#comment-15412242
]
Dima Spivak commented on HBASE-16255:
-
Yay! Thanks for putting this together, [~vrodionov]; I'll take a look later
today. As for expectations, I was curious to see how it behaves with fault
injection. To get monkeys working, you'd just need to have your
{{IntegrationTestBackupRestore}} extend {{IntegrationTestBase}} (see:
[IntegrationTestAcidGuarantees|https://github.com/apache/hbase/blob/master/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestAcidGuarantees.java#L44])
and then you'd get access to all the fun monkey options.
> Backup/Restore IT
> -
>
> Key: HBASE-16255
> URL: https://issues.apache.org/jira/browse/HBASE-16255
> Project: HBase
> Issue Type: Task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Labels: backup
> Attachments: HBASE-16255-v1.patch
>
>
> Integration test for backup restore.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412233#comment-15412233 ] Vladimir Rodionov commented on HBASE-16255: --- [~dimaspivak], What do you expect to see in this IT? I do not think we are ready to run IT with chaos monkey yet, taking into account that there is no IT for snapshots and backup are based on snapshots. So, no monkey. > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: HBASE-16255-v1.patch > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[ https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410458#comment-15410458 ] Ted Yu commented on HBASE-16255: [~dimaspivak]: Mind taking a look as well ? > Backup/Restore IT > - > > Key: HBASE-16255 > URL: https://issues.apache.org/jira/browse/HBASE-16255 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: HBASE-16255-v1.patch > > > Integration test for backup restore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16255) Backup/Restore IT
[
https://issues.apache.org/jira/browse/HBASE-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410457#comment-15410457
]
Ted Yu commented on HBASE-16255:
{code}
+public class IntegrationTestBackupRestore {
{code}
Should the test extend IntegrationTestBase ?
{code}
+ protected static final TableName TABLE_NAME = TableName.valueOf(CLASS_NAME);
+ protected static final TableName TABLE_NAME_RESTORE =
TableName.valueOf(CLASS_NAME);
{code}
Should the table to restore to have different name ?
{code}
+ protected static final int DEFAULT_REGIONSERVER_COUNT = 2;
{code}
Please increase the number of region servers.
{code}
+// #6 - restore incremental backup for multiple tables, with overwrite
{code}
Did you intend to involve more than one table ?
Currently only one table is backed up.
> Backup/Restore IT
> -
>
> Key: HBASE-16255
> URL: https://issues.apache.org/jira/browse/HBASE-16255
> Project: HBase
> Issue Type: Task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Labels: backup
> Attachments: HBASE-16255-v1.patch
>
>
> Integration test for backup restore.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
