[jira] [Commented] (HBASE-16303) FilterList with MUST_PASS_ONE optimization
[ https://issues.apache.org/jira/browse/HBASE-16303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15595972#comment-15595972 ] Mikhail Antonov commented on HBASE-16303: - [~ram_krish] I'm going to actually marked the fix Version as 1.3.0 as the commit did went in, and the git history and jira states shall remain in sync > FilterList with MUST_PASS_ONE optimization > -- > > Key: HBASE-16303 > URL: https://issues.apache.org/jira/browse/HBASE-16303 > Project: HBase > Issue Type: Bug > Components: Filters >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-16303.patch, HBASE-16303.patch, > HBASE-16303_1.patch, HBASE-16303_1.patch > > > This JIRA was created to add @Test tag for all the filter related tests. > After doing that one such test failed in > TestFilterList#testFilterListTwoFiltersMustPassOne. > The test assumes that when a PrefixFilter is added to a filterlist once the > given prefix is passed we should SKIP all other rows. But the impl in > FilterList for MUST_PASS_ONE filter is such that once the filter in the list > sees that filterAllRemaining is true we don't use that to decide if to to > SEE_NEXT_USING_HINT or not. This patch tries to handle that case where if for > a filter FilterAllRemaining is true then SEEK_NEXT_USING_HINT need not be > done. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16303) FilterList with MUST_PASS_ONE optimization
[ https://issues.apache.org/jira/browse/HBASE-16303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411247#comment-15411247 ] ramkrishna.s.vasudevan commented on HBASE-16303: I am not marking this JIRA for 1.3.0 because it means we only have @Test tag added to the tests. > FilterList with MUST_PASS_ONE optimization > -- > > Key: HBASE-16303 > URL: https://issues.apache.org/jira/browse/HBASE-16303 > Project: HBase > Issue Type: Bug > Components: Filters >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0 > > Attachments: HBASE-16303.patch, HBASE-16303.patch, > HBASE-16303_1.patch, HBASE-16303_1.patch > > > This JIRA was created to add @Test tag for all the filter related tests. > After doing that one such test failed in > TestFilterList#testFilterListTwoFiltersMustPassOne. > The test assumes that when a PrefixFilter is added to a filterlist once the > given prefix is passed we should SKIP all other rows. But the impl in > FilterList for MUST_PASS_ONE filter is such that once the filter in the list > sees that filterAllRemaining is true we don't use that to decide if to to > SEE_NEXT_USING_HINT or not. This patch tries to handle that case where if for > a filter FilterAllRemaining is true then SEEK_NEXT_USING_HINT need not be > done. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16303) FilterList with MUST_PASS_ONE optimization
[ https://issues.apache.org/jira/browse/HBASE-16303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411246#comment-15411246 ] ramkrishna.s.vasudevan commented on HBASE-16303: bq.please check compilation before committing. This is the most basic of checks a committer can do. It shouldn't be necessary to ask! Sorry about this. I should not have done that. Will see to that I compile the code before committing. I expected this bug to be in latest branch-1. And hence in branch-1.3 also. My bad. The addendum was not necessary there only the patch would have been enough. Thanks [~busbey] - And sorry for the trouble. > FilterList with MUST_PASS_ONE optimization > -- > > Key: HBASE-16303 > URL: https://issues.apache.org/jira/browse/HBASE-16303 > Project: HBase > Issue Type: Bug > Components: Filters >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0 > > Attachments: HBASE-16303.patch, HBASE-16303.patch, > HBASE-16303_1.patch, HBASE-16303_1.patch > > > This JIRA was created to add @Test tag for all the filter related tests. > After doing that one such test failed in > TestFilterList#testFilterListTwoFiltersMustPassOne. > The test assumes that when a PrefixFilter is added to a filterlist once the > given prefix is passed we should SKIP all other rows. But the impl in > FilterList for MUST_PASS_ONE filter is such that once the filter in the list > sees that filterAllRemaining is true we don't use that to decide if to to > SEE_NEXT_USING_HINT or not. This patch tries to handle that case where if for > a filter FilterAllRemaining is true then SEEK_NEXT_USING_HINT need not be > done. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16303) FilterList with MUST_PASS_ONE optimization
[ https://issues.apache.org/jira/browse/HBASE-16303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411034#comment-15411034 ] Andrew Purtell commented on HBASE-16303: [~ramkrishna.s.vasude...@gmail.com], please check *compilation* before committing. This is the most basic of checks a committer can do. It shouldn't be necessary to ask! > FilterList with MUST_PASS_ONE optimization > -- > > Key: HBASE-16303 > URL: https://issues.apache.org/jira/browse/HBASE-16303 > Project: HBase > Issue Type: Bug > Components: Filters >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-16303.patch, HBASE-16303.patch, > HBASE-16303_1.patch, HBASE-16303_1.patch > > > This JIRA was created to add @Test tag for all the filter related tests. > After doing that one such test failed in > TestFilterList#testFilterListTwoFiltersMustPassOne. > The test assumes that when a PrefixFilter is added to a filterlist once the > given prefix is passed we should SKIP all other rows. But the impl in > FilterList for MUST_PASS_ONE filter is such that once the filter in the list > sees that filterAllRemaining is true we don't use that to decide if to to > SEE_NEXT_USING_HINT or not. This patch tries to handle that case where if for > a filter FilterAllRemaining is true then SEEK_NEXT_USING_HINT need not be > done. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16303) FilterList with MUST_PASS_ONE optimization
[ https://issues.apache.org/jira/browse/HBASE-16303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410391#comment-15410391 ] Hudson commented on HBASE-16303: FAILURE: Integrated in HBase-1.3 #810 (See [https://builds.apache.org/job/HBase-1.3/810/]) Revert "HBASE-16303 Addendum as the wrong patch was committed" (busbey: rev 76658440dfaddde890a216c8247855182a6c9ac5) * hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterList.java > FilterList with MUST_PASS_ONE optimization > -- > > Key: HBASE-16303 > URL: https://issues.apache.org/jira/browse/HBASE-16303 > Project: HBase > Issue Type: Bug > Components: Filters >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-16303.patch, HBASE-16303.patch, > HBASE-16303_1.patch, HBASE-16303_1.patch > > > This JIRA was created to add @Test tag for all the filter related tests. > After doing that one such test failed in > TestFilterList#testFilterListTwoFiltersMustPassOne. > The test assumes that when a PrefixFilter is added to a filterlist once the > given prefix is passed we should SKIP all other rows. But the impl in > FilterList for MUST_PASS_ONE filter is such that once the filter in the list > sees that filterAllRemaining is true we don't use that to decide if to to > SEE_NEXT_USING_HINT or not. This patch tries to handle that case where if for > a filter FilterAllRemaining is true then SEEK_NEXT_USING_HINT need not be > done. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16303) FilterList with MUST_PASS_ONE optimization
[ https://issues.apache.org/jira/browse/HBASE-16303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410250#comment-15410250 ] Hudson commented on HBASE-16303: SUCCESS: Integrated in HBase-1.3-IT #782 (See [https://builds.apache.org/job/HBase-1.3-IT/782/]) Revert "HBASE-16303 Addendum as the wrong patch was committed" (busbey: rev 76658440dfaddde890a216c8247855182a6c9ac5) * hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterList.java > FilterList with MUST_PASS_ONE optimization > -- > > Key: HBASE-16303 > URL: https://issues.apache.org/jira/browse/HBASE-16303 > Project: HBase > Issue Type: Bug > Components: Filters >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-16303.patch, HBASE-16303.patch, > HBASE-16303_1.patch, HBASE-16303_1.patch > > > This JIRA was created to add @Test tag for all the filter related tests. > After doing that one such test failed in > TestFilterList#testFilterListTwoFiltersMustPassOne. > The test assumes that when a PrefixFilter is added to a filterlist once the > given prefix is passed we should SKIP all other rows. But the impl in > FilterList for MUST_PASS_ONE filter is such that once the filter in the list > sees that filterAllRemaining is true we don't use that to decide if to to > SEE_NEXT_USING_HINT or not. This patch tries to handle that case where if for > a filter FilterAllRemaining is true then SEEK_NEXT_USING_HINT need not be > done. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16303) FilterList with MUST_PASS_ONE optimization
[
https://issues.apache.org/jira/browse/HBASE-16303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409854#comment-15409854
]
Sean Busbey commented on HBASE-16303:
-
{quote}
bq. unnecessary results retrieved, but not returned incorrectly? what happens
without the fix, incorrect results?
In the actual case I don't think it will produce wrong results, but may be
unnecessary iterations. I can verify that if needed.
{quote}
Thanks! returning correct results or not is how I'd differentiate between this
being an improvement (and thus only needed on 1.3+) vs a bug (and thus needed
on all branches).
> FilterList with MUST_PASS_ONE optimization
> --
>
> Key: HBASE-16303
> URL: https://issues.apache.org/jira/browse/HBASE-16303
> Project: HBase
> Issue Type: Bug
> Components: Filters
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-16303.patch, HBASE-16303.patch,
> HBASE-16303_1.patch, HBASE-16303_1.patch
>
>
> This JIRA was created to add @Test tag for all the filter related tests.
> After doing that one such test failed in
> TestFilterList#testFilterListTwoFiltersMustPassOne.
> The test assumes that when a PrefixFilter is added to a filterlist once the
> given prefix is passed we should SKIP all other rows. But the impl in
> FilterList for MUST_PASS_ONE filter is such that once the filter in the list
> sees that filterAllRemaining is true we don't use that to decide if to to
> SEE_NEXT_USING_HINT or not. This patch tries to handle that case where if for
> a filter FilterAllRemaining is true then SEEK_NEXT_USING_HINT need not be
> done.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16303) FilterList with MUST_PASS_ONE optimization
[ https://issues.apache.org/jira/browse/HBASE-16303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409774#comment-15409774 ] Hudson commented on HBASE-16303: FAILURE: Integrated in HBase-1.4 #334 (See [https://builds.apache.org/job/HBase-1.4/334/]) HBASE-16303 FilterList with MUST_PASS_ONE optimization (Ram) (ramkrishna: rev 6278ece8b6cbe3fae0e8618dd25ab03533113095) * hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilter.java * hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java HBASE-16303 Addendum as the wrong patch was committed (ramkrishna: rev 7a62076ae45ad91a20df66528d8b5cd09a0e4251) * hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterList.java > FilterList with MUST_PASS_ONE optimization > -- > > Key: HBASE-16303 > URL: https://issues.apache.org/jira/browse/HBASE-16303 > Project: HBase > Issue Type: Bug > Components: Filters >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-16303.patch, HBASE-16303.patch, > HBASE-16303_1.patch, HBASE-16303_1.patch > > > This JIRA was created to add @Test tag for all the filter related tests. > After doing that one such test failed in > TestFilterList#testFilterListTwoFiltersMustPassOne. > The test assumes that when a PrefixFilter is added to a filterlist once the > given prefix is passed we should SKIP all other rows. But the impl in > FilterList for MUST_PASS_ONE filter is such that once the filter in the list > sees that filterAllRemaining is true we don't use that to decide if to to > SEE_NEXT_USING_HINT or not. This patch tries to handle that case where if for > a filter FilterAllRemaining is true then SEEK_NEXT_USING_HINT need not be > done. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16303) FilterList with MUST_PASS_ONE optimization
[ https://issues.apache.org/jira/browse/HBASE-16303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409754#comment-15409754 ] ramkrishna.s.vasudevan commented on HBASE-16303: bq.unnecessary results retrieved, but not returned incorrectly? what happens without the fix, incorrect results? In the actual case I don't think it will produce wrong results, but may be unnecessary iterations. I can verify that if needed. > FilterList with MUST_PASS_ONE optimization > -- > > Key: HBASE-16303 > URL: https://issues.apache.org/jira/browse/HBASE-16303 > Project: HBase > Issue Type: Bug > Components: Filters >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-16303.patch, HBASE-16303.patch, > HBASE-16303_1.patch, HBASE-16303_1.patch > > > This JIRA was created to add @Test tag for all the filter related tests. > After doing that one such test failed in > TestFilterList#testFilterListTwoFiltersMustPassOne. > The test assumes that when a PrefixFilter is added to a filterlist once the > given prefix is passed we should SKIP all other rows. But the impl in > FilterList for MUST_PASS_ONE filter is such that once the filter in the list > sees that filterAllRemaining is true we don't use that to decide if to to > SEE_NEXT_USING_HINT or not. This patch tries to handle that case where if for > a filter FilterAllRemaining is true then SEEK_NEXT_USING_HINT need not be > done. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16303) FilterList with MUST_PASS_ONE optimization
[ https://issues.apache.org/jira/browse/HBASE-16303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409536#comment-15409536 ] Hudson commented on HBASE-16303: FAILURE: Integrated in HBase-1.3-IT #781 (See [https://builds.apache.org/job/HBase-1.3-IT/781/]) HBASE-16303 Addendum as the wrong patch was committed (ramkrishna: rev c5183b83b451b1cc46652e9880d60249165874b1) * hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterList.java > FilterList with MUST_PASS_ONE optimization > -- > > Key: HBASE-16303 > URL: https://issues.apache.org/jira/browse/HBASE-16303 > Project: HBase > Issue Type: Bug > Components: Filters >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-16303.patch, HBASE-16303.patch, > HBASE-16303_1.patch, HBASE-16303_1.patch > > > This JIRA was created to add @Test tag for all the filter related tests. > After doing that one such test failed in > TestFilterList#testFilterListTwoFiltersMustPassOne. > The test assumes that when a PrefixFilter is added to a filterlist once the > given prefix is passed we should SKIP all other rows. But the impl in > FilterList for MUST_PASS_ONE filter is such that once the filter in the list > sees that filterAllRemaining is true we don't use that to decide if to to > SEE_NEXT_USING_HINT or not. This patch tries to handle that case where if for > a filter FilterAllRemaining is true then SEEK_NEXT_USING_HINT need not be > done. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16303) FilterList with MUST_PASS_ONE optimization
[ https://issues.apache.org/jira/browse/HBASE-16303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409463#comment-15409463 ] Sean Busbey commented on HBASE-16303: - unnecessary results retrieved, but not returned incorrectly? what happens without the fix, incorrect results? > FilterList with MUST_PASS_ONE optimization > -- > > Key: HBASE-16303 > URL: https://issues.apache.org/jira/browse/HBASE-16303 > Project: HBase > Issue Type: Bug > Components: Filters >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-16303.patch, HBASE-16303.patch, > HBASE-16303_1.patch, HBASE-16303_1.patch > > > This JIRA was created to add @Test tag for all the filter related tests. > After doing that one such test failed in > TestFilterList#testFilterListTwoFiltersMustPassOne. > The test assumes that when a PrefixFilter is added to a filterlist once the > given prefix is passed we should SKIP all other rows. But the impl in > FilterList for MUST_PASS_ONE filter is such that once the filter in the list > sees that filterAllRemaining is true we don't use that to decide if to to > SEE_NEXT_USING_HINT or not. This patch tries to handle that case where if for > a filter FilterAllRemaining is true then SEEK_NEXT_USING_HINT need not be > done. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16303) FilterList with MUST_PASS_ONE optimization
[ https://issues.apache.org/jira/browse/HBASE-16303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409347#comment-15409347 ] Hudson commented on HBASE-16303: SUCCESS: Integrated in HBase-Trunk_matrix #1358 (See [https://builds.apache.org/job/HBase-Trunk_matrix/1358/]) HBASE-16303 FilterList with MUST_PASS_ONE optimization (Ram) (ramkrishna: rev 19c609fa5e2624e537a445d9204f06e56ae782c2) * hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilter.java * hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java HBASE-16303 Addendum as the wrong patch was committed (ramkrishna: rev e8f08ba0c7949edb4bc349718d2d6532be2f2360) * hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterList.java > FilterList with MUST_PASS_ONE optimization > -- > > Key: HBASE-16303 > URL: https://issues.apache.org/jira/browse/HBASE-16303 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-16303.patch, HBASE-16303.patch, > HBASE-16303_1.patch, HBASE-16303_1.patch > > > This JIRA was created to add @Test tag for all the filter related tests. > After doing that one such test failed in > TestFilterList#testFilterListTwoFiltersMustPassOne. > The test assumes that when a PrefixFilter is added to a filterlist once the > given prefix is passed we should SKIP all other rows. But the impl in > FilterList for MUST_PASS_ONE filter is such that once the filter in the list > sees that filterAllRemaining is true we don't use that to decide if to to > SEE_NEXT_USING_HINT or not. This patch tries to handle that case where if for > a filter FilterAllRemaining is true then SEEK_NEXT_USING_HINT need not be > done. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16303) FilterList with MUST_PASS_ONE optimization
[ https://issues.apache.org/jira/browse/HBASE-16303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409001#comment-15409001 ] Hudson commented on HBASE-16303: SUCCESS: Integrated in HBase-1.3-IT #779 (See [https://builds.apache.org/job/HBase-1.3-IT/779/]) HBASE-16303 FilterList with MUST_PASS_ONE optimization (Ram) (ramkrishna: rev 8570e7f8dbfb42bcb686953fbb4eadac860eeb21) * hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilter.java * hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java > FilterList with MUST_PASS_ONE optimization > -- > > Key: HBASE-16303 > URL: https://issues.apache.org/jira/browse/HBASE-16303 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-16303.patch, HBASE-16303.patch, > HBASE-16303_1.patch, HBASE-16303_1.patch > > > This JIRA was created to add @Test tag for all the filter related tests. > After doing that one such test failed in > TestFilterList#testFilterListTwoFiltersMustPassOne. > The test assumes that when a PrefixFilter is added to a filterlist once the > given prefix is passed we should SKIP all other rows. But the impl in > FilterList for MUST_PASS_ONE filter is such that once the filter in the list > sees that filterAllRemaining is true we don't use that to decide if to to > SEE_NEXT_USING_HINT or not. This patch tries to handle that case where if for > a filter FilterAllRemaining is true then SEEK_NEXT_USING_HINT need not be > done. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16303) FilterList with MUST_PASS_ONE optimization
[ https://issues.apache.org/jira/browse/HBASE-16303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407218#comment-15407218 ] ramkrishna.s.vasudevan commented on HBASE-16303: Will commit this patch later today if there are no objections. > FilterList with MUST_PASS_ONE optimization > -- > > Key: HBASE-16303 > URL: https://issues.apache.org/jira/browse/HBASE-16303 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 1.1.5, 1.2.2, 0.98.20 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 1.3.0, 1.0.4, 1.1.6, 0.98.21 > > Attachments: HBASE-16303.patch, HBASE-16303.patch, > HBASE-16303_1.patch, HBASE-16303_1.patch > > > This JIRA was created to add @Test tag for all the filter related tests. > After doing that one such test failed in > TestFilterList#testFilterListTwoFiltersMustPassOne. > The test assumes that when a PrefixFilter is added to a filterlist once the > given prefix is passed we should SKIP all other rows. But the impl in > FilterList for MUST_PASS_ONE filter is such that once the filter in the list > sees that filterAllRemaining is true we don't use that to decide if to to > SEE_NEXT_USING_HINT or not. This patch tries to handle that case where if for > a filter FilterAllRemaining is true then SEEK_NEXT_USING_HINT need not be > done. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16303) FilterList with MUST_PASS_ONE optimization
[ https://issues.apache.org/jira/browse/HBASE-16303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404648#comment-15404648 ] Ted Yu commented on HBASE-16303: lgtm > FilterList with MUST_PASS_ONE optimization > -- > > Key: HBASE-16303 > URL: https://issues.apache.org/jira/browse/HBASE-16303 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 1.1.5, 1.2.2, 0.98.20 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 1.3.0, 1.0.4, 1.1.6, 0.98.21 > > Attachments: HBASE-16303.patch, HBASE-16303.patch, > HBASE-16303_1.patch, HBASE-16303_1.patch > > > This JIRA was created to add @Test tag for all the filter related tests. > After doing that one such test failed in > TestFilterList#testFilterListTwoFiltersMustPassOne. > The test assumes that when a PrefixFilter is added to a filterlist once the > given prefix is passed we should SKIP all other rows. But the impl in > FilterList for MUST_PASS_ONE filter is such that once the filter in the list > sees that filterAllRemaining is true we don't use that to decide if to to > SEE_NEXT_USING_HINT or not. This patch tries to handle that case where if for > a filter FilterAllRemaining is true then SEEK_NEXT_USING_HINT need not be > done. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16303) FilterList with MUST_PASS_ONE optimization
[
https://issues.apache.org/jira/browse/HBASE-16303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403664#comment-15403664
]
Hadoop QA commented on HBASE-16303:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 31s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
31s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 2s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 55s
{color} | {color:green} master passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
50s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
35s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
58s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 51s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 52s
{color} | {color:green} master passed with JDK v1.7.0_80 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
8s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 7s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 7s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 55s
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 55s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
50s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
34s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
32m 14s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
31s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 52s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 53s
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 59s
{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 115m 42s
{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
32s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 173m 18s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures |
| Timed out junit tests | org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12821513/HBASE-16303_1.patch |
| JIRA Issue | HBASE-16303 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle
[jira] [Commented] (HBASE-16303) FilterList with MUST_PASS_ONE optimization
[ https://issues.apache.org/jira/browse/HBASE-16303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403634#comment-15403634 ] ramkrishna.s.vasudevan commented on HBASE-16303: The purpose of this JIRA was to only add @Test tag for all the filter tests. Later found a bug by doing so. So updated the title but forgot adding description. Now added it. > FilterList with MUST_PASS_ONE optimization > -- > > Key: HBASE-16303 > URL: https://issues.apache.org/jira/browse/HBASE-16303 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 1.1.5, 1.2.2, 0.98.20 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 1.3.0, 1.0.4, 1.1.6, 0.98.21 > > Attachments: HBASE-16303.patch, HBASE-16303.patch, > HBASE-16303_1.patch, HBASE-16303_1.patch > > > This JIRA was created to add @Test tag for all the filter related tests. > After doing that one such test failed in > TestFilterList#testFilterListTwoFiltersMustPassOne. > The test assumes that when a PrefixFilter is added to a filterlist once the > given prefix is passed we should SKIP all other rows. But the impl in > FilterList for MUST_PASS_ONE filter is such that once the filter in the list > sees that filterAllRemaining is true we don't use that to decide if to to > SEE_NEXT_USING_HINT or not. This patch tries to handle that case where if for > a filter FilterAllRemaining is true then SEEK_NEXT_USING_HINT need not be > done. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16303) FilterList with MUST_PASS_ONE optimization
[ https://issues.apache.org/jira/browse/HBASE-16303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403581#comment-15403581 ] Anoop Sam John commented on HBASE-16303: What is it doing Ram? Add some description? > FilterList with MUST_PASS_ONE optimization > -- > > Key: HBASE-16303 > URL: https://issues.apache.org/jira/browse/HBASE-16303 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 1.1.5, 1.2.2, 0.98.20 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 1.3.0, 1.0.4, 1.1.6, 0.98.21 > > Attachments: HBASE-16303.patch, HBASE-16303.patch, > HBASE-16303_1.patch, HBASE-16303_1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16303) FilterList with MUST_PASS_ONE optimization
[ https://issues.apache.org/jira/browse/HBASE-16303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403554#comment-15403554 ] ramkrishna.s.vasudevan commented on HBASE-16303: Ping - [~lhofhansl], [~tedyu], [~anoop.hbase]. > FilterList with MUST_PASS_ONE optimization > -- > > Key: HBASE-16303 > URL: https://issues.apache.org/jira/browse/HBASE-16303 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 1.1.5, 1.2.2, 0.98.20 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 1.3.0, 1.0.4, 1.1.6, 0.98.21 > > Attachments: HBASE-16303.patch, HBASE-16303.patch, > HBASE-16303_1.patch, HBASE-16303_1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16303) FilterList with MUST_PASS_ONE optimization
[ https://issues.apache.org/jira/browse/HBASE-16303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403421#comment-15403421 ] ramkrishna.s.vasudevan commented on HBASE-16303: Build failed due to insufficient memory. > FilterList with MUST_PASS_ONE optimization > -- > > Key: HBASE-16303 > URL: https://issues.apache.org/jira/browse/HBASE-16303 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 1.1.5, 1.2.2, 0.98.20 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0, 1.3.0, 1.0.4, 1.1.6, 0.98.21 > > Attachments: HBASE-16303.patch, HBASE-16303.patch, HBASE-16303_1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16303) FilterList with MUST_PASS_ONE optimization
[
https://issues.apache.org/jira/browse/HBASE-16303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403410#comment-15403410
]
Hadoop QA commented on HBASE-16303:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
1s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 22s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
0s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 2s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 1s
{color} | {color:green} master passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
54s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
38s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
25s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 46s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 56s
{color} | {color:green} master passed with JDK v1.7.0_80 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 11s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
13s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 6s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 6s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 7s
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 7s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
1s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
40s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 10m 23s
{color} | {color:red} Patch causes 11 errors with Hadoop v2.5.0. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 12m 30s
{color} | {color:red} Patch causes 11 errors with Hadoop v2.5.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 14m 33s
{color} | {color:red} Patch causes 12 errors with Hadoop v2.5.2. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 16m 38s
{color} | {color:red} Patch causes 12 errors with Hadoop v2.6.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 18m 42s
{color} | {color:red} Patch causes 11 errors with Hadoop v2.6.2. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 20m 53s
{color} | {color:red} Patch causes 12 errors with Hadoop v2.6.3. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 22m 55s
{color} | {color:red} Patch causes 11 errors with Hadoop v2.7.1. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 17s
{color} | {color:red} hbase-client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 24s
{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 17s
{color} | {color:red} hbase-client in the patch failed with JDK v1.8.0. {color}
|
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 21s
{color} | {color:red} hbase-server in the patch failed with JDK v1.8.0.
