[jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15425310#comment-15425310
]
Dima Spivak commented on HBASE-16384:
-
Well FWIW, the only issue I cared about was the import order warning: you
should put {{logging}} and {{os}} imports before Jinja2 to be compliant with
PEP 8. I guess a follow-on JIRA is fine.
> Update report-flakies.py script to allow specifying a list of build ids to be
> excluded
> --
>
> Key: HBASE-16384
> URL: https://issues.apache.org/jira/browse/HBASE-16384
> Project: HBase
> Issue Type: Bug
>Reporter: Appy
>Assignee: Appy
> Attachments: HBASE-16384.master.001.patch,
> HBASE-16384.master.002.patch, HBASE-16384.master.003.patch,
> HBASE-16384.master.004.patch, HBASE-16384.master.005.patch,
> HBASE-16384.master.006.patch, HBASE-16384.master.007.patch,
> HBASE-16384.master.008.patch, HBASE-16384.master.009.patch
>
>
> Sometimes, builds fail mysteriously and leave lots of tests hanging. This
> makes [flaky
> list|https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html]
> go crazy.
> This patch adds that feature to specify build ids to exclude in
> report-flakies.py.
> If we find that a build screwed up, we can exclude it using "exclude=" option
> in --urls param and rerun the job to fix the flaky list.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
[ https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15425303#comment-15425303 ] Sean Busbey commented on HBASE-16384: - +1. I agree that a clean-up follow-on is the way to go for the lint issues. > Update report-flakies.py script to allow specifying a list of build ids to be > excluded > -- > > Key: HBASE-16384 > URL: https://issues.apache.org/jira/browse/HBASE-16384 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Attachments: HBASE-16384.master.001.patch, > HBASE-16384.master.002.patch, HBASE-16384.master.003.patch, > HBASE-16384.master.004.patch, HBASE-16384.master.005.patch, > HBASE-16384.master.006.patch, HBASE-16384.master.007.patch, > HBASE-16384.master.008.patch, HBASE-16384.master.009.patch > > > Sometimes, builds fail mysteriously and leave lots of tests hanging. This > makes [flaky > list|https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > go crazy. > This patch adds that feature to specify build ids to exclude in > report-flakies.py. > If we find that a build screwed up, we can exclude it using "exclude=" option > in --urls param and rerun the job to fix the flaky list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
[ https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15425276#comment-15425276 ] Appy commented on HBASE-16384: -- Net pylint from patch are -ve, i.e. it's fixing a lot of old ones. The net count is bigger because it's showing old pylints from the newly added file in patch. These are not being introduced in this patch, so i'd rather not keep delaying this patch for fixing old lints. Old ones can be fixed overtime in future patches. > Update report-flakies.py script to allow specifying a list of build ids to be > excluded > -- > > Key: HBASE-16384 > URL: https://issues.apache.org/jira/browse/HBASE-16384 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Attachments: HBASE-16384.master.001.patch, > HBASE-16384.master.002.patch, HBASE-16384.master.003.patch, > HBASE-16384.master.004.patch, HBASE-16384.master.005.patch, > HBASE-16384.master.006.patch, HBASE-16384.master.007.patch, > HBASE-16384.master.008.patch, HBASE-16384.master.009.patch > > > Sometimes, builds fail mysteriously and leave lots of tests hanging. This > makes [flaky > list|https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > go crazy. > This patch adds that feature to specify build ids to exclude in > report-flakies.py. > If we find that a build screwed up, we can exclude it using "exclude=" option > in --urls param and rerun the job to fix the flaky list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
[ https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15425245#comment-15425245 ] Dima Spivak commented on HBASE-16384: - You got a few more Pylint warnings with your newest patch, [~appy]. Once those are fixed, if it works as expected on your machine, +1 from me. > Update report-flakies.py script to allow specifying a list of build ids to be > excluded > -- > > Key: HBASE-16384 > URL: https://issues.apache.org/jira/browse/HBASE-16384 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Attachments: HBASE-16384.master.001.patch, > HBASE-16384.master.002.patch, HBASE-16384.master.003.patch, > HBASE-16384.master.004.patch, HBASE-16384.master.005.patch, > HBASE-16384.master.006.patch, HBASE-16384.master.007.patch, > HBASE-16384.master.008.patch, HBASE-16384.master.009.patch > > > Sometimes, builds fail mysteriously and leave lots of tests hanging. This > makes [flaky > list|https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > go crazy. > This patch adds that feature to specify build ids to exclude in > report-flakies.py. > If we find that a build screwed up, we can exclude it using "exclude=" option > in --urls param and rerun the job to fix the flaky list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
[ https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15425234#comment-15425234 ] Appy commented on HBASE-16384: -- Thanks Dima for reviewing it a couple of times yesterday night! Need to get it in now. :) > Update report-flakies.py script to allow specifying a list of build ids to be > excluded > -- > > Key: HBASE-16384 > URL: https://issues.apache.org/jira/browse/HBASE-16384 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Attachments: HBASE-16384.master.001.patch, > HBASE-16384.master.002.patch, HBASE-16384.master.003.patch, > HBASE-16384.master.004.patch, HBASE-16384.master.005.patch, > HBASE-16384.master.006.patch, HBASE-16384.master.007.patch, > HBASE-16384.master.008.patch, HBASE-16384.master.009.patch > > > Sometimes, builds fail mysteriously and leave lots of tests hanging. This > makes [flaky > list|https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > go crazy. > This patch adds that feature to specify build ids to exclude in > report-flakies.py. > If we find that a build screwed up, we can exclude it using "exclude=" option > in --urls param and rerun the job to fix the flaky list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424135#comment-15424135
]
Hadoop QA commented on HBASE-16384:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 27s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} pylint {color} | {color:red} 0m 6s {color}
| {color:red} The patch generated 5 new + 36 unchanged - 22 fixed = 41 total
(was 58) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
28m 59s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:red}-1{color} | {color:red} hbaseprotoc {color} | {color:red} 0m 11s
{color} | {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 30m 10s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.0 Server=1.12.0 Image:yetus/hbase:date2016-08-17 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12824100/HBASE-16384.master.009.patch
|
| JIRA Issue | HBASE-16384 |
| Optional Tests | asflicense pylint |
| uname | Linux 6bcd2e6c4403 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28
20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / d5080e8 |
| pylint | v1.6.4 |
| pylint |
https://builds.apache.org/job/PreCommit-HBASE-Build/3126/artifact/patchprocess/diff-patch-pylint.txt
|
| hbaseprotoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/3126/artifact/patchprocess/patch-hbaseprotoc-root.txt
|
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/3126/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> Update report-flakies.py script to allow specifying a list of build ids to be
> excluded
> --
>
> Key: HBASE-16384
> URL: https://issues.apache.org/jira/browse/HBASE-16384
> Project: HBase
> Issue Type: Bug
>Reporter: Appy
>Assignee: Appy
> Attachments: HBASE-16384.master.001.patch,
> HBASE-16384.master.002.patch, HBASE-16384.master.003.patch,
> HBASE-16384.master.004.patch, HBASE-16384.master.005.patch,
> HBASE-16384.master.006.patch, HBASE-16384.master.007.patch,
> HBASE-16384.master.008.patch, HBASE-16384.master.009.patch
>
>
> Sometimes, builds fail mysteriously and leave lots of tests hanging. This
> makes [flaky
> list|https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html]
> go crazy.
> This patch adds that feature to specify build ids to exclude in
> report-flakies.py.
> If we find that a build screwed up, we can exclude it using "exclude=" option
> in --urls param and rerun the job to fix the flaky list.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424095#comment-15424095
]
Hadoop QA commented on HBASE-16384:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 11s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} pylint {color} | {color:red} 0m 3s {color}
| {color:red} The patch generated 2 new + 15 unchanged - 19 fixed = 17 total
(was 34) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
27m 28s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:red}-1{color} | {color:red} hbaseprotoc {color} | {color:red} 0m 12s
{color} | {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 28m 19s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:date2016-08-17 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12824098/HBASE-16384.master.008.patch
|
| JIRA Issue | HBASE-16384 |
| Optional Tests | asflicense pylint |
| uname | Linux 1a83bbdb3d91 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / d5080e8 |
| pylint | v1.6.4 |
| pylint |
https://builds.apache.org/job/PreCommit-HBASE-Build/3124/artifact/patchprocess/diff-patch-pylint.txt
|
| hbaseprotoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/3124/artifact/patchprocess/patch-hbaseprotoc-root.txt
|
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/3124/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> Update report-flakies.py script to allow specifying a list of build ids to be
> excluded
> --
>
> Key: HBASE-16384
> URL: https://issues.apache.org/jira/browse/HBASE-16384
> Project: HBase
> Issue Type: Bug
>Reporter: Appy
>Assignee: Appy
> Attachments: HBASE-16384.master.001.patch,
> HBASE-16384.master.002.patch, HBASE-16384.master.003.patch,
> HBASE-16384.master.004.patch, HBASE-16384.master.005.patch,
> HBASE-16384.master.006.patch, HBASE-16384.master.007.patch,
> HBASE-16384.master.008.patch, HBASE-16384.master.009.patch
>
>
> Sometimes, builds fail mysteriously and leave lots of tests hanging. This
> makes [flaky
> list|https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html]
> go crazy.
> This patch adds that feature to specify build ids to exclude in
> report-flakies.py.
> If we find that a build screwed up, we can exclude it using "exclude=" option
> in --urls param and rerun the job to fix the flaky list.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
[ https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423977#comment-15423977 ] Appy commented on HBASE-16384: -- bq.Order imports alphabetically, but grouped as described in PEP 8. The current order didn't throw lint warning so i thought it was fine. Anyways, changed it for better. If its still not perfect, please ignore it as i really consider it a nit. bq. Can probably remove the brackets around the metavar for excluded_builds to be more clear on how to pass arguments. done bq. In your new get_bad_tests, you removed the assignment of result. I'm also confused about why the doc suggests you'll return a list, but then you actually return an empty dictionary sometimes. Good catch. i thought intellij's rename would rename every usage, but seems like it left this bug. bq. Use enumerate in place of for i in range(len(job_urls)) to stay Pythonic I noticed it in lint, but this can't be changed. i is used for getting corresponding elements in other args. There may be other fancy pythonic way to do this, but i'd rather not get hung up on that. > Update report-flakies.py script to allow specifying a list of build ids to be > excluded > -- > > Key: HBASE-16384 > URL: https://issues.apache.org/jira/browse/HBASE-16384 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Attachments: HBASE-16384.master.001.patch, > HBASE-16384.master.002.patch, HBASE-16384.master.003.patch, > HBASE-16384.master.004.patch, HBASE-16384.master.005.patch, > HBASE-16384.master.006.patch > > > Sometimes, builds fail mysteriously and leave lots of tests hanging. This > makes [flaky > list|https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > go crazy. > This patch adds that feature to specify build ids to exclude in > report-flakies.py. > If we find that a build screwed up, we can exclude it using "exclude=" option > in --urls param and rerun the job to fix the flaky list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423641#comment-15423641
]
Dima Spivak commented on HBASE-16384:
-
Thanks for updating the script, [~appy]; way more readable IMHO. :) Some
suggestions:
- Order imports alphabetically, but grouped as described in PEP 8.
- Can probably remove the brackets around the {{metavar}} for
{{excluded_builds}} to be more clear on how to pass arguments.
- In your new {{get_bad_tests}}, you removed the assignment of {{result}}. I'm
also confused about why the doc suggests you'll return a list, but then you
actually return an empty dictionary sometimes.
- Use {{enumerate}} in place of {{for i in range(len(job_urls))}} to stay
Pythonic.
Other than that, basically looks good to me. It passing locally with and
without your new arguments in place?
> Update report-flakies.py script to allow specifying a list of build ids to be
> excluded
> --
>
> Key: HBASE-16384
> URL: https://issues.apache.org/jira/browse/HBASE-16384
> Project: HBase
> Issue Type: Bug
>Reporter: Appy
>Assignee: Appy
> Attachments: HBASE-16384.master.001.patch,
> HBASE-16384.master.002.patch, HBASE-16384.master.003.patch,
> HBASE-16384.master.004.patch, HBASE-16384.master.005.patch,
> HBASE-16384.master.006.patch
>
>
> Sometimes, builds fail mysteriously and leave lots of tests hanging. This
> makes [flaky
> list|https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html]
> go crazy.
> This patch adds that feature to specify build ids to exclude in
> report-flakies.py.
> If we find that a build screwed up, we can exclude it using "exclude=" option
> in --urls param and rerun the job to fix the flaky list.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
[ https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421770#comment-15421770 ] Appy commented on HBASE-16384: -- [~busbey], [~dimaspivak] ready for final review. > Update report-flakies.py script to allow specifying a list of build ids to be > excluded > -- > > Key: HBASE-16384 > URL: https://issues.apache.org/jira/browse/HBASE-16384 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Attachments: HBASE-16384.master.001.patch, > HBASE-16384.master.002.patch, HBASE-16384.master.003.patch, > HBASE-16384.master.004.patch, HBASE-16384.master.005.patch, > HBASE-16384.master.006.patch > > > Sometimes, builds fail mysteriously and leave lots of tests hanging. This > makes [flaky > list|https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > go crazy. > This patch adds that feature to specify build ids to exclude in > report-flakies.py. > If we find that a build screwed up, we can exclude it using "exclude=" option > in --urls param and rerun the job to fix the flaky list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421767#comment-15421767
]
Hadoop QA commented on HBASE-16384:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 10s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} pylint {color} | {color:red} 0m 5s {color}
| {color:red} The patch generated 1 new + 15 unchanged - 19 fixed = 16 total
(was 34) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
27m 49s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:red}-1{color} | {color:red} hbaseprotoc {color} | {color:red} 0m 10s
{color} | {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 28m 36s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:date2016-08-15 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12823765/HBASE-16384.master.006.patch
|
| JIRA Issue | HBASE-16384 |
| Optional Tests | asflicense pylint |
| uname | Linux 42328f04bf0f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 9219d68 |
| pylint | v1.6.4 |
| pylint |
https://builds.apache.org/job/PreCommit-HBASE-Build/3093/artifact/patchprocess/diff-patch-pylint.txt
|
| hbaseprotoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/3093/artifact/patchprocess/patch-hbaseprotoc-root.txt
|
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/3093/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> Update report-flakies.py script to allow specifying a list of build ids to be
> excluded
> --
>
> Key: HBASE-16384
> URL: https://issues.apache.org/jira/browse/HBASE-16384
> Project: HBase
> Issue Type: Bug
>Reporter: Appy
>Assignee: Appy
> Attachments: HBASE-16384.master.001.patch,
> HBASE-16384.master.002.patch, HBASE-16384.master.003.patch,
> HBASE-16384.master.004.patch, HBASE-16384.master.005.patch,
> HBASE-16384.master.006.patch
>
>
> Sometimes, builds fail mysteriously and leave lots of tests hanging. This
> makes [flaky
> list|https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html]
> go crazy.
> This patch adds that feature to specify build ids to exclude in
> report-flakies.py.
> If we find that a build screwed up, we can exclude it using "exclude=" option
> in --urls param and rerun the job to fix the flaky list.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
[ https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421724#comment-15421724 ] Appy commented on HBASE-16384: -- installed pylint locally to see full set of warnings (instead of just patch diff). Corrected most. The rest can be ignored. They are mostly "[Invalid constant name|http://stackoverflow.com/questions/25184097/pylint-invalid-constant-name]; since the variables are in global scope. > Update report-flakies.py script to allow specifying a list of build ids to be > excluded > -- > > Key: HBASE-16384 > URL: https://issues.apache.org/jira/browse/HBASE-16384 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Attachments: HBASE-16384.master.001.patch, > HBASE-16384.master.002.patch, HBASE-16384.master.003.patch, > HBASE-16384.master.004.patch, HBASE-16384.master.005.patch, > HBASE-16384.master.006.patch > > > Sometimes, builds fail mysteriously and leave lots of tests hanging. This > makes [flaky > list|https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > go crazy. > This patch adds that feature to specify build ids to exclude in > report-flakies.py. > If we find that a build screwed up, we can exclude it using "exclude=" option > in --urls param and rerun the job to fix the flaky list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421562#comment-15421562
]
Hadoop QA commented on HBASE-16384:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 13s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} pylint {color} | {color:red} 0m 5s {color}
| {color:red} The patch generated 3 new + 23 unchanged - 11 fixed = 26 total
(was 34) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
28m 4s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:red}-1{color} | {color:red} hbaseprotoc {color} | {color:red} 0m 15s
{color} | {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
19s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 29m 8s {color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:date2016-08-15 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12823741/HBASE-16384.master.004.patch
|
| JIRA Issue | HBASE-16384 |
| Optional Tests | asflicense pylint |
| uname | Linux 8e86bb7d0704 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 9219d68 |
| pylint | v1.6.4 |
| pylint |
https://builds.apache.org/job/PreCommit-HBASE-Build/3090/artifact/patchprocess/diff-patch-pylint.txt
|
| hbaseprotoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/3090/artifact/patchprocess/patch-hbaseprotoc-root.txt
|
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/3090/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> Update report-flakies.py script to allow specifying a list of build ids to be
> excluded
> --
>
> Key: HBASE-16384
> URL: https://issues.apache.org/jira/browse/HBASE-16384
> Project: HBase
> Issue Type: Bug
>Reporter: Appy
>Assignee: Appy
> Attachments: HBASE-16384.master.001.patch,
> HBASE-16384.master.002.patch, HBASE-16384.master.003.patch,
> HBASE-16384.master.004.patch
>
>
> Sometimes, builds fail mysteriously and leave lots of tests hanging. This
> makes [flaky
> list|https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html]
> go crazy.
> This patch adds that feature to specify build ids to exclude in
> report-flakies.py.
> If we find that a build screwed up, we can exclude it using "exclude=" option
> in --urls param and rerun the job to fix the flaky list.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
[ https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421504#comment-15421504 ] Appy commented on HBASE-16384: -- Ahh, my python isn't the best and it felt like python was being very picky about scopes of variables. Anyways, i have changed variable names and corrected the indentation. I think there will still be 1 lint warning remaining, but the generic suggestion doesn't fit in this case. > Update report-flakies.py script to allow specifying a list of build ids to be > excluded > -- > > Key: HBASE-16384 > URL: https://issues.apache.org/jira/browse/HBASE-16384 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Attachments: HBASE-16384.master.001.patch, > HBASE-16384.master.002.patch, HBASE-16384.master.003.patch, > HBASE-16384.master.004.patch > > > Sometimes, builds fail mysteriously and leave lots of tests hanging. This > makes [flaky > list|https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > go crazy. > This patch adds that feature to specify build ids to exclude in > report-flakies.py. > If we find that a build screwed up, we can exclude it using "exclude=" option > in --urls param and rerun the job to fix the flaky list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
[ https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421212#comment-15421212 ] Sean Busbey commented on HBASE-16384: - bq. -1 pylint 0m 6s The patch generated 9 new + 23 unchanged - 11 fixed = 32 total (was 34) Can we improve this? Or are we stuck unless there's a total cleanup? (or are we just missing an appropriate config file?) > Update report-flakies.py script to allow specifying a list of build ids to be > excluded > -- > > Key: HBASE-16384 > URL: https://issues.apache.org/jira/browse/HBASE-16384 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Attachments: HBASE-16384.master.001.patch, > HBASE-16384.master.002.patch, HBASE-16384.master.003.patch > > > Sometimes, builds fail mysteriously and leave lots of tests hanging. This > makes [flaky > list|https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > go crazy. > This patch adds that feature to specify build ids to exclude in > report-flakies.py. > If we find that a build screwed up, we can exclude it using "exclude=" option > in --urls param and rerun the job to fix the flaky list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416279#comment-15416279
]
Hadoop QA commented on HBASE-16384:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 14s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} pylint {color} | {color:red} 0m 6s {color}
| {color:red} The patch generated 9 new + 23 unchanged - 11 fixed = 32 total
(was 34) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
27m 1s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:red}-1{color} | {color:red} hbaseprotoc {color} | {color:red} 0m 10s
{color} | {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 27m 54s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:date2016-08-11 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12823147/HBASE-16384.master.003.patch
|
| JIRA Issue | HBASE-16384 |
| Optional Tests | asflicense pylint |
| uname | Linux 041cc4a28bc7 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28
20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 8895667 |
| pylint | v1.6.4 |
| pylint |
https://builds.apache.org/job/PreCommit-HBASE-Build/3058/artifact/patchprocess/diff-patch-pylint.txt
|
| hbaseprotoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/3058/artifact/patchprocess/patch-hbaseprotoc-root.txt
|
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/3058/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> Update report-flakies.py script to allow specifying a list of build ids to be
> excluded
> --
>
> Key: HBASE-16384
> URL: https://issues.apache.org/jira/browse/HBASE-16384
> Project: HBase
> Issue Type: Bug
>Reporter: Appy
>Assignee: Appy
> Attachments: HBASE-16384.master.001.patch,
> HBASE-16384.master.002.patch, HBASE-16384.master.003.patch
>
>
> Sometimes, builds fail mysteriously and leave lots of tests hanging. This
> makes [flaky
> list|https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html]
> go crazy.
> This patch adds that feature to specify build ids to exclude in
> report-flakies.py.
> If we find that a build screwed up, we can exclude it using "exclude=" option
> in --urls param and rerun the job to fix the flaky list.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
[ https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416254#comment-15416254 ] Appy commented on HBASE-16384: -- :) Updated the patch as [~dimaspivak] suggested. > Update report-flakies.py script to allow specifying a list of build ids to be > excluded > -- > > Key: HBASE-16384 > URL: https://issues.apache.org/jira/browse/HBASE-16384 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Attachments: HBASE-16384.master.001.patch, > HBASE-16384.master.002.patch, HBASE-16384.master.003.patch > > > Sometimes, builds fail mysteriously and leave lots of tests hanging. This > makes [flaky > list|https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > go crazy. > This patch adds that feature to specify build ids to exclude in > report-flakies.py. > If we find that a build screwed up, we can exclude it using "exclude=" option > in --urls param and rerun the job to fix the flaky list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
[ https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416090#comment-15416090 ] stack commented on HBASE-16384: --- [~appy] [~dimaspivak] said pretty please. You going to refuse him? > Update report-flakies.py script to allow specifying a list of build ids to be > excluded > -- > > Key: HBASE-16384 > URL: https://issues.apache.org/jira/browse/HBASE-16384 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Attachments: HBASE-16384.master.001.patch, > HBASE-16384.master.002.patch > > > Sometimes, builds fail mysteriously and leave lots of tests hanging. This > makes [flaky > list|https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > go crazy. > This patch adds that feature to specify build ids to exclude in > report-flakies.py. > If we find that a build screwed up, we can exclude it using "exclude=" option > in --urls param and rerun the job to fix the flaky list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414470#comment-15414470
]
Dima Spivak commented on HBASE-16384:
-
Just as an example of what I'm proposing instead:
{noformat}
dspivak-MBP:~ dspivak$ cat my_url_parser.py
#!/usr/bin/env python
from argparse import ArgumentParser
parser = ArgumentParser(description='My URL parser!')
parser.add_argument('--url', metavar='URL', action='append', required=True,
help='URL to analyze')
parser.add_argument('--excluded-builds', metavar='[n1,n2]', action='append',
help='List of build numbers to exclude (or "None")')
parser.add_argument('--max-builds', metavar='n', action='append',
help='The maximum number of builds to use')
args = parser.parse_args()
print args
dspivak-MBP:~ dspivak$ python my_url_parser.py --url=url1
--excluded-builds=None --max-builds=20 \
> --url=url2 --excluded-builds=10,12,13 --max-builds=10
Namespace(excluded_builds=['None', '10,12,13'], max_builds=['20', '10'],
url=['url1', 'url2'])
{noformat}
> Update report-flakies.py script to allow specifying a list of build ids to be
> excluded
> --
>
> Key: HBASE-16384
> URL: https://issues.apache.org/jira/browse/HBASE-16384
> Project: HBase
> Issue Type: Bug
>Reporter: Appy
>Assignee: Appy
> Attachments: HBASE-16384.master.001.patch,
> HBASE-16384.master.002.patch
>
>
> Sometimes, builds fail mysteriously and leave lots of tests hanging. This
> makes [flaky
> list|https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html]
> go crazy.
> This patch adds that feature to specify build ids to exclude in
> report-flakies.py.
> If we find that a build screwed up, we can exclude it using "exclude=" option
> in --urls param and rerun the job to fix the flaky list.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414441#comment-15414441
]
Hadoop QA commented on HBASE-16384:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 12s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} pylint {color} | {color:red} 0m 4s {color}
| {color:red} The patch generated 8 new + 23 unchanged - 11 fixed = 31 total
(was 34) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
28m 54s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:red}-1{color} | {color:red} hbaseprotoc {color} | {color:red} 0m 10s
{color} | {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 29m 42s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:date2016-08-09 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12822899/HBASE-16384.master.002.patch
|
| JIRA Issue | HBASE-16384 |
| Optional Tests | asflicense pylint |
| uname | Linux 0b7596d42ef6 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28
20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 46defe8 |
| pylint | v1.6.4 |
| pylint |
https://builds.apache.org/job/PreCommit-HBASE-Build/3039/artifact/patchprocess/diff-patch-pylint.txt
|
| hbaseprotoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/3039/artifact/patchprocess/patch-hbaseprotoc-root.txt
|
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/3039/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> Update report-flakies.py script to allow specifying a list of build ids to be
> excluded
> --
>
> Key: HBASE-16384
> URL: https://issues.apache.org/jira/browse/HBASE-16384
> Project: HBase
> Issue Type: Bug
>Reporter: Appy
>Assignee: Appy
> Attachments: HBASE-16384.master.001.patch,
> HBASE-16384.master.002.patch
>
>
> Sometimes, builds fail mysteriously and leave lots of tests hanging. This
> makes [flaky
> list|https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html]
> go crazy.
> This patch adds that feature to specify build ids to exclude in
> report-flakies.py.
> If we find that a build screwed up, we can exclude it using "exclude=" option
> in --urls param and rerun the job to fix the flaky list.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414400#comment-15414400
]
Dima Spivak commented on HBASE-16384:
-
I guess I'd take the order mattering over this confusing space-separated
{{\-\-urls}} argument. It's just super non-conventional, whereas at least
making the order of arguments matter would have some precedent. Pretty please?
:)
> Update report-flakies.py script to allow specifying a list of build ids to be
> excluded
> --
>
> Key: HBASE-16384
> URL: https://issues.apache.org/jira/browse/HBASE-16384
> Project: HBase
> Issue Type: Bug
>Reporter: Appy
>Assignee: Appy
> Attachments: HBASE-16384.master.001.patch,
> HBASE-16384.master.002.patch
>
>
> Sometimes, builds fail mysteriously and leave lots of tests hanging. This
> makes [flaky
> list|https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html]
> go crazy.
> This patch adds that feature to specify build ids to exclude in
> report-flakies.py.
> If we find that a build screwed up, we can exclude it using "exclude=" option
> in --urls param and rerun the job to fix the flaky list.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
[ https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414366#comment-15414366 ] Appy commented on HBASE-16384: -- I did consider that case in the starting. So basically it's, --urls="https://builds.apache.org/job/HBase1/ excludes=10,20 num=5" --urls="https://builds.apache.org/job/HBase2/ num=10" --urls="https://builds.apache.org/job/HBase3/ excludes=100,200" OR --urls="https://builds.apache.org/job/HBase1/; --excluded-builds="10,20" --max-builds=5 --urls="https://builds.apache.org/job/HBase2/; --excluded-builds="-1" (or NULL, or something else) --max-builds=10 --urls="https://builds.apache.org/job/HBase1/; --excluded-builds="100,200" --max-builds=0 (or -1, means no limit) In the second one, I don't like the fact that the exact order of CLI arguments matter. > Update report-flakies.py script to allow specifying a list of build ids to be > excluded > -- > > Key: HBASE-16384 > URL: https://issues.apache.org/jira/browse/HBASE-16384 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Attachments: HBASE-16384.master.001.patch > > > Sometimes, builds fail mysteriously and leave lots of tests hanging. This > makes [flaky > list|https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > go crazy. > This patch adds that feature to specify build ids to exclude in > report-flakies.py. > If we find that a build screwed up, we can exclude it using "exclude=" option > in --urls param and rerun the job to fix the flaky list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414351#comment-15414351
]
Dima Spivak commented on HBASE-16384:
-
In that case, how about use {{action='append'}} style arguments for
{{excluded-builds}} and {{max-builds}}, too, in that case and require nulls or
something for cases of URLs we don't want to have excluded builds for? If you
have three lists, they'll be kept synced in that case.
> Update report-flakies.py script to allow specifying a list of build ids to be
> excluded
> --
>
> Key: HBASE-16384
> URL: https://issues.apache.org/jira/browse/HBASE-16384
> Project: HBase
> Issue Type: Bug
>Reporter: Appy
>Assignee: Appy
> Attachments: HBASE-16384.master.001.patch
>
>
> Sometimes, builds fail mysteriously and leave lots of tests hanging. This
> makes [flaky
> list|https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html]
> go crazy.
> This patch adds that feature to specify build ids to exclude in
> report-flakies.py.
> If we find that a build screwed up, we can exclude it using "exclude=" option
> in --urls param and rerun the job to fix the flaky list.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414359#comment-15414359
]
Hadoop QA commented on HBASE-16384:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 24s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} pylint {color} | {color:red} 0m 4s {color}
| {color:red} The patch generated 9 new + 28 unchanged - 6 fixed = 37 total
(was 34) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
29m 23s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:red}-1{color} | {color:red} hbaseprotoc {color} | {color:red} 0m 11s
{color} | {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 30m 29s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.0 Server=1.12.0 Image:yetus/hbase:date2016-08-09 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12822888/HBASE-16384.master.001.patch
|
| JIRA Issue | HBASE-16384 |
| Optional Tests | asflicense pylint |
| uname | Linux 0d5d84d29007 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28
20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 46defe8 |
| pylint | v1.6.4 |
| pylint |
https://builds.apache.org/job/PreCommit-HBASE-Build/3037/artifact/patchprocess/diff-patch-pylint.txt
|
| hbaseprotoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/3037/artifact/patchprocess/patch-hbaseprotoc-root.txt
|
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/3037/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> Update report-flakies.py script to allow specifying a list of build ids to be
> excluded
> --
>
> Key: HBASE-16384
> URL: https://issues.apache.org/jira/browse/HBASE-16384
> Project: HBase
> Issue Type: Bug
>Reporter: Appy
>Assignee: Appy
> Attachments: HBASE-16384.master.001.patch
>
>
> Sometimes, builds fail mysteriously and leave lots of tests hanging. This
> makes [flaky
> list|https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html]
> go crazy.
> This patch adds that feature to specify build ids to exclude in
> report-flakies.py.
> If we find that a build screwed up, we can exclude it using "exclude=" option
> in --urls param and rerun the job to fix the flaky list.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
[ https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414344#comment-15414344 ] Appy commented on HBASE-16384: -- Sorry for bad urls in example. But in practice, there will always be multiple urls. One for post-commit, and another for flaky-tests runner. If it was a script handling just single url, we wouldn't be having this discussion (i would have sent the patch with multiple options in first place). :) > Update report-flakies.py script to allow specifying a list of build ids to be > excluded > -- > > Key: HBASE-16384 > URL: https://issues.apache.org/jira/browse/HBASE-16384 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Attachments: HBASE-16384.master.001.patch > > > Sometimes, builds fail mysteriously and leave lots of tests hanging. This > makes [flaky > list|https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > go crazy. > This patch adds that feature to specify build ids to exclude in > report-flakies.py. > If we find that a build screwed up, we can exclude it using "exclude=" option > in --urls param and rerun the job to fix the flaky list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
[ https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414337#comment-15414337 ] Dima Spivak commented on HBASE-16384: - Do we really invoke the script multiple times across different jobs (so ostensibly different branches of HBase) that often? It's just so scary looking. > Update report-flakies.py script to allow specifying a list of build ids to be > excluded > -- > > Key: HBASE-16384 > URL: https://issues.apache.org/jira/browse/HBASE-16384 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Attachments: HBASE-16384.master.001.patch > > > Sometimes, builds fail mysteriously and leave lots of tests hanging. This > makes [flaky > list|https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > go crazy. > This patch adds that feature to specify build ids to exclude in > report-flakies.py. > If we find that a build screwed up, we can exclude it using "exclude=" option > in --urls param and rerun the job to fix the flaky list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
[ https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414333#comment-15414333 ] Appy commented on HBASE-16384: -- So basically consider this example: --urls="https://builds.apache.org/job/HBase1/ excludes=10,20 num=5" --urls="https://builds.apache.org/job/HBase2/ num=10" --urls="https://builds.apache.org/job/HBase3/ excludes=100,200" So first, I think it's clean. Also, if we split into three options, --urls ,--excludes and --max-builds, i think it'll make things much worse. > Update report-flakies.py script to allow specifying a list of build ids to be > excluded > -- > > Key: HBASE-16384 > URL: https://issues.apache.org/jira/browse/HBASE-16384 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Attachments: HBASE-16384.master.001.patch > > > Sometimes, builds fail mysteriously and leave lots of tests hanging. This > makes [flaky > list|https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > go crazy. > This patch adds that feature to specify build ids to exclude in > report-flakies.py. > If we find that a build screwed up, we can exclude it using "exclude=" option > in --urls param and rerun the job to fix the flaky list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414330#comment-15414330
]
Dima Spivak commented on HBASE-16384:
-
Why not just pass in a single URL and take separate arguments for specific
build numbers to exclude and the maximum number of builds to analyze? I think
simplifying the tool at the cost of a slight amount of flexibility during
invocation would make it much easier to use. e.g.
{noformat}
./report-flakies.py --url=my_build --excluded-builds=[12,13,14] --max-builds=20
{noformat}
> Update report-flakies.py script to allow specifying a list of build ids to be
> excluded
> --
>
> Key: HBASE-16384
> URL: https://issues.apache.org/jira/browse/HBASE-16384
> Project: HBase
> Issue Type: Bug
>Reporter: Appy
>Assignee: Appy
> Attachments: HBASE-16384.master.001.patch
>
>
> Sometimes, builds fail mysteriously and leave lots of tests hanging. This
> makes [flaky
> list|https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html]
> go crazy.
> This patch adds that feature to specify build ids to exclude in
> report-flakies.py.
> If we find that a build screwed up, we can exclude it using "exclude=" option
> in --urls param and rerun the job to fix the flaky list.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
[ https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414325#comment-15414325 ] Appy commented on HBASE-16384: -- Emm, is there any other option here that am missing? If it's better, and doesn't take too much refactoring, i'll definitely do it. > Update report-flakies.py script to allow specifying a list of build ids to be > excluded > -- > > Key: HBASE-16384 > URL: https://issues.apache.org/jira/browse/HBASE-16384 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Attachments: HBASE-16384.master.001.patch > > > Sometimes, builds fail mysteriously and leave lots of tests hanging. This > makes [flaky > list|https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > go crazy. > This patch adds that feature to specify build ids to exclude in > report-flakies.py. > If we find that a build screwed up, we can exclude it using "exclude=" option > in --urls param and rerun the job to fix the flaky list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
[ https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414320#comment-15414320 ] Dima Spivak commented on HBASE-16384: - As I said, it's just super hard to read; I can barely even understand the proper way to pass arguments into it. :( Please reconsider? > Update report-flakies.py script to allow specifying a list of build ids to be > excluded > -- > > Key: HBASE-16384 > URL: https://issues.apache.org/jira/browse/HBASE-16384 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Attachments: HBASE-16384.master.001.patch > > > Sometimes, builds fail mysteriously and leave lots of tests hanging. This > makes [flaky > list|https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > go crazy. > This patch adds that feature to specify build ids to exclude in > report-flakies.py. > If we find that a build screwed up, we can exclude it using "exclude=" option > in --urls param and rerun the job to fix the flaky list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414316#comment-15414316
]
Appy commented on HBASE-16384:
--
I know it's weird, but splitting into multiple options seemed more messy to me.
The input is basically tuples where some values maybe missing. for eg{A, [B],
[C]}
If i split into multiple options (where each option correspond to single type
of value, i.e. option for list of A's , B's and C's), syncing up order of
values seems worse to me. Then there can be missing values.
After all the consideration, i went with the option of keeping the related
values together because it's seems better to me and also I didn't want to spend
too much time on this.
> Update report-flakies.py script to allow specifying a list of build ids to be
> excluded
> --
>
> Key: HBASE-16384
> URL: https://issues.apache.org/jira/browse/HBASE-16384
> Project: HBase
> Issue Type: Bug
>Reporter: Appy
>Assignee: Appy
> Attachments: HBASE-16384.master.001.patch
>
>
> Sometimes, builds fail mysteriously and leave lots of tests hanging. This
> makes [flaky
> list|https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html]
> go crazy.
> This patch adds that feature to specify build ids to exclude in
> report-flakies.py.
> If we find that a build screwed up, we can exclude it using "exclude=" option
> in --urls param and rerun the job to fix the flaky list.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16384) Update report-flakies.py script to allow specifying a list of build ids to be excluded
[ https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414304#comment-15414304 ] Dima Spivak commented on HBASE-16384: - Hey [~appy], this is a good change to make, but this is a pretty weird (and super confusing to read) way to handle command line parsing in Python. Can you break up the URLs argument into multiple options instead of having to pass in these strings with spaces? > Update report-flakies.py script to allow specifying a list of build ids to be > excluded > -- > > Key: HBASE-16384 > URL: https://issues.apache.org/jira/browse/HBASE-16384 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Attachments: HBASE-16384.master.001.patch > > > Sometimes, builds fail mysteriously and leave lots of tests hanging. This > makes [flaky > list|https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > go crazy. > This patch adds that feature to specify build ids to exclude in > report-flakies.py. > If we find that a build screwed up, we can exclude it using "exclude=" option > in --urls param and rerun the job to fix the flaky list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
