[jira] [Commented] (HBASE-16465) Disable region splits and merges, balancer during full backup
[ https://issues.apache.org/jira/browse/HBASE-16465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16273552#comment-16273552 ] Vladimir Rodionov commented on HBASE-16465: --- Phase 4 is correct. That feature requires support from HBase of disabling split/merges per table. Currently, we can do it only cluster-wide. > Disable region splits and merges, balancer during full backup > - > > Key: HBASE-16465 > URL: https://issues.apache.org/jira/browse/HBASE-16465 > Project: HBase > Issue Type: Improvement >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-16465-v1.patch, HBASE-16465-v2.patch, > HBASE-16465-v3.patch, HBASE-16465-v4.patch, HBASE-16465-v5.patch, > HBASE-16465-v6.patch > > > Incorporate HBASE-15128 > Balancer, catalog janitor and region normalizer should be disabled as well > during full backup -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-16465) Disable region splits and merges, balancer during full backup
[ https://issues.apache.org/jira/browse/HBASE-16465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16273537#comment-16273537 ] Mike Drob commented on HBASE-16465: --- I don't understand the target for this issue, it is labelled as required for phase 3, but to be implemented as part of phase 4. Which is correct? > Disable region splits and merges, balancer during full backup > - > > Key: HBASE-16465 > URL: https://issues.apache.org/jira/browse/HBASE-16465 > Project: HBase > Issue Type: Improvement >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-16465-v1.patch, HBASE-16465-v2.patch, > HBASE-16465-v3.patch, HBASE-16465-v4.patch, HBASE-16465-v5.patch, > HBASE-16465-v6.patch > > > Incorporate HBASE-15128 > Balancer, catalog janitor and region normalizer should be disabled as well > during full backup -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-16465) Disable region splits and merges, balancer during full backup
[
https://issues.apache.org/jira/browse/HBASE-16465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15474940#comment-15474940
]
Vladimir Rodionov commented on HBASE-16465:
---
{quote}
See HBaseFSCK#setMasterInMaintenanceMode(). Stephen Yuan Jiang what do you
think?
{quote}
This code is not in HBASE-7912 yet. I will postpone this JIRA until master
merge is complete.
> Disable region splits and merges, balancer during full backup
> -
>
> Key: HBASE-16465
> URL: https://issues.apache.org/jira/browse/HBASE-16465
> Project: HBase
> Issue Type: Improvement
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Labels: backup
> Attachments: HBASE-16465-v1.patch, HBASE-16465-v2.patch,
> HBASE-16465-v3.patch, HBASE-16465-v4.patch, HBASE-16465-v5.patch
>
>
> Incorporate HBASE-15128
> Balancer, catalog janitor and region normalizer should be disabled as well
> during full backup
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16465) Disable region splits and merges, balancer during full backup
[ https://issues.apache.org/jira/browse/HBASE-16465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469132#comment-15469132 ] Enis Soztutar commented on HBASE-16465: --- bq. Who would be restoring the balancer setting ? We can use the new maintenance mode introduced in HBASE-16008 for this. We can put an ephemeral znode while the backup process is on, so that region operations like split / merge and balancing are disabled. See HBaseFSCK#setMasterInMaintenanceMode(). [~syuanjiang] what do you think? > Disable region splits and merges, balancer during full backup > - > > Key: HBASE-16465 > URL: https://issues.apache.org/jira/browse/HBASE-16465 > Project: HBase > Issue Type: Improvement >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: HBASE-16465-v1.patch, HBASE-16465-v2.patch, > HBASE-16465-v3.patch, HBASE-16465-v4.patch, HBASE-16465-v5.patch > > > Incorporate HBASE-15128 > Balancer, catalog janitor and region normalizer should be disabled as well > during full backup -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16465) Disable region splits and merges, balancer during full backup
[
https://issues.apache.org/jira/browse/HBASE-16465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15468382#comment-15468382
]
Vladimir Rodionov commented on HBASE-16465:
---
{quote}
The above check is in HBaseAdmin. What if the admin disconnects from cluster in
the middle of backup ?
Who would be restoring the balancer setting
{quote}
Admin can do this manually, for example.
> Disable region splits and merges, balancer during full backup
> -
>
> Key: HBASE-16465
> URL: https://issues.apache.org/jira/browse/HBASE-16465
> Project: HBase
> Issue Type: Improvement
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Labels: backup
> Attachments: HBASE-16465-v1.patch, HBASE-16465-v2.patch,
> HBASE-16465-v3.patch, HBASE-16465-v4.patch, HBASE-16465-v5.patch
>
>
> Incorporate HBASE-15128
> Balancer, catalog janitor and region normalizer should be disabled as well
> during full backup
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16465) Disable region splits and merges, balancer during full backup
[
https://issues.apache.org/jira/browse/HBASE-16465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15468350#comment-15468350
]
Ted Yu commented on HBASE-16465:
{code}
+
.setTargetRootDir(args[2]).setWorkers(workers).setBandwidth(bandwidth).setSplitsDisabled(splitsDisabled);
{code}
Wrap long line.
{code}
+ if (isFullBackup && balancerEnabled) {
{code}
The above check is in HBaseAdmin. What if the admin disconnects from cluster in
the middle of backup ?
Who would be restoring the balancer setting ?
> Disable region splits and merges, balancer during full backup
> -
>
> Key: HBASE-16465
> URL: https://issues.apache.org/jira/browse/HBASE-16465
> Project: HBase
> Issue Type: Improvement
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Labels: backup
> Attachments: HBASE-16465-v1.patch, HBASE-16465-v2.patch,
> HBASE-16465-v3.patch, HBASE-16465-v4.patch, HBASE-16465-v5.patch
>
>
> Incorporate HBASE-15128
> Balancer, catalog janitor and region normalizer should be disabled as well
> during full backup
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16465) Disable region splits and merges, balancer during full backup
[ https://issues.apache.org/jira/browse/HBASE-16465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15468246#comment-15468246 ] Vladimir Rodionov commented on HBASE-16465: --- [~tedyu], can you take a look at the patch? > Disable region splits and merges, balancer during full backup > - > > Key: HBASE-16465 > URL: https://issues.apache.org/jira/browse/HBASE-16465 > Project: HBase > Issue Type: Improvement >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Attachments: HBASE-16465-v1.patch, HBASE-16465-v2.patch, > HBASE-16465-v3.patch, HBASE-16465-v4.patch, HBASE-16465-v5.patch > > > Incorporate HBASE-15128 > Balancer, catalog janitor and region normalizer should be disabled as well > during full backup -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16465) Disable region splits and merges, balancer during full backup
[
https://issues.apache.org/jira/browse/HBASE-16465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15461562#comment-15461562
]
Hadoop QA commented on HBASE-16465:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 8s {color}
| {color:red} HBASE-16465 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.3.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12826985/HBASE-16465-v5.patch |
| JIRA Issue | HBASE-16465 |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/3411/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> Disable region splits and merges, balancer during full backup
> -
>
> Key: HBASE-16465
> URL: https://issues.apache.org/jira/browse/HBASE-16465
> Project: HBase
> Issue Type: Improvement
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Labels: backup
> Attachments: HBASE-16465-v1.patch, HBASE-16465-v2.patch,
> HBASE-16465-v3.patch, HBASE-16465-v4.patch, HBASE-16465-v5.patch
>
>
> Incorporate HBASE-15128
> Balancer, catalog janitor and region normalizer should be disabled as well
> during full backup
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16465) Disable region splits and merges, balancer during full backup
[
https://issues.apache.org/jira/browse/HBASE-16465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15461554#comment-15461554
]
Vladimir Rodionov commented on HBASE-16465:
---
{quote}
For testFullBackupMultipleCommandUnsafe, I don't see induced split / merge.
{quote}
I just check that backup works as expected with splits on and off.
> Disable region splits and merges, balancer during full backup
> -
>
> Key: HBASE-16465
> URL: https://issues.apache.org/jira/browse/HBASE-16465
> Project: HBase
> Issue Type: Improvement
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Labels: backup
> Attachments: HBASE-16465-v1.patch, HBASE-16465-v2.patch,
> HBASE-16465-v3.patch, HBASE-16465-v4.patch, HBASE-16465-v5.patch
>
>
> Incorporate HBASE-15128
> Balancer, catalog janitor and region normalizer should be disabled as well
> during full backup
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16465) Disable region splits and merges, balancer during full backup
[
https://issues.apache.org/jira/browse/HBASE-16465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15456497#comment-15456497
]
Ted Yu commented on HBASE-16465:
{code}
+ private boolean safeMode = true;
{code}
Mode implies enum. Please rename the variable.
{code}
+boolean balancer = false;
{code}
Please name the variable balancerEnabled.
{code}
+if (isFullBackup && userRequest.isSafeMode()) {
{code}
Should default value for safe mode be off ?
For testFullBackupMultipleCommandUnsafe, I don't see induced split / merge.
> Disable region splits and merges, balancer during full backup
> -
>
> Key: HBASE-16465
> URL: https://issues.apache.org/jira/browse/HBASE-16465
> Project: HBase
> Issue Type: Improvement
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
> Labels: backup
> Attachments: HBASE-16465-v1.patch, HBASE-16465-v2.patch,
> HBASE-16465-v3.patch, HBASE-16465-v4.patch
>
>
> Incorporate HBASE-15128
> Balancer, catalog janitor and region normalizer should be disabled as well
> during full backup
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
