[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15497205#comment-15497205 ] Hudson commented on HBASE-16631: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #1614 (See [https://builds.apache.org/job/HBase-Trunk_matrix/1614/]) HBASE-16631 Extract AsyncRequestFuture related code from AsyncProcess (chenheng: rev 2cf8907db53b84a0118acc1edd1dfb9b37abe8b7) * (add) hbase-client/src/main/java/org/apache/hadoop/hbase/client/BatchErrors.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableMultiplexer.java * (add) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFuture.java * (add) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestReplicasClient.java * (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java > Extract AsyncRequestFuture related code from AsyncProcess > - > > Key: HBASE-16631 > URL: https://issues.apache.org/jira/browse/HBASE-16631 > Project: HBase > Issue Type: Sub-task >Reporter: Heng Chen >Assignee: Heng Chen > Attachments: HBASE-16631.v1.patch, HBASE-16631.v1.patch, > HBASE-16631.v2.patch, HBASE-16631.v2.patch, HBASE-16631.wip.patch > > > Now, AsyncProcess class is too large (over 2000+ lines), and there are so > many sub classes in it. > AsyncRequestFutureImpl is the biggest subclass in AP, we could extract it > out from AP to reduce the AP size. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15496770#comment-15496770 ] Heng Chen commented on HBASE-16631: --- Timeout test case could pass locally, relates testcase such as TestAsyncProcess, TestFromClientSideXXX has passed. will commit it to master > Extract AsyncRequestFuture related code from AsyncProcess > - > > Key: HBASE-16631 > URL: https://issues.apache.org/jira/browse/HBASE-16631 > Project: HBase > Issue Type: Sub-task >Reporter: Heng Chen >Assignee: Heng Chen > Attachments: HBASE-16631.v1.patch, HBASE-16631.v1.patch, > HBASE-16631.v2.patch, HBASE-16631.v2.patch, HBASE-16631.wip.patch > > > Now, AsyncProcess class is too large (over 2000+ lines), and there are so > many sub classes in it. > AsyncRequestFutureImpl is the biggest subclass in AP, we could extract it > out from AP to reduce the AP size. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess
[
https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15496544#comment-15496544
]
Hadoop QA commented on HBASE-16631:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 11s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 8s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
54s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 49s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
40s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
21s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
23s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 40s
{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 8s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
1s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 50s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 50s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
41s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
21s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s
{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
24m 41s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m
19s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
38s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 41s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 0s
{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 77m 26s {color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
24s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 119m 48s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests |
org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures
|
| | org.apache.hadoop.hbase.master.procedure.TestRestoreSnapshotProcedure |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:7bda515 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12828828/HBASE-16631.v2.patch |
| JIRA Issue | HBASE-16631 |
| Optional Tests | asflicense javac javadoc unit xml compile findbugs
hadoopcheck hbaseanti checkstyle |
| uname | Linux db1a18b996d5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 2597217 |
| Default Java | 1.8.0_101 |
|
[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15496288#comment-15496288 ] stack commented on HBASE-16631: --- +1 on v1 (minus the pom change). Yeah, good idea making a new issue. I started another run just so can see if failures are related at all (they should not be given you made no change). > Extract AsyncRequestFuture related code from AsyncProcess > - > > Key: HBASE-16631 > URL: https://issues.apache.org/jira/browse/HBASE-16631 > Project: HBase > Issue Type: Sub-task >Reporter: Heng Chen >Assignee: Heng Chen > Attachments: HBASE-16631.v1.patch, HBASE-16631.v1.patch, > HBASE-16631.v2.patch, HBASE-16631.v2.patch, HBASE-16631.wip.patch > > > Now, AsyncProcess class is too large (over 2000+ lines), and there are so > many sub classes in it. > AsyncRequestFutureImpl is the biggest subclass in AP, we could extract it > out from AP to reduce the AP size. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495140#comment-15495140 ] Heng Chen commented on HBASE-16631: --- Create one new issue for it, maybe someone has related experience. See HBASE-16641 > Extract AsyncRequestFuture related code from AsyncProcess > - > > Key: HBASE-16631 > URL: https://issues.apache.org/jira/browse/HBASE-16631 > Project: HBase > Issue Type: Sub-task >Reporter: Heng Chen >Assignee: Heng Chen > Attachments: HBASE-16631.v1.patch, HBASE-16631.v1.patch, > HBASE-16631.v2.patch, HBASE-16631.wip.patch > > > Now, AsyncProcess class is too large (over 2000+ lines), and there are so > many sub classes in it. > AsyncRequestFutureImpl is the biggest subclass in AP, we could extract it > out from AP to reduce the AP size. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess
[
https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494973#comment-15494973
]
Heng Chen commented on HBASE-16631:
---
QA use the 'runAllTests' profile. And it looks good to me.
{code}
cd /testptch/hbase/hbase-client
mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hbase-master-patch-1
-DHBasePatchProcess -PrunAllTests clean test -fae
{code}
Not sure whether the cmd line is updated or not recently, let me have a check,
not familiar with it...
> Extract AsyncRequestFuture related code from AsyncProcess
> -
>
> Key: HBASE-16631
> URL: https://issues.apache.org/jira/browse/HBASE-16631
> Project: HBase
> Issue Type: Sub-task
>Reporter: Heng Chen
>Assignee: Heng Chen
> Attachments: HBASE-16631.v1.patch, HBASE-16631.v1.patch,
> HBASE-16631.v2.patch, HBASE-16631.wip.patch
>
>
> Now, AsyncProcess class is too large (over 2000+ lines), and there are so
> many sub classes in it.
> AsyncRequestFutureImpl is the biggest subclass in AP, we could extract it
> out from AP to reduce the AP size.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494935#comment-15494935 ] stack commented on HBASE-16631: --- I want to know if that setting changed recently? I am wondering if it is being set in a profile or via cmd line up on build box. > Extract AsyncRequestFuture related code from AsyncProcess > - > > Key: HBASE-16631 > URL: https://issues.apache.org/jira/browse/HBASE-16631 > Project: HBase > Issue Type: Sub-task >Reporter: Heng Chen >Assignee: Heng Chen > Attachments: HBASE-16631.v1.patch, HBASE-16631.v1.patch, > HBASE-16631.v2.patch, HBASE-16631.wip.patch > > > Now, AsyncProcess class is too large (over 2000+ lines), and there are so > many sub classes in it. > AsyncRequestFutureImpl is the biggest subclass in AP, we could extract it > out from AP to reduce the AP size. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494923#comment-15494923 ] Heng Chen commented on HBASE-16631: --- Timeout test case could pass locally, commit with hbase-client/pom.xml changed (patch v3)? wdyt? [~stack] > Extract AsyncRequestFuture related code from AsyncProcess > - > > Key: HBASE-16631 > URL: https://issues.apache.org/jira/browse/HBASE-16631 > Project: HBase > Issue Type: Sub-task >Reporter: Heng Chen >Assignee: Heng Chen > Attachments: HBASE-16631.v1.patch, HBASE-16631.v1.patch, > HBASE-16631.v2.patch, HBASE-16631.wip.patch > > > Now, AsyncProcess class is too large (over 2000+ lines), and there are so > many sub classes in it. > AsyncRequestFutureImpl is the biggest subclass in AP, we could extract it > out from AP to reduce the AP size. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494880#comment-15494880 ] Heng Chen commented on HBASE-16631: --- It is not changed recently, last change for this part is HBASE-8187. But I notice QA could trigger secondaryPart now https://builds.apache.org/job/PreCommit-HBASE-Build/3562/artifact/patchprocess/patch-unit-hbase-client.txt > Extract AsyncRequestFuture related code from AsyncProcess > - > > Key: HBASE-16631 > URL: https://issues.apache.org/jira/browse/HBASE-16631 > Project: HBase > Issue Type: Sub-task >Reporter: Heng Chen >Assignee: Heng Chen > Attachments: HBASE-16631.v1.patch, HBASE-16631.v1.patch, > HBASE-16631.v2.patch, HBASE-16631.wip.patch > > > Now, AsyncProcess class is too large (over 2000+ lines), and there are so > many sub classes in it. > AsyncRequestFutureImpl is the biggest subclass in AP, we could extract it > out from AP to reduce the AP size. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess
[
https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494120#comment-15494120
]
Hadoop QA commented on HBASE-16631:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 21s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
33s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 7s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
53s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
26s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 5s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 52s
{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
16s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 59s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 59s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
47s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
25s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s
{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
28m 45s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m
23s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
16s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 48s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 10s
{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 83m 4s {color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
24s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 133m 36s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests | org.apache.hadoop.hbase.client.TestReplicasClient |
| | org.apache.hadoop.hbase.client.TestFromClientSide |
| | org.apache.hadoop.hbase.client.TestTableSnapshotScanner |
| | org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClient |
| | org.apache.hadoop.hbase.client.TestMobSnapshotCloneIndependence |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:7bda515 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12828662/HBASE-16631.v2.patch |
| JIRA Issue | HBASE-16631 |
| Optional Tests | asflicense javac javadoc unit xml compile findbugs
hadoopcheck hbaseanti checkstyle |
| uname | Linux 62c59f167bd0 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28
20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493901#comment-15493901 ] stack commented on HBASE-16631: --- Did that change recently? > Extract AsyncRequestFuture related code from AsyncProcess > - > > Key: HBASE-16631 > URL: https://issues.apache.org/jira/browse/HBASE-16631 > Project: HBase > Issue Type: Sub-task >Reporter: Heng Chen >Assignee: Heng Chen > Attachments: HBASE-16631.v1.patch, HBASE-16631.v1.patch, > HBASE-16631.v2.patch, HBASE-16631.wip.patch > > > Now, AsyncProcess class is too large (over 2000+ lines), and there are so > many sub classes in it. > AsyncRequestFutureImpl is the biggest subclass in AP, we could extract it > out from AP to reduce the AP size. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess
[
https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493737#comment-15493737
]
Heng Chen commented on HBASE-16631:
---
Notice this: hbase-client/pom.xml
{code}
secondPartTestsExecution
test
test
true
{code}
Let me change the skip to be false, and retry
> Extract AsyncRequestFuture related code from AsyncProcess
> -
>
> Key: HBASE-16631
> URL: https://issues.apache.org/jira/browse/HBASE-16631
> Project: HBase
> Issue Type: Sub-task
>Reporter: Heng Chen
>Assignee: Heng Chen
> Attachments: HBASE-16631.v1.patch, HBASE-16631.v1.patch,
> HBASE-16631.wip.patch
>
>
> Now, AsyncProcess class is too large (over 2000+ lines), and there are so
> many sub classes in it.
> AsyncRequestFutureImpl is the biggest subclass in AP, we could extract it
> out from AP to reduce the AP size.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess
[
https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493290#comment-15493290
]
stack commented on HBASE-16631:
---
Says
{code}
[INFO] --- maven-surefire-plugin:2.18.1:test (secondPartTestsExecution) @
hbase-client ---
[INFO] Tests are skipped.
{code}
TestAsyncProcess is
@Category({ClientTests.class, MediumTests.class})
... Not sure why it'd skip second part when it looks like first part all passed
fine.
Retry and if still failing, we need to dig in
> Extract AsyncRequestFuture related code from AsyncProcess
> -
>
> Key: HBASE-16631
> URL: https://issues.apache.org/jira/browse/HBASE-16631
> Project: HBase
> Issue Type: Sub-task
>Reporter: Heng Chen
>Assignee: Heng Chen
> Attachments: HBASE-16631.v1.patch, HBASE-16631.v1.patch,
> HBASE-16631.wip.patch
>
>
> Now, AsyncProcess class is too large (over 2000+ lines), and there are so
> many sub classes in it.
> AsyncRequestFutureImpl is the biggest subclass in AP, we could extract it
> out from AP to reduce the AP size.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493202#comment-15493202 ] Heng Chen commented on HBASE-16631: --- Not in flakey tests. Very weird, it seems everything looks good in https://builds.apache.org/job/PreCommit-HBASE-Build/3547/artifact/patchprocess/patch-unit-hbase-client.txt, but there is no TestAsyncProcess. > Extract AsyncRequestFuture related code from AsyncProcess > - > > Key: HBASE-16631 > URL: https://issues.apache.org/jira/browse/HBASE-16631 > Project: HBase > Issue Type: Sub-task >Reporter: Heng Chen >Assignee: Heng Chen > Attachments: HBASE-16631.v1.patch, HBASE-16631.v1.patch, > HBASE-16631.wip.patch > > > Now, AsyncProcess class is too large (over 2000+ lines), and there are so > many sub classes in it. > AsyncRequestFutureImpl is the biggest subclass in AP, we could extract it > out from AP to reduce the AP size. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493176#comment-15493176 ] stack commented on HBASE-16631: --- Is it in the set of flakey tests? > Extract AsyncRequestFuture related code from AsyncProcess > - > > Key: HBASE-16631 > URL: https://issues.apache.org/jira/browse/HBASE-16631 > Project: HBase > Issue Type: Sub-task >Reporter: Heng Chen >Assignee: Heng Chen > Attachments: HBASE-16631.v1.patch, HBASE-16631.v1.patch, > HBASE-16631.wip.patch > > > Now, AsyncProcess class is too large (over 2000+ lines), and there are so > many sub classes in it. > AsyncRequestFutureImpl is the biggest subclass in AP, we could extract it > out from AP to reduce the AP size. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493028#comment-15493028 ] Heng Chen commented on HBASE-16631: --- Why TestAsyncProcess not be triggered in QA? Do you know the reason? [~stack] > Extract AsyncRequestFuture related code from AsyncProcess > - > > Key: HBASE-16631 > URL: https://issues.apache.org/jira/browse/HBASE-16631 > Project: HBase > Issue Type: Sub-task >Reporter: Heng Chen >Assignee: Heng Chen > Attachments: HBASE-16631.v1.patch, HBASE-16631.v1.patch, > HBASE-16631.wip.patch > > > Now, AsyncProcess class is too large (over 2000+ lines), and there are so > many sub classes in it. > AsyncRequestFutureImpl is the biggest subclass in AP, we could extract it > out from AP to reduce the AP size. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess
[
https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492177#comment-15492177
]
Hadoop QA commented on HBASE-16631:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 14s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 14s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
50s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 49s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
41s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
21s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
21s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 40s
{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 8s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
2s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 49s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 49s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
40s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
22s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
25m 15s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m
20s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 0s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 44s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 54s
{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 92m 51s {color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
35s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 135m 33s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests | org.apache.hadoop.hbase.TestZooKeeper |
| | org.apache.hadoop.hbase.master.TestDistributedLogSplitting |
| |
org.apache.hadoop.hbase.regionserver.throttle.TestFlushWithThroughputController
|
| | org.apache.hadoop.hbase.TestIOFencing |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:7bda515 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12828568/HBASE-16631.v1.patch |
| JIRA Issue | HBASE-16631 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux c666960d7036 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 8ef6c76 |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/3554/artifact/patchprocess/patch-unit-hbase-server.txt
|
|
[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492077#comment-15492077 ] stack commented on HBASE-16631: --- OK. +1 I have no plan. Ijust thinking about what our asynchronous client API will be and that it and here in AP align. Later > Extract AsyncRequestFuture related code from AsyncProcess > - > > Key: HBASE-16631 > URL: https://issues.apache.org/jira/browse/HBASE-16631 > Project: HBase > Issue Type: Sub-task >Reporter: Heng Chen >Assignee: Heng Chen > Attachments: HBASE-16631.v1.patch, HBASE-16631.v1.patch, > HBASE-16631.wip.patch > > > Now, AsyncProcess class is too large (over 2000+ lines), and there are so > many sub classes in it. > AsyncRequestFutureImpl is the biggest subclass in AP, we could extract it > out from AP to reduce the AP size. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess
[
https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491921#comment-15491921
]
Heng Chen commented on HBASE-16631:
---
{quote}
We'll probably want to change our Future to subclass CompletableFuture but that
can come later.
{quote}
Any issue about it?
> Extract AsyncRequestFuture related code from AsyncProcess
> -
>
> Key: HBASE-16631
> URL: https://issues.apache.org/jira/browse/HBASE-16631
> Project: HBase
> Issue Type: Sub-task
>Reporter: Heng Chen
>Assignee: Heng Chen
> Attachments: HBASE-16631.v1.patch, HBASE-16631.wip.patch
>
>
> Now, AsyncProcess class is too large (over 2000+ lines), and there are so
> many sub classes in it.
> AsyncRequestFutureImpl is the biggest subclass in AP, we could extract it
> out from AP to reduce the AP size.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491896#comment-15491896 ] Heng Chen commented on HBASE-16631: --- There is no logic changed, just split the AP and a little changes about function scope. > Extract AsyncRequestFuture related code from AsyncProcess > - > > Key: HBASE-16631 > URL: https://issues.apache.org/jira/browse/HBASE-16631 > Project: HBase > Issue Type: Sub-task >Reporter: Heng Chen >Assignee: Heng Chen > Attachments: HBASE-16631.v1.patch, HBASE-16631.wip.patch > > > Now, AsyncProcess class is too large (over 2000+ lines), and there are so > many sub classes in it. > AsyncRequestFutureImpl is the biggest subclass in AP, we could extract it > out from AP to reduce the AP size. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess
[
https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490978#comment-15490978
]
Hadoop QA commented on HBASE-16631:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 15s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 7s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
48s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 48s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
41s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
22s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
21s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 41s
{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 8s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
0s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 48s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 48s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
42s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
21s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
24m 50s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m
19s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
38s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 41s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 51s
{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 84m 48s {color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
28s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 126m 11s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.regionserver.TestHRegion |
| Timed out junit tests |
org.apache.hadoop.hbase.security.access.TestAccessController2 |
| | org.apache.hadoop.hbase.mob.TestExpiredMobFileCleaner |
| | org.apache.hadoop.hbase.snapshot.TestExportSnapshot |
| | org.apache.hadoop.hbase.security.access.TestCellACLWithMultipleVersions |
| | org.apache.hadoop.hbase.io.encoding.TestEncodedSeekers |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:7bda515 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12828476/HBASE-16631.v1.patch |
| JIRA Issue | HBASE-16631 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 394f37f9f964 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 4c6a98b |
| Default Java |
[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490827#comment-15490827 ] stack commented on HBASE-16631: --- Is this a straight extraction or did you make other changes? If so, patch LGTM. We'll probably want to change our Future to subclass CompletableFuture but that can come later. I like that you keep the implementations package private. > Extract AsyncRequestFuture related code from AsyncProcess > - > > Key: HBASE-16631 > URL: https://issues.apache.org/jira/browse/HBASE-16631 > Project: HBase > Issue Type: Sub-task >Reporter: Heng Chen >Assignee: Heng Chen > Attachments: HBASE-16631.v1.patch, HBASE-16631.wip.patch > > > Now, AsyncProcess class is too large (over 2000+ lines), and there are so > many sub classes in it. > AsyncRequestFutureImpl is the biggest subclass in AP, we could extract it > out from AP to reduce the AP size. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490724#comment-15490724 ] Heng Chen commented on HBASE-16631: --- wdyt? [~stack] > Extract AsyncRequestFuture related code from AsyncProcess > - > > Key: HBASE-16631 > URL: https://issues.apache.org/jira/browse/HBASE-16631 > Project: HBase > Issue Type: Sub-task >Reporter: Heng Chen >Assignee: Heng Chen > Attachments: HBASE-16631.v1.patch, HBASE-16631.wip.patch > > > Now, AsyncProcess class is too large (over 2000+ lines), and there are so > many sub classes in it. > AsyncRequestFutureImpl is the biggest subclass in AP, we could extract it > out from AP to reduce the AP size. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16631) Extract AsyncRequestFuture related code from AsyncProcess
[ https://issues.apache.org/jira/browse/HBASE-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490683#comment-15490683 ] Heng Chen commented on HBASE-16631: --- With this patch, AsyncProcess has 966 lines, and AsyncRequestFutureImpl has 1290 lines. > Extract AsyncRequestFuture related code from AsyncProcess > - > > Key: HBASE-16631 > URL: https://issues.apache.org/jira/browse/HBASE-16631 > Project: HBase > Issue Type: Sub-task >Reporter: Heng Chen >Assignee: Heng Chen > Attachments: HBASE-16631.v1.patch, HBASE-16631.wip.patch > > > Now, AsyncProcess class is too large (over 2000+ lines), and there are so > many sub classes in it. > AsyncRequestFutureImpl is the biggest subclass in AP, we could extract it > out from AP to reduce the AP size. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
