[jira] [Commented] (HBASE-16696) TestBlockEvictionFromClient fails in master branch
[ https://issues.apache.org/jira/browse/HBASE-16696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521050#comment-15521050 ] Ted Yu commented on HBASE-16696: Thanks for digging, Ram. Feel free to adjust the subject if you have a patch. > TestBlockEvictionFromClient fails in master branch > -- > > Key: HBASE-16696 > URL: https://issues.apache.org/jira/browse/HBASE-16696 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: ramkrishna.s.vasudevan > Attachments: build-1638.out, build-1639.out > > > TestBlockEvictionFromClient consistently fails in master branch. > From existing Jenkins builds, looks like this started with build 1639. > See attached Jenkins console logs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16696) TestBlockEvictionFromClient fails in master branch
[ https://issues.apache.org/jira/browse/HBASE-16696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521045#comment-15521045 ] ramkrishna.s.vasudevan commented on HBASE-16696: The test as such is fine and it has infact helped in regression. > TestBlockEvictionFromClient fails in master branch > -- > > Key: HBASE-16696 > URL: https://issues.apache.org/jira/browse/HBASE-16696 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: ramkrishna.s.vasudevan > Attachments: build-1638.out, build-1639.out > > > TestBlockEvictionFromClient consistently fails in master branch. > From existing Jenkins builds, looks like this started with build 1639. > See attached Jenkins console logs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16696) TestBlockEvictionFromClient fails in master branch
[ https://issues.apache.org/jira/browse/HBASE-16696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521044#comment-15521044 ] ramkrishna.s.vasudevan commented on HBASE-16696: I verified the test case and could find the problem. It is because of the recent commits https://issues.apache.org/jira/browse/HBASE-16604. I will check once again that patch and see if that fix needs to be verified once again. This problem will not be seen in other branches because only master does the ref counting of blocks and so missing that 'shipped()' call will lead to problems. ScannerResetException has been introduced that does not allow the lease to be removed and I think in this case with RpcCallback it calls sets the callback but as there is an exception it does not really do the shipped() call. But i need to verify this once again and wil be back with a patch soon. > TestBlockEvictionFromClient fails in master branch > -- > > Key: HBASE-16696 > URL: https://issues.apache.org/jira/browse/HBASE-16696 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: ramkrishna.s.vasudevan > Attachments: build-1638.out, build-1639.out > > > TestBlockEvictionFromClient consistently fails in master branch. > From existing Jenkins builds, looks like this started with build 1639. > See attached Jenkins console logs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16696) TestBlockEvictionFromClient fails in master branch
[ https://issues.apache.org/jira/browse/HBASE-16696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15520708#comment-15520708 ] Anoop Sam John commented on HBASE-16696: Ram this is the case of flaky tests only? Or any code path is broken? > TestBlockEvictionFromClient fails in master branch > -- > > Key: HBASE-16696 > URL: https://issues.apache.org/jira/browse/HBASE-16696 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: ramkrishna.s.vasudevan > Attachments: build-1638.out, build-1639.out > > > TestBlockEvictionFromClient consistently fails in master branch. > From existing Jenkins builds, looks like this started with build 1639. > See attached Jenkins console logs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16696) TestBlockEvictionFromClient fails in master branch
[ https://issues.apache.org/jira/browse/HBASE-16696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15520688#comment-15520688 ] ramkrishna.s.vasudevan commented on HBASE-16696: I saw multiple issues around this. I will take this up and fix it by tomorrow my time. > TestBlockEvictionFromClient fails in master branch > -- > > Key: HBASE-16696 > URL: https://issues.apache.org/jira/browse/HBASE-16696 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu > Attachments: build-1638.out, build-1639.out > > > TestBlockEvictionFromClient consistently fails in master branch. > From existing Jenkins builds, looks like this started with build 1639. > See attached Jenkins console logs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16696) TestBlockEvictionFromClient fails in master branch
[ https://issues.apache.org/jira/browse/HBASE-16696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517059#comment-15517059 ] Ted Yu commented on HBASE-16696: The first failed sub-test is testScanWithException. After commenting out testScanWithException, the other tests pass. > TestBlockEvictionFromClient fails in master branch > -- > > Key: HBASE-16696 > URL: https://issues.apache.org/jira/browse/HBASE-16696 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu > Attachments: build-1638.out, build-1639.out > > > TestBlockEvictionFromClient consistently fails in master branch. > From existing Jenkins builds, looks like this started with build 1639. > See attached Jenkins console logs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16696) TestBlockEvictionFromClient fails in master branch
[ https://issues.apache.org/jira/browse/HBASE-16696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517032#comment-15517032 ] ramkrishna.s.vasudevan commented on HBASE-16696: I can check this. Internal to initiate scan we do latch counting so the test works based on that. Why suddenly this test became flakey? May be something to do with test case only. > TestBlockEvictionFromClient fails in master branch > -- > > Key: HBASE-16696 > URL: https://issues.apache.org/jira/browse/HBASE-16696 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu > Attachments: build-1638.out, build-1639.out > > > TestBlockEvictionFromClient consistently fails in master branch. > From existing Jenkins builds, looks like this started with build 1639. > See attached Jenkins console logs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16696) TestBlockEvictionFromClient fails in master branch
[
https://issues.apache.org/jira/browse/HBASE-16696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516995#comment-15516995
]
Anoop Sam John commented on HBASE-16696:
Is this a flaky test from long time?
{code}
ScanThread[] scanThreads = initiateScan(table, true);
Thread.sleep(200);
Iterator iterator = cache.iterator();
boolean usedBlocksFound = false;
int refCount = 0;
int noOfBlocksWithRef = 0;
while (iterator.hasNext()) {
CachedBlock next = iterator.next();
BlockCacheKey cacheKey = new BlockCacheKey(next.getFilename(),
next.getOffset());
if (cache instanceof BucketCache) {
refCount = ((BucketCache) cache).getRefCount(cacheKey);
} else if (cache instanceof CombinedBlockCache) {
refCount = ((CombinedBlockCache) cache).getRefCount(cacheKey);
} else {
continue;
}
if (refCount != 0) {
// Blocks will be with count 3
System.out.println("The refCount is " + refCount);
assertEquals(NO_OF_THREADS, refCount);
{code}
3 scanner threads were started and we sleep for 200 msec and then assert that
blocks have 3 as ref count. What is a scan got completed in btw? Then that
ref count dec would have happened. Ping [~ram_krish]
> TestBlockEvictionFromClient fails in master branch
> --
>
> Key: HBASE-16696
> URL: https://issues.apache.org/jira/browse/HBASE-16696
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
> Attachments: build-1638.out, build-1639.out
>
>
> TestBlockEvictionFromClient consistently fails in master branch.
> From existing Jenkins builds, looks like this started with build 1639.
> See attached Jenkins console logs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16696) TestBlockEvictionFromClient fails in master branch
[ https://issues.apache.org/jira/browse/HBASE-16696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516947#comment-15516947 ] Anoop Sam John commented on HBASE-16696: bq.Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 84.541 sec - in org.apache.hadoop.hbase.client.TestBlockEvictionFromClient > TestBlockEvictionFromClient fails in master branch > -- > > Key: HBASE-16696 > URL: https://issues.apache.org/jira/browse/HBASE-16696 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu > Attachments: build-1638.out, build-1639.out > > > TestBlockEvictionFromClient consistently fails in master branch. > From existing Jenkins builds, looks like this started with build 1639. > See attached Jenkins console logs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
