[jira] [Commented] (HBASE-16725) Don't let flushThread hang in TestHRegion
[ https://issues.apache.org/jira/browse/HBASE-16725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15533987#comment-15533987 ] Hudson commented on HBASE-16725: SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #1696 (See [https://builds.apache.org/job/HBase-Trunk_matrix/1696/]) HBASE-16725 Don't let flushThread hang in TestHRegion (tedyu: rev 63808a224c8689d07e55f90efd25f9597b0d04dd) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java > Don't let flushThread hang in TestHRegion > - > > Key: HBASE-16725 > URL: https://issues.apache.org/jira/browse/HBASE-16725 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Attachments: 16725.branch-1.v1.txt, 16725.branch-1.v2.txt, > 16725.v2.txt > > > I was running TestHRegion locally and observed the following in test output: > {code} > 2016-09-28 16:29:36,836 INFO [main] hbase.ResourceChecker(171): after: > regionserver.TestHRegion#testFlushCacheWhileScanning Thread=50 (was 49) > Potentially hanging thread: FlushThread > java.lang.Object.wait(Native Method) > java.lang.Object.wait(Object.java:502) > > org.apache.hadoop.hbase.regionserver.TestHRegion$FlushThread.run(TestHRegion.java:3834) > {code} > Call to flushThread.done() etc should be placed in the finally block. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16725) Don't let flushThread hang in TestHRegion
[ https://issues.apache.org/jira/browse/HBASE-16725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15533550#comment-15533550 ] Hudson commented on HBASE-16725: FAILURE: Integrated in Jenkins build HBase-1.4 #436 (See [https://builds.apache.org/job/HBase-1.4/436/]) HBASE-16725 Don't let flushThread hang in TestHRegion (tedyu: rev df578592582059e08fcbbb8a0bc6b950a9768323) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java > Don't let flushThread hang in TestHRegion > - > > Key: HBASE-16725 > URL: https://issues.apache.org/jira/browse/HBASE-16725 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Attachments: 16725.branch-1.v1.txt, 16725.branch-1.v2.txt, > 16725.v2.txt > > > I was running TestHRegion locally and observed the following in test output: > {code} > 2016-09-28 16:29:36,836 INFO [main] hbase.ResourceChecker(171): after: > regionserver.TestHRegion#testFlushCacheWhileScanning Thread=50 (was 49) > Potentially hanging thread: FlushThread > java.lang.Object.wait(Native Method) > java.lang.Object.wait(Object.java:502) > > org.apache.hadoop.hbase.regionserver.TestHRegion$FlushThread.run(TestHRegion.java:3834) > {code} > Call to flushThread.done() etc should be placed in the finally block. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16725) Don't let flushThread hang in TestHRegion
[ https://issues.apache.org/jira/browse/HBASE-16725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532209#comment-15532209 ] Ted Yu commented on HBASE-16725: The following tests extend HRegion which passed in the QA run: {code} hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoadWithOldClient.java:public class TestHRegionServerBulkLoadWithOldClient extends TestHRegio hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoadWithOldSecureEndpoint.java:public class TestHRegionServerBulkLoadWithOldSecureEndpoint ex hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionWithInMemoryFlush.java:public class TestHRegionWithInMemoryFlush extends TestHRegion{ {code} > Don't let flushThread hang in TestHRegion > - > > Key: HBASE-16725 > URL: https://issues.apache.org/jira/browse/HBASE-16725 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Attachments: 16725.branch-1.v1.txt, 16725.branch-1.v2.txt, > 16725.v2.txt > > > I was running TestHRegion locally and observed the following in test output: > {code} > 2016-09-28 16:29:36,836 INFO [main] hbase.ResourceChecker(171): after: > regionserver.TestHRegion#testFlushCacheWhileScanning Thread=50 (was 49) > Potentially hanging thread: FlushThread > java.lang.Object.wait(Native Method) > java.lang.Object.wait(Object.java:502) > > org.apache.hadoop.hbase.regionserver.TestHRegion$FlushThread.run(TestHRegion.java:3834) > {code} > Call to flushThread.done() etc should be placed in the finally block. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16725) Don't let flushThread hang in TestHRegion
[ https://issues.apache.org/jira/browse/HBASE-16725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15531815#comment-15531815 ] stack commented on HBASE-16725: --- +1 I don't see how the failures are related given a patch for a test. Are the failing tests subclassing or reusing this part of TestHRegion? > Don't let flushThread hang in TestHRegion > - > > Key: HBASE-16725 > URL: https://issues.apache.org/jira/browse/HBASE-16725 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > Attachments: 16725.branch-1.v1.txt, 16725.branch-1.v2.txt, > 16725.v2.txt > > > I was running TestHRegion locally and observed the following in test output: > {code} > 2016-09-28 16:29:36,836 INFO [main] hbase.ResourceChecker(171): after: > regionserver.TestHRegion#testFlushCacheWhileScanning Thread=50 (was 49) > Potentially hanging thread: FlushThread > java.lang.Object.wait(Native Method) > java.lang.Object.wait(Object.java:502) > > org.apache.hadoop.hbase.regionserver.TestHRegion$FlushThread.run(TestHRegion.java:3834) > {code} > Call to flushThread.done() etc should be placed in the finally block. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16725) Don't let flushThread hang in TestHRegion
[ https://issues.apache.org/jira/browse/HBASE-16725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15531801#comment-15531801 ] Hadoop QA commented on HBASE-16725: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 14s {color} | {color:blue} Docker mode activated. {color} | | {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m 2s {color} | {color:blue} The patch file was not named according to hbase's naming conventions. Please see https://yetus.apache.org/documentation/0.3.0/precommit-patchnames for instructions. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 45s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 39s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 48s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 16s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 55s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 33s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 47s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 34s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 34s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 46s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 14s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 29m 35s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 14s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 16s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 32s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 89m 54s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 16s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 133m 41s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Timed out junit tests | org.apache.hadoop.hbase.client.TestReplicasClient | | | org.apache.hadoop.hbase.client.TestFromClientSide | | | org.apache.hadoop.hbase.client.TestIncrementFromClientSideWithCoprocessor | | | org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClient | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:7bda515 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12830840/16725.v2.txt | | JIRA Issue | HBASE-16725 | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 92fca99b17f9 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh | | git revision | master / 09a31bd | | Default Java | 1.8.0_101 | | findbugs | v3.0.0 | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/3767/artifact/patchprocess/patch-unit-hbase-server.txt | | unit test logs | https://builds.apache.org/job/PreCommit-HBASE-Build/3767/artifact/patchprocess/patch-unit-hbase-server.txt | | Test
[jira] [Commented] (HBASE-16725) Don't let flushThread hang in TestHRegion
[ https://issues.apache.org/jira/browse/HBASE-16725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15531511#comment-15531511 ] Appy commented on HBASE-16725: -- +1 minor suggestion: Prefer using String.format in such cases. {noformat}"toggle="+toggle+"i=" + i + " ts="+System.currentTimeMillis() {noformat} > Don't let flushThread hang in TestHRegion > - > > Key: HBASE-16725 > URL: https://issues.apache.org/jira/browse/HBASE-16725 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Priority: Minor > Attachments: 16725.branch-1.v1.txt, 16725.branch-1.v2.txt > > > I was running TestHRegion locally and observed the following in test output: > {code} > 2016-09-28 16:29:36,836 INFO [main] hbase.ResourceChecker(171): after: > regionserver.TestHRegion#testFlushCacheWhileScanning Thread=50 (was 49) > Potentially hanging thread: FlushThread > java.lang.Object.wait(Native Method) > java.lang.Object.wait(Object.java:502) > > org.apache.hadoop.hbase.regionserver.TestHRegion$FlushThread.run(TestHRegion.java:3834) > {code} > Call to flushThread.done() etc should be placed in the finally block. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16725) Don't let flushThread hang in TestHRegion
[ https://issues.apache.org/jira/browse/HBASE-16725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15531037#comment-15531037 ] Hadoop QA commented on HBASE-16725: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 18s {color} | {color:blue} Docker mode activated. {color} | | {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m 1s {color} | {color:blue} The patch file was not named according to hbase's naming conventions. Please see https://yetus.apache.org/documentation/0.3.0/precommit-patchnames for instructions. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 8s {color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 35s {color} | {color:green} branch-1 passed with JDK v1.8.0_101 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 37s {color} | {color:green} branch-1 passed with JDK v1.7.0_111 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 56s {color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 16s {color} | {color:green} branch-1 passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 1s {color} | {color:red} hbase-server in branch-1 has 1 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 27s {color} | {color:green} branch-1 passed with JDK v1.8.0_101 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 35s {color} | {color:green} branch-1 passed with JDK v1.7.0_111 {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 50s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 38s {color} | {color:green} the patch passed with JDK v1.8.0_101 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 38s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 35s {color} | {color:green} the patch passed with JDK v1.7.0_111 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 35s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 55s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 16s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 16m 49s {color} | {color:green} The patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 14s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 11s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 25s {color} | {color:green} the patch passed with JDK v1.8.0_101 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 34s {color} | {color:green} the patch passed with JDK v1.7.0_111 {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 92m 34s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 18s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 124m 47s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.replication.regionserver.TestReplicationSourceManager | | | hadoop.hbase.mapred.TestMultiTableSnapshotInputFormat | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:date2016-09-28 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12830775/16725.branch-1.v2.txt | | JIRA Issue |
[jira] [Commented] (HBASE-16725) Don't let flushThread hang in TestHRegion
[ https://issues.apache.org/jira/browse/HBASE-16725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530592#comment-15530592 ] stack commented on HBASE-16725: --- The potentially hanging thread is real helpful. Sometimes it is just a lagging thread but no danger of zombies if no hanging thread at end of a test run. > Don't let flushThread hang in TestHRegion > - > > Key: HBASE-16725 > URL: https://issues.apache.org/jira/browse/HBASE-16725 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Priority: Minor > Attachments: 16725.branch-1.v1.txt > > > I was running TestHRegion locally and observed the following in test output: > {code} > 2016-09-28 16:29:36,836 INFO [main] hbase.ResourceChecker(171): after: > regionserver.TestHRegion#testFlushCacheWhileScanning Thread=50 (was 49) > Potentially hanging thread: FlushThread > java.lang.Object.wait(Native Method) > java.lang.Object.wait(Object.java:502) > > org.apache.hadoop.hbase.regionserver.TestHRegion$FlushThread.run(TestHRegion.java:3834) > {code} > Call to flushThread.done() etc should be placed in the finally block. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16725) Don't let flushThread hang in TestHRegion
[ https://issues.apache.org/jira/browse/HBASE-16725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530586#comment-15530586 ] Hadoop QA commented on HBASE-16725: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 18s {color} | {color:blue} Docker mode activated. {color} | | {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m 3s {color} | {color:blue} The patch file was not named according to hbase's naming conventions. Please see https://yetus.apache.org/documentation/0.3.0/precommit-patchnames for instructions. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 16s {color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 37s {color} | {color:green} branch-1 passed with JDK v1.8.0_101 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 35s {color} | {color:green} branch-1 passed with JDK v1.7.0_111 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 56s {color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 19s {color} | {color:green} branch-1 passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 4s {color} | {color:red} hbase-server in branch-1 has 1 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 29s {color} | {color:green} branch-1 passed with JDK v1.8.0_101 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 35s {color} | {color:green} branch-1 passed with JDK v1.7.0_111 {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 48s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 34s {color} | {color:green} the patch passed with JDK v1.8.0_101 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 34s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 35s {color} | {color:green} the patch passed with JDK v1.7.0_111 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 35s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 56s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 17s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 16m 56s {color} | {color:green} The patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 15s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 11s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 27s {color} | {color:green} the patch passed with JDK v1.8.0_101 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 35s {color} | {color:green} the patch passed with JDK v1.7.0_111 {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 83m 48s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 23s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 116m 25s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.replication.TestSerialReplication | | | hadoop.hbase.replication.regionserver.TestReplicationSourceManager | | | hadoop.hbase.regionserver.TestHRegion | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:date2016-09-28 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12830744/
[jira] [Commented] (HBASE-16725) Don't let flushThread hang in TestHRegion
[ https://issues.apache.org/jira/browse/HBASE-16725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530547#comment-15530547 ] Appy commented on HBASE-16725: -- Maybe put other thread joins also in finally? {noformat} putThread.join(); putThread.checkNoError(); {noformat} Also, we should check for interrupted exception from join() otherwise we'll fail to close region and wal. As a side question, how accurate are "potentially hanging thread" notifications? [~stack] your thoughts please. > Don't let flushThread hang in TestHRegion > - > > Key: HBASE-16725 > URL: https://issues.apache.org/jira/browse/HBASE-16725 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Priority: Minor > Attachments: 16725.branch-1.v1.txt > > > I was running TestHRegion locally and observed the following in test output: > {code} > 2016-09-28 16:29:36,836 INFO [main] hbase.ResourceChecker(171): after: > regionserver.TestHRegion#testFlushCacheWhileScanning Thread=50 (was 49) > Potentially hanging thread: FlushThread > java.lang.Object.wait(Native Method) > java.lang.Object.wait(Object.java:502) > > org.apache.hadoop.hbase.regionserver.TestHRegion$FlushThread.run(TestHRegion.java:3834) > {code} > Call to flushThread.done() etc should be placed in the finally block. -- This message was sent by Atlassian JIRA (v6.3.4#6332)