[jira] [Commented] (HBASE-17058) Lower epsilon used for jitter verification from HBASE-15324

2016-11-17 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675531#comment-15675531
 ] 

Hudson commented on HBASE-17058:


SUCCESS: Integrated in Jenkins build HBase-1.2-JDK7 #72 (See 
[https://builds.apache.org/job/HBase-1.2-JDK7/72/])
HBASE-17058 Lower epsilon used for jitter verification from HBASE-15324 
(esteban: rev bb891c6834a0691302b958d78e0c009b3601c442)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java


> Lower epsilon used for jitter verification from HBASE-15324
> ---
>
> Key: HBASE-17058
> URL: https://issues.apache.org/jira/browse/HBASE-17058
> Project: HBase
>  Issue Type: Bug
>  Components: Compaction
>Affects Versions: 2.0.0, 1.3.0, 1.4.0, 1.1.7, 1.2.4
>Reporter: Esteban Gutierrez
>Assignee: Esteban Gutierrez
> Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.8
>
> Attachments: HBASE-17058.master.001.patch
>
>
> The current epsilon used is 1E-6 and its too big it might overflow the 
> desiredMaxFileSize. A trivial fix is to lower the epsilon to 2^-52 or even 
> 2^-53. An option to consider too is just to shift the jitter to always 
> decrement hbase.hregion.max.filesize (MAX_FILESIZE) instead of increase the 
> size of the region and having to deal with the round off.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-17058) Lower epsilon used for jitter verification from HBASE-15324

2016-11-17 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675494#comment-15675494
 ] 

Hudson commented on HBASE-17058:


SUCCESS: Integrated in Jenkins build HBase-1.4 #538 (See 
[https://builds.apache.org/job/HBase-1.4/538/])
HBASE-17058 Lower epsilon used for jitter verification from HBASE-15324 
(esteban: rev 19441937ea688b6798675993c6af4a961f931c3a)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java


> Lower epsilon used for jitter verification from HBASE-15324
> ---
>
> Key: HBASE-17058
> URL: https://issues.apache.org/jira/browse/HBASE-17058
> Project: HBase
>  Issue Type: Bug
>  Components: Compaction
>Affects Versions: 2.0.0, 1.3.0, 1.4.0, 1.1.7, 1.2.4
>Reporter: Esteban Gutierrez
>Assignee: Esteban Gutierrez
> Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.8
>
> Attachments: HBASE-17058.master.001.patch
>
>
> The current epsilon used is 1E-6 and its too big it might overflow the 
> desiredMaxFileSize. A trivial fix is to lower the epsilon to 2^-52 or even 
> 2^-53. An option to consider too is just to shift the jitter to always 
> decrement hbase.hregion.max.filesize (MAX_FILESIZE) instead of increase the 
> size of the region and having to deal with the round off.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-17058) Lower epsilon used for jitter verification from HBASE-15324

2016-11-17 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675410#comment-15675410
 ] 

Hudson commented on HBASE-17058:


SUCCESS: Integrated in Jenkins build HBase-1.3-JDK8 #80 (See 
[https://builds.apache.org/job/HBase-1.3-JDK8/80/])
HBASE-17058 Lower epsilon used for jitter verification from HBASE-15324 
(esteban: rev f4ed43e06108687488ebb161086b00274d172bc0)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java


> Lower epsilon used for jitter verification from HBASE-15324
> ---
>
> Key: HBASE-17058
> URL: https://issues.apache.org/jira/browse/HBASE-17058
> Project: HBase
>  Issue Type: Bug
>  Components: Compaction
>Affects Versions: 2.0.0, 1.3.0, 1.4.0, 1.1.7, 1.2.4
>Reporter: Esteban Gutierrez
>Assignee: Esteban Gutierrez
> Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.8
>
> Attachments: HBASE-17058.master.001.patch
>
>
> The current epsilon used is 1E-6 and its too big it might overflow the 
> desiredMaxFileSize. A trivial fix is to lower the epsilon to 2^-52 or even 
> 2^-53. An option to consider too is just to shift the jitter to always 
> decrement hbase.hregion.max.filesize (MAX_FILESIZE) instead of increase the 
> size of the region and having to deal with the round off.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-17058) Lower epsilon used for jitter verification from HBASE-15324

2016-11-17 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675399#comment-15675399
 ] 

Hudson commented on HBASE-17058:


SUCCESS: Integrated in Jenkins build HBase-1.2-JDK8 #66 (See 
[https://builds.apache.org/job/HBase-1.2-JDK8/66/])
HBASE-17058 Lower epsilon used for jitter verification from HBASE-15324 
(esteban: rev bb891c6834a0691302b958d78e0c009b3601c442)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java


> Lower epsilon used for jitter verification from HBASE-15324
> ---
>
> Key: HBASE-17058
> URL: https://issues.apache.org/jira/browse/HBASE-17058
> Project: HBase
>  Issue Type: Bug
>  Components: Compaction
>Affects Versions: 2.0.0, 1.3.0, 1.4.0, 1.1.7, 1.2.4
>Reporter: Esteban Gutierrez
>Assignee: Esteban Gutierrez
> Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.8
>
> Attachments: HBASE-17058.master.001.patch
>
>
> The current epsilon used is 1E-6 and its too big it might overflow the 
> desiredMaxFileSize. A trivial fix is to lower the epsilon to 2^-52 or even 
> 2^-53. An option to consider too is just to shift the jitter to always 
> decrement hbase.hregion.max.filesize (MAX_FILESIZE) instead of increase the 
> size of the region and having to deal with the round off.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-17058) Lower epsilon used for jitter verification from HBASE-15324

2016-11-17 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675210#comment-15675210
 ] 

Hudson commented on HBASE-17058:


SUCCESS: Integrated in Jenkins build HBase-1.1-JDK7 #1820 (See 
[https://builds.apache.org/job/HBase-1.1-JDK7/1820/])
HBASE-17058 Lower epsilon used for jitter verification from HBASE-15324 
(esteban: rev 7c58547a37c85a148f481398819badd7c26129bc)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java


> Lower epsilon used for jitter verification from HBASE-15324
> ---
>
> Key: HBASE-17058
> URL: https://issues.apache.org/jira/browse/HBASE-17058
> Project: HBase
>  Issue Type: Bug
>  Components: Compaction
>Affects Versions: 2.0.0, 1.3.0, 1.4.0, 1.1.7, 1.2.4
>Reporter: Esteban Gutierrez
>Assignee: Esteban Gutierrez
> Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.8
>
> Attachments: HBASE-17058.master.001.patch
>
>
> The current epsilon used is 1E-6 and its too big it might overflow the 
> desiredMaxFileSize. A trivial fix is to lower the epsilon to 2^-52 or even 
> 2^-53. An option to consider too is just to shift the jitter to always 
> decrement hbase.hregion.max.filesize (MAX_FILESIZE) instead of increase the 
> size of the region and having to deal with the round off.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-17058) Lower epsilon used for jitter verification from HBASE-15324

2016-11-17 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675189#comment-15675189
 ] 

Hudson commented on HBASE-17058:


SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #1971 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/1971/])
HBASE-17058 Lower epsilon used for jitter verification from HBASE-15324 
(esteban: rev 7c6e839f6a98cf2c3ed37109318632db13b4a0df)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java


> Lower epsilon used for jitter verification from HBASE-15324
> ---
>
> Key: HBASE-17058
> URL: https://issues.apache.org/jira/browse/HBASE-17058
> Project: HBase
>  Issue Type: Bug
>  Components: Compaction
>Affects Versions: 2.0.0, 1.3.0, 1.4.0, 1.1.7, 1.2.4
>Reporter: Esteban Gutierrez
>Assignee: Esteban Gutierrez
> Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.8
>
> Attachments: HBASE-17058.master.001.patch
>
>
> The current epsilon used is 1E-6 and its too big it might overflow the 
> desiredMaxFileSize. A trivial fix is to lower the epsilon to 2^-52 or even 
> 2^-53. An option to consider too is just to shift the jitter to always 
> decrement hbase.hregion.max.filesize (MAX_FILESIZE) instead of increase the 
> size of the region and having to deal with the round off.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-17058) Lower epsilon used for jitter verification from HBASE-15324

2016-11-17 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675185#comment-15675185
 ] 

Hudson commented on HBASE-17058:


SUCCESS: Integrated in Jenkins build HBase-1.3-JDK7 #69 (See 
[https://builds.apache.org/job/HBase-1.3-JDK7/69/])
HBASE-17058 Lower epsilon used for jitter verification from HBASE-15324 
(esteban: rev f4ed43e06108687488ebb161086b00274d172bc0)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java


> Lower epsilon used for jitter verification from HBASE-15324
> ---
>
> Key: HBASE-17058
> URL: https://issues.apache.org/jira/browse/HBASE-17058
> Project: HBase
>  Issue Type: Bug
>  Components: Compaction
>Affects Versions: 2.0.0, 1.3.0, 1.4.0, 1.1.7, 1.2.4
>Reporter: Esteban Gutierrez
>Assignee: Esteban Gutierrez
> Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.8
>
> Attachments: HBASE-17058.master.001.patch
>
>
> The current epsilon used is 1E-6 and its too big it might overflow the 
> desiredMaxFileSize. A trivial fix is to lower the epsilon to 2^-52 or even 
> 2^-53. An option to consider too is just to shift the jitter to always 
> decrement hbase.hregion.max.filesize (MAX_FILESIZE) instead of increase the 
> size of the region and having to deal with the round off.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-17058) Lower epsilon used for jitter verification from HBASE-15324

2016-11-17 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675177#comment-15675177
 ] 

Hudson commented on HBASE-17058:


SUCCESS: Integrated in Jenkins build HBase-1.1-JDK8 #1904 (See 
[https://builds.apache.org/job/HBase-1.1-JDK8/1904/])
HBASE-17058 Lower epsilon used for jitter verification from HBASE-15324 
(esteban: rev 7c58547a37c85a148f481398819badd7c26129bc)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java


> Lower epsilon used for jitter verification from HBASE-15324
> ---
>
> Key: HBASE-17058
> URL: https://issues.apache.org/jira/browse/HBASE-17058
> Project: HBase
>  Issue Type: Bug
>  Components: Compaction
>Affects Versions: 2.0.0, 1.3.0, 1.4.0, 1.1.7, 1.2.4
>Reporter: Esteban Gutierrez
>Assignee: Esteban Gutierrez
> Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.8
>
> Attachments: HBASE-17058.master.001.patch
>
>
> The current epsilon used is 1E-6 and its too big it might overflow the 
> desiredMaxFileSize. A trivial fix is to lower the epsilon to 2^-52 or even 
> 2^-53. An option to consider too is just to shift the jitter to always 
> decrement hbase.hregion.max.filesize (MAX_FILESIZE) instead of increase the 
> size of the region and having to deal with the round off.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-17058) Lower epsilon used for jitter verification from HBASE-15324

2016-11-17 Thread huaxiang sun (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15674529#comment-15674529
 ] 

huaxiang sun commented on HBASE-17058:
--

Sorry, a late +1 from me, thanks.

> Lower epsilon used for jitter verification from HBASE-15324
> ---
>
> Key: HBASE-17058
> URL: https://issues.apache.org/jira/browse/HBASE-17058
> Project: HBase
>  Issue Type: Bug
>  Components: Compaction
>Affects Versions: 2.0.0, 1.3.0, 1.4.0, 1.1.7, 1.2.4
>Reporter: Esteban Gutierrez
>Assignee: Esteban Gutierrez
> Attachments: HBASE-17058.master.001.patch
>
>
> The current epsilon used is 1E-6 and its too big it might overflow the 
> desiredMaxFileSize. A trivial fix is to lower the epsilon to 2^-52 or even 
> 2^-53. An option to consider too is just to shift the jitter to always 
> decrement hbase.hregion.max.filesize (MAX_FILESIZE) instead of increase the 
> size of the region and having to deal with the round off.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-17058) Lower epsilon used for jitter verification from HBASE-15324

2016-11-11 Thread Esteban Gutierrez (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15657581#comment-15657581
 ] 

Esteban Gutierrez commented on HBASE-17058:
---

No unit tests needed, existing unit test from HBASE-15324 is sufficient.


> Lower epsilon used for jitter verification from HBASE-15324
> ---
>
> Key: HBASE-17058
> URL: https://issues.apache.org/jira/browse/HBASE-17058
> Project: HBase
>  Issue Type: Bug
>  Components: Compaction
>Affects Versions: 2.0.0, 1.3.0, 1.4.0, 1.1.7, 1.2.4
>Reporter: Esteban Gutierrez
>Assignee: Esteban Gutierrez
> Attachments: HBASE-17058.master.001.patch
>
>
> The current epsilon used is 1E-6 and its too big it might overflow the 
> desiredMaxFileSize. A trivial fix is to lower the epsilon to 2^-52 or even 
> 2^-53. An option to consider too is just to shift the jitter to always 
> decrement hbase.hregion.max.filesize (MAX_FILESIZE) instead of increase the 
> size of the region and having to deal with the round off.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-17058) Lower epsilon used for jitter verification from HBASE-15324

2016-11-11 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15656934#comment-15656934
 ] 

Hadoop QA commented on HBASE-17058:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 15s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s 
{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 
8s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 35s 
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 
46s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
14s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 
49s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 27s 
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 
48s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 38s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 38s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 
47s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
14s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
29m 23s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 2s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 29s 
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 94m 12s {color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
13s {color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 136m 19s {color} 
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests | 
org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId |
|   | org.apache.hadoop.hbase.client.TestMetaWithReplicas |
|   | org.apache.hadoop.hbase.master.TestMasterWalManager |
|   | org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor |
|   | org.apache.hadoop.hbase.client.TestHCM |
|   | org.apache.hadoop.hbase.client.TestTableSnapshotScanner |
|   | org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClient |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:7bda515 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12838531/HBASE-17058.master.001.patch
 |
| JIRA Issue | HBASE-17058 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  
hbaseanti  checkstyle  compile  |
| uname | Linux 0cc04148cf6a 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 
21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / f9c6b66 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/4435/artifact/patchprocess/patch-unit-hbase-server.txt
 |
| unit test logs |  

[jira] [Commented] (HBASE-17058) Lower epsilon used for jitter verification from HBASE-15324

2016-11-11 Thread Esteban Gutierrez (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15656689#comment-15656689
 ] 

Esteban Gutierrez commented on HBASE-17058:
---

Thanks for the review [~carp84], I will commit tomorrow if there is no other 
objection. 

> Lower epsilon used for jitter verification from HBASE-15324
> ---
>
> Key: HBASE-17058
> URL: https://issues.apache.org/jira/browse/HBASE-17058
> Project: HBase
>  Issue Type: Bug
>  Components: Compaction
>Affects Versions: 2.0.0, 1.3.0, 1.4.0, 1.1.7, 1.2.4
>Reporter: Esteban Gutierrez
>Assignee: Esteban Gutierrez
> Attachments: HBASE-17058.master.001.patch
>
>
> The current epsilon used is 1E-6 and its too big it might overflow the 
> desiredMaxFileSize. A trivial fix is to lower the epsilon to 2^-52 or even 
> 2^-53. An option to consider too is just to shift the jitter to always 
> decrement hbase.hregion.max.filesize (MAX_FILESIZE) instead of increase the 
> size of the region and having to deal with the round off.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-17058) Lower epsilon used for jitter verification from HBASE-15324

2016-11-11 Thread Yu Li (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15656680#comment-15656680
 ] 

Yu Li commented on HBASE-17058:
---

Patch lgtm, +1. Epsilon is a more careful way to check whether a double equals 
to zero and no need for greater/less check. Thanks for the fix [~esteban].

> Lower epsilon used for jitter verification from HBASE-15324
> ---
>
> Key: HBASE-17058
> URL: https://issues.apache.org/jira/browse/HBASE-17058
> Project: HBase
>  Issue Type: Bug
>  Components: Compaction
>Affects Versions: 2.0.0, 1.3.0, 1.4.0, 1.1.7, 1.2.4
>Reporter: Esteban Gutierrez
>Assignee: Esteban Gutierrez
> Attachments: HBASE-17058.master.001.patch
>
>
> The current epsilon used is 1E-6 and its too big it might overflow the 
> desiredMaxFileSize. A trivial fix is to lower the epsilon to 2^-52 or even 
> 2^-53. An option to consider too is just to shift the jitter to always 
> decrement hbase.hregion.max.filesize (MAX_FILESIZE) instead of increase the 
> size of the region and having to deal with the round off.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-17058) Lower epsilon used for jitter verification from HBASE-15324

2016-11-10 Thread Yu Li (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15655605#comment-15655605
 ] 

Yu Li commented on HBASE-17058:
---

Add link to HBASE-15324

> Lower epsilon used for jitter verification from HBASE-15324
> ---
>
> Key: HBASE-17058
> URL: https://issues.apache.org/jira/browse/HBASE-17058
> Project: HBase
>  Issue Type: Bug
>  Components: Compaction
>Affects Versions: 2.0.0, 1.3.0, 1.4.0, 1.1.7, 1.2.4
>Reporter: Esteban Gutierrez
>Assignee: Esteban Gutierrez
>
> The current epsilon used is 1E-6 and its too big it might overflow the 
> desiredMaxFileSize. A trivial fix is to lower the epsilon to 2^-52 or even 
> 2^-53. An option to consider too is just to shift the jitter to always 
> decrement hbase.hregion.max.filesize (MAX_FILESIZE) instead of increase the 
> size of the region and having to deal with the round off.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-17058) Lower epsilon used for jitter verification from HBASE-15324

2016-11-10 Thread huaxiang sun (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15654826#comment-15654826
 ] 

huaxiang sun commented on HBASE-17058:
--

[~esteban] has a fix for this.

> Lower epsilon used for jitter verification from HBASE-15324
> ---
>
> Key: HBASE-17058
> URL: https://issues.apache.org/jira/browse/HBASE-17058
> Project: HBase
>  Issue Type: Bug
>  Components: Compaction
>Affects Versions: 2.0.0, 1.3.0, 1.4.0, 1.1.7, 1.2.4
>Reporter: Esteban Gutierrez
>Assignee: Esteban Gutierrez
>
> The current epsilon used is 1E-6 and its too big it might overflow the 
> desiredMaxFileSize. A trivial fix is to lower the epsilon to 2^-52 or even 
> 2^-53. An option to consider too is just to shift the jitter to always 
> decrement hbase.hregion.max.filesize (MAX_FILESIZE) instead of increase the 
> size of the region and having to deal with the round off.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-17058) Lower epsilon used for jitter verification from HBASE-15324

2016-11-10 Thread huaxiang sun (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-17058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15654824#comment-15654824
 ] 

huaxiang sun commented on HBASE-17058:
--

[~esteban] has a fix for this.

> Lower epsilon used for jitter verification from HBASE-15324
> ---
>
> Key: HBASE-17058
> URL: https://issues.apache.org/jira/browse/HBASE-17058
> Project: HBase
>  Issue Type: Bug
>  Components: Compaction
>Affects Versions: 2.0.0, 1.3.0, 1.4.0, 1.1.7, 1.2.4
>Reporter: Esteban Gutierrez
>Assignee: Esteban Gutierrez
>
> The current epsilon used is 1E-6 and its too big it might overflow the 
> desiredMaxFileSize. A trivial fix is to lower the epsilon to 2^-52 or even 
> 2^-53. An option to consider too is just to shift the jitter to always 
> decrement hbase.hregion.max.filesize (MAX_FILESIZE) instead of increase the 
> size of the region and having to deal with the round off.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)