[jira] [Commented] (HBASE-17092) Both LoadIncrementalHFiles#doBulkLoad() methods should set return value
[ https://issues.apache.org/jira/browse/HBASE-17092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15666139#comment-15666139 ] Hudson commented on HBASE-17092: SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #1949 (See [https://builds.apache.org/job/HBase-Trunk_matrix/1949/]) HBASE-17092 Both LoadIncrementalHFiles#doBulkLoad() methods should set (tedyu: rev c7bdb3017f76726e1233c1b60b229ba485059567) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java > Both LoadIncrementalHFiles#doBulkLoad() methods should set return value > --- > > Key: HBASE-17092 > URL: https://issues.apache.org/jira/browse/HBASE-17092 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 2.0.0 > > Attachments: 17092.v1.txt > > > Currently there are two LoadIncrementalHFiles#doBulkLoad() methods. > One returns a Map: > {code} > public Map doBulkLoad(Map> > map, final Admin admin, > {code} > The other one is void return type. > This issue makes both methods record return value which is used by the run() > method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17092) Both LoadIncrementalHFiles#doBulkLoad() methods should set return value
[ https://issues.apache.org/jira/browse/HBASE-17092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665637#comment-15665637 ] Heng Chen commented on HBASE-17092: --- +1 > Both LoadIncrementalHFiles#doBulkLoad() methods should set return value > --- > > Key: HBASE-17092 > URL: https://issues.apache.org/jira/browse/HBASE-17092 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu > Attachments: 17092.v1.txt > > > Currently there are two LoadIncrementalHFiles#doBulkLoad() methods. > One returns a Map: > {code} > public Map doBulkLoad(Map> > map, final Admin admin, > {code} > The other one is void return type. > This issue makes both methods record return value which is used by the run() > method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17092) Both LoadIncrementalHFiles#doBulkLoad() methods should set return value
[ https://issues.apache.org/jira/browse/HBASE-17092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665552#comment-15665552 ] Ted Yu commented on HBASE-17092: Test failure was not related to the patch. > Both LoadIncrementalHFiles#doBulkLoad() methods should set return value > --- > > Key: HBASE-17092 > URL: https://issues.apache.org/jira/browse/HBASE-17092 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu > Attachments: 17092.v1.txt > > > Currently there are two LoadIncrementalHFiles#doBulkLoad() methods. > One returns a Map: > {code} > public Map doBulkLoad(Map> > map, final Admin admin, > {code} > The other one is void return type. > This issue makes both methods record return value which is used by the run() > method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17092) Both LoadIncrementalHFiles#doBulkLoad() methods should set return value
[ https://issues.apache.org/jira/browse/HBASE-17092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665529#comment-15665529 ] Hadoop QA commented on HBASE-17092: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 14s {color} | {color:blue} Docker mode activated. {color} | | {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m 2s {color} | {color:blue} The patch file was not named according to hbase's naming conventions. Please see https://yetus.apache.org/documentation/0.3.0/precommit-patchnames for instructions. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s {color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s {color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 58s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 33s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 40s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 13s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 32s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 24s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 41s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 32s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 32s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 39s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 14s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 25m 24s {color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha1. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 39s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 24s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 78m 22s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 16s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 115m 4s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Timed out junit tests | org.apache.hadoop.hbase.util.TestCoprocessorScanPolicy | | | org.apache.hadoop.hbase.util.TestMiniClusterLoadEncoded | | | org.apache.hadoop.hbase.util.TestMergeTable | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:7bda515 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12838858/17092.v1.txt | | JIRA Issue | HBASE-17092 | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 00eef08256df 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 6ee2dcf | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/4470/artifact/patchprocess/patch-unit-hbase-server.txt | | unit test logs | https://builds.apache.org/job/PreCommit-HBASE-Build/447