[jira] [Commented] (HBASE-17104) Improve cryptic error message "Memstore size is" on region close
[ https://issues.apache.org/jira/browse/HBASE-17104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17396919#comment-17396919 ] William Volkman commented on HBASE-17104: - Well I might suggest removing the "Impossible!" part as it is happening across all of our region servers whenever HDFS takes longer than 30 seconds with a compaction request. This change is a better clarification than the original message, curious why it's still open? > Improve cryptic error message "Memstore size is" on region close > > > Key: HBASE-17104 > URL: https://issues.apache.org/jira/browse/HBASE-17104 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: Matteo Bertozzi >Assignee: Sahil Aggarwal >Priority: Trivial > Labels: beginner, noob > Attachments: HBASE-17104.master.001 (1) (1).patch, > HBASE-17104.master.001 (1).patch, HBASE-17104.master.001.patch > > > while grepping my RS log for ERROR I found a cryptic > {noformat} > ERROR [RS_CLOSE_REGION-u1604vm:35021-1] regionserver.HRegion(1601): Memstore > size is 33744 > {noformat} > from the code looks like we seems to want to notify the user about the fact > that on close the rs was not able to flush and there were things in the RS. > https://github.com/apache/hbase/blob/c3685760f004450667920144f926383eb307de53/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L1601 > {code} > if (!canFlush) { > this.decrMemstoreSize(new MemstoreSize(memstoreDataSize.get(), > getMemstoreHeapOverhead())); > } else if (memstoreDataSize.get() != 0) { > LOG.error("Memstore size is " + memstoreDataSize.get()); > } > {code} > this should probably not even be an error but a warn or even info, unless we > have puts that specifically asked to not be written to the wal, otherwise > the data in the memstore should be safe in the wals. > In any case it will be nice to have a message describing what is going on and > why we are notifying about the memstore size. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-17104) Improve cryptic error message "Memstore size is" on region close
[ https://issues.apache.org/jira/browse/HBASE-17104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371898#comment-16371898 ] Sahil Aggarwal commented on HBASE-17104: Sorry for the delay here. Earlier we were just logging it as ERROR and continuing further where we are executing post-close hooks for coprocessor and closing the metricregion, I thought that should still continue. Thoughts? > Improve cryptic error message "Memstore size is" on region close > > > Key: HBASE-17104 > URL: https://issues.apache.org/jira/browse/HBASE-17104 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: Matteo Bertozzi >Assignee: Sahil Aggarwal >Priority: Trivial > Labels: beginner, noob > Fix For: 2.0.0 > > Attachments: HBASE-17104.master.001 (1) (1).patch, > HBASE-17104.master.001 (1).patch, HBASE-17104.master.001.patch > > > while grepping my RS log for ERROR I found a cryptic > {noformat} > ERROR [RS_CLOSE_REGION-u1604vm:35021-1] regionserver.HRegion(1601): Memstore > size is 33744 > {noformat} > from the code looks like we seems to want to notify the user about the fact > that on close the rs was not able to flush and there were things in the RS. > https://github.com/apache/hbase/blob/c3685760f004450667920144f926383eb307de53/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L1601 > {code} > if (!canFlush) { > this.decrMemstoreSize(new MemstoreSize(memstoreDataSize.get(), > getMemstoreHeapOverhead())); > } else if (memstoreDataSize.get() != 0) { > LOG.error("Memstore size is " + memstoreDataSize.get()); > } > {code} > this should probably not even be an error but a warn or even info, unless we > have puts that specifically asked to not be written to the wal, otherwise > the data in the memstore should be safe in the wals. > In any case it will be nice to have a message describing what is going on and > why we are notifying about the memstore size. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-17104) Improve cryptic error message "Memstore size is" on region close
[ https://issues.apache.org/jira/browse/HBASE-17104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113572#comment-16113572 ] Ted Yu commented on HBASE-17104: {code} 1695 LOG.error("Impossible! abort=false and memstore not flushed. Memstore size is " + memstoreDataSize.get()); {code} In the above case, shouldn't exception be thrown ? > Improve cryptic error message "Memstore size is" on region close > > > Key: HBASE-17104 > URL: https://issues.apache.org/jira/browse/HBASE-17104 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: Matteo Bertozzi >Assignee: Sahil Aggarwal >Priority: Trivial > Labels: beginner, noob > Fix For: 2.0.0 > > Attachments: HBASE-17104.master.001 (1) (1).patch, > HBASE-17104.master.001 (1).patch, HBASE-17104.master.001.patch > > > while grepping my RS log for ERROR I found a cryptic > {noformat} > ERROR [RS_CLOSE_REGION-u1604vm:35021-1] regionserver.HRegion(1601): Memstore > size is 33744 > {noformat} > from the code looks like we seems to want to notify the user about the fact > that on close the rs was not able to flush and there were things in the RS. > https://github.com/apache/hbase/blob/c3685760f004450667920144f926383eb307de53/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L1601 > {code} > if (!canFlush) { > this.decrMemstoreSize(new MemstoreSize(memstoreDataSize.get(), > getMemstoreHeapOverhead())); > } else if (memstoreDataSize.get() != 0) { > LOG.error("Memstore size is " + memstoreDataSize.get()); > } > {code} > this should probably not even be an error but a warn or even info, unless we > have puts that specifically asked to not be written to the wal, otherwise > the data in the memstore should be safe in the wals. > In any case it will be nice to have a message describing what is going on and > why we are notifying about the memstore size. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17104) Improve cryptic error message "Memstore size is" on region close
[ https://issues.apache.org/jira/browse/HBASE-17104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113569#comment-16113569 ] Ted Yu commented on HBASE-17104: Sahil: QA bot wouldn't run test suite if the status for JIRA is "In Progress". > Improve cryptic error message "Memstore size is" on region close > > > Key: HBASE-17104 > URL: https://issues.apache.org/jira/browse/HBASE-17104 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: Matteo Bertozzi >Assignee: Sahil Aggarwal >Priority: Trivial > Labels: beginner, noob > Fix For: 2.0.0 > > Attachments: HBASE-17104.master.001 (1) (1).patch, > HBASE-17104.master.001 (1).patch, HBASE-17104.master.001.patch > > > while grepping my RS log for ERROR I found a cryptic > {noformat} > ERROR [RS_CLOSE_REGION-u1604vm:35021-1] regionserver.HRegion(1601): Memstore > size is 33744 > {noformat} > from the code looks like we seems to want to notify the user about the fact > that on close the rs was not able to flush and there were things in the RS. > https://github.com/apache/hbase/blob/c3685760f004450667920144f926383eb307de53/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L1601 > {code} > if (!canFlush) { > this.decrMemstoreSize(new MemstoreSize(memstoreDataSize.get(), > getMemstoreHeapOverhead())); > } else if (memstoreDataSize.get() != 0) { > LOG.error("Memstore size is " + memstoreDataSize.get()); > } > {code} > this should probably not even be an error but a warn or even info, unless we > have puts that specifically asked to not be written to the wal, otherwise > the data in the memstore should be safe in the wals. > In any case it will be nice to have a message describing what is going on and > why we are notifying about the memstore size. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17104) Improve cryptic error message "Memstore size is" on region close
[ https://issues.apache.org/jira/browse/HBASE-17104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111311#comment-16111311 ] Chia-Ping Tsai commented on HBASE-17104: [~awked06] Could you re-submit the patch for triggering the QA? > Improve cryptic error message "Memstore size is" on region close > > > Key: HBASE-17104 > URL: https://issues.apache.org/jira/browse/HBASE-17104 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: Matteo Bertozzi >Assignee: Sahil Aggarwal >Priority: Trivial > Labels: beginner, noob > Fix For: 2.0.0 > > Attachments: HBASE-17104.master.001 (1).patch, > HBASE-17104.master.001.patch > > > while grepping my RS log for ERROR I found a cryptic > {noformat} > ERROR [RS_CLOSE_REGION-u1604vm:35021-1] regionserver.HRegion(1601): Memstore > size is 33744 > {noformat} > from the code looks like we seems to want to notify the user about the fact > that on close the rs was not able to flush and there were things in the RS. > https://github.com/apache/hbase/blob/c3685760f004450667920144f926383eb307de53/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L1601 > {code} > if (!canFlush) { > this.decrMemstoreSize(new MemstoreSize(memstoreDataSize.get(), > getMemstoreHeapOverhead())); > } else if (memstoreDataSize.get() != 0) { > LOG.error("Memstore size is " + memstoreDataSize.get()); > } > {code} > this should probably not even be an error but a warn or even info, unless we > have puts that specifically asked to not be written to the wal, otherwise > the data in the memstore should be safe in the wals. > In any case it will be nice to have a message describing what is going on and > why we are notifying about the memstore size. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17104) Improve cryptic error message "Memstore size is" on region close
[ https://issues.apache.org/jira/browse/HBASE-17104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110233#comment-16110233 ] Sahil Aggarwal commented on HBASE-17104: How do i request for review? > Improve cryptic error message "Memstore size is" on region close > > > Key: HBASE-17104 > URL: https://issues.apache.org/jira/browse/HBASE-17104 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: Matteo Bertozzi >Assignee: Sahil Aggarwal >Priority: Trivial > Labels: beginner, noob > Fix For: 2.0.0 > > Attachments: HBASE-17104.master.001 (1).patch, > HBASE-17104.master.001.patch > > > while grepping my RS log for ERROR I found a cryptic > {noformat} > ERROR [RS_CLOSE_REGION-u1604vm:35021-1] regionserver.HRegion(1601): Memstore > size is 33744 > {noformat} > from the code looks like we seems to want to notify the user about the fact > that on close the rs was not able to flush and there were things in the RS. > https://github.com/apache/hbase/blob/c3685760f004450667920144f926383eb307de53/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L1601 > {code} > if (!canFlush) { > this.decrMemstoreSize(new MemstoreSize(memstoreDataSize.get(), > getMemstoreHeapOverhead())); > } else if (memstoreDataSize.get() != 0) { > LOG.error("Memstore size is " + memstoreDataSize.get()); > } > {code} > this should probably not even be an error but a warn or even info, unless we > have puts that specifically asked to not be written to the wal, otherwise > the data in the memstore should be safe in the wals. > In any case it will be nice to have a message describing what is going on and > why we are notifying about the memstore size. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17104) Improve cryptic error message "Memstore size is" on region close
[ https://issues.apache.org/jira/browse/HBASE-17104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833288#comment-15833288 ] Sahil Aggarwal commented on HBASE-17104: Thanks [~yuzhih...@gmail.com] and [~stack] > Improve cryptic error message "Memstore size is" on region close > > > Key: HBASE-17104 > URL: https://issues.apache.org/jira/browse/HBASE-17104 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: Matteo Bertozzi >Assignee: Sahil Aggarwal >Priority: Trivial > Labels: beginner, noob > Fix For: 2.0.0 > > Attachments: HBASE-17104.master.001.patch > > > while grepping my RS log for ERROR I found a cryptic > {noformat} > ERROR [RS_CLOSE_REGION-u1604vm:35021-1] regionserver.HRegion(1601): Memstore > size is 33744 > {noformat} > from the code looks like we seems to want to notify the user about the fact > that on close the rs was not able to flush and there were things in the RS. > https://github.com/apache/hbase/blob/c3685760f004450667920144f926383eb307de53/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L1601 > {code} > if (!canFlush) { > this.decrMemstoreSize(new MemstoreSize(memstoreDataSize.get(), > getMemstoreHeapOverhead())); > } else if (memstoreDataSize.get() != 0) { > LOG.error("Memstore size is " + memstoreDataSize.get()); > } > {code} > this should probably not even be an error but a warn or even info, unless we > have puts that specifically asked to not be written to the wal, otherwise > the data in the memstore should be safe in the wals. > In any case it will be nice to have a message describing what is going on and > why we are notifying about the memstore size. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17104) Improve cryptic error message "Memstore size is" on region close
[ https://issues.apache.org/jira/browse/HBASE-17104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833082#comment-15833082 ] stack commented on HBASE-17104: --- [~awked06] Please retry. submit-patch.py is the ordained way of posting patches. I added you as a contributor. That is probably why it was failing. Thank you. > Improve cryptic error message "Memstore size is" on region close > > > Key: HBASE-17104 > URL: https://issues.apache.org/jira/browse/HBASE-17104 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: Matteo Bertozzi >Assignee: Sahil Aggarwal >Priority: Trivial > Labels: beginner, noob > Fix For: 2.0.0 > > > while grepping my RS log for ERROR I found a cryptic > {noformat} > ERROR [RS_CLOSE_REGION-u1604vm:35021-1] regionserver.HRegion(1601): Memstore > size is 33744 > {noformat} > from the code looks like we seems to want to notify the user about the fact > that on close the rs was not able to flush and there were things in the RS. > https://github.com/apache/hbase/blob/c3685760f004450667920144f926383eb307de53/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L1601 > {code} > if (!canFlush) { > this.decrMemstoreSize(new MemstoreSize(memstoreDataSize.get(), > getMemstoreHeapOverhead())); > } else if (memstoreDataSize.get() != 0) { > LOG.error("Memstore size is " + memstoreDataSize.get()); > } > {code} > this should probably not even be an error but a warn or even info, unless we > have puts that specifically asked to not be written to the wal, otherwise > the data in the memstore should be safe in the wals. > In any case it will be nice to have a message describing what is going on and > why we are notifying about the memstore size. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17104) Improve cryptic error message "Memstore size is" on region close
[ https://issues.apache.org/jira/browse/HBASE-17104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833059#comment-15833059 ] Ted Yu commented on HBASE-17104: You can attach patch to this JIRA. > Improve cryptic error message "Memstore size is" on region close > > > Key: HBASE-17104 > URL: https://issues.apache.org/jira/browse/HBASE-17104 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: Matteo Bertozzi >Priority: Trivial > Labels: beginner, noob > Fix For: 2.0.0 > > > while grepping my RS log for ERROR I found a cryptic > {noformat} > ERROR [RS_CLOSE_REGION-u1604vm:35021-1] regionserver.HRegion(1601): Memstore > size is 33744 > {noformat} > from the code looks like we seems to want to notify the user about the fact > that on close the rs was not able to flush and there were things in the RS. > https://github.com/apache/hbase/blob/c3685760f004450667920144f926383eb307de53/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L1601 > {code} > if (!canFlush) { > this.decrMemstoreSize(new MemstoreSize(memstoreDataSize.get(), > getMemstoreHeapOverhead())); > } else if (memstoreDataSize.get() != 0) { > LOG.error("Memstore size is " + memstoreDataSize.get()); > } > {code} > this should probably not even be an error but a warn or even info, unless we > have puts that specifically asked to not be written to the wal, otherwise > the data in the memstore should be safe in the wals. > In any case it will be nice to have a message describing what is going on and > why we are notifying about the memstore size. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17104) Improve cryptic error message "Memstore size is" on region close
[ https://issues.apache.org/jira/browse/HBASE-17104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833050#comment-15833050 ] Sahil Aggarwal commented on HBASE-17104: We end up here only when abort=true and canFlush=true(region is writable) in which case we don't flush memstore. If abort=false then we should have definitely flushed memstore by now and size would be 0 if canFlush=true. I have created patch for it but not able to submit using dev-support/submit-patch.py script. Getting error: CRITICAL:submit-patch: Oops, something went wrong when uploading patch to jira. Response: 403 Forbidden > Improve cryptic error message "Memstore size is" on region close > > > Key: HBASE-17104 > URL: https://issues.apache.org/jira/browse/HBASE-17104 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: Matteo Bertozzi >Priority: Trivial > Labels: beginner, noob > Fix For: 2.0.0 > > > while grepping my RS log for ERROR I found a cryptic > {noformat} > ERROR [RS_CLOSE_REGION-u1604vm:35021-1] regionserver.HRegion(1601): Memstore > size is 33744 > {noformat} > from the code looks like we seems to want to notify the user about the fact > that on close the rs was not able to flush and there were things in the RS. > https://github.com/apache/hbase/blob/c3685760f004450667920144f926383eb307de53/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L1601 > {code} > if (!canFlush) { > this.decrMemstoreSize(new MemstoreSize(memstoreDataSize.get(), > getMemstoreHeapOverhead())); > } else if (memstoreDataSize.get() != 0) { > LOG.error("Memstore size is " + memstoreDataSize.get()); > } > {code} > this should probably not even be an error but a warn or even info, unless we > have puts that specifically asked to not be written to the wal, otherwise > the data in the memstore should be safe in the wals. > In any case it will be nice to have a message describing what is going on and > why we are notifying about the memstore size. -- This message was sent by Atlassian JIRA (v6.3.4#6332)