[jira] [Commented] (HBASE-17169) Remove Cell variants with ShareableMemory
[ https://issues.apache.org/jira/browse/HBASE-17169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169817#comment-16169817 ] Chia-Ping Tsai commented on HBASE-17169: bq. Still +1 on making that change.. Ya that make sense too. Thanks for the message. see HBASE-18835 > Remove Cell variants with ShareableMemory > - > > Key: HBASE-17169 > URL: https://issues.apache.org/jira/browse/HBASE-17169 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Anoop Sam John >Assignee: Anoop Sam John > Fix For: 2.0.0 > > Attachments: HBASE-17169.patch > > > As asked by Stack in review comment of other sub tasks of the parent. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17169) Remove Cell variants with ShareableMemory
[ https://issues.apache.org/jira/browse/HBASE-17169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169810#comment-16169810 ] Anoop Sam John commented on HBASE-17169: bq.The clone of ExtendedCell is not a ExtendedCell but Cell. Should we change the return type to ExtendedCell? As such there were no need in using area. Still +1 on making that change.. Ya that make sense too. > Remove Cell variants with ShareableMemory > - > > Key: HBASE-17169 > URL: https://issues.apache.org/jira/browse/HBASE-17169 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Anoop Sam John >Assignee: Anoop Sam John > Fix For: 2.0.0 > > Attachments: HBASE-17169.patch > > > As asked by Stack in review comment of other sub tasks of the parent. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17169) Remove Cell variants with ShareableMemory
[
https://issues.apache.org/jira/browse/HBASE-17169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168872#comment-16168872
]
Chia-Ping Tsai commented on HBASE-17169:
{code}
+ /**
+ * Does a deep copy of the contents to a new memory area and returns it as a
new cell.
+ * @return The deep cloned cell
+ */
+ Cell deepClone();
{code}
The clone of ExtendedCell is not a ExtendedCell but Cell. Should we change the
return type to ExtendedCell?
> Remove Cell variants with ShareableMemory
> -
>
> Key: HBASE-17169
> URL: https://issues.apache.org/jira/browse/HBASE-17169
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
> Fix For: 2.0.0
>
> Attachments: HBASE-17169.patch
>
>
> As asked by Stack in review comment of other sub tasks of the parent.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17169) Remove Cell variants with ShareableMemory
[ https://issues.apache.org/jira/browse/HBASE-17169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15697803#comment-15697803 ] Hudson commented on HBASE-17169: SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #2022 (See [https://builds.apache.org/job/HBase-Trunk_matrix/2022/]) HBASE-17169 Remove Cell variants with ShareableMemory. (anoopsamjohn: rev 3f7f1c135385c68243309a99e5f5459b1695dae6) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AbstractMemStore.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/ExtendedCell.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/OffheapKeyValue.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/codec/KeyValueCodec.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/codec/KeyValueCodecWithTags.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/NoTagsKeyValue.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java > Remove Cell variants with ShareableMemory > - > > Key: HBASE-17169 > URL: https://issues.apache.org/jira/browse/HBASE-17169 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Anoop Sam John >Assignee: Anoop Sam John > Fix For: 2.0.0 > > Attachments: HBASE-17169.patch > > > As asked by Stack in review comment of other sub tasks of the parent. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17169) Remove Cell variants with ShareableMemory
[ https://issues.apache.org/jira/browse/HBASE-17169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15696554#comment-15696554 ] stack commented on HBASE-17169: --- +1 > Remove Cell variants with ShareableMemory > - > > Key: HBASE-17169 > URL: https://issues.apache.org/jira/browse/HBASE-17169 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Anoop Sam John >Assignee: Anoop Sam John > Fix For: 2.0.0 > > Attachments: HBASE-17169.patch > > > As asked by Stack in review comment of other sub tasks of the parent. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17169) Remove Cell variants with ShareableMemory
[
https://issues.apache.org/jira/browse/HBASE-17169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15690079#comment-15690079
]
Hadoop QA commented on HBASE-17169:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 17s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 32s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
27s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 50s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
39s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
40s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
14s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 41s
{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 11s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
56s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 52s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 52s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
38s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
23s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
25m 53s {color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
31s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 41s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 42s
{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 87m 30s
{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
29s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 131m 39s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12840236/HBASE-17169.patch |
| JIRA Issue | HBASE-17169 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux a2343c413ee8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 511398f |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/4599/testReport/ |
| modules | C: hbase-common hbase-server U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/4599/console |
| Powered by | Apache Yetus
