[jira] [Commented] (HBASE-17392) Load DefaultStoreEngine when user misconfigures 'hbase.hstore.engine.class'
[
https://issues.apache.org/jira/browse/HBASE-17392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15931034#comment-15931034
]
Hadoop QA commented on HBASE-17392:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 15s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
20s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 41s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
50s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
46s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 27s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
44s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 39s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 39s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
46s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
17s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
29m 28s {color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
19s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 35s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 110m 45s
{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 153m 45s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12859386/HBASE-17392-master-001.patch
|
| JIRA Issue | HBASE-17392 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 3509cb88e66f 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6
15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 8e5eeb4 |
| Default Java | 1.8.0_121 |
| findbugs | v3.0.0 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/6133/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/6133/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> Load DefaultStoreEngine when user misconfigures 'hbase.hstore.engine.class'
> ---
>
> Key: HBASE-17392
> URL: https://issues.apache.org/jira/browse/HBASE-17392
> Project: HBase
> Issue Type: Improvement
>
[jira] [Commented] (HBASE-17392) Load DefaultStoreEngine when user misconfigures 'hbase.hstore.engine.class'
[ https://issues.apache.org/jira/browse/HBASE-17392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15794055#comment-15794055 ] Anoop Sam John commented on HBASE-17392: Ya should not go with default store engine then.. We should do some sanity check and give a better Exception with proper message. > Load DefaultStoreEngine when user misconfigures 'hbase.hstore.engine.class' > --- > > Key: HBASE-17392 > URL: https://issues.apache.org/jira/browse/HBASE-17392 > Project: HBase > Issue Type: Improvement >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > > When user misconfigures 'hbase.hstore.engine.class', region server complains > "Class not found" and gives up. In this case, we need to load the > DefaultStoreEngine to avoid that. Sanity check needs to be done to prevent > user from misconfiguration as well. > https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreEngine.java#L121 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17392) Load DefaultStoreEngine when user misconfigures 'hbase.hstore.engine.class'
[ https://issues.apache.org/jira/browse/HBASE-17392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15786164#comment-15786164 ] huaxiang sun commented on HBASE-17392: -- Thanks [~davelatham] for feedback. How about improving the log message so it makes some sense for non-advanced users? I will see if sanity check can be done from the client side. > Load DefaultStoreEngine when user misconfigures 'hbase.hstore.engine.class' > --- > > Key: HBASE-17392 > URL: https://issues.apache.org/jira/browse/HBASE-17392 > Project: HBase > Issue Type: Improvement >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > > When user misconfigures 'hbase.hstore.engine.class', region server complains > "Class not found" and gives up. In this case, we need to load the > DefaultStoreEngine to avoid that. Sanity check needs to be done to prevent > user from misconfiguration as well. > https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreEngine.java#L121 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17392) Load DefaultStoreEngine when user misconfigures 'hbase.hstore.engine.class'
[ https://issues.apache.org/jira/browse/HBASE-17392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15786139#comment-15786139 ] Dave Latham commented on HBASE-17392: - I use DateTieredStoreEngine from HBASE-15400. If I have a typo in the configuration, I'd prefer to fail fast and loud rather than fallback to the DefaultStoreEngine which may screw up the layout of my data. > Load DefaultStoreEngine when user misconfigures 'hbase.hstore.engine.class' > --- > > Key: HBASE-17392 > URL: https://issues.apache.org/jira/browse/HBASE-17392 > Project: HBase > Issue Type: Improvement >Reporter: huaxiang sun >Assignee: huaxiang sun >Priority: Minor > > When user misconfigures 'hbase.hstore.engine.class', region server complains > "Class not found" and gives up. In this case, we need to load the > DefaultStoreEngine to avoid that. Sanity check needs to be done to prevent > user from misconfiguration as well. > https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreEngine.java#L121 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
