[jira] [Commented] (HBASE-17769) In webUI, master and regionserver address should use rpc-port instead of infoport

2017-03-10 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905655#comment-15905655
 ] 

Hadoop QA commented on HBASE-17769:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 18s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s 
{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 
1s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
15s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 26s 
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 
42s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
14s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
27m 33s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 27s 
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 97m 2s {color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
15s {color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 130m 24s {color} 
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12857365/HBASE-17769-v2.patch |
| JIRA Issue | HBASE-17769 |
| Optional Tests |  asflicense  javac  javadoc  unit  |
| uname | Linux 3268acd590c1 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 
15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / e0365df |
| Default Java | 1.8.0_121 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/6058/artifact/patchprocess/patch-unit-hbase-server.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/6058/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/6058/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> In webUI, master and regionserver address should use rpc-port instead of 
> infoport
> -
>
> Key: HBASE-17769
> URL: https://issues.apache.org/jira/browse/HBASE-17769
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 2.0.0, 1.4.0
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Attachments: HBASE-17769-v1.patch, HBASE-17769-v2.patch, 
> master_table.jsp_sceenshots.jpg, regionserver_page_sceenshots.jpg
>
>
> On table.jsp display regionserver address is ip:infoport, it may be more 
> appropriate to use ip:hbase.regionserver.port
> Similarly, the master address displayed on the regionserver page should be 
> ip:hbase.master.port



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HBASE-17769) In webUI, master and regionserver address should use rpc-port instead of infoport

2017-03-10 Thread Guangxu Cheng (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905508#comment-15905508
 ] 

Guangxu Cheng commented on HBASE-17769:
---

Update patch according to review comments, and attach screenshot of the latest 
page.
[~ashish singhi] , mind review again? Thanks.

> In webUI, master and regionserver address should use rpc-port instead of 
> infoport
> -
>
> Key: HBASE-17769
> URL: https://issues.apache.org/jira/browse/HBASE-17769
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 2.0.0, 1.4.0
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Attachments: HBASE-17769-v1.patch, HBASE-17769-v2.patch, 
> master_table.jsp_sceenshots.jpg, regionserver_page_sceenshots.jpg
>
>
> On table.jsp display regionserver address is ip:infoport, it may be more 
> appropriate to use ip:hbase.regionserver.port
> Similarly, the master address displayed on the regionserver page should be 
> ip:hbase.master.port



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HBASE-17769) In webUI, master and regionserver address should use rpc-port instead of infoport

2017-03-10 Thread Guangxu Cheng (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905375#comment-15905375
 ] 

Guangxu Cheng commented on HBASE-17769:
---

bq. Can you attach the sceenshots before and after ?
Sure,I'll attach the sceenshots for a while.
bq. The above change of yours will break the URL now. Please check whether on 
clicking the URL it still redirects to master page.
Sorry, there's a little problem here.I'll fix it right now.

> In webUI, master and regionserver address should use rpc-port instead of 
> infoport
> -
>
> Key: HBASE-17769
> URL: https://issues.apache.org/jira/browse/HBASE-17769
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 2.0.0, 1.4.0
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Attachments: HBASE-17769-v1.patch
>
>
> On table.jsp display regionserver address is ip:infoport, it may be more 
> appropriate to use ip:hbase.regionserver.port
> Similarly, the master address displayed on the regionserver page should be 
> ip:hbase.master.port



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HBASE-17769) In webUI, master and regionserver address should use rpc-port instead of infoport

2017-03-10 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905269#comment-15905269
 ] 

Hadoop QA commented on HBASE-17769:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 16s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s 
{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 
6s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
15s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 27s 
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 
44s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
15s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
28m 14s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 29s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 101m 30s 
{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
18s {color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 135m 47s {color} 
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12857321/HBASE-17769-v1.patch |
| JIRA Issue | HBASE-17769 |
| Optional Tests |  asflicense  javac  javadoc  unit  |
| uname | Linux 305310ce94aa 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 
15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / e0365df |
| Default Java | 1.8.0_121 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/6055/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/6055/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> In webUI, master and regionserver address should use rpc-port instead of 
> infoport
> -
>
> Key: HBASE-17769
> URL: https://issues.apache.org/jira/browse/HBASE-17769
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 2.0.0, 1.4.0
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Attachments: HBASE-17769-v1.patch
>
>
> On table.jsp display regionserver address is ip:infoport, it may be more 
> appropriate to use ip:hbase.regionserver.port
> Similarly, the master address displayed on the regionserver page should be 
> ip:hbase.master.port



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HBASE-17769) In webUI, master and regionserver address should use rpc-port instead of infoport

2017-03-10 Thread Ashish Singhi (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905063#comment-15905063
 ] 

Ashish Singhi commented on HBASE-17769:
---

Can you attach the sceenshots before and after ?

{code}
-String host = masterServerName.getHostname() + ":" + infoPort;
+String host = masterServerName.getHostname() + ":" + port;
 String url = "//" + host + "/master-status";
{code}
The above change of yours will break the URL now. Please check whether on 
clicking the URL it still redirects to master page.

> In webUI, master and regionserver address should use rpc-port instead of 
> infoport
> -
>
> Key: HBASE-17769
> URL: https://issues.apache.org/jira/browse/HBASE-17769
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 2.0.0, 1.4.0
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Attachments: HBASE-17769-v1.patch
>
>
> On table.jsp display regionserver address is ip:infoport, it may be more 
> appropriate to use ip:hbase.regionserver.port
> Similarly, the master address displayed on the regionserver page should be 
> ip:hbase.master.port



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)