[jira] [Commented] (HBASE-17808) FastPath for RWQueueRpcExecutor

2021-12-14 Thread Reid Chan (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-17808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17459615#comment-17459615
 ] 

Reid Chan commented on HBASE-17808:
---

A contributor is working on this in HBASE-26551. This has been a while, let's 
close this one.

> FastPath for RWQueueRpcExecutor
> ---
>
> Key: HBASE-17808
> URL: https://issues.apache.org/jira/browse/HBASE-17808
> Project: HBase
>  Issue Type: Improvement
>  Components: rpc, Scheduler
>Affects Versions: 2.0.0
>Reporter: Allan Yang
>Assignee: Allan Yang
>Priority: Major
> Attachments: HBASE-17808.patch, HBASE-17808.v2.patch
>
>
> FastPath for the FIFO rpcscheduler was introduced in HBASE-16023. But it is 
> not implemented for RW queues. In this issue, I use 
> FastPathBalancedQueueRpcExecutor in RW queues. So anyone who want to isolate 
> their read/write requests can also benefit from the fastpath.
> I haven't test the performance yet. But since I haven't change any of the 
> core implemention of FastPathBalancedQueueRpcExecutor, it should have the 
> same performance in HBASE-16023.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (HBASE-17808) FastPath for RWQueueRpcExecutor

2019-05-23 Thread Allan Yang (JIRA) 


[ 
https://issues.apache.org/jira/browse/HBASE-17808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847177#comment-16847177
 ] 

Allan Yang commented on HBASE-17808:


No, currently I'm not. Maybe we should just close this one.

> FastPath for RWQueueRpcExecutor
> ---
>
> Key: HBASE-17808
> URL: https://issues.apache.org/jira/browse/HBASE-17808
> Project: HBase
>  Issue Type: Improvement
>  Components: rpc, Scheduler
>Affects Versions: 2.0.0
>Reporter: Allan Yang
>Assignee: Allan Yang
>Priority: Major
> Attachments: HBASE-17808.patch, HBASE-17808.v2.patch
>
>
> FastPath for the FIFO rpcscheduler was introduced in HBASE-16023. But it is 
> not implemented for RW queues. In this issue, I use 
> FastPathBalancedQueueRpcExecutor in RW queues. So anyone who want to isolate 
> their read/write requests can also benefit from the fastpath.
> I haven't test the performance yet. But since I haven't change any of the 
> core implemention of FastPathBalancedQueueRpcExecutor, it should have the 
> same performance in HBASE-16023.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-17808) FastPath for RWQueueRpcExecutor

2019-05-23 Thread Biju Nair (JIRA) 


[ 
https://issues.apache.org/jira/browse/HBASE-17808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847087#comment-16847087
 ] 

Biju Nair commented on HBASE-17808:
---

[~allan163], still pursuing this or can we close this ticket?

> FastPath for RWQueueRpcExecutor
> ---
>
> Key: HBASE-17808
> URL: https://issues.apache.org/jira/browse/HBASE-17808
> Project: HBase
>  Issue Type: Improvement
>  Components: rpc, Scheduler
>Affects Versions: 2.0.0
>Reporter: Allan Yang
>Assignee: Allan Yang
>Priority: Major
> Attachments: HBASE-17808.patch, HBASE-17808.v2.patch
>
>
> FastPath for the FIFO rpcscheduler was introduced in HBASE-16023. But it is 
> not implemented for RW queues. In this issue, I use 
> FastPathBalancedQueueRpcExecutor in RW queues. So anyone who want to isolate 
> their read/write requests can also benefit from the fastpath.
> I haven't test the performance yet. But since I haven't change any of the 
> core implemention of FastPathBalancedQueueRpcExecutor, it should have the 
> same performance in HBASE-16023.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-17808) FastPath for RWQueueRpcExecutor

2019-05-17 Thread HBase QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/HBASE-17808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842297#comment-16842297
 ] 

HBase QA commented on HBASE-17808:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  6s{color} 
| {color:red} HBASE-17808 does not apply to master. Rebase required? Wrong 
Branch? See 
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for 
help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-17808 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12859712/HBASE-17808.v2.patch |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/346/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |


This message was automatically generated.



> FastPath for RWQueueRpcExecutor
> ---
>
> Key: HBASE-17808
> URL: https://issues.apache.org/jira/browse/HBASE-17808
> Project: HBase
>  Issue Type: Improvement
>  Components: rpc, Scheduler
>Affects Versions: 2.0.0
>Reporter: Allan Yang
>Assignee: Allan Yang
>Priority: Major
> Attachments: HBASE-17808.patch, HBASE-17808.v2.patch
>
>
> FastPath for the FIFO rpcscheduler was introduced in HBASE-16023. But it is 
> not implemented for RW queues. In this issue, I use 
> FastPathBalancedQueueRpcExecutor in RW queues. So anyone who want to isolate 
> their read/write requests can also benefit from the fastpath.
> I haven't test the performance yet. But since I haven't change any of the 
> core implemention of FastPathBalancedQueueRpcExecutor, it should have the 
> same performance in HBASE-16023.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-17808) FastPath for RWQueueRpcExecutor

2017-03-21 Thread Allan Yang (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935691#comment-15935691
 ] 

Allan Yang commented on HBASE-17808:


{quote}
Why FastPathRWQueueRpcExecutor not extends RWQueueRpcExecutor?
{quote}
Good question, FastPathRWQueueRpcExecutor  is backed by 
FastPathBalancedQueueRpcExecutor, it is also not good as RWQueueRpcExecutor in 
my tests. Still trying to figure out what's wrong.

> FastPath for RWQueueRpcExecutor
> ---
>
> Key: HBASE-17808
> URL: https://issues.apache.org/jira/browse/HBASE-17808
> Project: HBase
>  Issue Type: Improvement
>  Components: rpc
>Affects Versions: 2.0.0
>Reporter: Allan Yang
>Assignee: Allan Yang
> Attachments: HBASE-17808.patch, HBASE-17808.v2.patch
>
>
> FastPath for the FIFO rpcscheduler was introduced in HBASE-16023. But it is 
> not implemented for RW queues. In this issue, I use 
> FastPathBalancedQueueRpcExecutor in RW queues. So anyone who want to isolate 
> their read/write requests can also benefit from the fastpath.
> I haven't test the performance yet. But since I haven't change any of the 
> core implemention of FastPathBalancedQueueRpcExecutor, it should have the 
> same performance in HBASE-16023.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HBASE-17808) FastPath for RWQueueRpcExecutor

2017-03-21 Thread Guanghao Zhang (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935679#comment-15935679
 ] 

Guanghao Zhang commented on HBASE-17808:


Why FastPathRWQueueRpcExecutor not extends RWQueueRpcExecutor?

> FastPath for RWQueueRpcExecutor
> ---
>
> Key: HBASE-17808
> URL: https://issues.apache.org/jira/browse/HBASE-17808
> Project: HBase
>  Issue Type: Improvement
>  Components: rpc
>Affects Versions: 2.0.0
>Reporter: Allan Yang
>Assignee: Allan Yang
> Attachments: HBASE-17808.patch, HBASE-17808.v2.patch
>
>
> FastPath for the FIFO rpcscheduler was introduced in HBASE-16023. But it is 
> not implemented for RW queues. In this issue, I use 
> FastPathBalancedQueueRpcExecutor in RW queues. So anyone who want to isolate 
> their read/write requests can also benefit from the fastpath.
> I haven't test the performance yet. But since I haven't change any of the 
> core implemention of FastPathBalancedQueueRpcExecutor, it should have the 
> same performance in HBASE-16023.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HBASE-17808) FastPath for RWQueueRpcExecutor

2017-03-20 Thread Allan Yang (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15932494#comment-15932494
 ] 

Allan Yang commented on HBASE-17808:


testCoDelScheduling fails without my patch too.

> FastPath for RWQueueRpcExecutor
> ---
>
> Key: HBASE-17808
> URL: https://issues.apache.org/jira/browse/HBASE-17808
> Project: HBase
>  Issue Type: Improvement
>  Components: rpc
>Affects Versions: 2.0.0
>Reporter: Allan Yang
>Assignee: Allan Yang
> Attachments: HBASE-17808.patch
>
>
> FastPath for the FIFO rpcscheduler was introduced in HBASE-16023. But it is 
> not implemented for RW queues. In this issue, I use 
> FastPathBalancedQueueRpcExecutor in RW queues. So anyone who want to isolate 
> their read/write requests can also benefit from the fastpath.
> I haven't test the performance yet. But since I haven't change any of the 
> core implemention of FastPathBalancedQueueRpcExecutor, it should have the 
> same performance in HBASE-16023.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HBASE-17808) FastPath for RWQueueRpcExecutor

2017-03-20 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15932446#comment-15932446
 ] 

Hadoop QA commented on HBASE-17808:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 17s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s 
{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 
27s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 44s 
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 
49s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
15s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 1s 
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 29s 
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 
45s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 38s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 38s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 
52s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
18s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
30m 33s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 9s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 32s 
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 23m 36s {color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
9s {color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 68m 5s {color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.ipc.TestSimpleRpcScheduler |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12859521/HBASE-17808.patch |
| JIRA Issue | HBASE-17808 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  
hbaseanti  checkstyle  compile  |
| uname | Linux d9d6a424ce15 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 
15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
 |
| git revision | master / 7c03a21 |
| Default Java | 1.8.0_121 |
| findbugs | v3.0.0 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/6152/artifact/patchprocess/patch-unit-hbase-server.txt
 |
| unit test logs |  
https://builds.apache.org/job/PreCommit-HBASE-Build/6152/artifact/patchprocess/patch-unit-hbase-server.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/6152/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/6152/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> FastPath for RWQueueRpcExecutor