[jira] [Commented] (HBASE-17973) Create shell command to identify regions with poor locality
[ https://issues.apache.org/jira/browse/HBASE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002046#comment-16002046 ] Hudson commented on HBASE-17973: FAILURE: Integrated in Jenkins build HBase-1.4 #727 (See [https://builds.apache.org/job/HBase-1.4/727/]) HBASE-17973 Create shell command to identify regions with poor locality (apurtell: rev eaaf70354f6d4e4ecfb18c1ff33389c19da5a2b3) * (add) hbase-shell/src/test/ruby/hbase/list_regions_test_no_cluster.rb * (edit) hbase-shell/src/main/ruby/shell/commands/list_regions.rb * (edit) hbase-shell/src/main/ruby/hbase.rb HBASE-17973 Fix incorrect method call in list_regions and expand tests (apurtell: rev 1d33f619188bfabe51c7ed217102e897e3c105e9) * (edit) hbase-shell/src/test/ruby/hbase/list_regions_test_no_cluster.rb * (edit) hbase-shell/src/main/ruby/shell/commands/list_regions.rb > Create shell command to identify regions with poor locality > --- > > Key: HBASE-17973 > URL: https://issues.apache.org/jira/browse/HBASE-17973 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-17973.001.patch, HBASE-17973.002.patch, > HBASE-17973.003.patch, HBASE-17973.branch-1.001.patch > > > The data locality of regions often plays a large role in the efficiency of > HBase. Compactions are also expensive to execute, especially on very large > tables. The balancer can do a good job trying to maintain locality (when > tuned properly), but it is not perfect. > This creates a less-than-desirable situation where it's a costly operation to > take a cluster with spotty poor locality (e.g. a small percentage of > regionservers with poor locality). > We already have this information available via the {{ClusterStatus}} proto. > We can easily write a shell command that can present regions which are > lacking a certain percentage of locality. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17973) Create shell command to identify regions with poor locality
[ https://issues.apache.org/jira/browse/HBASE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999265#comment-15999265 ] Hudson commented on HBASE-17973: FAILURE: Integrated in Jenkins build HBase-HBASE-14614 #223 (See [https://builds.apache.org/job/HBase-HBASE-14614/223/]) HBASE-17973 Expand list_regions to filter on data locality (elserj: rev 13b6fdf8ad81e236632a2dc99e6c4a317213858e) * (add) hbase-shell/src/test/ruby/hbase/list_regions_test_no_cluster.rb * (edit) hbase-shell/src/main/ruby/hbase_constants.rb * (edit) hbase-shell/src/main/ruby/shell/commands/list_regions.rb HBASE-17973 Fix incorrect method call in list_regions and expand tests (elserj: rev de78c11893d7c25f9faaf4bcb0ef10a9df1cd96e) * (edit) hbase-shell/src/main/ruby/shell/commands/list_regions.rb * (edit) hbase-shell/src/test/ruby/hbase/list_regions_test_no_cluster.rb > Create shell command to identify regions with poor locality > --- > > Key: HBASE-17973 > URL: https://issues.apache.org/jira/browse/HBASE-17973 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0 > > Attachments: HBASE-17973.001.patch, HBASE-17973.002.patch, > HBASE-17973.003.patch, HBASE-17973.branch-1.001.patch > > > The data locality of regions often plays a large role in the efficiency of > HBase. Compactions are also expensive to execute, especially on very large > tables. The balancer can do a good job trying to maintain locality (when > tuned properly), but it is not perfect. > This creates a less-than-desirable situation where it's a costly operation to > take a cluster with spotty poor locality (e.g. a small percentage of > regionservers with poor locality). > We already have this information available via the {{ClusterStatus}} proto. > We can easily write a shell command that can present regions which are > lacking a certain percentage of locality. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17973) Create shell command to identify regions with poor locality
[ https://issues.apache.org/jira/browse/HBASE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999036#comment-15999036 ] Josh Elser commented on HBASE-17973: bq. alternatively (depending if Josh Elser is busy), I'd be happy to accept a branch-1 patch from you for commit. By all means, have at it! > Create shell command to identify regions with poor locality > --- > > Key: HBASE-17973 > URL: https://issues.apache.org/jira/browse/HBASE-17973 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0 > > Attachments: HBASE-17973.001.patch, HBASE-17973.002.patch, > HBASE-17973.003.patch, HBASE-17973.branch-1.001.patch > > > The data locality of regions often plays a large role in the efficiency of > HBase. Compactions are also expensive to execute, especially on very large > tables. The balancer can do a good job trying to maintain locality (when > tuned properly), but it is not perfect. > This creates a less-than-desirable situation where it's a costly operation to > take a cluster with spotty poor locality (e.g. a small percentage of > regionservers with poor locality). > We already have this information available via the {{ClusterStatus}} proto. > We can easily write a shell command that can present regions which are > lacking a certain percentage of locality. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17973) Create shell command to identify regions with poor locality
[ https://issues.apache.org/jira/browse/HBASE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999029#comment-15999029 ] Karan Mehta commented on HBASE-17973: - [~apurtell] I have added a patch for branch-1. I have squashed all the patches and the addendum into a single patch. Hope its fine that way. Please review whenever convenient. > Create shell command to identify regions with poor locality > --- > > Key: HBASE-17973 > URL: https://issues.apache.org/jira/browse/HBASE-17973 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0 > > Attachments: HBASE-17973.001.patch, HBASE-17973.002.patch, > HBASE-17973.003.patch, HBASE-17973.branch-1.001.patch > > > The data locality of regions often plays a large role in the efficiency of > HBase. Compactions are also expensive to execute, especially on very large > tables. The balancer can do a good job trying to maintain locality (when > tuned properly), but it is not perfect. > This creates a less-than-desirable situation where it's a costly operation to > take a cluster with spotty poor locality (e.g. a small percentage of > regionservers with poor locality). > We already have this information available via the {{ClusterStatus}} proto. > We can easily write a shell command that can present regions which are > lacking a certain percentage of locality. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17973) Create shell command to identify regions with poor locality
[ https://issues.apache.org/jira/browse/HBASE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998963#comment-15998963 ] Andrew Purtell commented on HBASE-17973: [~karanmehta93], alternatively (depending if [~elserj] is busy), I'd be happy to accept a branch-1 patch from you for commit. > Create shell command to identify regions with poor locality > --- > > Key: HBASE-17973 > URL: https://issues.apache.org/jira/browse/HBASE-17973 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0 > > Attachments: HBASE-17973.001.patch, HBASE-17973.002.patch, > HBASE-17973.003.patch > > > The data locality of regions often plays a large role in the efficiency of > HBase. Compactions are also expensive to execute, especially on very large > tables. The balancer can do a good job trying to maintain locality (when > tuned properly), but it is not perfect. > This creates a less-than-desirable situation where it's a costly operation to > take a cluster with spotty poor locality (e.g. a small percentage of > regionservers with poor locality). > We already have this information available via the {{ClusterStatus}} proto. > We can easily write a shell command that can present regions which are > lacking a certain percentage of locality. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17973) Create shell command to identify regions with poor locality
[ https://issues.apache.org/jira/browse/HBASE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998962#comment-15998962 ] Karan Mehta commented on HBASE-17973: - Hey [~elserj], Can you back-port the patch for {{branch-1}}? The addendum patch for HBASE-14925 (branch-1) is dependent on this. Thanks! > Create shell command to identify regions with poor locality > --- > > Key: HBASE-17973 > URL: https://issues.apache.org/jira/browse/HBASE-17973 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0 > > Attachments: HBASE-17973.001.patch, HBASE-17973.002.patch, > HBASE-17973.003.patch > > > The data locality of regions often plays a large role in the efficiency of > HBase. Compactions are also expensive to execute, especially on very large > tables. The balancer can do a good job trying to maintain locality (when > tuned properly), but it is not perfect. > This creates a less-than-desirable situation where it's a costly operation to > take a cluster with spotty poor locality (e.g. a small percentage of > regionservers with poor locality). > We already have this information available via the {{ClusterStatus}} proto. > We can easily write a shell command that can present regions which are > lacking a certain percentage of locality. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17973) Create shell command to identify regions with poor locality
[ https://issues.apache.org/jira/browse/HBASE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994238#comment-15994238 ] Hudson commented on HBASE-17973: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #2940 (See [https://builds.apache.org/job/HBase-Trunk_matrix/2940/]) HBASE-17973 Fix incorrect method call in list_regions and expand tests (elserj: rev de78c11893d7c25f9faaf4bcb0ef10a9df1cd96e) * (edit) hbase-shell/src/main/ruby/shell/commands/list_regions.rb * (edit) hbase-shell/src/test/ruby/hbase/list_regions_test_no_cluster.rb > Create shell command to identify regions with poor locality > --- > > Key: HBASE-17973 > URL: https://issues.apache.org/jira/browse/HBASE-17973 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0 > > Attachments: HBASE-17973.001.patch, HBASE-17973.002.patch, > HBASE-17973.003.patch > > > The data locality of regions often plays a large role in the efficiency of > HBase. Compactions are also expensive to execute, especially on very large > tables. The balancer can do a good job trying to maintain locality (when > tuned properly), but it is not perfect. > This creates a less-than-desirable situation where it's a costly operation to > take a cluster with spotty poor locality (e.g. a small percentage of > regionservers with poor locality). > We already have this information available via the {{ClusterStatus}} proto. > We can easily write a shell command that can present regions which are > lacking a certain percentage of locality. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17973) Create shell command to identify regions with poor locality
[ https://issues.apache.org/jira/browse/HBASE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994221#comment-15994221 ] Karan Mehta commented on HBASE-17973: - Yes, it is there. Sorry for that. I didn't observe that v3 was an addendum and not a complete patch. Thanks! > Create shell command to identify regions with poor locality > --- > > Key: HBASE-17973 > URL: https://issues.apache.org/jira/browse/HBASE-17973 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0 > > Attachments: HBASE-17973.001.patch, HBASE-17973.002.patch, > HBASE-17973.003.patch > > > The data locality of regions often plays a large role in the efficiency of > HBase. Compactions are also expensive to execute, especially on very large > tables. The balancer can do a good job trying to maintain locality (when > tuned properly), but it is not perfect. > This creates a less-than-desirable situation where it's a costly operation to > take a cluster with spotty poor locality (e.g. a small percentage of > regionservers with poor locality). > We already have this information available via the {{ClusterStatus}} proto. > We can easily write a shell command that can present regions which are > lacking a certain percentage of locality. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17973) Create shell command to identify regions with poor locality
[ https://issues.apache.org/jira/browse/HBASE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994166#comment-15994166 ] Josh Elser commented on HBASE-17973: It's already attached... V2 was the original, v3 was the addendum per the conversation with Andrew... > Create shell command to identify regions with poor locality > --- > > Key: HBASE-17973 > URL: https://issues.apache.org/jira/browse/HBASE-17973 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0 > > Attachments: HBASE-17973.001.patch, HBASE-17973.002.patch, > HBASE-17973.003.patch > > > The data locality of regions often plays a large role in the efficiency of > HBase. Compactions are also expensive to execute, especially on very large > tables. The balancer can do a good job trying to maintain locality (when > tuned properly), but it is not perfect. > This creates a less-than-desirable situation where it's a costly operation to > take a cluster with spotty poor locality (e.g. a small percentage of > regionservers with poor locality). > We already have this information available via the {{ClusterStatus}} proto. > We can easily write a shell command that can present regions which are > lacking a certain percentage of locality. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17973) Create shell command to identify regions with poor locality
[ https://issues.apache.org/jira/browse/HBASE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993921#comment-15993921 ] Karan Mehta commented on HBASE-17973: - Thank you for the clarification and the patch, [~elserj]. One more suggestion, could you just attach the patch you committed with this JIRA. It just makes things a little easier I feel. :) > Create shell command to identify regions with poor locality > --- > > Key: HBASE-17973 > URL: https://issues.apache.org/jira/browse/HBASE-17973 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0 > > Attachments: HBASE-17973.001.patch, HBASE-17973.002.patch, > HBASE-17973.003.patch > > > The data locality of regions often plays a large role in the efficiency of > HBase. Compactions are also expensive to execute, especially on very large > tables. The balancer can do a good job trying to maintain locality (when > tuned properly), but it is not perfect. > This creates a less-than-desirable situation where it's a costly operation to > take a cluster with spotty poor locality (e.g. a small percentage of > regionservers with poor locality). > We already have this information available via the {{ClusterStatus}} proto. > We can easily write a shell command that can present regions which are > lacking a certain percentage of locality. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17973) Create shell command to identify regions with poor locality
[ https://issues.apache.org/jira/browse/HBASE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993856#comment-15993856 ] Andrew Purtell commented on HBASE-17973: There's no hard conventions I think. A suggestion for next time, if you like > Create shell command to identify regions with poor locality > --- > > Key: HBASE-17973 > URL: https://issues.apache.org/jira/browse/HBASE-17973 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0 > > Attachments: HBASE-17973.001.patch, HBASE-17973.002.patch, > HBASE-17973.003.patch > > > The data locality of regions often plays a large role in the efficiency of > HBase. Compactions are also expensive to execute, especially on very large > tables. The balancer can do a good job trying to maintain locality (when > tuned properly), but it is not perfect. > This creates a less-than-desirable situation where it's a costly operation to > take a cluster with spotty poor locality (e.g. a small percentage of > regionservers with poor locality). > We already have this information available via the {{ClusterStatus}} proto. > We can easily write a shell command that can present regions which are > lacking a certain percentage of locality. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17973) Create shell command to identify regions with poor locality
[ https://issues.apache.org/jira/browse/HBASE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993853#comment-15993853 ] Josh Elser commented on HBASE-17973: bq. is any internal filter method available on Arrays since there was none explicitly defined. No, it was just a typo; it should have been {{select}}. > Create shell command to identify regions with poor locality > --- > > Key: HBASE-17973 > URL: https://issues.apache.org/jira/browse/HBASE-17973 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0 > > Attachments: HBASE-17973.001.patch, HBASE-17973.002.patch, > HBASE-17973.003.patch > > > The data locality of regions often plays a large role in the efficiency of > HBase. Compactions are also expensive to execute, especially on very large > tables. The balancer can do a good job trying to maintain locality (when > tuned properly), but it is not perfect. > This creates a less-than-desirable situation where it's a costly operation to > take a cluster with spotty poor locality (e.g. a small percentage of > regionservers with poor locality). > We already have this information available via the {{ClusterStatus}} proto. > We can easily write a shell command that can present regions which are > lacking a certain percentage of locality. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17973) Create shell command to identify regions with poor locality
[ https://issues.apache.org/jira/browse/HBASE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993846#comment-15993846 ] Karan Mehta commented on HBASE-17973: - [~elserj] I had a look at the comment earlier but was wondering if there is any internal {{filter}} method available on Arrays since there was none explicitly defined. I didn't understand the function of this line and couldn't find relevant stuff online. Can you please clarify what is this for? {code} + regions = hregion_locator_list.filter do |hregion| {code} Thank you! > Create shell command to identify regions with poor locality > --- > > Key: HBASE-17973 > URL: https://issues.apache.org/jira/browse/HBASE-17973 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0 > > Attachments: HBASE-17973.001.patch, HBASE-17973.002.patch, > HBASE-17973.003.patch > > > The data locality of regions often plays a large role in the efficiency of > HBase. Compactions are also expensive to execute, especially on very large > tables. The balancer can do a good job trying to maintain locality (when > tuned properly), but it is not perfect. > This creates a less-than-desirable situation where it's a costly operation to > take a cluster with spotty poor locality (e.g. a small percentage of > regionservers with poor locality). > We already have this information available via the {{ClusterStatus}} proto. > We can easily write a shell command that can present regions which are > lacking a certain percentage of locality. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17973) Create shell command to identify regions with poor locality
[ https://issues.apache.org/jira/browse/HBASE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993831#comment-15993831 ] Josh Elser commented on HBASE-17973: bq. We usually name addendum patches as addendum.patch but clearly .003 is smaller than the others. Thanks! I had only made a quick glance at a few other issues and didn't a convention. Sorry, about that. I can re-attach+rename if you'd prefer. Will push the addendum shortly. > Create shell command to identify regions with poor locality > --- > > Key: HBASE-17973 > URL: https://issues.apache.org/jira/browse/HBASE-17973 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0 > > Attachments: HBASE-17973.001.patch, HBASE-17973.002.patch, > HBASE-17973.003.patch > > > The data locality of regions often plays a large role in the efficiency of > HBase. Compactions are also expensive to execute, especially on very large > tables. The balancer can do a good job trying to maintain locality (when > tuned properly), but it is not perfect. > This creates a less-than-desirable situation where it's a costly operation to > take a cluster with spotty poor locality (e.g. a small percentage of > regionservers with poor locality). > We already have this information available via the {{ClusterStatus}} proto. > We can easily write a shell command that can present regions which are > lacking a certain percentage of locality. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17973) Create shell command to identify regions with poor locality
[ https://issues.apache.org/jira/browse/HBASE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993809#comment-15993809 ] Andrew Purtell commented on HBASE-17973: +1 on addendum We usually name addendum patches as -addendum-.patch but clearly .003 is smaller than the others. > Create shell command to identify regions with poor locality > --- > > Key: HBASE-17973 > URL: https://issues.apache.org/jira/browse/HBASE-17973 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0 > > Attachments: HBASE-17973.001.patch, HBASE-17973.002.patch, > HBASE-17973.003.patch > > > The data locality of regions often plays a large role in the efficiency of > HBase. Compactions are also expensive to execute, especially on very large > tables. The balancer can do a good job trying to maintain locality (when > tuned properly), but it is not perfect. > This creates a less-than-desirable situation where it's a costly operation to > take a cluster with spotty poor locality (e.g. a small percentage of > regionservers with poor locality). > We already have this information available via the {{ClusterStatus}} proto. > We can easily write a shell command that can present regions which are > lacking a certain percentage of locality. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17973) Create shell command to identify regions with poor locality
[ https://issues.apache.org/jira/browse/HBASE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993803#comment-15993803 ] Josh Elser commented on HBASE-17973: bq. The patch is committed already but the JIRA status is shown as unresolved. What is its current status? I need to put an addendum for HBASE-14925, but when I try running list_regions command, I get the error as [~karanmehta93], I guess you missed my earlier comment acknowledging that I broke it and had put up an addendum? :) https://issues.apache.org/jira/browse/HBASE-17973?focusedCommentId=15991634=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15991634 https://issues.apache.org/jira/browse/HBASE-17973?focusedCommentId=15993082=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15993082 Just need to get a +1 here and I can commit the addendum. > Create shell command to identify regions with poor locality > --- > > Key: HBASE-17973 > URL: https://issues.apache.org/jira/browse/HBASE-17973 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0 > > Attachments: HBASE-17973.001.patch, HBASE-17973.002.patch, > HBASE-17973.003.patch > > > The data locality of regions often plays a large role in the efficiency of > HBase. Compactions are also expensive to execute, especially on very large > tables. The balancer can do a good job trying to maintain locality (when > tuned properly), but it is not perfect. > This creates a less-than-desirable situation where it's a costly operation to > take a cluster with spotty poor locality (e.g. a small percentage of > regionservers with poor locality). > We already have this information available via the {{ClusterStatus}} proto. > We can easily write a shell command that can present regions which are > lacking a certain percentage of locality. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17973) Create shell command to identify regions with poor locality
[ https://issues.apache.org/jira/browse/HBASE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993799#comment-15993799 ] Hadoop QA commented on HBASE-17973: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 12s {color} | {color:blue} Docker mode activated. {color} | | {color:blue}0{color} | {color:blue} rubocop {color} | {color:blue} 0m 1s {color} | {color:blue} rubocop was not available. {color} | | {color:blue}0{color} | {color:blue} ruby-lint {color} | {color:blue} 0m 1s {color} | {color:blue} Ruby-lint was not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 18s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 14s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 7s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 13s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 13s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 25m 35s {color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 8s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 5m 5s {color} | {color:green} hbase-shell in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 7s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 35m 26s {color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12865998/HBASE-17973.003.patch | | JIRA Issue | HBASE-17973 | | Optional Tests | asflicense javac javadoc unit rubocop ruby_lint | | uname | Linux a885c639732d 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh | | git revision | master / 30d0c3f | | Default Java | 1.8.0_121 | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/6676/testReport/ | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/6676/console | | Powered by | Apache Yetus 0.3.0 http://yetus.apache.org | This message was automatically generated. > Create shell command to identify regions with poor locality > --- > > Key: HBASE-17973 > URL: https://issues.apache.org/jira/browse/HBASE-17973 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0 > > Attachments: HBASE-17973.001.patch, HBASE-17973.002.patch, > HBASE-17973.003.patch > > > The data locality of regions often plays a large role in the efficiency of > HBase. Compactions are also expensive to execute, especially on very large > tables. The balancer can do a good job trying to maintain locality (when > tuned properly), but it is not perfect. > This creates a less-than-desirable situation where it's a costly operation to > take a cluster with spotty poor locality (e.g. a small percentage of > regionservers with poor locality). > We already have this information available via the {{ClusterStatus}} proto. > We can easily write a shell command that can present regions which are > lacking a certain percentage of locality. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17973) Create shell command to identify regions with poor locality
[ https://issues.apache.org/jira/browse/HBASE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993800#comment-15993800 ] Karan Mehta commented on HBASE-17973: - [~elserj] The patch is committed already but the JIRA status is shown as unresolved. What is its current status? I need to put an addendum for HBASE-14925, but when I try running {{list_regions}} command, I get the error as {code} ERROR: undefined method `filter' for # {code} Can you please look into this? > Create shell command to identify regions with poor locality > --- > > Key: HBASE-17973 > URL: https://issues.apache.org/jira/browse/HBASE-17973 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0 > > Attachments: HBASE-17973.001.patch, HBASE-17973.002.patch, > HBASE-17973.003.patch > > > The data locality of regions often plays a large role in the efficiency of > HBase. Compactions are also expensive to execute, especially on very large > tables. The balancer can do a good job trying to maintain locality (when > tuned properly), but it is not perfect. > This creates a less-than-desirable situation where it's a costly operation to > take a cluster with spotty poor locality (e.g. a small percentage of > regionservers with poor locality). > We already have this information available via the {{ClusterStatus}} proto. > We can easily write a shell command that can present regions which are > lacking a certain percentage of locality. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17973) Create shell command to identify regions with poor locality
[ https://issues.apache.org/jira/browse/HBASE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15991875#comment-15991875 ] Hudson commented on HBASE-17973: SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #2933 (See [https://builds.apache.org/job/HBase-Trunk_matrix/2933/]) HBASE-17973 Expand list_regions to filter on data locality (elserj: rev 13b6fdf8ad81e236632a2dc99e6c4a317213858e) * (edit) hbase-shell/src/main/ruby/shell/commands/list_regions.rb * (add) hbase-shell/src/test/ruby/hbase/list_regions_test_no_cluster.rb * (edit) hbase-shell/src/main/ruby/hbase_constants.rb > Create shell command to identify regions with poor locality > --- > > Key: HBASE-17973 > URL: https://issues.apache.org/jira/browse/HBASE-17973 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0 > > Attachments: HBASE-17973.001.patch, HBASE-17973.002.patch > > > The data locality of regions often plays a large role in the efficiency of > HBase. Compactions are also expensive to execute, especially on very large > tables. The balancer can do a good job trying to maintain locality (when > tuned properly), but it is not perfect. > This creates a less-than-desirable situation where it's a costly operation to > take a cluster with spotty poor locality (e.g. a small percentage of > regionservers with poor locality). > We already have this information available via the {{ClusterStatus}} proto. > We can easily write a shell command that can present regions which are > lacking a certain percentage of locality. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17973) Create shell command to identify regions with poor locality
[ https://issues.apache.org/jira/browse/HBASE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15991156#comment-15991156 ] Sean Busbey commented on HBASE-17973: - +1 > Create shell command to identify regions with poor locality > --- > > Key: HBASE-17973 > URL: https://issues.apache.org/jira/browse/HBASE-17973 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0 > > Attachments: HBASE-17973.001.patch, HBASE-17973.002.patch > > > The data locality of regions often plays a large role in the efficiency of > HBase. Compactions are also expensive to execute, especially on very large > tables. The balancer can do a good job trying to maintain locality (when > tuned properly), but it is not perfect. > This creates a less-than-desirable situation where it's a costly operation to > take a cluster with spotty poor locality (e.g. a small percentage of > regionservers with poor locality). > We already have this information available via the {{ClusterStatus}} proto. > We can easily write a shell command that can present regions which are > lacking a certain percentage of locality. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17973) Create shell command to identify regions with poor locality
[ https://issues.apache.org/jira/browse/HBASE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15991063#comment-15991063 ] Hadoop QA commented on HBASE-17973: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 23s {color} | {color:blue} Docker mode activated. {color} | | {color:blue}0{color} | {color:blue} rubocop {color} | {color:blue} 0m 0s {color} | {color:blue} rubocop was not available. {color} | | {color:blue}0{color} | {color:blue} ruby-lint {color} | {color:blue} 0m 0s {color} | {color:blue} Ruby-lint was not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 7s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 25s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 13s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 23s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 25s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 60m 51s {color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 15s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 5m 11s {color} | {color:green} hbase-shell in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 74m 46s {color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:8d52d23 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12865768/HBASE-17973.002.patch | | JIRA Issue | HBASE-17973 | | Optional Tests | asflicense javac javadoc unit rubocop ruby_lint | | uname | Linux da4a2e21296c 4.8.3-std-1 #1 SMP Fri Oct 21 11:15:43 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 94c14ad | | Default Java | 1.8.0_121 | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/6645/testReport/ | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/6645/console | | Powered by | Apache Yetus 0.3.0 http://yetus.apache.org | This message was automatically generated. > Create shell command to identify regions with poor locality > --- > > Key: HBASE-17973 > URL: https://issues.apache.org/jira/browse/HBASE-17973 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0 > > Attachments: HBASE-17973.001.patch, HBASE-17973.002.patch > > > The data locality of regions often plays a large role in the efficiency of > HBase. Compactions are also expensive to execute, especially on very large > tables. The balancer can do a good job trying to maintain locality (when > tuned properly), but it is not perfect. > This creates a less-than-desirable situation where it's a costly operation to > take a cluster with spotty poor locality (e.g. a small percentage of > regionservers with poor locality). > We already have this information available via the {{ClusterStatus}} proto. > We can easily write a shell command that can present regions which are > lacking a certain percentage of locality. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17973) Create shell command to identify regions with poor locality
[ https://issues.apache.org/jira/browse/HBASE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989731#comment-15989731 ] Sean Busbey commented on HBASE-17973: - {code} +startKey = Bytes.toString(hregion_info.getStartKey()) +endKey = Bytes.toString(hregion_info.getEndKey()) +region_load_map = cluster_status.getLoad(server_name).getRegionsLoad() +region_load = region_load_map.get(hregion_info.getRegionName()) +region_store_file_size = region_load.getStorefileSizeMB() +region_requests = region_load.getRequestsCount() +# Ignore regions which exceed our locality threshold +if accept_region_for_locality? region_load.getDataLocality(), locality_threshold + results << { "server" => hregion.getServerName().toString(), "name" => hregion_info.getRegionNameAsString(), "startkey" => startKey, "endkey" => endKey, + "size" => region_store_file_size, "requests" => region_requests, "locality" => region_load.getDataLocality() } end {code} Can we do the locality check prior to setting up all the pieces for the results? > Create shell command to identify regions with poor locality > --- > > Key: HBASE-17973 > URL: https://issues.apache.org/jira/browse/HBASE-17973 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0 > > Attachments: HBASE-17973.001.patch > > > The data locality of regions often plays a large role in the efficiency of > HBase. Compactions are also expensive to execute, especially on very large > tables. The balancer can do a good job trying to maintain locality (when > tuned properly), but it is not perfect. > This creates a less-than-desirable situation where it's a costly operation to > take a cluster with spotty poor locality (e.g. a small percentage of > regionservers with poor locality). > We already have this information available via the {{ClusterStatus}} proto. > We can easily write a shell command that can present regions which are > lacking a certain percentage of locality. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17973) Create shell command to identify regions with poor locality
[ https://issues.apache.org/jira/browse/HBASE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989484#comment-15989484 ] Hadoop QA commented on HBASE-17973: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 16s {color} | {color:blue} Docker mode activated. {color} | | {color:blue}0{color} | {color:blue} rubocop {color} | {color:blue} 0m 0s {color} | {color:blue} rubocop was not available. {color} | | {color:blue}0{color} | {color:blue} ruby-lint {color} | {color:blue} 0m 0s {color} | {color:blue} Ruby-lint was not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 39s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 18s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 9s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 16s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 17s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 29m 12s {color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 8s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m 56s {color} | {color:green} hbase-shell in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 6s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 39m 28s {color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12865610/HBASE-17973.001.patch | | JIRA Issue | HBASE-17973 | | Optional Tests | asflicense javac javadoc unit rubocop ruby_lint | | uname | Linux 09fc12f6bce9 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 6edb8f8 | | Default Java | 1.8.0_121 | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/6628/testReport/ | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/6628/console | | Powered by | Apache Yetus 0.3.0 http://yetus.apache.org | This message was automatically generated. > Create shell command to identify regions with poor locality > --- > > Key: HBASE-17973 > URL: https://issues.apache.org/jira/browse/HBASE-17973 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0 > > Attachments: HBASE-17973.001.patch > > > The data locality of regions often plays a large role in the efficiency of > HBase. Compactions are also expensive to execute, especially on very large > tables. The balancer can do a good job trying to maintain locality (when > tuned properly), but it is not perfect. > This creates a less-than-desirable situation where it's a costly operation to > take a cluster with spotty poor locality (e.g. a small percentage of > regionservers with poor locality). > We already have this information available via the {{ClusterStatus}} proto. > We can easily write a shell command that can present regions which are > lacking a certain percentage of locality. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17973) Create shell command to identify regions with poor locality
[ https://issues.apache.org/jira/browse/HBASE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988749#comment-15988749 ] Josh Elser commented on HBASE-17973: bq. You want a dedicated command for that ? if not we can make it part of list_regions command output added as part of HBASE-14925 ? Hi [~ashish singhi]! {{list_regions}} sounds like a great location for it to land (I had missed that one). Let me re-jigger my patch to land to try to include it there :) > Create shell command to identify regions with poor locality > --- > > Key: HBASE-17973 > URL: https://issues.apache.org/jira/browse/HBASE-17973 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Josh Elser >Assignee: Josh Elser > > The data locality of regions often plays a large role in the efficiency of > HBase. Compactions are also expensive to execute, especially on very large > tables. The balancer can do a good job trying to maintain locality (when > tuned properly), but it is not perfect. > This creates a less-than-desirable situation where it's a costly operation to > take a cluster with spotty poor locality (e.g. a small percentage of > regionservers with poor locality). > We already have this information available via the {{ClusterStatus}} proto. > We can easily write a shell command that can present regions which are > lacking a certain percentage of locality. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17973) Create shell command to identify regions with poor locality
[ https://issues.apache.org/jira/browse/HBASE-17973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988729#comment-15988729 ] Ashish Singhi commented on HBASE-17973: --- You want a dedicated command for that ? if not we can make it part of {{list_regions}} command output added as part of HBASE-14925 ? > Create shell command to identify regions with poor locality > --- > > Key: HBASE-17973 > URL: https://issues.apache.org/jira/browse/HBASE-17973 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Josh Elser >Assignee: Josh Elser > > The data locality of regions often plays a large role in the efficiency of > HBase. Compactions are also expensive to execute, especially on very large > tables. The balancer can do a good job trying to maintain locality (when > tuned properly), but it is not perfect. > This creates a less-than-desirable situation where it's a costly operation to > take a cluster with spotty poor locality (e.g. a small percentage of > regionservers with poor locality). > We already have this information available via the {{ClusterStatus}} proto. > We can easily write a shell command that can present regions which are > lacking a certain percentage of locality. -- This message was sent by Atlassian JIRA (v6.3.15#6346)