[jira] [Commented] (HBASE-17977) Enabled Master observer to delete quotas on table deletion by default
[ https://issues.apache.org/jira/browse/HBASE-17977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16020898#comment-16020898 ] Hudson commented on HBASE-17977: FAILURE: Integrated in Jenkins build HBase-HBASE-14614 #244 (See [https://builds.apache.org/job/HBase-HBASE-14614/244/]) HBASE-17977 Enable the MasterSpaceQuotaObserver by default (elserj: rev f1a9990328a65c49cdd10af069f67ff5ba5147f9) * (add) hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestMasterSpaceQuotaObserverWithMocks.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestMasterSpaceQuotaObserver.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/MasterSpaceQuotaObserver.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * (edit) src/main/asciidoc/_chapters/ops_mgt.adoc > Enabled Master observer to delete quotas on table deletion by default > - > > Key: HBASE-17977 > URL: https://issues.apache.org/jira/browse/HBASE-17977 > Project: HBase > Issue Type: Sub-task >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: HBASE-16961 > > Attachments: HBASE-17977.001.HBASE-16961.patch, > HBASE-17977.002.HBASE-16961.patch > > > Deleting a table's quota when we delete the table should be the common case, > not the exception. > Load the observer by default (when quota support is enabled), and switch the > flag to disable loading it. Make sure to update the docs too. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17977) Enabled Master observer to delete quotas on table deletion by default
[ https://issues.apache.org/jira/browse/HBASE-17977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16020315#comment-16020315 ] Hudson commented on HBASE-17977: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3059 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3059/]) HBASE-17977 Enable the MasterSpaceQuotaObserver by default (elserj: rev f1a9990328a65c49cdd10af069f67ff5ba5147f9) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/MasterSpaceQuotaObserver.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * (add) hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestMasterSpaceQuotaObserverWithMocks.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestMasterSpaceQuotaObserver.java * (edit) src/main/asciidoc/_chapters/ops_mgt.adoc > Enabled Master observer to delete quotas on table deletion by default > - > > Key: HBASE-17977 > URL: https://issues.apache.org/jira/browse/HBASE-17977 > Project: HBase > Issue Type: Sub-task >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: HBASE-16961 > > Attachments: HBASE-17977.001.HBASE-16961.patch, > HBASE-17977.002.HBASE-16961.patch > > > Deleting a table's quota when we delete the table should be the common case, > not the exception. > Load the observer by default (when quota support is enabled), and switch the > flag to disable loading it. Make sure to update the docs too. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17977) Enabled Master observer to delete quotas on table deletion by default
[ https://issues.apache.org/jira/browse/HBASE-17977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997366#comment-15997366 ] Andrew Purtell commented on HBASE-17977: +1 > Enabled Master observer to delete quotas on table deletion by default > - > > Key: HBASE-17977 > URL: https://issues.apache.org/jira/browse/HBASE-17977 > Project: HBase > Issue Type: Sub-task >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: HBASE-16961 > > Attachments: HBASE-17977.001.HBASE-16961.patch, > HBASE-17977.002.HBASE-16961.patch > > > Deleting a table's quota when we delete the table should be the common case, > not the exception. > Load the observer by default (when quota support is enabled), and switch the > flag to disable loading it. Make sure to update the docs too. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17977) Enabled Master observer to delete quotas on table deletion by default
[ https://issues.apache.org/jira/browse/HBASE-17977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997211#comment-15997211 ] Josh Elser commented on HBASE-17977: The above test failures either pass locally or also fail on `master`. Ted/Andrew, if you have a moment to re-check, please. > Enabled Master observer to delete quotas on table deletion by default > - > > Key: HBASE-17977 > URL: https://issues.apache.org/jira/browse/HBASE-17977 > Project: HBase > Issue Type: Sub-task >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: HBASE-16961 > > Attachments: HBASE-17977.001.HBASE-16961.patch, > HBASE-17977.002.HBASE-16961.patch > > > Deleting a table's quota when we delete the table should be the common case, > not the exception. > Load the observer by default (when quota support is enabled), and switch the > flag to disable loading it. Make sure to update the docs too. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17977) Enabled Master observer to delete quotas on table deletion by default
[
https://issues.apache.org/jira/browse/HBASE-17977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996457#comment-15996457
]
Hadoop QA commented on HBASE-17977:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 29s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 39s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
38s {color} | {color:green} HBASE-16961 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m 16s
{color} | {color:green} HBASE-16961 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
56s {color} | {color:green} HBASE-16961 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m
11s {color} | {color:green} HBASE-16961 passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s
{color} | {color:blue} Skipped patched modules with no Java source: . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
20s {color} | {color:green} HBASE-16961 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 5m 1s
{color} | {color:green} HBASE-16961 passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 20s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
0s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m 59s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 7m 59s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
25s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m
40s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m 19s
{color} | {color:red} The patch causes 16 errors with Hadoop v2.4.0. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m 40s
{color} | {color:red} The patch causes 16 errors with Hadoop v2.4.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 6m 59s
{color} | {color:red} The patch causes 16 errors with Hadoop v2.5.0. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 9m 19s
{color} | {color:red} The patch causes 16 errors with Hadoop v2.5.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 11m 37s
{color} | {color:red} The patch causes 16 errors with Hadoop v2.5.2. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s
{color} | {color:blue} Skipped patched modules with no Java source: . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
16s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m 48s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 111m 53s
{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 209m 17s
{color} | {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
36s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 458m 1s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.regionserver.TestRegionReplicaFailover |
| | hadoop.hbase.client.TestAsyncRegionAdminApi |
| | hadoop.hbase.snapshot.TestExportSnapshot |
| |
[jira] [Commented] (HBASE-17977) Enabled Master observer to delete quotas on table deletion by default
[ https://issues.apache.org/jira/browse/HBASE-17977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996005#comment-15996005 ] Josh Elser commented on HBASE-17977: bq. Functionally this looks fine but hbase.master.quota.observer.ignore describes internals not intent. How about hbase.quota.remove.on.drop? (or ...on.delete) That's a really good point. Let me re-roll the patch. > Enabled Master observer to delete quotas on table deletion by default > - > > Key: HBASE-17977 > URL: https://issues.apache.org/jira/browse/HBASE-17977 > Project: HBase > Issue Type: Sub-task >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: HBASE-16961 > > Attachments: HBASE-17977.001.HBASE-16961.patch > > > Deleting a table's quota when we delete the table should be the common case, > not the exception. > Load the observer by default (when quota support is enabled), and switch the > flag to disable loading it. Make sure to update the docs too. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17977) Enabled Master observer to delete quotas on table deletion by default
[
https://issues.apache.org/jira/browse/HBASE-17977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15995931#comment-15995931
]
Andrew Purtell commented on HBASE-17977:
Functionally this looks fine but {{hbase.master.quota.observer.ignore}}
describes internals not intent. How about {{hbase.quota.remove.on.drop}}? (or
...on.delete)
> Enabled Master observer to delete quotas on table deletion by default
> -
>
> Key: HBASE-17977
> URL: https://issues.apache.org/jira/browse/HBASE-17977
> Project: HBase
> Issue Type: Sub-task
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: HBASE-16961
>
> Attachments: HBASE-17977.001.HBASE-16961.patch
>
>
> Deleting a table's quota when we delete the table should be the common case,
> not the exception.
> Load the observer by default (when quota support is enabled), and switch the
> flag to disable loading it. Make sure to update the docs too.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17977) Enabled Master observer to delete quotas on table deletion by default
[ https://issues.apache.org/jira/browse/HBASE-17977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15995690#comment-15995690 ] Ted Yu commented on HBASE-17977: lgtm > Enabled Master observer to delete quotas on table deletion by default > - > > Key: HBASE-17977 > URL: https://issues.apache.org/jira/browse/HBASE-17977 > Project: HBase > Issue Type: Sub-task >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: HBASE-16961 > > Attachments: HBASE-17977.001.HBASE-16961.patch > > > Deleting a table's quota when we delete the table should be the common case, > not the exception. > Load the observer by default (when quota support is enabled), and switch the > flag to disable loading it. Make sure to update the docs too. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17977) Enabled Master observer to delete quotas on table deletion by default
[ https://issues.apache.org/jira/browse/HBASE-17977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15995682#comment-15995682 ] Josh Elser commented on HBASE-17977: One more if you can review, [~apurtell], [~tedyu] :) More of the same flakey tests seen on the other issues we were chatting over. > Enabled Master observer to delete quotas on table deletion by default > - > > Key: HBASE-17977 > URL: https://issues.apache.org/jira/browse/HBASE-17977 > Project: HBase > Issue Type: Sub-task >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: HBASE-16961 > > Attachments: HBASE-17977.001.HBASE-16961.patch > > > Deleting a table's quota when we delete the table should be the common case, > not the exception. > Load the observer by default (when quota support is enabled), and switch the > flag to disable loading it. Make sure to update the docs too. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17977) Enabled Master observer to delete quotas on table deletion by default
[
https://issues.apache.org/jira/browse/HBASE-17977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994160#comment-15994160
]
Hadoop QA commented on HBASE-17977:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 24s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 34s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
26s {color} | {color:green} HBASE-16961 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m 30s
{color} | {color:green} HBASE-16961 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
58s {color} | {color:green} HBASE-16961 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m
15s {color} | {color:green} HBASE-16961 passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s
{color} | {color:blue} Skipped patched modules with no Java source: . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
23s {color} | {color:green} HBASE-16961 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 5m 6s
{color} | {color:green} HBASE-16961 passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 26s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m
23s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m 46s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 8m 46s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
30s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m
45s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m 16s
{color} | {color:red} The patch causes 16 errors with Hadoop v2.4.0. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m 32s
{color} | {color:red} The patch causes 16 errors with Hadoop v2.4.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 6m 47s
{color} | {color:red} The patch causes 16 errors with Hadoop v2.5.0. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 9m 14s
{color} | {color:red} The patch causes 16 errors with Hadoop v2.5.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 11m 41s
{color} | {color:red} The patch causes 16 errors with Hadoop v2.5.2. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s
{color} | {color:blue} Skipped patched modules with no Java source: . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
29s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m 46s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 110m 30s
{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 128m 40s
{color} | {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
40s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 380m 16s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests |
org.apache.hadoop.hbase.replication.regionserver.TestWALEntryStream |
| | org.apache.hadoop.hbase.io.encoding.TestChangingEncoding |
| |
