[jira] [Commented] (HBASE-18041) Add pylintrc file to HBase
[ https://issues.apache.org/jira/browse/HBASE-18041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16072580#comment-16072580 ] Hudson commented on HBASE-18041: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #130 (See [https://builds.apache.org/job/HBase-1.3-IT/130/]) HBASE-18041 Add .pylintrc to HBase (busbey: rev 8d40b2d98ffc6b2b522f6b1efdfca46e3ace977e) * (add) .pylintrc > Add pylintrc file to HBase > -- > > Key: HBASE-18041 > URL: https://issues.apache.org/jira/browse/HBASE-18041 > Project: HBase > Issue Type: Improvement > Components: community >Reporter: Alex Leblang >Assignee: Alex Leblang > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12 > > Attachments: diff-patch-pylint-noRC.txt, diff-patch-pylint.txt, > HBASE-18041.branch-1.2.001.patch > > > Yetus runs all commits with python files through a linter. I think that the > HBase community should add a pylintrc file to actively choose the project's > python style instead of just relying on yetus defaults. > As an argument for this, the yetus project itself doesn't even use the > default python linter for its own commits. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18041) Add pylintrc file to HBase
[ https://issues.apache.org/jira/browse/HBASE-18041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067685#comment-16067685 ] Hudson commented on HBASE-18041: SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #3280 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3280/]) HBASE-18041 Add .pylintrc to HBase (busbey: rev 4a2a164b0008e04ebc4b947d80d19046ade772b0) * (add) .pylintrc > Add pylintrc file to HBase > -- > > Key: HBASE-18041 > URL: https://issues.apache.org/jira/browse/HBASE-18041 > Project: HBase > Issue Type: Improvement > Components: community >Reporter: Alex Leblang >Assignee: Alex Leblang > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12 > > Attachments: diff-patch-pylint-noRC.txt, diff-patch-pylint.txt, > HBASE-18041.branch-1.2.001.patch > > > Yetus runs all commits with python files through a linter. I think that the > HBase community should add a pylintrc file to actively choose the project's > python style instead of just relying on yetus defaults. > As an argument for this, the yetus project itself doesn't even use the > default python linter for its own commits. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18041) Add pylintrc file to HBase
[ https://issues.apache.org/jira/browse/HBASE-18041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067484#comment-16067484 ] Hudson commented on HBASE-18041: SUCCESS: Integrated in Jenkins build HBase-2.0 #127 (See [https://builds.apache.org/job/HBase-2.0/127/]) HBASE-18041 Add .pylintrc to HBase (busbey: rev a11c5fd2b1180f1979d50eb8d516772744001663) * (add) .pylintrc > Add pylintrc file to HBase > -- > > Key: HBASE-18041 > URL: https://issues.apache.org/jira/browse/HBASE-18041 > Project: HBase > Issue Type: Improvement > Components: community >Reporter: Alex Leblang >Assignee: Alex Leblang > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12 > > Attachments: diff-patch-pylint-noRC.txt, diff-patch-pylint.txt, > HBASE-18041.branch-1.2.001.patch > > > Yetus runs all commits with python files through a linter. I think that the > HBase community should add a pylintrc file to actively choose the project's > python style instead of just relying on yetus defaults. > As an argument for this, the yetus project itself doesn't even use the > default python linter for its own commits. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18041) Add pylintrc file to HBase
[ https://issues.apache.org/jira/browse/HBASE-18041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067194#comment-16067194 ] Hudson commented on HBASE-18041: FAILURE: Integrated in Jenkins build HBase-1.4 #793 (See [https://builds.apache.org/job/HBase-1.4/793/]) HBASE-18041 Add .pylintrc to HBase (busbey: rev 0f0ff0ef525e3ad2e6fa90420d930806c6add7ac) * (add) .pylintrc > Add pylintrc file to HBase > -- > > Key: HBASE-18041 > URL: https://issues.apache.org/jira/browse/HBASE-18041 > Project: HBase > Issue Type: Improvement > Components: community >Reporter: Alex Leblang >Assignee: Alex Leblang > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12 > > Attachments: diff-patch-pylint-noRC.txt, diff-patch-pylint.txt, > HBASE-18041.branch-1.2.001.patch > > > Yetus runs all commits with python files through a linter. I think that the > HBase community should add a pylintrc file to actively choose the project's > python style instead of just relying on yetus defaults. > As an argument for this, the yetus project itself doesn't even use the > default python linter for its own commits. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18041) Add pylintrc file to HBase
[ https://issues.apache.org/jira/browse/HBASE-18041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067173#comment-16067173 ] Hudson commented on HBASE-18041: SUCCESS: Integrated in Jenkins build HBase-1.2-JDK8 #154 (See [https://builds.apache.org/job/HBase-1.2-JDK8/154/]) HBASE-18041 Add .pylintrc to HBase (busbey: rev 8c09370dac163a00dce79aebfde240143c5cc989) * (add) .pylintrc > Add pylintrc file to HBase > -- > > Key: HBASE-18041 > URL: https://issues.apache.org/jira/browse/HBASE-18041 > Project: HBase > Issue Type: Improvement > Components: community >Reporter: Alex Leblang >Assignee: Alex Leblang > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12 > > Attachments: diff-patch-pylint-noRC.txt, diff-patch-pylint.txt, > HBASE-18041.branch-1.2.001.patch > > > Yetus runs all commits with python files through a linter. I think that the > HBase community should add a pylintrc file to actively choose the project's > python style instead of just relying on yetus defaults. > As an argument for this, the yetus project itself doesn't even use the > default python linter for its own commits. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18041) Add pylintrc file to HBase
[ https://issues.apache.org/jira/browse/HBASE-18041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067172#comment-16067172 ] Hudson commented on HBASE-18041: SUCCESS: Integrated in Jenkins build HBase-1.3-JDK7 #189 (See [https://builds.apache.org/job/HBase-1.3-JDK7/189/]) HBASE-18041 Add .pylintrc to HBase (busbey: rev 8d40b2d98ffc6b2b522f6b1efdfca46e3ace977e) * (add) .pylintrc > Add pylintrc file to HBase > -- > > Key: HBASE-18041 > URL: https://issues.apache.org/jira/browse/HBASE-18041 > Project: HBase > Issue Type: Improvement > Components: community >Reporter: Alex Leblang >Assignee: Alex Leblang > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12 > > Attachments: diff-patch-pylint-noRC.txt, diff-patch-pylint.txt, > HBASE-18041.branch-1.2.001.patch > > > Yetus runs all commits with python files through a linter. I think that the > HBase community should add a pylintrc file to actively choose the project's > python style instead of just relying on yetus defaults. > As an argument for this, the yetus project itself doesn't even use the > default python linter for its own commits. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18041) Add pylintrc file to HBase
[ https://issues.apache.org/jira/browse/HBASE-18041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067147#comment-16067147 ] Hudson commented on HBASE-18041: FAILURE: Integrated in Jenkins build HBase-1.3-JDK8 #203 (See [https://builds.apache.org/job/HBase-1.3-JDK8/203/]) HBASE-18041 Add .pylintrc to HBase (busbey: rev 8d40b2d98ffc6b2b522f6b1efdfca46e3ace977e) * (add) .pylintrc > Add pylintrc file to HBase > -- > > Key: HBASE-18041 > URL: https://issues.apache.org/jira/browse/HBASE-18041 > Project: HBase > Issue Type: Improvement > Components: community >Reporter: Alex Leblang >Assignee: Alex Leblang > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12 > > Attachments: diff-patch-pylint-noRC.txt, diff-patch-pylint.txt, > HBASE-18041.branch-1.2.001.patch > > > Yetus runs all commits with python files through a linter. I think that the > HBase community should add a pylintrc file to actively choose the project's > python style instead of just relying on yetus defaults. > As an argument for this, the yetus project itself doesn't even use the > default python linter for its own commits. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18041) Add pylintrc file to HBase
[ https://issues.apache.org/jira/browse/HBASE-18041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067145#comment-16067145 ] Hudson commented on HBASE-18041: FAILURE: Integrated in Jenkins build HBase-1.2-JDK7 #158 (See [https://builds.apache.org/job/HBase-1.2-JDK7/158/]) HBASE-18041 Add .pylintrc to HBase (busbey: rev 8c09370dac163a00dce79aebfde240143c5cc989) * (add) .pylintrc > Add pylintrc file to HBase > -- > > Key: HBASE-18041 > URL: https://issues.apache.org/jira/browse/HBASE-18041 > Project: HBase > Issue Type: Improvement > Components: community >Reporter: Alex Leblang >Assignee: Alex Leblang > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12 > > Attachments: diff-patch-pylint-noRC.txt, diff-patch-pylint.txt, > HBASE-18041.branch-1.2.001.patch > > > Yetus runs all commits with python files through a linter. I think that the > HBase community should add a pylintrc file to actively choose the project's > python style instead of just relying on yetus defaults. > As an argument for this, the yetus project itself doesn't even use the > default python linter for its own commits. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18041) Add pylintrc file to HBase
[ https://issues.apache.org/jira/browse/HBASE-18041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067129#comment-16067129 ] Hudson commented on HBASE-18041: FAILURE: Integrated in Jenkins build HBase-1.1-JDK8 #1969 (See [https://builds.apache.org/job/HBase-1.1-JDK8/1969/]) HBASE-18041 Add .pylintrc to HBase (busbey: rev 8db0cd11ba2eee6646f1d5f713e187327cdefb76) * (add) .pylintrc > Add pylintrc file to HBase > -- > > Key: HBASE-18041 > URL: https://issues.apache.org/jira/browse/HBASE-18041 > Project: HBase > Issue Type: Improvement > Components: community >Reporter: Alex Leblang >Assignee: Alex Leblang > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12 > > Attachments: diff-patch-pylint-noRC.txt, diff-patch-pylint.txt, > HBASE-18041.branch-1.2.001.patch > > > Yetus runs all commits with python files through a linter. I think that the > HBase community should add a pylintrc file to actively choose the project's > python style instead of just relying on yetus defaults. > As an argument for this, the yetus project itself doesn't even use the > default python linter for its own commits. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18041) Add pylintrc file to HBase
[ https://issues.apache.org/jira/browse/HBASE-18041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067116#comment-16067116 ] Hudson commented on HBASE-18041: SUCCESS: Integrated in Jenkins build HBase-1.1-JDK7 #1886 (See [https://builds.apache.org/job/HBase-1.1-JDK7/1886/]) HBASE-18041 Add .pylintrc to HBase (busbey: rev 8db0cd11ba2eee6646f1d5f713e187327cdefb76) * (add) .pylintrc > Add pylintrc file to HBase > -- > > Key: HBASE-18041 > URL: https://issues.apache.org/jira/browse/HBASE-18041 > Project: HBase > Issue Type: Improvement > Components: community >Reporter: Alex Leblang >Assignee: Alex Leblang > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12 > > Attachments: diff-patch-pylint-noRC.txt, diff-patch-pylint.txt, > HBASE-18041.branch-1.2.001.patch > > > Yetus runs all commits with python files through a linter. I think that the > HBase community should add a pylintrc file to actively choose the project's > python style instead of just relying on yetus defaults. > As an argument for this, the yetus project itself doesn't even use the > default python linter for its own commits. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18041) Add pylintrc file to HBase
[ https://issues.apache.org/jira/browse/HBASE-18041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067109#comment-16067109 ] Hudson commented on HBASE-18041: SUCCESS: Integrated in Jenkins build HBase-1.2-IT #891 (See [https://builds.apache.org/job/HBase-1.2-IT/891/]) HBASE-18041 Add .pylintrc to HBase (busbey: rev 8c09370dac163a00dce79aebfde240143c5cc989) * (add) .pylintrc > Add pylintrc file to HBase > -- > > Key: HBASE-18041 > URL: https://issues.apache.org/jira/browse/HBASE-18041 > Project: HBase > Issue Type: Improvement > Components: community >Reporter: Alex Leblang >Assignee: Alex Leblang > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12 > > Attachments: diff-patch-pylint-noRC.txt, diff-patch-pylint.txt, > HBASE-18041.branch-1.2.001.patch > > > Yetus runs all commits with python files through a linter. I think that the > HBase community should add a pylintrc file to actively choose the project's > python style instead of just relying on yetus defaults. > As an argument for this, the yetus project itself doesn't even use the > default python linter for its own commits. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18041) Add pylintrc file to HBase
[ https://issues.apache.org/jira/browse/HBASE-18041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16066935#comment-16066935 ] Alex Leblang commented on HBASE-18041: -- Woohoo! Thanks Sean! > Add pylintrc file to HBase > -- > > Key: HBASE-18041 > URL: https://issues.apache.org/jira/browse/HBASE-18041 > Project: HBase > Issue Type: Improvement > Components: community >Reporter: Alex Leblang >Assignee: Alex Leblang > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12 > > Attachments: diff-patch-pylint-noRC.txt, diff-patch-pylint.txt, > HBASE-18041.branch-1.2.001.patch > > > Yetus runs all commits with python files through a linter. I think that the > HBase community should add a pylintrc file to actively choose the project's > python style instead of just relying on yetus defaults. > As an argument for this, the yetus project itself doesn't even use the > default python linter for its own commits. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18041) Add pylintrc file to HBase
[ https://issues.apache.org/jira/browse/HBASE-18041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021976#comment-16021976 ] Dima Spivak commented on HBASE-18041: - And to answer the question of what's needed to move forward, I'd say let's just get a run of the code base with this and see what it gives us. If it looks reasonable, I'll +1 it and we can handle cleanup later. > Add pylintrc file to HBase > -- > > Key: HBASE-18041 > URL: https://issues.apache.org/jira/browse/HBASE-18041 > Project: HBase > Issue Type: Improvement > Components: community >Reporter: Alex Leblang >Assignee: Alex Leblang > Attachments: HBASE-18041.branch-1.2.001.patch > > > Yetus runs all commits with python files through a linter. I think that the > HBase community should add a pylintrc file to actively choose the project's > python style instead of just relying on yetus defaults. > As an argument for this, the yetus project itself doesn't even use the > default python linter for its own commits. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-18041) Add pylintrc file to HBase
[
https://issues.apache.org/jira/browse/HBASE-18041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021975#comment-16021975
]
Dima Spivak commented on HBASE-18041:
-
Eh, it's probably fine. It's kinda hard to review a big 300 line config file
that's full of commented out stuff since I can't tell what's different from the
'default' and what isn't. Personally, I'd have started from a clean
{{pylintrc}} and then added stuff based on which errors we think are spurious,
but I dunno if it's worth taking the time to go through this exercise if
there's not much value to be gained.
> Add pylintrc file to HBase
> --
>
> Key: HBASE-18041
> URL: https://issues.apache.org/jira/browse/HBASE-18041
> Project: HBase
> Issue Type: Improvement
> Components: community
>Reporter: Alex Leblang
>Assignee: Alex Leblang
> Attachments: HBASE-18041.branch-1.2.001.patch
>
>
> Yetus runs all commits with python files through a linter. I think that the
> HBase community should add a pylintrc file to actively choose the project's
> python style instead of just relying on yetus defaults.
> As an argument for this, the yetus project itself doesn't even use the
> default python linter for its own commits.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-18041) Add pylintrc file to HBase
[ https://issues.apache.org/jira/browse/HBASE-18041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16020354#comment-16020354 ] Alex Leblang commented on HBASE-18041: -- [~dspivak] what do we need to do to move this forward? Do you want me to go through the checks I proposed not to use one by one? Should we try to get more opinions? > Add pylintrc file to HBase > -- > > Key: HBASE-18041 > URL: https://issues.apache.org/jira/browse/HBASE-18041 > Project: HBase > Issue Type: Improvement > Components: community >Reporter: Alex Leblang >Assignee: Alex Leblang > Attachments: HBASE-18041.branch-1.2.001.patch > > > Yetus runs all commits with python files through a linter. I think that the > HBase community should add a pylintrc file to actively choose the project's > python style instead of just relying on yetus defaults. > As an argument for this, the yetus project itself doesn't even use the > default python linter for its own commits. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-18041) Add pylintrc file to HBase
[ https://issues.apache.org/jira/browse/HBASE-18041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009048#comment-16009048 ] Alex Leblang commented on HBASE-18041: -- Well I just took the yetus pylintrc file so I can't be sure, but I know that linters can be pretty strict. We could start from another spot, but the things disabled weren't had selected to make our current codebase pass. > Add pylintrc file to HBase > -- > > Key: HBASE-18041 > URL: https://issues.apache.org/jira/browse/HBASE-18041 > Project: HBase > Issue Type: Improvement > Components: community >Reporter: Alex Leblang >Assignee: Alex Leblang > Attachments: HBASE-18041.branch-1.2.001.patch > > > Yetus runs all commits with python files through a linter. I think that the > HBase community should add a pylintrc file to actively choose the project's > python style instead of just relying on yetus defaults. > As an argument for this, the yetus project itself doesn't even use the > default python linter for its own commits. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-18041) Add pylintrc file to HBase
[ https://issues.apache.org/jira/browse/HBASE-18041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008860#comment-16008860 ] Dima Spivak commented on HBASE-18041: - Are we disabling a bunch of Pylint checks because the current code sucks? That seems like a bad idea. We should let it raise all kinds of errors and then open separate JIRAs to address them, I'd think. > Add pylintrc file to HBase > -- > > Key: HBASE-18041 > URL: https://issues.apache.org/jira/browse/HBASE-18041 > Project: HBase > Issue Type: Improvement > Components: community >Reporter: Alex Leblang >Assignee: Alex Leblang > Attachments: HBASE-18041.branch-1.2.001.patch > > > Yetus runs all commits with python files through a linter. I think that the > HBase community should add a pylintrc file to actively choose the project's > python style instead of just relying on yetus defaults. > As an argument for this, the yetus project itself doesn't even use the > default python linter for its own commits. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-18041) Add pylintrc file to HBase
[ https://issues.apache.org/jira/browse/HBASE-18041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008644#comment-16008644 ] Dima Spivak commented on HBASE-18041: - Yep, no problem. > Add pylintrc file to HBase > -- > > Key: HBASE-18041 > URL: https://issues.apache.org/jira/browse/HBASE-18041 > Project: HBase > Issue Type: Improvement > Components: community >Reporter: Alex Leblang > > Yetus runs all commits with python files through a linter. I think that the > HBase community should add a pylintrc file to actively choose the project's > python style instead of just relying on yetus defaults. > As an argument for this, the yetus project itself doesn't even use the > default python linter for its own commits. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-18041) Add pylintrc file to HBase
[ https://issues.apache.org/jira/browse/HBASE-18041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008623#comment-16008623 ] Sean Busbey commented on HBASE-18041: - well, as much as I'd like to have consistent spacing across the project (which would be 2), I like us following an established language default even better. [~dimaspivak] you mind handling this particular review? > Add pylintrc file to HBase > -- > > Key: HBASE-18041 > URL: https://issues.apache.org/jira/browse/HBASE-18041 > Project: HBase > Issue Type: Improvement > Components: community >Reporter: Alex Leblang > > Yetus runs all commits with python files through a linter. I think that the > HBase community should add a pylintrc file to actively choose the project's > python style instead of just relying on yetus defaults. > As an argument for this, the yetus project itself doesn't even use the > default python linter for its own commits. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-18041) Add pylintrc file to HBase
[ https://issues.apache.org/jira/browse/HBASE-18041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008619#comment-16008619 ] Alex Leblang commented on HBASE-18041: -- Sure, I'll make a first attempt at this. > Add pylintrc file to HBase > -- > > Key: HBASE-18041 > URL: https://issues.apache.org/jira/browse/HBASE-18041 > Project: HBase > Issue Type: Improvement > Components: community >Reporter: Alex Leblang > > Yetus runs all commits with python files through a linter. I think that the > HBase community should add a pylintrc file to actively choose the project's > python style instead of just relying on yetus defaults. > As an argument for this, the yetus project itself doesn't even use the > default python linter for its own commits. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-18041) Add pylintrc file to HBase
[ https://issues.apache.org/jira/browse/HBASE-18041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008616#comment-16008616 ] Dima Spivak commented on HBASE-18041: - Default is 4 spaces (that's a PEP 8 thing). > Add pylintrc file to HBase > -- > > Key: HBASE-18041 > URL: https://issues.apache.org/jira/browse/HBASE-18041 > Project: HBase > Issue Type: Improvement > Components: community >Reporter: Alex Leblang > > Yetus runs all commits with python files through a linter. I think that the > HBase community should add a pylintrc file to actively choose the project's > python style instead of just relying on yetus defaults. > As an argument for this, the yetus project itself doesn't even use the > default python linter for its own commits. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-18041) Add pylintrc file to HBase
[ https://issues.apache.org/jira/browse/HBASE-18041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008611#comment-16008611 ] Sean Busbey commented on HBASE-18041: - [~awleblang] you game for putting up a first-cut? [~dimaspivak] I thought the default in pylint was 4 spaces? Anyone else have Opinions about Python? > Add pylintrc file to HBase > -- > > Key: HBASE-18041 > URL: https://issues.apache.org/jira/browse/HBASE-18041 > Project: HBase > Issue Type: Improvement > Components: community >Reporter: Alex Leblang > > Yetis runs all commits with python files through a linter. I think that the > HBase community should add a pylintrc file to actively choose the project's > python style instead of just relying on yetis defaults. > As an argument for this, the yetis project itself doesn't even use the > default python linter for its own commits. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-18041) Add pylintrc file to HBase
[ https://issues.apache.org/jira/browse/HBASE-18041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008467#comment-16008467 ] Alex Leblang commented on HBASE-18041: -- This was prompted by some discussion in https://issues.apache.org/jira/browse/HBASE-18020. One issue that came up there was 2 versus 4 space indents in python. HBase uses both currently, though there aren't that many python files. Clusterdock uses 4 spaces, hadoop uses 2 spaces, and yetis uses two spaces. [~dimaspivak] expressed a desire to use 4 spaces > Add pylintrc file to HBase > -- > > Key: HBASE-18041 > URL: https://issues.apache.org/jira/browse/HBASE-18041 > Project: HBase > Issue Type: Improvement >Reporter: Alex Leblang > > Yetis runs all commits with python files through a linter. I think that the > HBase community should add a pylintrc file to actively choose the project's > python style instead of just relying on yetis defaults. > As an argument for this, the yetis project itself doesn't even use the > default python linter for its own commits. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
