[jira] [Commented] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191399#comment-16191399
]
Chia-Ping Tsai commented on HBASE-18131:
(Revisiting the AccessController remind me of this issue)
Could we remove the duplicate code on the server side? Why not pass a list of
server name to {{postClearDeadServers}} and {{postListDeadServers}}?
> Add an hbase shell command to clear deadserver list in ServerManager
>
>
> Key: HBASE-18131
> URL: https://issues.apache.org/jira/browse/HBASE-18131
> Project: HBase
> Issue Type: New Feature
> Components: Operability
>Reporter: Yu Li
>Assignee: Guangxu Cheng
> Fix For: 1.4.0, 1.5.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18131.branch-1.v1.patch,
> HBASE-18131.branch-1.v2.patch, HBASE-18131.master.v1.patch,
> HBASE-18131.master.v2.patch, HBASE-18131.master.v3.patch,
> HBASE-18131.master.v4.patch, HBASE-18131.master.v5.patch,
> HBASE-18131.master.v6.patch, HBASE-18131.master.v6.patch,
> HBASE-18131.master.v7.patch, HBASE-18131.patch
>
>
> Currently if a regionserver is aborted due to fatal error or stopped by
> operator on purpose, it will be added into {{ServerManager#deadservers}} list
> and shown as "Dead Servers" in the master UI. This is a valid warn for
> operators to notice the self-aborted servers and give a sanity check to
> avoid further issues. However, after necessary checks, even if operator is
> sure that the node is decommissioned (such as for repair), there's no way to
> clear the dead server list except restarting master. See more details in
> [this
> discussion|http://mail-archives.apache.org/mod_mbox/hbase-user/201705.mbox/%3CCAM7-19%2BD4MLu2b1R94%2BtWQDspjfny2sCy4Qit8JtCgjvTOZzzg%40mail.gmail.com%3E]
> in mail list
> Here we propose to add a hbase shell command to allow clearing dead server
> list in {{ServerManager}} for advanced users, and the command should be
> executed with caution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170127#comment-16170127
]
Chia-Ping Tsai commented on HBASE-18131:
bq. on the server side, we may not need to implement the method of
listDeadServers, but on the client side, I suggest to supports shell command
and api that the user can more clearly know how to get the crash server list.
+1 for readability
> Add an hbase shell command to clear deadserver list in ServerManager
>
>
> Key: HBASE-18131
> URL: https://issues.apache.org/jira/browse/HBASE-18131
> Project: HBase
> Issue Type: New Feature
> Components: Operability
>Reporter: Yu Li
>Assignee: Guangxu Cheng
> Fix For: 1.4.0, 1.5.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18131.branch-1.v1.patch,
> HBASE-18131.branch-1.v2.patch, HBASE-18131.master.v1.patch,
> HBASE-18131.master.v2.patch, HBASE-18131.master.v3.patch,
> HBASE-18131.master.v4.patch, HBASE-18131.master.v5.patch,
> HBASE-18131.master.v6.patch, HBASE-18131.master.v6.patch,
> HBASE-18131.master.v7.patch, HBASE-18131.patch
>
>
> Currently if a regionserver is aborted due to fatal error or stopped by
> operator on purpose, it will be added into {{ServerManager#deadservers}} list
> and shown as "Dead Servers" in the master UI. This is a valid warn for
> operators to notice the self-aborted servers and give a sanity check to
> avoid further issues. However, after necessary checks, even if operator is
> sure that the node is decommissioned (such as for repair), there's no way to
> clear the dead server list except restarting master. See more details in
> [this
> discussion|http://mail-archives.apache.org/mod_mbox/hbase-user/201705.mbox/%3CCAM7-19%2BD4MLu2b1R94%2BtWQDspjfny2sCy4Qit8JtCgjvTOZzzg%40mail.gmail.com%3E]
> in mail list
> Here we propose to add a hbase shell command to allow clearing dead server
> list in {{ServerManager}} for advanced users, and the command should be
> executed with caution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169938#comment-16169938
]
Guangxu Cheng commented on HBASE-18131:
---
bq.The getClusterStatus can return the list of dead servers. Perhaps the
listDeadServers is unnecessary. WDYT? Guangxu Cheng Thanks.
Sorry ,I did not notice it before. hmmm, on the server side, we may not need to
implement the method of listDeadServers, but on the client side, I suggest to
supports shell command and api that the user can more clearly know how to get
the crash server list.What do you think? [~chia7712] [~yuzhih...@gmail.com]
[~carp84]
> Add an hbase shell command to clear deadserver list in ServerManager
>
>
> Key: HBASE-18131
> URL: https://issues.apache.org/jira/browse/HBASE-18131
> Project: HBase
> Issue Type: New Feature
> Components: Operability
>Reporter: Yu Li
>Assignee: Guangxu Cheng
> Fix For: 1.4.0, 1.5.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18131.branch-1.v1.patch,
> HBASE-18131.branch-1.v2.patch, HBASE-18131.master.v1.patch,
> HBASE-18131.master.v2.patch, HBASE-18131.master.v3.patch,
> HBASE-18131.master.v4.patch, HBASE-18131.master.v5.patch,
> HBASE-18131.master.v6.patch, HBASE-18131.master.v6.patch,
> HBASE-18131.master.v7.patch, HBASE-18131.patch
>
>
> Currently if a regionserver is aborted due to fatal error or stopped by
> operator on purpose, it will be added into {{ServerManager#deadservers}} list
> and shown as "Dead Servers" in the master UI. This is a valid warn for
> operators to notice the self-aborted servers and give a sanity check to
> avoid further issues. However, after necessary checks, even if operator is
> sure that the node is decommissioned (such as for repair), there's no way to
> clear the dead server list except restarting master. See more details in
> [this
> discussion|http://mail-archives.apache.org/mod_mbox/hbase-user/201705.mbox/%3CCAM7-19%2BD4MLu2b1R94%2BtWQDspjfny2sCy4Qit8JtCgjvTOZzzg%40mail.gmail.com%3E]
> in mail list
> Here we propose to add a hbase shell command to allow clearing dead server
> list in {{ServerManager}} for advanced users, and the command should be
> executed with caution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169006#comment-16169006
]
Chia-Ping Tsai commented on HBASE-18131:
The {{getClusterStatus}} can return the list of dead servers. Perhaps the
{{listDeadServers}} is unnecessary. WDYT? [~andrewcheng] Thanks.
> Add an hbase shell command to clear deadserver list in ServerManager
>
>
> Key: HBASE-18131
> URL: https://issues.apache.org/jira/browse/HBASE-18131
> Project: HBase
> Issue Type: New Feature
> Components: Operability
>Reporter: Yu Li
>Assignee: Guangxu Cheng
> Fix For: 1.4.0, 1.5.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18131.branch-1.v1.patch,
> HBASE-18131.branch-1.v2.patch, HBASE-18131.master.v1.patch,
> HBASE-18131.master.v2.patch, HBASE-18131.master.v3.patch,
> HBASE-18131.master.v4.patch, HBASE-18131.master.v5.patch,
> HBASE-18131.master.v6.patch, HBASE-18131.master.v6.patch,
> HBASE-18131.master.v7.patch, HBASE-18131.patch
>
>
> Currently if a regionserver is aborted due to fatal error or stopped by
> operator on purpose, it will be added into {{ServerManager#deadservers}} list
> and shown as "Dead Servers" in the master UI. This is a valid warn for
> operators to notice the self-aborted servers and give a sanity check to
> avoid further issues. However, after necessary checks, even if operator is
> sure that the node is decommissioned (such as for repair), there's no way to
> clear the dead server list except restarting master. See more details in
> [this
> discussion|http://mail-archives.apache.org/mod_mbox/hbase-user/201705.mbox/%3CCAM7-19%2BD4MLu2b1R94%2BtWQDspjfny2sCy4Qit8JtCgjvTOZzzg%40mail.gmail.com%3E]
> in mail list
> Here we propose to add a hbase shell command to allow clearing dead server
> list in {{ServerManager}} for advanced users, and the command should be
> executed with caution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167677#comment-16167677
]
Guangxu Cheng commented on HBASE-18131:
---
bq.Can you check the hbaseprotoc warnings ?
the patch pass locally.
https://builds.apache.org/job/PreCommit-HBASE-Build/8595/artifact/patchprocess/patch-hbaseprotoc-hbase-protocol.txt
Since this file does not exist, so I do not know why these warnings appear.:(
By the way, I only updated the file Master.proto which located at
hbase-protocol. But hbase-client/hbase-server/hbase-shell all have hbaseprotoc
warnings. Maybe these hbaseprotoc warnings are unrelated.(?)
> Add an hbase shell command to clear deadserver list in ServerManager
>
>
> Key: HBASE-18131
> URL: https://issues.apache.org/jira/browse/HBASE-18131
> Project: HBase
> Issue Type: New Feature
> Components: Operability
>Reporter: Yu Li
>Assignee: Guangxu Cheng
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-18131.branch-1.v1.patch,
> HBASE-18131.branch-1.v2.patch, HBASE-18131.master.v1.patch,
> HBASE-18131.master.v2.patch, HBASE-18131.master.v3.patch,
> HBASE-18131.master.v4.patch, HBASE-18131.master.v5.patch,
> HBASE-18131.master.v6.patch, HBASE-18131.master.v6.patch,
> HBASE-18131.master.v7.patch, HBASE-18131.patch
>
>
> Currently if a regionserver is aborted due to fatal error or stopped by
> operator on purpose, it will be added into {{ServerManager#deadservers}} list
> and shown as "Dead Servers" in the master UI. This is a valid warn for
> operators to notice the self-aborted servers and give a sanity check to
> avoid further issues. However, after necessary checks, even if operator is
> sure that the node is decommissioned (such as for repair), there's no way to
> clear the dead server list except restarting master. See more details in
> [this
> discussion|http://mail-archives.apache.org/mod_mbox/hbase-user/201705.mbox/%3CCAM7-19%2BD4MLu2b1R94%2BtWQDspjfny2sCy4Qit8JtCgjvTOZzzg%40mail.gmail.com%3E]
> in mail list
> Here we propose to add a hbase shell command to allow clearing dead server
> list in {{ServerManager}} for advanced users, and the command should be
> executed with caution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167628#comment-16167628
]
Ted Yu commented on HBASE-18131:
Can you check the hbaseprotoc warnings ?
> Add an hbase shell command to clear deadserver list in ServerManager
>
>
> Key: HBASE-18131
> URL: https://issues.apache.org/jira/browse/HBASE-18131
> Project: HBase
> Issue Type: New Feature
> Components: Operability
>Reporter: Yu Li
>Assignee: Guangxu Cheng
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-18131.branch-1.v1.patch,
> HBASE-18131.branch-1.v2.patch, HBASE-18131.master.v1.patch,
> HBASE-18131.master.v2.patch, HBASE-18131.master.v3.patch,
> HBASE-18131.master.v4.patch, HBASE-18131.master.v5.patch,
> HBASE-18131.master.v6.patch, HBASE-18131.master.v6.patch,
> HBASE-18131.master.v7.patch, HBASE-18131.patch
>
>
> Currently if a regionserver is aborted due to fatal error or stopped by
> operator on purpose, it will be added into {{ServerManager#deadservers}} list
> and shown as "Dead Servers" in the master UI. This is a valid warn for
> operators to notice the self-aborted servers and give a sanity check to
> avoid further issues. However, after necessary checks, even if operator is
> sure that the node is decommissioned (such as for repair), there's no way to
> clear the dead server list except restarting master. See more details in
> [this
> discussion|http://mail-archives.apache.org/mod_mbox/hbase-user/201705.mbox/%3CCAM7-19%2BD4MLu2b1R94%2BtWQDspjfny2sCy4Qit8JtCgjvTOZzzg%40mail.gmail.com%3E]
> in mail list
> Here we propose to add a hbase shell command to allow clearing dead server
> list in {{ServerManager}} for advanced users, and the command should be
> executed with caution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164533#comment-16164533
]
Hadoop QA commented on HBASE-18131:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
25s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
23s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
0s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
20s{color} | {color:green} branch-1 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
24s{color} | {color:green} branch-1 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 16m
6s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
29s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 9m
37s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
52s{color} | {color:green} branch-1 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
24s{color} | {color:green} branch-1 passed with JDK v1.7.0_151 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
29s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
23s{color} | {color:green} hbase-protocol in the patch passed with JDK
v1.8.0_144. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
17s{color} | {color:green} hbase-client in the patch passed with JDK
v1.8.0_144. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
34s{color} | {color:green} hbase-server-jdk1.8.0_144 with JDK v1.8.0_144
generated 0 new + 5 unchanged - 5 fixed = 5 total (was 10) {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
15s{color} | {color:green} hbase-shell in the patch passed with JDK v1.8.0_144.
{color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
38s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
21s{color} | {color:green} hbase-protocol in the patch passed with JDK
v1.7.0_151. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
20s{color} | {color:green} hbase-client in the patch passed with JDK
v1.7.0_151. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
40s{color} | {color:green} hbase-server-jdk1.7.0_151 with JDK v1.7.0_151
generated 0 new + 5 unchanged - 5 fixed = 5 total (was 10) {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
17s{color} | {color:green} hbase-shell in the patch passed with JDK v1.7.0_151.
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 10m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m
12s{color} | {color:red} The patch generated 7 new + 827 unchanged - 1 fixed =
834 total (was 828) {color} |
| {color:red}-1{color} |
[jira] [Commented] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164028#comment-16164028
]
Hadoop QA commented on HBASE-18131:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
24s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
51s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
33s{color} | {color:green} branch-1 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
42s{color} | {color:green} branch-1 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 16m
17s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
28s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 9m
4s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
44s{color} | {color:green} branch-1 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
12s{color} | {color:green} branch-1 passed with JDK v1.7.0_151 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
19s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
19s{color} | {color:green} hbase-protocol in the patch passed with JDK
v1.8.0_144. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
15s{color} | {color:green} hbase-client in the patch passed with JDK
v1.8.0_144. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
32s{color} | {color:green} hbase-server-jdk1.8.0_144 with JDK v1.8.0_144
generated 0 new + 5 unchanged - 5 fixed = 5 total (was 10) {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
13s{color} | {color:green} hbase-shell in the patch passed with JDK v1.8.0_144.
{color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
31s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
21s{color} | {color:green} hbase-protocol in the patch passed with JDK
v1.7.0_151. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
18s{color} | {color:green} hbase-client in the patch passed with JDK
v1.7.0_151. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
37s{color} | {color:green} hbase-server-jdk1.7.0_151 with JDK v1.7.0_151
generated 0 new + 5 unchanged - 5 fixed = 5 total (was 10) {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
15s{color} | {color:green} hbase-shell in the patch passed with JDK v1.7.0_151.
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 9m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m
10s{color} | {color:red} The patch generated 7 new + 827 unchanged - 1 fixed =
834 total (was 828) {color} |
| {color:red}-1{color} |
[jira] [Commented] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163676#comment-16163676
]
Hudson commented on HBASE-18131:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3704 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/3704/])
HBASE-18131 Add an hbase shell command to clear deadserver list in (tedyu: rev
cfdbdd2066bf977c951b74b31c0e41dce152f9ef)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
* (edit) hbase-shell/src/main/ruby/shell.rb
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncHBaseAdmin.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/RequestConverter.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java
* (add) hbase-shell/src/main/ruby/shell/commands/list_deadservers.rb
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/DeadServer.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDeadServer.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
* (edit) hbase-protocol-shaded/src/main/protobuf/Master.proto
* (add) hbase-shell/src/main/ruby/shell/commands/clear_deadservers.rb
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ShortCircuitMasterConnection.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
* (edit) hbase-shell/src/main/ruby/hbase/admin.rb
> Add an hbase shell command to clear deadserver list in ServerManager
>
>
> Key: HBASE-18131
> URL: https://issues.apache.org/jira/browse/HBASE-18131
> Project: HBase
> Issue Type: New Feature
> Components: Operability
>Reporter: Yu Li
>Assignee: Guangxu Cheng
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-18131.branch-1.v1.patch,
> HBASE-18131.master.v1.patch, HBASE-18131.master.v2.patch,
> HBASE-18131.master.v3.patch, HBASE-18131.master.v4.patch,
> HBASE-18131.master.v5.patch, HBASE-18131.master.v6.patch,
> HBASE-18131.master.v6.patch, HBASE-18131.master.v7.patch, HBASE-18131.patch
>
>
> Currently if a regionserver is aborted due to fatal error or stopped by
> operator on purpose, it will be added into {{ServerManager#deadservers}} list
> and shown as "Dead Servers" in the master UI. This is a valid warn for
> operators to notice the self-aborted servers and give a sanity check to
> avoid further issues. However, after necessary checks, even if operator is
> sure that the node is decommissioned (such as for repair), there's no way to
> clear the dead server list except restarting master. See more details in
> [this
> discussion|http://mail-archives.apache.org/mod_mbox/hbase-user/201705.mbox/%3CCAM7-19%2BD4MLu2b1R94%2BtWQDspjfny2sCy4Qit8JtCgjvTOZzzg%40mail.gmail.com%3E]
> in mail list
> Here we propose to add a hbase shell command to allow clearing dead server
> list in {{ServerManager}} for advanced users, and the command should be
> executed with caution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163605#comment-16163605
]
Hudson commented on HBASE-18131:
FAILURE: Integrated in Jenkins build HBase-2.0 #503 (See
[https://builds.apache.org/job/HBase-2.0/503/])
HBASE-18131 Add an hbase shell command to clear deadserver list in (tedyu: rev
c75bb7424ef49777c927a0024e1f04f950a36c5c)
* (edit) hbase-shell/src/main/ruby/hbase/admin.rb
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/DeadServer.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java
* (edit) hbase-protocol-shaded/src/main/protobuf/Master.proto
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncHBaseAdmin.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/RequestConverter.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDeadServer.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java
* (edit) hbase-shell/src/main/ruby/shell.rb
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ShortCircuitMasterConnection.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java
* (add) hbase-shell/src/main/ruby/shell/commands/clear_deadservers.rb
* (add) hbase-shell/src/main/ruby/shell/commands/list_deadservers.rb
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
> Add an hbase shell command to clear deadserver list in ServerManager
>
>
> Key: HBASE-18131
> URL: https://issues.apache.org/jira/browse/HBASE-18131
> Project: HBase
> Issue Type: New Feature
> Components: Operability
>Reporter: Yu Li
>Assignee: Guangxu Cheng
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-18131.branch-1.v1.patch,
> HBASE-18131.master.v1.patch, HBASE-18131.master.v2.patch,
> HBASE-18131.master.v3.patch, HBASE-18131.master.v4.patch,
> HBASE-18131.master.v5.patch, HBASE-18131.master.v6.patch,
> HBASE-18131.master.v6.patch, HBASE-18131.master.v7.patch, HBASE-18131.patch
>
>
> Currently if a regionserver is aborted due to fatal error or stopped by
> operator on purpose, it will be added into {{ServerManager#deadservers}} list
> and shown as "Dead Servers" in the master UI. This is a valid warn for
> operators to notice the self-aborted servers and give a sanity check to
> avoid further issues. However, after necessary checks, even if operator is
> sure that the node is decommissioned (such as for repair), there's no way to
> clear the dead server list except restarting master. See more details in
> [this
> discussion|http://mail-archives.apache.org/mod_mbox/hbase-user/201705.mbox/%3CCAM7-19%2BD4MLu2b1R94%2BtWQDspjfny2sCy4Qit8JtCgjvTOZzzg%40mail.gmail.com%3E]
> in mail list
> Here we propose to add a hbase shell command to allow clearing dead server
> list in {{ServerManager}} for advanced users, and the command should be
> executed with caution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163208#comment-16163208
]
Ted Yu commented on HBASE-18131:
Patch doesn't apply to branch-1.
Please attach backported patch.
> Add an hbase shell command to clear deadserver list in ServerManager
>
>
> Key: HBASE-18131
> URL: https://issues.apache.org/jira/browse/HBASE-18131
> Project: HBase
> Issue Type: New Feature
> Components: Operability
>Reporter: Yu Li
>Assignee: Guangxu Cheng
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-18131.master.v1.patch,
> HBASE-18131.master.v2.patch, HBASE-18131.master.v3.patch,
> HBASE-18131.master.v4.patch, HBASE-18131.master.v5.patch,
> HBASE-18131.master.v6.patch, HBASE-18131.master.v6.patch,
> HBASE-18131.master.v7.patch, HBASE-18131.patch
>
>
> Currently if a regionserver is aborted due to fatal error or stopped by
> operator on purpose, it will be added into {{ServerManager#deadservers}} list
> and shown as "Dead Servers" in the master UI. This is a valid warn for
> operators to notice the self-aborted servers and give a sanity check to
> avoid further issues. However, after necessary checks, even if operator is
> sure that the node is decommissioned (such as for repair), there's no way to
> clear the dead server list except restarting master. See more details in
> [this
> discussion|http://mail-archives.apache.org/mod_mbox/hbase-user/201705.mbox/%3CCAM7-19%2BD4MLu2b1R94%2BtWQDspjfny2sCy4Qit8JtCgjvTOZzzg%40mail.gmail.com%3E]
> in mail list
> Here we propose to add a hbase shell command to allow clearing dead server
> list in {{ServerManager}} for advanced users, and the command should be
> executed with caution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163088#comment-16163088
]
Guangxu Cheng commented on HBASE-18131:
---
bq.Can you address rubocop and ruby-lint warnings which are related to your
patch ?
I also noticed these warnings. The new command format is the same as the other
commands. I did my best with these warnings.:(
> Add an hbase shell command to clear deadserver list in ServerManager
>
>
> Key: HBASE-18131
> URL: https://issues.apache.org/jira/browse/HBASE-18131
> Project: HBase
> Issue Type: New Feature
> Components: Operability
>Reporter: Yu Li
>Assignee: Guangxu Cheng
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-18131.master.v1.patch,
> HBASE-18131.master.v2.patch, HBASE-18131.master.v3.patch,
> HBASE-18131.master.v4.patch, HBASE-18131.master.v5.patch,
> HBASE-18131.master.v6.patch, HBASE-18131.master.v6.patch,
> HBASE-18131.master.v7.patch, HBASE-18131.patch
>
>
> Currently if a regionserver is aborted due to fatal error or stopped by
> operator on purpose, it will be added into {{ServerManager#deadservers}} list
> and shown as "Dead Servers" in the master UI. This is a valid warn for
> operators to notice the self-aborted servers and give a sanity check to
> avoid further issues. However, after necessary checks, even if operator is
> sure that the node is decommissioned (such as for repair), there's no way to
> clear the dead server list except restarting master. See more details in
> [this
> discussion|http://mail-archives.apache.org/mod_mbox/hbase-user/201705.mbox/%3CCAM7-19%2BD4MLu2b1R94%2BtWQDspjfny2sCy4Qit8JtCgjvTOZzzg%40mail.gmail.com%3E]
> in mail list
> Here we propose to add a hbase shell command to allow clearing dead server
> list in {{ServerManager}} for advanced users, and the command should be
> executed with caution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162801#comment-16162801
]
Ted Yu commented on HBASE-18131:
Can you address rubocop and ruby-lint warnings which are related to your patch ?
> Add an hbase shell command to clear deadserver list in ServerManager
>
>
> Key: HBASE-18131
> URL: https://issues.apache.org/jira/browse/HBASE-18131
> Project: HBase
> Issue Type: New Feature
> Components: Operability
>Reporter: Yu Li
>Assignee: Guangxu Cheng
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-18131.master.v1.patch,
> HBASE-18131.master.v2.patch, HBASE-18131.master.v3.patch,
> HBASE-18131.master.v4.patch, HBASE-18131.master.v5.patch,
> HBASE-18131.master.v6.patch, HBASE-18131.master.v6.patch,
> HBASE-18131.master.v7.patch, HBASE-18131.patch
>
>
> Currently if a regionserver is aborted due to fatal error or stopped by
> operator on purpose, it will be added into {{ServerManager#deadservers}} list
> and shown as "Dead Servers" in the master UI. This is a valid warn for
> operators to notice the self-aborted servers and give a sanity check to
> avoid further issues. However, after necessary checks, even if operator is
> sure that the node is decommissioned (such as for repair), there's no way to
> clear the dead server list except restarting master. See more details in
> [this
> discussion|http://mail-archives.apache.org/mod_mbox/hbase-user/201705.mbox/%3CCAM7-19%2BD4MLu2b1R94%2BtWQDspjfny2sCy4Qit8JtCgjvTOZzzg%40mail.gmail.com%3E]
> in mail list
> Here we propose to add a hbase shell command to allow clearing dead server
> list in {{ServerManager}} for advanced users, and the command should be
> executed with caution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161410#comment-16161410
]
Guangxu Cheng commented on HBASE-18131:
---
[~carp84] [~yuzhih...@gmail.com] Any other concerns? Thanks.
> Add an hbase shell command to clear deadserver list in ServerManager
>
>
> Key: HBASE-18131
> URL: https://issues.apache.org/jira/browse/HBASE-18131
> Project: HBase
> Issue Type: New Feature
> Components: Operability
>Reporter: Yu Li
>Assignee: Guangxu Cheng
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-18131.master.v1.patch,
> HBASE-18131.master.v2.patch, HBASE-18131.master.v3.patch,
> HBASE-18131.master.v4.patch, HBASE-18131.master.v5.patch,
> HBASE-18131.master.v6.patch, HBASE-18131.master.v6.patch,
> HBASE-18131.master.v7.patch, HBASE-18131.patch
>
>
> Currently if a regionserver is aborted due to fatal error or stopped by
> operator on purpose, it will be added into {{ServerManager#deadservers}} list
> and shown as "Dead Servers" in the master UI. This is a valid warn for
> operators to notice the self-aborted servers and give a sanity check to
> avoid further issues. However, after necessary checks, even if operator is
> sure that the node is decommissioned (such as for repair), there's no way to
> clear the dead server list except restarting master. See more details in
> [this
> discussion|http://mail-archives.apache.org/mod_mbox/hbase-user/201705.mbox/%3CCAM7-19%2BD4MLu2b1R94%2BtWQDspjfny2sCy4Qit8JtCgjvTOZzzg%40mail.gmail.com%3E]
> in mail list
> Here we propose to add a hbase shell command to allow clearing dead server
> list in {{ServerManager}} for advanced users, and the command should be
> executed with caution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161399#comment-16161399
]
Hadoop QA commented on HBASE-18131:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
18s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
1s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
4s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
21s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m
11s{color} | {color:red} The patch generated 7 new + 347 unchanged - 1 fixed =
354 total (was 348) {color} |
| {color:red}-1{color} | {color:red} ruby-lint {color} | {color:red} 0m
5s{color} | {color:red} The patch generated 14 new + 726 unchanged - 0 fixed =
740 total (was 726) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
8s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
38m 8s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
1m 21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
28s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
29s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 94m
53s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 6m
57s{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} |
[jira] [Commented] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161097#comment-16161097
]
Guangxu Cheng commented on HBASE-18131:
---
All tests pass locally. These failed tests are unrelated to this jira.
Retry again.
> Add an hbase shell command to clear deadserver list in ServerManager
>
>
> Key: HBASE-18131
> URL: https://issues.apache.org/jira/browse/HBASE-18131
> Project: HBase
> Issue Type: New Feature
> Components: Operability
>Reporter: Yu Li
>Assignee: Guangxu Cheng
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-18131.master.v1.patch,
> HBASE-18131.master.v2.patch, HBASE-18131.master.v3.patch,
> HBASE-18131.master.v4.patch, HBASE-18131.master.v5.patch,
> HBASE-18131.master.v6.patch, HBASE-18131.master.v6.patch, HBASE-18131.patch
>
>
> Currently if a regionserver is aborted due to fatal error or stopped by
> operator on purpose, it will be added into {{ServerManager#deadservers}} list
> and shown as "Dead Servers" in the master UI. This is a valid warn for
> operators to notice the self-aborted servers and give a sanity check to
> avoid further issues. However, after necessary checks, even if operator is
> sure that the node is decommissioned (such as for repair), there's no way to
> clear the dead server list except restarting master. See more details in
> [this
> discussion|http://mail-archives.apache.org/mod_mbox/hbase-user/201705.mbox/%3CCAM7-19%2BD4MLu2b1R94%2BtWQDspjfny2sCy4Qit8JtCgjvTOZzzg%40mail.gmail.com%3E]
> in mail list
> Here we propose to add a hbase shell command to allow clearing dead server
> list in {{ServerManager}} for advanced users, and the command should be
> executed with caution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161071#comment-16161071
]
Hadoop QA commented on HBASE-18131:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
22s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
19s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
13s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
20s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m
12s{color} | {color:red} The patch generated 7 new + 347 unchanged - 1 fixed =
354 total (was 348) {color} |
| {color:red}-1{color} | {color:red} ruby-lint {color} | {color:red} 0m
4s{color} | {color:red} The patch generated 14 new + 726 unchanged - 0 fixed =
740 total (was 726) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
14s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
41m 35s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
1m 31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
31s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
34s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 96m 54s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 6m
55s{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} |
[jira] [Commented] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160644#comment-16160644
]
Hadoop QA commented on HBASE-18131:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 8m
48s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
41s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
3s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
19s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
15s{color} | {color:red} hbase-client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
22s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
14s{color} | {color:red} hbase-client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
23s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} cc {color} | {color:red} 0m 14s{color} |
{color:red} hbase-client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} cc {color} | {color:red} 0m 23s{color} |
{color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 14s{color}
| {color:red} hbase-client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 23s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m
9s{color} | {color:red} The patch generated 7 new + 347 unchanged - 1 fixed =
354 total (was 348) {color} |
| {color:red}-1{color} | {color:red} ruby-lint {color} | {color:red} 0m
5s{color} | {color:red} The patch generated 14 new + 726 unchanged - 0 fixed =
740 total (was 726) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m
13s{color} | {color:red} The patch causes 28 errors with Hadoop v2.6.1. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m
12s{color} | {color:red} The patch causes 28 errors with Hadoop v2.6.2. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m
10s{color} | {color:red} The patch causes 28 errors with Hadoop v2.6.3. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m
9s{color} | {color:red} The patch causes 28 errors with Hadoop v2.6.4. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 5m
6s{color} | {color:red} The patch causes 28 errors with Hadoop v2.6.5. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 6m
6s{color} | {color:red} The patch causes 28 errors with Hadoop v2.7.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 7m
5s{color} | {color:red} The patch
[jira] [Commented] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155910#comment-16155910
]
Hadoop QA commented on HBASE-18131:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
35s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
9s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
22s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m
10s{color} | {color:red} The patch generated 8 new + 347 unchanged - 1 fixed =
355 total (was 348) {color} |
| {color:red}-1{color} | {color:red} ruby-lint {color} | {color:red} 0m
4s{color} | {color:red} The patch generated 14 new + 726 unchanged - 0 fixed =
740 total (was 726) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
35m 15s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
1m 23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
29s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
37s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 98m
13s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 7m 18s{color}
| {color:red} hbase-shell in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
56s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}173m 58s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.client.TestShell |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3
[jira] [Commented] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155615#comment-16155615
]
Guangxu Cheng commented on HBASE-18131:
---
v4 takes the suggestion from [~yuzhih...@gmail.com].pending QA
> Add an hbase shell command to clear deadserver list in ServerManager
>
>
> Key: HBASE-18131
> URL: https://issues.apache.org/jira/browse/HBASE-18131
> Project: HBase
> Issue Type: New Feature
> Components: Operability
>Reporter: Yu Li
>Assignee: Guangxu Cheng
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-18131.master.v1.patch,
> HBASE-18131.master.v2.patch, HBASE-18131.master.v3.patch,
> HBASE-18131.master.v4.patch, HBASE-18131.patch
>
>
> Currently if a regionserver is aborted due to fatal error or stopped by
> operator on purpose, it will be added into {{ServerManager#deadservers}} list
> and shown as "Dead Servers" in the master UI. This is a valid warn for
> operators to notice the self-aborted servers and give a sanity check to
> avoid further issues. However, after necessary checks, even if operator is
> sure that the node is decommissioned (such as for repair), there's no way to
> clear the dead server list except restarting master. See more details in
> [this
> discussion|http://mail-archives.apache.org/mod_mbox/hbase-user/201705.mbox/%3CCAM7-19%2BD4MLu2b1R94%2BtWQDspjfny2sCy4Qit8JtCgjvTOZzzg%40mail.gmail.com%3E]
> in mail list
> Here we propose to add a hbase shell command to allow clearing dead server
> list in {{ServerManager}} for advanced users, and the command should be
> executed with caution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155040#comment-16155040
]
Guangxu Cheng commented on HBASE-18131:
---
bq.Pending on resolving review comments from Ted, I guess there'll be a v3
patch Guangxu Cheng? Thanks.
yes, I'm preparing a new patch.Thanks
> Add an hbase shell command to clear deadserver list in ServerManager
>
>
> Key: HBASE-18131
> URL: https://issues.apache.org/jira/browse/HBASE-18131
> Project: HBase
> Issue Type: New Feature
> Components: Operability
>Reporter: Yu Li
>Assignee: Guangxu Cheng
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-18131.master.v1.patch,
> HBASE-18131.master.v2.patch, HBASE-18131.patch
>
>
> Currently if a regionserver is aborted due to fatal error or stopped by
> operator on purpose, it will be added into {{ServerManager#deadservers}} list
> and shown as "Dead Servers" in the master UI. This is a valid warn for
> operators to notice the self-aborted servers and give a sanity check to
> avoid further issues. However, after necessary checks, even if operator is
> sure that the node is decommissioned (such as for repair), there's no way to
> clear the dead server list except restarting master. See more details in
> [this
> discussion|http://mail-archives.apache.org/mod_mbox/hbase-user/201705.mbox/%3CCAM7-19%2BD4MLu2b1R94%2BtWQDspjfny2sCy4Qit8JtCgjvTOZzzg%40mail.gmail.com%3E]
> in mail list
> Here we propose to add a hbase shell command to allow clearing dead server
> list in {{ServerManager}} for advanced users, and the command should be
> executed with caution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154994#comment-16154994
]
Yu Li commented on HBASE-18131:
---
Pending on resolving review comments from Ted, I guess there'll be a v3 patch
[~andrewcheng]? Thanks.
> Add an hbase shell command to clear deadserver list in ServerManager
>
>
> Key: HBASE-18131
> URL: https://issues.apache.org/jira/browse/HBASE-18131
> Project: HBase
> Issue Type: New Feature
> Components: Operability
>Reporter: Yu Li
>Assignee: Guangxu Cheng
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-18131.master.v1.patch,
> HBASE-18131.master.v2.patch, HBASE-18131.patch
>
>
> Currently if a regionserver is aborted due to fatal error or stopped by
> operator on purpose, it will be added into {{ServerManager#deadservers}} list
> and shown as "Dead Servers" in the master UI. This is a valid warn for
> operators to notice the self-aborted servers and give a sanity check to
> avoid further issues. However, after necessary checks, even if operator is
> sure that the node is decommissioned (such as for repair), there's no way to
> clear the dead server list except restarting master. See more details in
> [this
> discussion|http://mail-archives.apache.org/mod_mbox/hbase-user/201705.mbox/%3CCAM7-19%2BD4MLu2b1R94%2BtWQDspjfny2sCy4Qit8JtCgjvTOZzzg%40mail.gmail.com%3E]
> in mail list
> Here we propose to add a hbase shell command to allow clearing dead server
> list in {{ServerManager}} for advanced users, and the command should be
> executed with caution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153410#comment-16153410
]
Guangxu Cheng commented on HBASE-18131:
---
Update patch as [~carp84] suggestions.thanks :)
> Add an hbase shell command to clear deadserver list in ServerManager
>
>
> Key: HBASE-18131
> URL: https://issues.apache.org/jira/browse/HBASE-18131
> Project: HBase
> Issue Type: New Feature
> Components: Operability
>Reporter: Yu Li
>Assignee: Guangxu Cheng
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-18131.master.v1.patch,
> HBASE-18131.master.v2.patch, HBASE-18131.patch
>
>
> Currently if a regionserver is aborted due to fatal error or stopped by
> operator on purpose, it will be added into {{ServerManager#deadservers}} list
> and shown as "Dead Servers" in the master UI. This is a valid warn for
> operators to notice the self-aborted servers and give a sanity check to
> avoid further issues. However, after necessary checks, even if operator is
> sure that the node is decommissioned (such as for repair), there's no way to
> clear the dead server list except restarting master. See more details in
> [this
> discussion|http://mail-archives.apache.org/mod_mbox/hbase-user/201705.mbox/%3CCAM7-19%2BD4MLu2b1R94%2BtWQDspjfny2sCy4Qit8JtCgjvTOZzzg%40mail.gmail.com%3E]
> in mail list
> Here we propose to add a hbase shell command to allow clearing dead server
> list in {{ServerManager}} for advanced users, and the command should be
> executed with caution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153198#comment-16153198
]
Guangxu Cheng commented on HBASE-18131:
---
bq.Mind upload the patch onto review board for better review?Guangxu Cheng
Thanks.
Reviewboard link:
https://reviews.apache.org/r/62059/
> Add an hbase shell command to clear deadserver list in ServerManager
>
>
> Key: HBASE-18131
> URL: https://issues.apache.org/jira/browse/HBASE-18131
> Project: HBase
> Issue Type: New Feature
> Components: Operability
>Reporter: Yu Li
>Assignee: Guangxu Cheng
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-18131.master.v1.patch, HBASE-18131.patch
>
>
> Currently if a regionserver is aborted due to fatal error or stopped by
> operator on purpose, it will be added into {{ServerManager#deadservers}} list
> and shown as "Dead Servers" in the master UI. This is a valid warn for
> operators to notice the self-aborted servers and give a sanity check to
> avoid further issues. However, after necessary checks, even if operator is
> sure that the node is decommissioned (such as for repair), there's no way to
> clear the dead server list except restarting master. See more details in
> [this
> discussion|http://mail-archives.apache.org/mod_mbox/hbase-user/201705.mbox/%3CCAM7-19%2BD4MLu2b1R94%2BtWQDspjfny2sCy4Qit8JtCgjvTOZzzg%40mail.gmail.com%3E]
> in mail list
> Here we propose to add a hbase shell command to allow clearing dead server
> list in {{ServerManager}} for advanced users, and the command should be
> executed with caution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153195#comment-16153195
]
Yu Li commented on HBASE-18131:
---
Mind upload the patch onto [review board|https://reviews.apache.org] for better
review?[~andrewcheng] Thanks.
> Add an hbase shell command to clear deadserver list in ServerManager
>
>
> Key: HBASE-18131
> URL: https://issues.apache.org/jira/browse/HBASE-18131
> Project: HBase
> Issue Type: New Feature
> Components: Operability
>Reporter: Yu Li
>Assignee: Guangxu Cheng
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-18131.master.v1.patch, HBASE-18131.patch
>
>
> Currently if a regionserver is aborted due to fatal error or stopped by
> operator on purpose, it will be added into {{ServerManager#deadservers}} list
> and shown as "Dead Servers" in the master UI. This is a valid warn for
> operators to notice the self-aborted servers and give a sanity check to
> avoid further issues. However, after necessary checks, even if operator is
> sure that the node is decommissioned (such as for repair), there's no way to
> clear the dead server list except restarting master. See more details in
> [this
> discussion|http://mail-archives.apache.org/mod_mbox/hbase-user/201705.mbox/%3CCAM7-19%2BD4MLu2b1R94%2BtWQDspjfny2sCy4Qit8JtCgjvTOZzzg%40mail.gmail.com%3E]
> in mail list
> Here we propose to add a hbase shell command to allow clearing dead server
> list in {{ServerManager}} for advanced users, and the command should be
> executed with caution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152456#comment-16152456
]
Guangxu Cheng commented on HBASE-18131:
---
Upload the first patch for review.Thanks [~carp84]
> Add an hbase shell command to clear deadserver list in ServerManager
>
>
> Key: HBASE-18131
> URL: https://issues.apache.org/jira/browse/HBASE-18131
> Project: HBase
> Issue Type: New Feature
> Components: Operability
>Reporter: Yu Li
>Assignee: Guangxu Cheng
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-18131.patch
>
>
> Currently if a regionserver is aborted due to fatal error or stopped by
> operator on purpose, it will be added into {{ServerManager#deadservers}} list
> and shown as "Dead Servers" in the master UI. This is a valid warn for
> operators to notice the self-aborted servers and give a sanity check to
> avoid further issues. However, after necessary checks, even if operator is
> sure that the node is decommissioned (such as for repair), there's no way to
> clear the dead server list except restarting master. See more details in
> [this
> discussion|http://mail-archives.apache.org/mod_mbox/hbase-user/201705.mbox/%3CCAM7-19%2BD4MLu2b1R94%2BtWQDspjfny2sCy4Qit8JtCgjvTOZzzg%40mail.gmail.com%3E]
> in mail list
> Here we propose to add a hbase shell command to allow clearing dead server
> list in {{ServerManager}} for advanced users, and the command should be
> executed with caution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146699#comment-16146699
]
Guangxu Cheng commented on HBASE-18131:
---
Hi [~carp84], Did you still work on this? If not, do you mind if I work on this
? I got a patch for this on the works.
> Add an hbase shell command to clear deadserver list in ServerManager
>
>
> Key: HBASE-18131
> URL: https://issues.apache.org/jira/browse/HBASE-18131
> Project: HBase
> Issue Type: New Feature
> Components: Operability
>Reporter: Yu Li
>Assignee: Yu Li
> Fix For: 2.0.0, 1.4.0
>
>
> Currently if a regionserver is aborted due to fatal error or stopped by
> operator on purpose, it will be added into {{ServerManager#deadservers}} list
> and shown as "Dead Servers" in the master UI. This is a valid warn for
> operators to notice the self-aborted servers and give a sanity check to
> avoid further issues. However, after necessary checks, even if operator is
> sure that the node is decommissioned (such as for repair), there's no way to
> clear the dead server list except restarting master. See more details in
> [this
> discussion|http://mail-archives.apache.org/mod_mbox/hbase-user/201705.mbox/%3CCAM7-19%2BD4MLu2b1R94%2BtWQDspjfny2sCy4Qit8JtCgjvTOZzzg%40mail.gmail.com%3E]
> in mail list
> Here we propose to add a hbase shell command to allow clearing dead server
> list in {{ServerManager}} for advanced users, and the command should be
> executed with caution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030535#comment-16030535
]
Yu Li commented on HBASE-18131:
---
bq. I think the root cause of this is not that servers are in the dead-servers
list indefinitely
Possibly, but the server will be left in dead-servers list (before master
restarts) if it's stopped (like for hardware repair) on purpose, right? So I
think the new command will still be a good tool in such scenario? Thanks.
> Add an hbase shell command to clear deadserver list in ServerManager
>
>
> Key: HBASE-18131
> URL: https://issues.apache.org/jira/browse/HBASE-18131
> Project: HBase
> Issue Type: New Feature
> Components: Operability
>Reporter: Yu Li
>Assignee: Yu Li
> Fix For: 2.0.0, 1.4.0
>
>
> Currently if a regionserver is aborted due to fatal error or stopped by
> operator on purpose, it will be added into {{ServerManager#deadservers}} list
> and shown as "Dead Servers" in the master UI. This is a valid warn for
> operators to notice the self-aborted servers and give a sanity check to
> avoid further issues. However, after necessary checks, even if operator is
> sure that the node is decommissioned (such as for repair), there's no way to
> clear the dead server list except restarting master. See more details in
> [this
> discussion|http://mail-archives.apache.org/mod_mbox/hbase-user/201705.mbox/%3CCAM7-19%2BD4MLu2b1R94%2BtWQDspjfny2sCy4Qit8JtCgjvTOZzzg%40mail.gmail.com%3E]
> in mail list
> Here we propose to add a hbase shell command to allow clearing dead server
> list in {{ServerManager}} for advanced users, and the command should be
> executed with caution.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029816#comment-16029816
]
Enis Soztutar commented on HBASE-18131:
---
I think the root cause of this is not that servers are in the dead-servers list
indefinitely. They will be removed from this list, however, due to HBASE-14223
the master thinks that the server is dead-but-not-processed even after restart.
> Add an hbase shell command to clear deadserver list in ServerManager
>
>
> Key: HBASE-18131
> URL: https://issues.apache.org/jira/browse/HBASE-18131
> Project: HBase
> Issue Type: New Feature
> Components: Operability
>Reporter: Yu Li
>Assignee: Yu Li
> Fix For: 2.0.0, 1.4.0
>
>
> Currently if a regionserver is aborted due to fatal error or stopped by
> operator on purpose, it will be added into {{ServerManager#deadservers}} list
> and shown as "Dead Servers" in the master UI. This is a valid warn for
> operators to notice the self-aborted servers and give a sanity check to
> avoid further issues. However, after necessary checks, even if operator is
> sure that the node is decommissioned (such as for repair), there's no way to
> clear the dead server list except restarting master. See more details in
> [this
> discussion|http://mail-archives.apache.org/mod_mbox/hbase-user/201705.mbox/%3CCAM7-19%2BD4MLu2b1R94%2BtWQDspjfny2sCy4Qit8JtCgjvTOZzzg%40mail.gmail.com%3E]
> in mail list
> Here we propose to add a hbase shell command to allow clearing dead server
> list in {{ServerManager}} for advanced users, and the command should be
> executed with caution.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
