[jira] [Commented] (HBASE-18411) Dividing FiterList into two separate sub-classes: FilterListWithOR , FilterListWithAND
[ https://issues.apache.org/jira/browse/HBASE-18411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219069#comment-16219069 ] Hudson commented on HBASE-18411: FAILURE: Integrated in Jenkins build HBase-2.0 #748 (See [https://builds.apache.org/job/HBase-2.0/748/]) HBASE-18411 Dividing FiterList into two separate sub-classes: (zhangduo: rev aa23cca58ae07f7e811e005d510be7619c658043) * (add) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterListBase.java * (add) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterListWithOR.java * (add) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterListWithAND.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterList.java > Dividing FiterList into two separate sub-classes: FilterListWithOR , > FilterListWithAND > > > Key: HBASE-18411 > URL: https://issues.apache.org/jira/browse/HBASE-18411 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu > Fix For: HBASE-18410 > > Attachments: HBASE-18411-HBASE-18410.v3.patch, > HBASE-18411-HBASE-18410.v3.patch, HBASE-18411.v1.patch, HBASE-18411.v1.patch, > HBASE-18411.v2.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18411) Dividing FiterList into two separate sub-classes: FilterListWithOR , FilterListWithAND
[ https://issues.apache.org/jira/browse/HBASE-18411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201388#comment-16201388 ] Sean Busbey commented on HBASE-18411: - There's a version in jira for the feature branch, named HBASE-18410. When we merge the branch we can update all the jiras that have that fixVersion to point at the right places. > Dividing FiterList into two separate sub-classes: FilterListWithOR , > FilterListWithAND > > > Key: HBASE-18411 > URL: https://issues.apache.org/jira/browse/HBASE-18411 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu > Fix For: HBASE-18410 > > Attachments: HBASE-18411-HBASE-18410.v3.patch, > HBASE-18411-HBASE-18410.v3.patch, HBASE-18411.v1.patch, HBASE-18411.v1.patch, > HBASE-18411.v2.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18411) Dividing FiterList into two separate sub-classes: FilterListWithOR , FilterListWithAND
[ https://issues.apache.org/jira/browse/HBASE-18411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201331#comment-16201331 ] Zheng Hu commented on HBASE-18411: -- Thanks [~psomogyi], Ping [~busbey], [~Apache9] > Dividing FiterList into two separate sub-classes: FilterListWithOR , > FilterListWithAND > > > Key: HBASE-18411 > URL: https://issues.apache.org/jira/browse/HBASE-18411 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu > Attachments: HBASE-18411-HBASE-18410.v3.patch, > HBASE-18411-HBASE-18410.v3.patch, HBASE-18411.v1.patch, HBASE-18411.v1.patch, > HBASE-18411.v2.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18411) Dividing FiterList into two separate sub-classes: FilterListWithOR , FilterListWithAND
[ https://issues.apache.org/jira/browse/HBASE-18411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201175#comment-16201175 ] Peter Somogyi commented on HBASE-18411: --- Nothing from my side, I think it can be merged. > Dividing FiterList into two separate sub-classes: FilterListWithOR , > FilterListWithAND > > > Key: HBASE-18411 > URL: https://issues.apache.org/jira/browse/HBASE-18411 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu > Attachments: HBASE-18411-HBASE-18410.v3.patch, > HBASE-18411-HBASE-18410.v3.patch, HBASE-18411.v1.patch, HBASE-18411.v1.patch, > HBASE-18411.v2.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18411) Dividing FiterList into two separate sub-classes: FilterListWithOR , FilterListWithAND
[ https://issues.apache.org/jira/browse/HBASE-18411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200306#comment-16200306 ] Zheng Hu commented on HBASE-18411: -- So , any concerns about the HBASE-18411-HBASE-18410.v3.patch ? If no, could you help to commit to branch HBASE-18410 ? [~busbey], [~Apache9] After that , I'll upload patch for HBASE-18879 :-) > Dividing FiterList into two separate sub-classes: FilterListWithOR , > FilterListWithAND > > > Key: HBASE-18411 > URL: https://issues.apache.org/jira/browse/HBASE-18411 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu > Attachments: HBASE-18411-HBASE-18410.v3.patch, > HBASE-18411-HBASE-18410.v3.patch, HBASE-18411.v1.patch, HBASE-18411.v1.patch, > HBASE-18411.v2.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18411) Dividing FiterList into two separate sub-classes: FilterListWithOR , FilterListWithAND
[ https://issues.apache.org/jira/browse/HBASE-18411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200203#comment-16200203 ] Sean Busbey commented on HBASE-18411: - yes, I'd like this to be done on the feature branch. > Dividing FiterList into two separate sub-classes: FilterListWithOR , > FilterListWithAND > > > Key: HBASE-18411 > URL: https://issues.apache.org/jira/browse/HBASE-18411 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu > Attachments: HBASE-18411-HBASE-18410.v3.patch, > HBASE-18411-HBASE-18410.v3.patch, HBASE-18411.v1.patch, HBASE-18411.v1.patch, > HBASE-18411.v2.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18411) Dividing FiterList into two separate sub-classes: FilterListWithOR , FilterListWithAND
[
https://issues.apache.org/jira/browse/HBASE-18411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199835#comment-16199835
]
Hadoop QA commented on HBASE-18411:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
46s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
39s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
52s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
37s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
27s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
8s{color} | {color:green} HBASE-18410 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
49s{color} | {color:green} HBASE-18410 passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
19s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
55s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
36m 23s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
37s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 90m
49s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
28s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}156m 22s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18411 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12891413/HBASE-18411-HBASE-18410.v3.patch
|
| Optional Tests | asflicense shadedjars javac javadoc unit findbugs
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 9b75b5c9407e 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | HBASE-18410 /
[jira] [Commented] (HBASE-18411) Dividing FiterList into two separate sub-classes: FilterListWithOR , FilterListWithAND
[ https://issues.apache.org/jira/browse/HBASE-18411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199737#comment-16199737 ] Zheng Hu commented on HBASE-18411: -- bq. So this will go into HBASE-18410 first? Yes, I think so. See comments under HBASE-18410. > Dividing FiterList into two separate sub-classes: FilterListWithOR , > FilterListWithAND > > > Key: HBASE-18411 > URL: https://issues.apache.org/jira/browse/HBASE-18411 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu > Attachments: HBASE-18411-HBASE-18410.v3.patch, HBASE-18411.v1.patch, > HBASE-18411.v1.patch, HBASE-18411.v2.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18411) Dividing FiterList into two separate sub-classes: FilterListWithOR , FilterListWithAND
[ https://issues.apache.org/jira/browse/HBASE-18411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199703#comment-16199703 ] Duo Zhang commented on HBASE-18411: --- So this will go into HBASE-18410 first? [~psomogyi] [~busbey] > Dividing FiterList into two separate sub-classes: FilterListWithOR , > FilterListWithAND > > > Key: HBASE-18411 > URL: https://issues.apache.org/jira/browse/HBASE-18411 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu > Attachments: HBASE-18411-HBASE-18410.v3.patch, HBASE-18411.v1.patch, > HBASE-18411.v1.patch, HBASE-18411.v2.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18411) Dividing FiterList into two separate sub-classes: FilterListWithOR , FilterListWithAND
[
https://issues.apache.org/jira/browse/HBASE-18411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181077#comment-16181077
]
Hadoop QA commented on HBASE-18411:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
34s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
42s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m
44s{color} | {color:red} hbase-server in master has 1 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
48s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
21s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
15s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
39m 45s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
5s{color} | {color:red} hbase-client generated 1 new + 0 unchanged - 0 fixed =
1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
35s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 92m
32s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
31s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}160m 58s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-client |
| | org.apache.hadoop.hbase.filter.FilterListBase.compareCell(Cell, Cell)
negates the return value of
org.apache.hadoop.hbase.CellComparator.compare(Cell, Cell) At
FilterListBase.java:value of
org.apache.hadoop.hbase.CellComparator.compare(Cell, Cell) At
FilterListBase.java:[line 86] |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18411 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12889076/HBASE-18411.v2.patch |
| Optional Tests | asflicense
[jira] [Commented] (HBASE-18411) Dividing FiterList into two separate sub-classes: FilterListWithOR , FilterListWithAND
[
https://issues.apache.org/jira/browse/HBASE-18411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180542#comment-16180542
]
Hadoop QA commented on HBASE-18411:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
40s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
28s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
54s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
39m 20s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
43s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 55m 50s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18411 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12888985/HBASE-18411.v1.patch |
| Optional Tests | asflicense shadedjars javac javadoc unit findbugs
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 1abfef6ab1b0 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 410368b |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8790/testReport/ |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8790/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message
[jira] [Commented] (HBASE-18411) Dividing FiterList into two separate sub-classes: FilterListWithOR , FilterListWithAND
[ https://issues.apache.org/jira/browse/HBASE-18411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180193#comment-16180193 ] Duo Zhang commented on HBASE-18411: --- I've already pushed HBASE-18160 to master and branch-2. You can upload the patch now [~openinx]. > Dividing FiterList into two separate sub-classes: FilterListWithOR , > FilterListWithAND > > > Key: HBASE-18411 > URL: https://issues.apache.org/jira/browse/HBASE-18411 > Project: HBase > Issue Type: Sub-task >Reporter: Zheng Hu >Assignee: Peter Somogyi > Attachments: HBASE-18411.v1.patch, HBASE-18411.v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18411) Dividing FiterList into two separate sub-classes: FilterListWithOR , FilterListWithAND
[ https://issues.apache.org/jira/browse/HBASE-18411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180079#comment-16180079 ] Zheng Hu commented on HBASE-18411: -- bq. could you upload the patch to reviewboard? [~psomogyi], HBASE-18411 is dependent on HBASE-18160, and HBASE-18160 haven't been committed into git rep yet. so uploading the HBASE-18411.v1.patch to RB will be failed. I upload it for the initial version, after with HBASE-18411 resolved, I'll put the patch to review board :-) > Dividing FiterList into two separate sub-classes: FilterListWithOR , > FilterListWithAND > > > Key: HBASE-18411 > URL: https://issues.apache.org/jira/browse/HBASE-18411 > Project: HBase > Issue Type: Sub-task >Reporter: Zheng Hu >Assignee: Peter Somogyi > Attachments: HBASE-18411.v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18411) Dividing FiterList into two separate sub-classes: FilterListWithOR , FilterListWithAND
[ https://issues.apache.org/jira/browse/HBASE-18411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179394#comment-16179394 ] Peter Somogyi commented on HBASE-18411: --- [~openinx], could you upload the patch to reviewboard? > Dividing FiterList into two separate sub-classes: FilterListWithOR , > FilterListWithAND > > > Key: HBASE-18411 > URL: https://issues.apache.org/jira/browse/HBASE-18411 > Project: HBase > Issue Type: Sub-task >Reporter: Zheng Hu >Assignee: Peter Somogyi > Attachments: HBASE-18411.v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18411) Dividing FiterList into two separate sub-classes: FilterListWithOR , FilterListWithAND
[ https://issues.apache.org/jira/browse/HBASE-18411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166121#comment-16166121 ] Zheng Hu commented on HBASE-18411: -- bq. it is better to have the class a bit more complicated than moving to a more difficult to use API. Agree. I think we can define two internal classes: FilterListWithOr & FilterListWithAnd, which is only used to implement the FilterList logic , and they need not to be exposed to user. bq. Since it looks like you have some good idea how to modify this class I give back to you this issue. I'm OK. > Dividing FiterList into two separate sub-classes: FilterListWithOR , > FilterListWithAND > > > Key: HBASE-18411 > URL: https://issues.apache.org/jira/browse/HBASE-18411 > Project: HBase > Issue Type: Sub-task >Reporter: Zheng Hu >Assignee: Peter Somogyi > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18411) Dividing FiterList into two separate sub-classes: FilterListWithOR , FilterListWithAND
[ https://issues.apache.org/jira/browse/HBASE-18411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166110#comment-16166110 ] Peter Somogyi commented on HBASE-18411: --- Thanks for the info [~openinx]! I agree that FilterList is a bit complex due to the combination of OR and AND, but my personal opinion is that maybe it is better to have the class a bit more complicated than moving to a more difficult to use API. Since it looks like you have some good idea how to modify this class I give back to you this issue. :) > Dividing FiterList into two separate sub-classes: FilterListWithOR , > FilterListWithAND > > > Key: HBASE-18411 > URL: https://issues.apache.org/jira/browse/HBASE-18411 > Project: HBase > Issue Type: Sub-task >Reporter: Zheng Hu >Assignee: Peter Somogyi > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18411) Dividing FiterList into two separate sub-classes: FilterListWithOR , FilterListWithAND
[ https://issues.apache.org/jira/browse/HBASE-18411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165692#comment-16165692 ] Zheng Hu commented on HBASE-18411: -- Besides , for this issue, the main point is keeping interface to be compatible with previous release .:-) > Dividing FiterList into two separate sub-classes: FilterListWithOR , > FilterListWithAND > > > Key: HBASE-18411 > URL: https://issues.apache.org/jira/browse/HBASE-18411 > Project: HBase > Issue Type: Sub-task >Reporter: Zheng Hu >Assignee: Peter Somogyi > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18411) Dividing FiterList into two separate sub-classes: FilterListWithOR , FilterListWithAND
[ https://issues.apache.org/jira/browse/HBASE-18411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165682#comment-16165682 ] Zheng Hu commented on HBASE-18411: -- Hi [~psomogyi] , after HBASE-18160, sub-tasks HBASE-18414 & HBASE-18416 will be resolved automatically. And I think you can start the work after HBASE-18160 finished :-) > Dividing FiterList into two separate sub-classes: FilterListWithOR , > FilterListWithAND > > > Key: HBASE-18411 > URL: https://issues.apache.org/jira/browse/HBASE-18411 > Project: HBase > Issue Type: Sub-task >Reporter: Zheng Hu >Assignee: Peter Somogyi > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
