[jira] [Commented] (HBASE-18482) Enable state to be passed between the batch mutate coprocessors
[ https://issues.apache.org/jira/browse/HBASE-18482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106984#comment-16106984 ] Anoop Sam John commented on HBASE-18482: This duplicates HBASE-18127 ? > Enable state to be passed between the batch mutate coprocessors > --- > > Key: HBASE-18482 > URL: https://issues.apache.org/jira/browse/HBASE-18482 > Project: HBase > Issue Type: Improvement >Reporter: James Taylor > > For secondary indexing, Phoenix leverages the coprocessors that fire during > the processing of a batch mutate: preBatchMutate, postBatchMutate, and > postBatchMutateIndispensably. It would be very helpful if we had a way of > passing state between these calls. One solution would be to provide a member > variable in the MiniBatchOperationInProgress class that gets passed from > invocation to invocation. Within doMiniBatchMutation, the instantiation of > the MiniBatchOperationInProgress would simply set this context member > variable based on the value from the previous MiniBatchOperationInProgress > instantiation. Another solution would be to allow the a context object to be > set on the ObserverContext which would then be available to the other calls. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18482) Enable state to be passed between the batch mutate coprocessors
[
https://issues.apache.org/jira/browse/HBASE-18482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106678#comment-16106678
]
Andrew Purtell commented on HBASE-18482:
On HBASE-18127 [~abhishek.chouhan] is already pursuing something along these
lines. His preliminary patch introduces {{OperationCoprocessorContext}} which
is passed among all the coprocessor hooks which might be invoked during the
processing of a batch mutation op.
> Enable state to be passed between the batch mutate coprocessors
> ---
>
> Key: HBASE-18482
> URL: https://issues.apache.org/jira/browse/HBASE-18482
> Project: HBase
> Issue Type: Improvement
>Reporter: James Taylor
>
> For secondary indexing, Phoenix leverages the coprocessors that fire during
> the processing of a batch mutate: preBatchMutate, postBatchMutate, and
> postBatchMutateIndispensably. It would be very helpful if we had a way of
> passing state between these calls. One solution would be to provide a member
> variable in the MiniBatchOperationInProgress class that gets passed from
> invocation to invocation. Within doMiniBatchMutation, the instantiation of
> the MiniBatchOperationInProgress would simply set this context member
> variable based on the value from the previous MiniBatchOperationInProgress
> instantiation. Another solution would be to allow the a context object to be
> set on the ObserverContext which would then be available to the other calls.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18482) Enable state to be passed between the batch mutate coprocessors
[ https://issues.apache.org/jira/browse/HBASE-18482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106636#comment-16106636 ] James Taylor commented on HBASE-18482: -- Any memory allocated would go out of scope when doMiniBatchMutation is completed. It really be no different than other memory allocation done within the coprocessor hook calls. In general, you always have to be aware of allocated huge amounts of memory. > Enable state to be passed between the batch mutate coprocessors > --- > > Key: HBASE-18482 > URL: https://issues.apache.org/jira/browse/HBASE-18482 > Project: HBase > Issue Type: Improvement >Reporter: James Taylor > > For secondary indexing, Phoenix leverages the coprocessors that fire during > the processing of a batch mutate: preBatchMutate, postBatchMutate, and > postBatchMutateIndispensably. It would be very helpful if we had a way of > passing state between these calls. One solution would be to provide a member > variable in the MiniBatchOperationInProgress class that gets passed from > invocation to invocation. Within doMiniBatchMutation, the instantiation of > the MiniBatchOperationInProgress would simply set this context member > variable based on the value from the previous MiniBatchOperationInProgress > instantiation. Another solution would be to allow the a context object to be > set on the ObserverContext which would then be available to the other calls. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18482) Enable state to be passed between the batch mutate coprocessors
[ https://issues.apache.org/jira/browse/HBASE-18482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106624#comment-16106624 ] Ted Yu commented on HBASE-18482: For #1, what if the member variable happens to have large memory footprint ? > Enable state to be passed between the batch mutate coprocessors > --- > > Key: HBASE-18482 > URL: https://issues.apache.org/jira/browse/HBASE-18482 > Project: HBase > Issue Type: Improvement >Reporter: James Taylor > > For secondary indexing, Phoenix leverages the coprocessors that fire during > the processing of a batch mutate: preBatchMutate, postBatchMutate, and > postBatchMutateIndispensably. It would be very helpful if we had a way of > passing state between these calls. One solution would be to provide a member > variable in the MiniBatchOperationInProgress class that gets passed from > invocation to invocation. Within doMiniBatchMutation, the instantiation of > the MiniBatchOperationInProgress would simply set this context member > variable based on the value from the previous MiniBatchOperationInProgress > instantiation. Another solution would be to allow the a context object to be > set on the ObserverContext which would then be available to the other calls. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
