[jira] [Commented] (HBASE-18487) Minor fixes in row lock implementation
[ https://issues.apache.org/jira/browse/HBASE-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131090#comment-16131090 ] Hudson commented on HBASE-18487: FAILURE: Integrated in Jenkins build HBASE-14070.HLC #233 (See [https://builds.apache.org/job/HBASE-14070.HLC/233/]) HBASE-18487 Minor fixes in row lock implementation (apurtell: rev 422a57223a9a3cccfdc6db7c9f43ca083e6f3037) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > Minor fixes in row lock implementation > -- > > Key: HBASE-18487 > URL: https://issues.apache.org/jira/browse/HBASE-18487 > Project: HBase > Issue Type: Bug >Reporter: James Taylor >Assignee: James Taylor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18487_branch-1.patch, HBASE-18487.patch > > > In reviewing the HRegion.getRowLockInternal() implementation, I noticed a > couple of possible issues that I wanted to pass along: > - make sure rowLockContext.cleanUp() always called if row lock could not be > acquired > - do not attempt to remove unusable row lock from map multiple times. > I'll post a patch for consideration. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18487) Minor fixes in row lock implementation
[ https://issues.apache.org/jira/browse/HBASE-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110034#comment-16110034 ] Hudson commented on HBASE-18487: FAILURE: Integrated in Jenkins build HBase-2.0 #275 (See [https://builds.apache.org/job/HBase-2.0/275/]) HBASE-18487 Minor fixes in row lock implementation (apurtell: rev f67dae90f952e84681a07a612b8005a2d688cae5) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > Minor fixes in row lock implementation > -- > > Key: HBASE-18487 > URL: https://issues.apache.org/jira/browse/HBASE-18487 > Project: HBase > Issue Type: Bug >Reporter: James Taylor >Assignee: James Taylor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18487_branch-1.patch, HBASE-18487.patch > > > In reviewing the HRegion.getRowLockInternal() implementation, I noticed a > couple of possible issues that I wanted to pass along: > - make sure rowLockContext.cleanUp() always called if row lock could not be > acquired > - do not attempt to remove unusable row lock from map multiple times. > I'll post a patch for consideration. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18487) Minor fixes in row lock implementation
[ https://issues.apache.org/jira/browse/HBASE-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110027#comment-16110027 ] Hudson commented on HBASE-18487: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3476 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3476/]) HBASE-18487 Minor fixes in row lock implementation (apurtell: rev 422a57223a9a3cccfdc6db7c9f43ca083e6f3037) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > Minor fixes in row lock implementation > -- > > Key: HBASE-18487 > URL: https://issues.apache.org/jira/browse/HBASE-18487 > Project: HBase > Issue Type: Bug >Reporter: James Taylor >Assignee: James Taylor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18487_branch-1.patch, HBASE-18487.patch > > > In reviewing the HRegion.getRowLockInternal() implementation, I noticed a > couple of possible issues that I wanted to pass along: > - make sure rowLockContext.cleanUp() always called if row lock could not be > acquired > - do not attempt to remove unusable row lock from map multiple times. > I'll post a patch for consideration. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18487) Minor fixes in row lock implementation
[ https://issues.apache.org/jira/browse/HBASE-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109967#comment-16109967 ] Hudson commented on HBASE-18487: SUCCESS: Integrated in Jenkins build HBase-1.3-JDK8 #229 (See [https://builds.apache.org/job/HBase-1.3-JDK8/229/]) HBASE-18487 Minor fixes in row lock implementation (apurtell: rev 84368110268ba0d2e75ce5acff2704eef615e3c6) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > Minor fixes in row lock implementation > -- > > Key: HBASE-18487 > URL: https://issues.apache.org/jira/browse/HBASE-18487 > Project: HBase > Issue Type: Bug >Reporter: James Taylor >Assignee: James Taylor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18487_branch-1.patch, HBASE-18487.patch > > > In reviewing the HRegion.getRowLockInternal() implementation, I noticed a > couple of possible issues that I wanted to pass along: > - make sure rowLockContext.cleanUp() always called if row lock could not be > acquired > - do not attempt to remove unusable row lock from map multiple times. > I'll post a patch for consideration. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18487) Minor fixes in row lock implementation
[ https://issues.apache.org/jira/browse/HBASE-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109895#comment-16109895 ] Hudson commented on HBASE-18487: SUCCESS: Integrated in Jenkins build HBase-1.2-JDK8 #174 (See [https://builds.apache.org/job/HBase-1.2-JDK8/174/]) HBASE-18487 Minor fixes in row lock implementation (apurtell: rev 6cadd1def796656efbcb3ca10befe5d323b53f1a) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > Minor fixes in row lock implementation > -- > > Key: HBASE-18487 > URL: https://issues.apache.org/jira/browse/HBASE-18487 > Project: HBase > Issue Type: Bug >Reporter: James Taylor >Assignee: James Taylor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18487_branch-1.patch, HBASE-18487.patch > > > In reviewing the HRegion.getRowLockInternal() implementation, I noticed a > couple of possible issues that I wanted to pass along: > - make sure rowLockContext.cleanUp() always called if row lock could not be > acquired > - do not attempt to remove unusable row lock from map multiple times. > I'll post a patch for consideration. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18487) Minor fixes in row lock implementation
[ https://issues.apache.org/jira/browse/HBASE-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109865#comment-16109865 ] Hudson commented on HBASE-18487: FAILURE: Integrated in Jenkins build HBase-1.4 #830 (See [https://builds.apache.org/job/HBase-1.4/830/]) HBASE-18487 Minor fixes in row lock implementation (apurtell: rev 80b85a857c87c66d45275e5716d02186918e9b5d) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > Minor fixes in row lock implementation > -- > > Key: HBASE-18487 > URL: https://issues.apache.org/jira/browse/HBASE-18487 > Project: HBase > Issue Type: Bug >Reporter: James Taylor >Assignee: James Taylor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18487_branch-1.patch, HBASE-18487.patch > > > In reviewing the HRegion.getRowLockInternal() implementation, I noticed a > couple of possible issues that I wanted to pass along: > - make sure rowLockContext.cleanUp() always called if row lock could not be > acquired > - do not attempt to remove unusable row lock from map multiple times. > I'll post a patch for consideration. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18487) Minor fixes in row lock implementation
[ https://issues.apache.org/jira/browse/HBASE-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109673#comment-16109673 ] Hudson commented on HBASE-18487: SUCCESS: Integrated in Jenkins build HBase-1.2-IT #913 (See [https://builds.apache.org/job/HBase-1.2-IT/913/]) HBASE-18487 Minor fixes in row lock implementation (apurtell: rev 6cadd1def796656efbcb3ca10befe5d323b53f1a) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > Minor fixes in row lock implementation > -- > > Key: HBASE-18487 > URL: https://issues.apache.org/jira/browse/HBASE-18487 > Project: HBase > Issue Type: Bug >Reporter: James Taylor >Assignee: James Taylor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18487_branch-1.patch, HBASE-18487.patch > > > In reviewing the HRegion.getRowLockInternal() implementation, I noticed a > couple of possible issues that I wanted to pass along: > - make sure rowLockContext.cleanUp() always called if row lock could not be > acquired > - do not attempt to remove unusable row lock from map multiple times. > I'll post a patch for consideration. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18487) Minor fixes in row lock implementation
[ https://issues.apache.org/jira/browse/HBASE-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109654#comment-16109654 ] Hudson commented on HBASE-18487: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #152 (See [https://builds.apache.org/job/HBase-1.3-IT/152/]) HBASE-18487 Minor fixes in row lock implementation (apurtell: rev 84368110268ba0d2e75ce5acff2704eef615e3c6) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > Minor fixes in row lock implementation > -- > > Key: HBASE-18487 > URL: https://issues.apache.org/jira/browse/HBASE-18487 > Project: HBase > Issue Type: Bug >Reporter: James Taylor >Assignee: James Taylor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18487_branch-1.patch, HBASE-18487.patch > > > In reviewing the HRegion.getRowLockInternal() implementation, I noticed a > couple of possible issues that I wanted to pass along: > - make sure rowLockContext.cleanUp() always called if row lock could not be > acquired > - do not attempt to remove unusable row lock from map multiple times. > I'll post a patch for consideration. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18487) Minor fixes in row lock implementation
[ https://issues.apache.org/jira/browse/HBASE-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109646#comment-16109646 ] Hudson commented on HBASE-18487: FAILURE: Integrated in Jenkins build HBase-1.2-JDK7 #179 (See [https://builds.apache.org/job/HBase-1.2-JDK7/179/]) HBASE-18487 Minor fixes in row lock implementation (apurtell: rev 6cadd1def796656efbcb3ca10befe5d323b53f1a) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > Minor fixes in row lock implementation > -- > > Key: HBASE-18487 > URL: https://issues.apache.org/jira/browse/HBASE-18487 > Project: HBase > Issue Type: Bug >Reporter: James Taylor >Assignee: James Taylor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18487_branch-1.patch, HBASE-18487.patch > > > In reviewing the HRegion.getRowLockInternal() implementation, I noticed a > couple of possible issues that I wanted to pass along: > - make sure rowLockContext.cleanUp() always called if row lock could not be > acquired > - do not attempt to remove unusable row lock from map multiple times. > I'll post a patch for consideration. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18487) Minor fixes in row lock implementation
[ https://issues.apache.org/jira/browse/HBASE-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109639#comment-16109639 ] Hudson commented on HBASE-18487: FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #214 (See [https://builds.apache.org/job/HBase-1.3-JDK7/214/]) HBASE-18487 Minor fixes in row lock implementation (apurtell: rev 84368110268ba0d2e75ce5acff2704eef615e3c6) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > Minor fixes in row lock implementation > -- > > Key: HBASE-18487 > URL: https://issues.apache.org/jira/browse/HBASE-18487 > Project: HBase > Issue Type: Bug >Reporter: James Taylor >Assignee: James Taylor > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18487_branch-1.patch, HBASE-18487.patch > > > In reviewing the HRegion.getRowLockInternal() implementation, I noticed a > couple of possible issues that I wanted to pass along: > - make sure rowLockContext.cleanUp() always called if row lock could not be > acquired > - do not attempt to remove unusable row lock from map multiple times. > I'll post a patch for consideration. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18487) Minor fixes in row lock implementation
[ https://issues.apache.org/jira/browse/HBASE-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109450#comment-16109450 ] Andrew Purtell commented on HBASE-18487: Thanks for the patch [~jamestaylor] and the review Ted. Committing shortly. > Minor fixes in row lock implementation > -- > > Key: HBASE-18487 > URL: https://issues.apache.org/jira/browse/HBASE-18487 > Project: HBase > Issue Type: Bug >Reporter: James Taylor >Assignee: James Taylor > Attachments: HBASE-18487_branch-1.patch, HBASE-18487.patch > > > In reviewing the HRegion.getRowLockInternal() implementation, I noticed a > couple of possible issues that I wanted to pass along: > - make sure rowLockContext.cleanUp() always called if row lock could not be > acquired > - do not attempt to remove unusable row lock from map multiple times. > I'll post a patch for consideration. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18487) Minor fixes in row lock implementation
[ https://issues.apache.org/jira/browse/HBASE-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109141#comment-16109141 ] Ted Yu commented on HBASE-18487: +1 > Minor fixes in row lock implementation > -- > > Key: HBASE-18487 > URL: https://issues.apache.org/jira/browse/HBASE-18487 > Project: HBase > Issue Type: Bug >Reporter: James Taylor > Attachments: HBASE-18487_branch-1.patch, HBASE-18487.patch > > > In reviewing the HRegion.getRowLockInternal() implementation, I noticed a > couple of possible issues that I wanted to pass along: > - make sure rowLockContext.cleanUp() always called if row lock could not be > acquired > - do not attempt to remove unusable row lock from map multiple times. > I'll post a patch for consideration. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18487) Minor fixes in row lock implementation
[
https://issues.apache.org/jira/browse/HBASE-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108062#comment-16108062
]
Hadoop QA commented on HBASE-18487:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
27m 23s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}108m
51s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}153m 51s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18487 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12879685/HBASE-18487.patch |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 1cc0ad641975 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 331a6cf |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/7853/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/7853/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Minor fixes in row lock implementation
> --
>
> Key: HBASE-18487
> URL: https://issues.apache.org/jira/browse/HBASE-18487
> Project: HBase
> Issue Type: Bug
>Reporter: James Taylor
> Attachments: HBASE-18487_branch-1.patch, HBASE-18487.patch
>
>
[jira] [Commented] (HBASE-18487) Minor fixes in row lock implementation
[ https://issues.apache.org/jira/browse/HBASE-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107773#comment-16107773 ] Ted Yu commented on HBASE-18487: lgtm Do posting patch for master branch ? > Minor fixes in row lock implementation > -- > > Key: HBASE-18487 > URL: https://issues.apache.org/jira/browse/HBASE-18487 > Project: HBase > Issue Type: Bug >Reporter: James Taylor > Attachments: HBASE-18487_branch-1.patch > > > In reviewing the HRegion.getRowLockInternal() implementation, I noticed a > couple of possible issues that I wanted to pass along: > - make sure rowLockContext.cleanUp() always called if row lock could not be > acquired > - do not attempt to remove unusable row lock from map multiple times. > I'll post a patch for consideration. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
