[jira] [Commented] (HBASE-18509) [HLC] Finishing cleanups
[
https://issues.apache.org/jira/browse/HBASE-18509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139372#comment-16139372
]
Hudson commented on HBASE-18509:
FAILURE: Integrated in Jenkins build HBASE-14070.HLC #270 (See
[https://builds.apache.org/job/HBASE-14070.HLC/270/])
HBASE-18509 (ADDENDUM) Fix NPEs when mocking RS clocks in tests (appy: rev
bc48d841bce1dbcc31016ff55837b9f1b242e3d6)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Clocks.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestWALLockup.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionReplayEvents.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/AbstractTestWALReplay.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionSplitPolicy.java
> [HLC] Finishing cleanups
>
>
> Key: HBASE-18509
> URL: https://issues.apache.org/jira/browse/HBASE-18509
> Project: HBase
> Issue Type: Sub-task
>Reporter: Appy
>Assignee: Amit Patel
> Attachments: HBASE-18509.HBASE-14070.HLC.001.patch,
> HBASE-18509.HBASE-14070.HLC.002.patch, HBASE-18509.HBASE-14070.HLC.003.patch,
> HBASE-18509.HBASE-14070.HLC.004.patch, HBASE-18509.HBASE-14070.HLC.005.patch
>
>
> Track all types of cleanups here:
> - (done in 001.patch) --Rename classes to more consistent naming:
> SystemClock, SystemMonotonicClock, HybridLogicalClock--
> - (done in 001.patch) --Move implementations out from Clock interface. It's a
> simple interface of 6 fns but very overloaded right now with everything put
> inside it.--
> - (done in 004.patch) --Maybe encapsulate all clocks in RS/Master into a new
> class. Then RSServices can just have getClocks() function.--
> {noformat}
> class Clocks {
> // all 3 types of clocks.
> // Fns:
> - update(ClockType, timestamp)
> - updateAll(List\)
> - int64 now(ClockType)
> - List\ nowAll()
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18509) [HLC] Finishing cleanups
[
https://issues.apache.org/jira/browse/HBASE-18509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139297#comment-16139297
]
Appy commented on HBASE-18509:
--
Pushed tests fix to HBASE-14070.HLC.
> [HLC] Finishing cleanups
>
>
> Key: HBASE-18509
> URL: https://issues.apache.org/jira/browse/HBASE-18509
> Project: HBase
> Issue Type: Sub-task
>Reporter: Appy
>Assignee: Amit Patel
> Attachments: HBASE-18509.HBASE-14070.HLC.001.patch,
> HBASE-18509.HBASE-14070.HLC.002.patch, HBASE-18509.HBASE-14070.HLC.003.patch,
> HBASE-18509.HBASE-14070.HLC.004.patch, HBASE-18509.HBASE-14070.HLC.005.patch
>
>
> Track all types of cleanups here:
> - (done in 001.patch) --Rename classes to more consistent naming:
> SystemClock, SystemMonotonicClock, HybridLogicalClock--
> - (done in 001.patch) --Move implementations out from Clock interface. It's a
> simple interface of 6 fns but very overloaded right now with everything put
> inside it.--
> - (done in 004.patch) --Maybe encapsulate all clocks in RS/Master into a new
> class. Then RSServices can just have getClocks() function.--
> {noformat}
> class Clocks {
> // all 3 types of clocks.
> // Fns:
> - update(ClockType, timestamp)
> - updateAll(List\)
> - int64 now(ClockType)
> - List\ nowAll()
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18509) [HLC] Finishing cleanups
[
https://issues.apache.org/jira/browse/HBASE-18509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138034#comment-16138034
]
Hudson commented on HBASE-18509:
FAILURE: Integrated in Jenkins build HBASE-14070.HLC #266 (See
[https://builds.apache.org/job/HBASE-14070.HLC/266/])
HBASE-18509 Encapsulate all clocks in RS/Master into a new 'Clocks' (stack: rev
4c56a3c28a5eea721f82dae841bb88c48a2bb04e)
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/TestClockWithCluster.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/MockRegionServerServices.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java
* (add)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Clocks.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockNoopMasterServices.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/AbstractTestWALReplay.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RSProcedureDispatcher.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionSplitPolicy.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionReplayEvents.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestWALLockup.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerServices.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java
> [HLC] Finishing cleanups
>
>
> Key: HBASE-18509
> URL: https://issues.apache.org/jira/browse/HBASE-18509
> Project: HBase
> Issue Type: Sub-task
>Reporter: Appy
>Assignee: Amit Patel
> Attachments: HBASE-18509.HBASE-14070.HLC.001.patch,
> HBASE-18509.HBASE-14070.HLC.002.patch, HBASE-18509.HBASE-14070.HLC.003.patch,
> HBASE-18509.HBASE-14070.HLC.004.patch
>
>
> Track all types of cleanups here:
> - (done in 001.patch) --Rename classes to more consistent naming:
> SystemClock, SystemMonotonicClock, HybridLogicalClock--
> - (done in 001.patch) --Move implementations out from Clock interface. It's a
> simple interface of 6 fns but very overloaded right now with everything put
> inside it.--
> - (done in 004.patch) --Maybe encapsulate all clocks in RS/Master into a new
> class. Then RSServices can just have getClocks() function.--
> {noformat}
> class Clocks {
> // all 3 types of clocks.
> // Fns:
> - update(ClockType, timestamp)
> - updateAll(List\)
> - int64 now(ClockType)
> - List\ nowAll()
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18509) [HLC] Finishing cleanups
[
https://issues.apache.org/jira/browse/HBASE-18509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137906#comment-16137906
]
Appy commented on HBASE-18509:
--
There's one more action item remaining - split out clocks in separate package.
But we can do it in another jira.
> [HLC] Finishing cleanups
>
>
> Key: HBASE-18509
> URL: https://issues.apache.org/jira/browse/HBASE-18509
> Project: HBase
> Issue Type: Sub-task
>Reporter: Appy
>Assignee: Amit Patel
> Attachments: HBASE-18509.HBASE-14070.HLC.001.patch,
> HBASE-18509.HBASE-14070.HLC.002.patch, HBASE-18509.HBASE-14070.HLC.003.patch,
> HBASE-18509.HBASE-14070.HLC.004.patch
>
>
> Track all types of cleanups here:
> - (done in 001.patch) --Rename classes to more consistent naming:
> SystemClock, SystemMonotonicClock, HybridLogicalClock--
> - (done in 001.patch) --Move implementations out from Clock interface. It's a
> simple interface of 6 fns but very overloaded right now with everything put
> inside it.--
> - Move to separate module/package/both
> - Maybe encapsulate all clocks in RS/Master into a new class. Then RSServices
> can just have getClocks() function.
> {noformat}
> class Clocks {
> // all 3 types of clocks.
> // Fns:
> - update(ClockType, timestamp)
> - updateAll(List\)
> - int64 now(ClockType)
> - List\ nowAll()
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18509) [HLC] Finishing cleanups
[
https://issues.apache.org/jira/browse/HBASE-18509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137879#comment-16137879
]
Hadoop QA commented on HBASE-18509:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
1s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 8 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
35s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
0s{color} | {color:green} HBASE-14070.HLC passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
57s{color} | {color:green} HBASE-14070.HLC passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
50s{color} | {color:green} HBASE-14070.HLC passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
28s{color} | {color:green} HBASE-14070.HLC passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
44s{color} | {color:green} HBASE-14070.HLC passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
49s{color} | {color:green} HBASE-14070.HLC passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
36m 16s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
52s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 25m 29s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 88m 20s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.regionserver.TestRegionSplitPolicy |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18509 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12883235/HBASE-18509.HBASE-14070.HLC.004.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux ea9f15865698 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | HBASE-14070.HLC / 4e7c55d |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/8253/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8253/testReport/
[jira] [Commented] (HBASE-18509) [HLC] Finishing cleanups
[
https://issues.apache.org/jira/browse/HBASE-18509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137856#comment-16137856
]
stack commented on HBASE-18509:
---
Let me know if I should not have resolved this patch, if there is more cleanup
to do [~amit.patel] Thanks.
> [HLC] Finishing cleanups
>
>
> Key: HBASE-18509
> URL: https://issues.apache.org/jira/browse/HBASE-18509
> Project: HBase
> Issue Type: Sub-task
>Reporter: Appy
>Assignee: Amit Patel
> Attachments: HBASE-18509.HBASE-14070.HLC.001.patch,
> HBASE-18509.HBASE-14070.HLC.002.patch, HBASE-18509.HBASE-14070.HLC.003.patch,
> HBASE-18509.HBASE-14070.HLC.004.patch
>
>
> Track all types of cleanups here:
> - (done in 001.patch) --Rename classes to more consistent naming:
> SystemClock, SystemMonotonicClock, HybridLogicalClock--
> - (done in 001.patch) --Move implementations out from Clock interface. It's a
> simple interface of 6 fns but very overloaded right now with everything put
> inside it.--
> - Move to separate module/package/both
> - Maybe encapsulate all clocks in RS/Master into a new class. Then RSServices
> can just have getClocks() function.
> {noformat}
> class Clocks {
> // all 3 types of clocks.
> // Fns:
> - update(ClockType, timestamp)
> - updateAll(List\)
> - int64 now(ClockType)
> - List\ nowAll()
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18509) [HLC] Finishing cleanups
[
https://issues.apache.org/jira/browse/HBASE-18509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137392#comment-16137392
]
Amit Patel commented on HBASE-18509:
Patch 3 [^HBASE-18509.HBASE-14070.HLC.003.patch] includes the new Clocks class
(forgot to add it in the patch before)
> [HLC] Finishing cleanups
>
>
> Key: HBASE-18509
> URL: https://issues.apache.org/jira/browse/HBASE-18509
> Project: HBase
> Issue Type: Sub-task
>Reporter: Appy
>Assignee: Amit Patel
> Attachments: HBASE-18509.HBASE-14070.HLC.001.patch,
> HBASE-18509.HBASE-14070.HLC.002.patch, HBASE-18509.HBASE-14070.HLC.003.patch
>
>
> Track all types of cleanups here:
> - (done in 001.patch) --Rename classes to more consistent naming:
> SystemClock, SystemMonotonicClock, HybridLogicalClock--
> - (done in 001.patch) --Move implementations out from Clock interface. It's a
> simple interface of 6 fns but very overloaded right now with everything put
> inside it.--
> - Move to separate module/package/both
> - Maybe encapsulate all clocks in RS/Master into a new class. Then RSServices
> can just have getClocks() function.
> {noformat}
> class Clocks {
> // all 3 types of clocks.
> // Fns:
> - update(ClockType, timestamp)
> - updateAll(List\)
> - int64 now(ClockType)
> - List\ nowAll()
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18509) [HLC] Finishing cleanups
[
https://issues.apache.org/jira/browse/HBASE-18509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137300#comment-16137300
]
Amit Patel commented on HBASE-18509:
Patch 2 [^HBASE-18509.HBASE-14070.HLC.002.patch] takes care of encapsulating
all clocks in RS/Master into a new class (Clocks).
> [HLC] Finishing cleanups
>
>
> Key: HBASE-18509
> URL: https://issues.apache.org/jira/browse/HBASE-18509
> Project: HBase
> Issue Type: Sub-task
>Reporter: Appy
>Assignee: Amit Patel
> Attachments: HBASE-18509.HBASE-14070.HLC.001.patch,
> HBASE-18509.HBASE-14070.HLC.002.patch
>
>
> Track all types of cleanups here:
> - (done in 001.patch) --Rename classes to more consistent naming:
> SystemClock, SystemMonotonicClock, HybridLogicalClock--
> - (done in 001.patch) --Move implementations out from Clock interface. It's a
> simple interface of 6 fns but very overloaded right now with everything put
> inside it.--
> - Move to separate module/package/both
> - Maybe encapsulate all clocks in RS/Master into a new class. Then RSServices
> can just have getClocks() function.
> {noformat}
> class Clocks {
> // all 3 types of clocks.
> // Fns:
> - update(ClockType, timestamp)
> - updateAll(List\)
> - int64 now(ClockType)
> - List\ nowAll()
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18509) [HLC] Finishing cleanups
[
https://issues.apache.org/jira/browse/HBASE-18509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16128229#comment-16128229
]
Hudson commented on HBASE-18509:
FAILURE: Integrated in Jenkins build HBASE-14070.HLC #221 (See
[https://builds.apache.org/job/HBASE-14070.HLC/221/])
HBASE-18509 Cleanup Clock interface. (appy: rev
82a9cec595d165a715a0406e5b280bec8fcf0e88)
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionReplayEvents.java
* (add)
hbase-common/src/main/java/org/apache/hadoop/hbase/SystemMonotonicClock.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultMemStore.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RSProcedureDispatcher.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* (add)
hbase-common/src/main/java/org/apache/hadoop/hbase/HybridLogicalClock.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestCoprocessorScanPolicy.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/TestClockWithCluster.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionSplitPolicy.java
* (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/TimestampType.java
* (add) hbase-common/src/main/java/org/apache/hadoop/hbase/SystemClock.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestCopyTable.java
* (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/Clock.java
* (edit)
hbase-common/src/main/java/org/apache/hadoop/hbase/SettableTimestamp.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestCellACLWithMultipleVersions.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactingMemStore.java
* (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/ClockType.java
* (edit)
hbase-common/src/test/java/org/apache/hadoop/hbase/TestTimestampType.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/AbstractTestWALReplay.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
* (add) hbase-common/src/main/java/org/apache/hadoop/hbase/ClockException.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestIncrementTimeRange.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestWALLockup.java
* (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/TestClock.java
> [HLC] Finishing cleanups
>
>
> Key: HBASE-18509
> URL: https://issues.apache.org/jira/browse/HBASE-18509
> Project: HBase
> Issue Type: Sub-task
>Reporter: Appy
>Assignee: Amit Patel
> Attachments: HBASE-18509.HBASE-14070.HLC.001.patch
>
>
> Track all types of cleanups here:
> - (done in 001.patch) --Rename classes to more consistent naming:
> SystemClock, SystemMonotonicClock, HybridLogicalClock--
> - (done in 001.patch) --Move implementations out from Clock interface. It's a
> simple interface of 6 fns but very overloaded right now with everything put
> inside it.--
> - Move to separate module/package/both
> - Maybe encapsulate all clocks in RS/Master into a new class. Then RSServices
> can just have getClocks() function.
> {noformat}
> class Clocks {
> // all 3 types of clocks.
> // Fns:
> - update(ClockType, timestamp)
> - updateAll(List\)
> - int64 now(ClockType)
> - List\ nowAll()
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18509) [HLC] Finishing cleanups
[
https://issues.apache.org/jira/browse/HBASE-18509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16128145#comment-16128145
]
Appy commented on HBASE-18509:
--
Patch 1 takes care of:
- Rename classes to more consistent naming: SystemClock, SystemMonotonicClock,
HybridLogicalClock
- Move implementations out from Clock interface. It's a simple interface of 6
fns but very overloaded right now with everything put inside it.
Additional changes before commit: Moved out ClockException too. Added
InterfaceAudience to new classes.
Committed.
Keeping jira open for remaining cleanup work.
> [HLC] Finishing cleanups
>
>
> Key: HBASE-18509
> URL: https://issues.apache.org/jira/browse/HBASE-18509
> Project: HBase
> Issue Type: Sub-task
>Reporter: Appy
>Assignee: Amit Patel
> Attachments: HBASE-18509.HBASE-14070.HLC.001.patch
>
>
> Track all types of cleanups here:
> - Rename classes to more consistent naming: SystemClock,
> SystemMonotonicClock, HybridLogicalClock
> - Move implementations out from Clock interface. It's a simple interface of 6
> fns but very overloaded right now with everything put inside it.
> - Maybe encapsulate all clocks in RS/Master into a new class. Then RSServices
> can just have getClocks() function.
> {noformat}
> class Clocks {
> // all 3 types of clocks.
> // Fns:
> - update(ClockType, timestamp)
> - updateAll(List\)
> - int64 now(ClockType)
> - List\ nowAll()
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
