[jira] [Commented] (HBASE-18537) [C++] Improvements to load-client
[ https://issues.apache.org/jira/browse/HBASE-18537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123606#comment-16123606 ] Ted Yu commented on HBASE-18537: Alright. lgtm > [C++] Improvements to load-client > - > > Key: HBASE-18537 > URL: https://issues.apache.org/jira/browse/HBASE-18537 > Project: HBase > Issue Type: Sub-task >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: HBASE-14850 > > Attachments: hbase-18537.patch, hbase-18537_v2.patch > > > A couple of improvements to the load-client after spending some time with > testing: > - better log messages > - support for progress > - minor bug fixes -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18537) [C++] Improvements to load-client
[
https://issues.apache.org/jira/browse/HBASE-18537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123592#comment-16123592
]
Enis Soztutar commented on HBASE-18537:
---
Thanks Ted for taking a look.
bq. Why is the above check needed ?
It fixes a bug in the logic for setting scan end keys. Lets say we have
{{num_rows=1}}, then {{max_row}} is {{}} with {{width=4}}, but the
width of {{end=1}} is 5. Thus, for these types of cases, the last scanners
end row does not use the same width as the other ones. Since we do not have
inclusive stop rows, not setting the scanners end key is a quick solution.
bq. Where does the above go ?
{{DoGet()}} calls {{Verify}} which is the overloaded one taking all of the
families. That method in turn calls the {{Verify()}} method for every column.
> [C++] Improvements to load-client
> -
>
> Key: HBASE-18537
> URL: https://issues.apache.org/jira/browse/HBASE-18537
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
> Fix For: HBASE-14850
>
> Attachments: hbase-18537.patch, hbase-18537_v2.patch
>
>
> A couple of improvements to the load-client after spending some time with
> testing:
> - better log messages
> - support for progress
> - minor bug fixes
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18537) [C++] Improvements to load-client
[
https://issues.apache.org/jira/browse/HBASE-18537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122705#comment-16122705
]
Ted Yu commented on HBASE-18537:
{code}
+ if (end != max_row && end != max_row + 1) {
{code}
Why is the above check needed ?
For DoGet(),
{code}
-for (int m = 1; m <= cols; m++) {
- if (!Verify(result, family, m)) return false;
{code}
Where does the above go ?
> [C++] Improvements to load-client
> -
>
> Key: HBASE-18537
> URL: https://issues.apache.org/jira/browse/HBASE-18537
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
> Fix For: HBASE-14850
>
> Attachments: hbase-18537.patch, hbase-18537_v2.patch
>
>
> A couple of improvements to the load-client after spending some time with
> testing:
> - better log messages
> - support for progress
> - minor bug fixes
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18537) [C++] Improvements to load-client
[ https://issues.apache.org/jira/browse/HBASE-18537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120413#comment-16120413 ] Enis Soztutar commented on HBASE-18537: --- [~ted_yu] do you mind taking a look. > [C++] Improvements to load-client > - > > Key: HBASE-18537 > URL: https://issues.apache.org/jira/browse/HBASE-18537 > Project: HBase > Issue Type: Sub-task >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: HBASE-14850 > > Attachments: hbase-18537.patch > > > A couple of improvements to the load-client after spending some time with > testing: > - better log messages > - support for progress > - minor bug fixes -- This message was sent by Atlassian JIRA (v6.4.14#64029)
