[jira] [Commented] (HBASE-18611) Copy all tests from o.a.h.h.p.TestProtobufUtil to o.a.h.h.s.p.TestProtobufUtil
[ https://issues.apache.org/jira/browse/HBASE-18611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143171#comment-16143171 ] Hudson commented on HBASE-18611: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3607 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3607/]) HBASE-18611 Copy all tests from o.a.h.h.p.TestProtobufUtil to (chia7712: rev a407b58f17f92ce036b4c021c9a1c7feae39958f) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/protobuf/TestProtobufUtil.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/shaded/protobuf/TestProtobufUtil.java > Copy all tests from o.a.h.h.p.TestProtobufUtil to o.a.h.h.s.p.TestProtobufUtil > -- > > Key: HBASE-18611 > URL: https://issues.apache.org/jira/browse/HBASE-18611 > Project: HBase > Issue Type: Task > Components: Protobufs, test >Affects Versions: 3.0.0, 2.0.0-alpha-1 >Reporter: Chia-Ping Tsai >Assignee: ChunHao >Priority: Minor > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-18611.master.v0.patch, > HBASE-18611.master.v1.patch, HBASE-18611.master.v2.patch, > HBASE-18611.master.v3.patch > > > We copied all codes from o.a.h.h.p.ProtobufUtil to o.a.h.h.s.p.ProtobufUtil, > but we ignored the test codes. Let us increase the code coverage. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18611) Copy all tests from o.a.h.h.p.TestProtobufUtil to o.a.h.h.s.p.TestProtobufUtil
[ https://issues.apache.org/jira/browse/HBASE-18611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143148#comment-16143148 ] Hudson commented on HBASE-18611: FAILURE: Integrated in Jenkins build HBase-2.0 #406 (See [https://builds.apache.org/job/HBase-2.0/406/]) HBASE-18611 Copy all tests from o.a.h.h.p.TestProtobufUtil to (chia7712: rev e07ff0452fdb81c20721cd1de4f1419c40b8d14c) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/protobuf/TestProtobufUtil.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/shaded/protobuf/TestProtobufUtil.java > Copy all tests from o.a.h.h.p.TestProtobufUtil to o.a.h.h.s.p.TestProtobufUtil > -- > > Key: HBASE-18611 > URL: https://issues.apache.org/jira/browse/HBASE-18611 > Project: HBase > Issue Type: Task > Components: Protobufs, test >Affects Versions: 3.0.0, 2.0.0-alpha-1 >Reporter: Chia-Ping Tsai >Assignee: ChunHao >Priority: Minor > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-18611.master.v0.patch, > HBASE-18611.master.v1.patch, HBASE-18611.master.v2.patch, > HBASE-18611.master.v3.patch > > > We copied all codes from o.a.h.h.p.ProtobufUtil to o.a.h.h.s.p.ProtobufUtil, > but we ignored the test codes. Let us increase the code coverage. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18611) Copy all tests from o.a.h.h.p.TestProtobufUtil to o.a.h.h.s.p.TestProtobufUtil
[ https://issues.apache.org/jira/browse/HBASE-18611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142847#comment-16142847 ] Chia-Ping Tsai commented on HBASE-18611: Will commit it later if no objections. > Copy all tests from o.a.h.h.p.TestProtobufUtil to o.a.h.h.s.p.TestProtobufUtil > -- > > Key: HBASE-18611 > URL: https://issues.apache.org/jira/browse/HBASE-18611 > Project: HBase > Issue Type: Task > Components: Protobufs, test >Affects Versions: 3.0.0, 2.0.0-alpha-1 >Reporter: Chia-Ping Tsai >Assignee: ChunHao >Priority: Minor > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-18611.master.v0.patch, > HBASE-18611.master.v1.patch, HBASE-18611.master.v2.patch, > HBASE-18611.master.v3.patch > > > We copied all codes from o.a.h.h.p.ProtobufUtil to o.a.h.h.s.p.ProtobufUtil, > but we ignored the test codes. Let us increase the code coverage. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18611) Copy all tests from o.a.h.h.p.TestProtobufUtil to o.a.h.h.s.p.TestProtobufUtil
[
https://issues.apache.org/jira/browse/HBASE-18611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142841#comment-16142841
]
Hadoop QA commented on HBASE-18611:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
32m 44s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}111m
51s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
16s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}158m 35s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18611 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12883928/HBASE-18611.master.v3.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 72ab101a9414 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / f53051b |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8337/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8337/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Copy all tests from o.a.h.h.p.TestProtobufUtil to o.a.h.h.s.p.TestProtobufUtil
> --
>
> Key: HBASE-18611
> URL: https://issues.apache.org/jira/browse/HBASE-18611
> Project: HBase
> Issue Type: Task
> Components: Protobufs, test
>Affects Versions: 3.0.0, 2.0.0-alpha-1
>Reporter: Chia-Ping Tsai
>
[jira] [Commented] (HBASE-18611) Copy all tests from o.a.h.h.p.TestProtobufUtil to o.a.h.h.s.p.TestProtobufUtil
[ https://issues.apache.org/jira/browse/HBASE-18611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142792#comment-16142792 ] ChunHao commented on HBASE-18611: - [~chia7712], I have removed the duplicate import, thank you for your comment. > Copy all tests from o.a.h.h.p.TestProtobufUtil to o.a.h.h.s.p.TestProtobufUtil > -- > > Key: HBASE-18611 > URL: https://issues.apache.org/jira/browse/HBASE-18611 > Project: HBase > Issue Type: Task > Components: Protobufs, test >Affects Versions: 3.0.0, 2.0.0-alpha-1 >Reporter: Chia-Ping Tsai >Assignee: ChunHao >Priority: Minor > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-18611.master.v0.patch, > HBASE-18611.master.v1.patch, HBASE-18611.master.v2.patch, > HBASE-18611.master.v3.patch > > > We copied all codes from o.a.h.h.p.ProtobufUtil to o.a.h.h.s.p.ProtobufUtil, > but we ignored the test codes. Let us increase the code coverage. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18611) Copy all tests from o.a.h.h.p.TestProtobufUtil to o.a.h.h.s.p.TestProtobufUtil
[
https://issues.apache.org/jira/browse/HBASE-18611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142783#comment-16142783
]
Chia-Ping Tsai commented on HBASE-18611:
LGTM.
nit: duplicate import
{code}
+import
org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos.MutationProto;
import
org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos.MutationProto;
{code}
> Copy all tests from o.a.h.h.p.TestProtobufUtil to o.a.h.h.s.p.TestProtobufUtil
> --
>
> Key: HBASE-18611
> URL: https://issues.apache.org/jira/browse/HBASE-18611
> Project: HBase
> Issue Type: Task
> Components: Protobufs, test
>Affects Versions: 3.0.0, 2.0.0-alpha-1
>Reporter: Chia-Ping Tsai
>Assignee: ChunHao
>Priority: Minor
> Labels: beginner
> Fix For: 2.0.0
>
> Attachments: HBASE-18611.master.v0.patch,
> HBASE-18611.master.v1.patch, HBASE-18611.master.v2.patch
>
>
> We copied all codes from o.a.h.h.p.ProtobufUtil to o.a.h.h.s.p.ProtobufUtil,
> but we ignored the test codes. Let us increase the code coverage.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18611) Copy all tests from o.a.h.h.p.TestProtobufUtil to o.a.h.h.s.p.TestProtobufUtil
[
https://issues.apache.org/jira/browse/HBASE-18611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142734#comment-16142734
]
Hadoop QA commented on HBASE-18611:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
22s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
33m 47s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 62m 43s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
23s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}112m 40s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests |
org.apache.hadoop.hbase.master.procedure.TestDisableTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestModifyTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestCreateTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestEnableTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestDeleteTableProcedure |
| | org.apache.hadoop.hbase.client.TestSnapshotCloneIndependence |
| | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId |
| | org.apache.hadoop.hbase.client.TestFromClientSide |
| | org.apache.hadoop.hbase.client.TestMultipleTimestamps |
| | org.apache.hadoop.hbase.client.TestAsyncReplicationAdminApi |
| | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 |
| | org.apache.hadoop.hbase.trace.TestHTraceHooks |
| | org.apache.hadoop.hbase.snapshot.TestSnapshotClientRetries |
| | org.apache.hadoop.hbase.namespace.TestNamespaceAuditor |
| | org.apache.hadoop.hbase.TestHBaseTestingUtility |
| | org.apache.hadoop.hbase.client.TestAsyncNamespaceAdminApi |
| | org.apache.hadoop.hbase.client.TestAsyncProcedureAdminApi |
| | org.apache.hadoop.hbase.client.TestAsyncTableBatch |
| | org.apache.hadoop.hbase.regionserver.TestTimestampFilterSeekHint |
| | org.apache.hadoop.hbase.TestMultiVersions |
| | org.apache.hadoop.hbase.security.access.TestAccessController3 |
| | org.apache.hadoop.hbase.client.TestAsyncNonMetaRegionLocator |
| |
[jira] [Commented] (HBASE-18611) Copy all tests from o.a.h.h.p.TestProtobufUtil to o.a.h.h.s.p.TestProtobufUtil
[ https://issues.apache.org/jira/browse/HBASE-18611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142674#comment-16142674 ] ChunHao commented on HBASE-18611: - ??+CellProtos.Cell cell = org.apache.hadoop.hbase.protobuf.ProtobufUtil.toCell(offheapKV); +Cell newOffheapKV = org.apache.hadoop.hbase.protobuf.ProtobufUtil.toCell(cell); After fixing the wrong import, you don't need to use the fully qualified name for ProtobufUtil.?? [~chia7712], I have removed the "org.apache.hadoop.hbase.protobuf" for ProtobufUtil in v2 patch. > Copy all tests from o.a.h.h.p.TestProtobufUtil to o.a.h.h.s.p.TestProtobufUtil > -- > > Key: HBASE-18611 > URL: https://issues.apache.org/jira/browse/HBASE-18611 > Project: HBase > Issue Type: Task > Components: Protobufs, test >Affects Versions: 3.0.0, 2.0.0-alpha-1 >Reporter: Chia-Ping Tsai >Assignee: ChunHao >Priority: Minor > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-18611.master.v0.patch, > HBASE-18611.master.v1.patch, HBASE-18611.master.v2.patch > > > We copied all codes from o.a.h.h.p.ProtobufUtil to o.a.h.h.s.p.ProtobufUtil, > but we ignored the test codes. Let us increase the code coverage. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18611) Copy all tests from o.a.h.h.p.TestProtobufUtil to o.a.h.h.s.p.TestProtobufUtil
[
https://issues.apache.org/jira/browse/HBASE-18611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142627#comment-16142627
]
Hadoop QA commented on HBASE-18611:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
39m 24s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 69m 59s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
32s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}127m 24s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests | org.apache.hadoop.hbase.regionserver.TestRowTooBig |
| | org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy
|
| | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId |
| | org.apache.hadoop.hbase.regionserver.wal.TestFSHLog |
| | org.apache.hadoop.hbase.regionserver.TestCompaction |
| | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 |
| | org.apache.hadoop.hbase.snapshot.TestSnapshotClientRetries |
| | org.apache.hadoop.hbase.regionserver.TestTimestampFilterSeekHint |
| | org.apache.hadoop.hbase.TestHBaseTestingUtility |
| | org.apache.hadoop.hbase.TestFullLogReconstruction |
| | org.apache.hadoop.hbase.wal.TestWALFiltering |
| |
org.apache.hadoop.hbase.security.visibility.TestEnforcingScanLabelGenerator |
| |
org.apache.hadoop.hbase.security.visibility.TestVisibilityLablesWithGroups |
| | org.apache.hadoop.hbase.quotas.TestMasterSpaceQuotaObserver |
| | org.apache.hadoop.hbase.replication.regionserver.TestWALEntryStream |
| | org.apache.hadoop.hbase.master.TestGetInfoPort |
| | org.apache.hadoop.hbase.TestZooKeeper |
| | org.apache.hadoop.hbase.wal.TestWALSplitCompressed |
| | org.apache.hadoop.hbase.master.TestMasterFailoverBalancerPersistence |
| | org.apache.hadoop.hbase.regionserver.TestColumnSeeking |
| | org.apache.hadoop.hbase.quotas.TestQuotaTableUtil |
| | org.apache.hadoop.hbase.mob.compactions.TestPartitionedMobCompactor |
| |
[jira] [Commented] (HBASE-18611) Copy all tests from o.a.h.h.p.TestProtobufUtil to o.a.h.h.s.p.TestProtobufUtil
[
https://issues.apache.org/jira/browse/HBASE-18611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142615#comment-16142615
]
Chia-Ping Tsai commented on HBASE-18611:
{code}
+CellProtos.Cell cell =
org.apache.hadoop.hbase.protobuf.ProtobufUtil.toCell(offheapKV);
+Cell newOffheapKV =
org.apache.hadoop.hbase.protobuf.ProtobufUtil.toCell(cell);
{code}
After fixing the wrong import, you don't need to use the fully qualified name
for ProtobufUtil.
> Copy all tests from o.a.h.h.p.TestProtobufUtil to o.a.h.h.s.p.TestProtobufUtil
> --
>
> Key: HBASE-18611
> URL: https://issues.apache.org/jira/browse/HBASE-18611
> Project: HBase
> Issue Type: Task
> Components: Protobufs, test
>Affects Versions: 3.0.0, 2.0.0-alpha-1
>Reporter: Chia-Ping Tsai
>Assignee: ChunHao
>Priority: Minor
> Labels: beginner
> Fix For: 2.0.0
>
> Attachments: HBASE-18611.master.v0.patch, HBASE-18611.master.v1.patch
>
>
> We copied all codes from o.a.h.h.p.ProtobufUtil to o.a.h.h.s.p.ProtobufUtil,
> but we ignored the test codes. Let us increase the code coverage.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18611) Copy all tests from o.a.h.h.p.TestProtobufUtil to o.a.h.h.s.p.TestProtobufUtil
[ https://issues.apache.org/jira/browse/HBASE-18611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142590#comment-16142590 ] ChunHao commented on HBASE-18611: - [~chia7712], I have fixed the wrong import. > Copy all tests from o.a.h.h.p.TestProtobufUtil to o.a.h.h.s.p.TestProtobufUtil > -- > > Key: HBASE-18611 > URL: https://issues.apache.org/jira/browse/HBASE-18611 > Project: HBase > Issue Type: Task > Components: Protobufs, test >Affects Versions: 3.0.0, 2.0.0-alpha-1 >Reporter: Chia-Ping Tsai >Assignee: ChunHao >Priority: Minor > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-18611.master.v0.patch, HBASE-18611.master.v1.patch > > > We copied all codes from o.a.h.h.p.ProtobufUtil to o.a.h.h.s.p.ProtobufUtil, > but we ignored the test codes. Let us increase the code coverage. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18611) Copy all tests from o.a.h.h.p.TestProtobufUtil to o.a.h.h.s.p.TestProtobufUtil
[
https://issues.apache.org/jira/browse/HBASE-18611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142063#comment-16142063
]
Hadoop QA commented on HBASE-18611:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
39m 5s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
39s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 90m 23s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
21s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}147m 20s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests |
org.apache.hadoop.hbase.master.procedure.TestDisableTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestCreateTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestEnableTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestDeleteTableProcedure |
| | org.apache.hadoop.hbase.client.TestSnapshotCloneIndependence |
| | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId |
| | org.apache.hadoop.hbase.client.TestFromClientSide |
| | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 |
| | org.apache.hadoop.hbase.namespace.TestNamespaceAuditor |
| | org.apache.hadoop.hbase.TestHBaseTestingUtility |
| | org.apache.hadoop.hbase.mapred.TestTableInputFormat |
| | org.apache.hadoop.hbase.client.TestAsyncNamespaceAdminApi |
| | org.apache.hadoop.hbase.client.TestAsyncProcedureAdminApi |
| | org.apache.hadoop.hbase.client.TestAsyncTableBatch |
| |
org.apache.hadoop.hbase.security.visibility.TestVisibilityLablesWithGroups |
| |
org.apache.hadoop.hbase.security.visibility.TestEnforcingScanLabelGenerator |
| | org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi |
| | org.apache.hadoop.hbase.security.access.TestAccessController2 |
| | org.apache.hadoop.hbase.quotas.TestMasterSpaceQuotaObserver |
| | org.apache.hadoop.hbase.master.TestGetInfoPort |
| | org.apache.hadoop.hbase.TestZooKeeper |
|
[jira] [Commented] (HBASE-18611) Copy all tests from o.a.h.h.p.TestProtobufUtil to o.a.h.h.s.p.TestProtobufUtil
[
https://issues.apache.org/jira/browse/HBASE-18611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142044#comment-16142044
]
Chia-Ping Tsai commented on HBASE-18611:
The o.a.h.h.p.TestProtobufUtil has an wrong import.
{code}
import org.apache.hadoop.hbase.shaded.protobuf.generated.CellProtos;
{code}
Could you also fix that? Thanks.
> Copy all tests from o.a.h.h.p.TestProtobufUtil to o.a.h.h.s.p.TestProtobufUtil
> --
>
> Key: HBASE-18611
> URL: https://issues.apache.org/jira/browse/HBASE-18611
> Project: HBase
> Issue Type: Task
> Components: Protobufs, test
>Affects Versions: 3.0.0, 2.0.0-alpha-1
>Reporter: Chia-Ping Tsai
>Assignee: ChunHao
>Priority: Minor
> Labels: beginner
> Fix For: 2.0.0
>
> Attachments: HBASE-18611.master.v0.patch
>
>
> We copied all codes from o.a.h.h.p.ProtobufUtil to o.a.h.h.s.p.ProtobufUtil,
> but we ignored the test codes. Let us increase the code coverage.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18611) Copy all tests from o.a.h.h.p.TestProtobufUtil to o.a.h.h.s.p.TestProtobufUtil
[ https://issues.apache.org/jira/browse/HBASE-18611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141878#comment-16141878 ] Ted Yu commented on HBASE-18611: lgtm, pending QA > Copy all tests from o.a.h.h.p.TestProtobufUtil to o.a.h.h.s.p.TestProtobufUtil > -- > > Key: HBASE-18611 > URL: https://issues.apache.org/jira/browse/HBASE-18611 > Project: HBase > Issue Type: Task > Components: Protobufs, test >Affects Versions: 3.0.0, 2.0.0-alpha-1 >Reporter: Chia-Ping Tsai >Assignee: ChunHao >Priority: Minor > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-18611.master.v0.patch > > > We copied all codes from o.a.h.h.p.TestProtobufUtil to > o.a.h.h.s.p.ProtobufUtil, but we ignored the test codes. Let us increase the > code coverage. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
