[jira] [Commented] (HBASE-18622) Mitigate API compatibility concerns between branch-1 and branch-2

2018-06-22 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-18622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520502#comment-16520502
 ] 

stack commented on HBASE-18622:
---

We do. Need to write up report on what diffs are. It didn't block 2.0 so can't 
block 2.1.

> Mitigate API compatibility concerns between branch-1 and branch-2
> -
>
> Key: HBASE-18622
> URL: https://issues.apache.org/jira/browse/HBASE-18622
> Project: HBase
>  Issue Type: Bug
>  Components: API
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Fix For: 3.0.0, 2.1.0
>
> Attachments: report.1.2_2.0.html.gz
>
>
> This project is to do what [~apurtell] did in the issue "HBASE-18431 Mitigate 
> compatibility concerns between branch-1.3 and branch-1.4" only do it between 
> branch-1 and branch-2.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-18622) Mitigate API compatibility concerns between branch-1 and branch-2

2018-06-22 Thread Duo Zhang (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-18622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520204#comment-16520204
 ] 

Duo Zhang commented on HBASE-18622:
---

Ping [~stack] [~busbey]. Thanks.

> Mitigate API compatibility concerns between branch-1 and branch-2
> -
>
> Key: HBASE-18622
> URL: https://issues.apache.org/jira/browse/HBASE-18622
> Project: HBase
>  Issue Type: Bug
>  Components: API
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Fix For: 3.0.0, 2.1.0
>
> Attachments: report.1.2_2.0.html.gz
>
>
> This project is to do what [~apurtell] did in the issue "HBASE-18431 Mitigate 
> compatibility concerns between branch-1.3 and branch-1.4" only do it between 
> branch-1 and branch-2.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-18622) Mitigate API compatibility concerns between branch-1 and branch-2

2018-06-19 Thread Duo Zhang (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-18622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517085#comment-16517085
 ] 

Duo Zhang commented on HBASE-18622:
---

Do we still have unfinished work for this issue? It is marked as blocker...

> Mitigate API compatibility concerns between branch-1 and branch-2
> -
>
> Key: HBASE-18622
> URL: https://issues.apache.org/jira/browse/HBASE-18622
> Project: HBase
>  Issue Type: Bug
>  Components: API
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Fix For: 3.0.0, 2.1.0
>
> Attachments: report.1.2_2.0.html.gz
>
>
> This project is to do what [~apurtell] did in the issue "HBASE-18431 Mitigate 
> compatibility concerns between branch-1.3 and branch-1.4" only do it between 
> branch-1 and branch-2.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-18622) Mitigate API compatibility concerns between branch-1 and branch-2

2018-04-12 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436365#comment-16436365
 ] 

stack commented on HBASE-18622:
---

Reran the report

Changed the reporting tool to use 2.4 instead of 2.1 (released in January).

diff --git a/dev-support/checkcompatibility.py 
b/dev-support/checkcompatibility.py
index ea9c229344..9f0d797ff3 100755
--- a/dev-support/checkcompatibility.py
+++ b/dev-support/checkcompatibility.py
@@ -156,7 +156,7 @@ def checkout_java_acc(force):

 logging.info("Downloading Java ACC...")

-url = "https://github.com/lvc/japi-compliance-checker/archive/2.1.tar.gz;
+url = "https://github.com/lvc/japi-compliance-checker/archive/2.4.tar.gz;
 scratch_dir = get_scratch_dir()
 path = os.path.join(scratch_dir, os.path.basename(url))
 jacc = urllib2.urlopen(url)
@@ -166,7 +166,7 @@ def checkout_java_acc(force):
 subprocess.check_call(["tar", "xzf", path],
   cwd=scratch_dir)

-shutil.move(os.path.join(scratch_dir, "japi-compliance-checker-2.1"),
+shutil.move(os.path.join(scratch_dir, "japi-compliance-checker-2.4"),
 os.path.join(acc_dir))


$ ./dev-support/checkcompatibility.py --annotation 
org.apache.hadoop.hbase.classification.InterfaceAudience.Public rel/1.2.6 
2.0.0RC0


> Mitigate API compatibility concerns between branch-1 and branch-2
> -
>
> Key: HBASE-18622
> URL: https://issues.apache.org/jira/browse/HBASE-18622
> Project: HBase
>  Issue Type: Bug
>  Components: API
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: report.1.2_2.0.html.gz
>
>
> This project is to do what [~apurtell] did in the issue "HBASE-18431 Mitigate 
> compatibility concerns between branch-1.3 and branch-1.4" only do it between 
> branch-1 and branch-2.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)