[jira] [Commented] (HBASE-18667) Disable error-prone for hbase-protocol-shaded
[
https://issues.apache.org/jira/browse/HBASE-18667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804259#comment-16804259
]
Hudson commented on HBASE-18667:
Results for branch branch-2
[build #1782 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1782/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1782//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1782//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1782//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Disable error-prone for hbase-protocol-shaded
> -
>
> Key: HBASE-18667
> URL: https://issues.apache.org/jira/browse/HBASE-18667
> Project: HBase
> Issue Type: Sub-task
> Components: build
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-18667.patch
>
>
> This is all generated code that we shouldn't be running extra analysis on
> because it adds a lot of noise to the build, and also takes a very long time
> (15 minutes on my machine). Let's make it fast and simple.
> Even when we run with error-prone enabled for the rest of the build, it
> should not apply here.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-18667) Disable error-prone for hbase-protocol-shaded
[
https://issues.apache.org/jira/browse/HBASE-18667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804240#comment-16804240
]
Hudson commented on HBASE-18667:
Results for branch branch-2.2
[build #139 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/139/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/139//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/139//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/139//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Disable error-prone for hbase-protocol-shaded
> -
>
> Key: HBASE-18667
> URL: https://issues.apache.org/jira/browse/HBASE-18667
> Project: HBase
> Issue Type: Sub-task
> Components: build
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-18667.patch
>
>
> This is all generated code that we shouldn't be running extra analysis on
> because it adds a lot of noise to the build, and also takes a very long time
> (15 minutes on my machine). Let's make it fast and simple.
> Even when we run with error-prone enabled for the rest of the build, it
> should not apply here.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-18667) Disable error-prone for hbase-protocol-shaded
[
https://issues.apache.org/jira/browse/HBASE-18667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804110#comment-16804110
]
Hudson commented on HBASE-18667:
Results for branch branch-2.1
[build #1002 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1002/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1002//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1002//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1002//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Disable error-prone for hbase-protocol-shaded
> -
>
> Key: HBASE-18667
> URL: https://issues.apache.org/jira/browse/HBASE-18667
> Project: HBase
> Issue Type: Sub-task
> Components: build
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-18667.patch
>
>
> This is all generated code that we shouldn't be running extra analysis on
> because it adds a lot of noise to the build, and also takes a very long time
> (15 minutes on my machine). Let's make it fast and simple.
> Even when we run with error-prone enabled for the rest of the build, it
> should not apply here.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-18667) Disable error-prone for hbase-protocol-shaded
[
https://issues.apache.org/jira/browse/HBASE-18667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804049#comment-16804049
]
Hudson commented on HBASE-18667:
Results for branch branch-2.0
[build #1472 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1472/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1472//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1472//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1472//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Disable error-prone for hbase-protocol-shaded
> -
>
> Key: HBASE-18667
> URL: https://issues.apache.org/jira/browse/HBASE-18667
> Project: HBase
> Issue Type: Sub-task
> Components: build
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-18667.patch
>
>
> This is all generated code that we shouldn't be running extra analysis on
> because it adds a lot of noise to the build, and also takes a very long time
> (15 minutes on my machine). Let's make it fast and simple.
> Even when we run with error-prone enabled for the rest of the build, it
> should not apply here.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-18667) Disable error-prone for hbase-protocol-shaded
[ https://issues.apache.org/jira/browse/HBASE-18667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202410#comment-16202410 ] Hudson commented on HBASE-18667: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3875 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3875/]) HBASE-18667 Add @Generated to protobuf classes (mdrob: rev 883c3584b8436e2a541eda357e6eb480a61de6b4) * (edit) hbase-protocol/pom.xml * (edit) hbase-protocol-shaded/pom.xml > Disable error-prone for hbase-protocol-shaded > - > > Key: HBASE-18667 > URL: https://issues.apache.org/jira/browse/HBASE-18667 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: Mike Drob >Assignee: Mike Drob > Fix For: 3.0.0 > > Attachments: HBASE-18667.patch > > > This is all generated code that we shouldn't be running extra analysis on > because it adds a lot of noise to the build, and also takes a very long time > (15 minutes on my machine). Let's make it fast and simple. > Even when we run with error-prone enabled for the rest of the build, it > should not apply here. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18667) Disable error-prone for hbase-protocol-shaded
[
https://issues.apache.org/jira/browse/HBASE-18667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202266#comment-16202266
]
stack commented on HBASE-18667:
---
Patch makes sense to me. I tried it. Seems to do the right thing:
@javax.annotation.Generated("proto") public final class ZooKeeperProtos {
+1
> Disable error-prone for hbase-protocol-shaded
> -
>
> Key: HBASE-18667
> URL: https://issues.apache.org/jira/browse/HBASE-18667
> Project: HBase
> Issue Type: Sub-task
> Components: build
>Reporter: Mike Drob
>Assignee: Mike Drob
> Fix For: 3.0.0
>
> Attachments: HBASE-18667.patch
>
>
> This is all generated code that we shouldn't be running extra analysis on
> because it adds a lot of noise to the build, and also takes a very long time
> (15 minutes on my machine). Let's make it fast and simple.
> Even when we run with error-prone enabled for the rest of the build, it
> should not apply here.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18667) Disable error-prone for hbase-protocol-shaded
[ https://issues.apache.org/jira/browse/HBASE-18667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201814#comment-16201814 ] Mike Drob commented on HBASE-18667: --- [~stack] - proto generation seems to be your area, can you take a look at the patch? Thanks sir! Compiling with error prone is done by using the -PerrorProne profile > Disable error-prone for hbase-protocol-shaded > - > > Key: HBASE-18667 > URL: https://issues.apache.org/jira/browse/HBASE-18667 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: Mike Drob >Assignee: Mike Drob > Fix For: 3.0.0 > > Attachments: HBASE-18667.patch > > > This is all generated code that we shouldn't be running extra analysis on > because it adds a lot of noise to the build, and also takes a very long time > (15 minutes on my machine). Let's make it fast and simple. > Even when we run with error-prone enabled for the rest of the build, it > should not apply here. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18667) Disable error-prone for hbase-protocol-shaded
[
https://issues.apache.org/jira/browse/HBASE-18667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200967#comment-16200967
]
Hadoop QA commented on HBASE-18667:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
28s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 9m
40s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
20s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
4s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
41m 44s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
29s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
20s{color} | {color:green} hbase-protocol in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 56m 10s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18667 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12891555/HBASE-18667.patch |
| Optional Tests | asflicense shadedjars javac javadoc unit xml compile
|
| uname | Linux 737f41685084 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7
11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / c4ced0b |
| Default Java | 1.8.0_144 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/9049/testReport/ |
| modules | C: hbase-protocol-shaded hbase-protocol U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9049/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Disable error-prone for hbase-protocol-shaded
> -
>
>
[jira] [Commented] (HBASE-18667) Disable error-prone for hbase-protocol-shaded
[ https://issues.apache.org/jira/browse/HBASE-18667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139305#comment-16139305 ] stack commented on HBASE-18667: --- +1 > Disable error-prone for hbase-protocol-shaded > - > > Key: HBASE-18667 > URL: https://issues.apache.org/jira/browse/HBASE-18667 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: Mike Drob > > This is all generated code that we shouldn't be running extra analysis on > because it adds a lot of noise to the build, and also takes a very long time > (15 minutes on my machine). Let's make it fast and simple. > Even when we run with error-prone enabled for the rest of the build, it > should not apply here. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
