[jira] [Commented] (HBASE-18733) [compat 1-2] Hide WALKey
[ https://issues.apache.org/jira/browse/HBASE-18733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164006#comment-16164006 ] Hudson commented on HBASE-18733: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3705 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3705/]) HBASE-18733 [compat 1-2] Hide WALKey (stack: rev a66bd04815f772c571d53d09614e99f50d0b51ab) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALKey.java > [compat 1-2] Hide WALKey > > > Key: HBASE-18733 > URL: https://issues.apache.org/jira/browse/HBASE-18733 > Project: HBase > Issue Type: Sub-task > Components: API >Reporter: stack >Assignee: Sean Busbey > Fix For: 2.0.0-alpha-3 > > Attachments: 18733.txt > > > It has all the below issues and it uses our internal PB. See head of class > where it says it should go away... > hbase-server-1.0.0.jar, WALEdit.class > package org.apache.hadoop.hbase.regionserver.wal > [−] WALEdit.getCompaction ( Cell kv ) [static] : > WALProtos.CompactionDescriptor 1 > org/apache/hadoop/hbase/regionserver/wal/WALEdit.getCompaction:(Lorg/apache/hadoop/hbase/Cell;)Lorg/apache/hadoop/hbase/protobuf/generated/WALProtos$CompactionDescriptor; > ChangeEffect > 1 Return value type has been changed from > org.apache.hadoop.hbase.protobuf.generated.WALProtos.CompactionDescriptor to > org.apache.hadoop.hbase.shaded.protobuf.generated.WALProtos.CompactionDescriptor. > This method has been removed because the return type is part of the method > signature. A client program may be interrupted by NoSuchMethodError exception. > [+] WALEdit.getFlushDescriptor ( Cell cell ) [static] : > WALProtos.FlushDescriptor 1 > [+] WALEdit.getRegionEventDescriptor ( Cell cell ) [static] : > WALProtos.RegionEventDescriptor 1 > hbase-server-1.0.0.jar, WALKey.class > package org.apache.hadoop.hbase.wal > [+] WALKey.getBuilder ( WALCellCodec.ByteStringCompressor compressor ) : > WALProtos.WALKey.Builder 1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18733) [compat 1-2] Hide WALKey
[ https://issues.apache.org/jira/browse/HBASE-18733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163769#comment-16163769 ] Hudson commented on HBASE-18733: FAILURE: Integrated in Jenkins build HBase-2.0 #504 (See [https://builds.apache.org/job/HBase-2.0/504/]) HBASE-18733 [compat 1-2] Hide WALKey (stack: rev 41ff7d4c6b9a71912a7313055ba288e57f0dfb30) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALKey.java > [compat 1-2] Hide WALKey > > > Key: HBASE-18733 > URL: https://issues.apache.org/jira/browse/HBASE-18733 > Project: HBase > Issue Type: Sub-task > Components: API >Reporter: stack >Assignee: Sean Busbey > Fix For: 2.0.0-alpha-3 > > Attachments: 18733.txt > > > It has all the below issues and it uses our internal PB. See head of class > where it says it should go away... > hbase-server-1.0.0.jar, WALEdit.class > package org.apache.hadoop.hbase.regionserver.wal > [−] WALEdit.getCompaction ( Cell kv ) [static] : > WALProtos.CompactionDescriptor 1 > org/apache/hadoop/hbase/regionserver/wal/WALEdit.getCompaction:(Lorg/apache/hadoop/hbase/Cell;)Lorg/apache/hadoop/hbase/protobuf/generated/WALProtos$CompactionDescriptor; > ChangeEffect > 1 Return value type has been changed from > org.apache.hadoop.hbase.protobuf.generated.WALProtos.CompactionDescriptor to > org.apache.hadoop.hbase.shaded.protobuf.generated.WALProtos.CompactionDescriptor. > This method has been removed because the return type is part of the method > signature. A client program may be interrupted by NoSuchMethodError exception. > [+] WALEdit.getFlushDescriptor ( Cell cell ) [static] : > WALProtos.FlushDescriptor 1 > [+] WALEdit.getRegionEventDescriptor ( Cell cell ) [static] : > WALProtos.RegionEventDescriptor 1 > hbase-server-1.0.0.jar, WALKey.class > package org.apache.hadoop.hbase.wal > [+] WALKey.getBuilder ( WALCellCodec.ByteStringCompressor compressor ) : > WALProtos.WALKey.Builder 1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18733) [compat 1-2] Hide WALKey
[
https://issues.apache.org/jira/browse/HBASE-18733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160744#comment-16160744
]
stack commented on HBASE-18733:
---
WALKey, @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.REPLICATION),
changed a bunch for 2.0.0, so much so, we figured it ok purging it since it was
a useless class anyways and CPs using it had to change anyways.
Here is list of changes in 2.0.0 for completeness sake.
Additions:
{code}
hbase-server-3.0.0-SNAPSHOT.jar, WALKey.class
package org.apache.hadoop.hbase.wal
WALKey.estimatedSerializedSizeOf ( ) : long
org/apache/hadoop/hbase/wal/WALKey.estimatedSerializedSizeOf:()J
WALKey.getBuilder ( WALCellCodec.ByteStringCompressor compressor ) :
WALProtos.WALKey.Builder
org/apache/hadoop/hbase/wal/WALKey.getBuilder:(Lorg/apache/hadoop/hbase/regionserver/wal/WALCellCodec$ByteStringCompressor;)Lorg/apache/hadoop/hbase/shaded/protobuf/generated/WALProtos$WALKey$Builder;
WALKey.getReplicationScopes ( ) : NavigableMap
org/apache/hadoop/hbase/wal/WALKey.getReplicationScopes:()Ljava/util/NavigableMap;
WALKey.init ( byte[ ] encodedRegionName, TableName tablename, long logSeqNum,
long now, List clusterIds, long nonceGroup, long nonce,
MultiVersionConcurrencyControl mvcc, NavigableMap
replicationScope ) : void
org/apache/hadoop/hbase/wal/WALKey.init:([BLorg/apache/hadoop/hbase/TableName;JJLjava/util/List;JJLorg/apache/hadoop/hbase/regionserver/MultiVersionConcurrencyControl;Ljava/util/NavigableMap;)V
WALKey.readFieldsFromPb ( WALProtos.WALKey walKey,
WALCellCodec.ByteStringUncompressor uncompressor ) : void
org/apache/hadoop/hbase/wal/WALKey.readFieldsFromPb:(Lorg/apache/hadoop/hbase/shaded/protobuf/generated/WALProtos$WALKey;Lorg/apache/hadoop/hbase/regionserver/wal/WALCellCodec$ByteStringUncompressor;)V
WALKey.serializeReplicationScope ( boolean serialize ) : void
org/apache/hadoop/hbase/wal/WALKey.serializeReplicationScope:(Z)V
WALKey.setSequenceId ( long sequenceId ) : void
org/apache/hadoop/hbase/wal/WALKey.setSequenceId:(J)V
WALKey.WALKey ( byte[ ] encodedRegionName, TableName tablename, long logSeqNum,
long now, List clusterIds, long nonceGroup, long nonce,
MultiVersionConcurrencyControl mvcc, NavigableMap
replicationScope )
org/apache/hadoop/hbase/wal/WALKey."":([BLorg/apache/hadoop/hbase/TableName;JJLjava/util/List;JJLorg/apache/hadoop/hbase/regionserver/MultiVersionConcurrencyControl;Ljava/util/NavigableMap;)V
WALKey.WALKey ( byte[ ] encodedRegionName, TableName tablename, long now,
List clusterIds, long nonceGroup, long nonce,
MultiVersionConcurrencyControl mvcc, NavigableMap
replicationScope )
org/apache/hadoop/hbase/wal/WALKey."":([BLorg/apache/hadoop/hbase/TableName;JLjava/util/List;JJLorg/apache/hadoop/hbase/regionserver/MultiVersionConcurrencyControl;Ljava/util/NavigableMap;)V
WALKey.WALKey ( byte[ ] encodedRegionName, TableName tablename, long now,
MultiVersionConcurrencyControl mvcc, NavigableMap
replicationScope )
org/apache/hadoop/hbase/wal/WALKey."":([BLorg/apache/hadoop/hbase/TableName;JLorg/apache/hadoop/hbase/regionserver/MultiVersionConcurrencyControl;Ljava/util/NavigableMap;)V
WALKey.WALKey ( byte[ ] encodedRegionName, TableName tablename, long now,
NavigableMap replicationScope )
org/apache/hadoop/hbase/wal/WALKey."":([BLorg/apache/hadoop/hbase/TableName;JLjava/util/NavigableMap;)V
WALKey.WALKey ( NavigableMap replicationScope )
org/apache/hadoop/hbase/wal/WALKey."":(Ljava/util/NavigableMap;)V
{code}
Removed methods:
{code}
hbase-server-1.2.7-SNAPSHOT.jar, WALKey.class
package org.apache.hadoop.hbase.wal
WALKey.getBuilder ( WALCellCodec.ByteStringCompressor compressor ) :
WALProtos.WALKey.Builder
org/apache/hadoop/hbase/wal/WALKey.getBuilder:(Lorg/apache/hadoop/hbase/regionserver/wal/WALCellCodec$ByteStringCompressor;)Lorg/apache/hadoop/hbase/protobuf/generated/WALProtos$WALKey$Builder;
WALKey.getScopes ( ) : NavigableMap
org/apache/hadoop/hbase/wal/WALKey.getScopes:()Ljava/util/NavigableMap;
WALKey.getSequenceId ( long maxWaitForSeqId ) : long
org/apache/hadoop/hbase/wal/WALKey.getSequenceId:(J)J
WALKey.init ( byte[ ] encodedRegionName, TableName tablename, long logSeqNum,
long now, List clusterIds, long nonceGroup, long nonce,
MultiVersionConcurrencyControl mvcc ) : void
org/apache/hadoop/hbase/wal/WALKey.init:([BLorg/apache/hadoop/hbase/TableName;JJLjava/util/List;JJLorg/apache/hadoop/hbase/regionserver/MultiVersionConcurrencyControl;)V
WALKey.readFieldsFromPb ( WALProtos.WALKey walKey,
WALCellCodec.ByteStringUncompressor uncompressor ) : void
org/apache/hadoop/hbase/wal/WALKey.readFieldsFromPb:(Lorg/apache/hadoop/hbase/protobuf/generated/WALProtos$WALKey;Lorg/apache/hadoop/hbase/regionserver/wal/WALCellCodec$ByteStringUncompressor;)V
[jira] [Commented] (HBASE-18733) [compat 1-2] Hide WALKey
[ https://issues.apache.org/jira/browse/HBASE-18733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160666#comment-16160666 ] Sean Busbey commented on HBASE-18733: - works for me. > [compat 1-2] Hide WALKey > > > Key: HBASE-18733 > URL: https://issues.apache.org/jira/browse/HBASE-18733 > Project: HBase > Issue Type: Sub-task > Components: API >Reporter: stack >Assignee: Sean Busbey > Fix For: 2.0.0-alpha-3 > > > It has all the below issues and it uses our internal PB. See head of class > where it says it should go away... > hbase-server-1.0.0.jar, WALEdit.class > package org.apache.hadoop.hbase.regionserver.wal > [−] WALEdit.getCompaction ( Cell kv ) [static] : > WALProtos.CompactionDescriptor 1 > org/apache/hadoop/hbase/regionserver/wal/WALEdit.getCompaction:(Lorg/apache/hadoop/hbase/Cell;)Lorg/apache/hadoop/hbase/protobuf/generated/WALProtos$CompactionDescriptor; > ChangeEffect > 1 Return value type has been changed from > org.apache.hadoop.hbase.protobuf.generated.WALProtos.CompactionDescriptor to > org.apache.hadoop.hbase.shaded.protobuf.generated.WALProtos.CompactionDescriptor. > This method has been removed because the return type is part of the method > signature. A client program may be interrupted by NoSuchMethodError exception. > [+] WALEdit.getFlushDescriptor ( Cell cell ) [static] : > WALProtos.FlushDescriptor 1 > [+] WALEdit.getRegionEventDescriptor ( Cell cell ) [static] : > WALProtos.RegionEventDescriptor 1 > hbase-server-1.0.0.jar, WALKey.class > package org.apache.hadoop.hbase.wal > [+] WALKey.getBuilder ( WALCellCodec.ByteStringCompressor compressor ) : > WALProtos.WALKey.Builder 1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18733) [compat 1-2] Hide WALKey
[ https://issues.apache.org/jira/browse/HBASE-18733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160650#comment-16160650 ] stack commented on HBASE-18733: --- [~busbey] Mind if I just purge WALKey for 2.0? (HBASE-16478) Then this issue just goes away. WALKey is removed/incompatible for 2.0.0. > [compat 1-2] Hide WALKey > > > Key: HBASE-18733 > URL: https://issues.apache.org/jira/browse/HBASE-18733 > Project: HBase > Issue Type: Sub-task > Components: API >Reporter: stack >Assignee: Sean Busbey > Fix For: 2.0.0-alpha-3 > > > It has all the below issues and it uses our internal PB. See head of class > where it says it should go away... > hbase-server-1.0.0.jar, WALEdit.class > package org.apache.hadoop.hbase.regionserver.wal > [−] WALEdit.getCompaction ( Cell kv ) [static] : > WALProtos.CompactionDescriptor 1 > org/apache/hadoop/hbase/regionserver/wal/WALEdit.getCompaction:(Lorg/apache/hadoop/hbase/Cell;)Lorg/apache/hadoop/hbase/protobuf/generated/WALProtos$CompactionDescriptor; > ChangeEffect > 1 Return value type has been changed from > org.apache.hadoop.hbase.protobuf.generated.WALProtos.CompactionDescriptor to > org.apache.hadoop.hbase.shaded.protobuf.generated.WALProtos.CompactionDescriptor. > This method has been removed because the return type is part of the method > signature. A client program may be interrupted by NoSuchMethodError exception. > [+] WALEdit.getFlushDescriptor ( Cell cell ) [static] : > WALProtos.FlushDescriptor 1 > [+] WALEdit.getRegionEventDescriptor ( Cell cell ) [static] : > WALProtos.RegionEventDescriptor 1 > hbase-server-1.0.0.jar, WALKey.class > package org.apache.hadoop.hbase.wal > [+] WALKey.getBuilder ( WALCellCodec.ByteStringCompressor compressor ) : > WALProtos.WALKey.Builder 1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18733) [compat 1-2] Hide WALKey
[ https://issues.apache.org/jira/browse/HBASE-18733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159517#comment-16159517 ] stack commented on HBASE-18733: --- FYI [~busbey], would be good to get HBASE-16473 in too... If you think we should shutdown WALKey access, I can disappear it... using the [~enis] patches > [compat 1-2] Hide WALKey > > > Key: HBASE-18733 > URL: https://issues.apache.org/jira/browse/HBASE-18733 > Project: HBase > Issue Type: Sub-task > Components: API >Reporter: stack >Assignee: Sean Busbey > Fix For: 2.0.0-alpha-3 > > > It has all the below issues and it uses our internal PB. See head of class > where it says it should go away... > hbase-server-1.0.0.jar, WALEdit.class > package org.apache.hadoop.hbase.regionserver.wal > [−] WALEdit.getCompaction ( Cell kv ) [static] : > WALProtos.CompactionDescriptor 1 > org/apache/hadoop/hbase/regionserver/wal/WALEdit.getCompaction:(Lorg/apache/hadoop/hbase/Cell;)Lorg/apache/hadoop/hbase/protobuf/generated/WALProtos$CompactionDescriptor; > ChangeEffect > 1 Return value type has been changed from > org.apache.hadoop.hbase.protobuf.generated.WALProtos.CompactionDescriptor to > org.apache.hadoop.hbase.shaded.protobuf.generated.WALProtos.CompactionDescriptor. > This method has been removed because the return type is part of the method > signature. A client program may be interrupted by NoSuchMethodError exception. > [+] WALEdit.getFlushDescriptor ( Cell cell ) [static] : > WALProtos.FlushDescriptor 1 > [+] WALEdit.getRegionEventDescriptor ( Cell cell ) [static] : > WALProtos.RegionEventDescriptor 1 > hbase-server-1.0.0.jar, WALKey.class > package org.apache.hadoop.hbase.wal > [+] WALKey.getBuilder ( WALCellCodec.ByteStringCompressor compressor ) : > WALProtos.WALKey.Builder 1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
