[jira] [Commented] (HBASE-18749) Apply the TimeRange from ColumnFamily to filter the segment scanner

2017-09-04 Thread Chia-Ping Tsai (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-18749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152384#comment-16152384
 ] 

Chia-Ping Tsai commented on HBASE-18749:


bq. The issue is not using CF specific TR from Scan.
yeah, the CF specific TR is used only in matcher and 
StoreFileScanner#shouldUseScanner now.

bq. On the code, will it be better that the Segments know which Store/CF it 
belongs to. Than we pass Store instance every time into shouldSeek() method. 
Per cf we have one MS and that will have N Segments. In Compacting Memstore, 
already the Store ref is there.
That will complicate the construction of Segment...Or just pass the TImeRange 
to shouldSeek()? The impl needs only the TimeRange. We can refactor the 
shouldSeek() in the future if any policies are raised.

> Apply the TimeRange from ColumnFamily to filter the segment scanner
> ---
>
> Key: HBASE-18749
> URL: https://issues.apache.org/jira/browse/HBASE-18749
> Project: HBase
>  Issue Type: Improvement
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Minor
> Fix For: 2.0.0-alpha-3
>
> Attachments: HBASE-18749.v0.patch
>
>
> We can evict the unused segment scanner early.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18749) Apply the TimeRange from ColumnFamily to filter the segment scanner

2017-09-04 Thread Anoop Sam John (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-18749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152299#comment-16152299
 ] 

Anoop Sam John commented on HBASE-18749:


The issue is not using CF specific TR from Scan.
On the code, will it be better that the Segments know which Store/CF it belongs 
to.  Than we pass Store instance every time into shouldSeek() method.  Per cf 
we have one MS and that will have N Segments.  In Compacting Memstore, already 
the Store ref is there.  

> Apply the TimeRange from ColumnFamily to filter the segment scanner
> ---
>
> Key: HBASE-18749
> URL: https://issues.apache.org/jira/browse/HBASE-18749
> Project: HBase
>  Issue Type: Improvement
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Minor
> Fix For: 2.0.0-alpha-3
>
> Attachments: HBASE-18749.v0.patch
>
>
> We can evict the unused segment scanner early.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18749) Apply the TimeRange from ColumnFamily to filter the segment scanner

2017-09-04 Thread Chia-Ping Tsai (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-18749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152236#comment-16152236
 ] 

Chia-Ping Tsai commented on HBASE-18749:


Will commit it later.

> Apply the TimeRange from ColumnFamily to filter the segment scanner
> ---
>
> Key: HBASE-18749
> URL: https://issues.apache.org/jira/browse/HBASE-18749
> Project: HBase
>  Issue Type: Improvement
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Minor
> Fix For: 2.0.0-alpha-3
>
> Attachments: HBASE-18749.v0.patch
>
>
> We can evict the unused segment scanner early.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18749) Apply the TimeRange from ColumnFamily to filter the segment scanner

2017-09-03 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-18749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151937#comment-16151937
 ] 

Ted Yu commented on HBASE-18749:


lgtm

> Apply the TimeRange from ColumnFamily to filter the segment scanner
> ---
>
> Key: HBASE-18749
> URL: https://issues.apache.org/jira/browse/HBASE-18749
> Project: HBase
>  Issue Type: Improvement
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Minor
> Fix For: 2.0.0-alpha-3
>
> Attachments: HBASE-18749.v0.patch
>
>
> We can evict the unused segment scanner early.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18749) Apply the TimeRange from ColumnFamily to filter the segment scanner

2017-09-03 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-18749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151933#comment-16151933
 ] 

Hadoop QA commented on HBASE-18749:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
20s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
35m 53s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}108m 
25s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
19s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}159m 11s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:47a5614 |
| JIRA Issue | HBASE-18749 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12885150/HBASE-18749.v0.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  
hbaseanti  checkstyle  compile  |
| uname | Linux d51d2bcdb47b 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
 |
| git revision | master / 83175fd |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8450/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8450/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |


This message was automatically generated.



> Apply the TimeRange from ColumnFamily to filter the segment scanner
> ---
>
> Key: HBASE-18749
> URL: https://issues.apache.org/jira/browse/HBASE-18749
> Project: HBase
>  Issue Type: Improvement
>Reporter: Chia-Ping Tsai
>